August 2014 - Wine-Devel - list.winehq.org

Re: mshtml: Added IHTMLInputElement_get_form method implementation. (try 3)
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

On 07/29/14 15:34, Zhenbo Li wrote: > +#define test_input_get_form(o, t) _test_input_get_form(__LINE__, o, t) > +static void _test_input_get_form(unsigned line, IUnknown *unk, const char *id) > +{ > + IHTMLInputElement *input; > + IHTMLFormElement *form; > + IHTMLElement *elem; > + BSTR bstr; > + HRESULT hres; > + > + ok_(__FILE__,line) (unk != NULL, "unk is NULL!\n"); > + hres = IUnknown_QueryInterface(unk, &IID_IHTMLInputElement, (void**)&input); > + ok_(__FILE__,line) (hres == S_OK, "Could not get IHTMLInputElement: %08x\n", hres); > + ok_(__FILE__,line) (input != NULL, "input == NULL\n"); > + if(FAILED(hres) || input == NULL) > + return; > + > + hres = IHTMLInputElement_get_form(input, &form); > + ok_(__FILE__, line) (hres == S_OK, "get_form failed: %08x\n", hres); > + ok_(__FILE__, line) (form != NULL, "form == NULL\n"); > + if(FAILED(hres) || form == NULL){ > + IHTMLInputElement_Release(input); > + return; > + } > + > + hres = IHTMLFormElement_QueryInterface(form, &IID_IHTMLElement, (void **)&elem); > + ok_(__FILE__, line) (hres == S_OK, "QueryInterface(IID_IHTMLElement) failed: %08x\n", hres); > + ok_(__FILE__, line) (elem != NULL, "elem == NULL\n"); > + if(FAILED(hres) || elem == NULL){ > + IHTMLInputElement_Release(input); > + IHTMLFormElement_Release(form); > + return; > + } > + hres = IHTMLElement_get_id(elem, &bstr); > + ok_(__FILE__, line) (hres == S_OK, "get_id failed: %08x\n", hres); > + ok_(__FILE__, line) (!strcmp_wa(bstr, id), "Expect %s, got %s\n", id, wine_dbgstr_w(bstr)); Please use _test_elem_id instead. Cheers, Jacek

1 0

Re: mshtml: Added IHTMLImgElement::isMap property implementation. (try 2)
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

Hi Zhenbo, On 08/11/14 08:46, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlimg.c > +++ b/dlls/mshtml/htmlimg.c > @@ -102,15 +102,37 @@ static HRESULT WINAPI HTMLImgElement_Invoke(IHTMLImgElement *iface, DISPID dispI > static HRESULT WINAPI HTMLImgElement_put_isMap(IHTMLImgElement *iface, VARIANT_BOOL v) > { > HTMLImgElement *This = impl_from_IHTMLImgElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLImageElement_SetIsMap(This->nsimg, v ? TRUE : FALSE); Please avoid v?TRUE:FALSE style expressions. Cheers, Jacek

1 0

Re: [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays (resend)
by Henri Verbeet Aug. 13, 2014

Aug. 13, 2014

On 12 August 2014 02:17, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > @@ -2172,45 +2173,43 @@ intel_gl_vendor_table[] = > {GL_VENDOR_MESA, "Mesa Intel driver", cards_intel, > ARRAY_SIZE(cards_intel)}, Your mailer wrapped the patch, so it won't apply. I recommend using git send-email for sending patches. > +C_ASSERT(NUMELMS(card_fallback_nvidia) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_amd) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_intel) == WINED3D_D3D_LEVEL_COUNT); ... > + enum wined3d_pci_device *card_fallback; /* An array with D3D_LEVEL_COUNT > elements */ I also strongly suspect that even if the patch did apply, it would either generate warnings or just fail to compile.

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Marvin Aug. 12, 2014

Aug. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8473 Your paranoid android. === w8 (32 bit pipe) === pipe.c:540: Test failed: can't open pipe, GetLastError: e7 pipe.c:616: Test failed: can't open pipe, GetLastError: e7

1 0

Re: (resend)[2/5]dwrite: Initial implementation of CreateCustomFontFileReference
by Marvin Aug. 12, 2014

Aug. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8468 Your paranoid android. === build (build) === Patch failed to apply

1 0

RE. [1/5]dwrite: Implement Font File Loader registration
by Aric Stewart Aug. 12, 2014

Aug. 12, 2014

Sorry, I missed this e-mail... I got a bit sloppy with some of my tests. I will clean those up. >> +static HRESULT WINAPI fontfileloader_CreateStreamFromKey(IDWriteFontFileLoader *iface, const void *fontFileReferenceKey, UINT32 fontFileReferenceKeySize, IDWriteFontFileStream **fontFileStream) >> +{ >> + return 0x8faecafe; > > I'm sure this works, but it's cleaner to return E_FAIL/E_NOTIMPL imho. The point of that part of the test is to show that the error code returned from CreateStreamFromKey is passed down to CreateFontFace. -aric

1 0

Re: dmscript/tests: Initialize test variable (valgrind)
by Bruno Jesus Aug. 12, 2014

Aug. 12, 2014

On Sat, Aug 9, 2014 at 8:40 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=36809 I see the patch is in pending state but I don't know what is expected. Can anyone help me? http://source.winehq.org/patches/data/105943 Best regards, Bruno

2 1

Re: wined3d: add support for AMD Radeon HD7750
by Henri Verbeet Aug. 11, 2014

Aug. 11, 2014

On 11 August 2014 02:23, Austin English <austinenglish(a)gmail.com> wrote: > + {HW_VENDOR_AMD, CARD_AMD_RADEON_HD7750, "AMD Radeon HD 7750 Series", DRIVER_AMD_R600, 1024}, This is suspicious, all recent discrete Radeon's have had descriptions of the form "AMD Radeon HD 7700 Series". Is this based on what the Windows driver actually returns? > + {"HD 7750", CARD_AMD_RADEON_HD7750}, Similarly, I'd expect fglrx to call this card "AMD Radeon HD 7700 Series". Is this based on actual fglrx glxinfo output? > + {"CAPE VERDE PRO", CARD_AMD_RADEON_HD7750}, This is just wrong. The radeonsi driver doesn't return "CAPE VERDE PRO" for any card.

1 0

Re: mshtml: Added IHTMLStyle::lineStylePosition property implementation.
by Marvin Aug. 10, 2014

Aug. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8406 Your paranoid android. === w2000pro (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === wxppro (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === wvistau64 (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === w2008s64 (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === w7u (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === w8 (32 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === wvistau64 (64 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null) === w2008s64 (64 bit style) === style.c:2127: Test failed: Expects E_INVALIDARG, got 00000000 style.c:2132: Test failed: listStyleType = (null)

1 0

Re: mshtml: Added IHTMLStyle::lineStylePosition property implementation.
by Zhenbo Li Aug. 10, 2014

Aug. 10, 2014

Sorry, this is a bad patch. Please just ignore it, thanks. 2014-08-10 20:11 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > --- > dlls/mshtml/htmlstyle.c | 15 +++++++++++---- > dlls/mshtml/htmlstyle.h | 1 + > dlls/mshtml/tests/style.c | 14 +++++++++++--- > 3 files changed, 23 insertions(+), 7 deletions(-) > > -- Have a nice day! Zhenbo Li

1 0

Re: [PATCH 2/2] vbscript: Implemented Time
by Marvin Aug. 10, 2014

Aug. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8405 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] vbscript: Implemented Date
by Marvin Aug. 10, 2014

Aug. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8404 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] ddraw: Return empty D3D hardware flags for RGB device enumeration (try 2).
by Stefan Dösinger Aug. 9, 2014

Aug. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-08 17:45, schrieb Erich E. Hoover: > Per Henri's request this now also tests the Ramp and MMX devices. > I also tried to test for Ref devices, but the testbot and the > machine available to me didn't have a Ref device. To get the REF device for d3d7 and earlier you have to install the DirectX 7 sdk. This installs a system control applet that allows you to enable REF device enumeration. I don't think it's worth bothering. I don't even know if the REF device still works on a modern Windows. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT5mncAAoJEN0/YqbEcdMwaEQP/A0/Y5o15v0WOOUk+k+ocDRh Vuf1FH6aKxPbKOF0HgEJsjKQyO+QUl3J1KZsqQeXtWaFTDa2Npki3LfoiAxBr4Gc l9EoRF7prVW/L+gAlqUvpQzpSEO0pjDvl1IFrMH/HNL4IMDeo7e8H+JRXUO5mVfJ bGO8WXJucNPwkzcQzMzgt8ycVP30uBCTS7vkCwG3J++HmTiChby0W7XPI5Q6n2T1 Gi00Z1RhLDb6HcTCPzwdIi/v7BpEOOMv0/U+CaoSZGQhxHWDTxtLVXehHwzHhX3p 86lUe906qjPmdTWsTpuiRcCWzRfbi/GQyXx04rDxKdb6/LfT5kDMhViLYeoGo0VZ YIQVe1eFHJ/LhpGZCMrZ/sv3DMIUfINZuzo/eYOLsA+ehdz7CPjLul2gqwL+8EKT kSwX2ptw8KlaOnLrcRxShU9OrUvbUeM4Ui6k+kAeZJyBRLbZbKCgq0EiNgtVN+IZ ul+Us3sR6jCo7qdrF2k1Ia39LxGLlOcP2TeyloJ14zKv8/zCkqlPwu3xGWGyl2EX qtnrDbhztL8Y12IDkCIkNULdqQ0Oxj/rOmVACDKgptLOlpfiq8fC98o7QgDdmYcc vLxu0q+7At5qQHLGPtaqNEa/GqkJ/OEM2abXGMMLVnPHx6tOwk+BnapZTbKKxKql WaQCwW4eBNX9BWqhAxTw =od4v -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] ddraw/tests: Remove broken tests of D3DTRANSFORM_UNCLIPPED.
by Stefan Dösinger Aug. 9, 2014

Aug. 9, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-08 17:45, schrieb Erich E. Hoover: > - for(i = 0; i < sizeof(outH); i++) { > - if(((unsigned char *) outH)[i] != 0xcc) { > - ok(FALSE, "Homogeneous output was generated despite UNCLIPPED flag\n"); > - break; > - } > - } There is some more code you can remove. At least the outH memset is not needed. I'd say you can also remove the second call to TransFormVertices. The difference between the first and second call is pretty minor now. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT5me/AAoJEN0/YqbEcdMwzn0P/RXdxutD01EhhYD2J0sUnjPZ uiAI+xj64mjMLF8WYByNSZc5e6HSRVR6cOvX8ZBQM2WSHgpcdiL0/GfnsRS21nTq pQDf9qqNMoUczVrJkt/RjvkINKESINuOWOmTK1eweS1RXB+Yto0PjdMXFJ8gnZc0 vq1Hqobv+zkwaGJ0jw8T3WFNJ2U7hY9eKmM61MetliqtA8rgkhilkZIcneXovW93 gxFQFIh90FgZzwudgUAIYk6s1aAf0EzaI1IPUGb9jr7GOrnH8Z2jOtK0ird+dLtb mbaTxjhUTzD37EYfOO+bvUOjxRDrboxSq4p/sRuXg0ZHCYP/tuSSP4HHzajOaHkc 1Z148lL7aG4PCRswLyQufJgqbVAr99axoSIivAOkObDXNVoaypCt63He6ctjq8e3 fwnmPhRfofZTL2a2arvP1Prvf3vcvvhF1zgLudNE5dlZr5VqiNJ64yf6zJfmN3Gf ad8qXyaq15f/BjfRamqlhyk5hXomfnTv3dQcUDa37FwYz01XR+24E031R207vqqc kiNxppo1s5+ri66VoEormjWBxhHwHfO2cYsjT3plsY9kVIy8B1cWDXBQLkZKaPhU kZlHD3gG01i8QrZ0c1YbZAwWdTLZUCqykH3RJGhUKKz68ELxOHZfT49BuByVRz8a gMPX2hwrcAQPQGMx/K6u =SA6e -----END PGP SIGNATURE-----

1 0

Re: [PATCH 7/7] vbscript: Implemented Atn
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8386 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] vbscript: Implemented Sqr
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8385 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/7] vbscript: Implemented Log
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8384 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/7] vbscript: Implemented Exp
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8383 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/7] vbscript: Implemented Tan
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8382 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/7] vbscript: Implemented Sin
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8381 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos
by Marvin Aug. 9, 2014

Aug. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8380 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] vbscript: Implemented ScriptEngineMinorVersion(try 2)
by Marvin Aug. 8, 2014

Aug. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8363 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/4] vbscript: Implemented ScriptEngineMajorVersion(try 2)
by Marvin Aug. 8, 2014

Aug. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8362 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/4] vbscript: Inplemented ScriptEngineBuildVersion(try 2)
by Marvin Aug. 8, 2014

Aug. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8361 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] vbscript: Implemented ScriptEngine(try 2)
by Marvin Aug. 8, 2014

Aug. 8, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8360 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0