August 2014 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Wine 64 bit
by Kevin Davies June 5, 2015

June 5, 2015

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

[RFC 0/11] Linux FF: Intro
by Elias Vanderstuyft Sept. 7, 2014

Sept. 7, 2014

Hi, This is the sequel of the mail with title: "Discussion and Improvement of Wine's Linux Force Feedback implementation". This mail is meant to give an introduction to the next 11 mails: All tests were performed using wine-1.7.11-206-g82b3813 (but none of the files of which I propose changes to be made in, are affected in the current (2014-03-04) wine-version 1.7.13) Because I haven't created any (formal) patch yet (and instead first request for comments), I tried to keep the line numbers to reference the affected files more or less based to the version I started from, where I could. However, the orig code of a (informal) patch that has to be applied after (and thus is dependent of) a previous patch, may be different from the initial code of the wine-version I started from. After having discussed everything, I will send a proper patchset. In these mails, sometimes 'FEdit' is mentioned: it's a MS application that allows to create all FF effect types (except CustomForce and rumble/vibration effects), and therefore the ideal test application. Physical behavior is compared between Windows7 (using Logitech MOMO wheel with latest drivers installed) running in Virtualbox, and my patched Wine-version. In the end, (using a dummy FF driver on the Linux side, thanks to Michal Malý), the behavior of Wine is almost (limitations caused by the dummy ff driver, such as updating an effect while playing is not implemented) identical, if not better (in some aspects) then the Windows equivalent. Sometimes I refer to linux-input mailing lists to prove a statement, because the links may vanish (unlikely though), I provide the titles corresponding with the links: (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08513.html) "ff-core effect id handling in case of a failed effect upload" (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html) "Questions about the documentation/specification of Linux ForceFeedback input.h" Subjects [11] ------------- - Joystick control panel program [2] - Linux effect status management [3] - Linux effect parameter: start delay [1] - Linux effect parameter: periodic effect's phase [1] - Linux effect parameters: time parameters [3] - Linux effect: conditional effect's parameters [2] - Linux effect: axes [1] - Linux effect direction [7] - Linux effect parameters (global) [6] - Linux joystick initialization [1] - Debug message fixes/additions [6] Elias

2 3

Wine test analysis August 28th
by Jeremy White Sept. 1, 2014

Sept. 1, 2014

Hi Folks, Good news - we've made progress! We're down to only 25 issues. I have now annotated every single failure: https://www.winehq.org/~jwhite/5aeb834dd4e7.html (although some of my annotations are out of date). It looks like the biggest win will come if Francois and Hans can figure out the msi timing stuff. I think there are a number of ones that might be 'easy': http://test.winehq.org/data/tests/gdi32:font.html Bug 35573, 35760, fails in certain locales http://test.winehq.org/data/tests/mmdevapi:capture.html I asked Jorg, but he may have a hard time getting to it. It's nice and consistent... http://test.winehq.org/data/tests/shell32:shlexec.html Nice and consistent; asked Misha to look into it, but he can't. http://test.winehq.org/data/tests/user32:sysparams.html Nice and consistent; I'd invited Frederic to work on this one, but looks like he could use help... Don't be shy, there are plenty of consistent failures to go around! From there, I think nudging Jacek, Nikolay, and Huw will get us our next big set of wins. Nudge, nudge, nudge. Cheers, Jeremy p.s. Reminder: my analysis always shows up at http://winehq.org/~jwhite/latest.html

5 5

Re: [PATCH 2/5] comdlg32: Implement calling IFileDialogEvents::OnTypeChange().
by Marvin Aug. 31, 2014

Aug. 31, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8725 Your paranoid android. === wvistau64 (64 bit itemdlg) === itemdlg.c:1210: Test failed: Got 5

1 0

Re: [PATCH 1/5] comdlg32/tests: Add some IFileDialogEvents tests.
by Marvin Aug. 31, 2014

Aug. 31, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8724 Your paranoid android. === wvistau64 (32 bit itemdlg) === itemdlg.c:1210: Test failed: Got 3 === wvistau64 (64 bit itemdlg) === itemdlg.c:1210: Test failed: Got 5

1 0

Re: [PATCH] mshtml: Add IHTMLTableCell::bgColor property implementation.
by Jacek Caban Aug. 29, 2014

Aug. 29, 2014

Hi Jactry, On 08/29/14 17:17, Jactry Zeng wrote: > --- a/dlls/mshtml/htmltablecell.c > +++ b/dlls/mshtml/htmltablecell.c > @@ -174,15 +174,47 @@ static HRESULT WINAPI HTMLTableCell_get_vAlign(IHTMLTableCell *iface, BSTR *p) > static HRESULT WINAPI HTMLTableCell_put_bgColor(IHTMLTableCell *iface, VARIANT v) > { > HTMLTableCell *This = impl_from_IHTMLTableCell(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); > - return E_NOTIMPL; > + nsAString strColor; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); > + > + nsAString_InitDepend(&strColor, V_BSTR(&v)); > + variant_to_nscolor(&v, &strColor); Please handle variant_to_nscolor errors here. Jacek

2 1

Implementation of IDwriteFactory::CreateCustomFontCollection
by Guillaume Charifi Aug. 29, 2014

Aug. 29, 2014

Hello, I heard you are working on IDwriteFactory::CreateCustomFontCollection implementation, so I attached my current work, if it can help. It's almost done, just this part, retrieving the font family name to effectively save it, is to be implemented (even if Adobe Creative Cloud works with this changes): + if(!This->families) { + This->count = 1; + This->alloc = 1; + This->families = heap_alloc(This->alloc * sizeof(WCHAR *)); + This->families[0] = heap_strdupW((const WCHAR[]){'d','u','m','m','y',0}); + } else { + add_family_syscollection(This, (const WCHAR[]){'d','u','m','m','y',0}); + } In the hope it could be useful, Regards

1 0

Re: [2/2] winemenubuilder: ignore icons in unsupported PNG format
by Indrek Altpere Aug. 29, 2014

Aug. 29, 2014

Ah, indeed, my bad for not digging deep enough to the windowscodecs code and jumping to assumptions based on BITMAPINFO. Thanks for catching that, and as I can see on patches page the invalid patch is already marked as rejected. Regards, Indrek

1 0

Re: include: add EncryptedFileRaw functions and defines (try 2)
by Michael Stefaniuc Aug. 28, 2014

Aug. 28, 2014

On 08/28/2014 12:37 AM, Austin English wrote: > Splitting from https://source.winehq.org/patches/data/106010 for easier > review And the patch? bye michael

2 1

Re: [2/2] winemenubuilder: ignore icons in unsupported PNG format
by Damjan Jovanovic Aug. 28, 2014

Aug. 28, 2014

Please don't commit this patch, it's unnecessary. PNG support is not "missing": winemenubuilder supports PNG icons just fine and has for many years (IIRC, from .ico files and "valid" .exes/.dlls): it's implemented by using windowscodecs (starting from IWICImagingFactory_CreateDecoderFromStream() called from convert_to_native_icon()) which auto-detects the file format. In the case of PNG, that BITMAPINFO *pIcon pointer may not point to a valid BITMAPINFO structure, but who cares, the fields of that structure are never accessed, only opaquely memcpy()'ed en-masse. Using void* or BYTE* instead of BITMAPINFO* might be clearer, but the semantics are the same. I've tested Stepmania 5, one of the problematic apps from #19241, and winemenubuilder creates working 256x256 PNG icons when the previous patch is applied and this one isn't. Otherwise thank you for your contribution Indrek. Regards Damjan On Thu, Aug 28, 2014 at 6:09 PM, Indrek Altpere <efbiaiinzinz(a)hotmail.com> wrote: > While fixing https://bugs.winehq.org/show_bug.cgi?id=19241 I saw that > winemenubuilder does not handle/ignore png icon entries currently. > > As per MSDN blog, icon resources can contain raw PNG information instead of > regular BITMAPINFO, but due to weird decisions, only way to differentiate > between them is to check if the resource starts with PNG header bytes. > http://blogs.msdn.com/b/oldnewthing/archive/2010/10/22/10079192.aspx > Made the winemenubuilder ignore such entries for now (with fixme notices), > since using PNG raw bytes as BITMAPINFO data is definitely invalid and is > due to cause other issues/crashes when the best matching size icon happens > to be PNG. A new bug should be opened for the missing PNG support. > > Regards, > Indrek > > >

1 0

Re: wpcap: Load libpcap dynamically
by Alexandre Julliard Aug. 28, 2014

Aug. 28, 2014

André Hentschel <nerv(a)dawncrow.de> writes: > This is intended for packagers, without this patch libpcap easily becomes a fixed dependency of wine. > Something we don't want i guess. It's only used for wpcap, which can't work without it anyway, so I don't see any need to make it dynamic. -- Alexandre Julliard julliard(a)winehq.org

7 10

Re: winemenubuilder: fix crash caused by invalid icon entries and avoid future crashes by ignoring unhandled png entries (resend)
by Akihiro Sagawa Aug. 28, 2014

Aug. 28, 2014

On Thu, 28 Aug 2014 09:30:34 +0300, Indrek Altpere wrote: > Forgot to link to the bug before, also added more detailed description. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=19241 > > For the InnoSetup 5 crash (and likely other similar reported crashes), the > issue seems to be GRPICONDIRENTRY with invalid information. (...) > As per MSDN blog, icon resources can contain raw PNG information instead of > regular BITMAPINFO, but due to weird decisions, only way to differentiate > between them is to check if the resource starts with PNG header bytes. > http://blogs.msdn.com/b/oldnewthing/archive/2010/10/22/10079192.aspx > Made the winemenubuilder ignore such entries for now (with fixme notices), > since using PNG raw bytes as BITMAPINFO data is definitely invalid and is > due to cause other issues/crashes when the best matching size icon happens > to be PNG. A new bug should be opened for the missing PNG support. Hello Indrek, I think your patch looks nice, but needs to split into two or more parts. This means one for invalid GRPICONDIRENTRY issue and one for PNG entry's enhancement. If you do this, it will be easier to read and easier to pass. For details, please read our Patch Submission Guidelines[1], especially Code Guidelines section. [1] http://wiki.winehq.org/SubmittingPatches Regards, Akihiro Sagawa

1 0

Re: [1/2] netcfgx: Add stub for INetCfgComponent
by Alistair Leslie-Hughes Aug. 28, 2014

Aug. 28, 2014

On 28/08/2014 6:39 AM, André Hentschel wrote: > --- > dlls/netcfgx/netcfg.c | 148 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 148 insertions(+) > Your missing tests to show that this interface exist. Same goes for INetCfgClassSetup2. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/5] dxgi: Free the wined3d object when device creation fails (Valgrind).
by Henri Verbeet Aug. 27, 2014

Aug. 27, 2014

On 27 August 2014 18:40, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/dxgi/device.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/dxgi/device.c b/dlls/dxgi/device.c > index 837c57f..0f3ae7d 100644 > --- a/dlls/dxgi/device.c > +++ b/dlls/dxgi/device.c > @@ -350,7 +350,7 @@ HRESULT dxgi_device_init(struct dxgi_device *device, struct dxgi_device_layer *l > IWineDXGIDeviceParent *dxgi_device_parent; > IWineDXGIAdapter *wine_adapter; > UINT adapter_ordinal; > - struct wined3d *wined3d; > + struct wined3d *wined3d = NULL; > void *layer_base; > HRESULT hr; > WINED3DCAPS caps; > @@ -430,6 +430,12 @@ fail: > wined3d_device_decref(device->wined3d_device); > LeaveCriticalSection(&dxgi_cs); > } > + else if (wined3d) > + { > + EnterCriticalSection(&dxgi_cs); > + wined3d_decref(wined3d); > + LeaveCriticalSection(&dxgi_cs); > + } I don't think this works as intended. For example, if IDXGIAdapter_QueryInterface() fails, you'd call wined3d_decref() twice. There's also a wined3d_decref() after wined3d_device_create(), although it's indeed missing for IWineDXGIDevice_QueryInterface() and wined3d_get_device_caps().

2 1

Re: [PATCH 5/5] d3dx9: Correctly handle out of memory conditions while reallocating children array.
by Henri Verbeet Aug. 26, 2014

Aug. 26, 2014

On 26 August 2014 16:13, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -338,15 +338,20 @@ static HRESULT d3dx9_file_data_create(IDirectXFileObject *dxfile_object, ID3DXFi > > while (SUCCEEDED(ret = IDirectXFileData_GetNextObject(object->dxfile_data, &data_object))) ... > + new_children = HeapReAlloc(GetProcessHeap(), 0, object->children, > + sizeof(*object->children) * (object->nb_children + 1)); While I suspect this is hardly the only thing wrong with xfile.c, it seems suboptimal to grow the array by 1 each time you go through the loop.

2 2

Re: [PATCH 2/5] comdlg32: Implement calling IFileDialogEvents::OnTypeChange().
by Alexandre Julliard Aug. 25, 2014

Aug. 25, 2014

David Hedberg <david.hedberg(a)gmail.com> writes: > @@ -1652,6 +1666,11 @@ static LRESULT on_command_filetype(FileDialogImpl *This, WPARAM wparam, LPARAM l > } > CoTaskMemFree(filename); > } > + > + /* The documentation claims that OnTypeChange is called only > + * when the dialog is opened, but this is obviously not the > + * case. */ > + events_OnTypeChange(This); It would be more obvious with a test case... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] vbscript: Implemented Time(try 3)
by Marvin Aug. 25, 2014

Aug. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8660 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 3)
by Marvin Aug. 25, 2014

Aug. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8659 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Nikolay Sivov Aug. 24, 2014

Aug. 24, 2014

On 8/23/2014 19:38, Shuai Meng wrote: > + GetLocalTime(&lt); > + ud.st = lt; > + VarDateFromUdateEx(&ud, 0, VAR_DATEVALUEONLY, &date); > + return return_date(res, date); It's better to init 'wDayOfYear' part too, even if it's not used internally +variant will show its garbage value. Also I'm not sure about ignoring return value of VarDateFromUdateEx().

2 1

Re: configure: Add -linotify when present, for non-Linux platforms.
by Alexandre Julliard Aug. 23, 2014

Aug. 23, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > A FreeBSD user ran into this when sys/inotify.h was present via an > extra package and Wine went ahead using that, only to fail at link- > time. We'd want to use kqueue instead on FreeBSD. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)
by Marvin Aug. 23, 2014

Aug. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8634 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Marvin Aug. 23, 2014

Aug. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8633 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/5] wined3d: Also update the container in wined3d_surface_update_desc().
by Stefan Dösinger Aug. 22, 2014

Aug. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet: > This fixes a bug exposed by commit > 415b8037206b1d4c104d9623037458739f6cfdf5. In particular, > wined3d_resource_update_draw_binding() uses the multisample type to > determine to appropriate draw binding, and since we never updated > that for the container, we could end up with an incorrect draw > binding after a device reset. Why not move this call to the texture entirely? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yAyAAoJEN0/YqbEcdMwkEsP/juiBeX/o8Pj7hLFs/svF7/U 5fIjBxWSnSq/+WA0/g4OkoIPJoTp+qXjj3irv3r8JCZVTDR455pMDnBZ0yTa+jQa VEF9HvELIurpZz6qOP2UTISD2u2VizzTG74AO8dM+gGYTtX4kPa1+H3QdY7BA2nN XxWW7wGvH5sCzxPh8yx7m8p+vSKzlUQnSuNRoFK+RFLL/VtSeUBsk5OVwuv99LGw lc7DsNH7yKsfG+V5rXyWmgZQsTJDqnlaS+3t5XlqBfdBYuv5JbreUDwdlelbBcmi MWqOdFGVxw60TM7Ra/FXITse9J62lhxjZMyP5nc8nrDp9o6Ci7ynFAzev4FsK6qz eTYj+WRwmsiIKMFPKzx69vz90/ZjdhKM68LPmVythfcB4Cx3YekhME/e7QX0+wZE VBNhZB6VnP7B6BO3tPl8RxMOFzLuFmpgzH2UZevhQVOQximH343CzU0ejf5t0o5Z vkjryDR7QxWE73Ru1p+Sx2b0c81eQtzG+SeDKyjDLLJbVCvFWytj6khUuekupPzF VKHn///AO14pYD1qgRFN4g/FblS792WbXsufV4xDpEsfokoV7E/t8f8vDAoR7FFi rDoP290L95rc9t3ltFW1bVaiKKRrT6mslPZ6e9wR1un7kC9AlfeOiQn8sAVUT3O5 zl9+g1wfTHod4Mi7Sr5J =PO4N -----END PGP SIGNATURE-----

2 1

Re: [PATCH 3/5] wined3d: Get rid of wined3d_device_color_fill().
by Stefan Dösinger Aug. 22, 2014

Aug. 22, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-22 12:32, schrieb Henri Verbeet: > + if (desc.pool != WINED3D_POOL_DEFAULT && desc.pool != WINED3D_POOL_SYSTEM_MEM) > + { > + WARN("Color-fill not allowed on surfaces in pool %#x.\n", desc.pool); > + return D3DERR_INVALIDCALL; > + } I realize that this just keeps existing code in place, but as far as I can see this check is redundant. There's already a somewhat strange check right above this one that tests if the surface is a render target or in WINED3D_POOL_DEFAULT. Unless I missed a way to create a non-default pool render target testing only for WINED3D_POOL_DEFAULT should be enough. The patch also works only as long as we keep the D3DUSAGE_RENDERTARGET check in wined3d_device_set_rendertarget_view and not move it to wined3d_rendertarget_view_create. Is that your intention? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9yX4AAoJEN0/YqbEcdMw5i4P/Ao5NQVk+CMZtE6wAenF/YIx V/NuOHczkC1qnXt74CkZe96o/HukbpoyyQ3uKlDnEzgwN8OrJUfwL3kVq6N9llqu MaYGH0a4P/Ib+ZROouuolNcOFSsgjyHvTnZmHQUONhpzURnmLNdUzoKyfrZTKrwe XtIk4prgEMny5W9Oae0eniYHeVv3Gyvg1jtSoviO/KT/fys5Bb+3xW1Voi7ARPWj Ylm+D61JIQotblAcJVon4JElegbS4ENnziRSJM2774VaCaEpFOkCJ+0e3ZDzgqBQ SjGbuLURL48HHYHKzCBEy9zpTiWr40cLjwm/h6f35koHl3IjHofFuxQPxOLqVDFt L/BsdTUNKFL6EkvalC5ObdFUvgkX+1tx60h4vllue1sFbBIZRkISARoc1Q+HAwJE 4B2Ktwlwy0w2fuy8Ml7j3X8g+wqyPkCpaoFcKtauELFBkY/eqn+HFmoRAJTa2oMb ps3d79EbeRPEVhh9NOOqAAkMuA+ztr52uEbKgq7PS0PzcFIvyECTBWxSnAEjw+d8 CKRk6HGC/v8Jo4Vqw/SzDTYRM/bO5sdvgMulux0zSAJuBZe+YGIcl2d0akT6MYQf 615tmoVbSfR3FY2e7SaMXqfXMLMEZzkQWjRy0A+Zs1+sPycobS3/Q7YjOmhW6goC KQGqfd79P2SuiuAbvlue =h6dU -----END PGP SIGNATURE-----

2 1

Tesing list, ignore
by Jeremy Newman Aug. 21, 2014

Aug. 21, 2014

I'm a test post. Move along....

1 1

Re: [PATCH 5/5] wined3d: Use rendertarget views for color output instead of surfaces.
by Stefan Dösinger Aug. 21, 2014

Aug. 21, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-21 09:55, schrieb Henri Verbeet: > + if (swapchain_desc->backbuffer_count && FAILED(hr = wined3d_rendertarget_view_create_from_surface( > + surface_from_resource(wined3d_texture_get_sub_resource(swapchain->back_buffers[0], 0)), > + NULL, &wined3d_null_parent_ops, &device->back_buffer_view))) > + { > + ERR("Failed to create rendertarget view, hr %#x.\n", hr); > + goto err_out; > + } Having an implicit back buffer render target view managed by wined3d seems a bit odd. Why not let the client libraries create and set the render target view after device creation? That would be similar to what a d3d10 app does after D3D10CreateDeviceAndSwapChain. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT9huWAAoJEN0/YqbEcdMwvxMQAIcE7cZnRLTTgECUoxQMWkA5 hobDWConkMr0LGeCMt0Aw98UPsq5n7V/qivYdayudgWbt2YkrRnKq6+d7SIuaWBd QnA0q3CRpWa/v4BKfsXN7t2OKnDwwYCeQoW+qqBpentNEblxVAdh4Rh+/AQZ1Oim PjWdi0Nl31VPnRTQq/GpiHFNY87T9l46hsd5W1GfxY8gPuNxBn0P1xDDsYqG8IxQ 3GH5gw3YIk/JTlvX0nSHQbo05WCgxlGUJ+i7LMotlNth0itEBPOI8EqefEwTdfVO a/6O9xdt7FCNuZSb9yA9nCvn65D8k9hJxYjltF2aouLlbbtuV9CeuNrsxQhqWRA4 vKH5agUKa7dH8aGEaEKk1nrcO9r1U//wGVT1jaZRyWaPx2+o/J/RPIGwEx/HZtyv jInN2QpVSQo4YqSRLHB6geJ3K5OvTAVI4X4QtFXiFQ6IABTmsjlIdxF30fFSmOos +45ohC/GguOJKgvApgWix7xRAX7N1U3QaDsNyaQofJ6hDY7EdMW5Ptz58qBqUv6x 4P6PJ+m4BS5yj+hIsOC1HlwQnMRn4JexTfsg4E/mB5Laa3RONQ8x5aX00G3gs6Sv FozirZyoP4n3d7X0nRkRf4qljlW8SsssWhy7paTLgtLJwdFwy97wWLubdZuljeeg GxCvkXAnRBScDk9IE4z4 =UuRt -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] mshtml: Added IHTMLLinkElement::rev property implementation.
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8616 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5751: Test failed: hasFeature failed: 80070057

1 0

Re: [PATCH 1/2] mshtml: Added IHTMLDocument5::get_implementation implementation.
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8615 Your paranoid android. === w2000pro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057 === wxppro (32 bit dom) === dom.c:5720: Test failed: hasFeature failed: 80070057

1 0

Re: [1/5] ntdll/tests: Add tests for FILE_PIPE_INFORMATION. (try 2)
by Marvin Aug. 21, 2014

Aug. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8610 Your paranoid android. === w8 (32 bit pipe) === pipe.c:546: Test failed: can't open pipe, GetLastError: e7 pipe.c:622: Test failed: can't open pipe, GetLastError: e7

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Alexandre Julliard Aug. 20, 2014

Aug. 20, 2014

Sebastian Lackner <sebastian(a)fds-team.de> writes: > +#define check_pipe_handle_state(handle, r, c) \ > + do \ > + { \ > + memset(&fpi, 0x55, sizeof(fpi)); \ > + if (handle == INVALID_HANDLE_VALUE) break; \ > + res = pNtQueryInformationFile(handle, &iosb, &fpi, sizeof(fpi), (FILE_INFORMATION_CLASS)23); \ > + ok(!res, "NtQueryInformationFile returned %x\n", res); \ > + ok(fpi.ReadMode == r, "ReadMode == %x\n", fpi.ReadMode); \ > + ok(fpi.CompletionMode == c, "CompletionMode == %x\n", fpi.CompletionMode); \ > + } \ > + while (0) Please use a function instead of a macro for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Piotr Caban Aug. 20, 2014

Aug. 20, 2014

On 08/19/14 17:56, Shuai Meng wrote: > Change log: > checked the type of returned variant instead of printing it. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 2 ++ > 2 files changed, 10 insertions(+), 2 deletions(-) > The patch will not apply cleanly in current git. I've sent a patch that adds support for VAR_TIMEVALUEONLY and VAR_DATEVALUEONLY flags to VarDateFromUdateEx function. I think it will be nicer to use this function here. Thanks, Piotr

1 0

Wine test analysis August 6
by Jeremy White Aug. 19, 2014

Aug. 19, 2014

Henri asked me to share my daily link; this page: www.winehq.org/~jwhite/latest.html should redirect you to the latest results of my cron job that analyzes test results. My cron job is hopefully only a temporary tool used to shame people into fixing the tests. It's main features: 1. Limits results only to believed 'good' test bot VMs (which is basically all the production ones, minus the win 8 vm) 2. Looks for patterns (e.g. apparently fixed, sporadically failing, consistently failing) 3. Holds an annotation line The goal is to have 0 failures. My first step in that is to have each failure annotated, so we know who to blame <grin>. The 'good' news is that we are back down under 30 - looks like just 27 failures right now. There are five failures not annotated in any way, and my link for them was blue, so they might be new and easy: http://test.winehq.org/data/tests/shlwapi:ordinal.html http://test.winehq.org/data/tests/comctl32:button.html http://test.winehq.org/data/tests/kernel32:change.html http://test.winehq.org/data/tests/user32:listbox.html http://test.winehq.org/data/tests/user32:win.html Any takers? Cheers, Jeremy

3 2

Re: [PATCH 2/2] vbscript: Implemented Time(try 2)
by Marvin Aug. 19, 2014

Aug. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8592 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Date(try 2)
by Marvin Aug. 19, 2014

Aug. 19, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8591 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: d3d10_1.idl: Added some missing constants.
by Henri Verbeet Aug. 19, 2014

Aug. 19, 2014

In my copy of the PSDK these are guarded by _D3D10_1_CONSTANTS, although it's not entirely clear to me if that actually does anything, since it's only used there, inside d3d10_1.idl.

2 1

Re: [1/2] wbemprox: Implement __SystemSecurity::GetSD.
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8576 Your paranoid android. === wvistau64 (64 bit query) === query: unhandled exception c0000005 at 0000000077336B27 === w2008s64 (64 bit query) === query: unhandled exception c0000005 at 0000000077C76B27

1 0

Re: [PATCH 7/7] vbscript: Implemented Log(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8570 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Exp(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8569 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Atn(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8568 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Tan(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8567 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Sin(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8566 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Cos(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8565 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Sqr(try 4)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8564 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: ddraw/tests: Correct test condition (PVS-Studio)
by Marvin Aug. 18, 2014

Aug. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8529 Your paranoid android. === w2000pro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00A10028) === wxppro (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(00B50028) === wvistau64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02C70028) === w2008s64 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(02B90028) === w7u (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(01B70028) === w8 (32 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(00000000) differs from the one returned by Lock(019F0000) === wvistau64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000029F0040) === w2008s64 (64 bit dsurface) === dsurface.c:272: Test failed: lpSurface from GetSurfaceDesc(0000000000000000) differs from the one returned by Lock(00000000031A0040)

5 5