August 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] d3d10core: Implement d3d10_device_CopyResource().
by Stefan Dösinger Aug. 4, 2014

Aug. 4, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-08-04 12:17, schrieb Henri Verbeet: > + if (dst_resource->type != WINED3D_RTYPE_TEXTURE) > + { > + FIXME("Not implemented for %s resources.\n", debug_d3dresourcetype(dst_resource->type)); > + return; > + } What's the point of implementing this based on textures and blits? It seems to me that a major restructuring will be needed to make this work on buffers. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJT35GOAAoJEN0/YqbEcdMwljwQAI2wEkyQHnUbwVIc6wV1bkm6 25ySqo8ZC27L72eHHPpA6nBNDObcbN19MpnTGh57cK1xzt6aC/KBWwCotXkbgKzK almnHatukw7Nkms1jMGn7C0ROQRcdBC4VHKpeINKcCdTxfosm81NOpj9eofy0hB1 BGqWzAhS9oOKGmQZznIHeWJJNuRe5skvsOVvSg4bbaHGi1528BgKLLxRtlFfbXbO LNT3SnGvAI9jJC2lJEJ1SH62NkPXJmh8gIm5ptGS2JNzkT7EjNQyxqBJ1uTjlsAH jyIX1+XZx+H950ucH1RktOyccowPzi1TY2qe6nBDDr4G5u/mgfzXcGbHcUd1G51K DPP09g4NdaPExjfi40c0CgD0xRNgu7JInhzqLiBeEU2LBiXiSNC+wR8oXSlOroMj rC93/J2CqJ+7emZ1SQSq+zQECdaqscQ11iPPQGfKkwxlm8XwF+knMh99hnyknaQs wTbRh9Fp0OzM7cs81E3GL/KxJ+pmqctLBZSVAn6VHAXs06d3BQ+moX5D7sZaopQ/ y2U83wECb3DwSHp1ihbhoM6en9CWxdkLn+JqA8VRLiS803el7e7QvpmRzR7t8+VA O4jvo6v7TWszpsL2HbuyCJeOnWsVXAjIxlB2Eok8CI+FfYc0S20QCBMaFw1ixVIr BiyVPU9VwG/qicUSK53R =5T4j -----END PGP SIGNATURE-----

2 2

Re: [PATCH 2/2] ddraw: Return empty D3D hardware flags for HEL device enumeration.
by Henri Verbeet Aug. 4, 2014

Aug. 4, 2014

On 31 July 2014 00:57, Erich E. Hoover <erich.e.hoover(a)gmail.com> wrote: > @@ -537,12 +537,16 @@ static HRESULT WINAPI enumDevicesCallback(GUID *Guid, char *DeviceDescription, > > ok(hal->dcmColorModel == 0, "RGB Device %u hal caps has colormodel %u\n", ver, hal->dcmColorModel); > ok(hel->dcmColorModel == D3DCOLOR_RGB, "RGB Device %u hel caps has colormodel %u\n", ver, hel->dcmColorModel); > + > + ok(hal->dwFlags == 0, "RGB Device %u has hardware flags %x\n", ver, hal->dwFlags); > } > else if(IsEqualGUID(&IID_IDirect3DHALDevice, Guid)) > { > trace("HAL Device %d\n", ver); > ok(hal->dcmColorModel == D3DCOLOR_RGB, "HAL Device %u hal caps has colormodel %u\n", ver, hel->dcmColorModel); > ok(hel->dcmColorModel == 0, "HAL Device %u hel caps has colormodel %u\n", ver, hel->dcmColorModel); > + > + ok(hal->dwFlags != 0, "HAL Device %u has hardware flags %x\n", ver, hal->dwFlags); > } In principle this patch looks plausible enough. What about hel->dwFlags though, and what about other device types like Ref, MMX, etc.?

1 0

Re: [2/2]dwrite: basic implementation for FontCollectionLoader registration
by Nikolay Sivov Aug. 4, 2014

Aug. 4, 2014

> + IDWriteFontCollectionLoader **CollectionLoaders; > + LONG CollectionLoaderCount; I'd really like a better naming for those, something like 'loaders' and 'loaders_count'. > + if (i == This->CollectionLoaderCount) > + { > + This->CollectionLoaderCount++; > + if (This->CollectionLoaders) > + This->CollectionLoaders = heap_realloc(This->CollectionLoaders, This->CollectionLoaderCount * sizeof(IDWriteFontCollectionLoader*)); > + else > + This->CollectionLoaders = heap_alloc(This->CollectionLoaderCount * sizeof(IDWriteFontCollectionLoader*)); > + if (!This->CollectionLoaders) > + return E_OUTOFMEMORY; > + } > + IDWriteFontCollectionLoader_AddRef(loader); > + This->CollectionLoaders[i] = loader; This should grow more efficiently in my opinion. Also it probably makes sense to have small number of slots allocated on initial factory creation or even use a list (you don't need index access). Another question is do we want to register a default local loader on factory creation or not.

2 3

Re: [2/2]dwrite: basic implementation for FontCollectionLoader registration
by Piotr Caban Aug. 4, 2014

Aug. 4, 2014

On 8/1/14 12:01 PM, Aric Stewart wrote: > + if (i == This->CollectionLoaderCount) > + { > + This->CollectionLoaderCount++; > + if (This->CollectionLoaders) > + This->CollectionLoaders = heap_realloc(This->CollectionLoaders, This->CollectionLoaderCount * sizeof(IDWriteFontCollectionLoader*)); > + else > + This->CollectionLoaders = heap_alloc(This->CollectionLoaderCount * sizeof(IDWriteFontCollectionLoader*)); > + if (!This->CollectionLoaders) > + return E_OUTOFMEMORY; > + } There's a leak in out of memory case. Isn't it better to grow the buffer exponentially?

3 2

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18