August 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

On 08/14/14 17:23, Shuai Meng wrote: > Change log: > Applied cleanly. > --- > dlls/vbscript/global.c | 10 ++++++++-- > dlls/vbscript/tests/api.vbs | 19 +++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > Please add some tests for values other than trivial cases. You may want to add PI constant and a helper (like almostEqual) to deal with precision problems. Same applies to other patches from this series. Also, for functions (like atan) that have invalid arguments, I'd like to see tests of them. Jacek

1 0

Re: [PATCH 2/2] vbscript: Implemented Int(try 2)
by Marvin Aug. 14, 2014

Aug. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8483 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] vbscript: Implemented Fix(try 2)
by Marvin Aug. 14, 2014

Aug. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8482 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 7/7] vbscript: Implemented Atn
by Thomas Faber Aug. 14, 2014

Aug. 14, 2014

> static HRESULT Global_Ant(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) Perhaps you want to use this opportunity to fix the typo in the function name too? ;)

2 1

Re: mshtml: Added IHTMLInputElement::readOnly property.
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

Hi Zhenbo, On 08/14/14 16:08, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlinput.c > +++ b/dlls/mshtml/htmlinput.c > @@ -389,15 +389,33 @@ static HRESULT WINAPI HTMLInputElement_get_defaultValue(IHTMLInputElement *iface > static HRESULT WINAPI HTMLInputElement_put_readOnly(IHTMLInputElement *iface, VARIANT_BOOL v) > { > HTMLInputElement *This = impl_from_IHTMLInputElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLInputElement_SetReadOnly(This->nsinput, v != VARIANT_FALSE ? TRUE : FALSE); Remove "? TRUE : FALSE" part. Jacek

1 0

Re: mshtml: Added IHTMLInputElement_get_form method implementation. (try 3)
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

On 07/29/14 15:34, Zhenbo Li wrote: > +#define test_input_get_form(o, t) _test_input_get_form(__LINE__, o, t) > +static void _test_input_get_form(unsigned line, IUnknown *unk, const char *id) > +{ > + IHTMLInputElement *input; > + IHTMLFormElement *form; > + IHTMLElement *elem; > + BSTR bstr; > + HRESULT hres; > + > + ok_(__FILE__,line) (unk != NULL, "unk is NULL!\n"); > + hres = IUnknown_QueryInterface(unk, &IID_IHTMLInputElement, (void**)&input); > + ok_(__FILE__,line) (hres == S_OK, "Could not get IHTMLInputElement: %08x\n", hres); > + ok_(__FILE__,line) (input != NULL, "input == NULL\n"); > + if(FAILED(hres) || input == NULL) > + return; > + > + hres = IHTMLInputElement_get_form(input, &form); > + ok_(__FILE__, line) (hres == S_OK, "get_form failed: %08x\n", hres); > + ok_(__FILE__, line) (form != NULL, "form == NULL\n"); > + if(FAILED(hres) || form == NULL){ > + IHTMLInputElement_Release(input); > + return; > + } > + > + hres = IHTMLFormElement_QueryInterface(form, &IID_IHTMLElement, (void **)&elem); > + ok_(__FILE__, line) (hres == S_OK, "QueryInterface(IID_IHTMLElement) failed: %08x\n", hres); > + ok_(__FILE__, line) (elem != NULL, "elem == NULL\n"); > + if(FAILED(hres) || elem == NULL){ > + IHTMLInputElement_Release(input); > + IHTMLFormElement_Release(form); > + return; > + } > + hres = IHTMLElement_get_id(elem, &bstr); > + ok_(__FILE__, line) (hres == S_OK, "get_id failed: %08x\n", hres); > + ok_(__FILE__, line) (!strcmp_wa(bstr, id), "Expect %s, got %s\n", id, wine_dbgstr_w(bstr)); Please use _test_elem_id instead. Cheers, Jacek

1 0

Re: mshtml: Added IHTMLImgElement::isMap property implementation. (try 2)
by Jacek Caban Aug. 14, 2014

Aug. 14, 2014

Hi Zhenbo, On 08/11/14 08:46, Zhenbo Li wrote: > --- a/dlls/mshtml/htmlimg.c > +++ b/dlls/mshtml/htmlimg.c > @@ -102,15 +102,37 @@ static HRESULT WINAPI HTMLImgElement_Invoke(IHTMLImgElement *iface, DISPID dispI > static HRESULT WINAPI HTMLImgElement_put_isMap(IHTMLImgElement *iface, VARIANT_BOOL v) > { > HTMLImgElement *This = impl_from_IHTMLImgElement(iface); > - FIXME("(%p)->(%x)\n", This, v); > - return E_NOTIMPL; > + nsresult nsres; > + > + TRACE("(%p)->(%x)\n", This, v); > + > + nsres = nsIDOMHTMLImageElement_SetIsMap(This->nsimg, v ? TRUE : FALSE); Please avoid v?TRUE:FALSE style expressions. Cheers, Jacek

1 0

Re: [3/5] wined3d: replace vendor specific callbacks with generic code that uses vendor specific arrays (resend)
by Henri Verbeet Aug. 13, 2014

Aug. 13, 2014

On 12 August 2014 02:17, Andrei Slăvoiu <andrei.slavoiu(a)gmail.com> wrote: > @@ -2172,45 +2173,43 @@ intel_gl_vendor_table[] = > {GL_VENDOR_MESA, "Mesa Intel driver", cards_intel, > ARRAY_SIZE(cards_intel)}, Your mailer wrapped the patch, so it won't apply. I recommend using git send-email for sending patches. > +C_ASSERT(NUMELMS(card_fallback_nvidia) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_amd) == WINED3D_D3D_LEVEL_COUNT); > +C_ASSERT(NUMELMS(card_fallback_intel) == WINED3D_D3D_LEVEL_COUNT); ... > + enum wined3d_pci_device *card_fallback; /* An array with D3D_LEVEL_COUNT > elements */ I also strongly suspect that even if the patch did apply, it would either generate warnings or just fail to compile.

1 0

Re: [4/4] ntdll/tests: Add tests for FILE_PIPE_INFORMATION.
by Marvin Aug. 12, 2014

Aug. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8473 Your paranoid android. === w8 (32 bit pipe) === pipe.c:540: Test failed: can't open pipe, GetLastError: e7 pipe.c:616: Test failed: can't open pipe, GetLastError: e7

1 0

Re: (resend)[2/5]dwrite: Initial implementation of CreateCustomFontFileReference
by Marvin Aug. 12, 2014

Aug. 12, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8468 Your paranoid android. === build (build) === Patch failed to apply

1 0