September 2014 - Wine-Devel

Re: wineps.drv: Fix bug using different enumeration value on user defined printer page sizes for printers using the same ppd.
by Huw Davies Sept. 23, 2014

Sept. 23, 2014

On Tue, Sep 23, 2014 at 11:09:39AM +0200, Ralf Habacker wrote: > diff --git a/dlls/wineps.drv/ppd.c b/dlls/wineps.drv/ppd.c > index 520355a..b440da0 100644 > --- a/dlls/wineps.drv/ppd.c > +++ b/dlls/wineps.drv/ppd.c > @@ -179,7 +179,6 @@ static const struct { > {NULL, 0} > }; > > -static WORD UserPageType = DMPAPER_USER; > static WORD UserBinType = DMBIN_USER; > > /*********************************************************************** > @@ -695,6 +694,7 @@ PPD *PSDRV_ParsePPD( const WCHAR *fname, HANDLE printer ) > char *def_pagesize_override = NULL, *def_duplex_override = NULL; > PAGESIZE *page, *page_cursor2; > struct map_context c; > + WORD UserPageType = DMPAPER_USER; > Right, but you want to move UserBinType too. Also, your commit message isn't great. Huw.

1 0

Re: [3/3] dpvoice: Add DirectPlay Voice Test
by Marvin Sept. 23, 2014

Sept. 23, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9013 Your paranoid android. === w2000pro (32 bit voice) === voice.c:237: Test failed: Voice Connect failed with 0x80150183 === wxppro (32 bit voice) === voice.c:237: Test failed: Voice Connect failed with 0x80150183

1 0

Re: wined3d: Correctly display fog for right-handed projection matrix (try 2)
by Henri Verbeet Sept. 22, 2014

Sept. 22, 2014

On 18 September 2014 21:57, Joachim Priesner <joachim.priesner(a)web.de> wrote: > When using a right-handed projection matrix, z coordinates of vertices may be negative. This is not considered in the code generating the GLSL fog shader. The patch fixes that and adds a test. > The patch is likely correct, but the test has room for improvement. For example, it doesn't currently distinguish between using the absolute fog coordinate in the vertex shader or doing the same in the fragment shader. Also, please don't forget about ddraw and d3d8.

3 3

Re: vbscript: Don't try to convert int to short in return_int.
by Marvin Sept. 22, 2014

Sept. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8999 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] mshtml: add anchor element put_query and get_query
by Marvin Sept. 22, 2014

Sept. 22, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8998 Your paranoid android. === w2000pro (32 bit dom) === dom.c:7368: Test failed: search = (null), expected ?word=abc dom.c:7379: Test failed: href = L"http://test/word=abc?how?old=are", expected http://test/?how?old=are#hash dom.c:7379: Test failed: value = L"http://test/word=abc?how?old=are", expected http://test/?how?old=are#hash

1 0

Re: [PATCH] dwrite: use correct variable (Coverity)
by Nikolay Sivov Sept. 21, 2014

Sept. 21, 2014

On 9/21/2014 16:35, Marcus Meissner wrote: > 1232720 Mixing enum types > > these are actually different values. > --- > dlls/dwrite/tests/font.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c > index 3a17064..fe4eb4b 100644 > --- a/dlls/dwrite/tests/font.c > +++ b/dlls/dwrite/tests/font.c > @@ -957,7 +957,7 @@ static void test_FontLoader(void) > ok(face == DWRITE_FONT_FACE_TYPE_UNKNOWN, "got %i\n", face); > ok(count == 0, "got %i\n", count); > > - hr = IDWriteFactory_CreateFontFace(factory, type, 1, &ffile, 0, 0, &fface); > + hr = IDWriteFactory_CreateFontFace(factory, face, 1, &ffile, 0, 0, &fface); > ok(hr == 0x8faecafe, "got 0x%08x\n", hr); > IDWriteFontFile_Release(ffile); > It's supposed to be DWRITE_FONT_FACE_TYPE_CFF (it is now) or DWRITE_FONT_FACE_TYPE_TRUETYPE.

2 1

Re: [PATCH] dwrite: use correct variable (Coverity)
by Marvin Sept. 21, 2014

Sept. 21, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8996 Your paranoid android. === wvistau64 (32 bit font) === font.c:961: Test failed: got 0x80070057 === w2008s64 (32 bit font) === font.c:961: Test failed: got 0x80070057 === w7u (32 bit font) === font.c:961: Test failed: got 0x80070057 === w8 (32 bit font) === font.c:961: Test failed: got 0x80070057 === wvistau64 (64 bit font) === font.c:961: Test failed: got 0x80070057 === w2008s64 (64 bit font) === font.c:961: Test failed: got 0x80070057

1 0

Re: [PATCH] vbscript: Implemented RGB(try 2)
by Marvin Sept. 20, 2014

Sept. 20, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8993 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented RGB
by Nikolay Sivov Sept. 19, 2014

Sept. 19, 2014

On 09/18/2014 08:46 PM, Shuai Meng wrote: > + LONG total, color[3];//color[0] for red, color[1] for green, color[2] for blue. This could be just 'int', as you use to_int(). > static HRESULT return_int(VARIANT *res, int val) > { > - if((short)val == val) > - return return_short(res, val); > - That's a questionable thing to do as it affects all other places where this helper is used. > + if(color[i] > 255) > + color[i] = 255; This needs a test too. > + total = color[0] + 256 * color[1] + 256 * 256 * color[2]; RGB() macro does the same thing.

4 6

Re: [3/3] gdiplus: Add a more optimized loop for composing onto PARGB.
by Andrew Eikum Sept. 19, 2014

Sept. 19, 2014

On Fri, Sep 19, 2014 at 11:28:13AM -0500, Vincent Povirk wrote: > + else if ((fg & 0xff000000) == 0xff) This will never be true. Andrew

2 1

Re: [PATCH 1/2] riched20: Stub for ITextFont interface and implement ITextRange::GetFont. (try 3)
by Huw Davies Sept. 19, 2014

Sept. 19, 2014

On Fri, Sep 19, 2014 at 08:58:51PM +0800, Jactry Zeng wrote: > dlls/riched20/richole.c | 786 > +++++++++++++++++++++++++++++++++++++++++- > dlls/riched20/tests/richole.c | 47 +++ > 2 files changed, 831 insertions(+), 2 deletions(-) These two look good to me. Huw.

1 0

Re: rpcrt4: Fix buffer size calculation for arrays with embedded pointers
by Huw Davies Sept. 19, 2014

Sept. 19, 2014

On Thu, Sep 18, 2014 at 02:29:07PM +0200, Eric Kohl wrote: > I finally found the bug in the function EmbeddedPointerBufferSize where > the pointer to the current array element was not incremented while the > surrounding for loop traversed the array. The pointer was always > pointing at the first element of the array. I also found the same bug in > the function EmbeddedPointerMarshall. Perhaps also EmbeddedPointerFree? We probably need some tests. Huw.

1 1

Re: [PATCH 1/2] riched20: Stub for ITextFont interface and implement ITextRange::GetFont. (try 2)
by Huw Davies Sept. 19, 2014

Sept. 19, 2014

On Thu, Sep 18, 2014 at 09:15:11PM +0800, Jactry Zeng wrote: > +static IRichEditOleImpl *get_reOle(ITextFontImpl *txtFont) > +{ > + if (txtFont->txtRge) > + return txtFont->txtRge->reOle; > + else > + return txtFont->txtSel->reOle; > +} You're using two-space indents here, while the rest is four-space. A couple of these have sneaked in in earlier patches too - make sure your editor is set up correctly! > +static HRESULT CreateITextFont(ITextFontImpl **ptxtFont) > +{ > + ITextFontImpl *txtFont = NULL; This initialization isn't very useful. > + txtFont = heap_alloc(sizeof(ITextFontImpl)); > + if (!txtFont) > + return E_OUTOFMEMORY; > + > + txtFont->ITextFont_iface.lpVtbl = &tfvt; > + txtFont->ref = 1; > + *ptxtFont = txtFont; > + return S_OK; > +} It would make more sense to initialize txtSel and txtRge to NULL here - the caller then only needs to touch the one it needs. Otherwise, this one and the next one look good to me. Huw.

2 1

Re: [PATCH] vbscript: Implemented RGB
by Qian Hong Sept. 19, 2014

Sept. 19, 2014

Hi Shuai, Please don't use C++ style comment, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

2 1

Re: wined3d: Correctly display fog for right-handed projection matrix
by Bruno Jesus Sept. 18, 2014

Sept. 18, 2014

On Thu, Sep 18, 2014 at 3:30 PM, Joachim Priesner <joachim.priesner(a)web.de> wrote: > + // A right-handed perspective projection matrix designed so that vertices > + // (x in [-1..1], y in [-1..1], z = 0.1) will be mapped to the view plane. > + // Obtained from D3DXMatrixPerspectiveFovRH with the parameters > + // fov=84.29deg, aspect=640/480 near=0.01, far=100 Hi, Joachim. Please don't use C++ style comments, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

1 0

Re: [PATCH] vbscript: Implemented RGB
by Marvin Sept. 18, 2014

Sept. 18, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8974 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.
by Huw Davies Sept. 17, 2014

Sept. 17, 2014

On Wed, Sep 17, 2014 at 05:39:23PM +0800, Jactry Zeng wrote: > > +typedef struct ITextFontImpl { > + ITextFont ITextFont_iface; > + LONG ref; > + struct list entry; > + > + IRichEditOleImpl *reOle; > + ITextRangeImpl *txtRge; > + ITextSelectionImpl *txtSel; > +} ITextFontImpl; Since the ITextFont objects do hold a ref on their parent range / selection objects I don't think we need the list stuff again. I wouldn't store the reOle pointer here, but use txtRge / txtSel to access it (and check for disconnections). You probably want a helper function to do that. Huw.

2 1

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
by Indrek Altpere Sept. 17, 2014

Sept. 17, 2014

This seems to be a typo, I think the original variable name was mean to be isedge or is_edge. Perhaps this check would be simpler to understand and would not create local variable if it were like this? if (*end == *start) return S_FALSE; Regards, Indrek

3 2

Re: winedbg: Respect TMPDIR environment variable
by Michael Stefaniuc Sept. 17, 2014

Sept. 17, 2014

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/16/2014 09:25 PM, André Hentschel wrote: > First attack on https://bugs.winehq.org/show_bug.cgi?id=14838 > > diff --git a/programs/winedbg/gdbproxy.c > b/programs/winedbg/gdbproxy.c index 0865f44..d7596a0 100644 --- > a/programs/winedbg/gdbproxy.c +++ b/programs/winedbg/gdbproxy.c @@ > -2342,11 +2342,13 @@ static BOOL gdb_exec(const char* wine_path, > unsigned port, unsigned flags) { char buf[MAX_PATH]; int > fd; - const char* gdb_path; + const char *gdb_path, > *tmp_path; FILE* f; > > if (!(gdb_path = getenv("WINE_GDB"))) gdb_path = "gdb"; - > strcpy(buf,"/tmp/winegdb.XXXXXX"); + if (!(tmp_path = > getenv("TMPDIR"))) tmp_path = "/tmp"; + strcpy(buf, tmp_path); + > strcat(buf, "/winegdb.XXXXXX"); Just wondering, as we already have the .wine-$UID directory in TMPDIR shouldn't this file be placed in that directory too? > fd = mkstemps(buf, 0); if (fd == -1) return FALSE; if ((f = > fdopen(fd, "w+")) == NULL) return FALSE; > bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iD8DBQFUGVSO0ei8kcpE1VERAgC/AJ9Ow9H7xnu/qQ3VYlh49BXOgG75pACePrh7 aLhMgo8NZ7EhpQCB2cs8NnY= =OHEq -----END PGP SIGNATURE-----

1 0

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
by Huw Davies Sept. 17, 2014

Sept. 17, 2014

On Tue, Sep 16, 2014 at 06:39:32PM +0800, Jactry Zeng wrote: > +static HRESULT range_Collapse(LONG bStart, LONG *start, LONG *end) > +{ > + BOOL isdege = !(*end - *start); This is a strange way to test for an equality! Also, isdegen or is_degen would be much better choices for the variable name. Huw.

1 1

Re: [PATCH 3/5] riched20: Implement ITextRange::GetDuplicate. (try 3)
by Huw Davies Sept. 17, 2014

Sept. 17, 2014

On Tue, Sep 16, 2014 at 06:39:20PM +0800, Jactry Zeng wrote: > + hres = CreateITextRange(This->reOle, This->start, This->end, ppRange); > + if (FAILED(hres)) > + return E_FAIL; > + return hres; Actually since CreateITextRange can only fail in out-of-memory cases we can't easily test this behaviour and there's no guarantee that the docs are correct anyway. So just return CreateITextRange(..) here would be cleaner. Huw.

1 0

Re: [PATCH 4/8] riched20: Implement ITextRange::GetDuplicate. (try 2)
by Huw Davies Sept. 16, 2014

Sept. 16, 2014

On Fri, Sep 12, 2014 at 08:33:42PM +0800, Jactry Zeng wrote: > diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c > index a88aff2..b85ffda 100644 > --- a/dlls/riched20/richole.c > +++ b/dlls/riched20/richole.c > + hres = CreateITextRange(This->reOle, This->start, This->end, ppRange); > + if(hres) > + return E_FAIL; This isn't the way to test for failure. Use the FAILED() macro. Huw.

2 1

Re: [PATCH 1/2] riched20: Implement ITextRange::GetChar.
by Alexandre Julliard Sept. 15, 2014

Sept. 15, 2014

Jactry Zeng <wine(a)jactry.com> writes: > +#define TEST_TXTRGE_GETCHAR(first, lim, expected_char) \ > + create_interfaces(&w, &reOle, &txtDoc, NULL); \ > + SendMessageA(w, WM_SETTEXT, 0, (LPARAM)test_text1); \ > + ITextDocument_Range(txtDoc, first, lim, &txtRge); \ > + pch = 0xdeadbeef; \ > + hres = ITextRange_GetChar(txtRge, &pch); \ > + ok(hres == S_OK, "ITextRange_GetChar\n"); \ > + ok(pch == expected_char, "got wrong char: %c\n", pch); \ > + ITextRange_Release(txtRge); \ > + release_interfaces(&w, &reOle, &txtDoc, NULL); Please avoid that sort of huge macro. If necessary, use helper functions instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Problem with CompareString/CompareStringEx - accented characters
by Virgo Pärna Sept. 15, 2014

Sept. 15, 2014

I have been trying to figure out, what is wrong with wine's implementation of CompareString and CompareStringEx functions. From what I can figure out, those functions completely ignore locale passed to them. That alone is not a critical issue, but what causes problems to me, is that it seems always act, as if NORM_IGNORENONSPACE was passed (comparision shows, that A and Ä are same). I did try to rip relavent parts out of wine for test utility and it seems, that A and Ä have same value in collation_table which is used by compare_diacritic_weights. Could it be, that the make_unicode's READ_SORTKEYS_FILE looses relavent information, when generating collation.c file? My perl is even worse than my C, so figuring out those regexes is way beyond me. I did spam https://bugs.winehq.org/show_bug.cgi?id=9583 with my analysis. -- Virgo Pärna virgo.parna(a)mail.ee

1 0

Re: [PATCH 6/8] d3d8: Mark tests which no longer pass due to reverts as todo_wine.
by Marvin Sept. 14, 2014

Sept. 14, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8913 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

2 1

Re: [PATCH 5/8] Revert "wined3d: Restore the pixel format of the window whose pixel format was actually changed."
by Ken Thomases Sept. 14, 2014

Sept. 14, 2014

It seems I accidentally sent this one twice. Please ignore the duplicate, but the series should be OK otherwise. -Ken On Sep 14, 2014, at 7:47 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > This reverts commit 4c4552c5a1910a9d5adf8eccff0ac62d89ffe376. > > For: > https://bugs.winehq.org/show_bug.cgi?id=35655 > https://bugs.winehq.org/show_bug.cgi?id=35718 > https://bugs.winehq.org/show_bug.cgi?id=35950 > https://bugs.winehq.org/show_bug.cgi?id=35975 > https://bugs.winehq.org/show_bug.cgi?id=36900 > --- > dlls/wined3d/context.c | 87 +++++++++++------------------------------- > dlls/wined3d/wined3d_private.h | 1 - > 2 files changed, 22 insertions(+), 66 deletions(-) > > <0005-Revert-wined3d-Restore-the-pixel-format-of-the-windo.patch>

1 0

Re: wininet: Avoid compiler warnings due to negation before binary operator. (RESEND)
by Alexandre Julliard Sept. 12, 2014

Sept. 12, 2014

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > As of last week, what will become GCC 5.0 does warn about this as > part of -Wall. > > There are a couple of cases in Wine, such as this, which I'd like > to address. Please find a way that doesn't make the code unnecessarily ugly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/8] riched20: Stub for ITextRange interface and implement ITextDocument::Range. (try 5)
by Huw Davies Sept. 12, 2014

Sept. 12, 2014

On Fri, Sep 12, 2014 at 08:33:29PM +0800, Jactry Zeng wrote: > Thanks Huw and Sebastian. > > Superseded patch 106499. > > ChangeLog: > try 5: > - Alloc txtRge in CreateITextRange() > try 4: > - Simplify with macros in include/wine/list.h > - Using LONG instead of int in This->start and This->end > - Limit cp1 to (0, TextLength) > --- > dlls/riched20/richole.c | 730 > +++++++++++++++++++++++++++++++++++++++++- > dlls/riched20/tests/richole.c | 35 +- > 2 files changed, 762 insertions(+), 3 deletions(-) This first one looks ok to me. You'll need to re-send the rest of the series, but it would be better to wait until this gets in. Huw.

1 0

Re: [PATCH 1/8] riched20: Stub for ITextRange interface and implement ITextDocument::Range. (resend try 4)
by Huw Davies Sept. 12, 2014

Sept. 12, 2014

On Thu, Sep 11, 2014 at 05:35:38PM +0800, Jactry Zeng wrote: > +static HRESULT CreateITextRange(IRichEditOleImpl *reOle, LONG start, LONG end, > + ITextRangeImpl *txtRge, ITextRange** ppRange) > +{ > + txtRge->ITextRange_iface.lpVtbl = &trvt; > + txtRge->ref = 1; > + txtRge->reOle = reOle; > + txtRge->start = start; > + txtRge->end = end; > + list_add_head(&reOle->rangelist, &txtRge->entry); > + *ppRange = &txtRge->ITextRange_iface; > + return S_OK; > +} This looks very suspicious to me. You're storing a reference to 'reOle' so you should AddRef it somewhere. It may be better to pass the interface ptr, AddRef and store that. Also, is the purpose of rangelist just to be able to NULL out reOle when the parent object is destroyed? If so, this can go away if you correctly handle the ref counting. Huw.

3 13

Re: reg: Add reg.exe test suite. (try 3)
by Marvin Sept. 11, 2014

Sept. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8896 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: dpnet/tests: Make test_lobbyclient() static.
by Marvin Sept. 11, 2014

Sept. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8895 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/8] riched20: Implement ITextSelection::GetChar and ITextRange::GetChar. (resend try2)
by Marvin Sept. 11, 2014

Sept. 11, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8888 Your paranoid android. === wxppro (32 bit richole) === Failure running script in VM: Timed out in create_socket while connecting to testnet.winehq.org:22001:10.42.42.134:4242

1 0

Re: reg: Add reg.exe test suite. (try 2)
by Alexandre Julliard Sept. 10, 2014

Sept. 10, 2014

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 2: > - Avoid memory allocation in run_reg_exe_ function. > - Add more broken tests in WinXP. > - Compare the exit code outside of run_reg_exe function. > - Introduce REG_EXIT_SUCCESS/REG_EXIT_FAILURE constant and use it. It fails here on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M reg.exe -p reg.exe_test.exe.so reg && touch reg.ok reg.c:180: Test succeeded inside todo block: got wrong data make: *** [reg.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3]dwrite: build non-system font collections as a list of font families
by Nikolay Sivov Sept. 10, 2014

Sept. 10, 2014

On 09/09/2014 04:10 AM, Aric Stewart wrote: > @@ -920,6 +939,8 @@ static UINT32 WINAPI dwritefontcollection_GetFontFamilyCount(IDWriteFontCollecti > { > struct dwrite_fontcollection *This = impl_from_IDWriteFontCollection(iface); > TRACE("(%p)\n", This); > + if (This->family_count) > + return This->family_count; > return This->count; This looks particularly suspicious, probably naming needs some work. Other parts need to be improved as well I think, like avoiding impl_from_* in your own internal functions.

1 0

Re: mshtml: Bind events to document node instead of body element.
by Marvin Sept. 10, 2014

Sept. 10, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8870 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: reg: Add reg.exe test suite.
by Marvin Sept. 9, 2014

Sept. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8862 Your paranoid android. === wxppro (32 bit reg) === reg.c:132: Test failed: got exit code 0, expected 1

1 0

Re: dxguid: Add dvoice.h
by Alexandre Julliard Sept. 9, 2014

Sept. 9, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > dxguid: Add dvoice.h There shouldn't be any need to do that. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: (try 7)[1/5] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard Sept. 9, 2014

Sept. 9, 2014

Aric Stewart <aric(a)codeweavers.com> writes: > + if (thread_data->defaultContext) /* someone beat us */ > + IMM_DestroyContext(defaultContext); I don't think you should be doing that inside the thread lock. > + IMMThreadData* thread_data = IMM_GetThreadData(0); > + if (thread_data->hwndDefault == NULL) > + thread_data->hwndDefault = CreateWindowExW( WS_EX_TOOLWINDOW, That one is suspicious too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] wineps.drv: Allow text copy paste from print to pdf
by Huw Davies Sept. 9, 2014

Sept. 9, 2014

On Mon, Sep 08, 2014 at 09:19:54PM -0700, Daniel Horn wrote: > -void get_glyph_name(HDC hdc, WORD index, char *name) > +void get_glyph_name(HDC hdc, BOOL unicode, WORD index, char *name) > { > - /* FIXME */ > - sprintf(name, "g%04x", index); > + if(unicode) > + sprintf(name, "uni%04X", index); > + else > + sprintf(name, "g%04x", index); > return; > } The right way to do this is to look up the glyph's name in the font's 'post' table. Huw.

1 0

Re: [1/3] wineps.drv: Avoid marking composite unicode subglyphs as downloaded (resend)
by Huw Davies Sept. 9, 2014

Sept. 9, 2014

On Mon, Sep 08, 2014 at 09:18:51PM -0700, Daniel Horn wrote: > Fixes a bug with caching composite unicode glyphs (if a ñ came before any n in the document, > then all subsequent n's would appear as a box) > This was because the glyph was marked as having been sent down when it was only a component > of a more complex glyph This shouldn't be necessary, I suspect something else is going wrong. If the 'n' has been downloaded as part of a 'ñ' then it really shouldn't be necessary to download the 'n' again. Huw.

2 2

Re: [PATCH 1/4] mshtml: Return E_POINTER when p is NULL in HTMLStyle_get_pixelLeft.
by Jacek Caban Sept. 9, 2014

Sept. 9, 2014

Hi Jactry, On 09/09/14 08:06, Jactry Zeng wrote: > diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c > index f098cb0..9469243 100644 > --- a/dlls/mshtml/htmlstyle.c > +++ b/dlls/mshtml/htmlstyle.c > @@ -2482,6 +2482,8 @@ static HRESULT WINAPI HTMLStyle_get_pixelLeft(IHTMLStyle *iface, LONG *p) > HTMLStyle *This = impl_from_IHTMLStyle(iface); > > TRACE("(%p)->(%p)\n", This, p); > + if(!p) > + return E_POINTER; Since you're adding those checks to many functions, it would probably make sense to move that to get_nsstyle_pixel_val. Jacek

2 1

Re: [PATCH 1/11] ntdll: Make nt_to_unix_file_name_attr return always safe to free.
by Alexandre Julliard Sept. 9, 2014

Sept. 9, 2014

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > While working on an upcoming patch set I discovered that several of > the file handling primitives are not safe to free under all > circumstances. This would not normally be a problem (since a > comparison can usually be made against STATUS_SUCCESS). However, > there are several cases where this comparison is insufficient (mostly > when STATUS_NO_SUCH_FILE occurs). There are two ways to solve this > problem: > 1) Make these routines always safe to free (and always free them) > 2) Specifically add checks for STATUS_NO_SUCH_FILE and free all these > cases manually STATUS_NO_SUCH_FILE returning a valid string only happens when trying to create the file or things like that, not for normal opens, so most of your changes are unnecessary. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] mshtml: Add IHTMLStyle::pixelTop property implementation.
by Marvin Sept. 9, 2014

Sept. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8853 Your paranoid android. === wxppro (32 bit style) === style.c:1295: Test failed: pixelHeight = 5 === wvistau64 (32 bit style) === style.c:1295: Test failed: pixelHeight = 5 === w2008s64 (32 bit style) === style.c:1295: Test failed: pixelHeight = 5 === w7u (32 bit style) === style.c:1295: Test failed: pixelHeight = 5 === w8 (32 bit style) === style.c:1295: Test failed: pixelHeight = 5 === wvistau64 (64 bit style) === style.c:1295: Test failed: pixelHeight = 5 === w2008s64 (64 bit style) === style.c:1295: Test failed: pixelHeight = 5

1 0

Re: [PATCH 3/4] mshtml: Add IHTMLStyle::pixelHeight property implementation.
by Marvin Sept. 9, 2014

Sept. 9, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8852 Your paranoid android. === wxppro (32 bit style) === style.c:1274: Test failed: pixelHeight = 5 === wvistau64 (32 bit style) === style.c:1274: Test failed: pixelHeight = 5 === w2008s64 (32 bit style) === style.c:1274: Test failed: pixelHeight = 5 === w7u (32 bit style) === style.c:1274: Test failed: pixelHeight = 5 === w8 (32 bit style) === style.c:1274: Test failed: pixelHeight = 5 === wvistau64 (64 bit style) === style.c:1274: Test failed: pixelHeight = 5 === w2008s64 (64 bit style) === style.c:1274: Test failed: pixelHeight = 5

1 0

Re: user32: Also set cch member in GetMenuItemInfo when passing a null pointer.
by Nikolay Sivov Sept. 8, 2014

Sept. 8, 2014

A test would be nice.

1 0

Re: (resend 2)[1/4]dwrite: Implement GetInformationalStrings
by Alexandre Julliard Sept. 8, 2014

Sept. 8, 2014

Aric Stewart <aric(a)codeweavers.com> writes: > read strings from OpenType 'name' table You are not reading anything, once again this is mostly dead code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] d2d1: Implement initial clipping support.
by Matteo Bruni Sept. 7, 2014

Sept. 7, 2014

2014-09-05 15:50 GMT+02:00 Henri Verbeet <hverbeet(a)codeweavers.com>: > +static BOOL d2d_clip_stack_push(struct d2d_clip_stack *stack, const D2D1_RECT_F *rect) > +{ > + if (stack->current == stack->stack_size - 1) > + { > + D2D1_RECT_F *new_stack; > + unsigned int new_size; > + > + if (stack->stack_size > UINT_MAX / 2) > + return FALSE; > + > + new_size = stack->stack_size * 2; > + if (!(new_stack = HeapReAlloc(GetProcessHeap(), 0, stack->stack, new_size * sizeof(*stack->stack)))) > + return FALSE; > + > + stack->stack = new_stack; > + stack->stack_size = new_size; > + } > + > + stack->stack[stack->current++] = *rect; > + d2d_rect_intersect(&stack->clip_rect, rect); > + > + return TRUE; > +} > + > +static void d2d_clip_stack_pop(struct d2d_clip_stack *stack, unsigned int w, unsigned int h) > +{ > + unsigned int i; > + > + if (!stack->current) > + return; > + > + --stack->current; > + stack->clip_rect.left = 0.0f; > + stack->clip_rect.top = 0.0f; > + stack->clip_rect.right = w; > + stack->clip_rect.bottom = h; > + > + for (i = 0; i < stack->current; ++i) > + { > + d2d_rect_intersect(&stack->clip_rect, &stack->stack[i]); > + } > +} Would it be possible to store the clipped rectangles in the stack instead (so that stack->clip_rect == stack->stack[stack->current] at any given moment)? That way you don't need to recompute clip_rect on each pop.

2 1

[RFC 0/11] Linux FF: Intro
by Elias Vanderstuyft Sept. 7, 2014

Sept. 7, 2014

Hi, This is the sequel of the mail with title: "Discussion and Improvement of Wine's Linux Force Feedback implementation". This mail is meant to give an introduction to the next 11 mails: All tests were performed using wine-1.7.11-206-g82b3813 (but none of the files of which I propose changes to be made in, are affected in the current (2014-03-04) wine-version 1.7.13) Because I haven't created any (formal) patch yet (and instead first request for comments), I tried to keep the line numbers to reference the affected files more or less based to the version I started from, where I could. However, the orig code of a (informal) patch that has to be applied after (and thus is dependent of) a previous patch, may be different from the initial code of the wine-version I started from. After having discussed everything, I will send a proper patchset. In these mails, sometimes 'FEdit' is mentioned: it's a MS application that allows to create all FF effect types (except CustomForce and rumble/vibration effects), and therefore the ideal test application. Physical behavior is compared between Windows7 (using Logitech MOMO wheel with latest drivers installed) running in Virtualbox, and my patched Wine-version. In the end, (using a dummy FF driver on the Linux side, thanks to Michal Malý), the behavior of Wine is almost (limitations caused by the dummy ff driver, such as updating an effect while playing is not implemented) identical, if not better (in some aspects) then the Windows equivalent. Sometimes I refer to linux-input mailing lists to prove a statement, because the links may vanish (unlikely though), I provide the titles corresponding with the links: (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08513.html) "ff-core effect id handling in case of a failed effect upload" (http://www.mail-archive.com/linux-input(a)vger.kernel.org/msg08459.html) "Questions about the documentation/specification of Linux ForceFeedback input.h" Subjects [11] ------------- - Joystick control panel program [2] - Linux effect status management [3] - Linux effect parameter: start delay [1] - Linux effect parameter: periodic effect's phase [1] - Linux effect parameters: time parameters [3] - Linux effect: conditional effect's parameters [2] - Linux effect: axes [1] - Linux effect direction [7] - Linux effect parameters (global) [6] - Linux joystick initialization [1] - Debug message fixes/additions [6] Elias

2 3

Re: [PATCH 5/5] d2d1/tests: Add a basic clipping tests.
by Marvin Sept. 5, 2014

Sept. 5, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8807 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

2 1

Re: [PATCH 1/5] widl: Handle aggregate returns in a MSVC compatible way.
by Piotr Caban Sept. 5, 2014

Sept. 5, 2014

On 09/05/14 15:50, Henri Verbeet wrote: > -static D2D1_COLOR_F STDMETHODCALLTYPE d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface) > +static void STDMETHODCALLTYPE d2d_solid_color_brush_GetColor(ID2D1SolidColorBrush *iface, D2D1_COLOR_F *color) > { > static const D2D1_COLOR_F black = {0.0f, 0.0f, 0.0f, 1.0f}; > > FIXME("iface %p stub!\n", iface); > > - return black; > + *color = black; > } Shouldn't it return pointer to D2D1_COLOR_F?

3 2