January 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.
by Jacek Caban Jan. 23, 2015

Jan. 23, 2015

Hi Qian, On 01/23/15 10:19, Qian Hong wrote: > diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c > index 15b0550..656165b 100644 > --- a/dlls/atl/atl_ax.c > +++ b/dlls/atl/atl_ax.c > @@ -1435,8 +1435,9 @@ INT_PTR WINAPI AtlAxDialogBoxA(HINSTANCE hInstance, LPCSTR lpTemplateName, HWND > */ > HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, IUnknown **container, BSTR lic) > { > - FIXME("(%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > - return E_NOTIMPL; > + if (lic) > + FIXME("semi stub (%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > + return AtlAxCreateControl(lpTricsData, hwnd, stream, container); > } > > /*********************************************************************** > @@ -1446,9 +1447,10 @@ HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStrea > HRESULT WINAPI AtlAxCreateControlLicEx(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, > IUnknown **container, IUnknown **control, REFIID iidSink, IUnknown *punkSink, BSTR lic) > { > - FIXME("(%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > + if (lic) > + FIXME("semi stub (%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > debugstr_guid(iidSink), punkSink, debugstr_w(lic)); > - return E_NOTIMPL; > + return AtlAxCreateControlEx(lpTricsData, hwnd, stream, container, control, iidSink, punkSink); > } > > #endif Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add FIXME about unsupported argument instead of the other way around. Otherwise we'd have to do that later to support the argument anyway. Also AtlAxCreateControlLic would probably be better forwarded to AtlAxCreateControlLicEx. Cheers, Jacek

2 1

Re: [PATCH 5/5] wined3d: Use the core version of the shader object functions.
by Henri Verbeet Jan. 23, 2015

Jan. 23, 2015

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + typedef void (WINE_GLAPI *gl_shader_source_type)(GLuint, GLsizei, const GLchar * const *, const GLint*); > + ... > + #define MAP_GL_FUNCTION_CAST(core_func, cast, ext_func) \ > + do \ > + { \ > + if (!gl_info->gl_ops.ext.p_##core_func) \ > + gl_info->gl_ops.ext.p_##core_func = (cast)gl_info->gl_ops.ext.p_##ext_func; \ > + } while (0) ... > + MAP_GL_FUNCTION_CAST(glShaderSource, gl_shader_source_type, glShaderSourceARB); I'm not sure that's really much better than just adding a (void *) cast.

3 4

Re: shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault (try 6)
by Nikolay Sivov Jan. 23, 2015

Jan. 23, 2015

On 23.01.2015 10:24, Alistair Leslie-Hughes wrote: > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, NULL, &size); > + if(ret == ERROR_SUCCESS) > + { > + *association = CoTaskMemAlloc(size * sizeof(WCHAR)); Does it really return length in characters? I thought it's always in bytes. > + if(*association) > + { > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, *association, &size); > + if(ret == ERROR_SUCCESS) > + hr = S_OK; > + } > + } In case of !*association please return earlier with E_OUTOFMEMORY.

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 5)
by Marvin Jan. 23, 2015

Jan. 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11271 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: WineHQ zh_CN Translation Patch Up
by Bruno Jesus Jan. 22, 2015

Jan. 22, 2015

On Thu, Jan 22, 2015 at 2:10 PM, Jeff Bai <jeffbaichina(a)gmail.com> wrote: > Hello fellow developers > > Here is a copy of the patch of changed zh_CN localization from AOSC (Anthon > Open Source Community) L10n project. We've fixed the msgid width problem > which was addressed last time. The patch is large so we put this on our > public PasteBin site, as follows > > https://pastebin.anthonos.org/view/a0c1c1a3 > > Please mail back with any issue over this patch. Hi, please send the email again with the patch as an attachment and I think a more proper subject would be: po: Update Simplified Chinese translation > Keep up the good work! > > Jeff Bai > AOSC Best regards, Bruno

1 0

Re: WineHQ zh_CN Translation Patch Up
by Alex Henrie Jan. 22, 2015

Jan. 22, 2015

Jeff, The best way to submit patches is with `git format-patch` and `git send-email`. It looks like Alexandre won't accept patches submitted via pastebin. -Alex

1 0

Re: ws2_32: Better trace setsockopt/getsockopt
by Bruno Jesus Jan. 22, 2015

Jan. 22, 2015

On Tue, Jan 6, 2015 at 12:49 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > The intention of this patch is to make it easier to read winsock logs, > for setsockopt it even displays the value if its size is less than 5 > bytes. Hi, any complains about this patch? It's pending for 2 weeks now and I think this is a good waiting time to ask. Best Regards, Bruno

2 1

Re: [PATCH 3/5] wined3d: Initialize the last two components of R16G16_SINT attributes.
by Henri Verbeet Jan. 22, 2015

Jan. 22, 2015

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - GL_EXTCALL(glVertexAttrib4svARB(index, ptr)); > + { > + GLshort s[4] = {((const GLshort *)ptr)[0], ((const GLshort *)ptr)[1], 0, 1}; > + GL_EXTCALL(glVertexAttrib4svARB(index, s)); > break; > + } Perhaps I'm missing something, but wouldn't it be much easier to just use glVertexAttrib2svARB() instead?

1 0

Re: [PATCH 6/6] kernel32: Invalid console handles for new processes are 0, not INVALID_HANDLE_VALUE.
by Alistair Leslie-Hughes Jan. 21, 2015

Jan. 21, 2015

On 21/01/15 08:51, Erich E. Hoover wrote: > Several applications rely on the TEB value for fresh invalid console > handles to be zero instead of INVALID_HANDLE_VALUE (fixes Bug #36216 > and Bug #37914). > > +····if·(!params->hStdOutput·||·params->hStdOutput·==·INVALID_HANDLE_VALUE) > +········params->hStdOutput·=·0; The !params->hStdOutput check is redundant since it's already 0. Applies to the other places as well. Best Regards Alistair Leslie-Hughes

2 1

Wine Gecko 2.36-beta1
by Jacek Caban Jan. 21, 2015

Jan. 21, 2015

Hi all, I just uploaded new Wine Gecko beta packages. This time it's based on Firefox 36 beta branch, so it should be pretty stable. To test it please use the attached patch. That's all you need, Wine will download Gecko automatically. Packages are also available on Wine SourceForge if you prefer to download it manually. All testing is appreciated. Regressions and build problems are most important, but all feedback is welcomed. I'm also sending this announcement mingw-w64 mailing list. I know that some distro package maintainers that maintain Wine Gecko packages read it. Beta releases are a good chance to make sure that it builds with toolchains available in distros. Note that the package requires very recent mingw-w64 Git version. A new release on mingw-w64 is planned, so hopefully it will be out before final Wine Gecko release (which is expected in 5-6 weeks). Thanks, Jacek

1 0