January 2015 - Wine-Devel - list.winehq.org

Re: msi: Add a partial implementation of MsiProvideComponent.
by Marvin Jan. 21, 2015

Jan. 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11245 Your paranoid android. === wxppro (32 bit msi) === The test timed out === w7u (32 bit msi) === The test timed out

1 0

Re: msxml3/tests: Actually test the return values (PVS-Studio)
by Michael Stefaniuc Jan. 21, 2015

Jan. 21, 2015

Please ignore, wrong resend. On 01/21/2015 10:48 AM, Michael Stefaniuc wrote: > --- > dlls/msxml3/tests/domdoc.c | 1 + > dlls/msxml3/tests/schema.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index a23fb66..e669de4 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -11085,6 +11085,7 @@ static void test_xmlns_attribute(void) > V_VT(&v) = VT_BSTR; > V_BSTR(&v) = _bstr_("urn:schemas-microsoft-com:datatypes"); > hr = IXMLDOMAttribute_put_nodeValue(pAttribute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > > hr = IXMLDOMElement_setAttributeNode(root, pAttribute, NULL); > ok(hr == S_OK, "ret %08x\n", hr ); > diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c > index f5d6fcd..be18fcf 100644 > --- a/dlls/msxml3/tests/schema.c > +++ b/dlls/msxml3/tests/schema.c > @@ -1292,6 +1292,7 @@ static void test_XDR_datatypes(void) > > VariantClear(&type); > hr = IXMLDOMNode_get_nodeTypedValue(node, &type); > + EXPECT_HR(hr, S_OK); > ok(V_VT(&type) == VT_BSTR, "got variant type %i\n", V_VT(&v)); > VariantClear(&type); > IXMLDOMNode_Release(node); >

1 0

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)
by Michael Stefaniuc Jan. 21, 2015

Jan. 21, 2015

*SIGH* please ignore this one as this is already commited. Pushed out the wrong mailbox. On 01/21/2015 10:43 AM, Michael Stefaniuc wrote: > --- dlls/msxml3/tests/domdoc.c | 1 - 1 file changed, 1 deletion(-) > > diff --git a/dlls/msxml3/tests/domdoc.c > b/dlls/msxml3/tests/domdoc.c index 1a73771..a23fb66 100644 --- > a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ > -4903,7 +4903,6 @@ static void test_xmlTypes(void) > > doc = create_document(&IID_IXMLDOMDocument); > > - pNextChild = (void*)0xdeadbeef; hr = > IXMLDOMDocument_get_nextSibling(doc, NULL); ok(hr == E_INVALIDARG, > "ret %08x\n", hr );

1 0

Re: msxml3/tests: Actually test the return values (PVS-Studio)
by Marvin Jan. 21, 2015

Jan. 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11239 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)
by Marvin Jan. 21, 2015

Jan. 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11238 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin Jan. 21, 2015

Jan. 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11234 Your paranoid android. === w7u (32 bit msg) === msg.c:12108: Test failed: unexpected hwnd 0014013C

1 0

About Patch 108345 Pending ( gdiplus: fix get_clip_hrgn when window origin point changed (try 2) )
by Changhui Liu Jan. 19, 2015

Jan. 19, 2015

Hi, all, I reviewed this path http://source.winehq.org/patches/data/108345, I only found a code style problem: this: + if ( status == Ok && graphics->hdc)should :+ if (status == Ok && graphics->hdc) Could you help me point out the other mistake ? Thanks . ------------------ Regards, Changhui.

2 1

Re: gdi32: Do not enumerate fonts with names that are too long
by Dmitry Timoshkov Jan. 19, 2015

Jan. 19, 2015

Aric Stewart <aric(a)codeweavers.com> wrote: > Both the FullName and the FamilyName need to fit in the LOGFONT > structure. What happens with such a font under Windows? I'd expect the name be simply truncated instead of the font being skipped. In the latter case the font should not be added to the list at all. -- Dmitry.

2 1

Re: [PATCH 8/9] wined3d: Filter messages generated by focus handling.
by Henri Verbeet Jan. 19, 2015

Jan. 19, 2015

On 4 December 2014 at 21:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > We may want to consider moving mode changes, window setup and focus loss > handling into the client libs. With this patch and the next one we have > 3 wined3d flags just for focus loss handling. Furthermore, dxgi yet > again has different behavior - it doesn't hook the window procedure and Yeah, possibly, although I'd also like to keep the amount of Win32 specific stuff in the public wined3d API to a minimum, so I'd rather not have the client libs e.g. handle window messages directly. > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index ae6600e..89ec00a 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4961,7 +4961,7 @@ void device_invalidate_state(const struct wined3d_device *device, DWORD state) > LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL unicode, > UINT message, WPARAM wparam, LPARAM lparam, WNDPROC proc) > { > - if (device->filter_messages) > + if (device->filter_messages && message != WM_DISPLAYCHANGE) That seems pretty specific. I'd be curious how other broadcast messages are handled.

2 2

Re: [PATCH 9/9] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc.
by Henri Verbeet Jan. 19, 2015

Jan. 19, 2015

On 4 December 2014 at 21:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 89ec00a..51dabd4 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4992,6 +4992,16 @@ LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL > > device->device_parent->ops->activate(device->device_parent, wparam); > } > + else if (message == WM_SYSCOMMAND) > + { > + if (wparam == SC_RESTORE && !(device->wined3d->flags & WINED3D_NO_SYSCOMMAND_HANDLING)) I'm not really a fan of this kind of double negative. The way the flag is used, it also seems to be about restores in particular instead of syscommands in general. > + { > + if (unicode) > + DefWindowProcW(window, message, wparam, lparam); > + else > + DefWindowProcA(window, message, wparam, lparam); > + } > + } > > if (unicode) > return CallWindowProcW(proc, window, message, wparam, lparam); Is this really how it's supposed to work? In particular, should DefWindowProc really always get the message before the application does, or should we give the application a chance first, and only pass to DefWindowProc if it doesn't handle the message?

2 2