October 2015 - Wine-Devel - list.winehq.org

Re: mshtml: Add IHTMLEditServices stub implementation. Take 3.
by Marvin Oct. 13, 2015

Oct. 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17315 Your paranoid android. === wxppro (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2003std (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === wvistau64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2008s64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w7u (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w7pro64 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w8 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w864 (32 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w1064 (32 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 === wvistau64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w2008s64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo === w7pro64 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w864 (64 bit htmldoc) === htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 === w1064 (64 bit htmldoc) === htmldoc.c:3003: Test failed: unexpected command 183 htmldoc.c:3555: Test failed: unexpected call IsErrorUrl htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2482: Test failed: unexpected call GetHostInfo htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6370: Test failed: (31) cmdf=00000000, expected 00000003 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:6368: Test failed: (18) cmdf=00000000, expected 00000001 htmldoc.c:6369: Test failed: (19) cmdf=00000000, expected 00000001 htmldoc.c:6371: Test failed: (52) cmdf=00000000, expected 00000001 htmldoc.c:6372: Test failed: (55) cmdf=00000000, expected 00000001 htmldoc.c:6373: Test failed: (57) cmdf=00000000, expected 00000001 htmldoc.c:6374: Test failed: (59) cmdf=00000000, expected 00000001 htmldoc.c:6375: Test failed: (60) cmdf=00000000, expected 00000001 htmldoc.c:6376: Test failed: (56) cmdf=00000000, expected 00000001 htmldoc.c:6377: Test failed: (63) cmdf=00000000, expected 00000001 htmldoc.c:6378: Test failed: (2150) cmdf=00000000, expected 00000001 htmldoc.c:6379: Test failed: (2184) cmdf=00000000, expected 00000001 htmldoc.c:6380: Test failed: (2185) cmdf=00000000, expected 00000001 htmldoc.c:6381: Test failed: (2186) cmdf=00000000, expected 00000001 htmldoc.c:6382: Test failed: (2187) cmdf=00000000, expected 00000001 htmldoc.c:6383: Test failed: (17) cmdf=00000000, expected 00000001 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:2876: Test failed: unexpected state L"uninitialized", expected 4 htmldoc.c:2876: Test failed: VT_I4(out)=0, expected 4 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:875: Test failed: unexpected call htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 101 htmldoc.c:3003: Test failed: unexpected command 132

3 3

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 3).
by Alexandre Julliard Oct. 13, 2015

Oct. 13, 2015

"Erich E. Hoover" <erich.e.hoover(a)wine-staging.com> writes: > + /* set reasonable defaults when requested */ > + if (!bytes_per_send) > + bytes_per_send = 1024; Is that the Windows default? It doesn't seem very reasonable to me, it won't even fill a network packet. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 4).
by Marvin Oct. 12, 2015

Oct. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17307 Your paranoid android. === w2008s64 (64 bit sock) === sock.c:5766: Test failed: Expected event sequence [FD_WRITE(0)], got [] sock.c:5787: Test failed: Expected event sequence [FD_READ(0) FD_CLOSE(0)], got [FD_READ(0) FD_WRITE(0) FD_CLOSE(0)]

1 0

Re: [PATCH 1/2] dxgi: Partially implement dxgi_adapter_CheckInterfaceSupport().
by Henri Verbeet Oct. 12, 2015

Oct. 12, 2015

On 12 October 2015 at 03:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -200,9 +200,39 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_GetDesc(IDXGIAdapter1 *iface, DXGI > static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IDXGIAdapter1 *iface, > REFGUID guid, LARGE_INTEGER *umd_version) > { > - FIXME("iface %p, guid %s, umd_version %p stub!\n", iface, debugstr_guid(guid), umd_version); > + struct dxgi_adapter *adapter = impl_from_IDXGIAdapter1(iface); > + struct wined3d_adapter_identifier adapter_id; > + HRESULT hr; > + > + TRACE("iface %p, guid %s, umd_version %p.\n", iface, debugstr_guid(guid), umd_version); > + > + /* This method works only for D3D10 interfaces. */ > + if (!(IsEqualGUID(guid, &IID_ID3D10Device) > + || IsEqualGUID(guid, &IID_ID3D10Device1))) > + { > + WARN("Returning DXGI_ERROR_UNSUPPORTED for %s.\n", debugstr_guid(guid)); > + return DXGI_ERROR_UNSUPPORTED; > + } > + > + FIXME("Determine actual capabilities of adapter.\n"); Do you know what this does for hardware that doesn't support Direct3D10? Getting the capabilities isn't that hard, we already do that in dxgi_device_init(). (The wined3d_get_device_caps() call in particular.) > #include "dxgi.h" > +#include "d3d10_1.h" If you include d3d10_1.h you should be able to drop dxgi.h.

2 2

Re: [PATCH v2 4/5] d3d9/tests: Uninitialized varyings tests.
by Alexandre Julliard Oct. 12, 2015

Oct. 12, 2015

Matteo Bruni <mbruni(a)codeweavers.com> writes: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > v2: Update to the new helpers interface, fix WARP failures. > > dlls/d3d9/tests/visual.c | 302 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 302 insertions(+) It fails here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:20243: Test failed: Got unexpected color 0xff7fffff, case 19. make: *** [visual.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] mshtml: Add IHTMLEditServices stub implementation. Take 2.
by Jacek Caban Oct. 12, 2015

Oct. 12, 2015

Hi Dmitry, On 10/12/15 05:21, Dmitry Timoshkov wrote: > Thanks Jacek for the comments. > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/mshtml/htmldoc.c | 2 + > dlls/mshtml/main.c | 1 + > dlls/mshtml/mshtml_private.h | 1 + > dlls/mshtml/service.c | 137 +++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 141 insertions(+) The patch looks good to me now, but I still hope to see a test. It should be trivial, we even already have test_QueryService for that. Thanks, Jacek

2 1

Patch tracker emails
by Alexandre Julliard Oct. 12, 2015

Oct. 12, 2015

Folks, As we discussed at WineConf, I have now modified the patch tracker to send a mail whenever a patch status is updated. I'm sure everybody will love that ;-) I tried to make the messages nice and encouraging, but I'm sure there's room for improvement. Feedback is welcome... -- Alexandre Julliard julliard(a)winehq.org

3 4

RFC - d3d9: Return success for UnlockRect attempts on already unlocked surfaces
by Bruno Jesus Oct. 12, 2015

Oct. 12, 2015

Hi all, this is an attempt to fix bug 28874 [1]. The tests [2] run fine up to Windows 8, which unfortunately introduced a change in the behavior so I'm not sure how to handle this (broken?). Maybe a similar test is required in other d3d versions and a deeper change (wined3d_surface_unmap?) required to proper fix this. [1] - https://bugs.winehq.org/show_bug.cgi?id=28874 [2] - https://testbot.winehq.org/JobDetails.pl?Key=17252 Best wishes, Bruno

3 2

Re: [PATCH 2/3] user32: Send WM_COMMAND to parent window, not parent control.
by Marvin Oct. 12, 2015

Oct. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17285 Your paranoid android. === w1064 (32 bit msg) === msg.c:6100: Test failed: Update region shouldn't be empty msg.c:6334: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6336: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6100: Test failed: Update region shouldn't be empty msg.c:6334: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6336: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different msg.c:6106: Test failed: Regions are different

1 0

Re: [PATCH 1/3] user32: Test button parent messages.
by Marvin Oct. 12, 2015

Oct. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17284 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10622: Test failed: expected PeekMessage to return FALSE, got 1 === w1064 (32 bit msg) === msg.c:6103: Test failed: Update region shouldn't be empty msg.c:6337: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6339: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6103: Test failed: Update region shouldn't be empty msg.c:6337: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6339: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different msg.c:6109: Test failed: Regions are different

1 0

Re: [PATCH 2/2] dxgi/tests: Add test for IDXGIAdapter::CheckInterfaceSupport().
by Marvin Oct. 12, 2015

Oct. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17277 Your paranoid android. === w1064 (32 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1242: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1242: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1242: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1188: Test failed: Got unexpected hr 0, test 39. device.c:1242: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1242: Test failed: Got usage 160, expected 60, test 42, buffer 15. === w1064 (64 bit device) === device.c:1188: Test failed: Got unexpected hr 0, test 16. device.c:1188: Test failed: Got unexpected hr 0x87a0001, test 39.

1 0

Re: [PATCH 3/3] ws2_32: Add asynchronous support for TransmitFile (resend).
by Marvin Oct. 12, 2015

Oct. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17267 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7346: Test failed: bytesReturned isn't supposed to be 1 sock.c:7370: Test failed: GetOverlappedResult failed, error 0

1 0

Speed of gdi vs opengl DirectDrawRenderer
by Jonas Maebe Oct. 11, 2015

Oct. 11, 2015

Hi, I had a problem with Majesty Gold HD running at glacial speed on my machine (quad Core i5 2.9GHz, NVidia GeForce GT 750M 1GB, OS X 10.9.5). I'm using wine 1.7.35, but I've had similar problems with older wine versions. It's a DirectDraw7 game that has been partially remastered to run on modern systems, but still uses DirectDraw7. This is a common problem on Windows too, but generally can be resolved by telling the game to use the DirectDraw blitter (instead of blitting itself). That didn't help on Wine though. I profiled wine (Instruments time profile) and noticed that most time was spent in wined3d's convert_r5g6b5_x8r8g8b8. Replacing that routine with an optimized sse2 version from pixman did not make much of a difference. Then I discovered that if I told the game to render to a 16 bit instead of to a 32 bit surface, wine would let OpenGL handle the colour conversion. Unfortunately, while this significantly reduced wine's cpu usage, it by no means made the game any faster. Looking at the OpenGL Driver Monitor stats, it seems the cpu was simply waiting all the time on the GPU, probably while it was blitting all of those 1920x1080 images to the screen. Reducing the resolution to the lowest supported by the game (800x600) made it slightly faster, but not much. Next, I added the DirectDrawRenderer registry key and set it to gdi. Now, while it's still slow at 1920x1080, the game runs much faster at 800x600 and even still at 1024x768. Profiling the gdi renderer shows that it has way higher cpu usage than the OpenGL renderer (virtually all in convert_to_8888), but it seems that for some reason it has causes much less traffic to the GPU. The wiki's wording suggests the gdi renderer is deprecated though. Does that mean this qualifies as a bug in the OpenGL renderer (maybe it tries to update the screen more often than necessary, saturating the bus that way?), and are there any things I can try to narrow down why the gdi renderer is so much faster? I didn't immediately see where it blits things actually to the screen. Thanks, Jonas

4 10

Total bugs in WWN Issue 400
by Mathew Hodson Oct. 11, 2015

Oct. 11, 2015

How is it that in WWN Issue 400, https://www.winehq.org/wwn/400, the total number of bugs has decreased? Was that an error or have some bugs been deleted? -- Sincerely, Mathew Hodson

4 4

wiki.winehq.org is down
by Austin English Oct. 11, 2015

Oct. 11, 2015

Thought it may be my connection while travelling, but isup.me confirms it's down: http://isup.me/wiki.winehq.org could you please have a look? Thanks, -Austin

3 2

Re: [PATCH 1/6] d3d8: make use of wined3d_texture_map in d3d8_surface_LockRect
by Stefan Dösinger Oct. 11, 2015

Oct. 11, 2015

2 1

stack realignment
by Marcus Meissner Oct. 11, 2015

Oct. 11, 2015

Hi, (as small heads up) As we have this problem with the Win64 code calling us with non-16 byte aligned stacks, the gcc folks have now commited code to trunk gcc that allows -mincoming-stack-boundary=3 on October 7th. Uros also plans a backport for gcc 5. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66697 $ cat xx.c #include <stdio.h> int f(int a,int b) { printf("a=%d, b=%d\n", a, b); } -O2 build: 0000000000000000 <f>: 0: 89 f2 mov %esi,%edx 2: 31 c0 xor %eax,%eax 4: 89 fe mov %edi,%esi 6: bf 00 00 00 00 mov $0x0,%edi b: e9 00 00 00 00 jmpq 10 <f+0x10> -O2 -mincoming-stack-boundary=3 0000000000000000 <f>: 0: 4c 8d 54 24 08 lea 0x8(%rsp),%r10 5: 48 83 e4 f0 and $0xfffffffffffffff0,%rsp 9: 89 f2 mov %esi,%edx b: 31 c0 xor %eax,%eax d: 89 fe mov %edi,%esi f: bf 00 00 00 00 mov $0x0,%edi 14: 41 ff 72 f8 pushq -0x8(%r10) 18: 55 push %rbp 19: 48 89 e5 mov %rsp,%rbp 1c: 41 52 push %r10 1e: 48 83 ec 08 sub $0x8,%rsp 22: e8 00 00 00 00 callq 27 <f+0x27> 27: 48 83 c4 08 add $0x8,%rsp 2b: 41 5a pop %r10 2d: 5d pop %rbp 2e: 49 8d 62 f8 lea -0x8(%r10),%rsp 32: c3 retq It is more code emitted, but we can at least fix it without generating our own thunks. Ciao, Marcus

2 2

WineConf 2015 decisions
by Alexandre Julliard Oct. 10, 2015

Oct. 10, 2015

Over the last few months there have been a lot of discussions about how to improve our development process. I've been gathering feedback, and last week at WineConf I summarized the suggestions in my keynote presentation; the slides can be viewed at http://wiki.winehq.org/WineConf2015?action=AttachFile&do=get&target=winecon… We've then had a lot of constructive discussions about the various points. The major decisions we've agreed on are: - Wine-staging is now considered an integral part of the Wine development process, and will be used as a mechanism to enable more patches to meet the requirements for inclusion in the main tree. We will all be working together as a team. - Bugs reported against wine-staging will be accepted in the WineHQ bug tracker; there will be a way to distinguish bugs specific to Staging, and bugs that are fixed in Staging but not yet in main Wine. The Staging bug tracker will be retired. Austin English is in charge of implementing the necessary changes in Bugzilla. - We will switch to a time-based stable release, on a yearly schedule. The code freeze will start every year in the fall. Michael Stefaniuc will be maintaining the stable branch starting with 1.8. - We will start enforcing a Signed-Off-By header on patches, to make it possible to better distribute reviewing responsibility, and to allow multiple authors to cooperate on a patch. - We will keep a list of maintainer contact information for the various submodules; developers will be encouraged to go through the respective maintainer before submitting to wine-patches. - There will be a group of people who volunteer to be assigned patches to review, to make sure that no patch goes unreviewed. Going through Staging first will also be encouraged for unfinished or risky patches. - The patch tracker will send automated emails when a patch status changes; this will also serve to encourage discussion rather than despair when a patch is not approved. - We will start building and distributing binary packages for all distros that don't have readily available packages. The packaging scripts and control files will be maintained in git, so that people can review them and submit improvements. These changes will be implemented over the next few weeks. I'm hoping that this will make the development process more pleasant for everybody, and enable us to better respond to users' needs. Once these changes are in place, I'll also encourage everybody who had given up in disgust to give us another chance; and if things are still not satisfactory, please send us feedback. This is a work in progress, and we will continue to listen and work on making things better. -- Alexandre Julliard julliard(a)winehq.org

9 17

Re: kernel32: add a stub for GetCurrentProcessorNumberEx (try 2)
by Sebastian Lackner Oct. 9, 2015

Oct. 9, 2015

On 09.10.2015 12:15, Austin English wrote: > Try 2: > move implementation to ntdll.RtlGetCurrentProcessorNumberEx with a > forward from kernel32. > Initialize Group/Processor to 0. > > For https://bugs.winehq.org/show_bug.cgi?id=39376 > > +/********************************************************************** > + * RtlGetCurrentProcessorNumberEx [NTDLL.@] > + */ > +VOID WINAPI RtlGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER processor) I think its preferred to use PROCESSOR_NUMBER * here. > +{ > + processor->Group = 0; > + processor->Number = 0; The ->Number member could be initialized to the result to NtGetCurrentProcessorNumber(). Initializing ->Group to 0 is correct because Wine supports max 64 processors. According to MSDN, the struct also has a ->Reserved member, which probably should be set to zero. > + > + FIXME(":%p stub\n", processor); It might be better to print the FIXME before accessing the pointer, this allows to see if applications pass garbage pointers before the crash happens. ;) > +}

2 1

Re: [PATCH 5/5] maintainers: Update Direct3D-related sections.
by Stefan Dösinger Oct. 9, 2015

Oct. 9, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-09 um 15:55 schrieb Matteo Bruni: > Stefan, I'm putting d3drm under the general Direct3D section at > the moment. Feel free to change that as you see fit. Fine with me :-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWF8a0AAoJEN0/YqbEcdMw96oP/j1MyVZNxrVNRFg7v6K1b6Zn mTbnDc17oZbrJOnUYTNs+FJhaCvffj5wFRh8dB1piX6ayMpvItzoTOFnYzhYowIS iElwL/V7iYr8x4fojbrn8OestiaI7j41Rv4jlTNLfcnMtbbBYonM3oxDkFxJhQPp lsKw5/qOPfDpw2RFry5d3FTbhpKcy6vdQHPcCa4fb0E/pHvvCtwCH00pje5TIO7b fV2FUl8YEbMHpP1W1zY9m2jWDuPk3ke14g/KsGBXcB3PVZUtqPw4Tb4hCjBsXEzr WMyv3LqLw3vvWwtGpN49pLSAE0jHiSMCbH1fq4kNsZkT7TdB3he7vce1ckzRQWKh cvL1DmrL4TfVv1nH3bENX9I80I5SDRlg8EFWI/BYQZgNGun4fXweslHZISBz4CqZ VpZO/PpDOtM6DJhDXn0WDgYqNKC7GsLsx8TPsNpLPt+f/aSM+0ozZUmwDWtZW1HX m0lwn2sXoJzVwZ858ukmLRh8KtXJhl3Nupp0Eppa3IbYCwZOWERcwyhSDV6CB5gD lLmff2NPBirX7/yAC3D5NXEcvIxEk7nJPi01EY+b8iofIlrIUHzfrNeKkEpDAv89 oM9DwD7ZwzO5ga8EDYMdDGV/UhmZlFRAWyYC9oz4M8QGyiHwmtuA6VGgGiYtCYjy /jvROBtdjkiTTUpb24i4 =mAJR -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/6] hidclass.sys: Add a processing thread for HID devices
by Nikolay Sivov Oct. 9, 2015

Oct. 9, 2015

On 08.10.2015 22:34, Aric Stewart wrote: > + buffer_size = RingBuffer_GetBufferSize(ext->ring_buffer); > + RingBuffer_Read(ext->ring_buffer, ptr, packet, &buffer_size); No idea what's going on there, but first call seems to be redundant. Also maybe it makes sense to make RingBuffer_Read return size since it's out-only argument right now?

2 1

Re: [PATCH 1/2] dbghelp: Parse DW_TAG_pointer_type inside dwarf2_parse_subprogram_block.
by Qian Hong Oct. 9, 2015

Oct. 9, 2015

Sorry, typo in commit message, will resend soon, thanks Michael Müller.

1 0

Re: ntdll: Implement RtlValidRelativeSecurityDescriptor.
by Marcus Meissner Oct. 9, 2015

Oct. 9, 2015

On Fri, Oct 09, 2015 at 06:20:50PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ntdll/ntdll.spec | 2 +- > dlls/ntdll/sec.c | 9 +++++++++ > include/winternl.h | 1 + > 3 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index ca3561d..1e68ef3 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -936,7 +936,7 @@ > @ stub RtlUsageHeap > @ cdecl -i386 -norelay RtlUshortByteSwap() NTDLL_RtlUshortByteSwap > @ stdcall RtlValidAcl(ptr) > -# @ stub RtlValidRelativeSecurityDescriptor > +@ stdcall RtlValidRelativeSecurityDescriptor(ptr long long) > @ stdcall RtlValidSecurityDescriptor(ptr) > @ stdcall RtlValidSid(ptr) > @ stdcall RtlValidateHeap(long long ptr) > diff --git a/dlls/ntdll/sec.c b/dlls/ntdll/sec.c > index 360a579..bc5d5a3 100644 > --- a/dlls/ntdll/sec.c > +++ b/dlls/ntdll/sec.c > @@ -558,6 +558,15 @@ NTSTATUS WINAPI RtlValidSecurityDescriptor( > } > > /************************************************************************** > + * RtlValidRelativeSecurityDescriptor [NTDLL.@] > + */ > +BOOLEAN WINAPI RtlValidRelativeSecurityDescriptor(PSECURITY_DESCRIPTOR descriptor, > + ULONG length, SECURITY_INFORMATION info) > +{ > + return RtlValidSecurityDescriptor(descriptor) == STATUS_SUCCESS; > +} Perhaps add a semi-stub FIXME message, in case some app needs the behaviour triggered by the other arguments? Ciao, Marcus

1 0

Re: mshtml: Add IHTMLEditServices stub implementation.
by Jacek Caban Oct. 9, 2015

Oct. 9, 2015

Hi Dmitry, Please add a test. A very simple one that just calls QueryService and checks its return will be enough. I can see that you used undo mgr as an example, but it has its problems that I'd rather avoid in new code, so it would be nice to improve the patch. On 10/09/15 05:53, Dmitry Timoshkov wrote: > +static HRESULT WINAPI editsvcs_QueryInterface(IHTMLEditServices *iface, REFIID riid, void **ppv) > +{ > + editsvcs *This = impl_from_IHTMLEditServices(iface); > + > + if(IsEqualGUID(riid, &IID_IUnknown)) { > + TRACE("(%p)->(IID_IUnknown %p)\n", This, ppv); > + *ppv = &This->IHTMLEditServices_iface; > + } else if(IsEqualGUID(riid, &IID_IHTMLEditServices)) { > + TRACE("(%p)->(IID_IHTMLEditServices %p)\n", This, ppv); > + *ppv = &This->IHTMLEditServices_iface; > + } else { > + *ppv = NULL; > + FIXME("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppv); > + return E_NOINTERFACE; > + } Please use debugstr_mshtml_guid and add IHTMLEditServices there. > + > +static IHTMLEditServices *create_editsvcs(void) > +{ > + editsvcs *ret = heap_alloc(sizeof(*ret)); Please handle heap_alloc failure here. > + > + ret->IHTMLEditServices_iface.lpVtbl = &editsvcsVtbl; > + ret->ref = 1; > + > + return &ret->IHTMLEditServices_iface; > +} > + > /********************************************************** > * IServiceProvider implementation > */ > @@ -259,6 +381,15 @@ static HRESULT WINAPI ServiceProvider_QueryService(IServiceProvider *iface, REFG > return IWindowForBindingUI_QueryInterface(&This->doc_obj->IWindowForBindingUI_iface, riid, ppv); > } > > + if(IsEqualGUID(&SID_SHTMLEditServices, guidService)) { > + FIXME("SID_SHTMLEditServices\n"); I think it should be TRACE. Thanks, Jacek

1 0

Re: [PATCH 3/4] ole32: Add a stub for OleCreateFromFileEx.
by Dmitry Timoshkov Oct. 9, 2015

Oct. 9, 2015

Huw Davies <huw(a)codeweavers.com> wrote: > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -189,7 +189,7 @@ > @ stdcall OleCreateFromData(ptr ptr long ptr ptr ptr ptr) > @ stdcall OleCreateFromDataEx(ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr) > @ stdcall OleCreateFromFile(ptr ptr ptr long ptr ptr ptr ptr) > -@ stub OleCreateFromFileEx > +@ stdcall OleCreateFromFileEx(ptr ptr ptr long long long ptr ptr ptr ptr ptr ptr ptr) The 2nd parameter should be str, but that's not your fault, probably you've just copied and extended the OleCreateFromFile entry :) -- Dmitry.

2 2