October 2015 - Wine-Devel - list.winehq.org

Re: [4/4] dlls/ole32: Add more traces to the storage methods.
by Vincent Povirk Nov. 1, 2015

Nov. 1, 2015

On Thu, Oct 29, 2015 at 2:41 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > > static HRESULT TransactedSnapshotImpl_GetTransactionSig(StorageBaseImpl *base, > ULONG* result, BOOL refresh) > { > + FIXME("stub\n"); > return E_NOTIMPL; > } This is intentional. We don't need transaction signatures because nothing else can have our snapshot open to commit to it. Anything calling these methods should expect and handle E_NOTIMPL.

2 3

Re: [2/4] dlls/ole32: Zero out returned stats when IEnumSTATSTG::Next reaches end of enumeration.
by Vincent Povirk Oct. 31, 2015

Oct. 31, 2015

Are you sure we shouldn't be zeroing the entire remaining buffer? And maybe we should put it after the loop, given there are multiple exits.

2 1

Re: [PATCH 4/4] winex11: Make color cubes as big as possible.
by Vincent Povirk Oct. 31, 2015

Oct. 31, 2015

Sorry, I don't think I'm qualified to review this. There's too much context here that I don't understand.

1 0

Re: [PATCH 01/4] msvcp110: Add tr2_sys__Open_dir implementation.(try 4)
by Piotr Caban Oct. 31, 2015

Oct. 31, 2015

On 10/29/15 16:28, YongHao Hu wrote: > + char temppath[MAX_PATH+1]; > + TRACE("(%p %s %p %p)\n", target, debugstr_a(dest), err_code, type); > + if(strlen(dest) >= MAX_PATH) { > + *err_code = ERROR_BAD_PATHNAME; > + return NULL; > + } > + strcpy(temppath, dest); > + strcat(temppath, "\\*"); There may still write outside of temppath array in this code. Thanks, Piotr

2 1

Re: [7/7] oleaut32/tests: Add a bunch of new tests for typelib generation.
by Marvin Oct. 31, 2015

Oct. 31, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17862 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w2003std (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === wvistau64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w2008s64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w7u (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w7pro64 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w8 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w864 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === w1064 (32 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 20 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 16 typelib: unhandled exception c0000005 at 00420ACA === wvistau64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w2008s64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w7pro64 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w864 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933 === w1064 (64 bit typelib) === typelib.c:4570: Test failed: bstrIfName expected "_n" got "child_iface" typelib.c:4574: Test failed: typeattr->typekind expected 1 got 3 typelib.c:4589: Test failed: typeattr->cbSizeInstance expected 4 got 8 typelib.c:4591: Test failed: help_ctx expected 3 got 0 typelib.c:4592: Test failed: ((LONG)(((WORD)((DWORD_PTR)(typeattr->wMinorVerNum) & 0xFFFF)) | ((DWORD)((WORD)((DWORD_PTR)(typeattr->wMajorVerNum) & 0xFFFF))) << 16)) expected 65538 got 0 typelib.c:4593: Test failed: typeattr->cbSizeVft expected 0 got 40 typelib.c:4594: Test failed: typeattr->cFuncs expected 0 got 1 typelib.c:4606: Test failed: got wrong guid {b14b6bb5-904e-4ff9-b247-bd361f7aa002} typelib.c:4625: Test failed: desc->memid expected 0 got 1610743808 typelib.c:4626: Test failed: desc->funckind expected 0 got 1 typelib.c:4627: Test failed: desc->invkind expected 0 got 1 typelib.c:4628: Test failed: desc->callconv expected 0 got 4 typelib.c:4631: Test failed: desc->oVft got 32 typelib: unhandled exception c0000005 at 000000000041E933

1 0

Release plans
by Alexandre Julliard Oct. 30, 2015

Oct. 30, 2015

Folks, We've decided at WineConf that there would be a code freeze and release every year in the fall. That means about right now... However, there are a few things I'd like to get in first (*cough* Pulse driver), so my thinking is to do one more development release cycle, and start code freeze after 1.7.55. This should enable us to release 1.8 before the end of the year. So if there are new features you'd like to get into 1.8, you have another two weeks... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: Silently ignore temporary foreground loss (v2).
by Marvin Oct. 30, 2015

Oct. 30, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17854 Your paranoid android. === w1064 (32 bit win) === win.c:6708: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6708: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6708: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6708: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 === w1064 (64 bit win) === win.c:6708: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6730: Test failed: 0x80/0x1050000: window rect 0,0-1024,768

1 0

Re: [PATCH 2/3] msvcp120: implement _Thrd_current
by Piotr Caban Oct. 30, 2015

Oct. 30, 2015

On 10/29/15 15:50, Daniel Lehman wrote: > +_Thrd_t __cdecl _Thrd_current(void) The __cdecl calling convention is not compatible in this case. You will need to do something similar as is done in _Getcoll implementation. Unless I'm missing something, quick look on _Getcoll shows that it's broken when _MSVCP_VER>=110 and 64-bit wine is compiled. I'll take a look on it. Thanks, Piotr

1 1

Re: [1/2] ole32: Accept TYMED_FILE as a possible source of CF_METAFILEPICT format.
by Huw Davies Oct. 30, 2015

Oct. 30, 2015

B1;2cOn Fri, Oct 23, 2015 at 06:32:17PM +0800, Dmitry Timoshkov wrote: > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index caabd10..3db0edf 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -285,7 +285,7 @@ static DataCacheEntry *DataCache_GetEntryForFormatEtc(DataCache *This, const FOR > static HRESULT check_valid_clipformat_and_tymed(CLIPFORMAT cfFormat, DWORD tymed) > { > if (!cfFormat || !tymed || > - (cfFormat == CF_METAFILEPICT && tymed == TYMED_MFPICT) || > + (cfFormat == CF_METAFILEPICT && (tymed == TYMED_MFPICT || tymed == TYMED_FILE)) || > (cfFormat == CF_BITMAP && tymed == TYMED_GDI) || > (cfFormat == CF_DIB && tymed == TYMED_HGLOBAL) || > (cfFormat == CF_ENHMETAFILE && tymed == TYMED_ENHMF)) This should be easy enough to test. Create a stand-alone data cache ( using CreateDataCache() ), then call IOleCache_Cache with the relevant fmtetc. Huw.

2 2

Re: [PATCH 1/3] msvcp120: implement _Thrd_sleep/yield (try 2)
by Piotr Caban Oct. 30, 2015

Oct. 30, 2015

On 10/29/15 23:04, Daniel Lehman wrote: > + ok((diff > 2000 - TIMEDELTA) && (diff < 2000 + TIMEDELTA), "got %d", diff); This test is occasionally failing on my Windows 7 box (is most cases diff ~= 2165, biggest value I've seen is diff = 2771). I think that it should be enough to just test diff>2000-TIMEDELTA. New line character is also missing here. Thanks, Piotr

1 0