November 2015 - Wine-Devel - list.winehq.org

test
by André Hentschel Nov. 10, 2015

Nov. 10, 2015

please ignore, sorry for the noise

1 0

Re: [PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Dmitry Timoshkov Nov. 10, 2015

Nov. 10, 2015

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +BOOL WINAPI EnumTimeFormatsA(TIMEFMT_ENUMPROCA proc, LCID lcid, DWORD flags) > { > - WCHAR buf[256]; > + struct enumtimeformats_context ctxt; > > - if (!proc) > + /* EnumTimeFormatsA doesn't support flags, EnumTimeFormatsW does. */ > + if (flags & ~LOCALE_USE_CP_ACP) > { > - SetLastError(ERROR_INVALID_PARAMETER); > + SetLastError(ERROR_INVALID_FLAGS); Is there any particular reason that you need 3/4 in order to fix something you've added in 2/4? This looks like badly tested code. -- Dmitry.

1 0

Re: [PATCH 3/4] kernel32: Added support for TIME_NOSECONDS, restructured EnumTimeFormats implementation
by Marvin Nov. 10, 2015

Nov. 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18065 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4152: Test failed: IsValidLocaleName should have failed locale.c:4154: Test failed: IsValidLocaleName should have failed locale.c:4519: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4521: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [PATCH 1/4] kernel32: GetLocaleInfoA() doesn't support LOCALE_SSHORTTIME
by Marvin Nov. 10, 2015

Nov. 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18064 Your paranoid android. === w1064 (32 bit locale) === locale.c:2337: Test failed: LCMapStringEx should fail with bad locale name locale.c:2338: Test failed: unexpected error code -559038737 locale.c:2429: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4155: Test failed: IsValidLocaleName should have failed locale.c:4157: Test failed: IsValidLocaleName should have failed locale.c:4522: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4524: Test failed: For id 7, Expected IVC, got ''

1 0

Re: [v7 07/10] ddraw7/tests: Test SetColorKey() on cubemap surfaces.
by Marvin Nov. 10, 2015

Nov. 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18063 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2243: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3084: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3086: Test failed: Got unexpected screen width 1024. ddraw7.c:3088: Test failed: Got unexpected screen height 768. ddraw7.c:3101: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3103: Test failed: Got unexpected screen width 1024. ddraw7.c:3105: Test failed: Got unexpected screen height 768. ddraw7.c:3109: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3111: Test failed: Got unexpected screen width 1024. ddraw7.c:3113: Test failed: Got unexpected screen height 768. ddraw7.c:3132: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3134: Test failed: Got unexpected screen width 1024. ddraw7.c:3136: Test failed: Got unexpected screen height 768. ddraw7.c:3140: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3142: Test failed: Got unexpected screen width 1024. ddraw7.c:3144: Test failed: Got unexpected screen height 768. ddraw7.c:3164: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3166: Test failed: Got unexpected screen width 1024. ddraw7.c:3168: Test failed: Got unexpected screen height 768. ddraw7.c:3173: Test failed: Got unexpected screen width 1024. ddraw7.c:3175: Test failed: Got unexpected screen height 768. ddraw7.c:3188: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3190: Test failed: Got unexpected screen width 1024. ddraw7.c:3192: Test failed: Got unexpected screen height 768. ddraw7.c:3196: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3198: Test failed: Got unexpected screen width 1024. ddraw7.c:3200: Test failed: Got unexpected screen height 768. ddraw7.c:3208: Test failed: Got unexpected screen width 1024. ddraw7.c:3210: Test failed: Got unexpected screen height 768. ddraw7.c:3222: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3224: Test failed: Got unexpected screen width 1024. ddraw7.c:3226: Test failed: Got unexpected screen height 768. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4081: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4094: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4110: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4129: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:4035: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5937: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

1 0

Re: [PATCH 1/2] winemac: Check the window's display link after adding it as a child of another window, which may order it on screen.
by Huw Davies Nov. 10, 2015

Nov. 10, 2015

On 10 Nov 2015, at 02:31, Ken Thomases wrote: > This fixes a problem where child windows ("owned" windows in Windows parlance) > would never display their contents on OS X 10.8 or earlier. Beginning with > 10.9, Cocoa calls -windowDidChangeOcclusionState: when the window becomes > visible, which is why they display on that version and later. > --- > Reported by Huw Davies. Works great, thanks! Huw.

1 0

Re: [PATCH 1/2] winemac: Use CVDisplayLink to limit window redrawing to the display refresh rate. (try 2)
by Huw Davies Nov. 10, 2015

Nov. 10, 2015

Thanks Ken, Just confirming that this series now builds for me on 10.7 Huw.

3 3

How to change the ACCESS_MASK of a thread?
by Bruno Jesus Nov. 9, 2015

Nov. 9, 2015

Hi all. I have a simple question that I could not find an answer after looking for a lot. All I need is to remove the THREAD_SUSPEND_RESUME flag from the ACCESS_MASK to add it again later. info.GrantedAccess = 0; NtQueryObject(GetCurrentThread(), ObjectBasicInformation, &info, sizeof(info), NULL); if (info.GrantedAccess & THREAD_SUSPEND_RESUME) { changed = TRUE; info.GrantedAccess &= ~THREAD_SUSPEND_RESUME; //magic here } This is about fixing bug 3930 where SuspendThread is called from inside a callback deadlocking the game. If I can prevent the SuspendThread from running it will work. Best wishes, Bruno

1 0

Re: [PATCH] msvcp120: implement _Cnd_* functions (try 2)
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/09/15 16:38, Daniel Lehman wrote: > +static int (__cdecl*p__Mtx_init)(_Mtx_t*); This function has different header. > + if (0) /* causes crash in later_Cnd_* calls on Windows */ > + p__Cnd_destroy(&cm.cnd); This is not what I meant. I'm attaching a patch (generated on top of yours with the test I had in mind). It only shows the problem, the test needs more work. > + for(i = 0; i < NUM_THREADS; i++) > + p__Thrd_create(&threads[i], cnd_bcast_thread, (void*)&cm); ... > + p__Mtx_lock(&mtx); > + cm.go = 1; > + p__Mtx_unlock(&mtx); Please add some kind of synchronization to make sure the thread is waiting on condition variable before setting cm.go to 1. > + cm.go = 0; > + p__Thrd_create(&threads[0], cnd_signal_thread, (void*)&cm); > + p__Mtx_lock(&mtx); > + while(!cm.go) { > + r = p__Cnd_wait(&cnd, &mtx); > + ok(!r, "failed to wait\n"); > + } Here's a similar synchronization problem. In most cases p__Cnd_wait will not be called. > + diff = p__Xtime_diff_to_millis2(&after, &before); > + ok(r == 2, "should have timed out\n"); > + ok(diff > 2000 - TIMEDELTA, "got %d\n", diff); This test failed once on my computer (in ~10 runs, diff == 1800). Thanks, Piotr

1 0

Re: [PATCH v2 3/3] msvcp140: Add MSVC 2015 C++ support DLL
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/06/15 13:51, Martin Storsjo wrote: > static void init_cxx_funcs(void) > { > @@ -77,6 +125,11 @@ static void init_cxx_funcs(void) > > if (!hmod) FIXME( "%s not loaded\n", MSVCRT_NAME(_MSVCP_VER) ); > > +#if _MSVCP_VER >= 140 > + MSVCRT_operator_new = operator_new; > + MSVCRT_operator_delete = operator_delete; > + MSVCRT_set_new_handler = (void*)GetProcAddress(hmod, "_set_new_handler"); > +#else > if (sizeof(void *) > sizeof(int)) /* 64-bit has different names */ > { > MSVCRT_operator_new = (void*)GetProcAddress(hmod, "??2(a)YAPEAX_K@Z"); > @@ -113,6 +166,7 @@ static void init_cxx_funcs(void) > #endif > #endif /* _MSVCP_VER >= 110 */ > } > +#endif > } Please also initialize critical_section related functions. Thanks, Piotr

1 0

Re: [PATCH] msvcp120: implement _Cnd_* functions
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/07/15 00:58, Daniel Lehman wrote: > +void __cdecl _Cnd_destroy(_Cnd_t *cnd) > +{ > + MSVCRT_operator_delete(*cnd); > +} What happens when _Cnd_destroy is called while someone waits on condition variable? > +int __cdecl _Cnd_timedwait(_Cnd_t *cnd, _Mtx_t *mtx, const xtime *xt) > +{ > + CONDITION_VARIABLE *cv = &(*cnd)->cv; > + LARGE_INTEGER timeout; > + NTSTATUS status; > + > + InterlockedExchangeAdd( (LONG *)&cv->Ptr, 1 ); > + _Mtx_unlock(mtx); > + > + timeout.QuadPart = (ULONGLONG)_Xtime_diff_to_millis(xt) * -10000; > + status = NtWaitForKeyedEvent(keyed_event, &cv->Ptr, FALSE, &timeout); > + if (status) > + { > + if (!interlocked_dec_if_nonzero( (LONG *)&cv->Ptr )) > + NtWaitForKeyedEvent( keyed_event, &cv->Ptr, FALSE, NULL ); You need to update status here. Thanks, Piotr

2 1

Re: [1/5] gdi32: Fix the advance width in synthetic bold glyphs when using scaling factors. (try 2)
by Alexandre Julliard Nov. 9, 2015

Nov. 9, 2015

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 2: > - Rename the vector normalization function name and returns > calculated value. > - Avoid division by zero. > Thanks Huw and Henri. > > Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> > --- > dlls/gdi32/freetype.c | 50 ++++++++++++++++++++++++++++++++++--------------- > dlls/gdi32/tests/font.c | 10 ++++++++++ > 2 files changed, 45 insertions(+), 15 deletions(-) It breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M gdi32.dll -p gdi32_test.exe.so font && touch font.ok font.c:389: Test failed: cx 221 != 243 font.c:389: Test failed: cx 221 != 243 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] odbccp32: Implement SQLGetPrivateProfileStringW/SQLGetPrivateProfileString (try 3)
by Alexandre Julliard Nov. 9, 2015

Nov. 9, 2015

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Corrected formatting. > Use strlen where approperate. > Improved tests to show that we cannot write directly to the buffer passed in. It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M odbccp32.dll -p odbccp32_test.exe.so misc && touch misc.ok misc.c:273: Test failed: incorrect string 'testing' make[1]: *** [misc.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] d3d9/tests: Improve the shade mode test.
by Henri Verbeet Nov. 9, 2015

Nov. 9, 2015

On 8 November 2015 at 20:25, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > dlls/d3d9/tests/visual.c | 275 ++++++++++++++++++++++++++++++++--------------- > 1 file changed, 191 insertions(+), 84 deletions(-) > I think most of this test would work for d3d8 and ddraw as well. Could you please port it? > + {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_FLAT, FALSE, 0x00ff0000, 0x0000ff00}, > + {&novs, &ps_3, D3DPT_TRIANGLESTRIP, D3DSHADE_GOURAUD, FALSE, 0x000dca28, 0x000d45c7}, These fail here on Windows: visual.c:8338: Test failed: Test 14 shading has color0 00ffffff, expected 00ff0000. visual.c:8340: Test failed: Test 14 shading has color1 00ffffff, expected 0000ff00. visual.c:8338: Test failed: Test 15 shading has color0 00ffffff, expected 000dca28. visual.c:8340: Test failed: Test 15 shading has color1 00ffffff, expected 000d45c7. IIRC SM3 vertex and pixel shaders need to be used together, or results are undefined / implementation defined.

2 1

Re: [PATCH 3/9] d3d11/tests: Port test_texture() from d3d10core.
by Henri Verbeet Nov. 9, 2015

Nov. 9, 2015

On 6 November 2015 at 18:38, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + for (i = 0; i < 4; ++i) > + { > + for (j = 0; j < 4; ++j) > + { > + color = get_texture_color(backbuffer, 80 + j * 160, 60 + i * 120); > + ok(compare_color(color, bitmap_data[j + i * 4], 1), > + "Got unexpected color 0x%08x at (%u, %u), expected 0x%08x.\n", > + color, j, i, bitmap_data[j + i * 4]); > + } > + } It's not a terribly high priority, but Matteo recently introduced get_rt_readback()/release_surface_readback() in the d3d8/9 tests. We'll want to introduce that interface in the d3d10/11 tests as well.

1 0

Re: [PATCH v4] ucrtbase: Hook up _seh_filter_exe and _seh_filter_dll
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/09/15 12:36, Martin Storsjo wrote: > +@ cdecl _seh_filter_dll(long ptr) __CppXcptFilter > +@ cdecl _seh_filter_exe(long ptr) __CppXcptFilter _seh_filter_dll should behave like __CppXcptFilter and _seh_filter_exe like _XcptFilter. You also need to copy -arch=i386,x86_64,arm parameter. Otherwise you break compilation for other architectures because __CppXcptFilter is not defined there. Thanks, Piotr

2 1

Re: [PATCH 4/4] ntdll: Added NtNotifyChangeMultipleKeys implementation.
by Dmitry Timoshkov Nov. 9, 2015

Nov. 9, 2015

Hi Jacek, Jacek Caban <jacek(a)codeweavers.com> wrote: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index 464b233..d9bab90 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -205,7 +205,7 @@ > # @ stub NtModifyBootEntry > @ stdcall NtNotifyChangeDirectoryFile(long long ptr ptr ptr ptr long long long) > @ stdcall NtNotifyChangeKey(long long ptr ptr ptr long long ptr long long) > -# @ stub NtNotifyChangeMultipleKeys > +@ stdcall NtNotifyChangeMultipleKeys(long long ptr long ptr ptr ptr long long ptr long long) You forgot to update the Zw* .spec entry. -- Dmitry.

1 0

Re: [PATCH v5] ucrtbase: Hook up _seh_filter_exe and _seh_filter_dll
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/09/15 12:46, Martin Storsjo wrote: > +@ cdecl -arch=i386,x86_64,arm _seh_filter_dll(long ptr) __CppXcptFilter > +@ cdecl -arch=i386,x86_64,arm _seh_filter_exe(long ptr) __CppXcptFilter This is still wrong.

2 3

Re: [PATCH v3] ucrtbase: Implement _seh_filter_exe and _seh_filter_dll
by Piotr Caban Nov. 9, 2015

Nov. 9, 2015

On 11/05/15 13:52, Martin Storsjo wrote: > +int CDECL _seh_filter_dll(MSVCRT_ulong ex, PEXCEPTION_POINTERS ptr) > +{ > + TRACE("(%08x,%p)\n", ex, ptr); > + /* I assume ptr->ExceptionRecord->ExceptionCode is the same as ex */ > + return msvcrt_exception_filter(ptr); > +} This function should behave like __CppXcptFilter. Thanks, Piotr

2 2

Re: [PATCH] oledb32/tests: Add more GetConversionSize tests
by Nikolay Sivov Nov. 9, 2015

Nov. 9, 2015

On 09.11.2015 12:49, Alistair Leslie-Hughes wrote: > It appears that if the type being converted is of a fixed > size then it returns a constant value of 110. > I don't think it makes sense to have such magic size in tests, until there's an understanding what DataConvert returns as destination in such cases.

1 0

Re: [4/5] gdi32: Embolden width direction only if ppem <= 50. (resend)
by Huw Davies Nov. 9, 2015

Nov. 9, 2015

On Fri, Nov 06, 2015 at 09:25:11PM +0900, Akihiro Sagawa wrote: > > In other words, avoid increasing the thickness of height direction if > the size is small. This prevents distorting fonts as in Bug 34884. > This feature requires newer FreeType library (2.4.10 and/or later). What does Windows do here? Does it really have a cutoff at 50 ppem? I suspect we should always just stretch in the x-direction irrespective of the ppem (at least in the case where we have FT_Outline_EmboldenXY). Huw.

1 0

Re: [3/5] gdi32: Implement synthesizing bold glyphs for bitmap fonts. (resend)
by Huw Davies Nov. 9, 2015

Nov. 9, 2015

On Fri, Nov 06, 2015 at 09:25:09PM +0900, Akihiro Sagawa wrote: > @@ -6970,7 +6971,16 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, > INT w = min( pitch, (ft_face->glyph->bitmap.width + 7) >> 3 ); > INT h = min( height, ft_face->glyph->bitmap.rows ); > while(h--) { > - memcpy(dst, src, w); > + if (!font->fake_bold) > + memcpy(dst, src, w); > + else { > + INT x; > + dst[0] = 0; > + for (x = 0; x < w; x++) { > + dst[x ] = (dst[x] & 0x80) | (src[x] >> 1) | src[x]; > + dst[x+1] = (src[x] & 0x01) << 7; This could write past the end of dst (and similarly for ones below). Huw.

1 0

Re: [PATCH 3/3] quartz: Fix error code when chekcing circular connection.
by Qian Hong Nov. 9, 2015

Nov. 9, 2015

Please drop this patch, I find the actual define for 80040217 this time, will resend soon.

1 0

Re: [PATCH] gdi32: Initialize system font link registry.
by Huw Davies Nov. 9, 2015

Nov. 9, 2015

On Wed, Nov 04, 2015 at 09:40:38PM +0800, Qian Hong wrote: > +static void update_font_system_link_info(UINT current_ansi_codepage) > + if (RegCreateKeyA(HKEY_LOCAL_MACHINE, font_link_reg_key, &hkey) == ERROR_SUCCESS) > + { > + HKEY hsubkey; > + if (RegCreateKeyA(hkey, system_link_subkey, &hsubkey) == ERROR_SUCCESS) > + { You could create this key in one call. Please use the unicode registry functions for both key creation and value setting (yes, I know there are many ansi versions already there, but let's avoid adding more!). You'll find the system link unicode string already defined in 'system_link'. Huw.

2 1

Re: taskschd/tests: Fix memory leaks (Valgrind).
by Marvin Nov. 9, 2015

Nov. 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18033 Your paranoid android. === w1064 (32 bit scheduler) === scheduler.c:159: Test failed: expected ERROR_INVALID_NAME, got 0x80070002 scheduler.c:204: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:354: Test failed: expected ERROR_FILE_NOT_FOUND, got 0 scheduler.c:767: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:773: Test failed: expected ERROR_PATH_NOT_FOUND, got 0x80070002 scheduler.c:941: Test failed: expected ERROR_FILE_NOT_FOUND, got 0

1 0