November 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 07/11] ddraw/tests: Port test_shademode() to ddraw7.
by Marvin Nov. 12, 2015

Nov. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18191 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

1 0

Re: wininet: Create file with correct file name in test_trailing_slash tests
by Marvin Nov. 12, 2015

Nov. 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18188 Your paranoid android. === w7pro64 (64 bit urlcache) === urlcache.c:395: Test failed: GetUrlCacheEntryInfo should have set last error to ERROR_INSUFFICIENT_BUFFER instead of 2 urlcache.c:399: Test failed: GetUrlCacheEntryInfo failed with error 87 urlcache.c:400: Test failed: expected zero ExpireTime urlcache.c:402: Test failed: expected zero LastModifiedTime urlcache.c:404: Test failed: expected type NORMAL_CACHE_ENTRY|URLHISTORY_CACHE_ENTRY, got 05000000 urlcache.c:408: Test failed: expected dwExemptDelta 0, got 6292480 urlcache.c:422: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 2 urlcache.c:426: Test failed: GetUrlCacheEntryInfo failed with error 87 urlcache.c:432: Test failed: expected type NORMAL_CACHE_ENTRY|URLHISTORY_CACHE_ENTRY, got 00000000 urlcache.c:437: Test failed: expected headers size 19, got 6311544 urlcache.c:441: Test failed: HitRate not incremented by one on commit urlcache.c:448: Test failed: Fileextension isn't unset: xN` urlcache.c:476: Test failed: RetrieveUrlCacheEntryFile should have set last error to ERROR_INVALID_DATA instead of 2

1 0

Downloads Site Mirrors
by Jeremy Newman Nov. 12, 2015

Nov. 12, 2015

We are now mirroring https://ftp.winehq.org, as https://dl.winehq.org/ For faster downloads, if you are using our old ftp site for files, change it to the new dl site. Thanks go out to the fine folks at Fastly for providing this service to Wine. -N

3 5

Re: [PATCH] msvcp120: implement _Cnd_* functions (try 3)
by Piotr Caban Nov. 12, 2015

Nov. 12, 2015

Hi, The implementation looks good for me. The tests are over complicated. I'm attaching a patch generated on top of yours that simplifies them. If you agree with this changes please just squash both commits and resend. Thanks, Piotr

1 0

Re: [v7 08/10] ddraw: Do refcounting only through wined3d_texture_{inc, dec}ref().
by Henri Verbeet Nov. 12, 2015

Nov. 12, 2015

This and the next two patches are blocked by previous patches in the series.

1 0

Re: [v7 06/10] ddraw: Check for mipmap sublevel through caps in ddraw_surface7_SetColorKey().
by Henri Verbeet Nov. 12, 2015

Nov. 12, 2015

On 10 November 2015 at 14:09, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -4727,13 +4727,8 @@ static HRESULT WINAPI ddraw_surface7_SetColorKey(IDirectDrawSurface7 *iface, DWO > > TRACE("iface %p, flags %#x, color_key %p.\n", iface, flags, color_key); > > - wined3d_mutex_lock(); > - if (!surface->wined3d_texture) > - { > - wined3d_mutex_unlock(); > + if (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL) > return DDERR_NOTONMIPMAPSUBLEVEL; > - } > - wined3d_mutex_unlock(); > This is probably fine, but depends on the test to go in.

1 0

Re: [v7 04/10] d3d9: Replace surface refcounting with parent texture refcounting.
by Henri Verbeet Nov. 12, 2015

Nov. 12, 2015

This seems fine, but is blocked on the previous patch.

1 0

[PATCH] ntdll: Report valid data for ProcessVmCounters on Linux.
by achurch＠achurch.org Nov. 11, 2015

Nov. 11, 2015

Forwarded by request from https://bugs.winehq.org/show_bug.cgi?id=35563 (please note that I am not subscribed to the list). This patch modifies NtQueryInformationProcess() to return valid data for ProcessVmCounters on Linux by reading /proc/self/status, so that GetProcessMemoryInfo() reports actual process information rather than all zeros. --Andrew Church http://achurch.org/ diff -urN wine-git-4a1629c-orig/dlls/ntdll/process.c wine-git-4a1629c/dlls/ntdll/process.c --- wine-git-4a1629c-orig/dlls/ntdll/process.c 2015-11-11 20:54:45 +0900 +++ wine-git-4a1629c/dlls/ntdll/process.c 2015-11-11 20:55:30 +0900 @@ -243,6 +243,46 @@ /* FIXME : real data */ memset(&pvmi, 0 , sizeof(VM_COUNTERS)); +#ifdef __linux__ + FILE *f = fopen("/proc/self/status", "r"); + if (f) { + char buf[100]; + int at_bol = 1; + while (fgets(buf, sizeof(buf), f)) { + const int has_eol = (buf[strlen(buf)-1] == '\n'); + if (at_bol) { + const char *tag = buf; + char *s = strchr(buf, ':'); + if (s) { + *s++ = '\0'; + unsigned long value = strtoul(s, NULL, 10); + if (strcmp(tag, "VmPeak") == 0) { + pvmi.PeakVirtualSize = value*1024; + pvmi.PeakPagefileUsage = value*1024; + pvmi.QuotaPeakPagedPoolUsage = value*1024; + } else if (strcmp(tag, "VmSize") == 0) { + pvmi.VirtualSize = value*1024; + pvmi.PagefileUsage = value*1024; + pvmi.QuotaPagedPoolUsage = value*1024; + } else if (strcmp(tag, "VmHWM") == 0) { + pvmi.PeakWorkingSetSize = value*1024; + } else if (strcmp(tag, "VmRSS") == 0) { + pvmi.WorkingSetSize = value*1024; + } + /* We could get QuotaNonPagedPoolUsage from + * the VmLck line, but Linux doesn't give a + * peak value for that, so we just ignore + * it instead of returning a "peak" value + * that might decrease over time. + * FIXME: track the peak value ourselves. */ + } + } + at_bol = has_eol; + } + fclose(f); + } +#endif /* __linux__ */ + len = ProcessInformationLength; if (len != FIELD_OFFSET(VM_COUNTERS,PrivatePageCount)) len = sizeof(VM_COUNTERS);

1 0

Re: [v6 01/13] d3d9: Call wined3d_device_copy_sub_resource_region() instead of wined3d_device_update_surface() in d3d9_device_UpdateSurface().
by Riccardo Bortolato Nov. 11, 2015

Nov. 11, 2015

Hi, what can I do to improve patches 1 to 6 in order to get them accepted? I will be on IRC for quicker discussion. Ciao, Riccardo 2015-11-05 17:15 GMT+01:00 Marvin <testbot(a)winehq.org>: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Assigned". > > This means that the patch has been assigned to a reviewer. If the > reviewer signs off on the patch, it will be committed, otherwise > you'll receive advice on how to improve it. If you don't hear anything > after a couple of weeks, please resend the patch.

2 2

Re: user32: Test layered window focus
by Alexandre Julliard Nov. 11, 2015

Nov. 11, 2015

Piotr Caban <piotr(a)codeweavers.com> writes: > + hwnd = CreateWindowExA( WS_EX_LAYERED, "MainWindowClass", "layered window", > + WS_POPUP | WS_VISIBLE, 100, 100, 200, 200, 0, 0, 0, NULL ); > + ok( hwnd != 0, "failed to create layered window\n" ); > + > + ok(GetFocus() == hwnd, "GetFocus() = %p, expected %p\n", GetFocus(), hwnd); > + flush_events(TRUE); > + todo_wine ok(GetFocus() == hwnd, "GetFocus() = %p, expected %p\n", GetFocus(), hwnd); What problem are you trying to demonstrate? It works fine here: ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so win && touch win.ok win.c:6566: Test succeeded inside todo block: GetFocus() = 0x8200f6, expected 0x8200f6 Makefile:609: recipe for target 'win.ok' failed -- Alexandre Julliard julliard(a)winehq.org

3 3