December 2015 - Wine-Devel - list.winehq.org

programs/xcopy: Fix casing of usage message
by Hugh McMaster Dec. 3, 2015

Dec. 3, 2015

On Wednesday, 18 Nov 2015 19:08:29 -0600, Austin English wrote: >- STRING_SIMCOPY, "%1!d! file(s) would be copied\n" >- STRING_COPY, "%1!d! file(s) copied\n" >+ STRING_SIMCOPY, "%1!d! File(s) would be copied\n" >+ STRING_COPY, "%1!d! File(s) copied\n" Hi Austin, You should probably patch all of the po files as well. It's a simple change, and it means Alexandre doesn't have to regenerate everything. -- Hugh McMaster

3 6

Simplified local IP reordering patch for default routes
by Bruno Jesus Dec. 3, 2015

Dec. 3, 2015

Hi, Jamie and Joachim and list. This is a short version of a long patch I'm working on, it orders the IP list with the default routes on top and it supports more than one default route. It fixes the problem on Linux and FreeBSD, could anyone also test it on OSX, please? This patch does not touch the magic IP so the loopback route will still return the IP 127.12.34.56 but at least it won't be the first one anymore. Thanks in advance, Bruno

3 6

Re: winedbg: Print windows version in system info.
by Austin English Dec. 2, 2015

Dec. 2, 2015

On Wed, Dec 2, 2015 at 5:20 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Michael Müller <michael(a)fds-team.de> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > ... for those who don't have a crystal ball while triaging bug reports. :) > > programs/winedbg/tgt_active.c | 58 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/programs/winedbg/tgt_active.c b/programs/winedbg/tgt_active.c > index 989e433..07edccc 100644 > --- a/programs/winedbg/tgt_active.c > +++ b/programs/winedbg/tgt_active.c > @@ -678,6 +678,63 @@ static HANDLE create_temp_file(void) > NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL | FILE_FLAG_DELETE_ON_CLOSE, 0 ); > } > > +static const struct > +{ > + int type; > + int platform; > + int major; > + int minor; > + const char *str; > +} > +version_table[] = > +{ > + { 0, VER_PLATFORM_WIN32s, 2, 0, "2.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 0, "3.0" }, > + { 0, VER_PLATFORM_WIN32s, 3, 10, "3.1" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 0, "95" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 10, "98" }, > + { 0, VER_PLATFORM_WIN32_WINDOWS, 4, 90, "ME" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 3, 51, "NT 3.51" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 4, 0, "NT 4.0" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 0, "2000" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 1, "XP" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 5, 2, "XP" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 5, 2, "Server 2003" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 0, "Vista" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 0, "Server 2008" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 1, "7" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 1, "Server 2008 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 2, "8" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 2, "Server 2012" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 6, 3, "8.1" }, > + { VER_NT_SERVER, VER_PLATFORM_WIN32_NT, 6, 3, "Server 2012 R2" }, > + { VER_NT_WORKSTATION, VER_PLATFORM_WIN32_NT, 10, 0, "10" }, > +}; > + > +static const char *get_windows_version(void) > +{ > + OSVERSIONINFOEXW info = { sizeof(OSVERSIONINFOEXW) }; > + static char str[64]; > + int i; > + > + GetVersionExW( (OSVERSIONINFOW *)&info ); > + > + for (i = 0; i < sizeof(version_table) / sizeof(version_table[0]); i++) > + { > + if (version_table[i].type == info.wProductType && > + version_table[i].platform == info.dwPlatformId && > + version_table[i].major == info.dwMajorVersion && > + version_table[i].minor == info.dwMinorVersion) > + { > + return version_table[i].str; > + } > + } > + > + snprintf( str, sizeof(str), "%d.%d (%d)", info.dwMajorVersion, > + info.dwMinorVersion, info.wProductType ); > + return str; > +} > + > static void output_system_info(void) > { > #ifdef __i386__ > @@ -705,6 +762,7 @@ static void output_system_info(void) > dbg_printf( "System information:\n" ); > if (wine_get_build_id) dbg_printf( " Wine build: %s\n", wine_get_build_id() ); > dbg_printf( " Platform: %s%s\n", platform, is_wow64 ? " (WOW64)" : "" ); > + dbg_printf( " Version: Windows %s\n", get_windows_version() ); > if (wine_get_host_version) > { > const char *sysname, *release; > -- > 2.6.2 > > With my bugzilla hat on: Thank you!! -- -Austin

1 0

Re: loader/wine.inf.in: add 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key
by Jacek Caban Dec. 2, 2015

Dec. 2, 2015

Hi Austin, On 12/02/15 07:31, Austin English wrote: > > From a8309f37269bc374359e6ee473e66465551b867f Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 2 Dec 2015 01:27:15 -0500 > Subject: [PATCH] loader/wine.inf.in: add > 'HKLM\Software\Classes\Applications\iexplore.exe\shell\open\command' key > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > loader/wine.inf.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/loader/wine.inf.in b/loader/wine.inf.in I believe this should go to programs/iexplore/iexplore.inf. > index 58a8d1d..02b92f4 100644 > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -245,6 +245,7 @@ HKCR,https\shell\open\ddeexec,"NoActivateHandler",2,"" > HKCR,https\shell\open\ddeexec\Application,,2,"IExplore" > HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > HKCR,mailto\shell\open\command,,2,"%11%\winebrowser %1" > +HKLM,Software\Classes\Applications\iexplore.exe\shell\open\command,,2,"""%16422%\Internet Explorer\iexplore.exe"" %1" Why don't you use HKCR here? Thanks, Jacek

2 1

Re: [PATCH 3/3] ntdll/tests: Restore old value in a more context independent way.
by Marvin Dec. 2, 2015

Dec. 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18722 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/002D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [PATCH 1/3] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 4).
by Marvin Dec. 2, 2015

Dec. 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18721 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/003D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [PATCH 4/4 v2] dsound: Fail to create a version 8 3d buffer with DSBCAPS_CTRLPAN
by Andrew Eikum Dec. 2, 2015

Dec. 2, 2015

This looks fine, but since it doesn't fix a bug, I think this one should be deferred. As Michael knows, dsound applications can be fragile... Andrew On Tue, Dec 01, 2015 at 02:49:45PM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 5 +++++ > dlls/dsound/tests/ds3d8.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 7b93455..e50ef58 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -542,6 +542,11 @@ static HRESULT DirectSoundDevice_CreateSoundBuffer( > return DSERR_INVALIDPARAM; > } > > + if (from8 && (dsbd->dwFlags & DSBCAPS_CTRL3D) && (dsbd->dwFlags & DSBCAPS_CTRLPAN)) { > + WARN("invalid parameter: DSBCAPS_CTRL3D and DSBCAPS_CTRLPAN cannot be used together\n"); > + return DSERR_INVALIDPARAM; > + } > + > hres = IDirectSoundBufferImpl_Create(device, &dsb, dsbd); > if (dsb) { > *ppdsb = (IDirectSoundBuffer*)&dsb->IDirectSoundBuffer8_iface; > diff --git a/dlls/dsound/tests/ds3d8.c b/dlls/dsound/tests/ds3d8.c > index 330f590..25eb010 100644 > --- a/dlls/dsound/tests/ds3d8.c > +++ b/dlls/dsound/tests/ds3d8.c > @@ -654,7 +654,6 @@ static HRESULT test_secondary8(LPGUID lpGuid, BOOL play, > /* Invalid flag combination */ > bufdesc.dwFlags|=DSBCAPS_CTRLPAN; > rc=IDirectSound8_CreateSoundBuffer(dso,&bufdesc,&secondary,NULL); > - todo_wine > ok(rc==DSERR_INVALIDPARAM, > "IDirectSound8_CreateSoundBuffer(secondary) should have " > "returned DSERR_INVALIDPARAM, returned %08x\n", rc); > -- > 2.1.0 > >

1 0

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).
by Alexandre Julliard Dec. 2, 2015

Dec. 2, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > Try 3: > - Correctly revert side effect of previous ldmxcsr, change 0x200 to > 0x80, 0x80 & 0xff7f = 0, 0x200 & 0xfdff = 0. It would be even better to restore the original value, without making assumptions about the previous contents. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH 1/2] ntdll/tests: Add SIMD exception test for floating point invalid operation fault (try 3).
by Marvin Dec. 2, 2015

Dec. 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18719 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003D0000/003D0001 exception: unhandled exception 80000004 at 003D0000 exception.c:485: Test failed: 42: Wrong exception address 77BAED97/003D0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [PATCH] ntdll: Fix valgrind heap realloc notifications.
by Alexandre Julliard Dec. 2, 2015

Dec. 2, 2015

Thomas Faller <tfaller1(a)gmx.de> writes: > Valgrind can't handle a realloc, if the new size is zero. > Fix for bug https://bugs.winehq.org/show_bug.cgi?id=37646 I'd suggest fixing valgrind, or if not possible, using a size of 1. Your change seems like it would make notifications less useful in several cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shlwapi/tests: Test NULL handle duplication in SHMapHandle()
by Olivier F. R. Dierick Dec. 2, 2015

Dec. 2, 2015

Le mardi 01 décembre 2015 à 19:51 +0800, Bruno Jesus a écrit : > Related to https://bugs.winehq.org/show_bug.cgi?id=36838 > > Not sure when Olivier Dierick will be back to this so I'm sending the > test I made. > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Thank you. The shlwapi functions are undocumented in MSDN. This is were I found documentation for the SHMapHandle() function: http://www.geoffchappell.com/studies/windows/shell/shlwapi/api/shared/mapha… -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be

1 0

Re: Shell32: Check null handles before freeing
by Nikolay Sivov Dec. 1, 2015

Dec. 1, 2015

On 25.11.2015 10:02, Olivier F. R. Dierick wrote: > Fix one of the error leak source that prevents the installer to succeed > (bug 36838). > > The original code did not check if the handles were null before freeing > them. For some reason they happen to be null and last error is set to > ERROR_INVALID_HANDLE. The game installer chokes at some point when the > last error is anything but zero and fails to complete the installation. > Checking if the handles are non-null before freeing them avoids this. > According to MSDN, it is not an error to have null values for those > handles. > > Signed-off-by: Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> > --- > dlls/shell32/changenotify.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > We most likely have many more places that do same thing, it will need tests for SHFree() and CoTaskMemFree(). If it turns out error is not changed on NULLs, it's easier to return early from SHFree or CoTaskMemFree than fix all places where those are used.

2 2

Re: dinput: Implement device property DIPROP_USERNAME.
by Sebastian Lackner Dec. 1, 2015

Dec. 1, 2015

On 01.12.2015 14:54, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39667 > > Probably same issue as in https://bugs.winehq.org/show_bug.cgi?id=12432 . > (Attached backtrace seems equal.) > > Steps to reproduce: > - start launcher > - "Configure Controller" > - leave dialog with "Cancel" > - crash > > MotoGP 3 demo launcher uses ConfigureDevices for the key mapping. > The crash seems to happen because the result of a > GetProperty(DIPROP_USERNAME) is used without checking. > > This affects just the launcher. The game starts without problems with > a default key mapping. > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/dinput/device.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > dlls/dinput8/tests/device.c | 29 +++++++++++++++++++++++++++-- > 3 files changed, 72 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index e525f01..1095c4c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -783,6 +783,7 @@ HRESULT _set_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, L > DIOBJECTDATAFORMAT *obj_df = NULL; > DIPROPDWORD dp; > DIPROPRANGE dpr; > + DIPROPSTRING dps; > WCHAR username[MAX_PATH]; > DWORD username_size = MAX_PATH; > int i, action = 0, num_actions = 0; > @@ -863,6 +864,19 @@ HRESULT _set_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, L > else > lstrcpynW(username, lpszUserName, MAX_PATH); > > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + lstrcpynW(dps.wsz, username, sizeof(dps.wsz)); > + IDirectInputDevice8_SetProperty(iface, DIPROP_USERNAME, &dps.diph); > + > + if (dwFlags & DIDSAM_NOUSER) > + { > + HeapFree(GetProcessHeap(), 0, This->username); > + This->username = NULL; > + } When I understand it correctly, if DISAM_NOUSER is set, you set the username just to reset it manually again afterwards? Why not pass an empty string to IDirectInputDevice8_SetProperty? > + > /* Save the settings to disk */ > save_mapping_settings(iface, lpdiaf, username); > > @@ -1100,6 +1114,9 @@ ULONG WINAPI IDirectInputDevice2WImpl_Release(LPDIRECTINPUTDEVICE8W iface) > /* Free action mapping */ > HeapFree(GetProcessHeap(), 0, This->action_map); > > + /* Free username */ > + HeapFree(GetProcessHeap(), 0, This->username); > + > EnterCriticalSection( &This->dinput->crit ); > list_remove( &This->entry ); > LeaveCriticalSection( &This->dinput->crit ); > @@ -1251,6 +1268,17 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + > + ps->wsz[0] = 0; > + if (This->username) > + lstrcpynW(ps->wsz, This->username, sizeof(ps->wsz)); The last argument is wrong, it should be a WCHAR count. > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1324,6 +1352,22 @@ HRESULT WINAPI IDirectInputDevice2WImpl_SetProperty( > LeaveCriticalSection(&This->crit); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPCDIPROPSTRING ps = (LPCDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + > + if (!This->username) > + This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(ps->wsz)); > + if (!This->username) > + return DIERR_OUTOFMEMORY; > + > + This->username[0] = 0; > + if (ps->wsz) > + lstrcpynW(This->username, ps->wsz, sizeof(ps->wsz)); Same here. Also, it could make sense to look at the actual string length, instead of allocating a fixed size buffer. > + break; > + } > default: > WARN("Unknown property %s\n", debugstr_guid(rguid)); > return DIERR_UNSUPPORTED; > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 52bbec4..26ec7c2 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR *username; /* set in SetActionMap */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > diff --git a/dlls/dinput8/tests/device.c b/dlls/dinput8/tests/device.c > index 6495559..af8667d 100644 > --- a/dlls/dinput8/tests/device.c > +++ b/dlls/dinput8/tests/device.c > @@ -223,8 +223,8 @@ static BOOL CALLBACK enumeration_callback(const DIDEVICEINSTANCEA *lpddi, IDirec > dps.wsz[0] = '\0'; > > hr = IDirectInputDevice_GetProperty(lpdid, DIPROP_USERNAME, &dps.diph); > - todo_wine ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > - todo_wine ok (!lstrcmpW(usernameW, dps.wsz), "Username not set correctly expected=%s, got=%s\n", wine_dbgstr_wn(usernameW, -1), wine_dbgstr_wn(dps.wsz, -1)); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (!lstrcmpW(usernameW, dps.wsz), "Username not set correctly expected=%s, got=%s\n", wine_dbgstr_wn(usernameW, -1), wine_dbgstr_wn(dps.wsz, -1)); > > /* Test buffer size */ > memset(&dp, 0, sizeof(dp)); > @@ -275,6 +275,7 @@ static void test_action_mapping(void) > HINSTANCE hinst = GetModuleHandleA(NULL); > IDirectInput8A *pDI = NULL; > DIACTIONFORMATA af; > + DIPROPSTRING dps; > struct enum_data data = {pDI, &af, NULL, NULL, NULL, 0}; > HWND hwnd; > > @@ -342,6 +343,30 @@ static void test_action_mapping(void) > > af.dwDataSize = 4 * sizeof(actionMapping) / sizeof(actionMapping[0]); > af.dwNumActions = sizeof(actionMapping) / sizeof(actionMapping[0]); > + > + /* test DIDSAM_NOUSER */ > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + dps.wsz[0] = '\0'; > + > + hr = IDirectInputDevice_GetProperty(data.keyboard, DIPROP_USERNAME, &dps.diph); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (dps.wsz[0] != 0, "Expected any username, got=%s\n", wine_dbgstr_wn(dps.wsz, -1)); > + > + hr = IDirectInputDevice8_SetActionMap(data.keyboard, data.lpdiaf, NULL, DIDSAM_NOUSER); > + ok (SUCCEEDED(hr), "SetActionMap failed hr=%08x\n", hr); > + > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + dps.wsz[0] = '\0'; > + > + hr = IDirectInputDevice_GetProperty(data.keyboard, DIPROP_USERNAME, &dps.diph); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (dps.wsz[0] == 0, "Expected empty username, got=%s\n", wine_dbgstr_wn(dps.wsz, -1)); > } > > if (data.mouse != NULL) >

1 0

Re: [PATCH 4/4 v2] dsound: Fail to create a version 8 3d buffer with DSBCAPS_CTRLPAN
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 5 +++++ > dlls/dsound/tests/ds3d8.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) Does this one fix a bug or is it just a consequence of the tests? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/4] dsound: A version 1 3d secondary buffer allows SetPan().
by Marvin Dec. 1, 2015

Dec. 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18692 Your paranoid android. === wxppro (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w2003std (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7u (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w8 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000

1 0

Re: [PATCH 2/4] dsound/tests: Test Pan for 3D secondary buffers too.
by Marvin Dec. 1, 2015

Dec. 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18691 Your paranoid android. === wxppro (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w2003std (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7u (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w8 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000

1 0

Re: [PATCH] ddraw/tests: 64-bit ddraw doesn't support textures.
by Marvin Dec. 1, 2015

Dec. 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18683 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2184: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] ole2disp: Implement VariantInit()
by Alexandre Julliard Dec. 1, 2015

Dec. 1, 2015

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -39,4 +39,43 @@ INT16 WINAPI SysReAllocString16(LPBSTR16,LPCOLESTR16); > int WINAPI SysReAllocStringLen16(BSTR16*, const char*, int); > int WINAPI SysStringLen16(BSTR16); > > +typedef struct tagVARIANT16 { > + VARTYPE vt; > + WORD wReserved1; > + WORD wReserved2; > + WORD wReserved3; > + union { > + BYTE bVal; > + SHORT iVal; > + LONG lVal; > + FLOAT fltVal; > + DOUBLE dblVal; > + VARIANT_BOOL boolVal; > + SCODE scode; > + DATE date; > + BSTR16 bstrVal; > + CY cyVal; > + IUnknown *punkVal; > + IDispatch *pdispVal; > + SAFEARRAY *parray; > + BYTE *pbVal; > + SHORT *piVal; > + LONG *plVal; > + FLOAT *pfltVal; > + DOUBLE *pdblVal; > + VARIANT_BOOL *pboolVal; > + SCODE *pscode; > + DATE *pdate; > + BSTR16 *pbstrVal; > + struct tagVARIANT16 *pvarVal; > + void *byref; > + CY *pcyVal; > + IUnknown **ppunkVal; > + IDispatch **ppdispVal; > + SAFEARRAY **pparray; > + } u; > +} VARIANT16; The pointers should all be SEGPTR. Some of the existing definitions like BSTR16 probably need to be fixed too. In any case this will have to wait until after code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Make a 16-bit test in wine for krnl386.exe16
by Bruno Jesus Dec. 1, 2015

Dec. 1, 2015

Hi all, I'm trying to create tests for GetPrivateProfileString16 but it is not working as expected because the test is calling the kernel32 version of the function instead of the krnl386.exe16. Is there any way to make a test that compiles and runs against krnl386 instead of kernel32? I tried a few different things and the attached patch is the last attempt (the tests are wrong but that is not the point yet). Any help is appreciated, thanks in advance, Bruno

7 11