December 2015 - Wine-Devel - list.winehq.org

Re: [2/2] shell32: ShellExecute() should not exec non-executable files.
by Francois Gouget Dec. 29, 2015

Dec. 29, 2015

On Tue, 29 Dec 2015, Francois Gouget wrote: [...] > + > + if ((sei_tmp.lpVerb && *sei_tmp.lpVerb) || PathIsExeW(wszApplicationName)) Please don't apply. I think this test is wrong. It should probably be checking that no was specified, or maybe that no class was specified. -- Francois Gouget <fgouget(a)codeweavers.com>

1 0

Bugzilla changes
by Austin English Dec. 28, 2015

Dec. 28, 2015

Howdy all, As Alexandre mentioned [1], at WineConf we made several decisions to modify bugzilla in a few ways. I've now implemented those changes, which are outlined below: * New wine-staging product: This should be used for bugs caused by patches that are in wine-staging, but that do not occur in wine-development (i.e., wine-staging patch regressions) * New STAGED resolution: This is to differentiate bugs that are FIXED (in wine-development) from bugs that are not present in wine-staging because of one or more patches. The anticipated workflow is: UNCONFIRMED > bug confirmed, NEW > patch written and sent to wine-patches, if it's accepted, FIXED. If not, and the patch is integrated into wine-staging, then the bug is STAGED. When the patch is revised and eventually integrated into wine-development, the bug should move to FIXED. * New NEEDINFO resolution: There's a lot of confusion and different handling by triagers for what to do with bug reports that are incomplete (i.e., leaving it open versus closing invalid). To mitigate this, I've added a NEEDINFO resolution. If a bug report lacks needed information, set it to this status. Bug that have been open NEEDINFO for more than 1 year can be closed. * Renamed UPSTREAM to NOTOURBUG: This is more in line with what other projects do, and eliminates confusion about the upstream/downstream distinction. Please let me know if there are any questions or ideas for further enhancements. [1] https://www.winehq.org/pipermail/wine-devel/2015-September/109392.html -- -Austin

6 11

Re: hidclass.sys: Properly quit hid_device_thread when both completion event and halt event are signaled.
by Aric Stewart Dec. 28, 2015

Dec. 28, 2015

Sorry for the delayed review, I have been traveling. I understand the issue your trying to fix, but I worry that you could get yourself into a bad state where if a driver is misbehaving and is blocked or crashes while processing an IRP then the halt event will never get processed as we will be waiting INFINITE on an event that may never come. I dont know which is the more likely or problematic case. What I may suggest is keep the WaitForMultipleObjects(2, events, FALSE, INFINITE) and instead of relying on the return code you could do an additional WaitForSingleObject(ext->halt_event, 0) to determine if exit_now should be set. -aric

2 1

Re: [PATCH 2/2] user32/tests: Add tests for WM_DEVICECHANGE message. (try 3)
by Marvin Dec. 28, 2015

Dec. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19233 Your paranoid android. === w1064 (32 bit msg) === msg.c:6140: Test failed: Update region shouldn't be empty msg.c:6374: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6376: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6146: Test failed: Regions are different msg.c:6146: Test failed: Regions are different msg.c:6146: Test failed: Regions are different

1 0

Re: [2/2] shell32: ShellExecute() should not exec non-executable files.
by Marvin Dec. 28, 2015

Dec. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19232 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:142: Test failed: ShellExecute(verb="QuotedUpperL", file="C:\Users\winetest\AppData\Local\Temp\wtD519.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1566: Test failed: argvA3 expected 'QuotedUpperL', but key not found or empty shlexec.c:1574: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD519.tmp\test file.shlexec', but key not found or empty === w1064 (32 bit shlexec) === shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1008.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1008.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1008.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1008.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2286: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2667: Test failed: argvA3 expected 'Exec', but key not found or empty shlexec.c:2668: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test2.exe', but key not found or empty shlexec.c:556: childTimeout called shlexec.c:2679: Test failed: argcA expected 4, but got 3 shlexec.c:2680: Test failed: argvA3 expected 'Exec', but key not found or empty shlexec.c:2681: Test failed: longPath expected 'C:\Users\winetest\AppData\Local\Temp\wt43A.tmp\test2.exe', got 'C:\Users\winetest\Documents\shell32_test64.exe'

1 0

Re: [1/2] shell32/tests: Make sure the test executable has an executable name.
by Marvin Dec. 28, 2015

Dec. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19231 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2300: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde")]' shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtEB96.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtF5C.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtF5C.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtF5C.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtF5C.tmp\test file.sde") failed: rc=29 err=2

1 0

Re: 0001-winedbg-Add-a-debug-button-on-crash-dialog-get-rid-of-
by Qian Hong Dec. 28, 2015

Dec. 28, 2015

I like this change, thank you for the patch. On Mon, Dec 28, 2015 at 5:21 PM, Changhui LIU <liuchanghui(a)linuxdeepin.com> wrote: > > > > > > > ------------------ > Regards, > Changhui Liu > > > > -- Regards, Qian Hong - http://www.winehq.org

1 0

Out-of-date gcc and ld on the testbot build VM
by Hugh McMaster Dec. 28, 2015

Dec. 28, 2015

The testbot seems to have an out-of-date version of mingw32, or at least, its linker, ld.exe. I'm trying to run tests for GetConsoleScreenBufferInfoEx, a function available on Vista and higher. But the build VM's linker is failing with an undefined reference: reg.o: In function `test_GetConsoleScreenBufferInfoEx': /home/winetest/tools/testbot/var/build-mingw32/programs/reg/tests/../../../../wine/programs/reg/tests/reg.c:489: undefined reference to `__imp__GetConsoleScreenBufferInfoEx(a)8' collect2: ld returned 1 exit status winegcc: i686-w64-mingw32-gcc failed My machine is able to compile the tests. It also has no trouble building a separate .exe using i686-w64-mingw32-gcc. My machine has: - mingw32 gcc version 4.8.2 (GCC) - mingw32 ld version: GNU ld (GNU Binutils) 2.23.52.20130620 -- Hugh McMaster

3 5

Re: shell32: add SHCreateSessionKey stub (try 2)
by Nikolay Sivov Dec. 28, 2015

Dec. 28, 2015

> +/************************************************************************* > + * SHCreateSessionKey [SHELL32.723] NT 4.0 > + * > + */ > +HRESULT WINAPI SHCreateSessionKey(REGSAM access, HKEY *hkey) > +{ > + FIXME("stub: %u %p\n", access, hkey); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} 'access' is a 32bit bit mask, return value is HRESULT.

1 0

Re: shell32: add SHCreateSessionKey stub
by Nikolay Sivov Dec. 28, 2015

Dec. 28, 2015

On 28.12.2015 8:15, Austin English wrote: > +HRESULT WINAPI SHCreateSessionKey(REGSAM access, HKEY *hkey) > +{ > + FIXME("stub: %d %p\n", access, hkey); > + return ERROR_SUCCESS; > +} This is wrong regarding tracing format, return value and formatting. I'll try to find time this week to send an actual implementation. It's fine to have fixed stub in before that of course.

1 0