March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH] vbscript: Implemented String
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11929 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [3/3] dpnet: Always update Component type since it can change (try 3)
by Stefan Dösinger March 5, 2015

March 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-05 um 09:55 schrieb Alistair Leslie-Hughes: > hr = IDirectPlay8Address_GetComponentByName(localaddr, DPNA_KEY_HOSTNAME, buffer, &size, &type); > ok(hr == S_OK, "got 0x%08x\n", hr); > - todo_wine ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > + ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > todo_wine ok(!lstrcmpW(buffer, localhost), "Invalid string: %s\n", wine_dbgstr_w(buffer)); I don't understand why the last check still needs todo_wine. Afaics the value should be stored and retrieved correctly. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU+GI4AAoJEN0/YqbEcdMwsyoP/0gkQITbAphMP7a4lonngLNC Bs3N5Pfo+AeXXcBUWMBFWTPfwHlTGxrk6cQZWijDaWI8ahWi57sjTY7iyez9gh7c +mCrewr+vOVOxWT6gIQIvv1xRCOQ2rrDAuNF3Ae9YuwaOvrtVuQmBMZuM5436OrD bTKu4Jj4wwnFRhR9TCQRiReI75vg9ZSF/T+PEnpovRCje7P53FtaqQcAPTDr742O IWSKngP+jAbWn5K4pwxDR8DVgGaGlzWHE7nv0IAZ69hZJy9fovzIGHbyiqQP2bZ6 2elhJkGgeNCwTVxV1ygbheJvs73KBrwf74mJbJUzC98EpdlO87ZJNEJKR6/UzAu5 Gr5aKtlQTjyvzY0AFwiahdWjS+gR5uUJLymAdEHBKjjYZzowzdXNq7KSGluhn5cm /c8EtJxcalix7dTdGp7Jq0te6B0yEk3hcvpYXcyfELo66hW4jdFApFpgZNb1Xx05 pmDfqagqHe3HHma3J4Uxhn0CyxJeOZKdJlQPZldpVia6zlf2y9BjD2iWfXq2Xl1B yoxS/xnmcx1HWvtUDtPmzobNCqZaA5KFNwKCJBGRiD7MaQjeY+EXBz+IjVuSiQk6 HziyqNT5u+CCjRY4MULGC3om4j9qytqxOjbVPKqZPesmYDI0SddrMwWtTcjoSMV8 8G0BUKbyNuBFCe/LiOtM =t8mZ -----END PGP SIGNATURE-----

1 0

Re: [1/4] ntdll: Implement TpSimpleTryPost and basic threadpool infrastructure.
by Alexandre Julliard March 5, 2015

March 5, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in > index ed4bb94..2cecac6 100644 > --- a/dlls/ntdll/Makefile.in > +++ b/dlls/ntdll/Makefile.in > @@ -47,6 +47,7 @@ C_SRCS = \ > tape.c \ > thread.c \ > threadpool.c \ > + threadpool2.c \ Please put that stuff in the existing threadpool.c, it's not large and it will be easier to find that way. -- Alexandre Julliard julliard(a)winehq.org

1 0

GSOC 2015 : D3DX9 - Implement missing D3DX9 APIs
by Abhishek Kumar March 5, 2015

March 5, 2015

Hi, I am Abhishek and am interested in the project titled "D3DX9 - Implement missing D3DX9 APIs". I am good at data-structures and algorithms and have worked with C,C++, PHP, Javascript and Python. I have some questions about the task: 1)Can domain-specific knowledge be a issue..? From just the name of the apis listed on ideas page, i can guess that some advanced domain knowledge in the concerned field is needed. How difficult would it be to write the apis without that knowledge..? 2) How should i start my work for this project..? By collecting the list of apis that would be implemented..? How should it be done..? Is there any documentation about it that will help..? Currently i have no idea. -- Thanks, Abhishek Kumar UG4, CSE IIIT Hyderabad, India

2 1

My GSOC2015 ideas
by YongHao Hu March 5, 2015

March 5, 2015

Hello, folks I'm YongHao Hu, a college student who study and send patches about msvcp,msvcrt. Thanks for Zhenbo's ideas. Here are my ideas for GSoC 2015. 1. Add needed functions about tr2 and finish my patch about cin>>complex ================== Though msvcp has almost 80%[1] functions implemented, it still has many unimplemented functions, which is used heavily in many softwares. For example, almost all the functions in namespace std::tr2::sys[2] need to implement, which causes a bug[3] now. 2. Optimize printf,sprintf functions using Grisu algorithm ================== I had found a bug[4] which is about inconsistent rounding behaviour for sprintf function. In order to fix it, I had made a patch[5] using Dragon4 algorithm. However, this implementation is a little slower than MSVC++ 2010, even four times slower[6] when printing 64-bit values with the minimal number of significant digits to identify the number like sprintf(buffer, "%.17g", value). As functions like printf and sprintf are dependent on pf_printf function, to which the patch applies, I guess efficency is important. As a result, using Grisu algorithm[7] to optimize the patch is a good choice. Grisu algorithm speeds up 99.4 percent of all 64-bit floating point numbers by only using small-integer arithmetic, while the remaining 0.6% still need to use a variant of Dragon4. My idea is to improve my patch based on Dragon4 algorithm so that it can be commited, after which I will add Grisu algorithm to optimize it. 3. Implement series undocumented functions about _Pad ================== There are two bugs needed unimplemented function of _pad in msvcp now[8][9]. I have studied and tested _pad function, finding that _pad is an undocumented function. I also implied that _Pad::Launch is a wrapper of _Thrd_create, thus, it is a tough job which needs to imply and implement many functions. Though my ideas for GSOC2015 may not mature enough, but I hope that they will be helpful. What's more, I am glad to choose some of them as my proposal, if they meet the criteria for GSoC. Thank you for reading this email. I will be grateful for any advice you can provide. [1]: https://www.winehq.org/winapi_stats [2]: https://msdn.microsoft.com/en-us/eg/library/hh874769.aspx [3]: https://bugs.winehq.org/show_bug.cgi?id=35774 [4]: https://bugs.winehq.org/show_bug.cgi?id=37913 [5]: http://source.winehq.org/patches/data/109456 [6]: http://www.ryanjuckett.com/programming/printing-floating-point-numbers/part… [7]: http://www.cs.tufts.edu/~nr/cs257/archive/florian-loitsch/printf.pdf [8]: https://bugs.winehq.org/show_bug.cgi?id=36996 [9]: https://bugs.winehq.org/show_bug.cgi?id=37694

2 1

Re: [1/3] dpnet: Add check for mismatched string lengths (try 4)
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11922 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 2/3] include/ole32/user32/winemac.drv/winex11.drv: do not allow dropping drags through obscuring native windows
by Ken Thomases March 4, 2015

March 4, 2015

Hi, On Mar 1, 2015, at 10:32 PM, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote: > Currently Wine does not support dragging from a Wine window to a > native Window, but does from a Wine window to another Wine window. > What is a big surprise though, is that if a Wine window is obscured by > a native window that's on top of it in the z-order, it looks like you > are dropping onto the native window, but you are actually dropping > THROUGH the native window into the Wine window - in other words, the > wrong application gets the drop! > > This patch fixes that problem by giving ole32 awareness of native > windows (represented by a ULONG_PTR) via new Wine-specific functions > in user32 that are implemented by the display drivers winex11.drv and > winemac.drv (of which only the former is implemented by this patch). > The ole32 drag loop can thus tell whether the window under the mouse > is a Wine window or a native window, and obtain IDropTarget from > either window type, something that is used by the next patch to > implement dragging from Wine to native windows. I appreciate your work on this, but I think this isn't the right approach. I think if you solve the other problem (dragging from Wine to other apps) by having the driver take over drags and translating them into a native drag operation, then this problem gets solved automatically. The native drag operation will target the proper window under the cursor, eliminating the problem of dropping through non-Wine windows. If the drag goes over a Wine window, then the native drag will get translated back into Win32 by the existing code in the drivers for receiving drops. I understand your point from the next patch email that this may result in code duplication between the drivers, but I think that's largely inevitable because of the requirements of driving a native drag operation. Also, I don't believe your design where the driver implements IDropTarget and ole32 calls its methods can be made to work on the Mac. As is often the case, Cocoa has a much more closed API for drag and drop than X11. We can't really arbitrarily do pieces of the drag operation in isolation and effectively start and stop the drag (as the cursor moves from Wine window to native window and back to a Wine window). We can only start the drag and then Cocoa takes it from there. It calls relevant methods on the drag source object along the way, of course, but we don't have a lot of control over the drag operation other than that. -Ken

3 3

Re: [PATCH] vbscript: Implemented Asc(try 4)
by Marvin March 4, 2015

March 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11905 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented Asc(try 3)
by Nikolay Sivov March 4, 2015

March 4, 2015

On 04.03.2015 9:19, Shuai Meng wrote: > + switch(V_VT(arg)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_BSTR: > + bstr = V_BSTR(arg); > + break; > + default: > + hres = to_string(arg, &bstr); > + if(FAILED(hres)) > + return hres; > + } > + > + ret = bstr[0]; > + SysFreeString(bstr); > + > + if(ret == 0) > + return MAKE_VBSERROR(VBSE_ILLEGAL_FUNC_CALL); > + return return_short(res, ret); This is wrong too. You can't always free it like that, please look carefully at where 'bstr' comes from.

2 1

Re: [1/3] dpnet: Add check for mismatched string lengths (try 3)
by Stefan Dösinger March 4, 2015

March 4, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-03-04 um 04:15 schrieb Alistair Leslie-Hughes: > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", 8, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == S_OK, "got 0x%08x\n", hr); This still uses a hardcoded size. I recommend to add an array const char test_str[] = "testing" similar to the localhost WCHAR. That way you can use the variable in all places. > + if (((strlenW((WCHAR*)lpvData)+1)*sizeof(WCHAR)) != dwDataSize) > + { > + WARN("Invalid STRING size, returning DPNERR_INVALIDPARAM\n"); > + return DPNERR_INVALIDPARAM; > + } There is a theoretical issue here that I don't know if we should care about. Assume e.g. dwDataSize is 10, but lpvData points to a blob that doesn't have a NULL byte before the end of the last defined page. In this case strlen will search for a string termination and segfault. strnlen could abort and return an error instead of segfault. I did some quick testing on Windows and it seems that this function uses a try / catch block to return gracefully in case of an invalid pointer. Generally we don't add tests that cause exceptions and I don't think we should test this here. And I have found no case where strnlen is used in Wine, and we have no strnlenW, so I don't think we should use it here. If I pass an invalid non-null pointer I get 0x80004003. If I pass a length = 0 I get DPNERR_INVALIDSTRING. Also checking !((char *)lpvData)[dwDataSize - 1] would be wrong, windows gracefully returns DPNERR_INVALIDPARAM on lpvData="123", size=999999. > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", sizeof("Testing")+2, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); Really minor issue: sizeof("testing") vs sizeof("Testing"). The result is the same, but a stupid compiler might place both strings in the executable. The variable I suggested above would avoid this issue here as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9zGdAAoJEN0/YqbEcdMw8MkP/0Mf46JYgZmA3IwqErfl5lRf fLq1ekHnsKWVXA8pMvl3A0bm2j9fP7UAErFo6mA+oW4KkqHtkqw9z87boJ5Ul5ko wy1T12fizUXXtxdq4Q+TKLCCl+SUX/CUS36Cvw7BeyHGldlUHUrgwQcv2UQg3T1Y dfug2KtrH1M8xTcZBmF9lRMGUqAUpcPxdH0wPh7AoOJsmNpXQUL3jZofsc2s6x7r JFffHxG2EdX96VSjhC+IG3vQLwH+SzlocblcGFFxhv/fjf0u0lgSZegmJVxDxfqc CVWSvMCpnXsd6O57ft8b25eJCmOkZLpYkvaOPiakj+Lz4I8h+lGzGck/Wfvy+bR2 Z0gqrNVjbABkYTlYHw6AsLHnliOnbvs3PROMG3mYsmmGOaLWIwFYhmIFBQCE6Kzv EWnvr3JSux2M689zurKvvJF/GYyS52SntMSpmJmcZ5TndFVi/xspL/+AUUMkr6tQ KK/ykTayv65ioa5T+VCFVclatama9wUcBkHQIU/ej9c4Njj9yXqTlBS7FC5Jieqo GBVHwuv0jNqMHBcAT5jR/V09wfbb3dmoz4yzdKJFGNRfpTeDFfF8qEbOO4AIN3Vy TRQQJJXXoz+UO+Ml0ZfYHxBsOnXSmiIHC8Pcdd9MTsY9XPUw1fFi+zLpXu8urm9Q vb7jaq/Ns9dXETrLE1m9 =jMxz -----END PGP SIGNATURE-----

1 1

Re: ntdll: Fix a spelling error.
by Nikolay Sivov March 4, 2015

March 4, 2015

> - * The returned unix_fd should be closed iff needs_close is non-zero. > + * The returned unix_fd should be closed if needs_close is non-zero. It's not necessary misspelled, 'iff' is a short form of 'if and only if'.

2 1

Re: msvcrt: Use Dragon4 algorithm to fix inconsistent rounding behaviour for sprintf and add tests. (try 2)
by Dmitry Timoshkov March 4, 2015

March 4, 2015

YongHao Hu <christopherwuy(a)gmail.com> wrote: > +typedef int int32_t; > +typedef unsigned char uint8_t; > +typedef unsigned long uint32_t; > +typedef unsigned long long uint64_t; Please use appropriate win32 types instead. Besides using 'typedef unsigned long uint32_t' is wrong. -- Dmitry.

2 1

Re: ws2_32/tests: Remove an unused assignment (PVS-Studio)
by Marvin March 4, 2015

March 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11891 Your paranoid android. === w2003std (32 bit sock) === sock: unhandled exception c0000005 at 00000000

2 1

Re: [PATCH 1/4] wined3d: Properly up-scale WINED3DFMT_R5G5_SNORM_L6_UNORM.
by Matteo Bruni March 4, 2015

March 4, 2015

2015-03-02 22:29 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>: > Simply left-shifting is not enough in positive ranges. 0xff / 255 != > 0xff00 / 65535. > > Using the compiler to read 5 bit signed values seems a lot easier than > operating with masks. > --- > dlls/wined3d/utils.c | 44 +++++++++++++++++++++++++------------------- > 1 file changed, 25 insertions(+), 19 deletions(-) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index 1ce23ac..67457d5 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -290,6 +290,15 @@ static void convert_l4a4_unorm(const BYTE *src, BYTE *dst, UINT src_row_pitch, U > } > } > > +#include <pshpack1.h> > +struct r5g5l6 > +{ > + signed r : 5; > + signed g : 5; > + unsigned l : 6; > +}; > +#include <poppack.h> > + AFAIK C doesn't give any guarantee on a specific allocation of bitfields in memory. I'm sure this works in practice with GCC and maybe also with the other compilers we care about, but if it doesn't get too ugly I'd prefer explicit shifts and masks and be safe. In any case, this should use signed / unsigned short at least.

2 1

Re: [2/3] dpnet: Free previous allocated data (try 2)
by Stefan Dösinger March 4, 2015

March 4, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-04 um 04:15 schrieb Alistair Leslie-Hughes: > + if(entry->type == DPNA_DATATYPE_STRING_ANSI) > + heap_free(entry->data.ansi); > + else if(entry->type == DPNA_DATATYPE_STRING) > + heap_free(entry->data.string); > + else if(entry->type == DPNA_DATATYPE_BINARY) > + heap_free(entry->data.binary); This code is OK with me. What I think Nikolai meant was that you don't need the if / else if / else if checks and can just call heap_free(entry->data.binary) (or heap_free(entry->data.ansi) or heap_free(entry->data.string)) regardless of the type because it's just a union. However, there's a caveat, and this is why I think the code you have is reasonable: You don't want to free a non-pointer type (DPNA_DATATYPE_DWORD, DPNA_DATATYPE_GUID), so you need to check the type anyway. And if you have the code above or if (type == STRING || type == BINARY || type == ANSI) free(data.binary) doesn't really make a difference IMHO. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9um8AAoJEN0/YqbEcdMwh1wP/iQp3BbqRYT/5UqR+SJodAA+ 4MlKAmhdZ395k4G5AFAw6uZ1RnOxVjq0BH20jQbVo+l2bNiHPEsSQ0Ua9tcdQjR3 wA70dQpIQgL9/XCHxQZKfZN1ujEcAR0IsgOxqEW7mPQNwe/hRYPSLysubUJaYGeR cExeKFdabEM5pEIu+OwPxdvevRSVMA2Je38dlggMnIkq4ajJIM7I+x87GEJAxzaJ U3RsqqgTI2jvFspG5F12/O3hpynoAPUiHgsoQgzolMIcJLwqMaCFuM+Ify4kZotq h/Hdk8hR5BjBwAOJZZwJqyCYaulSVftRYH1k33N75o7LHOgwWDps/C7jzg7sgyLE F+187z1RBfWtvUmeJORRlezo1v9rceIqRX8H7rfKfsec500gF0KtVWcQxhENxfp/ +j5vgms5gSAtzvgig50Oq35GCULWspjzz4AnxzEB8BH/Z6ugE4zakejlAjUVMUVR T0iTKkhp25U7L4jl8TqKSJ82TZMh2Yc8ydrieO/XVNtMH5yjIw/A0Ecb+laKlwMy OfI9rQOUPyFhxu2dtxEn4MCgCussBF+Py9gL3mZ2ausfIttw8hH2nigb0sMud0YC oDPyTmVDK5ALvducoHi/QQhBoCh1duYkiscAj1n3IfYBNc/d89vKxmtEDr9O/jk1 QNm18QYpQzTXoprDPmQM =TILa -----END PGP SIGNATURE-----

1 0

Help with testing new Gecko downloader
by Jacek Caban March 4, 2015

March 4, 2015

Hi all, My today patch [1] together with changes in Wine code from yesterday changed the way we interact with SourceForge for downloading Gecko. It's a risky change that could use wider testing from different locations. If you'd like to help, you need to: - Remove wine_gecko-2.36*.msi if you already have it. If you used downloader to get it, it's most likely in ~/.cache/wine. If you downloaded it manually, you know where to find it. - Create new wineprefix The most important thing is to ensure that downloading and installing Gecko still works. The expected difference is shorter connection time and faster downloads (or better said, no slow downloads). I appreciate any feedback on this. Thanks, Jacek [1] http://source.winehq.org/patches/data/109462

2 2

Re: include: add initial d3dx10core.h
by Matteo Bruni March 4, 2015

March 4, 2015

Can you replace the names of the methods arguments with some non-Hungarian alternatives? If nothing else, just to avoid having those declarations match those in the MS header character by character. Also please avoid tabs.

3 3

GSOC 2015 Applicant
by Balkrishna Srivastava March 4, 2015

March 4, 2015

Hi, I am Balkrishna Srivastava, a 3rd year dual degree undergraduate from BITS Pilani, Pilani Campus, India. I completed my computer programming course in C. I have also been doing extensive competitive coding on codechef.com in c ( profile: http://www.codechef.com/users/bali161616 ). I wish to contribute to your organisation this GSOC. I know c, java, python and c++. Please guide me how to go about contributing to your organization. -- *Regards* *BALKRISHNA SRIVASTAVA* *Undergraduate Student* *B.E.(Hons.) Computer Science* *M.Sc.(Hons.) Physics* *▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄* *Birla Institute of Technology & Science,* *Pilani*

2 1

Re: ntdll: Assert when trying to replace an exiting file descriptor in fd_cache.
by Alexandre Julliard March 4, 2015

March 4, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > The condition "prev_fd != -1" should never be true. If this is the case then something > is going terrible wrong, and it is better to assert instead of just closing the file > descriptor. It can happen if the handle was closed on the server side but not yet removed from the cache. Yes, handling of that case is not ideal, but an assert is not an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] vbscript: Implemented Asc(try 3)
by Marvin March 4, 2015

March 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11880 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: shell32: fix a test failure in shlfileop.c
by Zhenbo Li March 3, 2015

March 3, 2015

Excuse me, Is there anything to do to improve this patch? Thanks. Zhenbo Li 2015-02-27 8:52 GMT+08:00 Zhenbo Li <litimetal(a)gmail.com>: > I cross-compiled dlls/shell32/tests, and found that wvistau64 failed[1]. > This tiny patch should fix it > > > [1]: http://testbot.winehq.org/JobDetails.pl?Key=11761 > shell32_crosstest: > shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR > > > --- > dlls/shell32/tests/shlfileop.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > > > > > -- Have a nice day! Zhenbo Li

2 1

Re: [3/3] dpnet: Always update Component type since it can change (try 2)
by Marvin March 3, 2015

March 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11876 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 3)
by Marvin March 3, 2015

March 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11875 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: Shuai Meng : shell32: Also return Attributes in GetFolderDefinition.
by Bruno Jesus March 3, 2015

March 3, 2015

On Tue, Mar 3, 2015 at 12:42 PM, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 0becff824466b330675fabbd59241a150eebabeb > URL: http://source.winehq.org/git/wine.git/?a=commit;h=0becff824466b330675fabbd5… > > Author: Shuai Meng <mengshuaicalendr(a)gmail.com> > Date: Mon Mar 2 16:12:19 2015 +0800 > > shell32: Also return Attributes in GetFolderDefinition. I may be dreaming but is this the right patch? It looks like the patch from Shuai was commited with the subject from Andrew's patch. http://source.winehq.org/patches/data/109528 Best Regards, Bruno

2 1

Re: ws2_32: Implement returning the proper time with SO_CONNECT_TIME. (resend)
by Bruno Jesus March 3, 2015

March 3, 2015

On Tue, Mar 3, 2015 at 9:51 PM, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > I know that Bruno was also planning to work on this, but haven't seen any > attempt since my last submission over three months ago. If there is a better > solution for all this, I am pretty sure that it still can be changed later. I'm fine with it, I have many non-finished patches pending here but I don't have time to work on them now. I just don't understand why we can't simply return the time in seconds directly from the server to avoid that weird division =) Best Regards, Bruno

1 0