March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdiplus: Store IWICBitmapDecoder inside GpBitmap
by Vincent Povirk March 10, 2015

March 10, 2015

As long as we're doing this, we should probably make use of the decoder in GdipImageSelectActiveFrame, and maybe we shouldn't bother when we just have one frame. On Mon, Mar 9, 2015 at 12:33 PM, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 1 + > dlls/gdiplus/image.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > > > >

2 1

Re: [PATCH 3/3] gdiplus: Fix animated gif frames composition
by Dmitry Timoshkov March 9, 2015

March 9, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 5 ++ > dlls/gdiplus/image.c | 193 > +++++++++++++++++++++++++++++++++++++---- > 2 files changed, 181 insertions(+), 17 deletions(-) Besides its complexity this probably needs a split, and it seems to me that GIF transparent color index is not properly handled. -- Dmitry.

1 0

Re: [PATCH 2/3] gdiplus: Convert gif frame to DIB on load
by Dmitry Timoshkov March 9, 2015

March 9, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > + bitmap->format = PixelFormat32bppARGB; Please add a test confirming this. -- Dmitry.

1 0

Re: [PATCH 3/3] gdiplus: Fix animated gif frames composition
by Vincent Povirk March 9, 2015

March 9, 2015

+ hr = IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICBitmapSource, (void**)&bmp_source); FrameDecode inherits Source so I don't think this is necessary? None of this seems obviously wrong to me, but it is complicated and interesting behavior. I'm not sure if I understand it all.

1 0

Re: [4/4] winmm/tests: Add notify tests for MPEGVideo device.
by Marvin March 9, 2015

March 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12014 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

1 0

Re: [PATCH] wine.inf: Add some knownfolders to the registry
by Marvin March 9, 2015

March 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12013 Your paranoid android. === w8 (32 bit shellpath) === shellpath.c:471: Test failed: CSIDL_PERSONAL has unexpected type 46 (0x2e) shellpath.c:480: Test failed: CSIDL_PERSONAL has unexpected type 46 (0x2e) shellpath.c:545: Test failed: CSIDL_PERSONAL: got GUID {a8cdff1c-4878-43be-b5fd-f8091c1c60d0}, expected {450d8fba-ad25-11d0-98a8-0800361b1103} shellpath.c:1835: Test failed: invalid known folder parsing name returned for FOLDERID_Videos: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{A0953C92-50DC-43BF-BE83-3742FED03C9C}" retrieved shellpath.c:1317: Test failed: invalid known folder parsing name returned for FOLDERID_Pictures: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{3ADD1653-EB32-4CB0-BBD7-DFA0ABB5ACCA}" retrieved shellpath.c:1607: Test failed: invalid known folder attributes for FOLDERID_SamplePictures: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1083: Test failed: invalid known folder parent for FOLDERID_Cookies: FOLDERID_RoamingAppData expected, but {f1b32785-6fba-4fcf-9d55-7b8e7f157091} retrieved shellpath.c:1083: Test failed: invalid known folder relative path returned for FOLDERID_Cookies: Microsoft\Windows\Cookies expected, but L"Microsoft\\Windows\\INetCookies" retrieved shellpath.c:1598: Test failed: invalid known folder attributes for FOLDERID_SampleMusic: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1263: Test failed: invalid known folder parsing name returned for FOLDERID_Music: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{1CF1260C-4DD0-4EBB-811F-33C572699FDE}" retrieved shellpath.c:1128: Test failed: invalid known folder parsing name returned for FOLDERID_Downloads: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{374DE290-123F-4565-9164-39C4925E467B}" retrieved shellpath.c:1625: Test failed: invalid known folder attributes for FOLDERID_SampleVideos: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1110: Test failed: invalid known folder parsing name returned for FOLDERID_Documents: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{A8CDFF1C-4878-43be-B5FD-F8091C1C60D0}" retrieved shellpath.c:1200: Test failed: invalid known folder relative path returned for FOLDERID_InternetCache: Microsoft\Windows\Temporary Internet Files expected, but L"Microsoft\\Windows\\INetCache" retrieved

1 0

Re: [PATCH 3/4] wshom.ocx: Implement Exec() method
by Jacek Caban March 9, 2015

March 9, 2015

Hi Nikolay, On 03/09/15 06:41, Nikolay Sivov wrote: > + if (!CreateProcessW(NULL, command, NULL, NULL, FALSE, 0, NULL, NULL, &si, &info)) > + return HRESULT_FROM_WIN32(GetLastError()); > + > + hr = WshExec_create(&info, ret); > + if (FAILED(hr)) { > + TerminateProcess(info.hProcess, hr); This is questionable error handling. You wouldn't need that if you called WshExec_create before CreateProcessW. Cheers, Jacek

2 1

Re: [5/5] ws2_32/tests: Add more select() tests (try 2)
by Marvin March 7, 2015

March 7, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11987 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: [4/5] ws2_32/tests: Improve setup_connector_socket to allow non-blocking connect calls
by Marvin March 7, 2015

March 7, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11986 Your paranoid android. === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (c54): unexpectedly at the OOB mark: 0

1 0

Using compiler error information to check undocumented prototypes and structures?
by Qian Hong March 7, 2015

March 7, 2015

Hi, On Thu, Mar 5, 2015 at 7:27 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote: > I'm expecting it to be quite hard taking in account the functions are not > documented and that you can't look on the headers while working on it. Could we use compiler error information to check undocumented prototypes and structures? For example, assume we don't know the prototype of CreateWindowExW. Let's write a test program test.c like below: #include <windows.h> void CreateWindowExW(); int main(void) { CreateWindowExW(); return 0; } Then we compile test.c on Windows using: gcc -sysroot /path/to/MicrosoftSDK/include test.c Then we will get some error message like: In file included from /path/to/windows.h:72:0, from test.c:1: /path/to/winuser.h:1935:26: note: previous declaration of ‘CreateWindowExW’ was here WINUSERAPI HWND WINAPI CreateWindowExW(DWORD dwExStyle,LPCWSTR lpClassName,LPCWSTR lpWindowName,DWORD dwStyle,int X,int Y,int nWidth,int nHeight,HWND hWndParent,HMENU hMenu,HINSTANCE hInstance,LPVOID lpParam); Then we will know the correct prototype. In theory VC++ and clang should do similar job as well. Could that be a valid way to detect a function prototype and a data structure when re-implementing undocumented API? If it's valid, we can consider setting up a AppVeyor CI account and connect to a github account to provide a "MS type and structure query service". AppVeyor CI provides a free (as beer) Windows environment and VC++ compiler (third party compilers like gcc and clang can be installed as well). By tweaking the setting, we can trigger AppVeyor rebuild by pull request. In that case, whenever we need to query a undocumented prototype or structure, we can just write a (wrong) test case and submit a pull request, without reading MS headers by human. Any thought is appreciated. -- Regards, Qian Hong - http://www.winehq.org

4 5

Doubt about translation related to hhctrl.rc
by Bruno Jesus March 7, 2015

March 7, 2015

Hi all, in order to check for the correct hotkey assignment I need to see the screen this is used. Can anyone help? >From pt_BR.po: 3153 #: hhctrl.rc:83 3154 #, fuzzy 3155 #| msgid "Properties" 3156 msgid "Proper&ties" 3157 msgstr "Propriedades" Best regards, Bruno

2 2

Re: ddraw/tests: Fix compilation on systems that don't support nameless unions.
by Marvin March 7, 2015

March 7, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11972 Your paranoid android. === w8 (32 bit visual) === visual.c:1617: Test failed: unexpected colortable on offscreen surface === wvistau64 (32 bit ddraw7) === ddraw7.c:2524: Test failed: Expected message 0x46, but didn't receive it. ddraw7.c:2526: Test failed: Expected screen size 1024x768, got 0x0. ddraw7.c:2532: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2563: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2571: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2598: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2618: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2635: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2662: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2679: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2716: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2727: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2754: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2774: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2791: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2818: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2835: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw7.c:2873: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}.

1 0

Re: [PATCH 5/5] wined3d: Support WINED3DFMT_R5G5_SNORM_L6_UNORM with EXT_texture_snorm.
by Stefan Dösinger March 7, 2015

March 7, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-07 um 10:03 schrieb Stefan Dösinger: > From: Stefan Dösinger <stefandoesinger(a)gmx.at> I wrote this on a different computer, it turns out I had a different E-mail address set there... -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU+r94AAoJEN0/YqbEcdMwzn0P/iFvgnhB2cZZnxR8OvV+thA1 a8Mg0k+hCw2rMKjsxvMKNf7Q6axfLaS/aR7xeHYkyVMr0d6P1JIWJwTJmzIQxd9x hxwUytx7bu4u5eFp1aCXDhfkEyrP+p09+XMtEIgAOKriudO+Fx6AU9VBrwNul74w raCiVhh3+UJy1kaZZYzTgAKB7rSuPRGJdKvk+Ai0c74BWv5YA9+Sc+NXAND+3Y0r dx8W035zfIu7eYQ1nmRadAhE40cndiRix9qYZig+s4lHFBHkHJoUPe0PX6qQSeOp tkY+4wGVdKD6CUFZQuTW3C8yW49bUibTcuThznpidZolrSsv4AjpYbnBSSecy4ts xloCM2zCJYgErtcUwDOsOK77W0k7/uNOBZWhLkWanaRLHcbgVVNXy99tMqwNSXyz uX8GMLwgWoeDM5eOj4a+9R0wBhp1HMOUsX+rpw1v4dFogdxgFPjMhAUWF93g1YfO cquKm2kYZqX5Xa3x2up37tejGzVTQASxqpxFxgL6No4oaIdhw9CscoPYkaEsbmD6 +P9iFV8eFBSCjH98zfDnoigNcmH7jV3EPeTqfPoSLylpcWcA0vIVRNj5w1Vz/04g bkAUHD2ya0nnLLD/09VhkATsR/4fEwpp+1hJimJmBxEIUCfS5qfT+SbsO1Euzgnn WjrUnhrsG5tNxxwkevlb =zJBD -----END PGP SIGNATURE-----

1 0

Re: [1/4] ws2_32/tests: Fix a NT4 crash due to unsupported functions
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11962 Your paranoid android. === w2003std (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 0000000000000000

2 1

Re: [4/4] ws2_32/tests: Add more select() tests
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11965 Your paranoid android. === w2000pro (32 bit sock) === sock.c:3627: Test failed: expected 'A', got === wxppro (32 bit sock) === sock.c:3627: Test failed: expected 'A', got sock: unhandled exception c0000005 at 00000000 === w2003std (32 bit sock) === sock.c:3627: Test failed: expected 'A', got sock: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit sock) === sock.c:3627: Test failed: expected 'A', got === w2008s64 (32 bit sock) === sock.c:3627: Test failed: expected 'A', got === w7u (32 bit sock) === sock.c:3627: Test failed: expected 'A', got === w8 (32 bit sock) === sock.c:3627: Test failed: expected 'A', got === wvistau64 (64 bit sock) === sock.c:3627: Test failed: expected 'A', got === w2008s64 (64 bit sock) === sock.c:3627: Test failed: expected 'A', got sock: unhandled exception c0000005 at 0000000000000000

1 0

Re: [3/4] ws2_32/tests: Improve setup_connector_socket to allow non-blocking connect calls
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11964 Your paranoid android. === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 0000000000000000

1 0

Re: [2/4] ws2_32/test: Don't test unsupported IP_MULTICAST_TTL on NT4
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11963 Your paranoid android. === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: user32: Allow making window visible by WM_SETREDRAW message.
by Dmitry Timoshkov March 6, 2015

March 6, 2015

Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/user32/win.c | 7 ++----- > dlls/user32/win.h | 1 - > dlls/user32/winpos.c | 3 --- > 3 files changed, 2 insertions(+), 9 deletions(-) This change needs quite a bit of tests. -- Dmitry.

2 1

Re: mmdevapi/tests: Remove an unused assignment (PVS-Studio)
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11941 Your paranoid android. === w7u (32 bit render) === render.c:1975: Test failed: Got wrong volume: 0.501088 render.c:2004: Test failed: Got wrong volume: 0.501088 === w8 (32 bit render) === render.c:1975: Test failed: Got wrong volume: 0.671337 render.c:2004: Test failed: Got wrong volume: 0.671337

2 1

Re: [3/4] dpnet: Always update type since it might change (try 5)
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11938 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [1/4] dpnet:Add check for mismatched string lengths (try 5)
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11937 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 1/4] windowscodecs: Add helper to create internal COM classes without CoCreateInstance call if possible
by Vincent Povirk March 5, 2015

March 5, 2015

Thanks for working on this. The series looks good to me. + hr = WICCreateImagingFactory_Proxy(WINCODEC_SDK_VERSION, &factory); + ok(hr == S_OK, "CoCreateInstance error %#x\n", hr); This message doesn't match the call.

1 0

hostname: Remove redundant codepath and replace with FormatMessage
by Hugh McMaster March 5, 2015

March 5, 2015

How does patch 109550 need to improve? (http://source.winehq.org/patches/data/109550) Thanks, Hugh

1 0

Re: [PATCH 1/4] reg: Add path/key conversion functions
by Stefan Dösinger March 5, 2015

March 5, 2015

I think these patches can be split further. And yeah, I could have thought of some of this sooner :-( . 1.1: A patch that replaces the if chains with the table 1.2: A patch that merges the duplicated string splitting with reg_open 2.1: Implement REG_MULTI_SZ. Use this patch to strip LPCRAP from the function definition 2.2: Improve REG_DWORD. I think you can merge the REG_DWORD_BIG_ENDIAN support into this patch, since it is just another REG_DWORD. 2.3: Add REG_NONE. Just a one-liner and todo_wine removal. 2.4: Add REG_EXPAND_SZ. Another one-liner. 2.5: Add REG_BINARY. Patch 3: I think at least the check > + if (value_name && value_empty) > + { > + reg_message(STRING_INVALID_CMDLINE); > + return 1; > + } Is independent of the rest. I may be missing something though. Another question that pops up in my mind is this: > + if (value_name && !value_name[0]) > + value_name = NULL; This is interesting together with the value_name && value_empty check. I suspect /v "" /ve still results in an error, but it is worth a test in a separate patch. This can be after the existing series as far as I'm concerned. > + if (!argvW[++i][0] || argvW[i][1]) > + { > + reg_message(STRING_INVALID_CMDLINE); > + return 1; > + } Can also go in a separate patch. > + if (err != ERROR_SUCCESS){ I expect Alexandre to hit me with a brick now, but this is inconsistent with the rest. Patch 4 can be split in a similar fashion: > + /* Mutually exclusive options */ > + if ((!!value_name + !!value_empty + !!value_all) > 1) I think merging the existing (and broken) checks for that is separate from the rest. The changes you make to handle value_all can also be separated I think. That will make this patch easier to read. Stefan Am 04.03.2015 um 17:29 schrieb Jonathan Vollebregt <jnvsor(a)gmail.com>: > --- > programs/reg/reg.c | 166 +++++++++++++++++++++++++++-------------------------- > 1 file changed, 86 insertions(+), 80 deletions(-) > > <0001-reg-Add-path-key-conversion-functions.patch>

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11930 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0