March 2015 - Wine-Devel - list.winehq.org

[BISECTED REGRESSION] icons in nanocad have black background
by Andrey Skvortsov March 27, 2015

March 27, 2015

Hi, The issue was originally described here: https://bugs.winehq.org/show_bug.cgi?id=34825 I bisected both issues, but I'll create separate thread to the issue with file dialog. First bad commit that causes black background on icons is: [ b81a7d976e3c3de36a01401d125871d3014e6c67 ] gdi32: Always use the DIB engine for monochrome bitmap rendering. To see how the issue looks like, I attached small screenshots. -- Best regards, Andrey Skvortsov Secure eMail with gnupg: See http://www.gnupg.org/ PGP Key ID: 0x57A3AEAD

2 1

Re: [PATCH] vbscript: Implemented Oct(try 2)
by Marvin March 27, 2015

March 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12462 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] schannel_gnutls: when calling pgnutls_server_name_set ensure that the values are sane
by Jacek Caban March 27, 2015

March 27, 2015

Hi Nikos, On 03/27/15 17:25, Nikos Mavrogiannopoulos wrote: > This patch addresses issue with schan_imp_set_session_target() > translation to gnutls API. It does not pass invalid (null) parameters to > it, as this seems to cause issues. Addresses > https://bugs.winehq.org/show_bug.cgi?id=38134 Take a look at schan_imp_set_session_target caller in schannel.c. It already ensures that passed target is not NULL. If your patch indeed fixes a real problem, it's probably because it also ignores an empty string. That's, however, something that should also be done on caller side. Thanks, Jacek

1 0

Re: [PATCH] wineconsole: Set input stream buffer length per OS limit
by Nikolay Sivov March 27, 2015

March 27, 2015

On 26.03.2015 14:32, Hugh McMaster wrote: > --- > programs/wineconsole/wineconsole.c | 32 ++++++++++++++++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/programs/wineconsole/wineconsole.c b/programs/wineconsole/wineconsole.c > index 3c2faf5..81300ed 100644 > --- a/programs/wineconsole/wineconsole.c > +++ b/programs/wineconsole/wineconsole.c > @@ -797,6 +797,11 @@ static UINT WINECON_ParseOptions(const char* lpCmdLine, struct wc_init* wci) > return 0; > } > > +#define MAXSTRING_NON_NT 128 > +#define MAXSTRING_NT351 260 > +#define MAXSTRING_NT4_W2K 2048 > +#define MAXSTRING_XP 8192 > + Why do you need this mess?

3 3

Re: [PATCH 5/6] wined3d: Introduce a shader_snprintf() function.
by Henri Verbeet March 27, 2015

March 27, 2015

On 26 March 2015 at 20:12, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > It could be used in more places, some of them need additional rework > though. > I'm not sure this is what you had in mind. I didn't feel like making > these strings heap allocated, it seems to get quite ugly that way. It's not quite fully worked out at this point, but what I have in mind is roughly to use wined3d_shader_buffer. The shader_glsl_priv structure can then keep a list of scratch buffers from which you can get one to construct these kinds of intermediate strings and release back to when you're done with them. It would probably also involve cleanup functions for e.g. glsl_src_param and glsl_dst_param at some point. In principle this patch is in the right direction, but I'd rather avoid putting this in now and then having to change it again later.

1 0

Re: [PATCH] cmd: Add basic handling of Ctrl-C
by Nikolay Sivov March 27, 2015

March 27, 2015

On 26.03.2015 14:32, Hugh McMaster wrote: > + /* Enable handling of Ctrl-C signals */ > + if (SetConsoleCtrlHandler((PHANDLER_ROUTINE)console_ctrl_handler, TRUE)) > + WINE_TRACE("cmd: Ctrl handler was installed.\n"); > + else > + WINE_ERR("cmd: Unable to install Ctrl handler.\n"); > + Judging by the fact that you needed a cast, that's not right.

3 3

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo
by Erich E. Hoover March 27, 2015

March 27, 2015

On Thu, Mar 26, 2015 at 2:59 PM, Erich E. Hoover <erich.e.hoover(a)wine-staging.com> wrote: > On Thu, Mar 26, 2015 at 12:10 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote: >> ... >> The inheritance doesn't occur when function from ntdll are used for setting >> DACL. This makes your code inside server incorrect. Also your code is not >> checking handle permissions correctly. If you try to test it keep in mind >> that if correct inheritance flags are set in security descriptor control >> field the permissions will be filled when you right-click on file and >> display security properties on windows. > > I don’t have the time to write a test at the moment, but I find it > highly unlikely that MS would implement security descriptors in a > high-level DLL. If that were the case then an application could > easily hijack the API in order to permit access to files that would > otherwise be inaccessible. I would guess that > UNPROTECTED_DACL_SECURITY_INFORMATION and SE_DACL_AUTO_INHERITED > probably enter into this somehow. > > Besides that I think we should start implementing stored ACLs first, > before even thinking about implementing suitable inheritance > mechanisms. I submitted a bunch of patches for this some time ago, > but Alexandre wasn’t happy with using extended user attributes to > store this information. I’m just not sure that it’s useful to > implement inheritance without storing the ACLs, it’ll certainly fix > some apps but it will likely break a bunch of others. Whoops, forgot reply-all - sorry for the duplicate Piotr. Best, Erich

2 1

Re: [PATCH 1/5] include: Add Wine-specific theming hook struct to winuser.h
by Alexandre Julliard March 27, 2015

March 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > @@ -4060,6 +4060,15 @@ WORD WINAPI SYSTEM_KillSystemTimer( WORD ); > WINUSERAPI BOOL CDECL __wine_send_input( HWND hwnd, const INPUT *input ); > #endif > > +/* Wine-specific version of the undocumented structs > + * used by uxtheme to hook into user32. */ > + > +typedef struct > +{ > + WNDPROC DefWindowProcA; > + WNDPROC DefWindowProcW; > +} WINEUSERAPIHOOK; This doesn't belong in winuser.h. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] comctl32: Redraw themed button on WM_ENABLE.
by Alexandre Julliard March 27, 2015

March 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > When a themed button received a WM_ENABLE message, comctl32 redraws it, > then passes the message to the parent proc in user32. Unfortunately, this > is the wrong way round - as user32 redraws the window itself, the themed > button will be redrawn as its unthemed counterpart. It sounds like it's only hiding the problem. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] vbscript: Implemented Oct
by Marvin March 27, 2015

March 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12441 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Re: [2/3] windowscodecs: Implement PngDecoder_Block_GetCount.
by Alexandre Julliard March 27, 2015

March 27, 2015

Vincent Povirk <madewokherd(a)gmail.com> writes: > From 398cd35190fddb05de97f6b125897be6c0e9e92d Mon Sep 17 00:00:00 2001 > From: Vincent Povirk <vincent(a)codeweavers.com> > Date: Wed, 25 Mar 2015 14:26:28 -0500 > Subject: [PATCH 2/3] windowscodecs: Implement PngDecoder_Block_GetCount. > > --- > dlls/windowscodecs/pngformat.c | 80 +++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 76 insertions(+), 4 deletions(-) ../../../tools/runtest -q -P wine -T ../../.. -M windowscodecs.dll -p windowscodecs_test.exe.so metadata && touch metadata.ok metadata.c:949: Test succeeded inside todo block: GetCount failed, hr=80070057 metadata.c:952: Test succeeded inside todo block: GetCount failed, hr=0 metadata.c:953: Test succeeded inside todo block: unexpected count 1 Makefile:375: recipe for target 'metadata.ok' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/4] advapi32: Add DACL inheritance support in SetSecurityInfo
by Erich E. Hoover March 26, 2015

March 26, 2015

I do not believe this is the correct place to make this change. Inheritance still needs to occur even when SetSecurityInfo is not used, which pretty much means it has to be within the wineserver itself so that the same code can be used for CreateFile. The code I put together for this (as written it is somewhat dependent on my other ACL code) can be found here: https://github.com/wine-compholio/wine-staging/tree/master/patches/server-I… The first patch is for CreateFile and the second one is for SetSecurityInfo. I'm happy to try and change this to help you solve your problem without my other ACL code, it's been on my TODO list anyway - I've just been too busy with work lately :/ Best, Erich

4 4

Re: urlmon: Remove unneeded NONAMELESSXXX directives.
by Jacek Caban March 26, 2015

March 26, 2015

Hi Francois, On 03/26/15 15:29, Francois Gouget wrote: > Also put them in the files that need them. It may be a bit late for such question after so many patches already went in, but what's the point of this patch? Those defines are defined in central place, so that we don't have to deal with them in each .c file. Even if they are not needed for some .c files, they are harmless. BTW, I think we could even consider putting this macro in a central place like windef.h inside __WINESRC__ guard. Jacek

1 0

named memory-mapped file
by Leon Bogaert March 26, 2015

March 26, 2015

Hi all, I don't know if this is the correct list. If it's not I'm sorry. I have kind of a weird question. I'm playing this game iRacing which exposed it's api via named memory map ( https://github.com/meltingice/node-iracing/blob/master/lib/irsdk_utils.cpp) Is there a way I can access that named memory-mapped file via Linux? I did some Googling and I don't think it's possible but I thought I made sure to ask around here. If that isn't possible I think I'll write a simple program that would run under wine and expose that data in a Linux-friendly manner. Leon

3 4

how to upload and view reports
by Shubham kumar March 26, 2015

March 26, 2015

Sir, i have applied for winetest graphical user interface project. Problem is to see the test results in application itself we first need to know that how it shows report on test.winehq.org so that, we could get idea on how it shows report after uploading. But, on the website i could not find any link to upload the report. Where/How am i supposed to upload the report and view the test results on website?

2 1

Application for GSoc 2015 - Implement vbscript.dll builtins for Wine
by Shuai Meng March 26, 2015

March 26, 2015

Hello everyone, I'm Shuai Meng, a student from Beihang University of China, who have attended Gosc 2014 for wine vbscript. I would like to continue to work on this module this year: on one hand, I am familiar with it through last year's experience; on the other hand, as I have studied it deeper and deeper, I find it more difficult than imagined, and I think understanding and fulfilling this interpreter of vbscript is very meaningful and interesting. Last year, the relatively simple built-in functions have been implemented by my effort, with the generous help of many warm-hearted people. The left functions are more challenging, I have to study more about COM and DLL in order to understand the mechanism. Now let's talk about the details of my plan, the functions unimplemented can be sorted as below: 1.The first kind is the functions about date and time, they have not been implemented because Wine's vbscript is not able to parse date constant in the form of "#yy-mm-dd#" yet. The functions below can be hopefully implemented as long as I sovle this problem: IsDate CDate Day Month Weekday Year Hour Minute Second DateValue TimeValue DateSerial TimeSerial DateAdd DateDiff DatePart. 2.The second kind is about strings, they are LenB LeftB RightB MidB InStrB Replace String StrComp. I have sent some patches to implement String, which all failed. Then I realized that I have to solve the problem of locale before I can implement them. 3.The third kind is about characters: Asc AscB ChrB ChrW Escape Unescape, I have already sent patch for Asc, but due to the same problem as strings, it didn't work. Again I have to implement GetLocale and SetLocale function, however as Piotr pointed, these two functions are not registered in native typelib, so I have to figure out another way to implement them, instead of using idl files. 4.The fourth kind is about arrays: IsArray LBound UBound Array Filter Join Split. Though haven't considered them seriously, but I can feel that they harder than those listed before. 5.The fifth kind is about math, but only left Randomize and Rnd, they are a little difficult, but I think it's unnecessary to implement them manually, I mean there must be a wrapper function. I have found some samples in jscript and other modules, I will learn from them. 6.The sixth kind is others: Eval Execute ExecuteGlobal GetRef LoadPicture InputBox FormatNumber FormatCurrency FormatPercent FormatDateTime, they are the most difficult, I am not sure whether I can implement them, but I will try. 7.The remaining functions are about Error handling: Err_Description Err_HelpContext Err_HelpFile Err_Source Err_Raise. I haven't studied them yet, but sooner or later I will meet them. This is my idea for GSoC 2015, I appreciate for any comment. Thank you.

1 0

Re: ntdll/tests: Add tests for GetFinalPathNameByHandleA/W.
by Marvin March 26, 2015

March 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12425 Your paranoid android. === wvistau64 (32 bit file) === file.c:369: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:369: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: winecfg: add note about 32 bit prefixes to dialog
by Stefan Dösinger March 26, 2015

March 26, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I think making this visible on some way is a good idea. I have wondered about this myself, and so have many other users. > Context behind this: To run Simcity 2000 I change my Wine prefix > settings to mimic NT 3.5 so that it uses a different file chooser > dialog which doesn't crash the game (for whatever reason). This > last time installing things I was confused about why I didn't see > the option for NT 3.5 until slackner reminded me on IRC that I need > a 32 bit prefix to have that option. Somewhat offtopic to your patch: Is this a known bug in the game? Does it crash in Windows XP or newer unless you set Win9x or Win NT compatibility? It may be a good idea to investigate the actual crash. > So, I thought it might be useful if the dialog could have a note > explaining why those options aren't there if you're running from a > 64 bit prefix -- and thus this patch. To make room for the text I > made the applications Listbox 20 pixels shorter. - From a user interface point of view, what do you think about adding those old Windows versions in the listbox, maybe with a different text like "Windows 98 not available in 64 bit", and programming the code to set the dropdown field back to the last setting if the user decides to choose one of those settings? Or instead of having the modified text, pop up an error box and set the setting back. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVEea8AAoJEN0/YqbEcdMwQCsP/0Uw+ogXWRBtTZz46g8s6hAD wZjtYdFWfx9FMbITjpA9E2VLvmHj4tN6wZDanqOLuaHIRL3Mxa8eKaeZZ+LqE6pL mZWWJcWEQ+V8C/Fr6UTFUsbFhhSDTPhw9BJH/vZBof7uw0evNfBvV6lFQ+nf5bq7 Tpcwu+cBCeVlm9atvChZLwFAuBqjeVuH5ibyGnADIxKScHKvM9rbuJf2f3g3d7bW jCpR5sxoXfgeDeZYyaFh4o3WPHjVKriT3Twz2pYgHe/yZbxgoto72a7WNr5dMdHu 4/2FCQoBoDX2HahnCgWiL7fSDLk3pZFBQ78JRZUKDcS5nj868PszszAn4REVPXEW sgL5dgQqEJs0WhlhAePnUhuPudEaOIdKRDHqMftqJZpTwMxBwo16vnEnsLejrhlB Br2s2YIlqhpF0GKx4TeaefYFlJI/uRlxyhsmUBOvcfZ/BrLtpY9JMSHg0nGPnbI4 IUyU6iBQ5KSLjyDFDFTQ/gS19vbVtzJuEI88wtcUb0I2FknIa2zZN7GBDKN+VxOl hhtiiz1wgfxrrejVTxRKVVDF6bk5BpBWHLIyVIWVxZLiKy46I5Zie2MhbG74A5ks P1vph231JUHeea51wxFOfbUjw7LcTwhHswj8YM2I1EPizOH0AWJS5WQg0K+19o+g ch59pOw13mCF3Fl3LCtz =8FQi -----END PGP SIGNATURE-----

4 4

Re: [PATCH] advapi32: succeed for null pointer in ChangeServiceConfig2
by Nikolay Sivov March 25, 2015

March 25, 2015

On 19.03.2015 15:06, Bernhard Übelacker wrote: > Hello, > attached patch avoids an issue when trying to run Flatout 2 with copy > protection. > > When starting Flatout2.exe for the first time it wants to install some > services, but shows in wine some error messages. > > The only visible sign in terminal output, that something went wrong, is > this: > err:rpc:I_RpcReceive we got fault packet with status 0x3e6 > > And of course later some dialog showing error 998 (=0x3e6) and a > unhandled exception. > > This is because the SC_RPC_CONFIG_INFOW parameter has in its > descr->lpDescription a null pointer instead of a valid LPWSTR. > > Right now this null pointer would be accessed in > svcctl_ChangeServiceConfig2W and causes an exception there , but is > hidden by the RPC layer. > > (And of course this makes the SF4 protection still not working.) > > Kind regards, > Bernhard > Is it actually called with infolevel 1?

3 9

Re: msvcrt: Fix _copysign bugs for NAN/INF(try 2)
by Henri Verbeet March 25, 2015

March 25, 2015

On 25 March 2015 at 12:51, Zheng Chen <chanchengcc(a)gmail.com> wrote: > The last patch was damaged by my email client. > I would recommend everyone that doesn't already use it to spend a couple of minutes to learn git send-email. It avoids a lot of issues, and in general just saves everyone (not just reviewers) a lot of time.

2 1

Re: msvcrt: Use NAN and INFINITY definitions from port.h in printf tests
by Marvin March 25, 2015

March 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12406 Your paranoid android. === w2000pro (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wxppro (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2003std (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wvistau64 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2008s64 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w7u (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w8 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wvistau64 (64 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2008s64 (64 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R"

1 0

Re: msvcrt: Fix _copysign bugs for NAN/INF
by Piotr Caban March 25, 2015

March 25, 2015

Hi, On 03/24/15 11:10, Zheng Chen wrote: > --- > dlls/msvcrt/math.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) looks like your email client has destroyed the patch (line wraps). You can solve it by e.g. attaching the patch to email. Thanks, Piotr

2 1

winevdm DOS memory range mmap() shenanigans...
by Andreas Mohr March 25, 2015

March 25, 2015

Hi all, for fun I just tried to run a Lemmings demo downloaded from http://www.pcgaming.ws/download.php?game=lemmings Picture my not overly amused face when I then got the message " winevdm: Cannot start DOS application C:\lemmings\VGALEMMI.EXE because the DOS memory range is unavailable. You should install DOSBox. ". After some wild fprintf trickery in various winevdm / virtual.c / mmap.c parts and subsequent mmap() Internet research it turned out that this message is annoyingly imprecise: a simple echo 0 > /proc/sys/vm/vmmap_min_addr (original value here: 65536) will allow the corresponding mapping, thereby enabling the game to (partially - then seems to have interesting issues at some VGA register parts) launch. I would therefore strongly suggest adding per-platform hint strings in failure case (either passed directly out of the inner reserve_dos_area() helper, or perhaps near the winevdm message). In the Linux case, this message would obviously be something like: ...range is unavailable (you might need to specially tweak /proc/sys/vm/vmmap_min_addr - note that this is a risky operation...). Since this is an important tweak (otherwise tons of DOS applications will bail out, thus rather negatively affecting Wine implementation debugging/reliability progress since nobody will make it there), it would be useful to add such hinting one way or another (I might find the time to do so, and possibly given some additional counseling I might even be able to come up with a sufficiently perfect patch). Thanks, Andreas Mohr

3 2

Re: comctl32/tests: Listview doesn't subclass its header
by Marvin March 25, 2015

March 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12399 Your paranoid android. === w7u (32 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Regarding GSOC 2015 : Winetest Graphical User Interface
by Sushant makode March 24, 2015

March 24, 2015

Hello, I am a graduate student at IIIT Hyderabad India and I am interested in this project idea. ( Winetest Graphical User Interface ) I have been reading the documentation.My understanding is to add a form to existing winetest.exe which will have a table with available tests, results. These results will be read from the data which is read by the web interface possibly on the fly. I think we can run specific tests as follows e.g. cd dlls/advapi32/tests make test make services.ok Then after executing the test cases, an option to rerun the test can also be provided alongside the result of the test case. A consolidated result would be put on the same form in winetest. I am working on my GSOC proposal meanwhile It would be helpful if someone can you give some documentation regarding the winetest.exe and how to make changes to it. Thanks in advance. -- Thanks And Regards, Sushantkumar M. Tech. CSE IIIT Hyderabad

1 0

My ideas for GSoC 2015
by HuddenSin Yuan March 24, 2015

March 24, 2015

Hello, everyone. I’m Yuan Chen, a college student from China. I will have plenty of time to join GSoC 2015 and I have send two patches about mshtml.dll before and now I study gdi32 module and the Computer Graphics. Here is my idea for GSoC 2015. Improve the basic drawing functions and add GM_ADVANCED mode support ===================================== I found several bugs which show many basic curve and fonts drawing functions don’t support the GM_ADVANCED mode[1][2][3]. And the curve will become odd under this mode. I have written a test case to show these problems[9]. 1.add GM_ADVANCED mode support When I find that wine use polygon to fit the rect in GM_ADVANCED mode(polygon function is not good enough according to [4]). So I think we can use bezier spline or B spline to fit the curve like ellipse or arc in GM_ADVANCED mode[5][6]. There is also a paper about fonts capturing[7]. So the driver functions of curve and fonts like draw_arc, draw_glyph will be improved and added the GM_ADVANCED support. 2.improve the basic drawing functions In order to fix those above, we need to improve and add some basic helper functions in dlls/gdi32/dibdrv/graphics.c. get_arc_points will be improved and some helper functions will be added which help to calculate the coordinate of points of the curves in GM_ADVANCED mode.This part will take about three weeks. The bezier function need to be improved to n points instead of 3n+1 points according to Bresenham’s Algorithm[8]. This function will take less than one week. And I also try to improve the ellipse_first_quadrant functions using the Bresenham’s Algorithm.[10] Perhaps my idea is not mature enough, I will be appreciate it very much if anyone give me some advice! Thanks! [1]https://bugs.winehq.org/show_bug.cgi?id=33190 [2]https://bugs.winehq.org/show_bug.cgi?id=35333 [3]https://bugs.winehq.org/show_bug.cgi?id=35169 [4]https://bugs.winehq.org/show_bug.cgi?id=36891 [5]http://sarahfrisken.com/efficientCurveFitting.pdf [6]http://www.dtic.mil/dtic/tr/fulltext/u2/a350611.pdf [7]http://www.cs.uml.edu/~wanthony/91.427_f2008/cglr1/reference.pdf [8]http://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm [9]see the attachment “testforadvanced.txt" [10]see the attachment "0001-gdi32-Improve-the-algorithm-of-ellipse_first_quadrant.txt" ---------------------------------------- Best Regards , Yuan Chen

1 0

Re: Google Summer of Code 2015
by Matteo Bruni March 24, 2015

March 24, 2015

2015-03-24 11:38 GMT+01:00 Лёша Долгавин <dolgavin.alexey(a)gmail.com>: > Hello Matteo, > Hi Alexey, > I'm the last year student of Moscow institute. > I found you as possible mentors in project ideas. And I want to implement > missing APIs in D3DX (math and/or mesh functions). Cool! > So, I have a question: do I need to do some task or you will choose students > for this project from their proposal? Yes, you will have to write a proposal in Melange (i.e. the GSoC website) and have submitted at least one patch to wine-patches to be considered for acceptance. I suggest you to download Wine's source code, build it and give a look at the D3DX code (both the implementation of the existing functions and the tests, that's in dlls/d3dx9_36/ and the tests/ subdirectory within). Then it might be a good idea to try to run some game using d3dx on Wine, you can e.g. search bugs.winehq.org to find some. You can then try to implement one of the missing functions and see how it's like. Eventually you'll have to choose a set of the missing APIs you want to work on during your GSoC and write a suitable proposal. You'll get feedback on it and you'll be able to update it so don't worry on getting it exactly right on the first try. If you have further questions don't hesitate to ask. It's much better if you also include wine-devel(a)winehq.org in cc the next times, others might be able to reply faster / better than me. There is also the #winehackers IRC channel on freenode available. > I have strong knowledge in math and have experience in commercial software > developing. That's good. Make sure to write that in your proposal :)

1 0

Re: [PATCH] findstr: Added test for findstr.
by Stefan Dösinger March 24, 2015

March 24, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks for your patch! I have a few comments: Am 2015-03-23 um 04:14 schrieb Kaipeng Zeng: > index 5f5e9d5..f3056c7 100755 > --- a/configure > +++ b/configure You don't have to include the change to configure in your patch, Alexandre will update it himself. > diff --git a/configure.ac b/configure.ac > index d23227a..822affe 100644 > ... > WINE_CONFIG_PROGRAM(findstr,,[install]) > +WINE_CONFIG_TEST(programs/findstr/tests) > WINE_CONFIG_PROGRAM(hh,,[install]) I don't think we have any precedent for having tests without having at least a stub implementation. Personally I don't see anything wrong with having just a test for now. Can you make sure that the test is properly built and included in winetest.exe? Do you intend to implement the program itself? > +static DWORD runcmd(const char* cmd, char *output) > ... > + CloseHandle(hRead); > + return TRUE; > +} I think it would be a good idea to return the return value of findstr here instead of always returning true when CreateProcess succeeds. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVD/UWAAoJEN0/YqbEcdMwh8EP/37ev7ZrJHzmNy5AJfbuzY/s 3wxUIKIo5hwrjJeiwpdFCWAtDQGMo3Hz8weLLyAaCpT4OVrzz/DvbWFLxX3zCl2Z 9EhetkZkyfiPBUF1T+s/WdTse51J9qeP8mFI7NgQdwuwUOXyp2Ba7Kq8DVBM6sNW MtWsKdItE298jTzL21oQ59w9ar6YrFwRTcVcvLQ3JPmLKSfJ5MR2qT1SxIO6nVC9 Omqc89R9Ba3jSFv+5c3l0Zn6zgnf/U5YBPmsOMYb9DWLNvD0ZgiBh5NZkLxYcV16 NLHQWxJy3mO11RNyjSn1Ank26rR1MiM4kVT7tK3WvneM1IZW7Z/RugGaymtTgfBq vIIMKidz2hPrIwmuy4AYSEb9ScJIT+b2DCbwgJEWgmxTPl3mymW5ltXLx8yzcmhV y7GNYGVKuaH6CZeyHLimeLGA845qCzXW15vWxaB6PGw+lVlqpq4mWJnWcB2NOsC+ Auw4vubTf8KTs2UHyQily9AaahthU5IkZA6sPBDpTlZCNlGpRXa+gW88WpKjd5wV 5y9otOU49Fhp704uZAiVcX9ag5cTFaseu0AsTN/TKmYToA50bzAmJr+2/+nJEQIf lcahIWPeyYw1u7rF3cOEZfkN7FIx/ab1gv1hETLvyoKz/nnYb9NPztnnK3HDFNRP XJl+R82YChN/YV946HfO =6sQQ -----END PGP SIGNATURE-----

3 6

Re: msvcrt: fix _copysign(1., -0.) error
by Piotr Caban March 24, 2015

March 24, 2015

On 03/22/15 14:51, Kevin Chan wrote: > float CDECL MSVCRT__copysignf( float num, float sign ) > { > - /* FIXME: Behaviour for Nan/Inf? */ > - if (sign < 0.0) > - return num < 0.0 ? num : -num; > - return num < 0.0 ? -num : num; > + /* FIXME: Behaviour for signbit(NAN) is different in Linux and > + * Windows, where Windows gives a zero for -NAN > + */ > + if (signbit(sign)) > + return signbit(num) ? num : -num; > + return signbit(num) ? -num : num; It doesn't make sense to add this comment and remove it in next patch. I would also prefer if signbit fallback implementation is changed in this patch. +/* FIXME: Doesnot work with +-NAN and -0. */ There's a typo in this comment. Also it works for NAN with sign bit set to 0. +#define signbit(x) ((x) < 0 ? 1 : 0) This can be simplified to: #define signbit(x) ((x)<0)

2 1

Re: msvcrt: Add errno EDOM setting for atan(NAN)/exp(NAN)/tanh(NAN)
by Piotr Caban March 24, 2015

March 24, 2015

Hi, On 24/03/15 09:01, Zheng Chen wrote: > --- > dlls/msvcrt/math.c | 3 +++ > 1 file changed, 3 insertions(+) The patch needs to be generated on top of clean wine. This will not apply without applying all your earlier patches. Please send a patch that contains all the changes to atan, exp and tanh functions. Thanks, Piotr

2 1

Re: msvcrt: remove errno EDOM from atan, exp and tanh
by Piotr Caban March 24, 2015

March 24, 2015

Hi, On 03/22/15 14:50, Kevin Chan wrote: > double CDECL MSVCRT_atan( double x ) > { > - if (!isfinite(x)) *MSVCRT__errno() = MSVCRT_EDOM; > return atan(x); > } I've done a little more testing. The function is not setting errno in INF and -INF case. It does set errno to EDOM when argument is NAN. Thanks, Piotr

2 1

Re: [PATCH] comctl32: Use correct font for themed headers. (try 4)
by Nikolay Sivov March 24, 2015

March 24, 2015

Looks good, thanks.

1 0

submitting report
by Shubham kumar March 24, 2015

March 24, 2015

I ran winetest.exe on my pc and it generated a output file resDD89.tmp. How can i view this report? On which website i have to upload this file to generate the log? Thank you

2 1

Re: [PATCH] comctl32: Use correct font for themed headers. (try 3)
by Nikolay Sivov March 23, 2015

March 23, 2015

On 03/23/2015 10:44 PM, Mark Harmstone wrote: Hey, looks much better, thanks. One minor thing left, and I'm sorry that I missed it last time: > + if (theme) { > + DrawThemeText(theme, hdc, HP_HEADERITEM, state, phdi->pszText, > + lstrlenW(phdi->pszText), DT_LEFT|DT_END_ELLIPSIS|DT_VCENTER|DT_SINGLELINE, > + 0, &r); > + } else { > + Will it work as docs claim if you simply pass -1 as a text length? Otherwise looks good to me.

1 0

Re: [PATCH 1/5] wined3d: Only set TEXTURE_COMPARE_FUNC when ARB_depth_texture is supported.
by Henri Verbeet March 23, 2015

March 23, 2015

On 23 March 2015 at 18:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - if (desc->compare) > - GL_EXTCALL(glSamplerParameteri(sampler->name, GL_TEXTURE_COMPARE_MODE, GL_COMPARE_R_TO_TEXTURE)); > - GL_EXTCALL(glSamplerParameteri(sampler->name, GL_TEXTURE_COMPARE_FUNC, > - wined3d_gl_compare_func(desc->comparison_func))); > + if (gl_info->supported[ARB_DEPTH_TEXTURE]) > + { > + if (desc->compare) > + GL_EXTCALL(glSamplerParameteri(sampler->name, GL_TEXTURE_COMPARE_MODE, GL_COMPARE_R_TO_TEXTURE)); > + GL_EXTCALL(glSamplerParameteri(sampler->name, GL_TEXTURE_COMPARE_FUNC, > + wined3d_gl_compare_func(desc->comparison_func))); > + } Does the driver generate GL errors without this? The way I read the ARB_sampler_objects spec that would a driver bug. (Specifically, it states that TEXTURE_COMPARE_MODE/TEXTURE_COMPARE_FUNC are accepted by SamplerParameter(), without qualifying that with a dependency on ARB_depth_texture. I guess a driver that doesn't support depth textures can essentially just ignore the texture compare mode/function, since it would never encounter a texture it would apply to.)

2 1

Re: d3dx9_36: Align texture dimensions to block size for compressed textures in D3DXCheckTextureRequirements.
by Stefan Dösinger March 23, 2015

March 23, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/23/15 15:50, Sebastian Lackner wrote: > + format = D3DFMT_DXT5; > + width = 5; height = 5; > ... > + ok(mipmaps == 1, "Returned mipmaps %d, expected %d\n", mipmaps, 1); I'm curious, why does it report 1 mipmap level? Maybe because width / 2 is smaller than the block size, even though the block-size aligned width would allow a second level. What does d3dx9 return when you have width = height = 10 for example? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVEDcbAAoJEN0/YqbEcdMwVyAQAIusV1Z29v1LQQGKJtBdZk9C g+KRkCEcHalFEjwSHL4689U+GtQVigN1OSIJAtsSvrHBpslwtwsA+q7Crgamuk2X zQ+sxYOHE3QIoD2yy/uQElKxfLZWzBQjeUjZGMdYPLv4Bc2NRp4tMexPMKsHVeDx WubraUfiG40uWwcuFTfODuwuybZjWBUk89PIy865PS++/24wO12WB5vP+dK4XEB4 Mrv4Vzv+8f2zVO+tIWtXgr439f4skF4o5peOwe8qN7KxNSkqKduIWf/5dLfgZhgt lqUrziNNcWaVy5poM/cVeo7P4KKMJLjlT9ehItGee1S7gUUiatyGAKyttN5zauiV SRqJSq8sKWSGCDb/779aTonPVkLnHZVWHblJAihrCBuyE3tZVJpgg9xE3rWMyM8d IstQxbGEgDgQmrXxkeox6M3FnkBp3NL8ALzL5NHHoUxPJMg1yz5cGWuiqdBGYPM1 LmqynuRlXERLBMen/Rn69f/KFdGgqitPhzPupZ3nIGAi1Cku4Vjwd92nUS9ruZS9 uTT0t+wAjCvfKMBCfj0nnmQ4y7W9bmCxDVZs/Md83Ed4G49crTo7XTtrZnWDH4GU gFoGbn+BjcU7uankhoC5tq+XatHr6oRkWIrO5jJg2Oyk9Wns5cyanuvfGdwYrQT8 T+IYcghTfBRrDRNKHrqg =YJRY -----END PGP SIGNATURE-----

2 1

Re: d3dx9_36: Align texture dimensions to block size for compressed textures in D3DXCheckTextureRequirements.
by Henri Verbeet March 23, 2015

March 23, 2015

On 23 March 2015 at 15:50, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > + if (w % fmt->block_width) > + w += fmt->block_width - w % fmt->block_width; > + if (h % fmt->block_height) > + h += fmt->block_height - h % fmt->block_height; Could you please just use the conventional way to align something?

1 0

Counting bits set in a 32 bit value
by Bruno Jesus March 23, 2015

March 23, 2015

Hi all, after some manual testing I noticed that the joystick structure member dwButtonNumber is not the last button pressed but instead the count of pressed buttons. There is a bit field of buttons set in the structure member dwButton, to fix the number in dwButtonNumber I guess the easiest way is to count the bits set. I think that keeping a counter with ++/-- operations could lead to out of sync situations if the joystick is not polled fast enough. Is there any precedent need for this in wine? Is there an accepted solution for it? Internet searching shows different ways like bit counting with shift, using cpu instructions or internal compiler functions. Best wishes, Bruno

2 1

Re: dsound: Fix angle to sound source calculation.
by Andrew Eikum March 23, 2015

March 23, 2015

This seems sane to me, but I never had a good grasp on this to begin with. Does it look OK to you, Mark? Andrew On Sun, Mar 22, 2015 at 08:59:15PM +0300, Стас Цымбалов wrote: > This patch fixes incorrect sound positioning in dsound. > As of now, angle to sound source is calculated as angle between > vDistance and vOrientFront. > This leads to incorrect results for all sources that are not in the > same plane as speakers. > In extreme case: for sources directly above or below origin, angle is > calculated to -90 degrees, and they are played in the left speaker. > > This patch changes angle calculation: angle to sound source is > calculated as angle between vDistance and plane given by vectors > vOrientFront and vOrientTop. > --- > dlls/dsound/sound3d.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) > From 1ebe3761b0d6acfca58cec17472336a05b7f2679 Mon Sep 17 00:00:00 2001 > From: Stas Cymbalov <dummyunit(a)gmail.com> > Date: Sun, 22 Mar 2015 18:22:49 +0300 > Subject: dsound: Fix angle to sound source calculation. > > --- > dlls/dsound/sound3d.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/dlls/dsound/sound3d.c b/dlls/dsound/sound3d.c > index 9a0226a..ffd4d45 100644 > --- a/dlls/dsound/sound3d.c > +++ b/dlls/dsound/sound3d.c > @@ -112,7 +112,6 @@ static inline D3DVALUE AngleBetweenVectorsRad (const D3DVECTOR *a, const D3DVECT > > cos = product/(la*lb); > angle = acos(cos); > - if (cos < 0.0f) { angle -= M_PI; } > TRACE("angle between (%f,%f,%f) and (%f,%f,%f) = %f radians (%f degrees)\n", a->x, a->y, a->z, b->x, > b->y, b->z, angle, RadToDeg(angle)); > return angle; > @@ -264,16 +263,20 @@ void DSOUND_Calc3DBuffer(IDirectSoundBufferImpl *dsb) > else > { > vLeft = VectorProduct(&dsb->device->ds3dl.vOrientFront, &dsb->device->ds3dl.vOrientTop); > - flAngle = AngleBetweenVectorsRad(&dsb->device->ds3dl.vOrientFront, &vDistance); > - flAngle2 = AngleBetweenVectorsRad(&vLeft, &vDistance); > - > - /* AngleBetweenVectorsRad performs a dot product, which gives us the cosine of the angle > - * between two vectors. Unfortunately, because cos(theta) = cos(-theta), we've no idea from > - * this whether the sound is to our left or to our right. We have to perform another dot > - * product, with a vector at right angles to the initial one, to get the correct angle. > - * The angle should be between -180 degrees and 180 degrees. */ > - if (flAngle < 0.0f) { flAngle += M_PI; } > - if (flAngle2 > 0.0f) { flAngle = -flAngle; } > + /* To calculate angle to sound source we need to: > + * 1) Get angle between vDistance and a plane on which angle to sound source should be 0. > + * Such a plane is given by vectors vOrientFront and vOrientTop, and angle between vector > + * and a plane equals to M_PI_2 - angle between vector and normal to this plane (vLeft in this case). > + * 2) Determine if the source is behind or in front of us by calculating angle between vDistance > + * and vOrientFront. > + */ > + flAngle = AngleBetweenVectorsRad(&vLeft, &vDistance); > + flAngle2 = AngleBetweenVectorsRad(&dsb->device->ds3dl.vOrientFront, &vDistance); > + if (flAngle2 > M_PI_2) > + flAngle = -flAngle; > + flAngle -= M_PI_2; > + if (flAngle < -M_PI) > + flAngle += 2*M_PI; > } > TRACE("panning: Angle = %f rad, lPan = %d\n", flAngle, dsb->volpan.lPan); > > -- > 2.0.5 > >

1 0

Re: [PATCH 4/4] ddraw/tests: Port test_color_fill to earlier versions.
by Henri Verbeet March 23, 2015

March 23, 2015

On 20 March 2015 at 12:47, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (tests[i].caps & DDSCAPS_ZBUFFER) > + { > + surface_desc.dwFlags &= ~DDSD_PIXELFORMAT; > + surface_desc.dwFlags |= DDSD_ZBUFFERBITDEPTH; > + U2(surface_desc).dwZBufferBitDepth = get_device_z_depth(device); > + } > + > + hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &surface, NULL); > + ok(SUCCEEDED(hr), "Failed to create surface, hr %#x, surface %s.\n", hr, tests[i].name); > + This crashes for me: ddraw2.c:7654: Test failed: Failed to create surface, hr 0x88760091, surface sysmem zbuffer. ddraw2.c:7654: this is the last test seen before the exception ddraw2: unhandled exception c0000005 at 00437C9D And similarly for ddraw1: ddraw1.c:6636: Test failed: Failed to create surface, hr 0x88760091, surface sysmem zbuffer. ddraw1.c:6636: this is the last test seen before the exception ddraw1: unhandled exception c0000005 at 004167BD

1 0

Re: [PATCH 5/5] wined3d: Don't use the builtin FFP uniforms for texture transformation matrices.
by Henri Verbeet March 23, 2015

March 23, 2015

On 20 March 2015 at 13:50, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + get_texture_matrix(context, state, tex, &mat); > + GL_EXTCALL(glUniformMatrix4fv(prog->vs.texture_matrix_location[tex], 1, FALSE, (GLfloat *)&mat)); Like 110106. > + for (i = 0; i < MAX_TEXTURES; ++i) > + { > + char name[22]; > + > + sprintf(name, "ffp_texture_matrix[%u]", i); I'd feel slightly happier if this kind of thing used snprintf(), but I also think it's about time we start using something along the lines of shader_addline() for these.

1 0

Re: [PATCH 3/5] wined3d: Don't use the builtin FFP uniform for the projection matrix.
by Henri Verbeet March 23, 2015

March 23, 2015

On 20 March 2015 at 13:50, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (update_mask & WINED3D_SHADER_CONST_FFP_PROJ) > + { > + struct wined3d_matrix projection; > + > + get_projection_matrix(context, state, &projection); > + GL_EXTCALL(glUniformMatrix4fv(prog->vs.projection_matrix_location, 1, FALSE, (GLfloat *)&projection)); I'd prefer that as "&projection._11", avoiding the cast.

1 0

Re: user32: Fix padding in user_thread_info structure.
by Alexandre Julliard March 23, 2015

March 23, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Based on the comment above only TEB->Win32ClientInfo should be used to store the struct user_thread_info. > The padding got out of sync in cb3b7237925a24ba4c5696dd079fdc5d99a48577 where the 64-bit situation was ignored. > The pshpack4 is required because the struct has a size of 31 ULONGs, and gcc will otherwise align the whole > struct up to 8 bytes on 64-bit. I've confirmed manually with C_ASSERTs that the offsets/sizes are right and > that it matches what we expect. I don't see any need to change the packing, there's still enough room. I'd suggest to simply replace the padding with an assert on the structure size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] comctl32: Use correct font for themed headers. (try 2)
by Nikolay Sivov March 23, 2015

March 23, 2015

On 23.03.2015 10:51, Mark Harmstone wrote: Hi, Mark. Thanks for looking into this. > + > + if (theme) { > + LOGFONTW lf; > + HRESULT hr = GetThemeFont(theme, hdc, HP_HEADERITEM, state, TMT_FONT, &lf); > + if (SUCCEEDED(hr)) { > + font = CreateFontIndirectW(&lf); > + if (!font) > + TRACE("Failed to create font\n"); > + else { > + TRACE("font = %s\n", debugstr_w(lf.lfFaceName)); > + oldfont = SelectObject(hdc, font); > + created_font = TRUE; > + } > + } else { > + font = (HFONT)SendMessageW(infoPtr->hwndSelf, WM_GETFONT, 0, 0); > + oldfont = SelectObject(hdc, font); > + } > + } > + > DrawTextW (hdc, phdi->pszText, -1, > &textRect, DT_LEFT|DT_VCENTER|DT_SINGLELINE|DT_CALCRECT); > cw = textRect.right - textRect.left + 2 * infoPtr->iMargin; > + > + if (font) SelectObject(hdc, oldfont); > + if (created_font) DeleteObject(font); This seems to essentially duplicate GetThemeTextExtent(). Any reason why you can't use it instead?

1 0

Adding HID joystick support to FreeBSD
by Bruno Jesus March 23, 2015

March 23, 2015

Hi, all. In order to add HID joystick support to FreeBSD I need to do some changes I never did before so I could use some help. I tried to understand the changes made by Ken in order to add the winmm OSX driver but I don't get it =) In simple words I need to ensure that usbhid.h and dev/usb/usbhid.h exist and only if they exist compile the winejoystick driver. I believe it's a change in configure.ac but I tried adding these .h files to the long list of other .h files and it didn't work. Also I guess a similar change is needed like Ken did to enable the driver building: -test "$ac_cv_header_linux_joystick_h" = "yes" || enable_winejoystick_drv=${enable_winejoystick_drv:-no} +test "$ac_cv_header_linux_joystick_h" = "yes" -o "$ac_cv_header_IOKit_hid_IOHIDLib_h" = "yes" || enable_winejoystick_drv=${enable_winejoystick_drv:-no} Can anyone help? Best wishes and thanks in advance, Bruno

6 7

Re: comctl32/listview: Update view on style change only if LVS_TYPEMASK styles have changed
by Marvin March 23, 2015

March 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12359 Your paranoid android. === w7u (32 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

WIP: FreeBSD 10 usbhid joystick support
by Bruno Jesus March 23, 2015

March 23, 2015

For those wondering (probably a few, lol) this is the WIP patch that is actually working for the standard HID gamepad I have. I also tried testing in a PS2 controller attached in a USB converter but FreeBSD does not recognize it. The configure part is still missing and it required "-lusbhid" to compile and I didn't find the correct place to add that so I'm currently compiling manually. I labeled it as FreeBSD 10 only because it was the only one I tried, probably may require changes to support other BSD systems. This task is proving to be harder than I expected due to my lack of knowledge in the area and any help testing is appreciated specially with different gamepads/joysticks (for example a joystick with a HAT). The problem with configure.ac is that both usbhid.h and dev/usb/usbhid.h must be included and that would require a compound "-o" switch to ensure that both must be present in order to make the driver. The last problem is where to put that -lusbhid is required when compiling the file. And of course testing in the configure script if usbhid lib is present. Best regards, Bruno

1 0

Re: [PATCH 3/3] scrrun: Support BYREF types for integer keys
by Marvin March 22, 2015

March 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12362 Your paranoid android. === wvistau64 (64 bit dictionary) === dictionary.c:542: Test failed: got hash 0x000001f4 === w2008s64 (64 bit dictionary) === dictionary.c:542: Test failed: got hash 0x000001f4

1 0

Re: [PATCH 2/3] scrrun: Added support for VT_DATE keys, and BYREF float key types
by Marvin March 22, 2015

March 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12361 Your paranoid android. === wvistau64 (64 bit dictionary) === dictionary.c:508: Test failed: got hash 0x000001f4 === w2008s64 (64 bit dictionary) === dictionary.c:508: Test failed: got hash 0x000001f4

1 0

Re: msvcrt: Fix bugs in math.c
by Piotr Caban March 22, 2015

March 22, 2015

Hi, On 03/22/15 12:28, 陈正 wrote: > - Fixed the problem of atan(INF)/tanh(INF)/exp(INF) causing errno EDOM > - Fixed the error of _copysign(1., -0.) returning 1 Please don't send unrelated changes in one patch, please split it into 2 patches. The changes that remove errno setting from atan, tanh and exp looks good for me. > float CDECL MSVCRT__copysignf( float num, float sign ) > { > - /* FIXME: Behaviour for Nan/Inf? */ > - if (sign < 0.0) > - return num < 0.0 ? num : -num; > - return num < 0.0 ? -num : num; > + /* FIXME: Behaviour for signbit(NAN) is different in Linux and > + * Windows, where Windows gives a zero for -NAN > + */ > + if (signbit(sign)) > + return signbit(num) ? num : -num; > + return signbit(num) ? -num : num; > } Why don't you add an isnan() check? Is there any reason for returning "signbit(num) ? -num : num" instead of returning num? It would be nice to also change signbit definition on systems that doesn't support it, so it at least works for normal numbers. Thanks, Piotr

3 6