March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] riched20: Implement IOleWindow::GetWindow.
by Nikolay Sivov March 16, 2015

March 16, 2015

On 16.03.2015 10:36, Jactry Zeng wrote: > static HRESULT WINAPI IOleWindow_fnGetWindow(IOleWindow *iface, HWND *phwnd) > { > IOleClientSiteImpl *This = impl_from_IOleWindow(iface); > - FIXME("not implemented: (%p)->(%p)\n", This, phwnd); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, phwnd); > + *phwnd = This->reOle->editor->hWnd; > + return S_OK; > } Could you add a test for NULL argument too?

1 0

GSoC WINE -Deep Learning with Caffe & OpenCV Proposal
by Yida Wang March 16, 2015

March 16, 2015

Posted by Yida Wang Passion with OpenCV and other Open Source Communities Hello, I am Yida Wang, a first year Master Student in Pattern Recognition of PRIS Lab in SICE school of BUPT. I have wonderful experience with OpenCV and several other open source communities. I have won the 1st prize in Scilab Open Source Contest 2014 and Excellent Developer in CSDN Summer of Code 2014 in BladeRF commmunity. All certificate could be provided if it is necessary. As for WINE project, I have developed a PCANet structure to automatically match opencv source figures with Microsoft figures sot that the editor in linux platform could match the correct figure copied from Microsoft Office. This time I think it is convenient to use Caffe and OpenCV for deep learning and other CV issues for some pattern recognition applications. I have also own an Nvidia K40 GPU donated by Nvidia for research, I think I can extend the package for GPU calculation! Motivation for Proposal Framework in Computer Vision- Deep Learning Project I’m Concentrating on Deep Learning coding with OpenCV and other open source project like Caffe and cuDNN for a period of time. My project contains two meaningful contents, the 1st one is a BP algorithm eliminated CNN structure which is far less time consuming than traditional CNN and the 2nd one is an entire Deep Leaning structure on image recognition based on Caffe. New Idea for a Fast CNN My idea is based on the thriving pattern recognition method called ’Deep Neural Networks ’ which has been used by Google to build the amazing recognition structure last year. As Deep Neural Network behaves amazingly in pattern recognition, there are already useful tools such as Caffe being implemented for research. Some of the useful codes could be modified and embedded in OpenCV for the development of DNN. But at the same time, the problem lies in the dependence on hardware such as powerful GPU which is not easy to be got by ordinary people. The time consuming process is mainly caused by 2 points: the Randomness of the convolutional kernel and the countless back propagation step. I have been studying on a powerful single direction fast CNN called PCANet for research and commercial use. Here are some benefit in such structure: 1. Such structure hasn’t the BP algorithm used in DNN which cost much operation. 2. It has some tiny PCA filters instead. The filters’ shape is just like the shape in the training results of normal CNN. 3. My structure could be used in initiating the CNN in the future to optimize the training time in CNN. 4. Combination of Caffe and PCANet in WINE The ‘blob’ structure defined in Caffe is clear for the layer based CNN and the input data of convolution kernel and bias in one layer could be replaced by the PCANet filter for initialization. So the modified structure combined with Caffe and PCANet could be powerful both in speed of convergence and recognition stability with the help of OpenCV. So my idea consists 2 stage: PCANet implementation and Caffe modifying for OpenCV. The 1st direction called Fast-CNN(CellNet) My 1st idea is an implementation of PCANet which has different structure of local filters learning from different databases while holding the stability and generality of general CNN at the same time. Here is the General model of PCANet: I have been using this algorithm in one of the most difficult face database called ‘LFW’ and achieves 92% recognition rate with just this algorithm alone. My friend Qian Hong, has guild me to help him solve the general figure recognition problem recently to reduce the human labor cost in selecting the most likely figure in open source figure database to the Microsoft official figure. I use PCANet for such problem with particular parameters and got the result partly shown below: Target database Open source database The matching result shows the accuracy of PCANet, they are all extract from raw database, and there are many shape alike matches. My algorithm just could select the best substitute. Now I have modified the structure for general visual object classification problems and join the Detection-Feature extraction-Classification process together into an entire extension neural network both for my study and the project itself. By attempting to modify my previous Matlab codes about CellNet into C++ codes with the help of OpenCV(especially in Matrix operations), I could get some raw features extracted from a photo through the network these days. The performance is still as excellent as I mentioned last few weeks, but I am concerning about another confusion related to what you have told me. The 2nd direction: Modifying Caffe with OpenCV in WINE In fact besides studying in artificial architecture, I am also research in normal neural networks at the same time, so came the 2nd content I just showed. Deep learning is powerful indeed, it could exceed the human capabilities in the future due to Big Data and fast 2-D computation (including GPU). But the complex back and forth process cost really much even in the future. So I am still searching the better solution between one-way network and two-way network. I noticed that OpenCV has posted that it would be cool if OpenCV could load and run deep networks trained with popular DNN packages like Caffe or Torch. I am glad to hear that because I am also doing some experiment on CNN with Caffe. Than there are some main task to be done in the future: 1. Modify the Caffe’s data structure with OpenCV, especially the ‘blob’ structure defined in Caffe. The layer really appears more clear with the help of ‘blob’, but the basic element could be more flexible with the OpenCV data structure. 2. Some prerequisites should be simplified including BLAS & Boost. We may just need some basic dependencies to form a CNN. 3. Whether including GPU calculating process is under consideration due to the short time. Conclusion Just as described in detail, my idea is composed of a fast DNN which is almost completed and a Caffe based DNN. I attached the paper describing the fast DNN called “PCANet”. The source code is published on Github with the name of CellNet with the URL: https://github.com/Wangyida/CellNet As for the Caffe based DNN, I thought it is much more easy to develop a CPU version rather than a GPU version at first. I am worried about that the time might not be enough to apply OpenCV on Caffe without bugs from now on though there are already some utilizations of OpenCV in Caffe. I wonder if the idea is meaningful enough? Especially the 1st part.

2 1

GSOC-2015 Tools - Implement resource editor and / or dialog editor
by Rukshan Chathuranga March 16, 2015

March 16, 2015

Hi Marcus Meissner and André Hentschel, I'm rukshan chathuranga from university of moratuwa, Sri Lanka. I'm hope to apply to GSOC 2015 with Wine project. For that i hope to work with "Tools - Implement resource editor and / or dialog editor" project. Because i have C/C++/QT/QML programming experience. Also i am seeking more information and requirement about this topic. Can you help me to understand the scope well? Thanks and regards. *Rukshan Chathuranga.* *Department Of Computer Science & Engineering,* *Faculty Of Engineering,* *University Of Moratuwa. **Sri Lanka.* *WEB: http://www.rukspot.com/ <http://rukspot.com/>*

1 0

Re: winemenubuilder - MIME type handling GSoC - bad idea
by Damjan Jovanovic March 16, 2015

March 16, 2015

Hi I welcome this discussion. Of course manually deleting files in ~/.local is not user friendly, and it was never intended to be done that way. I did not write the part of the Wiki entry suggesting that applet :-). If you install a Windows app on Windows, and it creates menus and file associations, you don't get to opt out, and have to use a 3rd party tool to edit or delete those afterwards. If you install a Linux app on Linux, and it creates menus and file associations, you also don't get to opt out, and have to use a 3rd party tool (a Freedesktop menu/association editing tool) to edit or delete those afterwards. Why is Wine so special? What are people actually looking for? For Wine not to create menu/associations when running on a non-"~/.wine" WINEPREFIX? For a way to stop the annoying use of Wine's "Internet Explorer" to open jpeg files? Anything else? BTW you don't need distro binfmt handlers to double-click .exe (and .msi and .lnk) files: Wine's tools/wine.desktop handles those. You only need binfmt handlers to run .exe directly from the command line - when you aren't in a desktop where you can use "xdg-open /path/to/file.exe". I suspect the Ubuntu package installs a binfmt handler because it doesn't know that. Regards Damjan On Sun, Mar 15, 2015 at 5:03 PM, Michael Müller <michael(a)fds-team.de> wrote: > Hi Damjan, > > the idea of the GSOC project is to make the mime type association more > user friendly for ordinary users. Manually deleting files in > ~/.local/share/mime/ (which some users don't even find because it is a > hidden folder) or requiring a 3rd party program is not user friendly. If > Wine creates these associations it should also provide you with a way to > get rid of them. Even the wiki entry mentions that an applet would be > useful to manage these associations. > > There is also no obvious way to disable the integration, there is no > checkbox or something like this in winecfg, you will need to lookup that > winemenubuilder is the component responsible for this and disable it > manually with library overrides. We are talking about users who use wine > by double clicking on an executable (using the binfmt handler installed > by their distro) or by using a menu entry and who wonder why all their > txt files now open with notepad and how to get rid of this. > > There is also no easy and obvious way to create mime types only for a > specific program, i.e. disable the integration but later decide to > enable it only for Word and .doc* files. There might be different > solutions for this problem, but I think you can't deny that there is > something going wrong if you get a bug report with 72 comments and 4 > duplicates. Arguing that providing a way to disable the integration > again would be a new feature and not a bug fix doesn't help us in this > case. If you have better ideas how to make the integration more user > friendly, feel free to share them with us, but your comments didn't > convince me so far that this GSOC idea is bad. > > Maybe Rosanne can share her opinion on this topic, since she has more > contact with users complaining about this "feature". > > Regards, > Michael > > Am 15.03.2015 um 11:02 schrieb Damjan Jovanovic: >> Hi >> >> As the author of most of winemenubuilder, I am disappointed at how >> poorly understood it remains. >> >> The "Winecfg / winemenubuilder - enhance MIME type handling" GSoC idea >> suggests "The idea of this task is to provide a GUI (most probably as >> part of winecfg) to control the creation of such MIME type assignments >> and therefore making Wine more user friendly." >> >> If you read about the design of winemenubuilder's file associations on >> http://wiki.winehq.org/FileTypesIntegration you'll see that >> winemenubuilder logs each file association mapping to the registry on >> creation, and doesn't recreate it if it's already in the registry and >> the .desktop file is gone. This allows you not just to customize and >> delete file associations by editing the registry, but also by editing >> the Freedesktop associations (and menus btw) with Freedesktop tools - >> .desktop files you've deleted in those tools won't be recreated by >> Wine (unless you uninstall and reinstall the Windows app). >> >> I believe people have been spoiled by installing everything through >> their distro package manager, and thus don't know about/use >> Freedesktop menu/association editing tools, so they now expect Wine to >> do something that even Windows doesn't. >> >> If Freedesktop tools don't let you edit file associations, surely >> that's a missing feature in those tools, not a GSoC project in Wine? >> Additionally Windows apps for editing menus and file associations >> (example list at http://forums.techarena.in/tips-tweaks/989159.htm) >> should work under Wine. >> >> Thank you >> Damjan >> >

2 1

Re: [2/2] ws2_32/tests: Check the OOB mark in the right place
by Marvin March 15, 2015

March 15, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12177 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: d3drm: Add tests for querying between IDirect3DRM interfaces
by Marvin March 15, 2015

March 15, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12174 Your paranoid android. === build (build) === Patch failed to apply

1 0

Subtle Denial of Medical Treatment by the Singapore Government for Mr. Teo En Ming (Zhang Enming)
by Teo En Ming (Zhang Enming) March 15, 2015

March 15, 2015

Dear Sir/Madam, Please refer to the following PDF document: http://oss.clusterlabs.org/pipermail/pacemaker/2015-March/023574.html It is a very important letter. Please read the letter very carefully, word by word. The letter details how the Singapore Government led by Prime Minister Lee Hsien Loong has *subtly* denied me medical treatment for ***suspected*** coronary heart disease. Thank you very much. -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) Singapore Citizen

1 0

Testing
by Teo En Ming (Zhang Enming) March 15, 2015

March 15, 2015

Testing -- Yours sincerely, Mr. Teo En Ming (Zhang Enming) Singapore Citizen

1 0

Re: combase: implement WindowsSubstring
by Marvin March 15, 2015

March 15, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12173 Your paranoid android. === w8 (32 bit string) === string.c:258: Test failed: Duplicated string created new string

1 0

Re: [PATCH] vbscript: Implemented GetLocale
by Nikolay Sivov March 15, 2015

March 15, 2015

> +static HRESULT Global_GetLocale(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > +{ > + return return_int(res, GetACP()); > +} This looks completely wrong. Docs say it should return locale id (as name suggests), not a codepage value.

2 1

Re: [PATCH] d3d9/tests: Extend the colorfill test (v2).
by Alexandre Julliard March 15, 2015

March 15, 2015

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This supersedes patch 109855. > > Version 2: Don't check the fill value of D3DFMT_P8. The testbot deviates > from real HW. I could mark it broken, but it doesn't seem worth the > effort because the format is essentially useless. It can only be used > for ColorFill and StretchRect between P8 surfaces. It doesn't work here (GeForce 320M, Nouveau driver): ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:904: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:910: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:916: Test succeeded inside todo block: Got unexpected hr 0x8876086c, fmt=D3DFMT_YUY2. visual.c:904: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_UYVY. visual.c:910: Test failed: Failed to color fill, hr 0x8876086c, fmt=D3DFMT_UYVY. visual.c:916: Test succeeded inside todo block: Got unexpected hr 0x8876086c, fmt=D3DFMT_UYVY. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3drm: Add tests for querying between IDirect3DRM interfaces
by Marvin March 15, 2015

March 15, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12171 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] vbscript: Implemented GetLocale
by Marvin March 15, 2015

March 15, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12170 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

GSoC 2015 project
by TARUN GUPTA March 14, 2015

March 14, 2015

Hi, I am an aspirant of GSoC 2015 and interested in tools project. I have good C knowledge. I am ready to put in my best in these projects. How should i get started?

1 0

Regarding WineHQ development
by Shubham kumar March 14, 2015

March 14, 2015

Sir, I want to start contributing to this project but the thing is i don't know how to start or what are the right tools to achieve the tasks mentioned in winehq bugzilla and I was unable to find a guide that can help me. For instance, What am i supposed to do with bug 10000? It has a picture of some application which uses some language other than english and i was only able to make out that since windows api documentation is wrong and incomplete we should use the link from that application to correct it or something like that.... Please guide me on how to start and what are the development kits that i might need. I have installed wine on my Ubuntu package from "https://www.winehq.org/download/ubuntu" but i think this is meant for users not developers.. Thank you

1 0

Re: ntdll/tests: Remove an unneeded NONAMELESSSTRUCT directive. (try2)
by Marvin March 14, 2015

March 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12159 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:485: Test failed: 42: Wrong exception address 7751ED97/003E0001 === w7u (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 002F0000/002F0001 exception: unhandled exception 80000004 at 002F0000 exception.c:485: Test failed: 42: Wrong exception address 77CDE34F/002F0001 === w8 (32 bit exception) === exception.c:485: Test failed: 42: Wrong exception address 003E0000/003E0001 exception: unhandled exception 80000004 at 003E0000 exception.c:485: Test failed: 42: Wrong exception address 77174D17/003E0001

1 0

Re: ntdll: Remove unneeded NONAMELESSXXX directives.
by Francois Gouget March 14, 2015

March 14, 2015

Ignore this patch, it does not compile... but only in 64bit mode. I'll send an updated one. On Fri, 13 Mar 2015, Francois Gouget wrote: [...] > diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c [...] > -#define NONAMELESSUNION > #define NONAMELESSSTRUCT This is the problem: 64bit code does not compile if NONAMELESSSTRUCT is defined but not NONAMELESSUNION. That's because the 64bit KNONVOLATILE_CONTEXT_POINTERS struct then looks like this: { ... union { ... struct { ... } s; }; // Normally called u. union { ... struct { ... } s; }; // Normally called u2. }; So there is no way to determine whether one is accessing the content of the first struct or the second struct. Unfortunately we are stuck as that's really how it is in the PSDK. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Demander si un ordinateur peut penser revient à demander si un sous-marin peut nager.

1 0

Re: ntdll/tests: Remove unneeded NONAMELESSSXXX directives.
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12157 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 3/3] dwrite: Fix GetClusterMetrics() return value (try2)
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12142 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1109: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1109: Test failed: got 0x80004002

1 0

Re: [PATCH 2/3] dwrite: Store vertical orientation property (resend)
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12141 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1110: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1110: Test failed: got 0x80004002

1 0

Re: [PATCH 3/3] dwrite: Fix GetClusterMetrics() return value
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12139 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1109: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1056: Test failed: got 0x80004002 layout.c:1109: Test failed: got 0x80004002

1 0

Re: [PATCH 2/3] dwrite: Store vertical orientation property
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12138 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w7u (32 bit layout) === layout.c:1110: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 layout.c:1110: Test failed: got 0x80004002

1 0

Re: [PATCH 1/3] dwrite: Store pair kerning range attribute
by Marvin March 13, 2015

March 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12137 Your paranoid android. === wvistau64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 === w2008s64 (32 bit layout) === layout.c:1057: Test failed: got 0x80004002 === wvistau64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002 === w2008s64 (64 bit layout) === layout.c:1057: Test failed: got 0x80004002

1 0

Re: wininet: accept Version in cookies
by Sebastian Lackner March 13, 2015

March 13, 2015

On 13.03.2015 07:26, Daniel Lehman wrote: > > "version=" are 8 chars, why do you compare only the first 7?

2 3

Re: ole32: Fix sanity check timeout.
by Sebastian Lackner March 12, 2015

March 12, 2015

On 12.03.2015 20:56, Vincent Povirk wrote: > I meant for this to check once every 0.5 seconds, not after every lock > attempt that happens at least 0.5 seconds since the loop started. It > shouldn't hurt anything, but I don't think it's worth checking so > frequently. > > > > Isn't this basically identical to http://source.winehq.org/git/wine.git/patch/66e8060204c91d37ee6aef078d779b7… ?

2 1

Re: [PATCH] null.sys: Added stub dll.
by Alexandre Julliard March 12, 2015

March 12, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > First part for https://bugs.winehq.org/show_bug.cgi?id=38107 I don't see why you need a driver for this. -- Alexandre Julliard julliard(a)winehq.org

5 4

My Ideas for GSoC 2015
by Zhenbo Li March 12, 2015

March 12, 2015

Hello, everyone I'm Zhenbo Li, a college student who participated in GSoC 2014 for mshtml.dll. Here are some ideas for GSoC 2015. 1. IDropTargetHelper ================== This interface is to display images [1]. I'm sure that it is necessary for VPT[2], and I guess implementing this interface will contribute to programs like 7zip. Although IDropTargetHelper is a useful interface, I haven't found a proper demo(most demos depend on MFC). So I'm writing a simple demo for this interface[3], with no MFC or .NET code. 2. IXMLHttpRequest ================== XMLHttpRequest is used heavily in AJAX programming.[4] Wine has implemented most of it in msxml component, but it's a stub in mshtml. Most js code doesn't treat wine IE as IE6 or earlier, so they will not choost ActiveX[5] to work around it(like Firebug Lite[6]) 3. sessionStorage =============== IHTMLStorage[7] is used widely, including Firebug Lite[6]. A well-implemented IHTMLStorage interface should support both sessionStorage and localStorage. I tried to write a hack, but found that it may be necessary to adjust wine-gecko code to support that(Thank Jacek). Therefore, implementing sessionStorage can be the first step of implementing localStorage, and it can be an example for WebIDL binding for further development. These are my humble ideas for GSoC 2015, and I'm glad to choose one of them as my proposal, if they meet the criteria for GSoC. Also, it is my honor if my ideas make a positive effect on other GSoC students. Thank you for reading this mail. I'm looking forward to your feedback. [1]: https://msdn.microsoft.com/en-us/library/windows/desktop/bb762028%28v=vs.85… [2]: http://virtualplaytable.com/ [3]: https://gitcafe.com/endle/IDrop_Helper_Example [4]: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest [5]: http://en.wikipedia.org/wiki/XMLHttpRequest#Support_in_Internet_Explorer_ve… [6]: https://getfirebug.com/firebuglite [7]: https://msdn.microsoft.com/en-us/library/cc288313%28v=vs.85%29.aspx

1 1

Re: [PATCH 5/5] ddraw/tests: r200 ignores the alpha channel when matching color keys.
by Marvin March 12, 2015

March 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12108 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:6292: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6296: Test failed: Got unexpected color 0x00000080.

2 1

Re: [PATCH] vbscript: Implemented Asc(try 4)
by Piotr Caban March 12, 2015

March 12, 2015

On 03/04/15 19:59, Shuai Meng wrote: > Change log: > Free 'bstr' only when it comes from to_string(). > --- > dlls/vbscript/global.c | 26 ++++++++++++++++++++++++-- > dlls/vbscript/tests/api.vbs | 42 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 66 insertions(+), 2 deletions(-) This function needs to convert the WCHAR to correct character set. In order to easily write a test for it ChrW needs to be implemented first. The test may e.g. look like this: Asc(ChrW(261)) Your implementation will return 261 in this case, on windows it produces 97. Cheers, Piotr

2 2

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog() (resend)
by Nikolay Sivov March 12, 2015

March 12, 2015

On 11.03.2015 22:46, Pierre Schweitzer wrote: > +BOOL WINAPI SetupLogErrorW(LPCWSTR MessageString, LogSeverity Severity) > +{ > + BOOL ret; > + static const WCHAR null[] = {'(','n','u','l','l',')',0}; > + DWORD written; > + DWORD len; > + > + EnterCriticalSection(&setupapi_cs); > + > + if (setupact == INVALID_HANDLE_VALUE || setuperr == INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + SetLastError(ERROR_FILE_INVALID); > + return FALSE; > + } > + > + if (MessageString == NULL) > + MessageString = null; > + > + len = lstrlenW(MessageString) * sizeof(WCHAR); > + > + ret = WriteFile(setupact, MessageString, len, &written, NULL); > + if (!ret) > + { > + LeaveCriticalSection(&setupapi_cs); > + return ret; > + } > + > + if (Severity >= LogSevMaximum) > + { > + LeaveCriticalSection(&setupapi_cs); > + return FALSE; > + } > + > + if (Severity > LogSevInformation) > + ret = WriteFile(setuperr, MessageString, len, &written, NULL); > + > + LeaveCriticalSection(&setupapi_cs); > + > + return ret; > +} It'd be probably shorter if you had return with unlock call and one place and just jumped there. Also it's questionable if you need to return when first WriteFile() failed without trying to write to error log. I don't remember if I said it last time, but I don't see a reason to add a new file just for couple of functions. > + GetWindowsDirectoryW(win, MAX_PATH); > + lstrcpyW(path, win); > + lstrcatW(path, setupactlog); This never changes, so you can init it once. > + setupact = CreateFileW(path, GENERIC_WRITE, FILE_SHARE_WRITE | FILE_SHARE_READ, > + NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + if (setupact == INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + return FALSE; > + } > + > + SetFilePointer(setupact, 0, NULL, FILE_END); Will FILE_APPEND_DATA work in this case? > + if (setupact != INVALID_HANDLE_VALUE && setuperr != INVALID_HANDLE_VALUE) > + { > + LeaveCriticalSection(&setupapi_cs); > + SetLastError(ERROR_ALREADY_INITIALIZED); > + return TRUE; > + } Setting error here makes sense as tests show. > + SetLastError(ERROR_ALREADY_EXISTS); > + return TRUE; But this one looks redundant. > + ret = SetupLogErrorW((LPCWSTR)L"Test without opening\r\n", LogSevInformation); Don't use L"" please. > + SetLastError(0xdeadbeef); > + ret = SetupLogErrorW(NULL, LogSevInformation); > + error = GetLastError(); > + if (!ret) ok(error == ERROR_INVALID_PARAMETER, "got wrong error: %d\n", error); /* Win Vista + */ > + else ok(ret, "SetupLogError failed\n"); This makes no sense, is it supposed to fail or not? Same for new test file - I think you can add those test in some existing file.

2 3

Re: [PATCH 3/5] d3d9/tests: Relax the fog range test a bit.
by Marvin March 12, 2015

March 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12106 Your paranoid android. === w8 (32 bit visual) === visual.c:926: Test failed: Expected clear value 0xefefefef, got 0x00000000, fmt=D3DFMT_P8.

1 0

Re: [PATCH 2/5] d3d9/tests: Extend the colorfill test.
by Marvin March 12, 2015

March 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12105 Your paranoid android. === w8 (32 bit visual) === visual.c:926: Test failed: Expected clear value 0xefefefef, got 0x00000000, fmt=D3DFMT_P8.

1 0

Re: [PATCH 9/9] gdiplus: Add pixel format test for transparent non-animated gif (try3)
by Dmitry Timoshkov March 12, 2015

March 12, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/tests/image.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Please add the tests similar to the animated case which checks pixel data, also add the tests for the palette to see that it actually has a trasparent color. Otherwise it's hard to see what is going on, and my skills of reading binary gif data becomes rusty with time. -- Dmitry.

3 3

Re: [PATCH 7/7] gdiplus/tests: Add gif frames composition tests
by Dmitry Timoshkov March 12, 2015

March 12, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/tests/image.c | 99 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 97 insertions(+), 2 deletions(-) It would be interesting to test this on the WIC side first. -- Dmitry.

2 1

Re: [PATCH 6/7] gdiplus: Fix animated gif frames composition
by Dmitry Timoshkov March 12, 2015

March 12, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > + hr = IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICBitmapSource, (void**)&bmp_source); > + if(FAILED(hr)) > + return hr; > + hr = IWICBitmapSource_GetSize(bmp_source, width, height); > + IWICBitmapSource_Release(bmp_source); What's wrong with calling appropriate IWICBitmapFrameDecode method directly? -- Dmitry.

2 2

Re: [PATCH 5/7] gdiplus: Convert animated gif to PixelFormat32bppARGB on load
by Dmitry Timoshkov March 12, 2015

March 12, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > + status = decode_frame_wic(decoder, frame_count>1 ? TRUE : FALSE, > + 0, gif_metadata_reader, image); The format probably doesn't depend on a frame count but on a presence of transparent color. -- Dmitry.

2 1

Re: [PATCH 4/7] gdiplus: Don't store stream reference in GpImage, it's done by IWICBitmapDecoder
by Dmitry Timoshkov March 12, 2015

March 12, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > @@ -3808,12 +3816,6 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d > if (image->current_frame == frame) > return Ok; > > - if (!image->stream) > - { > - TRACE("image doesn't have an associated stream\n"); > - return Ok; > - } It doesn't make much sence to add this piece of code in previous patch. -- Dmitry.

2 1

Re: [PATCH 6/7] gdiplus: Fix animated gif frames composition (try2)
by Vincent Povirk March 12, 2015

March 12, 2015

I'm pretty sure you can just cast IWICBitmapFrameDecode to IWICBitmapSource, and you don't need to use QueryInterface.

2 1

Re: [PATCH 1/7] gdiplus: Don't create new instance of IWICBitmapDecoder to encode every frame of animation (try2)
by Vincent Povirk March 12, 2015

March 12, 2015

@@ -4288,7 +4341,8 @@ static const struct image_codec codecs[NUM_CODECS] = { /* SigMask */ emf_sig_mask, }, NULL, - decode_image_olepicture_metafile + decode_image_olepicture_metafile, + select_frame_wic }, { { /* WMF */ @@ -4307,7 +4361,8 @@ static const struct image_codec codecs[NUM_CODECS] = { /* SigMask */ wmf_sig_mask, }, NULL, - decode_image_olepicture_metafile + decode_image_olepicture_metafile, + select_frame_wic }, You have a later patch changing these to NULL, I'm guessing you meant to do that in this one?

2 1

Re: ws2_32/tests: Add more select() tests related to OOB handling
by Marvin March 12, 2015

March 12, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12094 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

CMD - implement more robust parser
by Péter Urbanovics March 11, 2015

March 11, 2015

Hi, I am Peter. I read about this (Google Summer of Code) project "CMD - implement more robust parser" and I am interested. What should I do to prepare for this project? How can I contact with the mentor Jason Edmeades?

2 1

CMD - implement more robust parser
by Abhishek Srivastava March 11, 2015

March 11, 2015

I am Abhishek and I am interested in project titled "CMD - implement more robust parser". I am new to The wine project and trying to fix few available bugs on BugList. Which kind of bugs should I approach first? And how can I contact mentor for project Mr. Jason Edmeades?

2 1

Re: [PATCH 5/7] gdiplus: Convert animated gif to PixelFormat32bppARGB on load
by Marvin March 11, 2015

March 11, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12083 Your paranoid android. === wxppro (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2003std (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === wvistau64 (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2008s64 (32 bit image) === image.c:2463: Test failed: Expected 24, got 12 === wvistau64 (64 bit image) === image.c:2463: Test failed: Expected 24, got 12 === w2008s64 (64 bit image) === image.c:2463: Test failed: Expected 24, got 12

1 0

Re: [PATCH] user32: Merge SCROLL_DrawInterior and SCROLL_DrawInterior_9x.
by Alexandre Julliard March 11, 2015

March 11, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > The scrollbar-drawing code in user32 contains two nearly-identical functions, > SCROLL_DrawInterior and SCROLL_DrawInterior_9x, the latter of which is only > called when drawing a moving thumb. This patch cleans up the code by merging > them into one function. It's not really cleaner with the extra boolean and the reentrant calls to the same function. You probably want to restructure it some more. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcp90: Add istream::operator>>complex implementation and tests.( try 3)
by YongHao Hu March 11, 2015

March 11, 2015

Hi, I have a better idea to write the test case just after sending this patch. Now I'm planing to submit a new patch with current version of implementation and an improved version of test. Please don't commit this version. However, I think the implementation itself is fine now, could you comment on the implementation part? On 2015年03月11日 14:47, YongHao Hu wrote: > Try3: Thanks QianHong > - Superseded Patch 109782, 109684 > - Avoid unnecessary else block. > > Try2: Thanks Piotr > - Delete useless check. > - Make the code more readable. > > --- > dlls/msvcp71/msvcp71.spec | 12 ++-- > dlls/msvcp80/msvcp80.spec | 12 ++-- > dlls/msvcp90/ios.c | 177 > ++++++++++++++++++++++++++++++++++++++++++++++ > dlls/msvcp90/msvcp90.spec | 12 ++-- > dlls/msvcp90/tests/ios.c | 151 +++++++++++++++++++++++++++++++++++++++ > 5 files changed, 346 insertions(+), 18 deletions(-) > >

2 1

Re: msvcp90: Add istream::operator>>complex implementation and tests.
by Piotr Caban March 11, 2015

March 11, 2015

Hi, On 03/07/15 12:13, YongHao Hu wrote: > +/* ??$?5MDU?$char_traits(a)D@std@@@std@@YAAAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AAV10@AAV?$complex(a)M@0@@Z */ > +/* ??$?5MDU?$char_traits(a)D@std@@@std@@YAAEAV?$basic_istream(a)DU?$char_traits(a)D@std@@@0(a)AEAV10@AEAV?$complex(a)M@0@@Z */ > +basic_istream_char* __cdecl basic_istream_char_read_complex_float(basic_istream_char *this, complex_float *v) > +{ > + float r; > + basic_ios_char *base = basic_istream_char_get_basic_ios(this); > + if(ios_base_good(&base->base)) { There's no need to check the stream state here, it will be done by stream reading functions. > + ws_basic_istream_char(this); > + if(basic_istream_char_peek(this) == '(') { > + basic_istream_char_get(this); > + basic_istream_char_read_float(this, &r); > + if(!ios_base_fail(&base->base)) { I think that the implementation will be more readable if you just return on error here. The if(!ios_base_fail(...)) line can be changed to: if(ios_base_fail(&base->base)) return this; You don't need to set failbit in this case because it's already set by basic_istream_char_read_float. The same applies to some other ios_base_fail() checks. Thanks, Piotr

2 1

Re: include: don't redefine _EVENT_TYPE or _TIMER_TYPE (resend)
by Alexandre Julliard March 11, 2015

March 11, 2015

Austin English <austinenglish(a)gmail.com> writes: > Previous try was dropped without comment. I guess I don't see where you are going with that. ntdef.h is supposed to contain a ton of definitions that are already in other headers, are you planning to add a #ifdef around every single one of them? That doesn't seem very workable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] d3d9/tests: Add a test for UpdateTexture.
by Marvin March 10, 2015

March 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12038 Your paranoid android. === w8 (32 bit visual) === visual.c:18055: Test failed: Got unexpected color 0x00000000, case 0, 6. visual.c:18055: Test failed: Got unexpected color 0x00303000, case 0, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 0, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 0, 12. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 1. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 2. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 3. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 4. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 5. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 6. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 8. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 1, 12. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 1. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 2. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 3. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 4. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 5. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 6. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 7. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 8. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 10. visual.c:18055: Test failed: Got unexpected color 0xdeadbeec, case 2, 12.

2 1

Re: [PATCH 3/5] d3d8/tests: Add a test for UpdateTexture.
by Marvin March 10, 2015

March 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12039 Your paranoid android. === w8 (32 bit visual) === visual.c:5983: Test failed: Got unexpected color 0x00000000, case 0, 6. visual.c:5983: Test failed: Got unexpected color 0x00303000, case 0, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 0, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 0, 12. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 1. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 2. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 3. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 4. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 5. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 6. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 8. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 1, 12. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 1. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 2. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 3. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 4. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 5. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 6. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 7. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 8. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 10. visual.c:5983: Test failed: Got unexpected color 0xdeadbeec, case 2, 12.

1 0

Re: [PATCH 2/3] gdiplus: Convert gif frame to DIB on load
by Vincent Povirk March 10, 2015

March 10, 2015

I don't like that we essentially have another instance here of the bitmap create/destroy logic. I think I'd rather we create another bitmap than use the existing one with new image data. It's not clear to me that decode_image_wic is even worth calling. Most of the logic in there is for reading image bits, and couldn't we in theory use blit_gif_frame or select_image_gif from the next patch for that? Or, if we wanted to add another hook to it, we could ask decode_image_wic to not attempt to find a matching format, and instead fall back on the conversion to 32bppARGB.

2 1