March 2015 - Wine-Devel - list.winehq.org

Re: ws2_32: Implement returning the proper time with SO_CONNECT_TIME. (resend)
by Marvin March 4, 2015

March 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11869 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at C0000241

2 1

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Nikolay Sivov March 3, 2015

March 3, 2015

On 03.03.2015 18:00, Shuai Meng wrote: > > > 2015-03-03 18:09 GMT+08:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>>: > > You're still leaking memory. > > > Thanks for commenting~ But I would be appreciated if you can explain > this more explicitly, I am not quite familiar with the string functions. Take a look at what to_string() does - you're supposed to free what it returns.

1 0

Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
by Dmitry Timoshkov March 3, 2015

March 3, 2015

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + if (((ULONG_PTR)Buffer % 8) != 0) > + return RPC_X_INVALID_BUFFER; Shouldn't this be 'if ((ULONG_PTR)Buffer & 7)' instead? -- Dmitry.

2 1

Re: rpcrt4: Fix argument check in MesEncodeFixedBufferHandleCreate()
by Marvin March 3, 2015

March 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11860 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3d9/tests: Add a test for signed formats.
by Matteo Bruni March 3, 2015

March 3, 2015

2015-03-02 22:29 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>: > + /* The input data was designed for D3DFMT_L6V5U5 and then transfered > + * to the other formats because L6V5U5 is the lowest precision format. > + * It tests the extreme values -1.0 (-16) and 1.0 (15) for U/V and > + * 0.0 (0) and 1.0 (63) for L, the neutral point 0 as well as -1 and 1. > + * Some other intermediate values are tested too. For the 8 bit formats > + * the equivalents of -1 and 1 are -8 and 8, that's why there is no > + * 0xffff input for these formats. The input value -15 (min + 1) is > + * tested as well. Unlike what OpenGL 4.4 says in section 2.3.4.1, this > + * value does not represent -1.0. For 8 bit singed data -127 is tested > + * in the Q channel of D3DFMT_Q8W8V8U8. Here d3d seems to follow the > + * rules from the GL spec. AMD's r200 is broken though and returns a > + * value < -1.0 for -128. The difference between using -127 or -128 as > + * the lowest possible value gets lost in the slop of 1 though. */ For the 8-bit format you mean that 1 is not representable in the signed u/v components, correct? Also "singed" typo, but otherwise good to me. > + static const USHORT content_v8u8[4][4] = > + { > + {0x0000, 0x7f7f, 0x8880, 0x0000}, > + {0x0080, 0x8000, 0x7f00, 0x007f}, > + {0x193b, 0xe8c8, 0x0808, 0xf8f8}, > + {0x4444, 0xc0c0, 0xa066, 0x22e0}, > + }; > + static const DWORD content_v16u16[4][4] = > + { > + {0x00000000, 0x7fff7fff, 0x88008000, 0x00000000}, > + {0x00008000, 0x80000000, 0x7fff0000, 0x00007fff}, > + {0x19993bbb, 0xe800c800, 0x08880888, 0xf800f800}, > + {0x44444444, 0xc000c000, 0xa0006666, 0x2222e000}, > + }; > + static const DWORD content_q8w8v8u8[4][4] = > + { > + {0x00000000, 0xff7f7f7f, 0x7f008880, 0x817f0000}, > + {0x10000080, 0x20008000, 0x30007f00, 0x4000007f}, > + {0x5020193b, 0x6028e8c8, 0x70020808, 0x807ff8f8}, > + {0x90414444, 0xa000c0c0, 0x8261a066, 0x834922e0}, > + }; > + static const DWORD content_x8l8v8u8[4][4] = > + { > + {0x00000000, 0x00ff7f7f, 0x00008880, 0x00ff0000}, > + {0x00000080, 0x00008000, 0x00007f00, 0x0000007f}, > + {0x0041193b, 0x0051e8c8, 0x00040808, 0x00fff8f8}, > + {0x00824444, 0x0000c0c0, 0x00c2a066, 0x009222e0}, > + }; > + /* D3DFMT_L6V5U5 has poor precision on some GPUs. On a GeForce 7 the highest U and V value (15) > + * results in the output color 0xfb, which is 4 steps away from the correct value 0xff. It is > + * not the ~0xf0 you'd get if you blindly left-shifted the 5 bit values to form an 8 bit value > + * though. > + * > + * There may also be an off-by-one bug involved: The value -7 should result in the output 0x47, > + * but ends up as 0x4d. Likewise, -3 becomes 0x6e instead of 0x67. Those values are close to > + * the proper results of -6 and -2. */ > + static const USHORT content_l6v5u5[4][4] = > + { > + {0x0000, 0xfdef, 0x0230, 0xfc00}, > + {0x0010, 0x0200, 0x01e0, 0x000f}, > + {0x4067, 0x53b9, 0x0421, 0xffff}, /* 0x4067, 0x53b9, 0x0421, 0xffff */ > + {0x8108, 0x0318, 0xc28c, 0x909c}, /* 0x8108, 0x0318, 0xc28c, 0x909c */ > + }; What did you mean to put in the comments here? Those currently there match the actual content of the array. > + for (y = 0; y < 4; y++) > + { > + for (x = 0; x < tests[j].width; x++) > + { > + expected_color = expected_colors[y][x]; > + if (!formats[i].blue) > + expected_color |= 0x000000ff; This is clearly my brain failing right now, but why is blue expected to be 0xff when the texture component is missing? > + hr = IDirect3DTexture9_GetSurfaceLevel(texture, 0, &dst_surface); > + ok(SUCCEEDED(hr), "Failed to get surface, hr %#x.\n", hr); > + IDirect3DTexture9_GetSurfaceLevel(texture_sysmem, 0, &src_surface); > + ok(SUCCEEDED(hr), "Failed to get surface, hr %#x.\n", hr); > + > + hr = IDirect3DDevice9_UpdateSurface(device, src_surface, > + &tests[j].src_rect, dst_surface, &tests[j].dst_point); > + ok(SUCCEEDED(hr), "Failed to update surface, hr %#x.\n", hr); > + > + IDirect3DSurface9_Release(dst_surface); > + IDirect3DSurface9_Release(src_surface); > + > + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0x00003300, 0.0f, 0); > + ok(SUCCEEDED(hr), "Failed to clear, hr %#x.\n", hr); > + hr = IDirect3DDevice9_BeginScene(device); > + ok(SUCCEEDED(hr), "Failed to begin scene, hr %#x.\n", hr); > + hr = IDirect3DDevice9_DrawPrimitiveUP(device, D3DPT_TRIANGLESTRIP, 2, &quad[0], sizeof(*quad)); > + ok(SUCCEEDED(hr), "Failed to draw, hr %#x.\n", hr); > + hr = IDirect3DDevice9_EndScene(device); > + ok(SUCCEEDED(hr), "Failed to end scene, hr %#x.\n", hr); > + > + for (y = 0; y < 4; y++) > + { > + for (x = 0; x < tests[j].width; x++) > + { > + if (tests[j].width == 4) > + expected_color = expected_colors2[y][x]; > + else > + expected_color = expected_colors3[y]; > + > + if (!formats[i].blue) > + expected_color |= 0x000000ff; > + > + color = getPixelColor(device, 80 + 160 * x, 60 + 120 * y); > + ok(color_match(color, expected_color, 1) > + || color_match(color, expected_color, formats[i].slop_broken), > + "Expected color 0x%08x, got 0x%08x, format %s, location %ux%u.\n", > + expected_color, color, formats[i].name, x, y); > + } > + } Cool additional test for UpdateSurface, thank you for that. Here and in the previous test I guess you might want to put the slop_broken check into a broken(), unless that also fails on Linux.

2 1

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Marvin March 3, 2015

March 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11857 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented Asc(try 2)
by Nikolay Sivov March 3, 2015

March 3, 2015

You're still leaking memory.

1 0

Re: [PATCH] uxtheme: Support images in GetThemeBackgroundRegion. (try 2)
by Alexandre Julliard March 3, 2015

March 3, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > + /* loop through the image looking for transparent pixels, > + * grouping together horizontal runs into one rect */ > + ptr = bits; > + for (y = 0; y < r.bottom; y++) { > + BOOL trans = FALSE; > + int transstart; > + > + for (x = 0; x < r.right; x++) { > + COLORREF colour = ptr[2] << 16 | ptr[1] << 8 | ptr[0]; > + ptr += 4; > + > + if (colour == transcolour) { > + if (!trans) { > + transstart = x; > + trans = TRUE; > + } > + } else if (trans) { > + rgntemp = CreateRectRgn(transstart, y, x, y+1); > + CombineRgn(hrgn, hrgn, rgntemp, RGN_DIFF); > + DeleteObject(rgntemp); > + trans = FALSE; > + } > + } > + > + if (trans) { > + rgntemp = CreateRectRgn(transstart, y, r.right, y+1); > + CombineRgn(hrgn, hrgn, rgntemp, RGN_DIFF); > + DeleteObject(rgntemp); > + } > + } That's going to be pretty slow. There's a better implementation in winex11.drv:update_surface_region(), you could just copy that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)
by Marvin March 3, 2015

March 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11855 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [1/3] dpnet: Add check for mismatched string lengths (try 2)
by Nikolay Sivov March 3, 2015

March 3, 2015

On 03.03.2015 11:57, Alistair Leslie-Hughes wrote: > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, &localhost, sizeof(localhost)+2, DPNA_DATATYPE_STRING); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); What happens with size == sizeof(localhost)/2 (or any size that cuts off a string)? Does it make a partial copy? > + hr = IDirectPlay8Address_AddComponent(localaddr, DPNA_KEY_HOSTNAME, "testing", 8+2, DPNA_DATATYPE_STRING_ANSI); > + ok(hr == DPNERR_INVALIDPARAM, "got 0x%08x\n", hr); Please use sizeof() here too.

1 0

Re: [2/3] dpnet: Free previous allocated data
by Nikolay Sivov March 3, 2015

March 3, 2015

On 03.03.2015 11:59, Alistair Leslie-Hughes wrote: > + if(entry->type == DPNA_DATATYPE_STRING_ANSI) > + heap_free(entry->data.ansi); > + else if(entry->type == DPNA_DATATYPE_STRING) > + heap_free(entry->data.string); > + else if(entry->type == DPNA_DATATYPE_BINARY) > + heap_free(entry->data.string); > + You can as well just call heap_free(entry->data.binary) for all those types (or add another neutral 'ptr' field).

1 0

Google Summer of 2015 has begun
by Austin English March 2, 2015

March 2, 2015

Howdy all, Wine has been accepted to Google's Summer Of Code for 2015: https://www.google-melange.com/gsoc/org2/google/gsoc2015/wine Developers, if you'd like to be a mentor, please go here to make a connection with the wine project, and then Andre or I will approve you: https://www.google-melange.com/gsoc/homepage/google/gsoc2015 Students, you can apply starting March 16 at 19:00 UTC. Now is a good time to start introducing yourself, explore the source, send patches, and discuss your proposals. Good luck. -- -Austin

1 0

GSOC 2015 Applicant
by Saurabh Goyal March 2, 2015

March 2, 2015

Hi, I am Saurabh Goyal a third year undergraduate from Indian institute of Technology BHU. I have taken basic Machine Learning course on coursera, created few android applications and know algorithms and data structures in c++ and i use linux(ubuntu) for my programming work. I want to participate and work on your organisation as part of GSOC this summer and i am willing to put as many hours as required per day to match the skill set required provided i get directions from my mentor and complete the job perfectly in given time. I know c++,c,R,octave,java. Please let me know how to start and look forward to hear from you. Your faithful, Saurabh Goyal

2 1

Re: [PATCH 5/5] wine.inf: Add some knownfolders to the registry
by Marvin March 2, 2015

March 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11831 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: user32: Enforce that surfaces are flushed after ReleaseDC.
by Alexandre Julliard March 2, 2015

March 2, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1116,6 +1116,7 @@ HDC WINAPI GetWindowDC( HWND hwnd ) > */ > INT WINAPI ReleaseDC( HWND hwnd, HDC hdc ) > { > + flush_window_surfaces( FALSE ); > return release_dc( hwnd, hdc, FALSE ); > } I don't think we can afford to do that, we'd be flushing constantly. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] vbscript: Implemented Asc
by Nikolay Sivov March 2, 2015

March 2, 2015

On 02.03.2015 11:12, Shuai Meng wrote: > + HRESULT hres; > + BSTR bstr; > + WCHAR ret; > + > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + switch(V_VT(arg)) { > + case VT_NULL: > + return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); > + case VT_EMPTY: > + return MAKE_VBSERROR(VBSE_ILLEGAL_FUNC_CALL); > + case VT_BSTR: > + bstr = V_BSTR(arg); > + default: > + hres = to_string(arg, &bstr); > + if(FAILED(hres)) > + return hres; > + } > + > + ret = bstr[0]; > + if(ret == 0) > + return MAKE_VBSERROR(VBSE_ILLEGAL_FUNC_CALL); > + return return_short(res, ret); Looks like you need to handle VT_NULL explicitly and after that only distinguish between VT_BSTR or the rest. Also you're leaking memory and missing a 'break'.

2 1

Re: [PATCH 1/3] ntdll/tests: Tests for RtlIpv6StringToAddress (try 4)
by Stefan Dösinger March 2, 2015

March 2, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-03-02 um 00:08 schrieb Mark Jansen: > + for (n = 0; name_a[n]; ++n) > + name[n] = name_a[n]; > + name[n] = 0; As discussed on IRC please use RtlMultiByteToUnicodeN here. Other tests use it for similar purposes, so I think it is OK to load and use here as well. Note that the other tests assume the function is available, so you don't need to add a skip() check for it. There are a few things where I don't know if Alexandre cares about them: The long lines (it may make sense to add some line breaks e.g. in long table entries), adding things like "ex_fails" in patch 1 rather than patch 2 where they are actually used (I think it's better to keep it your way, moving this to the other patch will be lots of work and won't improve readability), and the W test could in theory be moved to a separate patch. Personally I am fine with keeping those things the way they currently are. - From Patch 2: > + init_ip6(&expected_ip, ipv6_tests[i].ip); > + > + /* we do not test ip if the ex has a special case failure here. */ > + if (res == expect_ret) > + { > + ok(!memcmp(ip.s6_addr, expected_ip.s6_addr, sizeof(ip._S6_un)), > + "[%s] ip = %x:%x:%x:%x:%x:%x:%x:%x, expected %x:%x:%x:%x:%x:%x:%x:%x\n", I'm not sure what the comment means. Afaics you're always checking the IP except in case of win_broken_6. ex_fail_6 doesn't matter here. You can move the init_ip6 call into the if branch since you're not using it otherwise. - From Patch 3: > + //ok(terminator == ipv4_tests[i].address + ipv4_tests[i].terminator_offset, > + // "[%s] terminator = %p, expected %p\n", > + // ipv4_tests[i].address, terminator, ipv4_tests[i].address + ipv4_tests[i].terminator_offset); Leftover code from the A test? Since Ex doesn't write the terminator you can just remove that I think. Personally I am not too fond of the test changing its own input data (i.e., the !(ipv4_tests[i].flags & strict_diff_4) case), but since this is existing code I'd say keep it that way. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9DszAAoJEN0/YqbEcdMwo6AP/jU5NK5YqSXGuUYi1eOoaSAu 23nR4KvoaS/lXnPsZ2QPm+kyeSsWynwj0UYZ4dJJczve81m+5YYDLe4zc5Io/Fz0 C4x8WIMiBGPbhYM+iyIVAItz1wnL/9sB2IrlocQ/N9gYU1m25FLMBLvORePfQQs5 UEOOeZbaws7Qd8n+XDR7JRY9e946B7OVG8TFfq4in8IlPUsmmy+m65jQXGgQeBcF JZgOqJH+fSqW0yf3sHhok9wj7KrRpDVUgBlowBXooBz5uuEJwbQ3IwlrbL28PNIj PylUAHdVjeoHmKRif8gykwOt0laOe+RenSxegJbYbz3nw/d9Jmicj5n6W0W92hvb EPMR0a/HbNF2P6TKQIKSMwoaKhtxRXzfcgBz3Ff3LH63qtRYHxMAneU/yaueBMxR ZmfgWT9FHofH5dk2b4rRuP8XhKB/UFyqhlmimIBeDATO/aasNYuRjYlmce1NnfDa pQqW+ntq/H8TEz1jc2IQS0dm9iQZITSMkQnyJdcMi2GTQEh8y41wa0MuOTC+DavF 8HqmTmo7+/VeaZfAmWx1ndtrSktcPDr4wM70aYPcRP1+JyLsLDfkoV5VDXaelZc2 PwH1MBp6ZTv8t5ckaer4wCpvuDH972/jjB56FnbRF1SiFoYcMEs+ZuHHF5YpMn5A Pd6IazMRvRk6dd+ewaSJ =aaY5 -----END PGP SIGNATURE-----

1 0

Re: include: Correct DDSCAPS2 and DDSURFACEDESC2 structures and their uses.
by Stefan Dösinger March 2, 2015

March 2, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-02 um 02:05 schrieb Sebastian Lackner: > + union { > + DWORD dwBackBufferCount;/* 14: number of back buffers requested*/ > + DWORD dwDepth; > + } DUMMYUNIONNAME5; I don't mind if this patch is accepted, but I just want to note that this change was introduced in the directx8 SDK and doesn't exist in the dx7 SDK. Ddraw applications are probably not written with this change in mind, although since this is a nameless union it probably doesn't matter. The dwDepth member is most likely intended for .DDS files rather than the ddraw API. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9CWyAAoJEN0/YqbEcdMwhkAP/i8IUaEfm8xPckGUR6gmdChk mFNo1FS8cxs+a8CRI9P2VoLRTh68P0/tFuKVXT0vgkXApKx+vLeoRHngWktbgVSB ex05mVmlMPDlyw3rPqAw7GydbVxQKkTAzgrgskhZnEl8AjkZn1AcAzZ+LHkcLzAi MGhs1GyglPypGw996tScA0ZcAifQ/znLqA1l5y7J0iuF4jQQ/O2nVoWHZRGekWlC zJAf+2HDC+tVyF+72aefS4Oa9PyZROV36jN1vjpsfymDMB+d1pBL89xbFYMK7n+O RahYtTM1hPZS/WxWm/kF6N6kbVdj98CH4gmRoMymPmifeRpyb9SeSYZz3Aw4SJs0 j8YZb+D0o5wCYrZwXpS7cfpJ3JeKlqvifidlDpOPhTN0tU1qhNUJjTUvF159g9gR J9v/2z+XtnwtLXM0WPQGIzqwEVYwhXcxThsBoRGUVQ2/v4v9eSlVvQfyVe5LbWnc CSI7F6Q1dlue41ddWVlp/k3hbHvXw2j0AdW1eP7yj0rgbA34rt+OLRaPdbIdsZoV KWGr73foUb2brpVIN2Ms9Nmkx5ZBnIYwtfzxx54jurDFzP2+3VZI4r3QtVsm7Lv3 EcSAVB2Jhz27ueVVxAiy31Ol/6rG7Om3Sqs0UTsEWCwI3NSIL03MqoDDv8j8vVAW BQJPiryDjAgC4dA1k4+8 =AOlH -----END PGP SIGNATURE-----

1 0

Re: [PATCH] vbscript: Implemented Asc
by Marvin March 2, 2015

March 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11829 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: include/debug.h: Support tracing of VT_BSTR|VT_BYREF
by Nikolay Sivov March 1, 2015

March 1, 2015

Please ignore this one.

1 0