March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH] kernel32: Implement GetFinalPathNameByHandle
by Piotr Caban March 19, 2015

March 19, 2015

On 03/19/15 16:22, Andrew Eikum wrote: > + char data[MAX_PATH * sizeof(WCHAR) + sizeof(info->FileNameLength)]; Is the path limited to MAX_PATH characters?

2 1

Re: [PATCH] kernel32: Implement GetFinalPathNameByHandle
by Nikolay Sivov March 19, 2015

March 19, 2015

On 19.03.2015 18:22, Andrew Eikum wrote: > +/************************************************************************* > + * GetFinalPathNameByHandleA (KERNEL32.@) > + */ > +DWORD WINAPI GetFinalPathNameByHandleA(HANDLE handle, char *outstr, DWORD len, > + DWORD flags) > +{ > + WCHAR *wstr; > + DWORD dw; > + > + if (len > 0) > + { > + wstr = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ); > + if (!wstr) > + { > + SetLastError( ERROR_OUTOFMEMORY ); > + return 0; > + } > + } > + else > + wstr = NULL; > + > + dw = GetFinalPathNameByHandleW( handle, wstr, len, flags ); > + > + if (dw > 0 && dw < len) > + { > + /* success */ > + > + dw = WideCharToMultiByte( CP_ACP, 0, wstr, -1, NULL, 0, NULL, NULL ); > + if (dw > len) > + { > + /* buffer too small */ > + HeapFree( GetProcessHeap(), 0, wstr ); > + return dw; > + } > + > + dw = WideCharToMultiByte( CP_ACP, 0, wstr, -1, outstr, len, NULL, NULL ); > + if (!dw) > + { > + HeapFree( GetProcessHeap(), 0, wstr ); > + return 0; > + } > + > + /* don't report NUL */ > + dw = dw - 1; > + } > + > + HeapFree( GetProcessHeap(), 0, wstr ); > + > + return dw; > +} > + This doesn't look right. Proper way would be: - call GetFinalPathNameByHandleW() with NULL buffer to get required length; - allocated WCHAR buffer and get a path in it; - call WideCharToMultiByte() with NULL output buffer to get required length for CP_ACP string; - do what you need to do if A buffer length is too small. Right now you're assuming that WCHAR representation has same number of characters as CP_ACP one, I don't think it's always a case.

2 1

Bug that still exists for almost 10 years.
by Joshua Hale March 19, 2015

March 19, 2015

Hello, I'm helping with the first private server for Phantasy Online Universe that will be made public really soon, but the game can't run correctly with this problem: https://bugs.winehq.org/show_bug.cgi?id=6955 It's been about almost 10 years that this issue has been submitted. We were told in 2009 that there was plans to get this fixed. https://forum.winehq.org/viewtopic.php?f=2&t=6626 but nothing has came from it. This is a bit important that this gets fixed soon or else the Mac wine wrapper at launch will be a dud... Can somebody tell me the progress of this? -- Thanks, Joshua Hale

2 1

Re: [PATCH] advapi32: succeed for null pointer in ChangeServiceConfig2
by Nikolay Sivov March 19, 2015

March 19, 2015

On 19.03.2015 15:06, Bernhard Übelacker wrote: > @@ -2217,7 +2217,13 @@ BOOL WINAPI ChangeServiceConfig2W( SC_HANDLE hService, DWORD dwInfoLevel, > > info.dwInfoLevel = dwInfoLevel; > info.u.descr = lpInfo; > - err = svcctl_ChangeServiceConfig2W( hService, info ); > + > + if (info.u.descr->lpDescription) > + { > + err = svcctl_ChangeServiceConfig2W( hService, info ); > + } else { > + err = ERROR_SUCCESS; > + } In this case it's better to return earlier, no need to step into try..expect block if you know you won't call anything.

1 0

Re: [2/2] shell32: Fix SHFileOperation(FO_MOVE) for a directory with subdirectories.
by Marvin March 19, 2015

March 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12288 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

1 0

Re: [1/2] shell32/tests: Add a couple of SHFileOperation(FO_MOVE) tests for a directory.
by Marvin March 19, 2015

March 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12287 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

2 1

Re: ntdll: Use lockfree implementation for get_cached_fd. (resend)
by Alexandre Julliard March 19, 2015

March 19, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Contains a couple of small improvements compared with the last > attempt. As a reminder, the #ifdefs are there because we do not have > 64-bit interlocked instructions on PowerPC (and I have also no idea if > its possible at all to implement them properly). I'm not sure we care enough about PowerPC to require this, but in any case it would have to be done without spreading #ifdefs all over the code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] ntdll: Expose wine_uninterrupted_[read|write]_memory as exports.
by Alexandre Julliard March 19, 2015

March 19, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Since APCs are also implemented outside of ntdll, we need to expose memory management functions. > The alternative solution would be to move ws2_32 code to ntdll. That would be preferable, if you find a way to do it cleanly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] include: Add undocumented theming hook structs to winuser.h.
by Dmitry Timoshkov March 19, 2015

March 19, 2015

[please keep wine-devel in the cc: list] Mark Harmstone <hellas(a)burntcomma.com> wrote: > >> Adds the undocumented structs to winuser.h which are needed for uxtheme to hook > >> into user32. As researched by ReactOS: see https://www.reactos.org/wiki/Techwiki:RegisterUserApiHook > > > > Referencing reactos as a source of the information makes it unlikely > > to improve the chances of including the patch in Wine. > > What? Why? They've already done the research... To make long story short - ReactOS' understanding of allowed research practices doesn't match the accepted Wine standards. > > Moreover, as > > was already discussed many times, theme interface is completely > > undocumented and different between Windows versions, therefore it's > > very unlikely that there is an application that depends on the > > details of this interface, thus making it unnecessary to duplicate > > it in Wine. > > > > Well, I'm about to submit patches to allow uxtheme to hook into user32, > so it can theme the non-client areas like scrollbars. Clearly some > sort of shared interface is needed for this, would you not agree? Just making this interface Wine specific would work better IMHO. Using that approach you could add the needed pieces one by one. -- Dmitry.

1 0

Re: [PATCH] vbscript: Implemented GetLocale(try 2)
by Piotr Caban March 19, 2015

March 19, 2015

On 03/17/15 09:29, Shuai Meng wrote: > -#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON 207 > -#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND 208 > -#define DISPID_GLOBAL_VBMSGBOXRIGHT 209 > -#define DISPID_GLOBAL_VBMSGBOXRTLREADING 210 > +#define DISPID_GLOBAL_VBMSGBOXHELPBUTTON 208 > +#define DISPID_GLOBAL_VBMSGBOXSETFOREGROUND 209 > +#define DISPID_GLOBAL_VBMSGBOXRIGHT 210 > +#define DISPID_GLOBAL_VBMSGBOXRTLREADING 211 > > #define DISPID_GLOBAL_CCUR 100 > #define DISPID_GLOBAL_CINT 101 > @@ -210,6 +210,7 @@ > #define DISPID_GLOBAL_EXECUTE 204 > #define DISPID_GLOBAL_EXECUTEGLOBAL 205 > #define DISPID_GLOBAL_GETREF 206 > +#define DISPID_GLOBAL_GETLOCALE 207 This changes are not matching the typelib in native vbscript.dll. It looks like GetLocale function is not defined there at all.

2 3