March 2015 - Wine-Devel - list.winehq.org

Re: msvcrt: Use NAN and INFINITY definitions from port.h in printf tests
by Marvin March 25, 2015

March 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12406 Your paranoid android. === w2000pro (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wxppro (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2003std (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wvistau64 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2008s64 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w7u (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w8 (32 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === wvistau64 (64 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R" === w2008s64 (64 bit printf) === printf.c:693: Test failed: r = 8 printf.c:694: Test failed: failed: "1.#QNAN0" printf.c:701: Test failed: r = 13 printf.c:702: Test failed: failed: "1.#QNAN0e+000" printf.c:710: Test failed: failed: "1.#QNAN" printf.c:718: Test failed: failed: "0000001.#R"

1 0

Re: msvcrt: Fix _copysign bugs for NAN/INF
by Piotr Caban March 25, 2015

March 25, 2015

Hi, On 03/24/15 11:10, Zheng Chen wrote: > --- > dlls/msvcrt/math.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) looks like your email client has destroyed the patch (line wraps). You can solve it by e.g. attaching the patch to email. Thanks, Piotr

2 1

winevdm DOS memory range mmap() shenanigans...
by Andreas Mohr March 25, 2015

March 25, 2015

Hi all, for fun I just tried to run a Lemmings demo downloaded from http://www.pcgaming.ws/download.php?game=lemmings Picture my not overly amused face when I then got the message " winevdm: Cannot start DOS application C:\lemmings\VGALEMMI.EXE because the DOS memory range is unavailable. You should install DOSBox. ". After some wild fprintf trickery in various winevdm / virtual.c / mmap.c parts and subsequent mmap() Internet research it turned out that this message is annoyingly imprecise: a simple echo 0 > /proc/sys/vm/vmmap_min_addr (original value here: 65536) will allow the corresponding mapping, thereby enabling the game to (partially - then seems to have interesting issues at some VGA register parts) launch. I would therefore strongly suggest adding per-platform hint strings in failure case (either passed directly out of the inner reserve_dos_area() helper, or perhaps near the winevdm message). In the Linux case, this message would obviously be something like: ...range is unavailable (you might need to specially tweak /proc/sys/vm/vmmap_min_addr - note that this is a risky operation...). Since this is an important tweak (otherwise tons of DOS applications will bail out, thus rather negatively affecting Wine implementation debugging/reliability progress since nobody will make it there), it would be useful to add such hinting one way or another (I might find the time to do so, and possibly given some additional counseling I might even be able to come up with a sufficiently perfect patch). Thanks, Andreas Mohr

3 2

Re: comctl32/tests: Listview doesn't subclass its header
by Marvin March 25, 2015

March 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12399 Your paranoid android. === w7u (32 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === wvistau64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5121: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5126: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Regarding GSOC 2015 : Winetest Graphical User Interface
by Sushant makode March 24, 2015

March 24, 2015

Hello, I am a graduate student at IIIT Hyderabad India and I am interested in this project idea. ( Winetest Graphical User Interface ) I have been reading the documentation.My understanding is to add a form to existing winetest.exe which will have a table with available tests, results. These results will be read from the data which is read by the web interface possibly on the fly. I think we can run specific tests as follows e.g. cd dlls/advapi32/tests make test make services.ok Then after executing the test cases, an option to rerun the test can also be provided alongside the result of the test case. A consolidated result would be put on the same form in winetest. I am working on my GSOC proposal meanwhile It would be helpful if someone can you give some documentation regarding the winetest.exe and how to make changes to it. Thanks in advance. -- Thanks And Regards, Sushantkumar M. Tech. CSE IIIT Hyderabad

1 0

My ideas for GSoC 2015
by HuddenSin Yuan March 24, 2015

March 24, 2015

Hello, everyone. I’m Yuan Chen, a college student from China. I will have plenty of time to join GSoC 2015 and I have send two patches about mshtml.dll before and now I study gdi32 module and the Computer Graphics. Here is my idea for GSoC 2015. Improve the basic drawing functions and add GM_ADVANCED mode support ===================================== I found several bugs which show many basic curve and fonts drawing functions don’t support the GM_ADVANCED mode[1][2][3]. And the curve will become odd under this mode. I have written a test case to show these problems[9]. 1.add GM_ADVANCED mode support When I find that wine use polygon to fit the rect in GM_ADVANCED mode(polygon function is not good enough according to [4]). So I think we can use bezier spline or B spline to fit the curve like ellipse or arc in GM_ADVANCED mode[5][6]. There is also a paper about fonts capturing[7]. So the driver functions of curve and fonts like draw_arc, draw_glyph will be improved and added the GM_ADVANCED support. 2.improve the basic drawing functions In order to fix those above, we need to improve and add some basic helper functions in dlls/gdi32/dibdrv/graphics.c. get_arc_points will be improved and some helper functions will be added which help to calculate the coordinate of points of the curves in GM_ADVANCED mode.This part will take about three weeks. The bezier function need to be improved to n points instead of 3n+1 points according to Bresenham’s Algorithm[8]. This function will take less than one week. And I also try to improve the ellipse_first_quadrant functions using the Bresenham’s Algorithm.[10] Perhaps my idea is not mature enough, I will be appreciate it very much if anyone give me some advice! Thanks! [1]https://bugs.winehq.org/show_bug.cgi?id=33190 [2]https://bugs.winehq.org/show_bug.cgi?id=35333 [3]https://bugs.winehq.org/show_bug.cgi?id=35169 [4]https://bugs.winehq.org/show_bug.cgi?id=36891 [5]http://sarahfrisken.com/efficientCurveFitting.pdf [6]http://www.dtic.mil/dtic/tr/fulltext/u2/a350611.pdf [7]http://www.cs.uml.edu/~wanthony/91.427_f2008/cglr1/reference.pdf [8]http://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm [9]see the attachment “testforadvanced.txt" [10]see the attachment "0001-gdi32-Improve-the-algorithm-of-ellipse_first_quadrant.txt" ---------------------------------------- Best Regards , Yuan Chen

1 0

Re: Google Summer of Code 2015
by Matteo Bruni March 24, 2015

March 24, 2015

2015-03-24 11:38 GMT+01:00 Лёша Долгавин <dolgavin.alexey(a)gmail.com>: > Hello Matteo, > Hi Alexey, > I'm the last year student of Moscow institute. > I found you as possible mentors in project ideas. And I want to implement > missing APIs in D3DX (math and/or mesh functions). Cool! > So, I have a question: do I need to do some task or you will choose students > for this project from their proposal? Yes, you will have to write a proposal in Melange (i.e. the GSoC website) and have submitted at least one patch to wine-patches to be considered for acceptance. I suggest you to download Wine's source code, build it and give a look at the D3DX code (both the implementation of the existing functions and the tests, that's in dlls/d3dx9_36/ and the tests/ subdirectory within). Then it might be a good idea to try to run some game using d3dx on Wine, you can e.g. search bugs.winehq.org to find some. You can then try to implement one of the missing functions and see how it's like. Eventually you'll have to choose a set of the missing APIs you want to work on during your GSoC and write a suitable proposal. You'll get feedback on it and you'll be able to update it so don't worry on getting it exactly right on the first try. If you have further questions don't hesitate to ask. It's much better if you also include wine-devel(a)winehq.org in cc the next times, others might be able to reply faster / better than me. There is also the #winehackers IRC channel on freenode available. > I have strong knowledge in math and have experience in commercial software > developing. That's good. Make sure to write that in your proposal :)

1 0

Re: [PATCH] findstr: Added test for findstr.
by Stefan Dösinger March 24, 2015

March 24, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Thanks for your patch! I have a few comments: Am 2015-03-23 um 04:14 schrieb Kaipeng Zeng: > index 5f5e9d5..f3056c7 100755 > --- a/configure > +++ b/configure You don't have to include the change to configure in your patch, Alexandre will update it himself. > diff --git a/configure.ac b/configure.ac > index d23227a..822affe 100644 > ... > WINE_CONFIG_PROGRAM(findstr,,[install]) > +WINE_CONFIG_TEST(programs/findstr/tests) > WINE_CONFIG_PROGRAM(hh,,[install]) I don't think we have any precedent for having tests without having at least a stub implementation. Personally I don't see anything wrong with having just a test for now. Can you make sure that the test is properly built and included in winetest.exe? Do you intend to implement the program itself? > +static DWORD runcmd(const char* cmd, char *output) > ... > + CloseHandle(hRead); > + return TRUE; > +} I think it would be a good idea to return the return value of findstr here instead of always returning true when CreateProcess succeeds. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVD/UWAAoJEN0/YqbEcdMwh8EP/37ev7ZrJHzmNy5AJfbuzY/s 3wxUIKIo5hwrjJeiwpdFCWAtDQGMo3Hz8weLLyAaCpT4OVrzz/DvbWFLxX3zCl2Z 9EhetkZkyfiPBUF1T+s/WdTse51J9qeP8mFI7NgQdwuwUOXyp2Ba7Kq8DVBM6sNW MtWsKdItE298jTzL21oQ59w9ar6YrFwRTcVcvLQ3JPmLKSfJ5MR2qT1SxIO6nVC9 Omqc89R9Ba3jSFv+5c3l0Zn6zgnf/U5YBPmsOMYb9DWLNvD0ZgiBh5NZkLxYcV16 NLHQWxJy3mO11RNyjSn1Ank26rR1MiM4kVT7tK3WvneM1IZW7Z/RugGaymtTgfBq vIIMKidz2hPrIwmuy4AYSEb9ScJIT+b2DCbwgJEWgmxTPl3mymW5ltXLx8yzcmhV y7GNYGVKuaH6CZeyHLimeLGA845qCzXW15vWxaB6PGw+lVlqpq4mWJnWcB2NOsC+ Auw4vubTf8KTs2UHyQily9AaahthU5IkZA6sPBDpTlZCNlGpRXa+gW88WpKjd5wV 5y9otOU49Fhp704uZAiVcX9ag5cTFaseu0AsTN/TKmYToA50bzAmJr+2/+nJEQIf lcahIWPeyYw1u7rF3cOEZfkN7FIx/ab1gv1hETLvyoKz/nnYb9NPztnnK3HDFNRP XJl+R82YChN/YV946HfO =6sQQ -----END PGP SIGNATURE-----

3 6

Re: msvcrt: fix _copysign(1., -0.) error
by Piotr Caban March 24, 2015

March 24, 2015

On 03/22/15 14:51, Kevin Chan wrote: > float CDECL MSVCRT__copysignf( float num, float sign ) > { > - /* FIXME: Behaviour for Nan/Inf? */ > - if (sign < 0.0) > - return num < 0.0 ? num : -num; > - return num < 0.0 ? -num : num; > + /* FIXME: Behaviour for signbit(NAN) is different in Linux and > + * Windows, where Windows gives a zero for -NAN > + */ > + if (signbit(sign)) > + return signbit(num) ? num : -num; > + return signbit(num) ? -num : num; It doesn't make sense to add this comment and remove it in next patch. I would also prefer if signbit fallback implementation is changed in this patch. +/* FIXME: Doesnot work with +-NAN and -0. */ There's a typo in this comment. Also it works for NAN with sign bit set to 0. +#define signbit(x) ((x) < 0 ? 1 : 0) This can be simplified to: #define signbit(x) ((x)<0)

2 1

Re: msvcrt: Add errno EDOM setting for atan(NAN)/exp(NAN)/tanh(NAN)
by Piotr Caban March 24, 2015

March 24, 2015

Hi, On 24/03/15 09:01, Zheng Chen wrote: > --- > dlls/msvcrt/math.c | 3 +++ > 1 file changed, 3 insertions(+) The patch needs to be generated on top of clean wine. This will not apply without applying all your earlier patches. Please send a patch that contains all the changes to atan, exp and tanh functions. Thanks, Piotr

2 1