April 2015 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Speed of gdi vs opengl DirectDrawRenderer
by Jonas Maebe Oct. 11, 2015

Oct. 11, 2015

Hi, I had a problem with Majesty Gold HD running at glacial speed on my machine (quad Core i5 2.9GHz, NVidia GeForce GT 750M 1GB, OS X 10.9.5). I'm using wine 1.7.35, but I've had similar problems with older wine versions. It's a DirectDraw7 game that has been partially remastered to run on modern systems, but still uses DirectDraw7. This is a common problem on Windows too, but generally can be resolved by telling the game to use the DirectDraw blitter (instead of blitting itself). That didn't help on Wine though. I profiled wine (Instruments time profile) and noticed that most time was spent in wined3d's convert_r5g6b5_x8r8g8b8. Replacing that routine with an optimized sse2 version from pixman did not make much of a difference. Then I discovered that if I told the game to render to a 16 bit instead of to a 32 bit surface, wine would let OpenGL handle the colour conversion. Unfortunately, while this significantly reduced wine's cpu usage, it by no means made the game any faster. Looking at the OpenGL Driver Monitor stats, it seems the cpu was simply waiting all the time on the GPU, probably while it was blitting all of those 1920x1080 images to the screen. Reducing the resolution to the lowest supported by the game (800x600) made it slightly faster, but not much. Next, I added the DirectDrawRenderer registry key and set it to gdi. Now, while it's still slow at 1920x1080, the game runs much faster at 800x600 and even still at 1024x768. Profiling the gdi renderer shows that it has way higher cpu usage than the OpenGL renderer (virtually all in convert_to_8888), but it seems that for some reason it has causes much less traffic to the GPU. The wiki's wording suggests the gdi renderer is deprecated though. Does that mean this qualifies as a bug in the OpenGL renderer (maybe it tries to update the screen more often than necessary, saturating the bus that way?), and are there any things I can try to narrow down why the gdi renderer is so much faster? I didn't immediately see where it blits things actually to the screen. Thanks, Jonas

4 10

[PATCH] Use asserts for mmap failure modes
by Michael Gilbert July 26, 2015

July 26, 2015

Hi, Using exit in shared libraries is a discouraged practice, and wine's mmap implementation currently does that. I attach a proposed change using asserts instead. Let me know if you have any feedback. Best wishes, Mike (btw I'm the debian wine maintainer)

2 2

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Wine 64 bit
by Kevin Davies June 5, 2015

June 5, 2015

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

Re: user32: After handling an internal message give a chance to real message to arrive.
by Alexandre Julliard May 6, 2015

May 6, 2015

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2931,7 +2931,10 @@ static BOOL peek_message( MSG *msg, HWND hwnd, UINT first, UINT last, UINT flags > else > peek_message( msg, info.msg.hwnd, info.msg.message, > info.msg.message, flags | PM_REMOVE, changed_mask ); > - continue; > + > + /* give a chance to real message to arrive */ > + HeapFree( GetProcessHeap(), 0, buffer ); > + return FALSE; Why do you need to leave the function instead of checking for further messages? What is the issue you are seeing? -- Alexandre Julliard julliard(a)winehq.org

2 17

Wine Joysticks, seeking a plan
by Aric Stewart May 6, 2015

May 6, 2015

Hi all, Ok I sat down with Ken (the benefits of being in the same office) and after a lengthy discussion I have come to terms with how it may not be the most ideal plan to put the joystick driver into the graphics driver. However I am still of the strong opinion that we need some sort of better joystick architecture and I know Alexandre is also of the like mindset. This was discussed back on 2005 and I know there was also recent discussion around BSD that also involves this. I also have an itch to start to poke at xinput, but I have no interest in poking at xinput with the current way joysticks are handled. When I was working on this driver thing Alexandre expressed he was pretty opposed to having a whole new set of platform specific wine drivers. (winejoystick_mac, winejoystick_linux, etc...) But if we at least did that we would reduce code duplication by not having the platform specific code duplicated in 2 (with xinput it would become 3) places and have it collected in one place. Now completely unresearched but it may be possible to make a single joystick driver, maybe replacing winejoystick.drv that would build only the platform code that is relevant. but before I do another big chunk of work I am seeking some community buy-in and not just discuss with with Alexandre. I understand if the USB driver path gets actually fleshed out and we try to support Joysticks via that then all this separate driver work would fall away and be replaced. We of course need to make sure we come up with a plan that Alexandre will approve of. Would a replacement winejoystick.drv that holds all the platform specific code be acceptable? Is there a case where we would want that driver to be able to build multiple platform code? Maybe Linux and Linux Input? I will admit I am pretty ignorant of the Linux side of this whole situation. Ideas? Comments? thanks! -aric

7 9

Re: [PATCH 2/4] wined3d: Keep track of renderbuffer capabilities.
by Henri Verbeet May 4, 2015

May 4, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 36be539..ad9b496 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -4095,7 +4095,7 @@ static BOOL wined3d_check_pixel_format_color(const struct wined3d_gl_info *gl_in > BYTE redSize, greenSize, blueSize, alphaSize, colorBits; > > /* Float formats need FBOs. If FBOs are used this function isn't called */ > - if (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_FLOAT) > + if (format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_FLOAT) That's not wrong as such, but it is pretty arbitrary. WINED3DFMT_FLAG_FLOAT is a basic property of the format, like e.g. the component masks and sizes, it shouldn't depend on the resource type. Once we'll get proper integer types for d3d10, it will probably make sense to keep track of the type (INT/UINT/FLOAT/UNORM/SNORM) as an enumeration instead, perhaps even per-component. > @@ -4178,8 +4178,8 @@ HRESULT CDECL wined3d_check_depth_stencil_match(const struct wined3d *wined3d, > ds_format = wined3d_get_format(&adapter->gl_info, depth_stencil_format_id); > if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > { > - if ((rt_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_RENDERTARGET) > - && (ds_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if ((rt_format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_RENDERTARGET) > + && (ds_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) This is actually wrong. At least, as long as we don't allow (plain) renderbuffers to be used for FBO attachments. There's nothing in the spec that says formats that can be used for color rendering with renderbuffers have to be available for color rendering with textures as well, and in fact that's much of the reason for this patch set. > @@ -998,9 +998,9 @@ static BOOL fbo_blit_supported(const struct wined3d_gl_info *gl_info, enum wined > break; > > case WINED3D_BLIT_OP_DEPTH_BLIT: > - if (!(src_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if (!(src_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) Similar to WINED3DFMT_FLAG_FLOAT, these are basic properties of the format.

2 4

Re: [2/3] user32: Add some tests for EndDialog called from other thread.
by Marvin April 30, 2015

April 30, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13148 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013C msg.c:12252: Test failed: bad time 314e6/314f6

1 0

Re: [1/3] user32/tests: Add a test for calling SetWindowPos for other thread window. Resend.
by Marvin April 30, 2015

April 30, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13147 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013C msg.c:12252: Test failed: bad time 30ece/30ede

1 0

Re: [PATCH 2/5] d3d9/tests: Add a test for UpdateTexture. (v2, resend)
by Alexandre Julliard April 30, 2015

April 30, 2015

Matteo Bruni <mbruni(a)codeweavers.com> writes: > v2: Make tests pass on the testbot, add a couple more test cases, some > small cleanups. It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so visual && touch visual.ok visual.c:12925: Tests skipped: No NVDB (depth bounds test) support, skipping tests. visual.c:16373: Tests skipped: DXT5 volume textures are not supported, skipping test. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 0, 1. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 0, 2. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 0, 3. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 0, 4. visual.c:18582: Test failed: Got unexpected color 0x0036c800, case 1, 1. visual.c:18582: Test failed: Got unexpected color 0x0036c800, case 1, 2. visual.c:18582: Test failed: Got unexpected color 0x0036c800, case 1, 3. visual.c:18582: Test failed: Got unexpected color 0x0036c800, case 1, 4. visual.c:18409: Tests skipped: Volume ATI2N textures are not supported, skipping some tests. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 2, 1. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 2, 2. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 2, 3. visual.c:18582: Test failed: Got unexpected color 0x0000ff00, case 2, 4. make: *** [visual.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] wined3d: Don't use depth textures without ARB_depth_texture.
by Henri Verbeet April 30, 2015

April 30, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (!gl_info->supported[ARB_DEPTH_TEXTURE]) > + { > + static const unsigned int depth_flags = WINED3DFMT_FLAG_SHADOW | WINED3DFMT_FLAG_DEPTH > + | WINED3DFMT_FLAG_STENCIL; > + format->flags[WINED3D_GL_RES_TYPE_TEX_1D] &= ~depth_flags; > + format->flags[WINED3D_GL_RES_TYPE_TEX_2D] &= ~depth_flags; > + format->flags[WINED3D_GL_RES_TYPE_TEX_3D] &= ~depth_flags; > + format->flags[WINED3D_GL_RES_TYPE_TEX_CUBE] &= ~depth_flags; > + format->flags[WINED3D_GL_RES_TYPE_TEX_RECT] &= ~depth_flags; > + } This is wrong for the reasons mentioned in patch 2/4, but it should also be unnecessary. WINED3DFMT_FLAG_TEXTURE is supposed to indicate if you can use a format for texturing or not.

1 0

Re: [PATCH 3/4] wined3d: Use renderbuffers if the resource type is RB.
by Henri Verbeet April 30, 2015

April 30, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -341,6 +341,8 @@ void wined3d_resource_update_draw_binding(struct wined3d_resource *resource) > resource->draw_binding = WINED3D_LOCATION_DRAWABLE; > else if (resource->multisample_type) > resource->draw_binding = WINED3D_LOCATION_RB_MULTISAMPLE; > + else if (resource->gl_type == WINED3D_GL_RES_TYPE_RB) > + resource->draw_binding = WINED3D_LOCATION_RB_RESOLVED; I haven't looked much into what actually happens now, but the last time I looked at using renderbuffers for FBO attachments, one of the issues that came up was the initial surface contents. Right now we handle that by clearing WINED3D_LOCATION_SYSMEM and marking it current, but that won't work so well for renderbuffers. Somewhat related, does WINED3DFMT_D16_LOCKABLE need special handling?

1 0

Re: [PATCH 1/4] wined3d: Allow specifying a different depth stencil location.
by Henri Verbeet April 30, 2015

April 30, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -2342,12 +2352,14 @@ BOOL context_apply_clear_state(struct wined3d_context *context, const struct win > ++i; > } > context_apply_fbo_state(context, GL_FRAMEBUFFER, context->blit_targets, > - wined3d_rendertarget_view_get_surface(fb->depth_stencil), > - rt_count ? rts[0]->resource->draw_binding : WINED3D_LOCATION_TEXTURE_RGB); > + wined3d_rendertarget_view_get_surface(dsv), > + rt_count ? rts[0]->resource->draw_binding : WINED3D_LOCATION_TEXTURE_RGB, > + dsv ? dsv->resource->draw_binding : WINED3D_LOCATION_TEXTURE_RGB); > } This works because we mostly just care that the color location isn't WINED3D_LOCATION_DRAWABLE if there's no attachment. (In particular for the case where the application is doing depth only rendering.) Strictly speaking though, it's probably more correct to use the color location if there's no depth/stencil attachment, to avoid silliness like the color attachment being in WINED3D_LOCATION_DRAWABLE and the depth/stencil attachment in WINED3D_LOCATION_TEXTURE_RGB. In fact, now that the color and depth/stencil locations are separate, you can probably just pass 0.

1 0

Re: [PATCH 5/5] wined3d: Don't use the same va_list multiple times in shader_vaddline().
by Henri Verbeet April 30, 2015

April 30, 2015

On 29 April 2015 at 23:34, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > -static void string_buffer_vsprintf(struct wined3d_string_buffer *buffer, const char *format, va_list args) > +static int string_buffer_vsprintf(struct wined3d_string_buffer *buffer, const char *format, va_list args) > { > if (!buffer) > - return; > + return 0; > string_buffer_clear(buffer); > - shader_vaddline(buffer, format, args); > + return shader_vaddline(buffer, format, args); > } > You could perhaps just merge this into string_buffer_sprintf(), but I don't care that much.

1 0

Re: d3drm: Fix refcounting for IDirect3DRM{1-3}
by Stefan Dösinger April 30, 2015

April 30, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-29 um 23:47 schrieb Aaryaman Vasishta: > - if (!refcount) > + if (!refcount && !InterlockedDecrement(&d3drm->numIfaces)) > HeapFree(GetProcessHeap(), 0, d3drm); This works, but this way you have the code that destroys the object 3 times. Not much of an issue as long as it is just a HeapFree, but I think it would be nicer to have a separate function. Either add a d3drm_destroy function or a pair of d3drm_add_iface and d3drm_release_iface functions that also take care of InterlockedIncrement / Decrement for iface_count) > - { &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, TRUE }, > - { &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, TRUE }, > + { &IID_IDirect3DRM3, &IID_IDirect3DRM3, S_OK, FALSE }, > + { &IID_IDirect3DRM2, &IID_IDirect3DRM2, S_OK, FALSE }, Afaics all the TODOs are gone, so you can remove this field from the table and the todo_wine code from test_qi(). Either in the same patch or a separate one. > - LONG ref; > + LONG ref1, ref2, ref3, numIfaces; > }; Please use iface_count. Yeah, it's just a plain style thing, but d3drm is nicely consistent so far in not using CamelCase (except in cases where Microsoft determined the name). (Yesterday on IRC I said num_ifaces. Henri says xxx_count is the way he prefers.) > + if (refcount == 1) InterlockedIncrement(&d3drm->numIfaces); Another minor style issue: Please put the statement on a separate line, in consistency with the existing code. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVQdzBAAoJEN0/YqbEcdMw5WAP/0H52sqgEXMdSmh6sXH/dZMQ nTZY9uRhElUbb3r6D6HG0ylit994pPaq887t9BSl8F4vbjsPXLjruDbVSwoScCfp rIDKy9xET+ek4p5TSFC9cX1BFAiC2VKN7YYWmr/wHKVPZc+aFudU9ykac02bi9p2 Oe+9wMBcFbwv33UhNL+2dugA4+0yj6egfPJWmju9C6ff6CPGqgXH70rHsrSf1AYs VkNPRhGpfI9BxojBChVtgc0zwPM1HnfOwfmKWCW75YNgNg9lL0o+bdoy2wCcxiLq FYwLLT2o9K+RnPQqRDhdJBKWwY8VrJI/fHZEURRau7RW1ia26j4UrrsAdXTQwhPs Iy8A63pYOxyZsphq5KJ8cwGABYIlBPUG0lXZQRgKh1Jw8f39HIR5cfnu1at/fPSc Cw6tfL/t+g4KeHaZDWZnROwyp704kIZGgvSaPuJjwkPtHh2MN14cp9KQj389kCUM 4KfV6FxsAByRuJ8ur1HSaV2OeIOKOJkaDTzaiiMqc581A0awOeCy5SuAUSrQu4IE 4gAIjryIJXd+kTDw46y6OW5UNXHdNJKGWAMiih25yLBi0BLBfUiW0U7qW5Lcerls e7zefeUYNT+Umj3WU4sDu6B8B6auSZgKrLu9JAwYH2RUhKX9R+z3uTY25VUbJkoP 9WJfJJuosIA5zqLbjxu+ =/BI/ -----END PGP SIGNATURE-----

2 1

Re: kernel32/tests: Add tests for deleting readonly files with NtCreateFile.
by Marvin April 29, 2015

April 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13137 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === w7u (32 bit file) === file.c:4052: Test failed: SetFileValidData failed 87 file.c:4055: Test failed: SetFileValidData failed 87 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [3/3] ws2_32: Properly handle closing sockets during a select call.
by Marvin April 29, 2015

April 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13135 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: shell32: Add caption to run dialog (resend)
by Alex Henrie April 29, 2015

April 29, 2015

Thanks for your interest in developing Wine! A few pointers: You are supposed to use your name when submitting patches. I don't think Alexandre will accept just your initials. Also, you should avoid putting all that HTML garbage into the patch by using `git format-patch` and `git send-email`. If you cannot use git send-email, send the patch as an attachment. Please read http://wiki.winehq.org/SubmittingPatches Finally, your patch is more likely to be accepted if you can give an example of a Windows program that demonstrates the problem you're trying to fix. -Alex

1 0

Re: [PATCH 2/5] ddraw: Release the surface clipper (if any) in ddraw_surface_wined3d_object_destroyed() (Valgrind).
by Marvin April 29, 2015

April 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13125 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:1373: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1392: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00. ddraw1.c:6666: Test failed: Got unexpected color 0x000000ff. ddraw1.c:6670: Test failed: Got unexpected color 0x00000080.

2 1

Re: Strange wined3d crash
by Francois Gouget April 29, 2015

April 29, 2015

On Wed, 29 Apr 2015, Henri Verbeet wrote: > On 29 April 2015 at 12:40, Francois Gouget <fgouget(a)free.fr> wrote: > > I am getting a strange wined3d crash during the d3d8:device test. > > > Is that a regression? We did touch the shader generation code recently. It is actually. This is the patch that introduced the crash: commit 28343db2083de7b4afe4079da090520f44b5544d Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Mon Apr 27 17:39:12 2015 +0200 wined3d: Don't use the builtin FFP uniforms for the lights. While at it, use D3D-like uniforms for the light parameters and (consequently) implement range and proper D3D spotlights support. I can test patches but I'm not sure I'll have time to debug this much further for a while :-( Note that this is with an Intel HD Graphics 4600 GPU. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ $live{free} || die "";

3 2

Re: ws2_32: Include inttypes.h for UINT32_MAX.
by Henri Verbeet April 29, 2015

April 29, 2015

On 29 April 2015 at 11:34, Francois Gouget <fgouget(a)free.fr> wrote: > This fixes compilation on FreeBSD. > --- > > The only other files that use UINT32_MAX are: > * The .yy.c files. These are generated and always do an ifndef+define. > * dlls/mshtml/nsembed.c though it calls it PR_UINT32_MAX for some reason. > * dlls/jscript/string.c which simply defines it. > * dlls/winemac.drv/macdrv_cocoa.h which presumably gets it from the Mac > OS X headers. > > Maybe mshtml and jscript should use inttypes.h, or to the contrary, > maybe ws2_32 should use the ifndef+define approach. > Arguably it shouldn't be using UINT32_MAX at all, since it isn't actually used with uint32_t. I guess it should be using e.g. unsigned int with UINT_MAX instead.

4 6

USB Support
by Steve Kenton April 29, 2015

April 29, 2015

USB Support has been on the list of possible release criteria basically forever. I've read through all the old threads and other discussions I could find and it boils down to "really hard to do right". If possible could someone knowledgeable comment briefly on what might be an acceptable architecture for a Wine USB stack? In particular I'm wondering about how much support for client/function drivers would be desirable. Should we stick to only unprivileged operations or would an optional kernel mode driver to support WDM or WDF (KMDF/UMDF) privileged interfaces be acceptable? Steve Kenton

5 11

Strange wined3d crash
by Francois Gouget April 29, 2015

April 29, 2015

I am getting a strange wined3d crash during the d3d8:device test. It's annoying because it only happens with the 64 bit build, and disappears if I add traces (+d3d or +d3d_shader), and even if I add a FIXME() just before the crash. The crash happens in shader_glsl_ffp_vertex_lighting(): shader_addline(buffer, "gl_FrontSecondaryColor = %s * specular;\n", specular); According to the checks I've been able to do the specular pointer is still correct when this gets called. Here's the backtrace: http://pastebin.com/DKvXTVJn Any idea what's up? It almost feels like a compiler bug (gcc 4.9.2 (Debian 4.9.2-10) here). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

1 0

Re: [PATCH] wined3d: fix different level count while texture update
by Henri Verbeet April 29, 2015

April 29, 2015

On 28 April 2015 at 20:18, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Bug 38048 > According to MSDN > https://msdn.microsoft.com/en-us/library/windows/desktop/bb205858(v=vs.85) > source texture CAN have greater level count then destination > Current comparison "!=“ causes black textures as discussed in the bugzilla. > This may be correct, it may not be. This change needs tests, and I believe that was pointed out in the bug report already.

1 0

Re: [PATCH] wined3d: fix Unrecognized usage flags
by Henri Verbeet April 29, 2015

April 29, 2015

Please use git send-email for sending patches. On 28 April 2015 at 09:18, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > + WINED3DUSAGE_TO_STR(WINED3DUSAGE_TEXTURE); This is fine, but WINED3DUSAGE_OWNDC is missing here as well. Is "buf" still larger enough after you add these flags? > - if (usage) FIXME("Unrecognized usage flag(s) %#x\n", usage); > + if (usage & ~WINED3DUSAGE_QUERY_MASK) FIXME("Unrecognized usage flag(s) %#x\n", usage); I think it makes more sense to do this in the caller. It may make even more sense to just merge debug_d3dusage() and debug_d3dusagequery().

1 0

Re: [PATCH] comdlg32: Change "Borders" to "Margins".
by Alex Henrie April 28, 2015

April 28, 2015

2015-04-28 8:03 GMT-06:00 Alexandre Julliard <julliard(a)winehq.org>: > Alex Henrie <alexhenrie24(a)gmail.com> writes: > >> Alexandre, >> >> What was wrong with this patch that you did not accept it? > > I'm concerned that you have been looking at Windows a bit too much. At first, I thought that Wine actually used this string. On closer look, it seems that Wine always replaces the dialog's string "Borders" with the string resource "Margins [inches]" or "Margins [mm]": https://source.winehq.org/git/wine.git/blob/abd673bde93b76a361ddf7342c538c2… https://source.winehq.org/git/wine.git/blob/abd673bde93b76a361ddf7342c538c2… The following test (run with `./wine dlls/comdlg32/tests/comdlg32_test.exe.so printdlg`) also supports the hypothesis that Wine always overrides the dialog's string: diff --git a/dlls/comdlg32/comdlg32.rc b/dlls/comdlg32/comdlg32.rc index d3deeab..9d37d69 100644 --- a/dlls/comdlg32/comdlg32.rc +++ b/dlls/comdlg32/comdlg32.rc @@ -438,7 +438,7 @@ BEGIN GROUPBOX "Orientation", grp1, 8, 156, 64, 56, BS_GROUPBOX AUTORADIOBUTTON "&Portrait", rad1, 16, 170, 52, 12, BS_AUTORADIOBUTTON AUTORADIOBUTTON "&Landscape", rad2, 16, 190, 52, 12, BS_AUTORADIOBUTTON - GROUPBOX "Borders", grp4, 80, 156, 152, 56, BS_GROUPBOX + GROUPBOX "foobar", grp4, 80, 156, 152, 56, BS_GROUPBOX LTEXT "L&eft:", stc15, 88, 172, 30, 8 EDITTEXT edt4, 119, 170, 36, 12, WS_TABSTOP|WS_GROUP|WS_BORDER LTEXT "&Right:", stc16, 159, 172, 30, 8 diff --git a/dlls/comdlg32/tests/printdlg.c b/dlls/comdlg32/tests/printdlg.c index 7e06c97..d6c7dff 100644 --- a/dlls/comdlg32/tests/printdlg.c +++ b/dlls/comdlg32/tests/printdlg.c @@ -88,7 +88,7 @@ static void test_PageSetupDlgA(void) ZeroMemory(pDlg, sizeof(PAGESETUPDLGA)); pDlg->lStructSize = sizeof(PAGESETUPDLGA); - pDlg->Flags = PSD_RETURNDEFAULT | PSD_NOWARNING; + pDlg->Flags = PSD_NOWARNING; SetLastError(0xdeadbeef); res = PageSetupDlgA(pDlg); ok( res || (CommDlgExtendedError() == PDERR_NODEFAULTPRN), If I am correct, it would be better to replace "Borders" with "" so that translators have one less string to worry about. Is that acceptable to you? -Alex

2 1

Re: [PATCH] comdlg32: Change "Borders" to "Margins".
by Alexandre Julliard April 28, 2015

April 28, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Alexandre, > > What was wrong with this patch that you did not accept it? I'm concerned that you have been looking at Windows a bit too much. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: Added IShellFolderViewDual definition
by Marvin April 28, 2015

April 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13085 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH 5/5] d3d9/tests: Add spotlight and light range tests.
by Henri Verbeet April 28, 2015

April 28, 2015

On 27 April 2015 at 17:39, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + static const float pi = 3.141592654f; I guess you'll have to resubmit this for the testbot, but while you're at it, I think I prefer M_PI.

1 0

Re: [PATCH 3/6] dmloader: Add and use a generic IPersistStream_GetClassID.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13066 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 2/6] dmloader/tests: Add more DirectMusicCollection tests.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13065 Your paranoid android. === build (build) === Make failed

1 0

Re: [PATCH 1/6] dmloader: Use the generic DirectMusicObject implementation for DMContainer.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13064 Your paranoid android. === build (build) === Make failed

1 0

Re: jscript: Date.parse: long date with '/' or '-'
by Stefan Dösinger April 27, 2015

April 27, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-25 um 17:45 schrieb Thomas Faller: > This format is not documented under > > https://msdn.microsoft.com/en-us/library/k4w173wk%28v=vs.84%29.aspx > > but its implemented in the internet explorer and in the windows > script host. In this case a test would be very useful. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVO8QzAAoJEN0/YqbEcdMwl4EP/1+xPW5sSLx86MPGq8e1eXCx 7ON4cSV1u0IIAnw1qMc/VuUxxHw3LN6VSrBN8Rbq6XxXx/1fLvaIz7+ckdBvOz3c QhregFjv7kBsRs3WCDuz8SujMMCeBL0FdeAg7xuWl61mHRKxkaeBNROHlfPxG7GE fYBdOTUPzdEj8eYTB48xozHPMV3EadpO7GL+742upv4qxJa3m7V2ZU3/+4O1atjE +yZyVKEwxKU6PLJNMMzva/TpQPxIEPsKg2L3hFAXnZXjn6lJeew6PWGQiR/OpNR0 HLQcdGk3xQlslefauJpJ6ffSyHl+wRrK7DUpUDsNAQuWQ4ALwHsjkFGG8ph8xRL4 aMnnA+afBU2VXnVpkmnjHlILIaWtCejMo4zveXjD1dk15CeOcs2ezasxhbbl9FUl HySkMNyX6gX07BfR6e9N5gwCzHdOj0GbvRtPMcRXWkPwgzj47xX4NbT0QT8ncg2a lsey/aE8aEscUwGROWm9xv7egKxdBM5kxccBxAMFY1Z5MBNbntlMVTwKERWAl1q9 sRjf77vuuD8LIyXpntqVOb96Hq+4mIo0VzAClFOqSIf6bv8fPz8oFD1elE6G3M4W cXH620URbzXsXg4ZBVRUP6t5sIy5jnSZG+I5h0BUxSizw5ekxbKWlfCicFSZStbu Ln6ptTTJVzUg3QpSR6jN =a7ty -----END PGP SIGNATURE-----

2 2

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings (v3).
by Ken Thomases April 27, 2015

April 27, 2015

On Apr 27, 2015, at 2:54 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Version 3: Use SendNotifyMessage for sending WM_MACDRV_DISPLAYCHANGE. > Ken, I need your review again to make sure that this change doesn't > have any negative impact regarding the sync_window_position call that > is part of the WM_MACDRV_DISPLAYCHANGE message handling. Looks OK to me. It is not necessary for the sync_window_position() call to be made synchronously with respect to the sending code. -Ken

1 0

Re: [PATCH 5/5] d3d9/tests: Add spotlight and light range tests.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13061 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: shell32: Add Association Registry entries (resend)
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13043 Your paranoid android. === w2000pro (32 bit assoc) === The test timed out

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings (v3).
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13041 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2497: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2510: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [3/3] user32: Don't perform SetWindowPos synchronously.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13038 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0017014A msg.c:12252: Test failed: bad time 31267/31276

1 0

Re: [1/3] user32/tests: Add a test for calling SetWindowPos for other thread window.
by Marvin April 27, 2015

April 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13037 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00150136 msg.c:12252: Test failed: bad time 31100/3111f

1 0

Re: [PATCH 4/5] wined3d: Don't use the builtin FFP uniforms for texture transformation matrices. (v3)
by Henri Verbeet April 26, 2015

April 26, 2015

On 24 April 2015 at 22:25, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +static void shader_glsl_ffp_vertex_texmatrix_uniform(const struct wined3d_context *context, > + const struct wined3d_state *state, unsigned int tex, struct glsl_shader_prog_link *prog) > +{ > + const struct wined3d_gl_info *gl_info = context->gl_info; > + struct wined3d_matrix mat; > + > + if (tex >= MAX_TEXTURES) > + return; I think the patch is fine as it is, but as a style comment, arguably you aren't so much validating "tex" against MAX_TEXTURES here as against ARRAY_SIZE(texture_matrix_location).

1 0

Re: [PATCH] wined3d: fix wrong struct initialization
by Henri Verbeet April 26, 2015

April 26, 2015

On 26 April 2015 at 12:22, Patrick Rudolph <siro(a)das-labor.org> wrote: > - static const struct wined3d_query_data_timestamp_disjoint > disjoint_data = {FALSE, 1000 * 1000 * 1000}; > + static const struct wined3d_query_data_timestamp_disjoint > disjoint_data = {1000 * 1000 * 1000, FALSE}; The change is fine like this, but unfortunately it looks like your MUA has wrapped the patch.

1 0

Re: advapi32/tests: Add tests for RegQueryInfoKey.
by Nikolay Sivov April 26, 2015

April 26, 2015

On 04/25/2015 08:41 PM, Thomas Faber wrote: > + /* class name with buffer one char too small */ > + memset(classbuffer, 0x55, sizeof(classbuffer)); > + classlen = sizeof(subkey_class) - 1; > + ret = RegQueryInfoKeyA(subkey, classbuffer, &classlen, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); > + ok(ret == ERROR_MORE_DATA, "ret = %d\n", ret); > + todo_wine ok(classlen == sizeof(subkey_class) - 2, "classlen = %u\n", classlen); > + todo_wine ok(classbuffer[0] == 's', "classbuffer[0] = 0x%x\n", classbuffer[0]); > + todo_wine ok(classbuffer[1] == 'u', "classbuffer[1] = 0x%x\n", classbuffer[1]); > + todo_wine ok(classbuffer[10] == 's', "classbuffer[10] = 0x%x\n", classbuffer[10]); > + todo_wine ok(classbuffer[11] == 0, "classbuffer[11] = 0x%x\n", classbuffer[11]); > + ok(classbuffer[12] == 0x55, "classbuffer[12] = 0x%x\n", classbuffer[12]); I think it would be more readable if you tested it against a string. Also hardcoded offsets could be avoided in this case. > + memset(classbufferW, 0x55, sizeof(classbufferW)); > + classlen = sizeof(subkey_class) - 1; > + ret = RegQueryInfoKeyW(subkey, classbufferW, &classlen, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); > + todo_wine ok(ret == ERROR_INSUFFICIENT_BUFFER, "ret = %d\n", ret); > + ok(classlen == sizeof(subkey_class) - 2 /* win8 */ || > + classlen == strlen(subkey_class), "classlen = %u\n", classlen); > + ok(classbufferW[0] == 0x5555, "classbufferW[0] = 0x%x\n", classbufferW[0]); > + ok(classbufferW[1] == 0x5555, "classbufferW[1] = 0x%x\n", classbufferW[1]); > + ok(classbufferW[10] == 0x5555, "classbufferW[10] = 0x%x\n", classbufferW[10]); > + ok(classbufferW[11] == 0x5555, "classbufferW[11] = 0x%x\n", classbufferW[11]); > + ok(classbufferW[12] == 0x5555, "classbufferW[12] = 0x%x\n", classbufferW[12]); If first element is not changed, it's really unlikely that anything else did. > + ok(classbuffer[12] == 0, "classbuffer[12] = 0x%x\n", classbuffer[12]); > + ok(classbuffer[13] == 0x55, "classbuffer[13] = 0x%x\n", classbuffer[13]); ... > + ok(!lstrcmpW(classbufferW, subkey_classW), "classbufferW = %s\n", wine_dbgstr_w(classbufferW)); > + ok(classbufferW[12] == 0, "classbufferW[12] = 0x%x\n", classbufferW[12]); > + ok(classbufferW[13] == 0x5555, "classbufferW[13] = 0x%x\n", classbufferW[13]); Could you replace offsets with calculated string length instead so it still works for different strings.

2 1

Re: [PATCH] wined3d: fix wrong data order for D3DQUERYTYPE_TIMESTAMPDISJOINT
by Henri Verbeet April 25, 2015

April 25, 2015

On 25 April 2015 at 14:26, Patrick Rudolph <siro(a)das-labor.org> wrote: > At the moment the querry D3DQUERYTYPE_TIMESTAMPDISJOINT returns TRUE instead > of FALSE due to wrong data order in struct > wined3d_query_data_timestamp_disjoint. > Please use "git send-email" for sending patches. (Or fix your MUA to inline them.) Unfortunately swapping the order of the fields will introduce a hole in the structure between "disjoint" and "frequency", and make it incompatible with the equivalent d3d10 structure (D3D10_QUERY_DATA_TIMESTAMP_DISJOINT). I think it would be much nicer to fix the initializer of "disjoint_data" in wined3d_timestamp_disjoint_query_ops_get_data() to match the structure layout instead.

1 0

Re: (resend)comctl32:TTM_SETTOOLINFO does not change subclassing
by Alexandre Julliard April 24, 2015

April 24, 2015

Aric Stewart <aric(a)codeweavers.com> writes: > + toolInfo2.cbSize = TTTOOLINFOA_V1_SIZE; > + toolInfo2.hwnd = parent2; > + toolInfo2.uId = 0x1234ABCE; > + lResult = SendMessageA(hwndTip, TTM_GETTOOLINFOA, 0, (LPARAM)&toolInfo2); > + ok(lResult, "GetToolInfo failed\n"); > + ok(!(toolInfo2.uFlags & TTF_SUBCLASS), "uFlags has subclass\n"); > + wndProc = GetWindowLongPtrA(parent2, GWLP_WNDPROC); > + ok (wndProc == (DWORD)(&info_wnd_proc), "Window Proc is wrong\n"); > + > + toolInfo2.uFlags |= TTF_SUBCLASS; > + SendMessageA(hwndTip, TTM_SETTOOLINFOA, 0, (LPARAM)&toolInfo2); > + lResult = SendMessageA(hwndTip, TTM_GETTOOLINFOA, 0, (LPARAM)&toolInfo2); > + ok(lResult, "GetToolInfo failed\n"); > + ok(toolInfo2.uFlags & TTF_SUBCLASS, "uFlags does not have subclass\n"); > + ok (wndProc == (DWORD)(&info_wnd_proc), "Window Proc is wrong\n"); Please use the correct types for window function pointers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 5/5] wined3d: Move volume DXTn handling to apply_format_fixups.
by Henri Verbeet April 24, 2015

April 24, 2015

This fails the d3dx9_36 tests: ../../../tools/runtest -q -P wine -T ../../.. -M d3dx9_36.dll -p d3dx9_36_test.exe.so texture && touch texture.ok ... texture.c:1778: Test failed: D3DXCreateVolumeTextureFromFileInMemory returned 0x8876086c, expected 0

1 0

Re: [PATCH 6/6] wined3d: Introduce a scratch string buffers framework.
by Henri Verbeet April 23, 2015

April 23, 2015

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > It's somewhat of an RFC at this point. In particular I'd like some > feedback about the API. In general, I think it goes in the right direction. > An obvious variant would be to store the pointer to the parent > wined3d_shader_buffer structure right before the string and just > return the string itself (thus avoiding having to add ->buffer to > all the uses of the string). Personally, I don't particularly mind the couple of extra characters, and it seems like a good thing to explicitly distinguish between string buffers and regular strings. > + tex_reg_name = shader_sprintf_unsafe(&priv->string_buffers, "tex%u", stage); > shader_glsl_color_correction_ext(buffer, tex_reg_name, WINED3DSP_WRITEMASK_ALL, > settings->op[stage].color_fixup); The problem with this construction is that it is likely to break as soon as shader_glsl_color_correction_ext() does anything that ends up calling shader_get_buffer(). To make it worse, shader_glsl_color_correction_ext() isn't aware of this because it just gets a const char *, and shader_glsl_generate_ffp_fragment_shader() isn't supposed to care about the internals of shader_glsl_color_correction_ext(). > @@ -276,13 +276,17 @@ int shader_vaddline(struct wined3d_shader_buffer *buffer, const char *format, va > char *base = buffer->buffer + buffer->content_size; > int rc; > char *new_buffer; > + unsigned int new_buffer_size; > > while(1) > { > rc = vsnprintf(base, buffer->buffer_size - buffer->content_size, format, args); > if (rc < 0 /* C89 */ || (unsigned int)rc >= buffer->buffer_size - buffer->content_size /* C99 */) > { > - new_buffer = HeapReAlloc(GetProcessHeap(), 0, buffer->buffer, buffer->buffer_size * 2); > + new_buffer_size = buffer->buffer_size * 2; > + while (rc > 0 && (unsigned int)rc >= new_buffer_size - buffer->content_size) > + new_buffer_size *= 2; > + new_buffer = HeapReAlloc(GetProcessHeap(), 0, buffer->buffer, new_buffer_size); > if (!new_buffer) > { > ERR("The buffer allocated for the shader program string is too small at %d bytes.\n", buffer->buffer_size); > @@ -290,7 +294,7 @@ int shader_vaddline(struct wined3d_shader_buffer *buffer, const char *format, va > return -1; > } > buffer->buffer = new_buffer; > - buffer->buffer_size = buffer->buffer_size * 2; > + buffer->buffer_size = new_buffer_size; > base = buffer->buffer + buffer->content_size; > } > else This is a bit of an unrelated change, but probably the right thing to do. Note that I have an unsent patch that separates tracing the shader source from shader_vaddline() though, so it's going to look a bit different fairly soon. > +static char shader_empty_string[] = ""; This should be const, right? > +static void shader_sprintf_va_list(struct wined3d_shader_buffer *buffer, const char *format, va_list args) I probably would have called that vprintf/vsprintf instead of sprintf_va_list. > +{ > + int ret; > + char *new_buffer; > + unsigned int new_buffer_size; > + > + if (!buffer) > + return; > + while (1) > + { > + ret = vsnprintf(buffer->buffer, buffer->buffer_size, format, args); > + if (ret < 0 || (unsigned int)ret >= buffer->buffer_size) > + { > + new_buffer_size = buffer->buffer_size * 2; > + while (ret > 0 && (unsigned int)ret >= new_buffer_size) > + new_buffer_size *= 2; > + new_buffer = HeapReAlloc(GetProcessHeap(), 0, buffer->buffer, new_buffer_size); > + if (!new_buffer) > + { > + ERR("Couldn't allocate buffer for temporary string.\n"); > + buffer->buffer[0] = 0; > + return; > + } > + buffer->buffer = new_buffer; > + buffer->buffer_size = new_buffer_size; > + } > + else > + { > + break; > + } > + } > +} Once tracing the shader source is removed from shader_vaddline(), this comes down to a shader_buffer_clear() followed by shader_vaddline(). And arguably shader_get_buffer() should always shader_buffer_clear() the buffers it returns. > +/* This function immediately puts the buffer back into the free list (it's > + * intended to be used when the string is to be used and discarded immediately, > + * mostly useful to avoid having to move the string pointer out of the block). */ > +const char *shader_sprintf_unsafe(struct list *buffer_list, const char *format, ...) Not a fan, for the reasons mentioned at shader_glsl_generate_ffp_fragment_shader() above. > +void shader_release_buffer(struct list *list, struct wined3d_shader_buffer *buffer) > +{ > + if (!buffer) > + return; Can buffer ever legitimately be NULL? > +void shader_buffer_list_free(struct list *list) > +{ > + struct wined3d_shader_buffer *buffer, *buffer_next; > + > + LIST_FOR_EACH_ENTRY_SAFE(buffer, buffer_next, list, struct wined3d_shader_buffer, entry) > + { > + shader_buffer_free(buffer); > + HeapFree(GetProcessHeap(), 0, buffer); > + } > +} > + This doesn't actually remove the buffers from the list. There may also be an argument for wrapping the list itself in a structure, similar to struct wined3d_private_store. > struct wined3d_shader_buffer > { At some point we'll probably want to rename this to something like "wined3d_string_buffer".

2 2

Re: [PATCH 2/5] wined3d: Introduce resource-type specific format flags.
by Henri Verbeet April 23, 2015

April 23, 2015

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Always check 2D textures here, we don't want to write this ERR when the app tried > + * to create a compressed volume texture but s3tc support is otherwise available. */ > if ((desc->format == WINED3DFMT_DXT1 || desc->format == WINED3DFMT_DXT2 || desc->format == WINED3DFMT_DXT3 > || desc->format == WINED3DFMT_DXT4 || desc->format == WINED3DFMT_DXT5) > - && !(format->flags & WINED3DFMT_FLAG_TEXTURE) && !once++) > + && !(format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_TEXTURE) && !once++) > ERR_(winediag)("The application tried to create a DXTn texture, but the driver does not support them.\n"); But now it's still going to write an ERR when it tries to create a volume texture and s3tc support is unavailable. Wouldn't it make more sense to just explicitly exclude volume textures by adding a "desc->resource_type != WINED3D_RTYPE_VOLUME_TEXTURE" condition?

2 2

Favor / heads up - wine tasks in a hackathon
by Jeremy White April 23, 2015

April 23, 2015

My alma mater is putting on a hackathon for college students in our region. http://carlhacks.io/ As an experiment, I'm wanted to see if I could get any of these students interested in Wine hacking. So we've sponsored prize money for any students that can fix a bug in Wine or fix a test. I have no idea if any students are going to take it on or not, but if you see an influx of urgent requests on #winehackers or here, starting Saturday and ending Sunday, you'll know why :-/. And if any such student does actually succeed in contributing a clearly useful or even promising patch, please let me know, so I can make a point to award the prize money during the closing ceremonies. Cheers, Jeremy

1 0

Re: [PATCH 4/5] wined3d: Query info for each resource type from ARB_internalformat_query2.
by Henri Verbeet April 23, 2015

April 23, 2015

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static GLenum wined3d_gl_type_to_enum(enum wined3d_gl_resource_type type) > +{ > + switch (type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + return GL_TEXTURE_1D; > + case WINED3D_GL_RES_TYPE_TEX_2D: > + return GL_TEXTURE_2D; > + case WINED3D_GL_RES_TYPE_TEX_3D: > + return GL_TEXTURE_3D; > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + return GL_TEXTURE_CUBE_MAP_ARB; > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + return GL_TEXTURE_RECTANGLE_ARB; > + case WINED3D_GL_RES_TYPE_BUFFER: > + return GL_TEXTURE_2D; /* TODO: GL_TEXTURE_BUFFER. */ > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > + ERR("Unexpected GL resource type %u.\n", type); > + return 0; > +} > + > + You have an extra newline here. > + for (type = 0; type < sizeof(format->flags) / sizeof(*format->flags); ++type) This isn't wrong as such, but you can use ARRAY_SIZE for this now. > { > - TRACE("Format %s doesn't support %s.\n", debug_d3dformat(format->id), string); > - format_clear_flag(format, flag); > + gl_info->gl_ops.ext.p_glGetInternalformativ(wined3d_gl_type_to_enum(type), internal, pname, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s supports %s.\n", debug_d3dformat(format->id), string); It would probably be helpful if this mentioned the resource type as well.

1 0

Re: [PATCH 5/6] d3d9/tests: Add a specular lighting test.
by Henri Verbeet April 23, 2015

April 23, 2015

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define VERTICES_SIDE 5 > +#define INDICES_COUNT ((VERTICES_SIDE - 1) * (VERTICES_SIDE - 1) * 2 * 3) > + I don't think you really need to #define these, but if you do you should probably #undef them once you're done with them.

1 0

Re: [PATCH 3/6] wined3d: Introduce D3D7+ normal matrix computation.
by Henri Verbeet April 23, 2015

April 23, 2015

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define SWAP_ROWS(a, b) { float *tmp = a; a = b; b = tmp; } > + I assume this is mostly borrowed from Mesa like invert_matrix_3d(), but unfortunately Mesa isn't particularly good at writing macros, even though they have more than enough of them. This one happens to more or less work for the cases you have here, but consider the following in particular: if (...) SWAP_ROWS(a, b); else SWAP_ROWS(c, d); Please just use the standard "do { ... } while(0)" construction when you need to define a macro like that. In this particular case there's of course no reason you need a macro in the first place.

1 0

Re: [PATCH 2/2] ntdll: Add support for FileFsFullSizeInformation class in NtQueryVolumeInformationFile(try 2)
by Alexandre Julliard April 23, 2015

April 23, 2015

"Jianqiu Zhang" <zhangjianqiu_133(a)yeah.net> writes: > + if(!S_ISREG(st.st_mode) && !S_ISDIR(st.st_mode)) > + { > + io->u.Status = STATUS_INVALID_DEVICE_REQUEST; > + } > + else > + { > + ULONGLONG bsize; > +#if !defined(linux) || !defined(HAVE_FSTATFS) > + struct statvfs stfs; > + > + if(fstatvfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_frsize; > +#else > + struct statfs stfs; > + if(fstatfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_bsize; > +#endif Please avoid duplicating all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32/tests: Add a trailing '\n' to an ok() call.
by Marvin April 23, 2015

April 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: user32: After handling an internal message give a chance to real message to arrive.
by Marvin April 23, 2015

April 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12973 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00150136 msg.c:12252: Test failed: bad time 315f0/315ff

1 0

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: [PATCH 2/2] krnl386: Invalid console handles should translate into real handles when creating a new process.
by Alexandre Julliard April 23, 2015

April 23, 2015

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > This patch fixes an issue exposed by the fix in patch 1. The current > mechanism for initializing the DOS handles for a process uses > DuplicateHandle, which converts INVALID_HANDLE_VALUE into a usable > handle (but not 0). Without this fix the Caesar III demo installer > crashes with an unhandled page fault, though it may be more desirable > to allocate new handles than to replicate the behavior we used to have > prior to patch 1. Proper handles would be better, simply open the null device or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] wined3d: Shadow format flags in wined3d_rendertarget_view.
by Henri Verbeet April 22, 2015

April 22, 2015

On 22 April 2015 at 11:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -101,6 +101,7 @@ static void wined3d_rendertarget_view_init(struct wined3d_rendertarget_view *vie > view->parent_ops = parent_ops; > > view->format = wined3d_get_format(gl_info, desc->format_id); > + view->format_flags = resource->format_flags; That's wrong. We won't be able to do much with this until we support ARB_texture_view, but the view format is mostly independent of the resource format, other than that they have to be from the same compatibility class. I guess you'd want something like "view->format_flags = view->format->flags[resource->gl_type];".

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 9)
by Stefan Dösinger April 22, 2015

April 22, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-22 um 05:30 schrieb Alistair Leslie-Hughes: > + if(*pdwBufferSize < entry->size || *pdwNameLen < namesize) > + { > + *pdwNameLen = namesize + 1; > + *pdwBufferSize = entry->size; > + return DPNERR_BUFFERTOOSMALL; > + } > + > + if((*pdwNameLen && !pwszName) || (*pdwBufferSize && !pvBuffer)) > + return E_POINTER; This check suggests that a NULL pwszName is ok if *pdwNameLen is 0. However, the above check fails in this situation. Depending on how you want this to behave there's either an error in your logic or you have some redundant checks in there. Are you sure *pdwDataType is not set in the BUFFERTOOSMALL case? I mentioned pdwDataType in the last feedback already, please take a bit more care and check if some things I point out apply in a similar way to other places, and re-read the feedback you get after you think you have implemented all the changes to see if there's anything you missed. > + case DPNA_DATATYPE_DWORD: > + *(DWORD*)pvBuffer = entry->data.value ; The extra space in front of the semicolon looks weird. > hr = IDirectPlay8Address_GetComponentByIndex(localaddr, 100, NULL, NULL, NULL, &bufflen, &type); > - todo_wine ok(hr == E_POINTER, "got 0x%08x\n", hr); > + ok(hr == DPNERR_INVALIDPOINTER, "got 0x%08x\n", hr); In the code you return E_POINTER. DPNERR_INVALIDPOINTER is defined as E_POINTER, but please try to be consistent. > hr = IDirectPlay8Address_GetComponentByIndex(localaddr, i, NULL, &namelen, NULL, &bufflen, &type); > - todo_wine ok(hr == DPNERR_BUFFERTOOSMALL, "got 0x%08x\n", hr); > + ok(hr == DPNERR_BUFFERTOOSMALL, "got 0x%08x\n", hr); > + ok(namelen > 0, "namelen length is 0\n"); > + ok(bufflen > 0, "bufflen length is 0\n"); Please check the exact length, not just > 0. Please also check the name string, and the string and lengths in the success case (e.g. if you pass a length > than the necessary size does dpnet change the size?). Also, as pointed out above -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVN25ZAAoJEN0/YqbEcdMwf1cP/jXMXUuyMNzg5JAVG6YMMKgJ yIac4X5zxnmcPrJMjMRKIr2xU3u6ZDki/Kk5/GulDCCd4NQGlDJP0QY9WuuZ9eIN YiAipjXLpO4DPVi6eTRlDIbfCSDfpNJnjSWdDGbjpF/dpUkJOOZzwWvkJKZr598O kZohPT1kwTs12sU3yQyT8N3NGQer+AaWHcfohMW5f0UeZ+whviwjg3CGavrR65mH Q2fWn92mgw8KPTu+zvJ5oBbWQLf24o+lBp/vQ6zeOIA2lxXVLoMfg5q8QRWvKge9 IiPIG8BEOfrTXXSEZSUauif97fdq23JGQJOOGYUyZ+YLg/4Pqj2nWZBOmFM+3gVy E5FgFPT4EdE1vpyn7cnWGufzNtnctTZGOJ4F7AKxdMoBPqXxDEgdjmMFqN0yeTH8 Pm6NGVJP7uR8+wqXApHoGN2S7ceZLuEhMhdGYHbFakx9McPzCEayWMGQ/CIlbjHt YRB5aaxOAk896Fmb+PMuv3G9d4+y4409iLB+/Jrda20VOFfAp1qzNa33R9rhWXN7 sSdCale2KKYwStnzSWAcH4Mn7L+i1B/Dl7Md83HqPumAPfwlSK8VZVeqF0ZVjLaR KlokPcmQnIuS/ia6gPdGVbmAHnpoIIn0CNtgstKBqXkvGUlasXsKhy2ofWkWoaiW lO+hrwausmSORbzMGVaW =fTwv -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 9)
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12940 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: comctl32:TTM_SETTOOLINFO does not change subclassing
by Nikolay Sivov April 21, 2015

April 21, 2015

On 21.04.2015 17:40, Aric Stewart wrote: > > Prevents crashes when a subclassed window is unsubclassed and then destroyed. > > As per information found at: > https://support.microsoft.com/en-us/kb/kbview/154122 > --- > dlls/comctl32/tooltips.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > We definitely need a test for that.

2 1

Re: [PATCH 5/5] ddraw/tests: Port the lighting test to the previous d3d versions.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12921 Your paranoid android. === wvistau64 (32 bit ddraw1) === ddraw1.c:2488: Test failed: Expected message 0x46, but didn't receive it. ddraw1.c:2490: Test failed: Expected screen size 1024x768, got 0x0. ddraw1.c:2496: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2527: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2535: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2562: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2582: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2606: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2633: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2650: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2687: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2698: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2725: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2745: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2762: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2789: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2806: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2844: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}.

1 0

Re: [PATCH 4/5] ddraw/tests: Add more d3d7 lighting tests.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12920 Your paranoid android. === w8 (32 bit visual) === visual.c:1494: Test failed: unexpected colortable on offscreen surface

1 0

Re: iexplore: Update version to 9.0.8112.16421.
by Nikolay Sivov April 21, 2015

April 21, 2015

On 21.04.2015 12:19, Hans Leidekker wrote: > --- > programs/iexplore/iexplore.inf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Maybe ieframe/mshtml versions should be updated as well?

2 1

Re: [2/2] server: GetQueueStatus should clear only checked queue changed bits.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12902 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00080150 msg.c:12252: Test failed: bad time 30c10/30c20

1 0

Re: [1/2] user32/tests: Add PeekMessage(PM_NOREMOVE) call to inter-thread messages test.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12901 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10471: Test failed: expected PeekMessage to return FALSE, got 1 === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013C msg.c:12252: Test failed: bad time 30fa9/30fb8

1 0

Re: (resend)server: Do not replace focus and active windows with NULL on thread_attach_input
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12890 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00080150 msg.c:12252: Test failed: bad time 30f1c/30f2c

1 0

Re: server: Do not replace focus and active windows with NULL on thread_attach_input
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12889 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013E msg.c:12252: Test failed: bad time 3200d/3201d

1 0

Re: user32/tests: Add a test for sending inter-thread messages.
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12880 Your paranoid android. === w7u (32 bit msg) === msg.c:6957: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x0014 instead msg.c:6957: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0082 instead msg.c:6957: Test failed: destroy child on thread exit: 2: the msg 0x0014 was expected, but got msg 0x000f instead msg.c:6957: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:12230: Test failed: unexpected hwnd 00060150 msg.c:12252: Test failed: bad time 31cc3/31cd2

1 0

GSoC 2015 Application
by lijianwei April 20, 2015

April 20, 2015

Hi I'm a graduate student in NorthWestern Polytenical University.I have been study Parelism promraming,especially GPU programming for two year.So I want to accept task Implement OpenMP. But now,what should I do to begin my work. Watting for your answer! Than you! Best Regard

2 1

License of AppDb content and sql dump?
by Sebastian Lackner April 19, 2015

April 19, 2015

Hiho, I've been wondering if there is any license information available for the appdb content. I've looked through lots of pages but didn't find any hint under which terms the data can be used. It would be nice if someone could clarify this situation a bit. For those who are wondering why I'm asking - I am planning to use the (anonymized) data (especially app names, categories and corresponding ratings) for further analysis and comparison between different Wine versions. There will of course be references to show where the data is from. Since the data is used in connection with the Wine project I would assume that it should be normally safe to do that - if anyone sees any legal issues please contact me. ;) Best regards, Sebastian

1 0

Re: [PATCH] urlmon: set hres also in else branch (Coverity)
by Nikolay Sivov April 19, 2015

April 19, 2015

On 19.04.2015 14:42, Marcus Meissner wrote: > 718705 Unchecked return value > --- > dlls/urlmon/session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/urlmon/session.c b/dlls/urlmon/session.c > index e01e647..001158f 100644 > --- a/dlls/urlmon/session.c > +++ b/dlls/urlmon/session.c > @@ -213,7 +213,7 @@ IInternetProtocolInfo *get_protocol_info(LPCWSTR url) > > hres = IClassFactory_QueryInterface(cf, &IID_IInternetProtocolInfo, (void**)&ret); > if(FAILED(hres)) > - IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > + hres = IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > IClassFactory_Release(cf); > > return ret; > It's still unchecked. If we want to use it we need to propagate return code to caller, right now it will return NULL interface pointer. So I'm thinking it's false positive.

2 1

Application for GSoC 2015 - Implement findstr.exe for Wine.
by KaiPeng Zeng April 19, 2015

April 19, 2015

Hi folks, I’m Kaipeng Zeng who is a Linux user and Wine/CrossOver user from China. I am major in Biomedical Engineering in Guangdong Pharmaceutical University. I’d like to apply GSoC to work for Wine Project this year. My proposal is "Implementing findstr.exe for Wine". Though findstr is a quite independent program in Wine, I think it is valuable to implement. As far as I knew, there are some bugs about findstr in Bugzilla[1]. Any other programs in Chinese depend on it too. The implementation of findstr will help these programs and all the programs will also be good tests for our implementation. Besides, I think the code of grep will be helpful for implementing findstr. There are three parts in my plan: === Part 1: Add more tests for findstr.exe === I have submitted a patch for findstr’s test to wine-patches[2]. I will add more tests to prepare for the implementation. === Part 2: Implement an initial findstr.exe === With enough tests, I will try to implement the findstr gradually. My middle goal is having an initial implementation of findstr which can handle some simple work. Bug 35254[3] may be fixed after this part is finished. === Part 3: Add more parameters implementation === In this part, I will add more tests and try to implement more arguments for findstr, let it solve more things. [1] https://bugs.winehq.org/buglist.cgi?quicksearch=findstr&list_id=178519 [2] http://source.winehq.org/patches/data/110182 [3] https://bugs.winehq.org/show_bug.cgi

1 2

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings (v2).
by Ken Thomases April 17, 2015

April 17, 2015

On Apr 17, 2015, at 4:09 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Version 2: Also update macdrv_displays_changed. Supersedes 110793. Looks OK to me. -Ken

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12849 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings.
by Ken Thomases April 17, 2015

April 17, 2015

Sorry for the double post. Sent by accident before I was finished. This hoists some of the knock-on effects of WM_MACDRV_UPDATE_DESKTOP_RECT to the place where it is sent. However, it only does so for one of the two places where it is sent. It is also sent in macdrv_displays_changed() which is called when something external to the process (may have) changed the display configuration. You would need to duplicate the hoisted code to that function, too, or find some other way to make sure the same work gets done. -Ken On Apr 16, 2015, at 5:18 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Same as the previous patch, just for winemac.drv. > > The message ping-pong between the ChangeDisplaySettings calling thread > and the desktop thread is more complicated here than in winex11. The > problem again is that sendMessageTimeout(SMTO_BLOCK) will not process > messages sent by the desktop, leading to a deadlock. Replacing > SendMessageTimeout in the desktop with PostMessage is not an option > either because then messages will be executed in a different order in > the thread that called ChangeDisplaySettings. > > This patch will lead to DISPLAYCHANGE messages being sent on redundant > changes. This matches the behavior of winex11 and happens to fix the > user32/sysparam.ok test, but it fixes it for the wrong reason (the real > problem afaics is that OSX only supports 32 bpp, so no change takes > place although one was requested). I think redundant changes should be > intercepted in user32 before the display driver is called. > --- > dlls/winemac.drv/display.c | 8 ++++++-- > dlls/winemac.drv/window.c | 4 ---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c > index 10ecf67..f7ce163 100644 > --- a/dlls/winemac.drv/display.c > +++ b/dlls/winemac.drv/display.c > @@ -564,8 +564,12 @@ better: > size_t width = CGDisplayModeGetWidth(best_display_mode); > size_t height = CGDisplayModeGetHeight(best_display_mode); > > - SendMessageW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > - MAKELPARAM(width, height)); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > + SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > + SendMessageTimeoutW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK, ~0U, NULL); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > ret = DISP_CHANGE_SUCCESSFUL; > } > else > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index 7a777e6..fa12af5 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -1666,13 +1666,9 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > if (!GetWindowRect(hwnd, &current_desktop_rect) || > !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) > { > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > - SMTO_ABORTIFHUNG, 2000, NULL); > SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), > CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), > SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, > - SMTO_ABORTIFHUNG, 2000, NULL); > } > } > return 0; > -- > 2.3.4 > > >

2 1

Re: [PATCH] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12824 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

2 1

Re: [PATCH 1/2] ntdll/tests: Add test for FileFsFullSizeInformation(try 2)
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12844 Your paranoid android. === w8 (32 bit file) === file.c:407: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

WineConf 2015
by Michael Stefaniuc April 17, 2015

April 17, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello guys, after we rethought WineConf and did it at/during FOSDEM for the last two years, it is time for a real WineConf again. We are missing too much our keynote, our governance discussions as well as our hackatons. Also the two full days should give more time for the most important topic aka the hallway discussions. After two years in Europe the old tradition would call for a session over in USA/Canada but this is not a strict requirement. Now the most important thing is to find volunteers that would want to host the WineConf. They have the bigger say in the date too, there are two options: - - either in late spring (preferred by me), - - or early fall (preferred by Jeremy) I have started also http://wiki.winehq.org/WineConf2015 please feel free to add agenda topics to it. bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTY5awACgkQ0ei8kcpE1VG2YQCguwUys0se+wV96lPfjZ+Qi6LJ 8ooAoJDxist2eZLgMXsRqUZVloGpBRgz =7Ta5 -----END PGP SIGNATURE-----

6 12

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings.
by Ken Thomases April 16, 2015

April 16, 2015

This hoists some of the knock-on effects of WM_MACDRV_UPDATE_DESKTOP_RECT to the place where it is sent. However, it only does so for one of the two places where it is sent. It is also sent in macdrv_displays_changed() On Apr 16, 2015, at 5:18 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Same as the previous patch, just for winemac.drv. > > The message ping-pong between the ChangeDisplaySettings calling thread > and the desktop thread is more complicated here than in winex11. The > problem again is that sendMessageTimeout(SMTO_BLOCK) will not process > messages sent by the desktop, leading to a deadlock. Replacing > SendMessageTimeout in the desktop with PostMessage is not an option > either because then messages will be executed in a different order in > the thread that called ChangeDisplaySettings. > > This patch will lead to DISPLAYCHANGE messages being sent on redundant > changes. This matches the behavior of winex11 and happens to fix the > user32/sysparam.ok test, but it fixes it for the wrong reason (the real > problem afaics is that OSX only supports 32 bpp, so no change takes > place although one was requested). I think redundant changes should be > intercepted in user32 before the display driver is called. > --- > dlls/winemac.drv/display.c | 8 ++++++-- > dlls/winemac.drv/window.c | 4 ---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c > index 10ecf67..f7ce163 100644 > --- a/dlls/winemac.drv/display.c > +++ b/dlls/winemac.drv/display.c > @@ -564,8 +564,12 @@ better: > size_t width = CGDisplayModeGetWidth(best_display_mode); > size_t height = CGDisplayModeGetHeight(best_display_mode); > > - SendMessageW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > - MAKELPARAM(width, height)); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > + SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > + SendMessageTimeoutW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK, ~0U, NULL); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > ret = DISP_CHANGE_SUCCESSFUL; > } > else > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index 7a777e6..fa12af5 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -1666,13 +1666,9 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > if (!GetWindowRect(hwnd, &current_desktop_rect) || > !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) > { > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > - SMTO_ABORTIFHUNG, 2000, NULL); > SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), > CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), > SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, > - SMTO_ABORTIFHUNG, 2000, NULL); > } > } > return 0; > -- > 2.3.4 > > >

1 0

Re: [PATCH 1/2] d3drm/tests: Make get_refcount return ULONG instead of int.
by Stefan Dösinger April 16, 2015

April 16, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 These patches look good to me. On 04/13/15 18:59, Aaryaman Vasishta wrote: > --- dlls/d3drm/tests/d3drm.c | 2 +- 1 file changed, 1 insertion(+), > 1 deletion(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 2f154f9..f089707 100644 --- a/dlls/d3drm/tests/d3drm.c +++ > b/dlls/d3drm/tests/d3drm.c @@ -33,7 +33,7 @@ ok(count == rc_new, > "Invalid refcount. Expected %d got %d\n", rc_new, count); \ } > > -static int get_refcount(IUnknown *object) +static ULONG > get_refcount(IUnknown *object) { IUnknown_AddRef( object ); return > IUnknown_Release( object ); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVL81eAAoJEN0/YqbEcdMwrRYP/j37mA7B6bg9RveFxAYQS8VX AVROgmPd+hZDl/JKKnSMrUgHU3Y6MtCGwKd6Pb42yRhpU8qw/j6dPW1QqUYSII0V MpqpON1tY6WRV8M2eCBJ5+qLBwzFDxi51a4ta+7BUbK6Jl9IJw58OdyL5pt5WSID XneEmweh3BVI3ay4ZYn5jlK53BArCFu5yfclYPklL5uNb4sdA5zTJoavvwUHYMHc grjeEXAxRnBn8zmD13H5+s8GRC59Sx/vHJl6PTlv2A4bU22HwTku3b7/RbAGyYtB rB4Y+SRUeDn8e5YAe6+kWmwAOORdQFf1plmLx+bjIc13UYlnBTLnOjV8KMZm9vrC nhCcxUVeY3YYahA7q37nEOMZHVt++mX5pJ00vdV47QzZVAat05pA9tiesI3n5IAm DNrDRPV1olBT2OIz20Xo0YvtdBnvkOQDKB+SfYtD8YnGGNw/WZKUEwBh5IpNtvbE iZ/d3AMB1h4A1trWofNR17nZJbTwQwTmIKI6ggw2Cr6DpPb6SFp6odoA4OjajGGB e+sqBTaf5yf2QbDzjn694f4PKAeTZwnkXXzR9Quu2J1Zu4dZFSWFvnFnq5ZMgTqq P1RrnGJJdx9p1JytzRhi9M9vnIr4UUGMNfOOGuw/qvnCyYHXM67ka9leXs82ruK3 aZbHB7YZDSthklM3u+RX =r66h -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings.
by Marvin April 16, 2015

April 16, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12822 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2003std (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === wvistau64 (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2008s64 (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w7u (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === wvistau64 (64 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2008s64 (64 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out

1 0

Re: [PATCH 3 / 2] d3d9: Add support for d3d9ex formats
by Sergey Isakov April 16, 2015

April 16, 2015

Ignore, please, this is included in previous patch. Sorry! On 16.04.2015, at 12:47, Sergey Isakov wrote: > just forget two lines in previous commit > <patch-d3d9ex-d3d9-device.txt>

1 0

Re: [PATCH 1 / 2] d3d9: Add support for D3D9ex new formats
by Stefan Dösinger April 16, 2015

April 16, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Do you know a game that needs these formats? Is there a d3d9 game that actually locks the depth buffer? Do Windows drivers support these formats? Am 2015-04-16 um 09:37 schrieb Sergey Isakov: > + case WINED3DFMT_D32_LOCKABLE: return D3DFMT_D32_LOCKABLE; > + case WINED3DFMT_S8_LOCKABLE: return D3DFMT_S8_LOCKABLE; WINED3DFMT_D32_LOCKABLE doesn't exist yet. Your patches are in the wrong order. > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 174fc13..6934528 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -2199,6 +2199,8 @@ static void test_display_modes(void) > TEST_FMT(D3DFMT_R8G8_B8G8, D3DERR_INVALIDCALL); > > TEST_FMT(D3DFMT_D16_LOCKABLE, D3DERR_INVALIDCALL); > + TEST_FMT(D3DFMT_D32_LOCKABLE, D3DERR_INVALIDCALL); > + TEST_FMT(D3DFMT_S8_LOCKABLE, D3DERR_INVALIDCALL); Please add a test that actually uses the format and locks them. It's ok if parts of the test (those that depend on depth transfers to / from system memory) are marked todo since wined3d doesn't handle depth locking at all. > + /* d3d9ex formats */ > + /* Z-Stencil formats valid for CPU access */ > + D3DFMT_D32_LOCKABLE = 84, The second comment is misaligned and I don't think these comments add much information. > + // s10e5 formats (16-bits per channel) This is an unrelated change. C++ comments ("//") are not allowed in Wine as our sources are plain C. > + // Monochrome 1 bit per pixel format > + D3DFMT_A1 = 118, > + // 2.8 biased fixed point > + D3DFMT_A2B10G10R10_XR_BIAS = 119, > + // Binary format indicating that the data has no inherent type > + D3DFMT_BINARYBUFFER = 199, Adding those is OK, but should be in a separate patch. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVL4cnAAoJEN0/YqbEcdMw6eMP/2b06nt5c3E9Stwm52T7l3aZ ytyrBcrqT7lE2XHVEhFH6te/NSgUXO5KYPqkgZQfx+/YvmnnevXeA1jfIMh5wOoD trBXmIDbhtgt1ABXmOB6CmN710B3zLBwnxMj4rUfiZAHgW4T6aONKxy4VmNGNxnl i5QxgMBOJbsAocu5URUpeiyGd87f3YWD1mTcrtAjwgTSNyF33VAx7O0zcV7Iui9e NY5fzYG7ff19zcPKRDIuOO0/ga93yYh6OcesiyUon+CHh+PxCcnztdXuNA6uIf2X N+OOudRbWrgnrpGbhudraRgoQOXIl+Sg1chX97qmPdtgz8Ftgf98yBWMld+QKllW fbTa8mIyiZBdO+0hTRYeiSMdDH0q4PnBbetvPW1lLRHVIlNqbL67yi4q9F+nvRoz jv5ueaz8S4iflG57ZVBVjmBok4QMxoX34J1V3M/qahsWhK1+hFVKXM7cJn9j0hNW H6GS/HdNA35yqwNJyKQdj3i2P1ptom39vLqHLlPCmX9okjiTSXfrtDsJBZdsHNC3 GP9uJWZnhE61rTmlwQ1vpdxZvVUp8whIgsgu9GWX7KaDXa3kYSf58sjE5aEAuKhh 4thc8OElq1BzRPHRIZNbyUoqZ6qHELYt88UNMA74obHun69UOeyvN2MIKn8wvTDh wIttvErryrAqz5+mFjKK =r5/p -----END PGP SIGNATURE-----

1 0

Re: Andrew Eikum : winecfg: Use a listview for speaker configuration.
by Bruno Jesus April 15, 2015

April 15, 2015

On Wed, Apr 15, 2015 at 10:43 AM, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: e17f4fd2f814a2a651c229ead4f86ab25130fe06 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=e17f4fd2f814a2a651c229ead… > > Author: Andrew Eikum <aeikum(a)codeweavers.com> > Date: Tue Apr 14 14:01:46 2015 -0500 > > winecfg: Use a listview for speaker configuration. This is much better, thanks Andrew.

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 8)
by Stefan Dösinger April 15, 2015

April 15, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, There are a few issues with this. They seem vaguely familiar to me, I think I have raised them before but they got lost in the list to array conversion: On 04/15/15 12:07, Alistair Leslie-Hughes wrote: > @@ -405,9 +405,48 @@ static HRESULT WINAPI IDirectPlay8AddressImpl_GetComponentByIndex(IDirectPlay8Ad > const DWORD dwComponentID, WCHAR *pwszName, DWORD *pdwNameLen, void *pvBuffer, > DWORD *pdwBufferSize, DWORD *pdwDataType) > { I assume you're supposed to write the name to pwszName if it is non-NULL, and check *pdwNameLen against the string length first. > + entry = This->components[dwComponentID]; > + > + if(*pdwBufferSize < entry->size) > + { > + *pdwBufferSize = entry->size; > + return DPNERR_BUFFERTOOSMALL; > + } It seems to me that it should assign *pdwDataType and *pdwNameLen in this case. The test should be extended to explicitly check the assigned lengths. Your code never sets *pdwNameLen, and it sets *pdwDataType only if the buffer is big enough. The concern about assigning *pdwDataType in the buffer to small case also applies to GetComponentByName. > + switch (entry->type) > + { > + case DPNA_DATATYPE_DWORD: > + memcpy(pvBuffer, &entry->data.value, sizeof(DWORD)); > + break; > + case DPNA_DATATYPE_GUID: > + memcpy(pvBuffer, &entry->data.guid, sizeof(GUID)); > + break; Assignments should be enough in these cases. The same applies to the existing GetComponentByName code. A semi-related problem in the existing GetComponentByName code: > if(!pwszName || !pdwBufferSize || !pdwDataType || (!pvBuffer && pdwBufferSize)) > return E_POINTER; The second check for pdwBufferSize is redundant, you already established it is not NULL. I assume that's supposed to be *pdwBufferSize. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVLj+3AAoJEN0/YqbEcdMws+UP/0q9wkiDyPPLi5+tbp8NXPKZ NItf38ksjFeForuNvmRt/Q0MAvQeJ0CSpqoyk3nH9G0EvcNQPXEpBHBCiL7aqUVU HN0OWc07OANPPrvAVqNRAVVaaAr1v9NFd+CJFNqNf7d0uOj0D1GMJtvJw+1ia06P qFfAUIIRSf1ay4RocO2HyAsaYwtps15Pib067jBJT/iVriMJQuflB9WRBy6BmKrR DM0PzySi3+quFjl+tYKUitUeR4RgGsMXUSx8V3l03929Y1duRO0uSfzAs18Mquqh wovE36jJfYhpBhJa7oAI9CVkNvr/EBMSVzHtBOGWM6mewMI3CGrfn+ZLxjOe1kk3 pIFXfIlbBBTZJYusL8fOxL0itacE2+YB5Opzi2K6TyNfnqWHscR5g7q+JH6iIe4k /JepaI2mqPsD2RgvM7SKBH2s6qz+cfd7uHWiW+QzzVEqIixbb3eJm1raR9p2UMAb +aJ9XPYpIeRzy8+BxCXLWhd5GQIFOSlUisQwxbwM9a/d9URFgcLS2KDX3ZjPPBcL hTOCS3jDiIfjf5lTpl1wj/rb+9zmK0JkpFyf6/EbxZEThP/fNuwSHtIYaY/4UO97 H9bpWYI5x1N7VnXaAFhCy9uwMeJ05ZYj0AhVl70S4Q1pHsFSX5XWumTOpfxXtJhH WRMpPPalUDabz3fPcAgG =rxp6 -----END PGP SIGNATURE-----

1 0

Re: msvcrt: improve accuracy of exp/pow/cosh and sinh
by Ruslan Kabatsayev April 14, 2015

April 14, 2015

Hi, Are you sure this will be of any use if one selects SSE instead of x87 instruction set to handle doubles (like -mfpmath=sse)? No one guarantees the functions like sinh will be evaluated on x87 FPU and even that this legacy instruction set will used at all. Regards, Ruslan On Sat, Apr 4, 2015 at 7:40 PM, Zheng Chen <chanchengcc(a)gmail.com> wrote: > The default fpu_cw = 0x27f makes the exp/pow/cosh/sinh functions producing > less accurate results. This patch temporally changes fpu_cw to 0x37f in > these functions for more accurate results. > > Thanks to Qian for his ideas. > > This patch fixes parts of these two bugs: 37149, 37150 > > >

2 1

i3, i5, i7 benchmarks building wine-1.6.2
by Dan Kegel April 13, 2015

April 13, 2015

Hi folks, in case anyone's wondering how fast a cheap computer builds wine these days, I did a little benchmark on the family computers. The benchmark was: $ sudo apt-get build-dep wine $ apt-get source wine $ cd wine1.6-1.6.2/ $ time debuild -b -uc -us $ dh clean $ time debuild -b -uc -us -j4 Results: Vintage CPU Ubuntu Time -j1 Time -j4 Details (model, barebones price) 2015 i3-4130 15.04b2 23m31s 12m16s http://kegel.com/new-computer-2015.html (ts140, $250, no drive) 2014 i5-4460 14.04 21m25s 8m12s http://kegel.com/new-computer-2014.html (h530, $426 including 1TB drive) 2010 i7-920 14.10 35m47s 13m44s http://kegel.com/new-computer-2010.html (ASRock x58 Extreme, $800, no drive) I'll probably semi-retire the ol' i7 and replace it with another ts140 soon, partly to save power, and partly to beef up my LAN party capabilities :-) (My new house has been averaging 22 kwh/day lately; switching from the i7 to the i3 will save something like 0.5 kwh/day on days when I work at home. Hope to add solar panels and go carbon-neutral sometime, but gotta fix the chimneys, replace furnaces with heat pumps, insulate, and replace the roof first.) - Dan

1 0

Re: dsound: Fix conning formula to correctly interpolate volume.
by Andrew Eikum April 13, 2015

April 13, 2015

On Sat, Apr 11, 2015 at 03:44:14PM +0000, Igor Kotrasinski wrote: > > Original formula is obviously wrong (plug in a large flAngle and a small cone difference). This one does correct linear interpolation. Makes sense to me. Thanks! Andrew

1 0

Re: [PATCH] dsound: Stricter validation for formats in secondary buffers
by Marvin April 13, 2015

April 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12777 Your paranoid android. === wxppro (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032 === w2003std (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032

1 0

Re: [PATCH] shell32: Add more knownfolders
by Marvin April 13, 2015

April 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12776 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winejoystick.dev: Add Graphics Driver connection for winejoystick.drv
by Charles Davis April 13, 2015

April 13, 2015

I do not agree with this particular direction. You do realize that some people on Mac OS still use the X11 driver (e.g. to get virtual desktop support), right? With these patches, these people suddenly won’t have any joystick support at all. Don’t get me wrong, I still think putting all the joystick code in one place is the right thing to do. I just don’t think that one place should be the graphics driver. Chip

5 7

Re: mshtml: Remove nsIDOMWindowUtils::SetCriticalDisplayPortForElement.
by Alexandre Julliard April 13, 2015

April 13, 2015

Thomas Faber <thomas.faber(a)reactos.org> writes: > This function is no longer present in Wine Gecko, so this re-aligns > the vtable. > > See https://www.winehq.org/pipermail/wine-devel/2015-April/107319.html It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so activex && touch activex.ok activex.c:1320: Test failed: unexpected call InPlaceDeactivate activex.c:1066: Test failed: unexpected call Close activex.c:1041: Test failed: unexpected call SetClientSite_NULL activex.c:1761: Test failed: OnUIActivate failed: 8000ffff activex.c:1716: Test failed: GetContainer failed: 8000ffff activex.c:1717: Test failed: container == NULL wine: Unhandled page fault on read access to 0x00000000 at address 0x7ecb5066 (thread 003a), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: Avoid four instances of "logical not is only applied to the to the left hand side".
by Henri Verbeet April 13, 2015

April 13, 2015

On 12 April 2015 at 23:04, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Indrek suggested that in this specific case the alternate approach > below also should work, so let me provide this as an option in case It probably would, but note that that doesn't do quite the same thing. BOOL values aren't restricted to TRUE/FALSE, so in principle there's no reason "ret" couldn't be e.g. ~0u. You'd need something like "!ret != !ie10_cache" to preserve the original behaviour, but I'm not sure that's really much better.

2 2

Re: winecfg: add all Windows versions and accompanying error message (try 3)
by Andrew Eikum April 12, 2015

April 12, 2015

On Thu, Apr 09, 2015 at 05:42:36PM -0700, Jason Overland wrote: > @@ -399,9 +401,49 @@ static void on_remove_app_click(HWND dialog) > SendMessageW(GetParent(dialog), PSM_CHANGED, (WPARAM) dialog, 0); > } > > +static INT_PTR WINAPI win_ver_error_dlg_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) This function should be guarded by an #ifdef. On my 32-bit build, I get: appdefaults.c:404:90: warning: ‘win_ver_error_dlg_proc’ defined but not used [-Wunused-function] > @@ -159,6 +159,22 @@ BEGIN > COMBOBOX IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP > END > > +IDD_WINVERERROR DIALOGEX 100, 100, 238, 95 > +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "Error: Invalid selection" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LTEXT "This Wine prefix is built to support 64 bit applications. \ > + Because the Windows version you selected does not support 64 bit applications, \ > + this prefix cannot be configured to mimic that version of Windows.", > + IDC_STATIC,5,5,220,40 > + CONTROL "Please refer to \"How do I create a 32 bit wineprefix on a 64 bit system?\" \ > + in the \"Using Wine\" section of the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> \ > + for instructions on how to create a 32 bit Wine prefix.", > + IDC_WIN_VER_TEXT,"SysLink",0,5,40,220,70 For some reason, this renders without a space between "the" and the "Wine FAQ" link. Also half of the last 'x' and the period are cut off. It could be an issue on my system. I'm not very familiar with how RC files work. Other than those issues, it seems to work as intended. Andrew

3 2

Re: wined3d: Load ModelView matrix for glLightfv calls.
by Matteo Bruni April 11, 2015

April 11, 2015

2015-04-11 17:16 GMT+02:00 Joachim Priesner <joachim.priesner(a)web.de>: > Analogous to the light() function in state.c, the correct ModelView matrix > has to be loaded when glLightfv is called. The code to load/restore the > matrix is copied from there. > --- > dlls/wined3d/glsl_shader.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 1a1b6b0..2422982 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -7208,6 +7208,11 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > > context->constant_update_mask |= WINED3D_SHADER_CONST_FFP_MODELVIEW; > > + /* Light settings are affected by the ModelView transform in OpenGL, the View transform in Direct3D. */ > + gl_info->gl_ops.gl.p_glMatrixMode(GL_MODELVIEW); > + gl_info->gl_ops.gl.p_glPushMatrix(); > + gl_info->gl_ops.gl.p_glLoadMatrixf(&state->transforms[WINED3D_TS_VIEW]._11); > + > for (k = 0; k < gl_info->limits.lights; ++k) > { > if (!(light = state->lights[k])) > @@ -7218,6 +7223,8 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > checkGLcall("glLightfv dirn"); > } > > + gl_info->gl_ops.gl.p_glPopMatrix(); > + > for (k = 0; k < gl_info->limits.clipplanes; ++k) > { > if (!isStateDirty(context, STATE_CLIPPLANE(k))) > -- > 1.8.4.5 AFAICS this patch is correct. Thank you Joachim!

1 0

Re: rpcrt4/tests: Fix a minor leak (Valgrind)
by Marvin April 11, 2015

April 11, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12764 Your paranoid android. === wvistau64 (64 bit ndr_marshall) === No test summary line found === w2008s64 (64 bit ndr_marshall) === No test summary line found

1 0

Re: [1/1] dwrite: case insensitive font search
by Nikolay Sivov April 11, 2015

April 11, 2015

On 04/10/2015 10:20 PM, Julius Schwartzenberg wrote: > Running the tests on MS Windows, it turns out that Nikolay Sivov was > correct that it should just be a case insensitive search: > https://www.winehq.org/pipermail/wine-devel/2015-April/107309.html > This allows Samsung Smart View 2.0 to get further with starting up. Hi, Julius. This looks good enough, except subject line needs to be improved a bit to follow a pattern we usually use, something like 'dwrite: Font family lookup should be case-insensitive', but that's not critical at all. Thanks for tracking this down.

1 0

Re: [PATCH 8/9] wined3d: Handle color key dirtification in wined3d_cs_exec_set_texture.
by Henri Verbeet April 10, 2015

April 10, 2015

On 9 April 2015 at 22:48, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h > index eb5c3b0..a888552 100644 > --- a/dlls/wined3d/wined3d_private.h > +++ b/dlls/wined3d/wined3d_private.h > @@ -1068,7 +1068,10 @@ DWORD get_flexible_vertex_size(DWORD d3dvtVertexType) DECLSPEC_HIDDEN; > #define STATE_POINT_SIZE_ENABLE (STATE_FRAMEBUFFER + 1) > #define STATE_IS_POINT_SIZE_ENABLE(a) ((a) == STATE_POINT_SIZE_ENABLE) > > -#define STATE_HIGHEST (STATE_POINT_SIZE_ENABLE) > +#define STATE_COLOR_KEY (STATE_POINT_SIZE_ENABLE + 1) You should handle this in debug_d3dstate() and validate_state_table() as well.

1 0

[RFC] mshtml: Remove nsIDOMWindowUtils::SetCriticalDisplayPortForElement.
by Thomas Faber April 10, 2015

April 10, 2015

Hey Jacek, I just got an MSVC /RTCs stack pointer mismatch error after this call in mshtml's CustomDoc_Release: nsIDOMWindowUtils_CycleCollect(window_utils, NULL, 0); After some investigation I found that the vtable for this class was off by one element. The culprit seems to be SetCriticalDisplayPortForElement. The function got removed here in Gecko: http://sourceforge.net/p/wine/wine-gecko/ci/ed28b621505812d584723bfb389983b… However the latest nsiface.idl in Wine still has it: https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/mshtml/nsiface.idl#l… I did my testing on mshtml 1.7.37 with Wine Gecko 2.34 but it looks like this is still present in the latest code as well. Do you agree with my analysis (i.e. the attached patch) here, or do you think I'm missing something? Thanks! And thanks for maintaining Wine Gecko... this truly opened my eyes to the complexity of that task ;) -Thomas

2 1

Re: [PATCH 2/2] wined3d: Implement color keying in the glsl fragment pipeline (v2).
by Marvin April 10, 2015

April 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12746 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/9] wined3d: Implement color keying in arbfp_blit.
by Matteo Bruni April 10, 2015

April 10, 2015

2015-04-09 22:48 GMT+02:00 Stefan Dösinger <stefan(a)codeweavers.com>: > This intentionally discards on the alpha value. To do a proper color > compare we have to migrate fixed function pipeline color keying and > blits at the same time because the color keying conversion changes the > texture contents and can cause the key not to match. > --- > dlls/wined3d/arb_program_shader.c | 68 +++++++++++++++++++++++++++++++++------ > dlls/wined3d/surface.c | 51 +++++++++++++++++++---------- > dlls/wined3d/swapchain.c | 2 +- > dlls/wined3d/wined3d_private.h | 7 ++-- > 4 files changed, 99 insertions(+), 29 deletions(-) > > diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c > index 79439f5..f740123 100644 > --- a/dlls/wined3d/arb_program_shader.c > +++ b/dlls/wined3d/arb_program_shader.c > @@ -7539,7 +7549,24 @@ static GLuint arbfp_gen_plain_shader(struct arbfp_blit_priv *priv, > GL_EXTCALL(glBindProgramARB(GL_FRAGMENT_PROGRAM_ARB, shader)); > > shader_addline(&buffer, "!!ARBfp1.0\n"); > - shader_addline(&buffer, "TEX result.color, fragment.texcoord[0], texture[0], %s;\n", tex_target); > + > + if (type->use_color_key) > + { > + shader_addline(&buffer, "TEMP color;\n"); > + shader_addline(&buffer, "TEMP compare;\n"); > + shader_addline(&buffer, "PARAM color_key = program.local[%u];\n", ARBFP_BLIT_PARAM_COLOR_KEY); > + shader_addline(&buffer, "TEX color, fragment.texcoord[0], texture[0], %s;\n", tex_target); > + shader_addline(&buffer, "SGE compare.r, color.a, color_key.a;\n"); > + shader_addline(&buffer, "SGE compare.g, -color.a, color_key.a;\n"); > + shader_addline(&buffer, "MUL compare, compare.r, -compare.g;\n"); > + shader_addline(&buffer, "KIL compare;\n"); > + shader_addline(&buffer, "MOV result.color, color;\n"); If you're checking for an exact match, that doesn't look right. You probably want something like: ... SGE compare.r, color.a, color_key.a; SGE compare.g, -color.a, -color_key.a; MUL compare, compare.r, compare.g; ... I might have misunderstood the point of the shader though, if that's the case then ignore this.

2 1

Re: [PATCH 3/4] d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame{1-3}
by Stefan Dösinger April 9, 2015

April 9, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-09 um 16:11 schrieb Aaryaman Vasishta: > +static void test_frame1_qi(void) > +{ > ... > + test_qi("frame_qi", (IUnknown *)frame, &IID_IDirect3DRMFrame, tests, sizeof(tests) / sizeof(*tests)); > ... > +static void test_frame2_qi(void) > +{ > ... > + test_qi("frame_qi", (IUnknown *)frame2, &IID_IDirect3DRMFrame2, tests, sizeof(tests) / sizeof(*tests)); > ... > +static void test_frame3_qi(void) > +{ > ... > + test_qi("frame_qi", (IUnknown *)frame3, &IID_IDirect3DRMFrame3, tests, sizeof(tests) / sizeof(*tests)); With this it won't be possible to find out which test failed if something fails. Please use more informative names for the test_name parameter of test_qi, e.g. "frame1_qi", "frame2_qi" and "frame3_qi". It is a bit unfortunate that you have to duplicate the big structure 3 times. You could in theory share it between the different functions, but then you'd have to lie about which interface you pass to test_qi, and I am not sure if this is nicer. If you can't find a better solution keep it the way it currently is. @Alexandre: The reason why I want to test all interface versions is our experience with ddraw. It has plenty of interface-specific behaviors, some of them depend on which version is called, and some of them depend on which version was used to create the object. (see struct ddraw_surface::version, struct ddraw::version and struct d3d_device::version, as well as various thunks). For this particular test the relevant information is that all interfaces can be queried from all object versions and that there are no refcounting differences, which could be introduced by the presumably aggregated IDirect3DRMObject2 interface. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVJvBaAAoJEN0/YqbEcdMwXYEP/2k4k4qdiGA2sxdv0S6mTaZW RXEPGDY1BqtDyOlw9EzwK+EmQTnE6B4zC25AM55yFAQjaIs8UyAk/TN3b0K+H9xz ZJJIgqGe2x+yIrzKqT70lGqUltYMaENHEw3oh8GdkYnIIK97bG7Y7vK7VZKIDPlh vfxcwG990di77KyPTt3eI4w6BQp4SyyEUxNC5vCy213ML+sF9XjGV+WPkV0UStcX nNCLRcszExminklJgEj4h1S6qcxNVIwJks8vCrgRx9isJfmbK8g5GrAzod3iTSES K1ccZWxGFbXupiT8Je6K5Te6b2PlHZtBVVHb5ndeYQdZJmwZIrTFbE3LjX3o2Vyt m0DvbPzAzNNJO7jREtWVSDXmg2OIaxsaIlMpH+v7VU2csqLNQZCijJ9/q3hN2qLf rYIS7i2fAmWDUoE6uFDOs+VJKDx88OljZaBTV4VFAHYwfeiqr3KXVdYZ3lciViif gjfno0N20inhG/ydjmJOn+tMipj2p1iffHDMaIlXVFhxitTj2Kk/bYp5b65T5q0C dn99clpZKU8xKg8w1I6MQv03CvMla0Z5k5d01H6YCW0YDSHtSnxfXeykxN2PeCGZ wYkTxF/KeSXhg3tLkl7StD1aRJsa5lv98FnJmQA2UWDNlcPfHcvv0Dam8ZsRohEr pPvj1H5GMcaaDGhfCOiZ =Eore -----END PGP SIGNATURE-----

1 0

Re: [PATCH] shell32: Add more knownfolders
by Marvin April 9, 2015

April 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12738 Your paranoid android. === w2000pro (32 bit shellpath) === The test timed out

1 0

Re: TestBot job 11764 results: [1/5] comctl32: Move TaskDialogIndirect function and its test to separate files (try 3)
by Joachim Priesner April 9, 2015

April 9, 2015

Hi all, this patch series (implementing a basic version of TaskDialog/TaskDialogIndirect) has vanished from the patches list without comment. I'd appreciate any hint on what I did wrong. Thanks Joachim Am Donnerstag, 26. Februar 2015 schrieb Marvin: > VM Status Number of test failures > build completed > w2000pro completed 0 > wxppro completed 0 > w2003std completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > w7u completed 0 > w8 completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > w2000pro completed 0 > wxppro completed 0 > w2003std completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > w7u completed 0 > w8 completed 0 > wvistau64 completed 0 > w2008s64 completed 0 > > === build (build) === > No build failures found > > === w2000pro (32 bit taskdialog) === > No test failures found > > === wxppro (32 bit taskdialog) === > No test failures found > > === w2003std (32 bit taskdialog) === > No test failures found > > === wvistau64 (32 bit taskdialog) === > No test failures found > > === w2008s64 (32 bit taskdialog) === > No test failures found > > === w7u (32 bit taskdialog) === > No test failures found > > === w8 (32 bit taskdialog) === > No test failures found > > === wvistau64 (64 bit taskdialog) === > No test failures found > > === w2008s64 (64 bit taskdialog) === > No test failures found > > === w2000pro (32 bit misc) === > No test failures found > > === wxppro (32 bit misc) === > No test failures found > > === w2003std (32 bit misc) === > No test failures found > > === wvistau64 (32 bit misc) === > No test failures found > > === w2008s64 (32 bit misc) === > No test failures found > > === w7u (32 bit misc) === > No test failures found > > === w8 (32 bit misc) === > No test failures found > > === wvistau64 (64 bit misc) === > No test failures found > > === w2008s64 (64 bit misc) === > No test failures found

2 1

Re: dpnet: Convert Address components to use a list
by Stefan Dösinger April 9, 2015

April 9, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-08 um 09:10 schrieb Alistair Leslie-Hughes: > +{ > + if(This->comp_count == This->comp_array_size) > + { > + struct component **temp; > + > + temp = heap_realloc(This->components, sizeof(struct component *) * (This->comp_array_size*2) ); Style hint: You can use sizeof(*temp) here, that way the alloc code doesn't need to be changed when you change the type of temp. This is even more helpful when the declaration of the pointer is in a different file, like in the heap_alloc call that allocates client->components. > + if(This->components) > + { > + This->components[This->comp_count] = item; > + This->comp_count++; > + return TRUE; > + } Can this ever be NULL for a legitimate reason? Note that the heap_realloc call already assumes This->components is not NULL. > @@ -540,8 +596,8 @@ HRESULT DPNET_CreateDirectPlay8Address(IClassFactory *iface, IUnknown *pUnkOuter > > client->IDirectPlay8Address_iface.lpVtbl = &DirectPlay8Address_Vtbl; > client->ref = 1; > - > - list_init(&client->components); > + client->comp_array_size = 4; > + client->components = heap_alloc( sizeof(struct component *) * client->comp_array_size ); Please add error checking here. (The NULL check in add_component doesn't help if this fails. You'll just get a half-working address object where AddComponent always fails) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVJkU+AAoJEN0/YqbEcdMwYRYP/0Vzb0FQDV6xBWc66VFjECxa dSyWsm34yksURXd9H7ayT+cGHQiyfq9dP5MIEL3Lrf7Npiqy7b3DV2NYH1X3foL8 NZoU0R6BSq1XUkqcEWFnXRDIHWs8f0Q1kNyRcUfsuXO4c6vAQOde7CdRtMHuLEy5 DOZjnnSbfAjoKq9Xk3JGJOs1juceoNumojpYE6wtbwDM5Q3Z8DOAdDEvv9qCw9SU Gziuis+LLN2yFDb+cONIKApy/XS/zs2imFS4z/wlKAEu72aGib/64j/d7j48jIxl C7ojDWjWGQj1CDSF6Wn0X80TV5Xjgolgw3ndyPFvqResCk4+UMeoyPaBXLLmozcu VaNtd4sGVTTAe7ivfKVaZx1K0gR8mezsFXEZ2jBfZlTOGHIRiImQ84ORZvahWr7t HYh0ZdDddzNOEbJVAlvxMrB/HLL+ODAOZJaElN6QXyWPBYFIb5AH+VwXeBccahSM xg8xkZLQIPqgDyQaI4TPDCboU5VzptTtl3uKJSy4QX+gV23IFXT9AUnPrWLas+3J qW0pX1tljdTxrVqU3mGvvE3KnUsHyEvx4sBVNWOzEagnSv4TQiabNlkyPfQmJsiH WE/Lx2WTWV9ucLfsGmCNbx+Cu52hDNj1R93hqgpSgAvvUjFeGjxTy4SQFD17ig6M ZFkE66v0L53cG4lQASGw =FqJl -----END PGP SIGNATURE-----

1 0

Re: [1/2] ws2_32/tests: Add tests about retrieving the local address of an interface bound socket
by Marvin April 8, 2015

April 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12730 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

dwrite font family issue
by Julius Schwartzenberg April 8, 2015

April 8, 2015

Hi, On #winehq there was a discussion on Monday as I was trying to get Samsung Smart View 2.0 to run. (DotNOT 4.5 application requiring Windows 7/8.) I would report back on my findings. Anastasius Focht figured it was running into a problem discovering a suitable font (family). Here is a patch I came up with which lets the program continue. I'm not sure whether this is a correct fix however. What is happening is that in 'dlls/dwrite/font.c: collection_find_family' the name argument is completely uppercase. This is then compared to buffer which will contain a similar string at some point but with regular casing. Before that however I see the string passed with its original casing like this: 0009:Call KERNEL32.LCMapStringEx(00000000,00000200,0172c79c L"Arial",00000005,0172c7b4,00000005,00000000,00000000,001908b8) ret=00aaa471 0009:fixme:nls:LCMapStringEx unsupported lparam 1908b8 0009:Ret KERNEL32.LCMapStringEx() retval=00000005 ret=00aaa471 0009:trace:dwrite:dwritefontcollection_FindFamilyName (0x1966e8)->(L"ARIAL" 0x33be0c 0x33be08) I added two TRACE calls myself to print the values of name & buffer which gives: 0009:trace:dwrite:collection_find_family name=L"ARIAL" and later: 0009:trace:dwrite:collection_find_family buffer=L"Arial" The call to KERNEL32.LCMapStringEx may suggest that the casing is actually lost unintentionally. Thanks, Julius

2 1

Re: [PATCH 5/5] wined3d: Set color keys through the command stream.
by Henri Verbeet April 8, 2015

April 8, 2015

On 6 April 2015 at 00:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +#define WINED3D_CKEY_REMOVE 0x80000000 > + It seems unfortunate to define part of the flags in include/wine/wined3d.h and part of the flags in dlls/wined3d/cs.c. You'd probably also want to mask out private flags in wined3d_cs_emit_set_color_key(). Ultimately though, why do you need this? Most of the CS ops operate on a wined3d_state structure, which is mirrored between the CS and the device, and (in theory) functions get passed the appropriate one depending on whether they're running from the CS or not. This one is different in that it operates on a texture, and anything that would need to read the color key would then need to either wait for the texture to become idle, or run from the CS itself. Perhaps that's ok, but it's more of a fundamental design decision than this commit makes it seem.

2 3

Re: [PATCH 2/2] shell32: Add more knownfolders
by Marvin April 8, 2015

April 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12722 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winecfg: improve user experience by adding all Windows versions and accompanying error message
by Jason Overland April 8, 2015

April 8, 2015

Is there anything I can do to improve this patch? Thanks, Jason On 03/26/2015 10:03 PM, Jason Overland wrote: > Hi, > This patch is a resubmission of and supersedes my previous patch "winecfg: add note about 32 bit prefixes to dialog". Thanks to everyone who provided feedback on that one. > > In this patch, winecfg's Application settings tab now includes all Windows versions in the combobox. If the user is running from a 64 bit prefix and selects a version of Windows that requires a 32 bit prefix, the selection will revert to the previous selection and a modal dialog containing an error message will appear: > > """ > This Wine prefix is built to support 64 bit applications. Because the Windows version you selected does not support 64 bit applications, this prefix cannot be configured to mimic that version of Windows. > > Please refer to "How do I create a 32 bit wineprefix on a 64 bit system?" in the "Using Wine" section of the Wine FAQ (http://wiki.winehq.org/FAQ) for instructions on how to create a 32 bit Wine prefix. > """ > > In addition, I noticed two File Open dialogs in winecfg which should be modal but are not modal. I made these modal by setting the appropriate owner window. While a separate issue, this seemed like a trivial enough change to include in this patch. >

3 3

Re: [1/3] ws2_32/tests: Add some more select() related tests
by Marvin April 8, 2015

April 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12715 Your paranoid android. === w7u (32 bit sock) === sock.c:7148: Test failed: bytesReturned isn't supposed to be 1 sock.c:7172: Test failed: GetOverlappedResult failed, error 0

1 0

Re: dinput: Add JoystickID to the Instance Name
by Dmitry Timoshkov April 7, 2015

April 7, 2015

Aric Stewart <aric(a)codeweavers.com> wrote: > + if (SUCCEEDED(IDirectInputDevice2_GetProperty(iface, DIPROP_JOYSTICKID, (LPDIPROPHEADER)&pd))) > + index = pd.dwData; Please find a way to avoid the cast. > + if (SUCCEEDED(IDirectInputDevice2_GetProperty(iface, DIPROP_JOYSTICKID, (LPDIPROPHEADER)&pd))) > + index = pd.dwData; Same here. > + snprintf(buffer, MAX_PATH, "Joystick %d", index); 'index' is unsigned, sizeof() instead of a hardcoded value is better. -- Dmitry.

1 0

Problem receiving UDP broadcast on wxppro and w2008s64
by Bruno Jesus April 7, 2015

April 7, 2015

Hi, Francois, I hope you can help me in this situation. The patch attached to bug 31994 [1] (compiled version at [2]) runs fine in most testbot machines (tested dozens of times) and my personal XP machine, but for some reason it doesn't work in xppro and w2008s64. The test creates 2 UDP sockets and send a broadcast from socket A to the network where B is bound, but the broadcasted packet never is received by B resulting in test timeout due to recvfrom never getting data. According to [3] all testbots share similar IP addresses like and I can't imagine a reason for them not to work: wxppro: testing broadcast for interface IP 10.42.42.134 (don't work) w2003std: testing broadcast for interface IP 10.42.42.140 (works) wvistau64: testing broadcast for interface IP 10.42.42.138 (works) w2008s64: testing broadcast for interface IP 10.42.42.216 (don't work) Any ideas? I wonder if it could be a firewall. The test also works fine in NT4. [1] https://bugs.winehq.org/attachment.cgi?id=51182 [2] https://testbot.winehq.org/GetFile.pl?JobKey=12594&StepKey=1 [3] https://testbot.winehq.org/JobDetails.pl?Key=12591 Best Regards, Bruno

2 5

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL (plus test fix)
by Marvin April 7, 2015

April 7, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12697 Your paranoid android. === w2000pro (32 bit locale) === locale.c:1776: Test failed: Without NORM_STOP_ON_NULL flag - strings `don\0a` (5) and `don\0b` (5) expected CSTR_LESS_THAN, got 2

1 0

CoInternetParseUrl and concepts explanation.
by Philippe Groarke April 6, 2015

April 6, 2015

Hello, I am currently exploring Wine code base looking for low hanging fruits I can contribute to. I think CoInternetParseUrl and other URLMon stubs seemed easy enough I want to try and implement some. I also see many URLMon stubs when using Wine for games and applications. In CoInternetParseUrl, you use a switch case depending on the parameters passed. These in turn call specific methods for each parameter, which most do the same thing, call IInternetProtocolInfo_ParseUrl with the desired parse option . This function is defined in urlmon header. It seems to call a saved This on runtime, derefencing a saved (?) virtual table calling ParseUrl. It is also implemented in the header (static FORCEINLINE) and also calls the ParseUrl. There are some STDMETHODCALLTYPE pure virtual methods inside a IInternetProtocoleInfo class. A struct virtual table IInternetProtocolInfoVtbl O_o I cannot find the actual ParseUrl implementation, though in misc.c, there are many references to CHECK_CALLED(ParseUrl) and SET_EXPECT(ParseUrl). I have no clue what is going on here to be completely honest. Finally, in misc.c there are some pCoInternetParseUrl and CoInternetParseUrl tests. But nothing that seems to implement what I need. My question is, why go through all these hoops instead of implementing CoInternetParseUrl inside internet.c. I am sure there is good reasoning behind this, I would just like to understand why. Also, where do I implement ParseUrl or IInternetProtocolInfo_ParseUrl? Thank you for any help in understanding what is going on here. Good day, Philippe

2 1

Re: [PATCH 2/4] ntdll/test: Add ntdll test function test_file_full_size_information
by Nikolay Sivov April 5, 2015

April 5, 2015

On 04.04.2015 10:03, Jianqiu Zhang wrote: > + trace("TotalAllocationUnits %08x %08x\n", fsi.TotalAllocationUnits.HighPart, fsi.TotalAllocationUnits.LowPart); > + trace("CallerAvailableAllocationUnits %08x %08x\n", fsi.CallerAvailableAllocationUnits.HighPart, fsi.CallerAvailableAllocationUnits.LowPart); > + trace("ActualAvailableAllocationUnits %08x %08x\n", fsi.ActualAvailableAllocationUnits.HighPart, fsi.ActualAvailableAllocationUnits.LowPart); > + trace("SectorsPerAllocationUnit %08x\n", fsi.SectorsPerAllocationUnit); > + trace("BytesPerSector %08x\n", fsi.BytesPerSector); > + Hi, Jianqiu. This is not exactly a test, as you're just printing a result. Same thing with patch 3/4. Also to print LONGLONG values you use wine_dbgstr_longlong() probably.

2 3

Re: [PATCH 1/2] ws2_32: Fix compile on OS X.
by Bruno Jesus April 5, 2015

April 5, 2015

On Sun, Apr 5, 2015 at 4:07 PM, Socapex <philippe.groarke(a)gmail.com> wrote: > If HAS_IPX isn't defined, compilation will throw error since > WS_IPX_* aren't declared. > --- > dlls/ws2_32/socket.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 09c8416..bc4d40a 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -365,6 +365,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKLEVEL(WS_NSPROTO_IPX); > switch(optname) > { > +#ifdef HAS_IPX > DEBUG_SOCKOPT(WS_IPX_PTYPE); > DEBUG_SOCKOPT(WS_IPX_FILTERPTYPE); > DEBUG_SOCKOPT(WS_IPX_DSTYPE); > @@ -372,6 +373,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKOPT(WS_IPX_MAXSIZE); > DEBUG_SOCKOPT(WS_IPX_ADDRESS); > DEBUG_SOCKOPT(WS_IPX_MAX_ADAPTER_NUM); > +#endif > } > break; Hi, unfortunately I don't have OSX so I only test my patches in Linux and FreeBSD, so sometimes these problems happen, sorry. I think it's better to simply remove the #ifdef around wsnwlink.h [1], this will not reduce the debug capabilities of debugstr_sockopt. Since wsnwlink.h is an internal include it will always be available, can you it, please? [1] From socket.c: 160 #ifdef HAS_IPX 161 # include "wsnwlink.h" 162 #endif Best Regards, Bruno

2 1

Re: [PATCH 2/2] ws2_32: Remove trailing white-spaces.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-04-05 um 21:07 schrieb Socapex: > -/* Note: EAI_NODATA is deprecated, but still > +/* Note: EAI_NODATA is deprecated, but still Generally we don't commit whitespace-only changes because they cause problems with git blame (though git blame has been improved in that regard) and merges. Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIYsNAAoJEN0/YqbEcdMwLUEP/jy+kbilEFxb+W5HrbvV5x4Y GKTrrE0sBYv3RmcLEdCEmivTt5BOHerIxmoy5Li2wsH/S1FglwcdVETTBBG9v8tV 0dEgJ/p3GAB8RPQTRtvHTyr5aiUqOQg0HNW08puy/OHF3Zr3BTiFfzNLfKcVRTj5 Vvp28AwThDTqjG85ajOezBfxw/H6g4D8GtmsETYr2NYQZD9lt+C28op9K5hxSuA9 E05Af00Rxye7qb8ry715cAbBg2nO/MDygRt5iYpCX6Rd8fmRuM5O27MJLDQkq/pU GDKilQuWmiwZPEQcs3PKbOql3xditgvLrGKk4jkYAiXfTtaxIvwz9GDA6KVXynom Hv/m2BFKV1odoBYkDWlZZ42XVj1aZFKFZIknVTddDoRN/AVfTBO3cz5TPWOwr0q3 jGWOBT31ksWStdXOaQsPyUjX7ZKws2T2ZTRZTKoY0o/c/LYAXIgqz0VNwVnVaIs2 x+xlrdEpg58E1JuLBL93F0z3Pe+YQXqdv3RhWNSgzosK3VmaEC8+GzWBUR8gQMlJ UW0WRSycE9AktMGJv1+Grf/PIk8pHRN+4veL4065M5a4jaeclghx/HxqswuI8WCV Ty1qe5eHeNbD/9cEzbRSHBOV5g/V+xmvgzY5M0DJ2TTSMchmkJzC00m0khRMWhaj JMLgp7jnoWasLLA2ufZH =MEUF -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] ws2_32: Fix compile on OS X.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, You have to use your real name, not a nickname. We need this to be able to show where our code comes from. With best regards, Stefan Am 2015-04-05 um 21:07 schrieb Socapex: > If HAS_IPX isn't defined, compilation will throw error since > WS_IPX_* aren't declared. > --- > dlls/ws2_32/socket.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 09c8416..bc4d40a 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -365,6 +365,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKLEVEL(WS_NSPROTO_IPX); > switch(optname) > { > +#ifdef HAS_IPX > DEBUG_SOCKOPT(WS_IPX_PTYPE); > DEBUG_SOCKOPT(WS_IPX_FILTERPTYPE); > DEBUG_SOCKOPT(WS_IPX_DSTYPE); > @@ -372,6 +373,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKOPT(WS_IPX_MAXSIZE); > DEBUG_SOCKOPT(WS_IPX_ADDRESS); > DEBUG_SOCKOPT(WS_IPX_MAX_ADAPTER_NUM); > +#endif > } > break; > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIYmzAAoJEN0/YqbEcdMwmcMP/0UWQMONOFklXHtI9ibTn5rU Y8idfpQRQEj7s4UqKT5XdHbbGsmGa24byBybhWf54z/ykTqcwvcun4xDUs0/pmCK WRWx9hlgGd4xPSGrnum9XC/tnywjyP5s8eyRUU4CeMmBOIwauj15iePd/v4W+BA+ iHTyY4rjzyoyatmZURoaZaFFj/n5cLoqyqQ+fTNeP22z+Wjl7N76wXYbsylRsatB NKe8bAdBAQZL8LNngjpCVXW0PsKaH88LIdVPZpvI0T+hH8+LYRToKbfqCXtwkwYb LuE9RCdfAcRbIQTCe4FrpfduGUtQN2Nlxu7pIOH9GghWITTjIZn/XV0VYSBVDrNc d2zZ0lmyEWPU6H5RU/dzfhkJMhKP7RzZkd3j7yDKsjBlC651ysDT6ev/HpX2Jx7O aYf70/48Qk5BhbEZblQuPrssz/p4ErXHz2UQRGodqLjJm+ATSwkSlwsAGZ8iyjn0 3JQuL3BDDSF3CAjfQBLfcRXS4tNgNd58rr5dfoLmOhkKG+LIbYIQ55104UG03xDc 5LFubLU8i8r89OBR3yeZXLIX3BdR3oxANVDoPjjbbJiAKIoej5yJOCyLb8cPbchN CufNxeiY+wrKNWtuW6UXONaEJqt2MpcY0HUV70s9qRXZ2iZoPKDFkR5mPudR7qbj ZIUAqSKGQcWwmCw+aEk+ =ShND -----END PGP SIGNATURE-----

1 0

Re: [PATCH 3/3] d3drm/tests: Split tests between different versions, initially adding frame QueryInterface tests.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, This series looks good to me, and this time I ran the tests on Windows and Wine :-) Am 2015-04-03 um 14:25 schrieb Aaryaman Vasishta: > +struct qi_test > +{ > + REFIID iid; > + REFIID refcount_iid; > + HRESULT hr; > + BOOL refcount_todo; > +}; refcount_todo is always FALSE in your tables, so you might as well remove it. I don't think it's necessary to resend the patch because of that though. You can just remove it when you add the vtable inheritance test. If you expect future tests to need refcount_todo you can also keep the field. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIWyeAAoJEN0/YqbEcdMwZPgP/AoYCerTMFiXH9lYnmueThK/ UPGcBOLhdU0dT0U8lI0ZVzX7mbvtvjoVFUn/cAGgBZTUH175BK3SHbuIljJ+R954 +xQtRda5QrEu759UIkuc6v+REUtNQWzPtWLRX8EhZLhTEJaTEdsGeGUKAKRwGFmc UsMEff5r1gIIFgFDSlwSm1daAduOwkNcnzFwbxTbm7Kg/qCn50nSTfWj4Nk/sYYl kr6vzKH5EAt5nL9tvtXT7q8YDu+e2TC96B2xzoseRnS3st44nAgqjSb9E7fB05Cu Lem/zEEoGJI3mrLWpoDVDoYFFaHPifoqRgyf6EcT9ID0vUmJhM97WgBWw0+b8fFR yxJ/nsBol56Rb4xssOrXINDfF2E+7S9RMu/oxSbVbW8GV3vN4ssgZ5/Q8itmCdJd u7Kyfx/OS72xE9rrUXIQrS0EM7yFq1j6cZa/xv6xGzO0SpeIbWrB2Pnujvr5GTt/ KkPqJVoiFr8VOaZfK2SQreGTaBK4f6rDdW+jkfnQLU38uVSmDTowdO3oD6aPCy2s mgB8JmhBuDsU5RAWoA61PzTtDPmdWLhmHZJWfLC4PG9/IN0m3G3JhFUAUy3qr8UZ 543kGtR21tmPHLKXc+Bt20B0j+RY0sxu8CvVJPb3qa7VmDP+c3thnjkgng1ZJo0F CrXo+6/IKapzItlvTFIE =ssTG -----END PGP SIGNATURE-----

1 0

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL (marvins test fix)
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12662 Your paranoid android. === w2000pro (32 bit locale) === locale.c:1776: Test failed: Without NORM_STOP_ON_NULL flag - strings `don\0a` (5) and `don\0b` (5) expected CSTR_LESS_THAN, got 2 === wvistau64 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w7u (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w8 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === wvistau64 (64 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (64 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0

1 0

Re: [PATCH 1/7] advapi32: Initialize buffer length to zero in LsaLookupSids to prevent crash.
by Nikolay Sivov April 4, 2015

April 4, 2015

On 04.04.2015 17:22, Qian Hong wrote: > > (*Names)[i].Name.Buffer = NULL; > + (*Names)[i].Name.Length = 0; > + (*Names)[i].Name.MaximumLength = 0; Maybe it's better to hide this in RtlInitUnicodeStringEx(..., NULL) ?

2 1

Re: mshtml: Removed return to ensure AddRef is called on an internal interface
by Piotr Caban April 4, 2015

April 4, 2015

The patch is wrong, nsCycleCollectionISupports doesn't support AddRef/Release.

4 6

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12661 Your paranoid android. === wvistau64 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w7u (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w8 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === wvistau64 (64 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (64 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0

1 0

Re: [PATCH 7/7] advapi32/tests: Add more tests for LsaLookupSids and LsaLookupNames2.
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12659 Your paranoid android. === w2003std (32 bit lsa) === lsa: unhandled exception c0000005 at 7C81BB52 === wvistau64 (64 bit lsa) === No test summary line found === w2008s64 (64 bit lsa) === No test summary line found

1 0

Re: msxml3: Explicitly list acceptable libxml2->msxml node types for unknode (try 2)
by Jacek Caban April 4, 2015

April 4, 2015

Hi Nikolay, On 01/04/15 22:41, Nikolay Sivov wrote: > + switch (This->node.node->type) > + { > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + case XML_TEXT_NODE: > + case XML_CDATA_SECTION_NODE: > + case XML_ENTITY_REF_NODE: > + case XML_ENTITY_NODE: > + case XML_PI_NODE: > + case XML_COMMENT_NODE: > + case XML_DOCUMENT_NODE: > + case XML_DOCUMENT_TYPE_NODE: > + case XML_DOCUMENT_FRAG_NODE: > + case XML_NOTATION_NODE: Most of those types have their own IXMLDOMNode implementations, so they should never be the case in here. Also, ideally we shouldn't even create unknode object for types that are not supported, so it should be fixed in create_node or its callers. Is it possible in the case that you're fixing? Jacek

2 1

Re: [PATCH 3/4] ntdll/test: Add test_file_size_information
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12656 Your paranoid android. === w8 (32 bit file) === file.c:397: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

Re: ntdll: Return STATUS_SUCCESS from SetInformationJobObject
by Nikolay Sivov April 4, 2015

April 4, 2015

I don't think it's a good idea to always claim success. It might be better to actually store those UILIMIT flags (probably by extending set_job_limits ). Alternatively if you don't want to store those for some reason you can return success for this class only while keeping a fixme, but not for all unimplemented classes.

2 1

Re: [PATCH 2/4] ntdll/test: Add ntdll test function test_file_full_size_information
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12655 Your paranoid android. === w8 (32 bit file) === file.c:397: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

Re: [PATCH] gdiplus: Avoid unnecessary pre-multiplied alpha conversions in GdipDrawImagePointsRect
by Vincent Povirk April 3, 2015

April 3, 2015

Looks good to me.

1 0

Re: [PATCH] comctl32: Do not resize windows when giving an updown control the same buddy.
by Anton Baskanov April 3, 2015

April 3, 2015

Hello! Have you verified this behavior on native comctl32? I've tried to send UDM_SETBUDDY with the same HWND repeatedly, and the buddy is resized every time. I've tested it on Windows 7 x64 with both version 5 and 6 of comctl32. On Wed, Apr 1, 2015 at 4:02 AM, Mark Harmstone <hellas(a)burntcomma.com> wrote: > When an updown control receives UDM_SETBUDDY with the HWND of its existing > buddy, it should do nothing. At present Wine resizes the buddy as it > would do initially, resulting in the textbox getting progressively smaller > every time UDM_SETBUDDY is sent. > > --- > dlls/comctl32/updown.c | 3 +++ > 1 file changed, 3 insertions(+) > > > > >

2 2

Re: [PATCH 4/4] d3drm/tests: Add vtable comparison tests in test_frame_qi
by Stefan Dösinger April 3, 2015

April 3, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-02 um 18:36 schrieb Aaryaman Vasishta: > REFIID iid; > REFIID refcount_iid; > + REFIID vtable_iid; > HRESULT hr; > BOOL refcount_todo; > + BOOL vtable_equal; > + BOOL vtable_todo; > }; I think this is more complicated than it needs to be. All you should need is the vtable_iid field. Then, in the inner loop do something like if (IsEqualGUID(tests[i].vtable_iid, tests[j].vtable_iid)) ok(iface1 == iface2, ...); else ok(iface1 != iface2, ...); I may be missing something though. If you want to compare two Win32 BOOLs for equality you have to be careful: BOOL a = 1; BOOL b = 2; if (a) printf("this is true.\n"); if (b) printf("this is also true.\n"); if (a == b) printf("oops, this is false.\n"); For something like that you can use if (!a == !b) printf("yay, this is true!\n"); IsEqualGUID(a, b) is defined as !memcmp(a, b, sizeof(GUID)), so IsEqualGUID() == (ptr1 == ptr2) should be OK though. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHakvAAoJEN0/YqbEcdMwPPYP/08CiwYXURzl7Ias7EKvZGO8 QlYjp4CSEorj44LMOMPMELbN+50NJOngxhXA0mecIhZYA9Dgd5NZtVvDWBIPPu/B tXe+0+Xw/EvzubfzMYjOX5/lOKm400CW3fPEbxwYrzdFOSmeNhclZpfD+9jjuekG Lj2XUSk/TAi1B8NlD0x0LE7P6gGb61rg7jeJNZGgfPYMsuAoB2OtekvbIvpbCZmb 3WlOXtzmqVMHjsEsw47i8pdL/DwCFFfpE0xWWdhfgCChFUG/Ul/V56ltN5ERtudO j+jKtY5oNhunIyALwIifwhYNq/bY9CdfovIOI7sNfM3bXwSCZGEk+5Oq3/dnd4rP /Ejp+Kd5xk4SDMC3kyE6VucZkyFD58plgEDNlgSXx2ND/o3Mw91PTDaGj5xT0Fy1 Enk6oqORgXQhvtUaDH5Y5rOyh+AMquWhhN5N43ymT0UW40D4b6UBNSSwuQeqKaxS d1CqkbjUcivIBVd1k8GiuXEgjaEvwMlv8kPj1FGu/GCoMeyoRy7mXN1NOapPdFVu Gz2e8xR8Bri7oglvsS25i6gjYeYvP8qhTcc8tKBU2tr6MHFN3sUkuOZwtLKJLirc NxdSzaylgVGpCFQ0cwNSjm+eY0WvBd4eLychal+cs2plMmMAkYVTLDRBC4ZReCkw KIL1cdIMHQIZSSrDu22h =tKFs -----END PGP SIGNATURE-----

2 2

Re: kernel32: Stub out GetFileMUIPath.
by Nikolay Sivov April 3, 2015

April 3, 2015

> +@ stdcall GetFileMUIPath(long ptr ptr ptr ptr ptr ptr) Second and third arguments should be 'wstr'.

1 0

Re: advapi32: Handle NULL DACL in SetSecurityInfo
by Sebastian Lackner April 3, 2015

April 3, 2015

On 02.04.2015 17:20, Piotr Caban wrote: > --- > dlls/advapi32/security.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > It doesn't match the Windows behaviour, please add at least a couple of tests. https://newtestbot.winehq.org/JobDetails.pl?Key=12622&log_204=1#k204

3 4

Re: user32/tests: Avoid side-effect in an assert.
by Marvin April 3, 2015

April 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12631 Your paranoid android. === wvistau64 (32 bit win) === win.c:7487: Test failed: didn't get start_event in.c:7429: Test failed: button under static window didn't get WM_LBUTTONUP

1 0

Re: [1/3] server: Allow to open a directory without any permission bits.
by Piotr Caban April 2, 2015

April 2, 2015

On 04/02/15 09:42, Sebastian Lackner wrote: > Its a bit ugly, but probably the best solution to workaround the restrictions of the unix api. ;) There's similar problem with regular files (not directories). The owner should be able to read/write permissions. Also is there any need for unix_fd in this case? Thanks, Piotr

2 1

Re: [PATCH 3/4] d3drm/tests: Split tests between different versions, initially adding frame QueryInterface tests
by Stefan Dösinger April 2, 2015

April 2, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, There are a few more issues: Am 2015-04-02 um 18:36 schrieb Aaryaman Vasishta: > + * Copyright 2012 Andr� Hentschel > + * Copyright 2011-2014 Henri Verbeet for CodeWeavers The encoding is still messed up. Is there any code you have taken from the other file? test_qi() is from dlls/ddraw/tests/ddraw*.c, so you should keep Henri's line. Taking along all the Copyright lines if you take something from an existing file is a safe choice though. Also, you should still fix your editor settings anyways. You can add your own name there if you want. (Fwiw, I don't know why we're maintaining these lines at all. The last thing I heard was that they don't have any legal meaning anyway. Also, git keep track of authorship pretty well.) > +#define CHECK_REFCOUNT(obj,rc) \ > + { \ > + int rc_new = rc; \ > + int count = get_refcount((IUnknown *)obj); \ > + ok(count == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, count); \ > + } Do you need this? You're using this in one place as far as I can see, you can also just use the get_refcount() and ok() calls directly. > +static int get_refcount(IUnknown *object) > +{ > + IUnknown_AddRef(object); > + return IUnknown_Release(object); > +} Refcounts are ULONG. > + hr = IDirect3DRM_CreateFrame(d3drm, NULL, &frame); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame3 interface (hr = %x)\n", hr); The string is a bit misleading, I think something like "Failed to create frame" is better. Not a big issue though. The same applies to d3drm2.c and d3drm3.c -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHaNRAAoJEN0/YqbEcdMwZsAP/RvHLPjullG+tQC+JOZvzGDg nm2CZanwOzmC8ZEvWpXKxhCUjTIVUu0XB7yV33BgPywgRKBUUXkqEuGN+Z/wk7Lm rqNuPx17nPHL7aKjw9DxU3QP75t7RbFxU6N3Wz3Veoi+ox4xwxwmrIxRMkFNtxhv tPREjNp9yQVO79ZlLzI1VzeMVnTHKgVn/L+s68nADUkcBFrQaH6SBhB232utwbtp DdkwYOWCK0xGweaLAkt33X2Qhp+qbdtQjIoK/UZvq190owrW2tC2ORnIFhB/7zDR +FrpGzwGuTnhVocrLYCtVtB1RW5t0QealNjhlwv9HI03NSi/J7MmcwGOIE3TIatm TCCDvp034+EMThEvTDODATbYyihbgihG/jjiaQwznu+A66N9lOvhKRCbiasTjTym X06ti98dmpq9BwMd+8sRVe+U1zi9nRmGqvrcncmxUyZ1QoFdrDWFEpRog1jJvaho 8zO9NIzwsG839bqRyZIyZ0DvteaGXD7o907Nkr7aDt4jMjUmuj0ij+nrDvif9kTJ 5WOppUgN7JN4HhWNo4y5i3jei8X2TDDI9z76Juiv1DM0cbWbr2UTHSvFRysPiqGT vCg+boC2pZd94vQKnMYbyAg+06KDneZwiNYBVQpirY3Bua7PY7TwxkBgXQfh2sNv B2fjxmZVRMB3dWylqJmg =wYMH -----END PGP SIGNATURE-----

2 1

Re: [PATCH] undefined symbols compiling for macosx >10.8
by Ken Thomases April 2, 2015

April 2, 2015

That symbol is in the 10.8 SDK. We build against that SDK all the time. It works fine. Here's the documentation for that function: <https://developer.apple.com/library/mac/documentation/Security/Reference/se…>. Notice that under Availability it says, "Available in OS X v10.8 and later." Here is the declaration from Security.framework/Headers/SecureTransport.h: ---------- OSStatus SSLGetProtocolVersionMax (SSLContextRef context, SSLProtocol *maxVersion) __OSX_AVAILABLE_STARTING(__MAC_10_8, __IPHONE_5_0); ---------- Notice the __MAC_10_8 identifier in the __OSX_AVAILABLE_STARTING() decorator. You need to fix your build environment and/or your build commands. Whatever problem you're encountering while trying to build is specific to your system. -Ken On Apr 2, 2015, at 11:58 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Your proposition that SDK10.8 contains the symbol is wrong > —— > #if MAC_OS_X_VERSION_MAX_ALLOWED >= 1080 > +#ifdef SSLGetProtocolVersionMax > if(SSLGetProtocolVersionMax != NULL) { > ---- > > On 01 апр. 2015 г., at 21:36, Ken Thomases <ken(a)codeweavers.com> wrote: > >> If you were having problems building Wine without this patch, then you have a system configuration problem. Or you're configuring Wine incorrectly. >> >> -Ken >> >> On Apr 1, 2015, at 11:52 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: >> >>> Sorry but I committed the patch make me compilation be possible. >>> >>> On 01 апр. 2015 г., at 18:34, Ken Thomases <ken(a)codeweavers.com> wrote: >>> >>>> Hi, >>>> >>>> This patch makes no sense. Wine builds just fine for OS X versions greater than 10.8. Indeed, as near as I know, it still builds just fine for 10.5 and up (the Mac driver requires 10.6 or later, but on 10.5 it just will be skipped; it won't break anything). >>>> >>>> On Apr 1, 2015, at 6:48 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: >>>> >>>>> Undefined symbols for architecture i386: >>>>> "_kCGDisplayShowDuplicateLowResolutionModes", referenced from: >>>>> -[WineApplicationController modeMatchingMode:forDisplay:] in cocoa_app.o >>>>> ld: symbol(s) not found for architecture i386 >>>> >>>> If you're getting this error, you're not building against a 10.8+ SDK properly. The compiler is seeing the headers for a 10.8+ SDK but the linker is seeing libraries and frameworks from some pre-10.8 SDK. >>>> >>>> >>>>> Instead of checking for NULL we should check #ifdef >>>> >>>> No. The things being tested are not macros in any version of the SDK. Your #ifdef checks will never pass. You have effectively done "#if 0". >>>> >>>> Finally, changes to separate DLLs (secur32 and winemac.drv, in this case) should be in separate patches unless they are inter-dependent. >>>> >>>> -Ken >>>> >>> >> >

1 0

Re: [PATCH] vbscript: Fixed Hex(try 3)
by Marvin April 2, 2015

April 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12612 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [1/4] windowscodecs: Add test for PNG gAMA metadata.
by Vincent Povirk April 2, 2015

April 2, 2015

I forgot to NULL-terminate a string, please ignore. On Wed, Apr 1, 2015 at 5:24 PM, Vincent Povirk <madewokherd(a)gmail.com> wrote: >

1 0

Re: [PATCH] findstr: Added test for findstr. (try 2)
by Kaipeng Zeng April 2, 2015

April 2, 2015

Excuse me,can anyone have a look at this patch? I appreciate for any comment. Thanks！ 2015-03-24 13:55 GMT+08:00 Kaipeng Zeng <kaipeng94(a)gmail.com>: > Thanks Stefan! > > Superseded patch 110143 . > ChangeLog: > - Exclude change to configure > - Return exit code of findstr in runcmd() >

2 1

Re: [1/3] server: Implement job limit flags (try 2)
by Nikolay Sivov April 2, 2015

April 2, 2015

On 02.04.2015 10:38, Andrew Cook wrote: > Changes in try 2: > - Removed the goto in SetInformationJobObject, ExtendedLimit will need its own > wineserver call eventually anyway I don't think you'll need a separate server call for extended info case. All fields should be enabled with flags, so you don't have to invent special values to ignore some limits. > + switch (class) > + { > + > + case JobObjectExtendedLimitInformation: > + if (len != sizeof(JOBOBJECT_EXTENDED_LIMIT_INFORMATION)) > + return STATUS_INVALID_PARAMETER; > + > + basic_limit = &(((JOBOBJECT_EXTENDED_LIMIT_INFORMATION *)info)->BasicLimitInformation); > + if (basic_limit->LimitFlags & ~JOB_OBJECT_EXTENDED_LIMIT_VALID_FLAGS) > + return STATUS_INVALID_PARAMETER; > + > + SERVER_START_REQ( job_set_limits ) > + { > + req->handle = wine_server_obj_handle( handle ); > + req->limit_flags = basic_limit->LimitFlags; > + status = wine_server_call( req ); > + } > + SERVER_END_REQ; > + break; This still looks strange, if you need only flags you can use switch() to prepare this flags value depending on info class, and handle invalid arguments same way you do know, no need to duplicate server calling block. Actually since extended info contains basic info you only need a switch() to test for invalid arguments, and you can cast unconditionally to JOBOBJECT_BASIC_LIMIT_INFORMATION* to get flags.

1 0

Re: [1/3] server: Implement job limit flags
by Alexandre Julliard April 2, 2015

April 2, 2015

Andrew Cook <ariscop(a)gmail.com> writes: > + switch (class) > + { > + > + case JobObjectExtendedLimitInformation: > + if (len != sizeof(JOBOBJECT_EXTENDED_LIMIT_INFORMATION)) > + return STATUS_INVALID_PARAMETER; > + > + basic_limit = &(((JOBOBJECT_EXTENDED_LIMIT_INFORMATION *)info)->BasicLimitInformation); > + if (basic_limit->LimitFlags & ~JOB_OBJECT_EXTENDED_LIMIT_VALID_FLAGS) > + return STATUS_INVALID_PARAMETER; > + > + goto set_basic_limits; > + > + case JobObjectBasicLimitInformation: > + if (len != sizeof(JOBOBJECT_BASIC_LIMIT_INFORMATION)) > + return STATUS_INVALID_PARAMETER; > + > + basic_limit = info; > + if (basic_limit->LimitFlags & ~JOB_OBJECT_BASIC_LIMIT_VALID_FLAGS) > + return STATUS_INVALID_PARAMETER; > + > + set_basic_limits: > + SERVER_START_REQ( set_job_limits ) > + { > + req->handle = wine_server_obj_handle( handle ); > + req->limit_flags = basic_limit->LimitFlags; > + status = wine_server_call( req ); > + } > + SERVER_END_REQ; > + break; A goto target in the middle of a switch statement is not very nice, please try to find a better way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msctf: Always return FALSE in DllCanUnloadNow
by Sebastian Lackner April 2, 2015

April 2, 2015

On 02.04.2015 03:34, Alistair Leslie-Hughes wrote: > Hi, > Fixes https://bugs.winehq.org/show_bug.cgi?id=31579 > > Changelog: > msctf: Always return FALSE in DllCanUnloadNow > > > Best Regards > Alistair Leslie-Hughes > > > I doubt that the patch has any real disadvantage, but wouldn't it be better to fix the refcounting instead of just removing this feature? Qian Hong even attached a suggested patch on the bugreport.

3 2

Re: comctl32/tests: Fix couple of metrics tests that fail on some systems (try 3)
by Marvin April 2, 2015

April 2, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12601 Your paranoid android. === wvistau64 (32 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (32 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7u (32 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

2 1

Re: [PATCH (try2)] gdiplus: Avoid unnecessary pre-multiplied alpha conversions in GdipDrawImagePointsRect
by Vincent Povirk April 1, 2015

April 1, 2015

I think we also need resample_bitmap_pixel to be set up to handle PARGB. Nearest neighbor interpolation should work OK as is, but bilinear interpolation uses blend_colors which only works correctly for ARGB. (The implementation of blend_colors that we had before 9c579023f0750539bdf7815f8545c4620540387a should actually be correct for PARGB.) On Wed, Apr 1, 2015 at 11:38 AM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > Not all of the operations we perform in the DrawImage family need to > be post-multiplied. We can avoid doing a pre-to-post-multiplied alpha > conversion by detecting whether we need post-multiplied ahead of time. > Avoiding this conversion saves considerable time, about 3/1000s in my > particular test case. > > --- > > try2: Fix return value from color_over_fgpremult > > dlls/gdiplus/gdiplus_private.h | 20 +++++++++++++ > dlls/gdiplus/graphics.c | 66 ++++++++++++++++++++++++++++-------------- > 2 files changed, 65 insertions(+), 21 deletions(-) > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 065f5ed..57b3de3 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -121,6 +121,26 @@ static inline ARGB color_over(ARGB bg, ARGB fg) > return (a<<24)|(r<<16)|(g<<8)|b; > } > > +/* fg is premult, bg and return value are not */ > +static inline ARGB color_over_fgpremult(ARGB bg, ARGB fg) > +{ > + BYTE b, g, r, a; > + BYTE bg_alpha, fg_alpha; > + > + fg_alpha = (fg>>24)&0xff; > + > + if (fg_alpha == 0) return bg; > + > + bg_alpha = (((bg>>24)&0xff) * (0xff-fg_alpha)) / 0xff; > + > + a = bg_alpha + fg_alpha; > + b = ((bg&0xff)*bg_alpha + (fg&0xff)*0xff)/a; > + g = (((bg>>8)&0xff)*bg_alpha + ((fg>>8)&0xff)*0xff)/a; > + r = (((bg>>16)&0xff)*bg_alpha + ((fg>>16)&0xff)*0xff)/a; > + > + return (a<<24)|(r<<16)|(g<<8)|b; > +} > + > extern const char *debugstr_rectf(const RectF* rc) DECLSPEC_HIDDEN; > > extern const char *debugstr_pointf(const PointF* pt) DECLSPEC_HIDDEN; > diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c > index 580390f..89c108e 100644 > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -354,9 +354,9 @@ static GpStatus get_clip_hrgn(GpGraphics *graphics, HRGN *hrgn) > return GdipGetRegionHRgn(graphics->clip, NULL, hrgn); > } > > -/* Draw non-premultiplied ARGB data to the given graphics object */ > +/* Draw ARGB data to the given graphics object */ > static GpStatus alpha_blend_bmp_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, > - const BYTE *src, INT src_width, INT src_height, INT src_stride) > + const BYTE *src, INT src_width, INT src_height, INT src_stride, const PixelFormat fmt) > { > GpBitmap *dst_bitmap = (GpBitmap*)graphics->image; > INT x, y; > @@ -372,7 +372,10 @@ static GpStatus alpha_blend_bmp_pixels(GpGraphics *graphics, INT dst_x, INT dst_ > continue; > > GdipBitmapGetPixel(dst_bitmap, x+dst_x, y+dst_y, &dst_color); > - GdipBitmapSetPixel(dst_bitmap, x+dst_x, y+dst_y, color_over(dst_color, src_color)); > + if (fmt & PixelFormatPAlpha) > + GdipBitmapSetPixel(dst_bitmap, x+dst_x, y+dst_y, color_over_fgpremult(dst_color, src_color)); > + else > + GdipBitmapSetPixel(dst_bitmap, x+dst_x, y+dst_y, color_over(dst_color, src_color)); > } > } > > @@ -380,7 +383,7 @@ static GpStatus alpha_blend_bmp_pixels(GpGraphics *graphics, INT dst_x, INT dst_ > } > > static GpStatus alpha_blend_hdc_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, > - const BYTE *src, INT src_width, INT src_height, INT src_stride) > + const BYTE *src, INT src_width, INT src_height, INT src_stride, PixelFormat fmt) > { > HDC hdc; > HBITMAP hbitmap; > @@ -404,7 +407,8 @@ static GpStatus alpha_blend_hdc_pixels(GpGraphics *graphics, INT dst_x, INT dst_ > hbitmap = CreateDIBSection(hdc, (BITMAPINFO*)&bih, DIB_RGB_COLORS, > (void**)&temp_bits, NULL, 0); > > - if (GetDeviceCaps(graphics->hdc, SHADEBLENDCAPS) == SB_NONE) > + if (GetDeviceCaps(graphics->hdc, SHADEBLENDCAPS) == SB_NONE || > + fmt & PixelFormatPAlpha) > memcpy(temp_bits, src, src_width * src_height * 4); > else > convert_32bppARGB_to_32bppPARGB(src_width, src_height, temp_bits, > @@ -420,7 +424,7 @@ static GpStatus alpha_blend_hdc_pixels(GpGraphics *graphics, INT dst_x, INT dst_ > } > > static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst_y, > - const BYTE *src, INT src_width, INT src_height, INT src_stride, HRGN hregion) > + const BYTE *src, INT src_width, INT src_height, INT src_stride, HRGN hregion, PixelFormat fmt) > { > GpStatus stat=Ok; > > @@ -470,7 +474,7 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst > stat = alpha_blend_bmp_pixels(graphics, rects[i].left, rects[i].top, > &src[(rects[i].left - dst_x) * 4 + (rects[i].top - dst_y) * src_stride], > rects[i].right - rects[i].left, rects[i].bottom - rects[i].top, > - src_stride); > + src_stride, fmt); > } > > GdipFree(rgndata); > @@ -503,7 +507,7 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst > ExtSelectClipRgn(graphics->hdc, hregion, RGN_AND); > > stat = alpha_blend_hdc_pixels(graphics, dst_x, dst_y, src, src_width, > - src_height, src_stride); > + src_height, src_stride, fmt); > > RestoreDC(graphics->hdc, save); > > @@ -514,9 +518,9 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst > } > > static GpStatus alpha_blend_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, > - const BYTE *src, INT src_width, INT src_height, INT src_stride) > + const BYTE *src, INT src_width, INT src_height, INT src_stride, PixelFormat fmt) > { > - return alpha_blend_pixels_hrgn(graphics, dst_x, dst_y, src, src_width, src_height, src_stride, NULL); > + return alpha_blend_pixels_hrgn(graphics, dst_x, dst_y, src, src_width, src_height, src_stride, NULL, fmt); > } > > static ARGB blend_colors(ARGB start, ARGB end, REAL position) > @@ -656,8 +660,9 @@ static BOOL color_is_gray(ARGB color) > return (r == g) && (g == b); > } > > -static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE data, > - UINT width, UINT height, INT stride, ColorAdjustType type) > +/* returns preferred pixel format for the applied attributes */ > +static PixelFormat apply_image_attributes(const GpImageAttributes *attributes, LPBYTE data, > + UINT width, UINT height, INT stride, ColorAdjustType type, PixelFormat fmt) > { > UINT x, y; > INT i; > @@ -669,6 +674,9 @@ static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE d > BYTE min_blue, min_green, min_red; > BYTE max_blue, max_green, max_red; > > + if (!data || fmt != PixelFormat32bppARGB) > + return PixelFormat32bppARGB; > + > if (attributes->colorkeys[type].enabled) > key = &attributes->colorkeys[type]; > else > @@ -702,6 +710,9 @@ static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE d > { > const struct color_remap_table *table; > > + if (!data || fmt != PixelFormat32bppARGB) > + return PixelFormat32bppARGB; > + > if (attributes->colorremaptables[type].enabled) > table = &attributes->colorremaptables[type]; > else > @@ -731,6 +742,9 @@ static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE d > int gray_matrix[5][5]; > BOOL identity; > > + if (!data || fmt != PixelFormat32bppARGB) > + return PixelFormat32bppARGB; > + > if (attributes->colormatrices[type].enabled) > colormatrices = &attributes->colormatrices[type]; > else > @@ -769,6 +783,9 @@ static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE d > { > REAL gamma; > > + if (!data || fmt != PixelFormat32bppARGB) > + return PixelFormat32bppARGB; > + > if (attributes->gamma_enabled[type]) > gamma = attributes->gamma[type]; > else > @@ -793,6 +810,8 @@ static void apply_image_attributes(const GpImageAttributes *attributes, LPBYTE d > *src_color = (*src_color & 0xff000000) | (red << 16) | (green << 8) | blue; > } > } > + > + return fmt; > } > > /* Given a bitmap and its source rectangle, find the smallest rectangle in the > @@ -1237,7 +1256,7 @@ static GpStatus brush_fill_pixels(GpGraphics *graphics, GpBrush *brush, > if (stat == Ok) > apply_image_attributes(fill->imageattributes, fill->bitmap_bits, > bitmap->width, bitmap->height, > - src_stride, ColorAdjustTypeBitmap); > + src_stride, ColorAdjustTypeBitmap, lockeddata.PixelFormat); > > if (stat != Ok) > { > @@ -2990,15 +3009,18 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image > return OutOfMemory; > src_stride = sizeof(ARGB) * src_area.Width; > > - /* Read the bits we need from the source bitmap into an ARGB buffer. */ > + /* Read the bits we need from the source bitmap into a compatible buffer. */ > lockeddata.Width = src_area.Width; > lockeddata.Height = src_area.Height; > lockeddata.Stride = src_stride; > - lockeddata.PixelFormat = PixelFormat32bppARGB; > lockeddata.Scan0 = src_data; > + if (bitmap->format == PixelFormat32bppPARGB) > + lockeddata.PixelFormat = apply_image_attributes(imageAttributes, NULL, 0, 0, 0, ColorAdjustTypeBitmap, bitmap->format); > + else > + lockeddata.PixelFormat = PixelFormat32bppARGB; > > stat = GdipBitmapLockBits(bitmap, &src_area, ImageLockModeRead|ImageLockModeUserInputBuf, > - PixelFormat32bppARGB, &lockeddata); > + lockeddata.PixelFormat, &lockeddata); > > if (stat == Ok) > stat = GdipBitmapUnlockBits(bitmap, &lockeddata); > @@ -3011,7 +3033,7 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image > > apply_image_attributes(imageAttributes, src_data, > src_area.Width, src_area.Height, > - src_stride, ColorAdjustTypeBitmap); > + src_stride, ColorAdjustTypeBitmap, lockeddata.PixelFormat); > > if (do_resampling) > { > @@ -3059,7 +3081,8 @@ GpStatus WINGDIPAPI GdipDrawImagePointsRect(GpGraphics *graphics, GpImage *image > } > > stat = alpha_blend_pixels(graphics, dst_area.left, dst_area.top, > - dst_data, dst_area.right - dst_area.left, dst_area.bottom - dst_area.top, dst_stride); > + dst_data, dst_area.right - dst_area.left, dst_area.bottom - dst_area.top, dst_stride, > + lockeddata.PixelFormat); > > GdipFree(src_data); > > @@ -4009,7 +4032,8 @@ static GpStatus SOFTWARE_GdipFillRegion(GpGraphics *graphics, GpBrush *brush, > if (stat == Ok) > stat = alpha_blend_pixels_hrgn(graphics, gp_bound_rect.X, > gp_bound_rect.Y, (BYTE*)pixel_data, gp_bound_rect.Width, > - gp_bound_rect.Height, gp_bound_rect.Width * 4, hregion); > + gp_bound_rect.Height, gp_bound_rect.Width * 4, hregion, > + PixelFormat32bppARGB); > > GdipFree(pixel_data); > } > @@ -5811,7 +5835,7 @@ GpStatus WINGDIPAPI GdipReleaseDC(GpGraphics *graphics, HDC hdc) > /* Write the changed pixels to the real target. */ > alpha_blend_pixels(graphics, 0, 0, graphics->temp_bits, > graphics->temp_hbitmap_width, graphics->temp_hbitmap_height, > - graphics->temp_hbitmap_width * 4); > + graphics->temp_hbitmap_width * 4, PixelFormat32bppARGB); > > /* Clean up. */ > DeleteDC(graphics->temp_hdc); > @@ -6366,7 +6390,7 @@ static GpStatus SOFTWARE_GdipDrawDriverString(GpGraphics *graphics, GDIPCONST UI > > /* draw the result */ > stat = alpha_blend_pixels(graphics, min_x, min_y, pixel_data, pixel_area.Width, > - pixel_area.Height, pixel_data_stride); > + pixel_area.Height, pixel_data_stride, PixelFormat32bppARGB); > > GdipFree(pixel_data); > > -- > 2.3.5 > > >

1 1

Re: [PATCH 4/4] d3drm/tests: Add tests to compare vtables for frame{1-3}, object and visual
by Stefan Dösinger April 1, 2015

April 1, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-01 um 18:15 schrieb Aaryaman Vasishta: > +struct vtable_test > +{ > + REFIID iid; > + BOOL equal; > + BOOL todo; > +}; You should be able to integrate this into the existing qi test table, similar to how the refcount_iid field works. If you need more than one TODO field (e.g. one for refcount_iid and one for vtable inheritance) use flags. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHHR+AAoJEN0/YqbEcdMwNa4P/08HSs3DE722aHW2nyx0Zfs1 KPeEn3yqm32PUrBbFs8gptp5+KxKqpsd7mzN3OgHxx+ipRCbcSrVEFhMYuels/Sl YX8rYrpGam+kKOSBOV8mnwjR1Fc9K3KDi5vyODmi4hFWb+gWArtONOVTm8HQwk/P S339yQDjsRArCugbVywmAMEi8J4ImTvuG102vZIyHFysmPG9CQQ5ndE7naE+B58s MJ557ErCWtDdazOis3CtFFVe1jBvwcZyfKi+6LSTyhVxVOiP3Mc84k+5cdT7929u UzXlHkJlS7qxAjxHz0gF1gdvCS/jlUQV5pGNrwoLg4FQEY7I5jPqR8QkseccygYC bHH/JaNfFcaELF5OTkyJCCH0Xa7hAPSWk8/RRcutzboe2s6n3SRUXuM9lAE9tBZL lopYNRYqb7wuxMFzdsRD5MG9zyqOGdg1dx/t75WMcniD36g65CDHkTaIRDX1nrCE 4ZTBhmXoAQxz60nrMHbZDye9rxTd1+RPvs45X9BOFpolfUAJt6luX8+ib0v5myMf qL8QzYT+lsNiFtZMwGrSRb3Wj4nm+KWeH2E8WBx3oYrQZe1LWFH6ZlkyTRamEKDY ooC8tNxrhOqQOV5eD8+Y3DDN+jE6jI53vpC3RAUMUtHXYrYHLiwKKpgyCjXU/vBi Ym2oC3yNbzOon0NQZ9UR =E3pj -----END PGP SIGNATURE-----

1 0

Re: [PATCH] uxtheme: Load MUI file when theme loaded.
by Nikolay Sivov April 1, 2015

April 1, 2015

On 04/02/2015 12:00 AM, Mark Harmstone wrote: > Version 4 uxthemes, as used in Vista and above, are split over two files - the > msstyles file, and a language-dependent MUI file storing the theme's name, the > fonts it uses, etc. In preparation for v4 support, this patch adds MUI loading > to uxtheme. > > --- > dlls/uxtheme/msstyles.c | 98 ++++++++++++++++++++++++++++++++++++++++++++++++- > dlls/uxtheme/msstyles.h | 1 + > 2 files changed, 98 insertions(+), 1 deletion(-) > Path resolution you've implemented looks very similar to what GetFileMUIPath() is supposed to return. It would be great to have it at least partially implemented instead of potentially duplicating it. It'd be perfectly fine if you implement only subset of flags that you'll actually need for uxtheme.

1 0

Re: comctl32/tests: Fix couple of metrics tests that fail on some systems (try2)
by Marvin April 1, 2015

April 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12597 Your paranoid android. === w2008s64 (32 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w7u (32 bit listview) === listview.c:3933: Test failed: got right 112, bottom 19 listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000 === w2008s64 (64 bit listview) === listview.c:5190: Test failed: NM_HOVER allow test: the msg sequence is not complete: expected 0087 - actual 0000 listview.c:5195: Test failed: NM_HOVER block test: the msg sequence is not complete: expected 0087 - actual 0000

1 0

Re: d3dx9_36: Add D3DXFrameFind stub.
by Nikolay Sivov April 1, 2015

April 1, 2015

On 04/01/2015 08:59 PM, Andrey Gusev wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38334 > > Thanks to Matteo Bruni for valuable help. > > +D3DXFRAME * WINAPI D3DXFrameFind(const D3DXFRAME *frame_root, const char *name) > +{ > + FIXME("frame_root %p, name %s stub.\n", frame_root, debugstr_a(name)); > + > + return NULL; > +} > + If it's just a matter of searching for a name in a tree, I think it's better to add actual implementation instead of a stub.

1 0

Re: [PATCH] undefined symbols compiling for macosx >10.8
by Ken Thomases April 1, 2015

April 1, 2015

If you were having problems building Wine without this patch, then you have a system configuration problem. Or you're configuring Wine incorrectly. -Ken On Apr 1, 2015, at 11:52 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Sorry but I committed the patch make me compilation be possible. > > On 01 апр. 2015 г., at 18:34, Ken Thomases <ken(a)codeweavers.com> wrote: > >> Hi, >> >> This patch makes no sense. Wine builds just fine for OS X versions greater than 10.8. Indeed, as near as I know, it still builds just fine for 10.5 and up (the Mac driver requires 10.6 or later, but on 10.5 it just will be skipped; it won't break anything). >> >> On Apr 1, 2015, at 6:48 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: >> >>> Undefined symbols for architecture i386: >>> "_kCGDisplayShowDuplicateLowResolutionModes", referenced from: >>> -[WineApplicationController modeMatchingMode:forDisplay:] in cocoa_app.o >>> ld: symbol(s) not found for architecture i386 >> >> If you're getting this error, you're not building against a 10.8+ SDK properly. The compiler is seeing the headers for a 10.8+ SDK but the linker is seeing libraries and frameworks from some pre-10.8 SDK. >> >> >>> Instead of checking for NULL we should check #ifdef >> >> No. The things being tested are not macros in any version of the SDK. Your #ifdef checks will never pass. You have effectively done "#if 0". >> >> Finally, changes to separate DLLs (secur32 and winemac.drv, in this case) should be in separate patches unless they are inter-dependent. >> >> -Ken >> >

1 0

Re: [PATCH 3/4] d3drm/tests: Split tests seperately for IDirect3DRM{1-3} interfaces
by Stefan Dösinger April 1, 2015

April 1, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-01 um 18:15 schrieb Aaryaman Vasishta: > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1841,6 +1841,104 @@ static void test_d3drm_qi(void) > IDirect3DRM_Release(d3drm); > } > > +static void test_frame_qi(void) > +{ There's no need to add this to d3drm.c and d3drm3.c. The versions in d3drm1.c, d3drm2.c and d3drm3.c are enough. Ideally d3drm.c will go away at some point. > + hr = Direct3DRMCreate(&d3drm); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", hr); > + > + test_qi("d3drm_qi", (IUnknown *)d3drm, &IID_IDirect3DRM, tests, sizeof(tests) / sizeof(*tests)); > + > + IDirect3DRM_Release(d3drm); This test is version independent because there is only one way to create the d3drm object. You can just keep it in d3drm.c for now, or move it to d3drm1.c in a separate patch if you want. > --- a/dlls/d3drm/tests/Makefile.in > +++ b/dlls/d3drm/tests/Makefile.in > @@ -2,4 +2,7 @@ TESTDLL = d3drm.dll > IMPORTS = d3drm dxguid ddraw user32 uuid > C_SRCS = \ > d3drm.c \ > + d3drm1.c \ > + d3drm2.c \ > + d3drm3.c \ > vector.c This doesn't match the Makefile.in file I have. You have a reordered IMPORTS line. This is why the testbot failed. Do you have other patches in your tree? > +* Copyright 2012 Andr� Hentschel This shows up wrong in my mail client. It may be a setup issue on my side. It shows up OK on http://source.winehq.org/patches/data/110484 when viewed with the browser, but if I download the patch with wget it is broken as well. Please make sure your text editor is configured to save the files as UTF8. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVHCwnAAoJEN0/YqbEcdMwqsMP/1pigFRsvxOMAYpIHbPoQzda rnKNX4egG04IFvrlObvEVNm6GUW02hgm7SB5+UcdCkXclbGbDjxW0R8M4RqoYOHs swdSxFIZX9s/wPqHJOv33oK8TDPKYUX2SwXyhyOEN7rh3LKJF4DeYGP0uW+wSMed bCXeJ9bx3X55cAGMJhP9jVdcq8ADTh8z0sYANHLBkD80OCac+KxFMmsGrxUD2e2H l6ATINj9BKlgAYGbFnoweNkiv4+O9y6zXBgOQu8Df6Jlr+mu86Jv0zi5S7MHEj4h tWwNyNyaDjTIUlfMdF3cCrKDhLhgYuuwQqij/iAdrEcGFEFn+QKeX0THCGwLeto8 nzwmEZFKYT2keJsMoHQ5tf0U6tT0xedsOjHHTHg/cg1BBj7ogtJ0YcEaxIYtF7uP 47tkjEL9iKXaN7bfdugH1D4buvufUzlZYIvehdbyNcWs3/HYHdiBAbER1ah3yAn9 TlpYdHpZstimuDkMMMLCExW/nlnGZlxz+orF9RNMm/SowtAe1aMVGGHMS5+6ZBfb 4z85+OWG8bR9D+e7+OeOYr/3Z62wiKLppRVQiJ4NgrGgv4ex2rIjqkiKBTEgSZm7 WTptfVrMCQ8zHEpos8iZHZOcoOLVFX4ylQaNNXmssGtwcLqH/P8o7KAk3o6RO+g0 qlkMVFMPEn7fE9h8WJfj =Jeuf -----END PGP SIGNATURE-----

3 3

Re: [PATCH 4/4] d3drm/tests: Add tests to compare vtables for frame{1-3}, object and visual
by Marvin April 1, 2015

April 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12593 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] d3drm/tests: Split tests seperately for IDirect3DRM{1-3} interfaces
by Marvin April 1, 2015

April 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12592 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] undefined symbols compiling for macosx >10.8
by Ken Thomases April 1, 2015

April 1, 2015

Hi, This patch makes no sense. Wine builds just fine for OS X versions greater than 10.8. Indeed, as near as I know, it still builds just fine for 10.5 and up (the Mac driver requires 10.6 or later, but on 10.5 it just will be skipped; it won't break anything). On Apr 1, 2015, at 6:48 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Undefined symbols for architecture i386: > "_kCGDisplayShowDuplicateLowResolutionModes", referenced from: > -[WineApplicationController modeMatchingMode:forDisplay:] in cocoa_app.o > ld: symbol(s) not found for architecture i386 If you're getting this error, you're not building against a 10.8+ SDK properly. The compiler is seeing the headers for a 10.8+ SDK but the linker is seeing libraries and frameworks from some pre-10.8 SDK. > Instead of checking for NULL we should check #ifdef No. The things being tested are not macros in any version of the SDK. Your #ifdef checks will never pass. You have effectively done "#if 0". Finally, changes to separate DLLs (secur32 and winemac.drv, in this case) should be in separate patches unless they are inter-dependent. -Ken

1 0

Re: [PATCH] vbscript: Implemented Oct(try 4)
by Marvin April 1, 2015

April 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12481 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2

Wine on Javascript
by Zhenbo Li April 1, 2015

April 1, 2015

Hi All, I'm came up with this idea since last year, and I'm glad to share this idea to you today. We tried to compile wine with clang[1], and most of the blocks have been fixed[2]. I tried it on my computer, and wine was built successfully, but `make test` failed.' I think wine+clang would work fine soon. Besides, the JavaScript engines are improving, for example, Google V8[3], and we can expect a better performance[4]. Now, let's connect them: Why not run wine's IR with a JavaScript engine?[5] At least, we have such benefits: 1. We can offer a online demo for wine 2. Wine can work on portable devices 3. Wine user can use the same prefix on different devices 4. We can have a better backend[6] This is my humble idea. I'm looking forward to your reply. [1]: http://wiki.winehq.org/Clang [2]: https://llvm.org/bugs/show_bug.cgi?id=10638 [3]: https://code.google.com/p/v8/ [4]: http://arewefastyet.com/ [5]: http://kripken.github.io/emscripten-site/ [6]: https://software.intel.com/en-us/articles/graphics-acceleration-for-html5-a… -- Have a nice (April Fool) day! Zhenbo Li

3 2

Re: [PATCH] vbscript: Fixed Hex(try 2)
by Marvin April 1, 2015

April 1, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12560 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2

Re: [1/6] kernel32/tests: Extend IsProcessInJob tests (try 2)
by Marvin March 31, 2015

March 31, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12559 Your paranoid android. === w7u (32 bit process) === prprocess.c:2496: Test failed: WaitForSingleObject returned 258

1 0

Re: [4/6] ntdll: Implement IsProcessInJob
by Marvin March 31, 2015

March 31, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12555 Your paranoid android. === w7u (32 bit process) === process.c:2274: Test failed: WaitForSingleObject returned 258 process.c:2278: Test failed: AssignProcessToJobObject unexpectedly succeeded process.c:2279: Test failed: Expected GetLastError() to be 5 (ERROR_ACCESS_DENIED) is -559038737

1 0