April 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Introduce resource-type specific format flags.
by Henri Verbeet April 23, 2015

April 23, 2015

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Always check 2D textures here, we don't want to write this ERR when the app tried > + * to create a compressed volume texture but s3tc support is otherwise available. */ > if ((desc->format == WINED3DFMT_DXT1 || desc->format == WINED3DFMT_DXT2 || desc->format == WINED3DFMT_DXT3 > || desc->format == WINED3DFMT_DXT4 || desc->format == WINED3DFMT_DXT5) > - && !(format->flags & WINED3DFMT_FLAG_TEXTURE) && !once++) > + && !(format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_TEXTURE) && !once++) > ERR_(winediag)("The application tried to create a DXTn texture, but the driver does not support them.\n"); But now it's still going to write an ERR when it tries to create a volume texture and s3tc support is unavailable. Wouldn't it make more sense to just explicitly exclude volume textures by adding a "desc->resource_type != WINED3D_RTYPE_VOLUME_TEXTURE" condition?

2 2

Favor / heads up - wine tasks in a hackathon
by Jeremy White April 23, 2015

April 23, 2015

My alma mater is putting on a hackathon for college students in our region. http://carlhacks.io/ As an experiment, I'm wanted to see if I could get any of these students interested in Wine hacking. So we've sponsored prize money for any students that can fix a bug in Wine or fix a test. I have no idea if any students are going to take it on or not, but if you see an influx of urgent requests on #winehackers or here, starting Saturday and ending Sunday, you'll know why :-/. And if any such student does actually succeed in contributing a clearly useful or even promising patch, please let me know, so I can make a point to award the prize money during the closing ceremonies. Cheers, Jeremy

1 0

Re: [PATCH 4/5] wined3d: Query info for each resource type from ARB_internalformat_query2.
by Henri Verbeet April 23, 2015

April 23, 2015

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static GLenum wined3d_gl_type_to_enum(enum wined3d_gl_resource_type type) > +{ > + switch (type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + return GL_TEXTURE_1D; > + case WINED3D_GL_RES_TYPE_TEX_2D: > + return GL_TEXTURE_2D; > + case WINED3D_GL_RES_TYPE_TEX_3D: > + return GL_TEXTURE_3D; > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + return GL_TEXTURE_CUBE_MAP_ARB; > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + return GL_TEXTURE_RECTANGLE_ARB; > + case WINED3D_GL_RES_TYPE_BUFFER: > + return GL_TEXTURE_2D; /* TODO: GL_TEXTURE_BUFFER. */ > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > + ERR("Unexpected GL resource type %u.\n", type); > + return 0; > +} > + > + You have an extra newline here. > + for (type = 0; type < sizeof(format->flags) / sizeof(*format->flags); ++type) This isn't wrong as such, but you can use ARRAY_SIZE for this now. > { > - TRACE("Format %s doesn't support %s.\n", debug_d3dformat(format->id), string); > - format_clear_flag(format, flag); > + gl_info->gl_ops.ext.p_glGetInternalformativ(wined3d_gl_type_to_enum(type), internal, pname, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s supports %s.\n", debug_d3dformat(format->id), string); It would probably be helpful if this mentioned the resource type as well.

1 0

Re: [PATCH 5/6] d3d9/tests: Add a specular lighting test.
by Henri Verbeet April 23, 2015

April 23, 2015

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define VERTICES_SIDE 5 > +#define INDICES_COUNT ((VERTICES_SIDE - 1) * (VERTICES_SIDE - 1) * 2 * 3) > + I don't think you really need to #define these, but if you do you should probably #undef them once you're done with them.

1 0

Re: [PATCH 3/6] wined3d: Introduce D3D7+ normal matrix computation.
by Henri Verbeet April 23, 2015

April 23, 2015

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define SWAP_ROWS(a, b) { float *tmp = a; a = b; b = tmp; } > + I assume this is mostly borrowed from Mesa like invert_matrix_3d(), but unfortunately Mesa isn't particularly good at writing macros, even though they have more than enough of them. This one happens to more or less work for the cases you have here, but consider the following in particular: if (...) SWAP_ROWS(a, b); else SWAP_ROWS(c, d); Please just use the standard "do { ... } while(0)" construction when you need to define a macro like that. In this particular case there's of course no reason you need a macro in the first place.

1 0

Re: [PATCH 2/2] ntdll: Add support for FileFsFullSizeInformation class in NtQueryVolumeInformationFile(try 2)
by Alexandre Julliard April 23, 2015

April 23, 2015

"Jianqiu Zhang" <zhangjianqiu_133(a)yeah.net> writes: > + if(!S_ISREG(st.st_mode) && !S_ISDIR(st.st_mode)) > + { > + io->u.Status = STATUS_INVALID_DEVICE_REQUEST; > + } > + else > + { > + ULONGLONG bsize; > +#if !defined(linux) || !defined(HAVE_FSTATFS) > + struct statvfs stfs; > + > + if(fstatvfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_frsize; > +#else > + struct statfs stfs; > + if(fstatfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_bsize; > +#endif Please avoid duplicating all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32/tests: Add a trailing '\n' to an ok() call.
by Marvin April 23, 2015

April 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: user32: After handling an internal message give a chance to real message to arrive.
by Marvin April 23, 2015

April 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12973 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00150136 msg.c:12252: Test failed: bad time 315f0/315ff

1 0

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard April 23, 2015

April 23, 2015

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: [PATCH 2/2] krnl386: Invalid console handles should translate into real handles when creating a new process.
by Alexandre Julliard April 23, 2015

April 23, 2015

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > This patch fixes an issue exposed by the fix in patch 1. The current > mechanism for initializing the DOS handles for a process uses > DuplicateHandle, which converts INVALID_HANDLE_VALUE into a usable > handle (but not 0). Without this fix the Caesar III demo installer > crashes with an unhandled page fault, though it may be more desirable > to allocate new handles than to replicate the behavior we used to have > prior to patch 1. Proper handles would be better, simply open the null device or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] wined3d: Shadow format flags in wined3d_rendertarget_view.
by Henri Verbeet April 22, 2015

April 22, 2015

On 22 April 2015 at 11:30, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -101,6 +101,7 @@ static void wined3d_rendertarget_view_init(struct wined3d_rendertarget_view *vie > view->parent_ops = parent_ops; > > view->format = wined3d_get_format(gl_info, desc->format_id); > + view->format_flags = resource->format_flags; That's wrong. We won't be able to do much with this until we support ARB_texture_view, but the view format is mostly independent of the resource format, other than that they have to be from the same compatibility class. I guess you'd want something like "view->format_flags = view->format->flags[resource->gl_type];".

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 9)
by Stefan Dösinger April 22, 2015

April 22, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-04-22 um 05:30 schrieb Alistair Leslie-Hughes: > + if(*pdwBufferSize < entry->size || *pdwNameLen < namesize) > + { > + *pdwNameLen = namesize + 1; > + *pdwBufferSize = entry->size; > + return DPNERR_BUFFERTOOSMALL; > + } > + > + if((*pdwNameLen && !pwszName) || (*pdwBufferSize && !pvBuffer)) > + return E_POINTER; This check suggests that a NULL pwszName is ok if *pdwNameLen is 0. However, the above check fails in this situation. Depending on how you want this to behave there's either an error in your logic or you have some redundant checks in there. Are you sure *pdwDataType is not set in the BUFFERTOOSMALL case? I mentioned pdwDataType in the last feedback already, please take a bit more care and check if some things I point out apply in a similar way to other places, and re-read the feedback you get after you think you have implemented all the changes to see if there's anything you missed. > + case DPNA_DATATYPE_DWORD: > + *(DWORD*)pvBuffer = entry->data.value ; The extra space in front of the semicolon looks weird. > hr = IDirectPlay8Address_GetComponentByIndex(localaddr, 100, NULL, NULL, NULL, &bufflen, &type); > - todo_wine ok(hr == E_POINTER, "got 0x%08x\n", hr); > + ok(hr == DPNERR_INVALIDPOINTER, "got 0x%08x\n", hr); In the code you return E_POINTER. DPNERR_INVALIDPOINTER is defined as E_POINTER, but please try to be consistent. > hr = IDirectPlay8Address_GetComponentByIndex(localaddr, i, NULL, &namelen, NULL, &bufflen, &type); > - todo_wine ok(hr == DPNERR_BUFFERTOOSMALL, "got 0x%08x\n", hr); > + ok(hr == DPNERR_BUFFERTOOSMALL, "got 0x%08x\n", hr); > + ok(namelen > 0, "namelen length is 0\n"); > + ok(bufflen > 0, "bufflen length is 0\n"); Please check the exact length, not just > 0. Please also check the name string, and the string and lengths in the success case (e.g. if you pass a length > than the necessary size does dpnet change the size?). Also, as pointed out above -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVN25ZAAoJEN0/YqbEcdMwf1cP/jXMXUuyMNzg5JAVG6YMMKgJ yIac4X5zxnmcPrJMjMRKIr2xU3u6ZDki/Kk5/GulDCCd4NQGlDJP0QY9WuuZ9eIN YiAipjXLpO4DPVi6eTRlDIbfCSDfpNJnjSWdDGbjpF/dpUkJOOZzwWvkJKZr598O kZohPT1kwTs12sU3yQyT8N3NGQer+AaWHcfohMW5f0UeZ+whviwjg3CGavrR65mH Q2fWn92mgw8KPTu+zvJ5oBbWQLf24o+lBp/vQ6zeOIA2lxXVLoMfg5q8QRWvKge9 IiPIG8BEOfrTXXSEZSUauif97fdq23JGQJOOGYUyZ+YLg/4Pqj2nWZBOmFM+3gVy E5FgFPT4EdE1vpyn7cnWGufzNtnctTZGOJ4F7AKxdMoBPqXxDEgdjmMFqN0yeTH8 Pm6NGVJP7uR8+wqXApHoGN2S7ceZLuEhMhdGYHbFakx9McPzCEayWMGQ/CIlbjHt YRB5aaxOAk896Fmb+PMuv3G9d4+y4409iLB+/Jrda20VOFfAp1qzNa33R9rhWXN7 sSdCale2KKYwStnzSWAcH4Mn7L+i1B/Dl7Md83HqPumAPfwlSK8VZVeqF0ZVjLaR KlokPcmQnIuS/ia6gPdGVbmAHnpoIIn0CNtgstKBqXkvGUlasXsKhy2ofWkWoaiW lO+hrwausmSORbzMGVaW =fTwv -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 9)
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12940 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: comctl32:TTM_SETTOOLINFO does not change subclassing
by Nikolay Sivov April 21, 2015

April 21, 2015

On 21.04.2015 17:40, Aric Stewart wrote: > > Prevents crashes when a subclassed window is unsubclassed and then destroyed. > > As per information found at: > https://support.microsoft.com/en-us/kb/kbview/154122 > --- > dlls/comctl32/tooltips.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > We definitely need a test for that.

2 1

Re: [PATCH 5/5] ddraw/tests: Port the lighting test to the previous d3d versions.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12921 Your paranoid android. === wvistau64 (32 bit ddraw1) === ddraw1.c:2488: Test failed: Expected message 0x46, but didn't receive it. ddraw1.c:2490: Test failed: Expected screen size 1024x768, got 0x0. ddraw1.c:2496: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2527: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2535: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2562: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2582: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2606: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2633: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2650: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2687: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2698: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2725: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2745: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2762: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2789: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2806: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}. ddraw1.c:2844: Test failed: Expected {0, 0, 1024, 768}, got {-8, -8, 1032, 746}.

1 0

Re: [PATCH 4/5] ddraw/tests: Add more d3d7 lighting tests.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12920 Your paranoid android. === w8 (32 bit visual) === visual.c:1494: Test failed: unexpected colortable on offscreen surface

1 0

Re: iexplore: Update version to 9.0.8112.16421.
by Nikolay Sivov April 21, 2015

April 21, 2015

On 21.04.2015 12:19, Hans Leidekker wrote: > --- > programs/iexplore/iexplore.inf | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Maybe ieframe/mshtml versions should be updated as well?

2 1

Re: [2/2] server: GetQueueStatus should clear only checked queue changed bits.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12902 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00080150 msg.c:12252: Test failed: bad time 30c10/30c20

1 0

Re: [1/2] user32/tests: Add PeekMessage(PM_NOREMOVE) call to inter-thread messages test.
by Marvin April 21, 2015

April 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12901 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10471: Test failed: expected PeekMessage to return FALSE, got 1 === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013C msg.c:12252: Test failed: bad time 30fa9/30fb8

1 0

Re: (resend)server: Do not replace focus and active windows with NULL on thread_attach_input
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12890 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00080150 msg.c:12252: Test failed: bad time 30f1c/30f2c

1 0

Re: server: Do not replace focus and active windows with NULL on thread_attach_input
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12889 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013E msg.c:12252: Test failed: bad time 3200d/3201d

1 0

Re: user32/tests: Add a test for sending inter-thread messages.
by Marvin April 20, 2015

April 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12880 Your paranoid android. === w7u (32 bit msg) === msg.c:6957: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x0014 instead msg.c:6957: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0082 instead msg.c:6957: Test failed: destroy child on thread exit: 2: the msg 0x0014 was expected, but got msg 0x000f instead msg.c:6957: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:12230: Test failed: unexpected hwnd 00060150 msg.c:12252: Test failed: bad time 31cc3/31cd2

1 0

GSoC 2015 Application
by lijianwei April 20, 2015

April 20, 2015

Hi I'm a graduate student in NorthWestern Polytenical University.I have been study Parelism promraming,especially GPU programming for two year.So I want to accept task Implement OpenMP. But now,what should I do to begin my work. Watting for your answer! Than you! Best Regard

2 1

License of AppDb content and sql dump?
by Sebastian Lackner April 19, 2015

April 19, 2015

Hiho, I've been wondering if there is any license information available for the appdb content. I've looked through lots of pages but didn't find any hint under which terms the data can be used. It would be nice if someone could clarify this situation a bit. For those who are wondering why I'm asking - I am planning to use the (anonymized) data (especially app names, categories and corresponding ratings) for further analysis and comparison between different Wine versions. There will of course be references to show where the data is from. Since the data is used in connection with the Wine project I would assume that it should be normally safe to do that - if anyone sees any legal issues please contact me. ;) Best regards, Sebastian

1 0

Re: [PATCH] urlmon: set hres also in else branch (Coverity)
by Nikolay Sivov April 19, 2015

April 19, 2015

On 19.04.2015 14:42, Marcus Meissner wrote: > 718705 Unchecked return value > --- > dlls/urlmon/session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/urlmon/session.c b/dlls/urlmon/session.c > index e01e647..001158f 100644 > --- a/dlls/urlmon/session.c > +++ b/dlls/urlmon/session.c > @@ -213,7 +213,7 @@ IInternetProtocolInfo *get_protocol_info(LPCWSTR url) > > hres = IClassFactory_QueryInterface(cf, &IID_IInternetProtocolInfo, (void**)&ret); > if(FAILED(hres)) > - IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > + hres = IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > IClassFactory_Release(cf); > > return ret; > It's still unchecked. If we want to use it we need to propagate return code to caller, right now it will return NULL interface pointer. So I'm thinking it's false positive.

2 1

Application for GSoC 2015 - Implement findstr.exe for Wine.
by KaiPeng Zeng April 19, 2015

April 19, 2015

Hi folks, I’m Kaipeng Zeng who is a Linux user and Wine/CrossOver user from China. I am major in Biomedical Engineering in Guangdong Pharmaceutical University. I’d like to apply GSoC to work for Wine Project this year. My proposal is "Implementing findstr.exe for Wine". Though findstr is a quite independent program in Wine, I think it is valuable to implement. As far as I knew, there are some bugs about findstr in Bugzilla[1]. Any other programs in Chinese depend on it too. The implementation of findstr will help these programs and all the programs will also be good tests for our implementation. Besides, I think the code of grep will be helpful for implementing findstr. There are three parts in my plan: === Part 1: Add more tests for findstr.exe === I have submitted a patch for findstr’s test to wine-patches[2]. I will add more tests to prepare for the implementation. === Part 2: Implement an initial findstr.exe === With enough tests, I will try to implement the findstr gradually. My middle goal is having an initial implementation of findstr which can handle some simple work. Bug 35254[3] may be fixed after this part is finished. === Part 3: Add more parameters implementation === In this part, I will add more tests and try to implement more arguments for findstr, let it solve more things. [1] https://bugs.winehq.org/buglist.cgi?quicksearch=findstr&list_id=178519 [2] http://source.winehq.org/patches/data/110182 [3] https://bugs.winehq.org/show_bug.cgi

1 2

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings (v2).
by Ken Thomases April 17, 2015

April 17, 2015

On Apr 17, 2015, at 4:09 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Version 2: Also update macdrv_displays_changed. Supersedes 110793. Looks OK to me. -Ken

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12849 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings.
by Ken Thomases April 17, 2015

April 17, 2015

Sorry for the double post. Sent by accident before I was finished. This hoists some of the knock-on effects of WM_MACDRV_UPDATE_DESKTOP_RECT to the place where it is sent. However, it only does so for one of the two places where it is sent. It is also sent in macdrv_displays_changed() which is called when something external to the process (may have) changed the display configuration. You would need to duplicate the hoisted code to that function, too, or find some other way to make sure the same work gets done. -Ken On Apr 16, 2015, at 5:18 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Same as the previous patch, just for winemac.drv. > > The message ping-pong between the ChangeDisplaySettings calling thread > and the desktop thread is more complicated here than in winex11. The > problem again is that sendMessageTimeout(SMTO_BLOCK) will not process > messages sent by the desktop, leading to a deadlock. Replacing > SendMessageTimeout in the desktop with PostMessage is not an option > either because then messages will be executed in a different order in > the thread that called ChangeDisplaySettings. > > This patch will lead to DISPLAYCHANGE messages being sent on redundant > changes. This matches the behavior of winex11 and happens to fix the > user32/sysparam.ok test, but it fixes it for the wrong reason (the real > problem afaics is that OSX only supports 32 bpp, so no change takes > place although one was requested). I think redundant changes should be > intercepted in user32 before the display driver is called. > --- > dlls/winemac.drv/display.c | 8 ++++++-- > dlls/winemac.drv/window.c | 4 ---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c > index 10ecf67..f7ce163 100644 > --- a/dlls/winemac.drv/display.c > +++ b/dlls/winemac.drv/display.c > @@ -564,8 +564,12 @@ better: > size_t width = CGDisplayModeGetWidth(best_display_mode); > size_t height = CGDisplayModeGetHeight(best_display_mode); > > - SendMessageW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > - MAKELPARAM(width, height)); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > + SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > + SendMessageTimeoutW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK, ~0U, NULL); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > ret = DISP_CHANGE_SUCCESSFUL; > } > else > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index 7a777e6..fa12af5 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -1666,13 +1666,9 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > if (!GetWindowRect(hwnd, &current_desktop_rect) || > !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) > { > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > - SMTO_ABORTIFHUNG, 2000, NULL); > SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), > CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), > SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, > - SMTO_ABORTIFHUNG, 2000, NULL); > } > } > return 0; > -- > 2.3.4 > > >

2 1

Re: [PATCH] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12824 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

2 1

Re: [PATCH 1/2] ntdll/tests: Add test for FileFsFullSizeInformation(try 2)
by Marvin April 17, 2015

April 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12844 Your paranoid android. === w8 (32 bit file) === file.c:407: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

WineConf 2015
by Michael Stefaniuc April 17, 2015

April 17, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello guys, after we rethought WineConf and did it at/during FOSDEM for the last two years, it is time for a real WineConf again. We are missing too much our keynote, our governance discussions as well as our hackatons. Also the two full days should give more time for the most important topic aka the hallway discussions. After two years in Europe the old tradition would call for a session over in USA/Canada but this is not a strict requirement. Now the most important thing is to find volunteers that would want to host the WineConf. They have the bigger say in the date too, there are two options: - - either in late spring (preferred by me), - - or early fall (preferred by Jeremy) I have started also http://wiki.winehq.org/WineConf2015 please feel free to add agenda topics to it. bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTY5awACgkQ0ei8kcpE1VG2YQCguwUys0se+wV96lPfjZ+Qi6LJ 8ooAoJDxist2eZLgMXsRqUZVloGpBRgz =7Ta5 -----END PGP SIGNATURE-----

6 12

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings.
by Ken Thomases April 16, 2015

April 16, 2015

This hoists some of the knock-on effects of WM_MACDRV_UPDATE_DESKTOP_RECT to the place where it is sent. However, it only does so for one of the two places where it is sent. It is also sent in macdrv_displays_changed() On Apr 16, 2015, at 5:18 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Same as the previous patch, just for winemac.drv. > > The message ping-pong between the ChangeDisplaySettings calling thread > and the desktop thread is more complicated here than in winex11. The > problem again is that sendMessageTimeout(SMTO_BLOCK) will not process > messages sent by the desktop, leading to a deadlock. Replacing > SendMessageTimeout in the desktop with PostMessage is not an option > either because then messages will be executed in a different order in > the thread that called ChangeDisplaySettings. > > This patch will lead to DISPLAYCHANGE messages being sent on redundant > changes. This matches the behavior of winex11 and happens to fix the > user32/sysparam.ok test, but it fixes it for the wrong reason (the real > problem afaics is that OSX only supports 32 bpp, so no change takes > place although one was requested). I think redundant changes should be > intercepted in user32 before the display driver is called. > --- > dlls/winemac.drv/display.c | 8 ++++++-- > dlls/winemac.drv/window.c | 4 ---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c > index 10ecf67..f7ce163 100644 > --- a/dlls/winemac.drv/display.c > +++ b/dlls/winemac.drv/display.c > @@ -564,8 +564,12 @@ better: > size_t width = CGDisplayModeGetWidth(best_display_mode); > size_t height = CGDisplayModeGetHeight(best_display_mode); > > - SendMessageW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > - MAKELPARAM(width, height)); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > + SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > + SendMessageTimeoutW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK, ~0U, NULL); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > ret = DISP_CHANGE_SUCCESSFUL; > } > else > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index 7a777e6..fa12af5 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -1666,13 +1666,9 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > if (!GetWindowRect(hwnd, &current_desktop_rect) || > !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) > { > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > - SMTO_ABORTIFHUNG, 2000, NULL); > SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), > CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), > SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, > - SMTO_ABORTIFHUNG, 2000, NULL); > } > } > return 0; > -- > 2.3.4 > > >

1 0

Re: [PATCH 1/2] d3drm/tests: Make get_refcount return ULONG instead of int.
by Stefan Dösinger April 16, 2015

April 16, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 These patches look good to me. On 04/13/15 18:59, Aaryaman Vasishta wrote: > --- dlls/d3drm/tests/d3drm.c | 2 +- 1 file changed, 1 insertion(+), > 1 deletion(-) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 2f154f9..f089707 100644 --- a/dlls/d3drm/tests/d3drm.c +++ > b/dlls/d3drm/tests/d3drm.c @@ -33,7 +33,7 @@ ok(count == rc_new, > "Invalid refcount. Expected %d got %d\n", rc_new, count); \ } > > -static int get_refcount(IUnknown *object) +static ULONG > get_refcount(IUnknown *object) { IUnknown_AddRef( object ); return > IUnknown_Release( object ); > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVL81eAAoJEN0/YqbEcdMwrRYP/j37mA7B6bg9RveFxAYQS8VX AVROgmPd+hZDl/JKKnSMrUgHU3Y6MtCGwKd6Pb42yRhpU8qw/j6dPW1QqUYSII0V MpqpON1tY6WRV8M2eCBJ5+qLBwzFDxi51a4ta+7BUbK6Jl9IJw58OdyL5pt5WSID XneEmweh3BVI3ay4ZYn5jlK53BArCFu5yfclYPklL5uNb4sdA5zTJoavvwUHYMHc grjeEXAxRnBn8zmD13H5+s8GRC59Sx/vHJl6PTlv2A4bU22HwTku3b7/RbAGyYtB rB4Y+SRUeDn8e5YAe6+kWmwAOORdQFf1plmLx+bjIc13UYlnBTLnOjV8KMZm9vrC nhCcxUVeY3YYahA7q37nEOMZHVt++mX5pJ00vdV47QzZVAat05pA9tiesI3n5IAm DNrDRPV1olBT2OIz20Xo0YvtdBnvkOQDKB+SfYtD8YnGGNw/WZKUEwBh5IpNtvbE iZ/d3AMB1h4A1trWofNR17nZJbTwQwTmIKI6ggw2Cr6DpPb6SFp6odoA4OjajGGB e+sqBTaf5yf2QbDzjn694f4PKAeTZwnkXXzR9Quu2J1Zu4dZFSWFvnFnq5ZMgTqq P1RrnGJJdx9p1JytzRhi9M9vnIr4UUGMNfOOGuw/qvnCyYHXM67ka9leXs82ruK3 aZbHB7YZDSthklM3u+RX =r66h -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings.
by Marvin April 16, 2015

April 16, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12822 Your paranoid android. === wxppro (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2003std (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === wvistau64 (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2008s64 (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w7u (32 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1 === wvistau64 (64 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out === w2008s64 (64 bit sysparams) === sysparams.c:2958: Test failed: ChangeDisplaySettingsEx failed, -1 sysparams.c:2961: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out

1 0

Re: [PATCH 3 / 2] d3d9: Add support for d3d9ex formats
by Sergey Isakov April 16, 2015

April 16, 2015

Ignore, please, this is included in previous patch. Sorry! On 16.04.2015, at 12:47, Sergey Isakov wrote: > just forget two lines in previous commit > <patch-d3d9ex-d3d9-device.txt>

1 0

Re: [PATCH 1 / 2] d3d9: Add support for D3D9ex new formats
by Stefan Dösinger April 16, 2015

April 16, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Do you know a game that needs these formats? Is there a d3d9 game that actually locks the depth buffer? Do Windows drivers support these formats? Am 2015-04-16 um 09:37 schrieb Sergey Isakov: > + case WINED3DFMT_D32_LOCKABLE: return D3DFMT_D32_LOCKABLE; > + case WINED3DFMT_S8_LOCKABLE: return D3DFMT_S8_LOCKABLE; WINED3DFMT_D32_LOCKABLE doesn't exist yet. Your patches are in the wrong order. > diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c > index 174fc13..6934528 100644 > --- a/dlls/d3d9/tests/device.c > +++ b/dlls/d3d9/tests/device.c > @@ -2199,6 +2199,8 @@ static void test_display_modes(void) > TEST_FMT(D3DFMT_R8G8_B8G8, D3DERR_INVALIDCALL); > > TEST_FMT(D3DFMT_D16_LOCKABLE, D3DERR_INVALIDCALL); > + TEST_FMT(D3DFMT_D32_LOCKABLE, D3DERR_INVALIDCALL); > + TEST_FMT(D3DFMT_S8_LOCKABLE, D3DERR_INVALIDCALL); Please add a test that actually uses the format and locks them. It's ok if parts of the test (those that depend on depth transfers to / from system memory) are marked todo since wined3d doesn't handle depth locking at all. > + /* d3d9ex formats */ > + /* Z-Stencil formats valid for CPU access */ > + D3DFMT_D32_LOCKABLE = 84, The second comment is misaligned and I don't think these comments add much information. > + // s10e5 formats (16-bits per channel) This is an unrelated change. C++ comments ("//") are not allowed in Wine as our sources are plain C. > + // Monochrome 1 bit per pixel format > + D3DFMT_A1 = 118, > + // 2.8 biased fixed point > + D3DFMT_A2B10G10R10_XR_BIAS = 119, > + // Binary format indicating that the data has no inherent type > + D3DFMT_BINARYBUFFER = 199, Adding those is OK, but should be in a separate patch. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVL4cnAAoJEN0/YqbEcdMw6eMP/2b06nt5c3E9Stwm52T7l3aZ ytyrBcrqT7lE2XHVEhFH6te/NSgUXO5KYPqkgZQfx+/YvmnnevXeA1jfIMh5wOoD trBXmIDbhtgt1ABXmOB6CmN710B3zLBwnxMj4rUfiZAHgW4T6aONKxy4VmNGNxnl i5QxgMBOJbsAocu5URUpeiyGd87f3YWD1mTcrtAjwgTSNyF33VAx7O0zcV7Iui9e NY5fzYG7ff19zcPKRDIuOO0/ga93yYh6OcesiyUon+CHh+PxCcnztdXuNA6uIf2X N+OOudRbWrgnrpGbhudraRgoQOXIl+Sg1chX97qmPdtgz8Ftgf98yBWMld+QKllW fbTa8mIyiZBdO+0hTRYeiSMdDH0q4PnBbetvPW1lLRHVIlNqbL67yi4q9F+nvRoz jv5ueaz8S4iflG57ZVBVjmBok4QMxoX34J1V3M/qahsWhK1+hFVKXM7cJn9j0hNW H6GS/HdNA35yqwNJyKQdj3i2P1ptom39vLqHLlPCmX9okjiTSXfrtDsJBZdsHNC3 GP9uJWZnhE61rTmlwQ1vpdxZvVUp8whIgsgu9GWX7KaDXa3kYSf58sjE5aEAuKhh 4thc8OElq1BzRPHRIZNbyUoqZ6qHELYt88UNMA74obHun69UOeyvN2MIKn8wvTDh wIttvErryrAqz5+mFjKK =r5/p -----END PGP SIGNATURE-----

1 0

Re: Andrew Eikum : winecfg: Use a listview for speaker configuration.
by Bruno Jesus April 15, 2015

April 15, 2015

On Wed, Apr 15, 2015 at 10:43 AM, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: e17f4fd2f814a2a651c229ead4f86ab25130fe06 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=e17f4fd2f814a2a651c229ead… > > Author: Andrew Eikum <aeikum(a)codeweavers.com> > Date: Tue Apr 14 14:01:46 2015 -0500 > > winecfg: Use a listview for speaker configuration. This is much better, thanks Andrew.

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 8)
by Stefan Dösinger April 15, 2015

April 15, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, There are a few issues with this. They seem vaguely familiar to me, I think I have raised them before but they got lost in the list to array conversion: On 04/15/15 12:07, Alistair Leslie-Hughes wrote: > @@ -405,9 +405,48 @@ static HRESULT WINAPI IDirectPlay8AddressImpl_GetComponentByIndex(IDirectPlay8Ad > const DWORD dwComponentID, WCHAR *pwszName, DWORD *pdwNameLen, void *pvBuffer, > DWORD *pdwBufferSize, DWORD *pdwDataType) > { I assume you're supposed to write the name to pwszName if it is non-NULL, and check *pdwNameLen against the string length first. > + entry = This->components[dwComponentID]; > + > + if(*pdwBufferSize < entry->size) > + { > + *pdwBufferSize = entry->size; > + return DPNERR_BUFFERTOOSMALL; > + } It seems to me that it should assign *pdwDataType and *pdwNameLen in this case. The test should be extended to explicitly check the assigned lengths. Your code never sets *pdwNameLen, and it sets *pdwDataType only if the buffer is big enough. The concern about assigning *pdwDataType in the buffer to small case also applies to GetComponentByName. > + switch (entry->type) > + { > + case DPNA_DATATYPE_DWORD: > + memcpy(pvBuffer, &entry->data.value, sizeof(DWORD)); > + break; > + case DPNA_DATATYPE_GUID: > + memcpy(pvBuffer, &entry->data.guid, sizeof(GUID)); > + break; Assignments should be enough in these cases. The same applies to the existing GetComponentByName code. A semi-related problem in the existing GetComponentByName code: > if(!pwszName || !pdwBufferSize || !pdwDataType || (!pvBuffer && pdwBufferSize)) > return E_POINTER; The second check for pdwBufferSize is redundant, you already established it is not NULL. I assume that's supposed to be *pdwBufferSize. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVLj+3AAoJEN0/YqbEcdMws+UP/0q9wkiDyPPLi5+tbp8NXPKZ NItf38ksjFeForuNvmRt/Q0MAvQeJ0CSpqoyk3nH9G0EvcNQPXEpBHBCiL7aqUVU HN0OWc07OANPPrvAVqNRAVVaaAr1v9NFd+CJFNqNf7d0uOj0D1GMJtvJw+1ia06P qFfAUIIRSf1ay4RocO2HyAsaYwtps15Pib067jBJT/iVriMJQuflB9WRBy6BmKrR DM0PzySi3+quFjl+tYKUitUeR4RgGsMXUSx8V3l03929Y1duRO0uSfzAs18Mquqh wovE36jJfYhpBhJa7oAI9CVkNvr/EBMSVzHtBOGWM6mewMI3CGrfn+ZLxjOe1kk3 pIFXfIlbBBTZJYusL8fOxL0itacE2+YB5Opzi2K6TyNfnqWHscR5g7q+JH6iIe4k /JepaI2mqPsD2RgvM7SKBH2s6qz+cfd7uHWiW+QzzVEqIixbb3eJm1raR9p2UMAb +aJ9XPYpIeRzy8+BxCXLWhd5GQIFOSlUisQwxbwM9a/d9URFgcLS2KDX3ZjPPBcL hTOCS3jDiIfjf5lTpl1wj/rb+9zmK0JkpFyf6/EbxZEThP/fNuwSHtIYaY/4UO97 H9bpWYI5x1N7VnXaAFhCy9uwMeJ05ZYj0AhVl70S4Q1pHsFSX5XWumTOpfxXtJhH WRMpPPalUDabz3fPcAgG =rxp6 -----END PGP SIGNATURE-----

1 0

Re: msvcrt: improve accuracy of exp/pow/cosh and sinh
by Ruslan Kabatsayev April 14, 2015

April 14, 2015

Hi, Are you sure this will be of any use if one selects SSE instead of x87 instruction set to handle doubles (like -mfpmath=sse)? No one guarantees the functions like sinh will be evaluated on x87 FPU and even that this legacy instruction set will used at all. Regards, Ruslan On Sat, Apr 4, 2015 at 7:40 PM, Zheng Chen <chanchengcc(a)gmail.com> wrote: > The default fpu_cw = 0x27f makes the exp/pow/cosh/sinh functions producing > less accurate results. This patch temporally changes fpu_cw to 0x37f in > these functions for more accurate results. > > Thanks to Qian for his ideas. > > This patch fixes parts of these two bugs: 37149, 37150 > > >

2 1

i3, i5, i7 benchmarks building wine-1.6.2
by Dan Kegel April 13, 2015

April 13, 2015

Hi folks, in case anyone's wondering how fast a cheap computer builds wine these days, I did a little benchmark on the family computers. The benchmark was: $ sudo apt-get build-dep wine $ apt-get source wine $ cd wine1.6-1.6.2/ $ time debuild -b -uc -us $ dh clean $ time debuild -b -uc -us -j4 Results: Vintage CPU Ubuntu Time -j1 Time -j4 Details (model, barebones price) 2015 i3-4130 15.04b2 23m31s 12m16s http://kegel.com/new-computer-2015.html (ts140, $250, no drive) 2014 i5-4460 14.04 21m25s 8m12s http://kegel.com/new-computer-2014.html (h530, $426 including 1TB drive) 2010 i7-920 14.10 35m47s 13m44s http://kegel.com/new-computer-2010.html (ASRock x58 Extreme, $800, no drive) I'll probably semi-retire the ol' i7 and replace it with another ts140 soon, partly to save power, and partly to beef up my LAN party capabilities :-) (My new house has been averaging 22 kwh/day lately; switching from the i7 to the i3 will save something like 0.5 kwh/day on days when I work at home. Hope to add solar panels and go carbon-neutral sometime, but gotta fix the chimneys, replace furnaces with heat pumps, insulate, and replace the roof first.) - Dan

1 0

Re: dsound: Fix conning formula to correctly interpolate volume.
by Andrew Eikum April 13, 2015

April 13, 2015

On Sat, Apr 11, 2015 at 03:44:14PM +0000, Igor Kotrasinski wrote: > > Original formula is obviously wrong (plug in a large flAngle and a small cone difference). This one does correct linear interpolation. Makes sense to me. Thanks! Andrew

1 0

Re: [PATCH] dsound: Stricter validation for formats in secondary buffers
by Marvin April 13, 2015

April 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12777 Your paranoid android. === wxppro (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032 === w2003std (32 bit dsound) === dsound.c:1401: Test failed: secondary: SetFormat: 88780032

1 0

Re: [PATCH] shell32: Add more knownfolders
by Marvin April 13, 2015

April 13, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12776 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: winejoystick.dev: Add Graphics Driver connection for winejoystick.drv
by Charles Davis April 13, 2015

April 13, 2015

I do not agree with this particular direction. You do realize that some people on Mac OS still use the X11 driver (e.g. to get virtual desktop support), right? With these patches, these people suddenly won’t have any joystick support at all. Don’t get me wrong, I still think putting all the joystick code in one place is the right thing to do. I just don’t think that one place should be the graphics driver. Chip

5 7

Re: mshtml: Remove nsIDOMWindowUtils::SetCriticalDisplayPortForElement.
by Alexandre Julliard April 13, 2015

April 13, 2015

Thomas Faber <thomas.faber(a)reactos.org> writes: > This function is no longer present in Wine Gecko, so this re-aligns > the vtable. > > See https://www.winehq.org/pipermail/wine-devel/2015-April/107319.html It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so activex && touch activex.ok activex.c:1320: Test failed: unexpected call InPlaceDeactivate activex.c:1066: Test failed: unexpected call Close activex.c:1041: Test failed: unexpected call SetClientSite_NULL activex.c:1761: Test failed: OnUIActivate failed: 8000ffff activex.c:1716: Test failed: GetContainer failed: 8000ffff activex.c:1717: Test failed: container == NULL wine: Unhandled page fault on read access to 0x00000000 at address 0x7ecb5066 (thread 003a), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: Avoid four instances of "logical not is only applied to the to the left hand side".
by Henri Verbeet April 13, 2015

April 13, 2015

On 12 April 2015 at 23:04, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Indrek suggested that in this specific case the alternate approach > below also should work, so let me provide this as an option in case It probably would, but note that that doesn't do quite the same thing. BOOL values aren't restricted to TRUE/FALSE, so in principle there's no reason "ret" couldn't be e.g. ~0u. You'd need something like "!ret != !ie10_cache" to preserve the original behaviour, but I'm not sure that's really much better.

2 2

Re: winecfg: add all Windows versions and accompanying error message (try 3)
by Andrew Eikum April 12, 2015

April 12, 2015

On Thu, Apr 09, 2015 at 05:42:36PM -0700, Jason Overland wrote: > @@ -399,9 +401,49 @@ static void on_remove_app_click(HWND dialog) > SendMessageW(GetParent(dialog), PSM_CHANGED, (WPARAM) dialog, 0); > } > > +static INT_PTR WINAPI win_ver_error_dlg_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) This function should be guarded by an #ifdef. On my 32-bit build, I get: appdefaults.c:404:90: warning: ‘win_ver_error_dlg_proc’ defined but not used [-Wunused-function] > @@ -159,6 +159,22 @@ BEGIN > COMBOBOX IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP > END > > +IDD_WINVERERROR DIALOGEX 100, 100, 238, 95 > +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU > +CAPTION "Error: Invalid selection" > +FONT 8, "MS Shell Dlg" > +BEGIN > + LTEXT "This Wine prefix is built to support 64 bit applications. \ > + Because the Windows version you selected does not support 64 bit applications, \ > + this prefix cannot be configured to mimic that version of Windows.", > + IDC_STATIC,5,5,220,40 > + CONTROL "Please refer to \"How do I create a 32 bit wineprefix on a 64 bit system?\" \ > + in the \"Using Wine\" section of the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> \ > + for instructions on how to create a 32 bit Wine prefix.", > + IDC_WIN_VER_TEXT,"SysLink",0,5,40,220,70 For some reason, this renders without a space between "the" and the "Wine FAQ" link. Also half of the last 'x' and the period are cut off. It could be an issue on my system. I'm not very familiar with how RC files work. Other than those issues, it seems to work as intended. Andrew

3 2

Re: wined3d: Load ModelView matrix for glLightfv calls.
by Matteo Bruni April 11, 2015

April 11, 2015

2015-04-11 17:16 GMT+02:00 Joachim Priesner <joachim.priesner(a)web.de>: > Analogous to the light() function in state.c, the correct ModelView matrix > has to be loaded when glLightfv is called. The code to load/restore the > matrix is copied from there. > --- > dlls/wined3d/glsl_shader.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 1a1b6b0..2422982 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -7208,6 +7208,11 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > > context->constant_update_mask |= WINED3D_SHADER_CONST_FFP_MODELVIEW; > > + /* Light settings are affected by the ModelView transform in OpenGL, the View transform in Direct3D. */ > + gl_info->gl_ops.gl.p_glMatrixMode(GL_MODELVIEW); > + gl_info->gl_ops.gl.p_glPushMatrix(); > + gl_info->gl_ops.gl.p_glLoadMatrixf(&state->transforms[WINED3D_TS_VIEW]._11); > + > for (k = 0; k < gl_info->limits.lights; ++k) > { > if (!(light = state->lights[k])) > @@ -7218,6 +7223,8 @@ void glsl_vertex_pipe_view(struct wined3d_context *context, const struct wined3d > checkGLcall("glLightfv dirn"); > } > > + gl_info->gl_ops.gl.p_glPopMatrix(); > + > for (k = 0; k < gl_info->limits.clipplanes; ++k) > { > if (!isStateDirty(context, STATE_CLIPPLANE(k))) > -- > 1.8.4.5 AFAICS this patch is correct. Thank you Joachim!

1 0

Re: rpcrt4/tests: Fix a minor leak (Valgrind)
by Marvin April 11, 2015

April 11, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12764 Your paranoid android. === wvistau64 (64 bit ndr_marshall) === No test summary line found === w2008s64 (64 bit ndr_marshall) === No test summary line found

1 0