April 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 1/2] ws2_32: Fix compile on OS X.
by Bruno Jesus April 6, 2015

April 6, 2015

On Sun, Apr 5, 2015 at 4:07 PM, Socapex <philippe.groarke(a)gmail.com> wrote: > If HAS_IPX isn't defined, compilation will throw error since > WS_IPX_* aren't declared. > --- > dlls/ws2_32/socket.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 09c8416..bc4d40a 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -365,6 +365,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKLEVEL(WS_NSPROTO_IPX); > switch(optname) > { > +#ifdef HAS_IPX > DEBUG_SOCKOPT(WS_IPX_PTYPE); > DEBUG_SOCKOPT(WS_IPX_FILTERPTYPE); > DEBUG_SOCKOPT(WS_IPX_DSTYPE); > @@ -372,6 +373,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKOPT(WS_IPX_MAXSIZE); > DEBUG_SOCKOPT(WS_IPX_ADDRESS); > DEBUG_SOCKOPT(WS_IPX_MAX_ADAPTER_NUM); > +#endif > } > break; Hi, unfortunately I don't have OSX so I only test my patches in Linux and FreeBSD, so sometimes these problems happen, sorry. I think it's better to simply remove the #ifdef around wsnwlink.h [1], this will not reduce the debug capabilities of debugstr_sockopt. Since wsnwlink.h is an internal include it will always be available, can you it, please? [1] From socket.c: 160 #ifdef HAS_IPX 161 # include "wsnwlink.h" 162 #endif Best Regards, Bruno

2 1

Re: [PATCH 2/2] ws2_32: Remove trailing white-spaces.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-04-05 um 21:07 schrieb Socapex: > -/* Note: EAI_NODATA is deprecated, but still > +/* Note: EAI_NODATA is deprecated, but still Generally we don't commit whitespace-only changes because they cause problems with git blame (though git blame has been improved in that regard) and merges. Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIYsNAAoJEN0/YqbEcdMwLUEP/jy+kbilEFxb+W5HrbvV5x4Y GKTrrE0sBYv3RmcLEdCEmivTt5BOHerIxmoy5Li2wsH/S1FglwcdVETTBBG9v8tV 0dEgJ/p3GAB8RPQTRtvHTyr5aiUqOQg0HNW08puy/OHF3Zr3BTiFfzNLfKcVRTj5 Vvp28AwThDTqjG85ajOezBfxw/H6g4D8GtmsETYr2NYQZD9lt+C28op9K5hxSuA9 E05Af00Rxye7qb8ry715cAbBg2nO/MDygRt5iYpCX6Rd8fmRuM5O27MJLDQkq/pU GDKilQuWmiwZPEQcs3PKbOql3xditgvLrGKk4jkYAiXfTtaxIvwz9GDA6KVXynom Hv/m2BFKV1odoBYkDWlZZ42XVj1aZFKFZIknVTddDoRN/AVfTBO3cz5TPWOwr0q3 jGWOBT31ksWStdXOaQsPyUjX7ZKws2T2ZTRZTKoY0o/c/LYAXIgqz0VNwVnVaIs2 x+xlrdEpg58E1JuLBL93F0z3Pe+YQXqdv3RhWNSgzosK3VmaEC8+GzWBUR8gQMlJ UW0WRSycE9AktMGJv1+Grf/PIk8pHRN+4veL4065M5a4jaeclghx/HxqswuI8WCV Ty1qe5eHeNbD/9cEzbRSHBOV5g/V+xmvgzY5M0DJ2TTSMchmkJzC00m0khRMWhaj JMLgp7jnoWasLLA2ufZH =MEUF -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] ws2_32: Fix compile on OS X.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, You have to use your real name, not a nickname. We need this to be able to show where our code comes from. With best regards, Stefan Am 2015-04-05 um 21:07 schrieb Socapex: > If HAS_IPX isn't defined, compilation will throw error since > WS_IPX_* aren't declared. > --- > dlls/ws2_32/socket.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 09c8416..bc4d40a 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -365,6 +365,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKLEVEL(WS_NSPROTO_IPX); > switch(optname) > { > +#ifdef HAS_IPX > DEBUG_SOCKOPT(WS_IPX_PTYPE); > DEBUG_SOCKOPT(WS_IPX_FILTERPTYPE); > DEBUG_SOCKOPT(WS_IPX_DSTYPE); > @@ -372,6 +373,7 @@ static inline const char *debugstr_sockopt(int level, int optname) > DEBUG_SOCKOPT(WS_IPX_MAXSIZE); > DEBUG_SOCKOPT(WS_IPX_ADDRESS); > DEBUG_SOCKOPT(WS_IPX_MAX_ADAPTER_NUM); > +#endif > } > break; > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIYmzAAoJEN0/YqbEcdMwmcMP/0UWQMONOFklXHtI9ibTn5rU Y8idfpQRQEj7s4UqKT5XdHbbGsmGa24byBybhWf54z/ykTqcwvcun4xDUs0/pmCK WRWx9hlgGd4xPSGrnum9XC/tnywjyP5s8eyRUU4CeMmBOIwauj15iePd/v4W+BA+ iHTyY4rjzyoyatmZURoaZaFFj/n5cLoqyqQ+fTNeP22z+Wjl7N76wXYbsylRsatB NKe8bAdBAQZL8LNngjpCVXW0PsKaH88LIdVPZpvI0T+hH8+LYRToKbfqCXtwkwYb LuE9RCdfAcRbIQTCe4FrpfduGUtQN2Nlxu7pIOH9GghWITTjIZn/XV0VYSBVDrNc d2zZ0lmyEWPU6H5RU/dzfhkJMhKP7RzZkd3j7yDKsjBlC651ysDT6ev/HpX2Jx7O aYf70/48Qk5BhbEZblQuPrssz/p4ErXHz2UQRGodqLjJm+ATSwkSlwsAGZ8iyjn0 3JQuL3BDDSF3CAjfQBLfcRXS4tNgNd58rr5dfoLmOhkKG+LIbYIQ55104UG03xDc 5LFubLU8i8r89OBR3yeZXLIX3BdR3oxANVDoPjjbbJiAKIoej5yJOCyLb8cPbchN CufNxeiY+wrKNWtuW6UXONaEJqt2MpcY0HUV70s9qRXZ2iZoPKDFkR5mPudR7qbj ZIUAqSKGQcWwmCw+aEk+ =ShND -----END PGP SIGNATURE-----

1 0

Re: [PATCH 3/3] d3drm/tests: Split tests between different versions, initially adding frame QueryInterface tests.
by Stefan Dösinger April 5, 2015

April 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, This series looks good to me, and this time I ran the tests on Windows and Wine :-) Am 2015-04-03 um 14:25 schrieb Aaryaman Vasishta: > +struct qi_test > +{ > + REFIID iid; > + REFIID refcount_iid; > + HRESULT hr; > + BOOL refcount_todo; > +}; refcount_todo is always FALSE in your tables, so you might as well remove it. I don't think it's necessary to resend the patch because of that though. You can just remove it when you add the vtable inheritance test. If you expect future tests to need refcount_todo you can also keep the field. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVIWyeAAoJEN0/YqbEcdMwZPgP/AoYCerTMFiXH9lYnmueThK/ UPGcBOLhdU0dT0U8lI0ZVzX7mbvtvjoVFUn/cAGgBZTUH175BK3SHbuIljJ+R954 +xQtRda5QrEu759UIkuc6v+REUtNQWzPtWLRX8EhZLhTEJaTEdsGeGUKAKRwGFmc UsMEff5r1gIIFgFDSlwSm1daAduOwkNcnzFwbxTbm7Kg/qCn50nSTfWj4Nk/sYYl kr6vzKH5EAt5nL9tvtXT7q8YDu+e2TC96B2xzoseRnS3st44nAgqjSb9E7fB05Cu Lem/zEEoGJI3mrLWpoDVDoYFFaHPifoqRgyf6EcT9ID0vUmJhM97WgBWw0+b8fFR yxJ/nsBol56Rb4xssOrXINDfF2E+7S9RMu/oxSbVbW8GV3vN4ssgZ5/Q8itmCdJd u7Kyfx/OS72xE9rrUXIQrS0EM7yFq1j6cZa/xv6xGzO0SpeIbWrB2Pnujvr5GTt/ KkPqJVoiFr8VOaZfK2SQreGTaBK4f6rDdW+jkfnQLU38uVSmDTowdO3oD6aPCy2s mgB8JmhBuDsU5RAWoA61PzTtDPmdWLhmHZJWfLC4PG9/IN0m3G3JhFUAUy3qr8UZ 543kGtR21tmPHLKXc+Bt20B0j+RY0sxu8CvVJPb3qa7VmDP+c3thnjkgng1ZJo0F CrXo+6/IKapzItlvTFIE =ssTG -----END PGP SIGNATURE-----

1 0

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL (marvins test fix)
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12662 Your paranoid android. === w2000pro (32 bit locale) === locale.c:1776: Test failed: Without NORM_STOP_ON_NULL flag - strings `don\0a` (5) and `don\0b` (5) expected CSTR_LESS_THAN, got 2 === wvistau64 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w7u (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w8 (32 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === wvistau64 (64 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (64 bit locale) === locale.c:2010: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2014: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:2018: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:2022: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2028: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2032: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0

1 0

Re: [PATCH 1/7] advapi32: Initialize buffer length to zero in LsaLookupSids to prevent crash.
by Nikolay Sivov April 4, 2015

April 4, 2015

On 04.04.2015 17:22, Qian Hong wrote: > > (*Names)[i].Name.Buffer = NULL; > + (*Names)[i].Name.Length = 0; > + (*Names)[i].Name.MaximumLength = 0; Maybe it's better to hide this in RtlInitUnicodeStringEx(..., NULL) ?

2 1

Re: mshtml: Removed return to ensure AddRef is called on an internal interface
by Piotr Caban April 4, 2015

April 4, 2015

The patch is wrong, nsCycleCollectionISupports doesn't support AddRef/Release.

4 6

Re: locale: [1/1] patch - 0x10000000 flag is NORM_STOP_ON_NULL
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12661 Your paranoid android. === wvistau64 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w7u (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w8 (32 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === wvistau64 (64 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 === w2008s64 (64 bit locale) === locale.c:1985: Test failed: NORM_STOP_ON_NULL passed, though its equal to length autodetect (-1) - strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1989: Test failed: NORM_STOP_ON_NULL is not set, strings considered as null terminated - so strings `don\0at` (-1) and `don\__` (-1) expected CSTR_EQUAL, got 0 locale.c:1993: Test failed: NORM_STOP_ON_NULL passed, and lengths are defined exlicitly - so strings `don\0at` (6) and `don\__` (6) are expected CSTR_EQUAL due to flag, got 0 locale.c:1997: Test failed: NORM_STOP_ON_NULL passed, and length is defined exlicitly for one string - anyway strings `don\0at` (6) and `don\__` (-1) are expected CSTR_EQUAL due to flag, got 0 locale.c:2003: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, though its equal to length autodetect (-1) - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0 locale.c:2007: Test failed: NORM_STOP_ON_NULL | NORM_IGNORECASE passed, and lengths are defined explicitely - so strings `don\0at` (-1) and `dOn\At` (-1) expected CSTR_EQUAL, got 0

1 0

Re: [PATCH 7/7] advapi32/tests: Add more tests for LsaLookupSids and LsaLookupNames2.
by Marvin April 4, 2015

April 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12659 Your paranoid android. === w2003std (32 bit lsa) === lsa: unhandled exception c0000005 at 7C81BB52 === wvistau64 (64 bit lsa) === No test summary line found === w2008s64 (64 bit lsa) === No test summary line found

1 0

Re: msxml3: Explicitly list acceptable libxml2->msxml node types for unknode (try 2)
by Jacek Caban April 4, 2015

April 4, 2015

Hi Nikolay, On 01/04/15 22:41, Nikolay Sivov wrote: > + switch (This->node.node->type) > + { > + case XML_ELEMENT_NODE: > + case XML_ATTRIBUTE_NODE: > + case XML_TEXT_NODE: > + case XML_CDATA_SECTION_NODE: > + case XML_ENTITY_REF_NODE: > + case XML_ENTITY_NODE: > + case XML_PI_NODE: > + case XML_COMMENT_NODE: > + case XML_DOCUMENT_NODE: > + case XML_DOCUMENT_TYPE_NODE: > + case XML_DOCUMENT_FRAG_NODE: > + case XML_NOTATION_NODE: Most of those types have their own IXMLDOMNode implementations, so they should never be the case in here. Also, ideally we shouldn't even create unknode object for types that are not supported, so it should be fixed in create_node or its callers. Is it possible in the case that you're fixing? Jacek

2 1