May 2015 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Speed of gdi vs opengl DirectDrawRenderer
by Jonas Maebe Oct. 11, 2015

Oct. 11, 2015

Hi, I had a problem with Majesty Gold HD running at glacial speed on my machine (quad Core i5 2.9GHz, NVidia GeForce GT 750M 1GB, OS X 10.9.5). I'm using wine 1.7.35, but I've had similar problems with older wine versions. It's a DirectDraw7 game that has been partially remastered to run on modern systems, but still uses DirectDraw7. This is a common problem on Windows too, but generally can be resolved by telling the game to use the DirectDraw blitter (instead of blitting itself). That didn't help on Wine though. I profiled wine (Instruments time profile) and noticed that most time was spent in wined3d's convert_r5g6b5_x8r8g8b8. Replacing that routine with an optimized sse2 version from pixman did not make much of a difference. Then I discovered that if I told the game to render to a 16 bit instead of to a 32 bit surface, wine would let OpenGL handle the colour conversion. Unfortunately, while this significantly reduced wine's cpu usage, it by no means made the game any faster. Looking at the OpenGL Driver Monitor stats, it seems the cpu was simply waiting all the time on the GPU, probably while it was blitting all of those 1920x1080 images to the screen. Reducing the resolution to the lowest supported by the game (800x600) made it slightly faster, but not much. Next, I added the DirectDrawRenderer registry key and set it to gdi. Now, while it's still slow at 1920x1080, the game runs much faster at 800x600 and even still at 1024x768. Profiling the gdi renderer shows that it has way higher cpu usage than the OpenGL renderer (virtually all in convert_to_8888), but it seems that for some reason it has causes much less traffic to the GPU. The wiki's wording suggests the gdi renderer is deprecated though. Does that mean this qualifies as a bug in the OpenGL renderer (maybe it tries to update the screen more often than necessary, saturating the bus that way?), and are there any things I can try to narrow down why the gdi renderer is so much faster? I didn't immediately see where it blits things actually to the screen. Thanks, Jonas

4 10

[PATCH] Use asserts for mmap failure modes
by Michael Gilbert July 26, 2015

July 26, 2015

Hi, Using exit in shared libraries is a discouraged practice, and wine's mmap implementation currently does that. I attach a proposed change using asserts instead. Let me know if you have any feedback. Best wishes, Mike (btw I'm the debian wine maintainer)

2 2

Re: XInput [1/4]: Implement XInputGetState
by Stefan Dösinger July 5, 2015

July 5, 2015

Am 09.07.2009 um 02:58 schrieb Michael Gruber: > This patch series implements parts of the XInput library. You can use > this to play games that support Xbox 360 Controllers. To be able to > use this you will need to have your Controller working on Linux via > the xpad kernel driver and the event interface. It will not work on > any OS other than Linux. It supports gamepads, should work with > guitars and wheels, but will not work with dance-mats. > <1-XInputGetState.patch> Is it possible to implement XInput on top of DirectInput? DirectInput already has some internal abstraction layers for differnet joystick APIs, and has basic support for OSX joysticks. Does DInput have enough capabilities to access all the Xbox controller's features? My gut says no, otherwise MS wouldn't have created a new lib. I guess its worth checking though.

5 6

Re: [1/3] include: Add stuff related to WSAPoll() (try 2)
by Alexandre Julliard June 12, 2015

June 12, 2015

Bruno Jesus <00cpxxx(a)gmail.com> writes: > try 2: > I found the solution to typedef the struct pollfd just like it's done > with fd_set. Unfortunately that doesn't work on mingw: In file included from ../../../wine/include/winsock2.h:50:0, from ../../../wine/include/ws2tcpip.h:22, from ../../../wine/dlls/jsproxy/main.c:34: ../../../wine/include/winsock2.h:287:19: error: redefinition of ‘struct pollfd’ ../../../wine/include/ws2def.h:27:18: note: in definition of macro ‘WS’ In file included from ../../../wine/dlls/jsproxy/main.c:20:0: ../../../wine/include/wine/port.h:284:8: note: originally defined here -- Alexandre Julliard julliard(a)winehq.org

3 4

mciqtz32: Guarantees that CoInitialize and CoUninitialize run on the same thread.
by Joerg-Cyril.Hoehle＠t-systems.com June 9, 2015

June 9, 2015

Aki, if I understand your critical section well, you serialize all accesses to the individual player thread. This may be ok for commands that return immediately, e.g. STATUS, but the MCI knows commands that may take a long time, in particular PLAY, RECORD and even SEEK. Did you run a test like this: CreateTask { SetEvent started MCICommand(MCI_PLAY, "av_file_that_takes_3_minutes.avi", MCI_WAIT); } Wait(started); Repeat 10 times { MCICommand(MCI_STATUS,MCI_POSITION); printf MCICommand(MCI_STATUS,MCI_MODE); Printf Sleep(2s); } Wait(thread); I would expect all MCI commands "STATUS POSITION" etc. to work while another thread is busy playing a file synchronously (using MCI_WAIT). Furthermore +static LRESULT MCIQTZ_relayTaskMessage [...] + if (WaitForSingleObject(wma->task.done, INFINITE) == WAIT_OBJECT_0) Are you sure it's ok to block the user thread like this? Shouldn't the code use a loop that also pumps the MS-Windows message queue and dispatches messages? E.g. there may be a need to dispatch REFRESH and PAINT messages? Did you cross-check what MS-Windows does here? On a related note, IIRC some wine devices use a more reliable approach to waiting: WaitForMultiple(2 objects: [task.done, task.threadId], INFINITE); That way, should the player crash or exit somehow, the main (user) task doesn't hang. Regards, Jörg Höhle

2 4

Wine 64 bit
by Kevin Davies June 5, 2015

June 5, 2015

Hello, Where would you find information on wine64 status for running 64 bit windows software under OSX. These days a lot of Windows programs are going 64bit to make use of the available memory. Its becoming necessary to have this capability. Many thanks Kevin

13 31

programs/regsvr32 patches
by Hugh McMaster June 4, 2015

June 4, 2015

Excuse me, I've looked through patches 111564-111568 and have only found one minor issue. In patch 111565 I forgot to include ctype.h for tolower(). Was there a problem with the input comparison handling, or something else? The changes to the input handling make conversion to unicode much easier and cleaner. I realise that patch 111565 looks complex, but it's just the indenting. -- Hugh McMaster

1 1

Fix GetRawInputDeviceList() to return ERROR_INSUFFICIENT_BUFFER
by achurch＠achurch.org June 1, 2015

June 1, 2015

(Note: I am not subscribed to the list; please CC me on any replies.) When GetRawInputDeviceList() is passed a buffer which is too small, the function should set the last error code to ERROR_INSUFFICIENT_BUFFER and return failure (see <http://msdn.microsoft.com/en-us/library/windows/desktop/ms645598(v=vs.85).a…>). However, the current Wine implementation does not set the last error code, meaning that callers expecting to see ERROR_INSUFFICIENT_BUFFER will behave incorrectly. I've confirmed that Windows itself (at least XP and 8) matches the documented behavior. See also: https://bugs.winehq.org/show_bug.cgi?id=37667 --Andrew Church http://achurch.org/ diff -urN wine-1.7.43-orig/dlls/user32/input.c wine-1.7.43/dlls/user32/input.c --- wine-1.7.43-orig/dlls/user32/input.c 2015-05-15 22:36:39 +0900 +++ wine-1.7.43/dlls/user32/input.c 2015-05-25 22:47:49 +0900 @@ -507,6 +507,7 @@ if (*device_count < 2) { *device_count = 2; + SetLastError(ERROR_INSUFFICIENT_BUFFER); return ~0U; } diff -urN wine-1.7.43-orig/dlls/user32/tests/Makefile.in wine-1.7.43/dlls/user32/tests/Makefile.in --- wine-1.7.43-orig/dlls/user32/tests/Makefile.in 2015-05-15 22:36:39 +0900 +++ wine-1.7.43/dlls/user32/tests/Makefile.in 2015-05-25 22:48:27 +0900 @@ -17,6 +17,7 @@ menu.c \ monitor.c \ msg.c \ + rawinput.c \ resource.c \ scroll.c \ static.c \ diff -urN wine-1.7.43-orig/dlls/user32/tests/rawinput.c wine-1.7.43/dlls/user32/tests/rawinput.c --- wine-1.7.43-orig/dlls/user32/tests/rawinput.c 1970-01-01 09:00:00 +0900 +++ wine-1.7.43/dlls/user32/tests/rawinput.c 2015-05-25 22:44:36 +0900 @@ -0,0 +1,43 @@ + /* Unit test suite for the rawinput functions + * + * Copyright 2015 Andrew Church + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define WINVER 0x0501 + +#include "wine/test.h" +#include "windef.h" +#include "winbase.h" +#include "winuser.h" + +static void GRIDLShortArrayTest() +{ + RAWINPUTDEVICELIST devices[1]; + UINT device_count = 1; + int result, error; + + result = GetRawInputDeviceList(devices, &device_count, sizeof(*devices)); + ok(result == ~0U, "wrong result: %d\n", result); + ok(device_count >= 2, "wrong device_count: %d\n", device_count); + error = GetLastError(); + ok(error == ERROR_INSUFFICIENT_BUFFER, "wrong error code: %d\n", error); +} + +START_TEST(rawinput) +{ + GRIDLShortArrayTest(); +}

2 1

Re: [PATCH 2/5] riched20/tests: Small test for GetClientSite()
by Marvin May 31, 2015

May 31, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13718 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 0042D1B0 === wxppro (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 0042D1B0 === w2003std (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 0042D1B0 === wvistau64 (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at A574D492 === w2008s64 (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 00000000 === w7u (32 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 10000000 === w8 (32 bit richole) === richole.c:1526: Test failed: got wrong pointer === wvistau64 (64 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 0000000000426DF0 === w2008s64 (64 bit richole) === richole.c:1526: Test failed: got wrong pointer richole: unhandled exception c0000005 at 000007FEFEE619B8

1 0

Re: [PATCH 1/2] msvcp110: Add _File_size implementation and test.(try 2)
by YongHao Hu May 29, 2015

May 29, 2015

Sry, Slackner found that I still used %llx /%llu as I misunderstood Piotr's comment and there are typos in the patch. I will fix all the issues later. :P On 2015年05月29日 21:16, YongHao Hu wrote: > try2: > Improve the patch according to Piotr's advices. > Add errno and SetLastError test. > --- > dlls/msvcp110/msvcp110.spec | 4 +- > dlls/msvcp120/msvcp120.spec | 4 +- > dlls/msvcp120/tests/msvcp120.c | 75 > +++++++++++++++++++++++++++++++++---- > dlls/msvcp120_app/msvcp120_app.spec | 4 +- > dlls/msvcp90/ios.c | 20 ++++++++++ > 5 files changed, 94 insertions(+), 13 deletions(-) > >

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 12)
by Stefan Dösinger May 29, 2015

May 29, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, This version of the patch looks good to me. Stefan Am 2015-05-29 um 12:06 schrieb Alistair Leslie-Hughes: > Hi, Add WARN on errors. > > I'll add more tests in another patch, which simplifies the > component list. > > Changelog: dpnet: Implement IDirectPlay8Address > GetComponentByIndex > > > Best Regards Alistair Leslie-Hughes > > > > > > > > > > > > > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVaE3VAAoJEN0/YqbEcdMwqIAP/iHHkRWQmGrZnoKbvuXuYJ9i caO0PB0akO3CvyLDcC68CMtT7jQ7gthTGPiXTHe4sEjmSR3KLoqajV2TX+JluWYj s/uTxbmPjNvafeXmflSpaoy0BRq5H/D+99AkKqo/GFPlCNT0UJpR9sD7OsXXA1E9 Cq7VpKMGqgnWoLf4/pRge/rBfV2vV0FOLhHTzboEyUOTgGegOI8v345vMw/Ph7RM YPEdLYUBkIwZZuZaDtaZ9DV5HyFG1fH65cYftkQFmM7tH4Sn1NiQcNHEUmPeX3Bc hv5Q9QOshwtWgQKhWe98YyGayP16Ip0iKDpxRZ28LEcOcKfK9URX66lBNWZjL/Ci IixsgZw12okh8Wn+Q76LwIh1PakpQSHZ/iQW8qDYlyWIRboFC+VyQoemkXxvUfVS VwqAe/D1uWAf1o6BD6vHNarH7A5ymHvxmcxw/1PxTGSZg4RBqOmt4/4gCWIuPXzX 564O8wrDn1msVhwS6tqpP85Sg3ydDYiPDVZNVigJAU/kMCiPH2WbXPxUGB/Pc7hA 4QaOK6FDTxXlTqEO0FHm12DU2bYzBMogOd0N6usKzVQe2kdy9hB4/hUo8+vojamS AI0agXg+a6UjVhTpNZvoZAxC0rFF6nEJaL6MgDS64LtmT6wrrri6hEtmPJM6aC/O 2bdo052EPFKWbfytsTK+ =jq9B -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 12)
by Marvin May 29, 2015

May 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13666 Your paranoid android. === w8 (32 bit address) === Failure running script in VM: timed out waiting for the child process

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 11)
by Stefan Dösinger May 29, 2015

May 29, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, There's one major problem I missed previously: Am 2015-05-29 um 10:22 schrieb Alistair Leslie-Hughes: > + case DPNA_DATATYPE_STRING: > + memcpy(pvBuffer, &entry->data.string, entry->size); > + break; This won't work. There's a & too much. Please consider adding tests for String and Binary types to catch this kind of thing. GetComponentByName once had the same problem I believe. Minor stuff: > + TRACE("(%p)->(%d %p %p %p %p %p)\n", This, dwComponentID, pwszName, pdwNameLen, pvBuffer, pdwBufferSize, pdwDataType); pdwNameLen, pvBuffer, pdwBufferSize, pdwDataType); A DWORD is unsigned, %u is better. > + if(*pdwBufferSize < entry->size || *pdwNameLen < namesize) > + { > + *pdwNameLen = namesize + 1; > + *pdwBufferSize = entry->size; > + *pdwDataType = entry->type; > + return DPNERR_BUFFERTOOSMALL; > + } You forgot to add a WARN here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVaCrwAAoJEN0/YqbEcdMwypEP/RttOLSqc6fQQW4XeMkBgVaS aiKUyYSysq9MnRoqP32A6lKq9LHpW23liKsvpwoWegdarTc35ENYwG7pLSLJuOIy i/e7AlWGLDphN9qdYMU0oCQ8PXGU8Y3Mb7kozZcnYm9EuYoJEFIiAYHtx4nFeGMj rVx/mruLmYTdgyR378iE4cYqNeMwzK7YtGNRHMPz8FNTzdLyzUu1blYQ8cYEbzAk Mm4RaIixByzKiGO7qUPCX4OOgYoohBOgMRiVWTJfZLrhKY0vyj0x2Jt5GWCzWeht 7mszNRRpvW+v60axT2xwemXmQSobjgjnddF0bwxC/vHZisfXF8H52lLgupXv9KRo efOsvX3lTpJstEL1Wt61NL/MqF4vwRjbrWeKD45DxHEzPX8wzUg4yFodz/yxAAN1 /l4fuX8BEjr9tttV4uup4fdOlVhlX95ZujQFT5Ue1zF97SSLOC9id/8Uy8xlHYmY Ou0H9GG5rILqG5+r9m3OghjuQcwomL6T7BSLYJ+WncdTgtxRbarhMI/mq9m0MiB2 OHkUddm/zn9EFPboQsCjqRuPFa6fcbx+b/XUmyLeBjosO3j7Otws4TGUEkzjbvWF f3fOORfbxpknZH9GxVaEFWlyUerNSJ4C4hYp5J+pHS9N5u+L9KsN0fXYT9jqpvh2 Tmu94XyHSblAoeS1ORgq =M5Sz -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 11)
by Marvin May 29, 2015

May 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13665 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 5/5] wined3d: Always enable GL_PROGRAM_POINT_SIZE in the GLSL backend.
by Henri Verbeet May 29, 2015

May 29, 2015

On 28 May 2015 at 23:23, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -6987,6 +7006,13 @@ static void shader_glsl_select(void *shader_priv, struct wined3d_context *contex > GLuint program_id = 0, prev_id = 0; > GLenum old_vertex_color_clamp, current_vertex_color_clamp; > > + if (!ctx_data->backend_init_done) > + { > + gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE); > + checkGLcall("GL_PROGRAM_POINT_SIZE"); > + ctx_data->backend_init_done = TRUE; > + } > + Is this shared state between contexts? Otherwise you need to do this once for every context. Also, shader_glsl_select() is kind of a hot path, it may be better to just add an entry to struct wined3d_shader_backend_ops for this kind of initialization.

2 2

Re: [PATCH 9/11] qcap: add the SmartTee filter automatically as necessary, and test this
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13651 Your paranoid android. === w2008s64 (32 bit smartteefilter) === smartteefilter.c:1926: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1926: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1985: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1985: Test failed: couldn't create NullRenderer, hr=0x80040154 === w2008s64 (64 bit smartteefilter) === smartteefilter.c:1926: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1926: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1985: Test failed: couldn't create NullRenderer, hr=0x80040154 smartteefilter.c:1985: Test failed: couldn't create NullRenderer, hr=0x80040154

1 0

Re: [PATCH 8/11] qcap: get the SmartTee filter to a minimally functional level
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13650 Your paranoid android. === w2000pro (32 bit smartteefilter) === The test timed out

1 0

Re: [PATCH 7/11] qcap: implement the SmartTee allocator functions
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13649 Your paranoid android. === w2000pro (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === wxppro (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === w7u (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time === w8 (32 bit smartteefilter) === smartteefilter.c:1366: Test failed: timeout: threads did not receive sample in time

1 0

Re: winex11: Fix ctrl-<symbol> to generate codes below 0x20 where necessary.
by Marvin May 28, 2015

May 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13631 Your paranoid android. === wvistau64 (32 bit input) === input.c:731: Test failed: 0 (a4/0): 10 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): 11 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): a0 from 01 -> 00 unexpected input.c:731: Test failed: 0 (a4/0): a2 from 01 -> 00 unexpected

2 1

Save the Date: WineConf on September 19, 20 in Vienna
by Stefan Dösinger May 28, 2015

May 28, 2015

Hi, I am happy to announce that we will have a WineConf again this year: It will be on Saturday September 19th and Sunday September 20th 2015 in Vienna, in the InterCityHotel Wien. I have added some basic information to http://wiki.winehq.org/WineConf2015 , and more detailed information will follow soon. Please help by suggesting talk topics and adding them to the list. I will write another mail to the list once we have an RSVP page set up. Cheers, Stefan

1 2

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 10)
by Stefan Dösinger May 28, 2015

May 28, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I'm sorry for the late review. I completely forgot about this patch (also in the private mail you sent me). It looks good to me, except one issue noted below that I missed earlier. Am 2015-05-23 um 13:22 schrieb Alistair Leslie-Hughes: > index 7e10136..bad84ef 100644 > --- a/dlls/dpnet/address.c > +++ b/dlls/dpnet/address.c > @@ -405,9 +405,58 @@ static HRESULT WINAPI IDirectPlay8AddressImpl_GetComponentByIndex(IDirectPlay8Ad > const DWORD dwComponentID, WCHAR *pwszName, DWORD *pdwNameLen, void *pvBuffer, > DWORD *pdwBufferSize, DWORD *pdwDataType) > { > - IDirectPlay8AddressImpl *This = impl_from_IDirectPlay8Address(iface); > - TRACE("(%p): stub\n", This); > - return DPN_OK; > + IDirectPlay8AddressImpl *This = impl_from_IDirectPlay8Address(iface); > + struct component *entry; > + int namesize; > + > + TRACE("(%p)->(%p %p %p %p)\n", This, pwszName, pvBuffer, pdwBufferSize, pdwDataType); You're not tracing dwComponentID and pdwNameLen here. In particular dwComponentID seems important, as it is the thing that the method call retrieves. > + if(!pdwNameLen || !pdwBufferSize || !pdwDataType) > + return DPNERR_INVALIDPOINTER; > + > + if(dwComponentID > This->comp_count) > + return DPNERR_DOESNOTEXIST; As I've noted in other patches it would be a good idea to write a WARN in error cases, especially in a COM method where +relay can't be used to check return values. You can also print the available and required size in case of DPNERR_BUFFERTOSMALL. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVZvMGAAoJEN0/YqbEcdMww2sP+gJRvmzLAZ4oXx3FJFSPIvpn JsbdhoKeZkmdsTCPQjvfPVAUKj1qSQcm1w9rRFBthZhkVWNgXGDTbsbTmtVRiATz qqoX+MjKKQeguWmgnEiQY0k/NW15kAvUkP/vT1qQfKOyqadXJs1a6gli0zfqHSqO uviq2P5mQ82vvIYbv5rS8tAGBTh/FHd1802tSPcMGXQqrqqjW3UH/rV4DymP33FF IsSpPBt2niCz7jSt6QGg/8R9Q2xK8D2sOOe1CcLvtRzrh7Ws+j0p1B8Y73aX8047 s7Pp/oUgfmcEUGheeD+c1YlAQOW6Xp9urjiCc9Pqp+sJBv9fJ5p40r9A6wXrP/Jb Zkei91cF+XcwuhZysQX/qJCwff2VyqG55cDdS1R7DTva/DSamhFB6jYrRAjotgrT g4ulnkbVR4khDzJRVk4K9rxJ2OPwoUkPVpspjrKzuT7oEm2U31PVHPUQa8qeIWzr b1vLyDnG/Zz+B27yHc9sLfwZm5olWz2XTDht7kZKGMU2FRy1Q2wK0wZ6Q6ekB/f5 jnnQep7DmgsMe4EN175k5L5e3yW/SISk0U2O/VtukKMbZQ/hoIhHw8ieiaAo16MM S6nvCRbHxRCe9vB/0zKt5+5SAzWrTTsdw03qdeFg82PSGi6I/F7RrrQnY76GtYKB gtjHMs5QPp0FZRriR0T0 =MUbC -----END PGP SIGNATURE-----

1 0

Re: [PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.
by Alexandre Julliard May 27, 2015

May 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > On 27/05/15 14:12, Alexandre Julliard wrote: >> Not that it really matters, but I don't see why you'd need to change >> Wine in order to be able to write a test. > > How am I supposed to know if GetUserPreferredUILanguages fails because it's not implemented, > or fails for some other reason? That doesn't matter. You are testing the Windows behavior, so unless there's a Windows version that returns ERROR_CALL_NOT_IMPLEMENTED, you should never need to check for it. Once your test succeeds on Windows, you add todo_wine in places where Wine differs. Whether that's because the function is unimplemented, or because it's implemented but broken, doesn't make any difference as far as the test is concerned. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] msvcp110: Add _File_size implementation and test.
by Piotr Caban May 27, 2015

May 27, 2015

On 05/27/15 04:35, YongHao Hu wrote: > +/* filesystem */ > +static unsigned long long (__cdecl*p_tr2_sys__File_size)(char const*); You should avoid using "long long" type. Please e.g. use ULONGLONG instead. > + mkdir("tr2_test_dir"); > + file = CreateFileA("tr2_test_dir/f1", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + SetFilePointerEx(file, large, NULL, FILE_BEGIN); > + SetEndOfFile(file); Please test return values of CreateFile, SetFilePointerEx and SetEndOfFile. > + large.LowPart = 4000000000u; > + large.HighPart = 120; > + file = CreateFileA("tr2_test_dir/f2", GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); > + SetFilePointerEx(file, large, NULL, FILE_BEGIN); > + SetEndOfFile(file); > + val = p_tr2_sys__File_size("tr2_test_dir/f2"); > + ok(val == 519396075520 || broken(val == 0), "file_size is %llu\n", val); /* not enough storage on the testbots */ > + CloseHandle(file); Please remove this test. It's not a good idea to create ~500GB file in the tests. > + val = p_tr2_sys__File_size("tr2_test_dir"); > + ok(val == 0, "file_size is %llu\n", val); > + > + val = p_tr2_sys__File_size("tr2_test_dir/not_exists_file"); > + ok(val == 0, "file_size is %llu\n", val); It would be nice to test GetLastError and errno value after this calls. What happens if NULL is passed as the argument? > +ULONGLONG __cdecl tr2_sys__File_size(const char* path) > +{ > + WIN32_FILE_ATTRIBUTE_DATA fad; Please add a trace message. > + if(!GetFileAttributesExA(path, GetFileExInfoStandard, &fad)) > + return (ULONGLONG)0; This cast is not needed, you can just return 0 here. > + if(fad.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) > + return (ULONGLONG)0; > + return ((ULONGLONG)(fad.nFileSizeHigh) << (sizeof(fad.nFileSizeLow)*8)) + fad.nFileSizeLow; I think that it's better to simply write 32 instead of sizeof(fad.nFileSizeLow)*8 here. Thanks, Piotr

2 2

Re: libport: Fix build on PowerPC
by Grazvydas Ignotas May 27, 2015

May 27, 2015

On Tue, May 26, 2015 at 11:16 PM, André Hentschel <nerv(a)dawncrow.de> wrote: > It was broken by recent commits > --- > libs/port/interlocked.c | 15 +++++++++++++++ Maybe we could just drop all this powerpc specific code, especially considering missing cmpxchg64 implementation (better use mutex fallback there) and that some other platforms (ARM/ARM64) don't have any of this anyway and just use the fallbacks. Gražvydas

2 1

Re: [PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.
by Alexandre Julliard May 27, 2015

May 27, 2015

Mark Harmstone <hellas(a)burntcomma.com> writes: > I want to include GetUserPreferredUILanguages in a test I'm writing, but can't at present as > it doesn't return the stub error code. Not that it really matters, but I don't see why you'd need to change Wine in order to be able to write a test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] msvcp110: Add _Equivalent implementation and test.
by Piotr Caban May 27, 2015

May 27, 2015

On 05/27/15 04:36, YongHao Hu wrote: > +static void test_tr2_sys__Equivalent(void) > +{ > + BOOL val; > + int i; > + FILE *file; > + struct { > + char const *file_path1; > + char const *file_path2; > + BOOL equivalent; It will make more sense to define it as int. > + } tests[] = { > + { "f1", "tr2_test_dir", -1 }, > + { "tr2_test_dir", "tr2_test_dir", -1 }, > + { "not_exists_file" , "not_exists_file", -1 }, > + { "tr2_test_dir/./f1", "tr2_test_dir/f2", FALSE }, > + { "tr2_test_dir/f1" , "tr2_test_dir/f1", TRUE }, > + { "tr2_test_dir\\f1", "tr2_test_dir/././f1", TRUE }, > + { "tr2_test_dir/../tr2_test_dir/f1", "tr2_test_dir/f1", TRUE }, Please add following test: { NULL, NULL, ... }, { "not_existing_file", "tr2_test_dir/f1", ... } The tests are also failing when run from VirtualBox share. It's caused by the virtual machine bug (their probably generate a random FileIndexHigh/Low every time file is opened). Could you please create the test files inside temp directory to workaround this bug? Cheers, Piotr

1 0

Re: [PATCH] wined3d: fix color in range comparison
by Stefan Dösinger May 27, 2015

May 27, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-05-26 um 14:41 schrieb Sergey Isakov: > +#define RED_KEY(x) (x & 0xff0000) > +#define GREEN_KEY(x) (x & 0x00ff00) > +#define BLUE_KEY(x) (x & 0x0000ff) > + return ((RED_KEY(color) >= RED_KEY(color_key->color_space_low_value)) && > + (RED_KEY(color) <= RED_KEY(color_key->color_space_high_value)) && > + (GREEN_KEY(color) >= GREEN_KEY(color_key->color_space_low_value)) && > + (GREEN_KEY(color) <= GREEN_KEY(color_key->color_space_high_value)) && > + (BLUE_KEY(color) >= BLUE_KEY(color_key->color_space_low_value)) && > + (BLUE_KEY(color) <= BLUE_KEY(color_key->color_space_high_value))); > +#undef RED_KEY > +#undef GREEN_KEY > +#undef BLUE_KEY The basic idea is most likely right, but it needs tests. Do you have a game that needs this behavior? The way you're extracting individual colors from the key is wrong. The bitmasks depend on the texture format. The code you're modifying is unused on any modern GPU. On GPUs that support ARB_fragment_program or GLSL we do the color key comparison in the fragment shader nowadays. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVZXSWAAoJEN0/YqbEcdMwbEUP/RM4QUsbdSzhSLyIz5j00Epb AW1ZcNOg61yrfymjHdhJkqfdNmEiKQFsRshD+ZQAxVHqMsZLTxXtRFfBB14WtmNI Ng5jwwiAzDqlmpjftlZ4CmkR1w7DMxH6Nt4e9OQBlDKShSIoGngL6RremV+2Wq+f nNC6HfdmUiAIReVvI2aMm5B9C5L624SKLvoAZNI8QW+HJeZeESSGmT9bx4IRVQwl QX+aKojT43CJwq6UpZRu7ZkniotrmO9aDC+6S3S0od0ZJWSP5Q9upCNWNcN+iPG7 9kCPwZMsEAxNUjvh/wQx8xE1+wiR7Ugjl/X6yTN8HFesFHChrqC2UeHUAkUKU++L WC4kwijfbktKSZnIiSvrTAzWvLOeCZMifFQqm8aqmlOqyvbNwyOJjh6yM/nqZi+c 2aEdEIMY5aaoswDIlyGRRN57zeWtqjZVmg7UzVxmZqfiocmUVxgdmdRv8BvFi0RF R4A6YTDP5EYb33SvH3qQE5kIrtDdtL8qtanmBsuHnhhwd1rdgeeq/9N0tqSjH1GQ s8vsXVmd3qU+mQMzyaxN9Cc9RGxGNgd+g1LkkoPqe+aVUw/JDzvAdMDGpy63zjhM QUlfS771f+Zt43wku/20XP1engXXti4m+KfnSOS3nCdKO1xRKOGHAMlUZzd8+jhU 2rWKuh42D3mSMDk1OhLR =IdO/ -----END PGP SIGNATURE-----

1 0

Re: winedump: Add more image debug types
by Michael Stefaniuc May 27, 2015

May 27, 2015

On 05/26/2015 10:59 PM, André Hentschel wrote: > My main goal is to destroy the ccache from Michael S. ;) Did you just ask for your patch to be Rejected? But I don't mind anymore since I got my new beefy box as compilation is fast enough with that ;-P bye michael > --- > include/winnt.h | 4 ++++ > tools/winedump/pe.c | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/winnt.h b/include/winnt.h > index b25c25b..4c89750 100644 > --- a/include/winnt.h > +++ b/include/winnt.h

1 0

Re: [PATCH] ntdll/tests: NtOpenFile a directory with NULL ObjectName.
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13614 Your paranoid android. === w8 (32 bit file) === file.c:408: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

programs/regsvr32: Output strings as WCHAR to support non-ascii characters
by Hugh McMaster May 26, 2015

May 26, 2015

On Mon, 25 May 2015 12:06:43 -0300, Bruno Jesus wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38638 Hi Bruno, Your patch had the unfortunate side-effect of breaking output for almost all resource strings used in regsvr32. The problem is that the names of DLLs and input commands are still in ASCII. Fixing the issue requires more work, as regsvr32 needs to be converted to Unicode first. I wrote patches to do that last year, but Alexandre felt they weren't needed. He said something like, "If it isn't broken, don't fix it". But now there is a problem, as translations are broken. I've rebased the patches against the latest commit base and uploaded them to my Dropbox account. [1] Feel free to use them. Or, if you like, I'll resend them to wine-patches. -- Hugh McMaster [1] https://www.dropbox.com/sh/7j8wh9n0n09znk5/AADz3Fa3oEmtRUhqVG-Kq0kIa?dl=0

2 2

Re: [PATCH 3/8] wined3d: Keep track of renderbuffer capabilities.
by Henri Verbeet May 26, 2015

May 26, 2015

On 22 May 2015 at 10:11, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1145,18 +1151,21 @@ static HRESULT texture_init(struct wined3d_texture *texture, const struct wined3 > /* WINED3DUSAGE_DEPTHSTENCIL needs WINED3DFMT_FLAG_DEPTH or WINED3DFMT_FLAG_STENCIL, not both. */ > > if ((format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & required_flags) == required_flags > - && (!(desc->usage & WINED3DUSAGE_DEPTHSTENCIL) || (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & ds_flags)) > + && check_ds_support(format, WINED3D_GL_RES_TYPE_TEX_2D, desc->usage) > && (gl_info->supported[WINED3D_GL_NORMALIZED_TEXRECT] > || (desc->width == pow2_width && desc->height == pow2_height))) > gl_type = WINED3D_GL_RES_TYPE_TEX_2D; > else if ((format->flags[WINED3D_GL_RES_TYPE_TEX_RECT] & required_flags) == required_flags > - && (!(desc->usage & WINED3DUSAGE_DEPTHSTENCIL) || (format->flags[WINED3D_GL_RES_TYPE_TEX_RECT] & ds_flags))) > + && check_ds_support(format, WINED3D_GL_RES_TYPE_TEX_RECT, desc->usage)) > gl_type = WINED3D_GL_RES_TYPE_TEX_RECT; > + else if ((format->flags[WINED3D_GL_RES_TYPE_RB] & required_flags) == required_flags > + && check_ds_support(format, WINED3D_GL_RES_TYPE_RB, desc->usage)) > + gl_type = WINED3D_GL_RES_TYPE_RB; > else > gl_type = WINED3D_GL_RES_TYPE_TEX_2D; /* No error, may be SCRATCH pool or emulated conditional np2. */ > This is kind of ok because the existing code is like this, but notice the similarity to some of the code in resource_init(). In fact, is there any reason the caller needs to pass "gl_type" to resource_init() instead of letting it figure it out on its own? > -static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info) > +static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info, > + enum wined3d_gl_resource_type d3d_type, GLuint *object) > { > - gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, > - GL_TEXTURE_2D, 0, 0); > + switch (d3d_type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + case WINED3D_GL_RES_TYPE_TEX_2D: > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + case WINED3D_GL_RES_TYPE_TEX_3D: > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + gl_info->gl_ops.gl.p_glDeleteTextures(1, object); > + break; > + > + case WINED3D_GL_RES_TYPE_RB: > + gl_info->fbo_ops.glDeleteRenderbuffers(1, object); > + break; > + > + case WINED3D_GL_RES_TYPE_BUFFER: > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > } Why is "object" a pointer?

3 7

GSoC 2015 projects
by Matteo Bruni May 26, 2015

May 26, 2015

Hey all, tomorrow the coding period of the Summer of Code begins and I though it might be a nice idea to let the community know about the projects we've got this year. Actually, I though it would be even better if the student themselves wrote a short summary of their own project for the mailing list. So, with no authority backing me, I'm kindly asking that. No need to write anything too fancy, just a few lines explaining what are you going to work on over the summer and maybe what are the expected benefits for Wine. Thank you! Matteo.

5 4

Re: [PATCH] d3d11.idl: add the basic interfaces to enable video decoding
by Steve Lhomme May 26, 2015

May 26, 2015

On Sun, May 24, 2015 at 8:03 AM, Steve Lhomme <robux4(a)videolabs.io> wrote: > Any update on this patch ? Should I submit again with the one space removed ? I'm sending the updated version. > Steve > > On Wed, May 13, 2015 at 11:06 AM, Steve Lhomme <robux4(a)videolabs.io> wrote: >> On Wed, May 13, 2015 at 1:02 PM, Stefan Dösinger >> <stefandoesinger(a)gmail.com> wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Hi, >>> >>> This patch looks better. Ultimately Henri and Alexandre have to decide >>> if they're happy with it. Henri is on vacation this week, so don't >>> expect much movement until Monday. >> >> No problem. >> >>> Am 2015-05-11 um 15:41 schrieb Steve Lhomme: >>>> +interface ID3D11VideoDecoderOutputView : ID3D11View >>>> +{ >>>> + void GetDesc( >>>> + [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc ); >>>> +} >>> There's a space that doesn't match the rest of the patch, but does match >>> what's in the MS headers. Since it is the only case I can spot I think >>> it's a typo in a self-typed header rather than a missed fixup in a >>> copypasted header. >> >> Should I resubmit without the extra space ? >> >>> You don't have to use the same parameter names in Methods or functions. >>> Instead of "pDesc" you can e.g. use "desc". The rest of the header >>> already uses pCrap though, so I'm ok with the current way. >> >> I checked the other d3d IDL files in the repo to match what's already >> in use and pDesc is very common, for example in d3d10.idl. >> >>> -----BEGIN PGP SIGNATURE----- >>> Version: GnuPG v2 >>> >>> iQIcBAEBAgAGBQJVUy8wAAoJEN0/YqbEcdMwXHwQAJd+LDxvH03XR5L/+bpxZB/o >>> U6g7cgMmtkklfSeCazZrUe0R5ZZExbmmIN+bBr6GJpbQezVQW3vng9EQj6ihfBjf >>> 6CEKr9BJF/xOhYdHPrhg3yxaD9MZrnsXa9llNFGds6SI0q1L8uCclyAuPxV+AoSO >>> fxgElN7/+LCRTwEM9shdwuxVELrikW52UmVTEajhNematVixplOh6pJMe+8XyPp/ >>> iSn+6p/jBeytKzjb83uUnyGqVaFLOIg9ywR2PPeA43RvNYVnfV9agxeOGJYvO7Zw >>> mKWmv+fG9sIXzvF/G9upnceE69YHf8WoIdEHW+kZsOl2ctRRB4ycBHp0rG4s2IeH >>> f1XpENP55lT+dYIc/Tef8IdpABzmGD7JwtnbLyxRbF4F9Qwfe6x7GP3VtEBp1M/+ >>> 5nePonYZ4N55sShelaU8X7/JxUuZb8onlz1UfEXJkIykopyQJJw49rXkQv7OFm2k >>> xyJAsXCQk5Z9sqXXBuFxUnKkip9P8UaLOwFJ8WFUVgHrkS9UAceiehUKgvpcwYfX >>> vxh48j6gAE4fBEUBVOlXiR4lMV7cDUWIoJdCopUkzxysPMp/hi3BcDk7EdrF9LX9 >>> c01jQc2N+JwzjIyNhSC01Jk23Qp2lOG+pUT1UrKcACesoB1H6Zm3QbNv5hVgUfkz >>> pFuJsryqPWxQFS02SvTu >>> =ToVh >>> -----END PGP SIGNATURE-----

1 0

Re: [PATCH 1/2] Add the GUID definition of DXGI_DEBUG_D3D11
by Steve Lhomme May 26, 2015

May 26, 2015

Any update on this patch ? Thanks On Tue, May 12, 2015 at 4:24 PM, Steve Lhomme <robux4(a)videolabs.io> wrote: > --- > According to https://msdn.microsoft.com/en-us/library/windows/desktop/hh780344%28v=vs.85… > --- > include/d3d11sdklayers.idl | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/d3d11sdklayers.idl b/include/d3d11sdklayers.idl > index 638e53c..f21d11e 100644 > --- a/include/d3d11sdklayers.idl > +++ b/include/d3d11sdklayers.idl > @@ -20,6 +20,8 @@ import "oaidl.idl"; > import "ocidl.idl"; > import "d3d11.idl"; > > +cpp_quote("DEFINE_GUID(DXGI_DEBUG_D3D11, 0x4b99317b, 0xac39, 0x4aa6, 0xbb, 0x0b, 0xba, 0xa0, 0x47, 0x84, 0x79, 0x8f);") > + > typedef enum D3D11_MESSAGE_CATEGORY { > D3D11_MESSAGE_CATEGORY_APPLICATION_DEFINED, > D3D11_MESSAGE_CATEGORY_MISCELLANEOUS, > -- > 2.4.0 > > >

1 0

Re: [PATCH 2/2] Add dxgidebug.idl
by Steve Lhomme May 26, 2015

May 26, 2015

Any update on this patch ? Thanks On Tue, May 12, 2015 at 4:24 PM, Steve Lhomme <robux4(a)videolabs.io> wrote: > --- > Useful to debug DXGI leaks > See https://msdn.microsoft.com/en-us/library/windows/desktop/hh780352%28v=vs.85… > --- > include/Makefile.in | 1 + > include/dxgidebug.idl | 44 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) > create mode 100644 include/dxgidebug.idl > > diff --git a/include/Makefile.in b/include/Makefile.in > index ad87f47..d496bd8 100644 > --- a/include/Makefile.in > +++ b/include/Makefile.in > @@ -42,6 +42,7 @@ PUBLIC_IDL_H_SRCS = \ > dwrite_2.idl \ > dxgi.idl \ > dxgi1_2.idl \ > + dxgidebug.idl \ > dxva2api.idl \ > endpointvolume.idl \ > exdisp.idl \ > diff --git a/include/dxgidebug.idl b/include/dxgidebug.idl > new file mode 100644 > index 0000000..94f57da > --- /dev/null > +++ b/include/dxgidebug.idl > @@ -0,0 +1,44 @@ > +/* > + * Copyright 2015 Steve Lhomme > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +import "oaidl.idl"; > + > +cpp_quote("DEFINE_GUID(DXGI_DEBUG_ALL, 0xe48ae283, 0xda80, 0x490b, 0x87, 0xe6, 0x43, 0xe9, 0xa9, 0xcf, 0xda, 0x08);") > +cpp_quote("DEFINE_GUID(DXGI_DEBUG_DX, 0x35cdd7fc, 0x13b2, 0x421d, 0xa5, 0xd7, 0x7e, 0x44, 0x51, 0x28, 0x7d, 0x64);") > +cpp_quote("DEFINE_GUID(DXGI_DEBUG_DXGI, 0x25cddaa4, 0xb1c6, 0x47e1, 0xac, 0x3e, 0x98, 0x87, 0x5b, 0x5a, 0x2e, 0x2a);") > +cpp_quote("DEFINE_GUID(DXGI_DEBUG_APP, 0x06cd6e01, 0x4219, 0x4ebd, 0x87, 0x90, 0x27, 0xed, 0x23, 0x36, 0x0c, 0x62);") > + > +typedef enum DXGI_DEBUG_RLO_FLAGS { > + DXGI_DEBUG_RLO_SUMMARY = 0x0001, > + DXGI_DEBUG_RLO_DETAIL = 0x0002, > + DXGI_DEBUG_RLO_IGNORE_INTERNAL = 0x0004, > + DXGI_DEBUG_RLO_ALL = 0x0007 > +} DXGI_DEBUG_RLO_FLAGS; > + > +[ > + object, > + local, > + uuid(119e7452-de9e-40fe-8806-88f90c12b441) > +] > +interface IDXGIDebug : IUnknown > +{ > + HRESULT ReportLiveObjects( > + [in] GUID apiid, > + [in] DXGI_DEBUG_RLO_FLAGS flags); > +} > + > -- > 2.4.0 > > >

1 0

Re: [PATCH 3/4] riched20: Initial support for changing font properties
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13591 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wxppro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2003std (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w8 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700

1 0

Re: msvcirt: Share exceptions implementation with msvcp
by Alexandre Julliard May 26, 2015

May 26, 2015

Iván Matellanes <matellanesivan(a)gmail.com> writes: > This is the first patch of my GSoC project :) > It implements the exceptions in msvcirt by using the code in msvcp90. > @@ -304,13 +304,15 @@ typedef enum __exception_type { > EXCEPTION_RERAISE, > EXCEPTION, > EXCEPTION_BAD_ALLOC, > - EXCEPTION_BAD_CAST, > EXCEPTION_LOGIC_ERROR, > +#ifndef _MSVCIRT > EXCEPTION_LENGTH_ERROR, > EXCEPTION_OUT_OF_RANGE, > EXCEPTION_INVALID_ARGUMENT, > EXCEPTION_RUNTIME_ERROR, > EXCEPTION_FAILURE, > + EXCEPTION_BAD_CAST, > +#endif Please avoid as many ifdefs as possible. For instance, having extra enums or unexported functions doesn't do any harm, so there's no reason to make a special case for them. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/4] riched20: Implement tomTrackParms/tomCacheParms
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13590 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wxppro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2003std (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w8 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700

1 0

Re: [PATCH 1/4] riched20: Support ITextFont instances detached from a range
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13589 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wxppro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2003std (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w8 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700

1 0

Re: [2/3] widl: Fix handling of circular imports that involve the file passed on the command line.
by Alexandre Julliard May 25, 2015

May 25, 2015

Francois Gouget <fgouget(a)free.fr> writes: > --- > tools/widl/parser.l | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/widl/parser.l b/tools/widl/parser.l > index b911186..2333687 100644 > --- a/tools/widl/parser.l > +++ b/tools/widl/parser.l > @@ -488,6 +488,9 @@ int do_import(char *fname) > int ptr = import_stack_ptr; > int ret, fd; > > + if (strcmp(import_stack_ptr ? import_stack[0].input_name : input_name, > + fname) == 0) > + return 0; /* initial source file */ This won't work for out-of-tree builds. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/ole32: Silence a FIXME
by Stefan Dösinger May 25, 2015

May 25, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-05-25 um 07:56 schrieb Hugh McMaster: > This fixme appears on wine init either before console output or > after it. The fixme text is interrupting the output for Wine's > CLI-based programs, making the output difficult to read. WINEDEBUG=-all is the best way to deal with disturbing debug output. Or if you want other fixmes WINEDEBUG=-ole helps for this specific one. Though in many other places trying to QI an unknown interface is a WARN, not a FIXME. Which interface(s) are the application(s) / other libs trying to QI? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVYtuhAAoJEN0/YqbEcdMwaLcP/iP/cWFNiqommeRRFXKpv1GN gCxfqO3H5H/dWlobvFahZ6caZvRg87tw940dO6l9ch3i29A3ooJR0QNmJefk4WBa RGCp+g9lDxqIp9KvsnHGeHN4gdNXdIkNDtTusuDi1HC31MW3Wcl9rL3eCwTLeK3O 6QNTmAgUK+ZJM5xvBcTPMEidqgw2+L8SyjRTS3I84NPa5tZhRWV5gwvglBIKlvlk j2ve5wu7MYMyCU0yadmDyCioLeVzMMvIK1vFTkMbLlWlQc+ni2wgAvjD51ODW9Mg LiJJow6CVnyIF2htAaqs1bVWgtRYiFkHecidliJzqlP3CS11dmys0izy4GCO5nCZ 8vQpvVjHnKjzyrTaHkJJnGXdCSFhcDdjj2VlxrhKZy0C5TUKhsu9HLux3ZZnh8rX 3LX/Di16PgALnx28oAGaA/tkjuutdToZioHVi6V4doRZu1gVQAVdVuqu+jyj8rnR GQfdUbBsMN0sfdm4wzG2Ls+BdPyymq4FtgvMoYjH7Ue3+4smQu0EilmTCHAnQdZU OjF4dUgOqSdenQOWbVJGuiQzabwfxfQVePVlUuse7sthnXf8xAk5CCEBl/ITvYxZ vbORohm8+Xr1yQ9qi7rgRB1ItU3ThrEUFm6DAruIHUtgfiK4zVXczFXh83GXoPur mY9cApML3tVu3Q0S+WtK =5NtD -----END PGP SIGNATURE-----

3 2

Re: [PATCH 5/5] riched20/tests: Initial tests for font duplication behavior
by Marvin May 24, 2015

May 24, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13570 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wxppro (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2003std (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wvistau64 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2008s64 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w8 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wvistau64 (64 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2008s64 (64 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1

1 0

Re: [PATCH] d3d11.idl: add the basic interfaces to enable video decoding
by Steve Lhomme May 24, 2015

May 24, 2015

Any update on this patch ? Should I submit again with the one space removed ? Steve On Wed, May 13, 2015 at 11:06 AM, Steve Lhomme <robux4(a)videolabs.io> wrote: > On Wed, May 13, 2015 at 1:02 PM, Stefan Dösinger > <stefandoesinger(a)gmail.com> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> This patch looks better. Ultimately Henri and Alexandre have to decide >> if they're happy with it. Henri is on vacation this week, so don't >> expect much movement until Monday. > > No problem. > >> Am 2015-05-11 um 15:41 schrieb Steve Lhomme: >>> +interface ID3D11VideoDecoderOutputView : ID3D11View >>> +{ >>> + void GetDesc( >>> + [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc ); >>> +} >> There's a space that doesn't match the rest of the patch, but does match >> what's in the MS headers. Since it is the only case I can spot I think >> it's a typo in a self-typed header rather than a missed fixup in a >> copypasted header. > > Should I resubmit without the extra space ? > >> You don't have to use the same parameter names in Methods or functions. >> Instead of "pDesc" you can e.g. use "desc". The rest of the header >> already uses pCrap though, so I'm ok with the current way. > > I checked the other d3d IDL files in the repo to match what's already > in use and pDesc is very common, for example in d3d10.idl. > >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2 >> >> iQIcBAEBAgAGBQJVUy8wAAoJEN0/YqbEcdMwXHwQAJd+LDxvH03XR5L/+bpxZB/o >> U6g7cgMmtkklfSeCazZrUe0R5ZZExbmmIN+bBr6GJpbQezVQW3vng9EQj6ihfBjf >> 6CEKr9BJF/xOhYdHPrhg3yxaD9MZrnsXa9llNFGds6SI0q1L8uCclyAuPxV+AoSO >> fxgElN7/+LCRTwEM9shdwuxVELrikW52UmVTEajhNematVixplOh6pJMe+8XyPp/ >> iSn+6p/jBeytKzjb83uUnyGqVaFLOIg9ywR2PPeA43RvNYVnfV9agxeOGJYvO7Zw >> mKWmv+fG9sIXzvF/G9upnceE69YHf8WoIdEHW+kZsOl2ctRRB4ycBHp0rG4s2IeH >> f1XpENP55lT+dYIc/Tef8IdpABzmGD7JwtnbLyxRbF4F9Qwfe6x7GP3VtEBp1M/+ >> 5nePonYZ4N55sShelaU8X7/JxUuZb8onlz1UfEXJkIykopyQJJw49rXkQv7OFm2k >> xyJAsXCQk5Z9sqXXBuFxUnKkip9P8UaLOwFJ8WFUVgHrkS9UAceiehUKgvpcwYfX >> vxh48j6gAE4fBEUBVOlXiR4lMV7cDUWIoJdCopUkzxysPMp/hi3BcDk7EdrF9LX9 >> c01jQc2N+JwzjIyNhSC01Jk23Qp2lOG+pUT1UrKcACesoB1H6Zm3QbNv5hVgUfkz >> pFuJsryqPWxQFS02SvTu >> =ToVh >> -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 10)
by Marvin May 23, 2015

May 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13560 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [3/3] ws2_32: Add WSAPoll() implementation
by Marvin May 22, 2015

May 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13559 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

WineConf 2015
by Tom Wickline May 22, 2015

May 22, 2015

I posted this on the wineconf mailing list but I'm not sure everyone is currently subscribed to that list so I'm posting here as well. Their is a Facebook page setup for anyone interested in WineConf 2015 to confirm their attendance, post to page, like, invite etc etc. https://www.facebook.com/events/734919546617361/ Cheers, Tom

1 0

Re: [1/2] include: Add stuff related to WSAPoll()
by Bruno Jesus May 21, 2015

May 21, 2015

Please ignore the series, it seems to break ws2_32 due to multiple definitions for struct pollfd. Any ideas what can I do to fix this? Like what #ifdef could be used to prevent it? Best wishes, Bruno On Thu, May 21, 2015 at 3:52 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: >

1 1

Re: [1/2] ntdll: Implement RtlUnicodeToUTF8N.
by Nikolay Sivov May 21, 2015

May 21, 2015

Any reason you can't use wine_utf8_mbstowcs/wine_utf8_wcstombs ?

1 0

Re: [PATCH 3/3] riched20/tests: Added tests for ITextFont getters on detached font
by Marvin May 21, 2015

May 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13520 Your paranoid android. === wvistau64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF57FACFA === w2008s64 (64 bit richole) === richole: unhandled exception c0000005 at 000007FEF648ACFA

1 0

Re: [PATCH 1/2] msvcp120: Added _Call_once implementation
by Nikolay Sivov May 21, 2015

May 21, 2015

On 20.05.2015 23:18, Piotr Caban wrote: > --- > dlls/msvcp110/msvcp110.spec | 4 +-- > dlls/msvcp120/msvcp120.spec | 4 +-- > dlls/msvcp120/tests/msvcp120.c | 55 > +++++++++++++++++++++++++++++++++++++ > dlls/msvcp120_app/msvcp120_app.spec | 4 +-- > dlls/msvcp90/misc.c | 35 +++++++++++++++++++++++ > 5 files changed, 96 insertions(+), 6 deletions(-) > > You sure it's not a wrapper around InitOnce* calls from kernel32?

2 1

Re: [PATCH] winex11drv: Fix uninitialized memory access appearing in multiple tests (Valgrind) (resend)
by Nikolay Sivov May 21, 2015

May 21, 2015

On 05/21/2015 08:05 AM, efbiaiinzinz(a)hotmail.com wrote: > From: Indrek Altpere <efbiaiinzinz(a)hotmail.com> > > --- > dlls/winex11.drv/window.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c > index 06e2294..de39a44 100644 > --- a/dlls/winex11.drv/window.c > +++ b/dlls/winex11.drv/window.c > @@ -701,6 +701,7 @@ static void set_size_hints( struct x11drv_win_data *data, DWORD style ) > static void set_mwm_hints( struct x11drv_win_data *data, DWORD style, DWORD ex_style ) > { > MwmHints mwm_hints; > + memset(&mwm_hints, 0, sizeof(mwm_hints)); > > if (data->hwnd == GetDesktopWindow()) > { > This looks too much, isn't it enough to just set input_mode = 0 once, before making a call?

2 1

widl problem in argument ordering
by Marcus Meissner May 21, 2015

May 21, 2015

Hi, Coverity issue "CID 1299032 Explicit null dereferenced" shows I think a problem of the widl generated stub marshaller. The IDL is: interface IAccIdentity : IUnknown { HRESULT GetIdentityString([in] DWORD idchild, [out, size_is(*string_len)] BYTE **str, [out] DWORD *string_len); } the generated stub is: void __RPC_STUB IAccIdentity_GetIdentityString_Stub( IRpcStubBuffer* This, IRpcChannelBuffer *_pRpcChannelBuffer, PRPC_MESSAGE _pRpcMessage, DWORD* _pdwStubPhase) { struct __frame_IAccIdentity_GetIdentityString_Stub __f, * const __frame = &__f; __frame->_This = (IAccIdentity*)((CStdStubBuffer*)This)->pvServerObject; NdrStubInitialize(_pRpcMessage, &__frame->_StubMsg, &Object_StubDesc, _pRpcChannelBuffer); RpcExceptionInit( 0, __finally_IAccIdentity_GetIdentityString_Stub ); __frame->str = 0; __frame->string_len = 0; RpcTryFinally { if ((_pRpcMessage->DataRepresentation & 0xffff) != NDR_LOCAL_DATA_REPRESENTATION) NdrConvert( &__frame->_StubMsg, &__MIDL_ProcFormatString.Format[216]); __frame->_StubMsg.Buffer = (unsigned char *)(((ULONG_PTR)__frame->_StubMsg.Buffer + 3) & ~0x3); if (__frame->_StubMsg.Buffer + sizeof(DWORD) > __frame->_StubMsg.BufferEnd) { RpcRaiseException(RPC_X_BAD_STUB_DATA); } __frame->idchild = *(DWORD *)__frame->_StubMsg.Buffer; __frame->_StubMsg.Buffer += sizeof(DWORD); __frame->str = NdrAllocate(&__frame->_StubMsg, *__frame->string_len * 4); // DEREFERENCED memset(__frame->str, 0, *__frame->string_len * 4); __frame->string_len = &__frame->_W0; // ACTUALLY initialized __frame->_W0 = 0; Not that __frame->string_len is dereferenced before it is set to &__frame->_W0. There seems to be a bit of an ordering problem here? Ciao, Marcus

2 1

Re: [PATCH] rpcrt4: make sure we do not have *data allocated on error (Coverity)
by Michael Stefaniuc May 20, 2015

May 20, 2015

On 05/20/2015 04:50 PM, Marcus Meissner wrote: > 713688 Resource leak > > callers expect *data only allocated when success is returned. > --- > dlls/rpcrt4/rpc_transport.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 34f434d..4080b14 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -2359,6 +2359,7 @@ static RPC_STATUS rpcrt4_http_read_http_packet(HINTERNET request, RpcHttpAsyncDa > if (!RPCRT4_IsValidHttpPacket(hdr, *data, data_len)) > { > ERR("invalid http packet\n"); > + if (*data) HeapFree(GetProcessHeap(), 0, *data); Marcus, you don't need the if not NULL check as HeapFree(NULL) is a no-op. bye michael

1 0

Re: [PATCH 2/4] ntdll: If read_directory_getattrlist() finds that the file doesn't exist, return successful "no file" result to stop search.
by Matteo Bruni May 20, 2015

May 20, 2015

---- diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index 0e5af8a..42e1842 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -2185,6 +2185,11 @@ static int read_directory_getattrlist( int fd, IO_STATUS_BLOCK *io, void *buffer } else io->u.Status = STATUS_NO_MORE_FILES; } + else if (errno == ENOENT || errno == ENOTDIR) + { + io->u.Status = STATUS_NO_MORE_FILES; + ret = 0; + } } else ret = -1; ---- Actually that's how my patch originally looked like (http://source.winehq.org/patches/data/111375) but then I realized that would break if the filesystem is case-sensitive, since it would return the file as missing while it might be present with a different name casing. I haven't actually tested it though.

2 3

Re: [PATCH 4/4] ntdll: Fix read_directory_getattrlist() to get the name of a symlink rather than its target, but still detect if the symlink is broken.
by Matteo Bruni May 20, 2015

May 20, 2015

2015-05-20 20:40 GMT+02:00 Ken Thomases <ken(a)codeweavers.com>: > --- > dlls/ntdll/directory.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) Not sure it matters in practice but it might be better to check for HAVE_SYS_VNODE_H in both the definition of and the call to read_directory_getattrlist().

2 1

Re: [PATCH] kernel32: Implement a few more classes in GetFileInformationByHandleEx
by Marvin May 20, 2015

May 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13506 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: msvcr120: Add erf functions (try 2)
by Alexandre Julliard May 20, 2015

May 20, 2015

Daniel Lehman <dlehman(a)esri.com> writes: > @@ -73,6 +73,32 @@ int CDECL MSVCRT__set_SSE2_enable(int flag) > return sse2_enabled; > } > > +#if _MSVCR_VER>=120 > +/********************************************************************* > + * erff (MSVCRT.@) > + */ > +float CDECL MSVCRT_erff( float num ) > +{ > + return erff(num); > +} > + > +/********************************************************************* > + * erf (MSVCRT.@) > + */ > +double CDECL MSVCRT_erf( double num ) > +{ > + return erf(num); > +} Please add configure checks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 7/7] riched20: Implement GetFont() for selection range
by Marvin May 20, 2015

May 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13500 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/7] riched20: Implement GetLanguageID()
by Marvin May 20, 2015

May 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13499 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/7] riched20: Implement GetSize()
by Marvin May 20, 2015

May 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13498 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] wined3d: Check resource types separately in check_fbo_compat.
by Henri Verbeet May 19, 2015

May 19, 2015

On 16 May 2015 at 15:29, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static void delete_fbo_attachment(const struct wined3d_gl_info *gl_info, > + enum wined3d_gl_resource_type d3d_type) > +{ > + switch (d3d_type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + gl_info->fbo_ops.glFramebufferTexture1D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_1D, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_2D: > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, > + wined3d_gl_type_to_enum(d3d_type), 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_3D: > + gl_info->fbo_ops.glFramebufferTexture3D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_3D, 0, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + gl_info->fbo_ops.glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, > + GL_TEXTURE_CUBE_MAP_POSITIVE_X_ARB, 0, 0); > + break; > + > + case WINED3D_GL_RES_TYPE_BUFFER: > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > +} > + This is kind of pointless. Any of the FramebufferTexture*() calls with a 0 texture will detach the current attachment. You shouldn't need to detach the current attachment before attaching a new one either, but I suppose the existing code already does that.

2 1

Re: [PATCH 3/5] riched20: Implement GetSize() (resend)
by Marvin May 19, 2015

May 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13468 Your paranoid android. === w7u (32 bit richole) === richole.c:1287: Test failed: got weight 400

1 0

Re: [PATCH 2/5] riched20: Implement GetWeight() (resend)
by Marvin May 19, 2015

May 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13467 Your paranoid android. === w7u (32 bit richole) === richole.c:1283: Test failed: after 400

1 0

Re: [PATCH 1/5] riched20: Implement GetBold()/GetItalic()
by Marvin May 19, 2015

May 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13451 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: kernel32/tests: Add tests for delete behaviour of CopyFileEx.
by Marvin May 19, 2015

May 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13465 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: dmusic: Remove "keep in sync with oneself" comments
by Michael Stefaniuc May 18, 2015

May 18, 2015

Hello Frederic, why would you want to do this? Keeping the files identical just allows to copy it as is. Or easily verify it by just checking the SHA1 sum. On 05/18/2015 02:47 AM, Frédéric Delanoy wrote: > --- > dlls/dmusic/dmobject.c | 1 - > dlls/dmusic/dmobject.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/dlls/dmusic/dmobject.c b/dlls/dmusic/dmobject.c > index cabb6f7..8e9f58e 100644 > --- a/dlls/dmusic/dmobject.c > +++ b/dlls/dmusic/dmobject.c > @@ -1,6 +1,5 @@ > /* > * Base IDirectMusicObject Implementation > - * Keep in sync with the master in dlls/dmusic/dmobject.c > * > * Copyright (C) 2003-2004 Rok Mandeljc > * Copyright (C) 2014 Michael Stefaniuc > diff --git a/dlls/dmusic/dmobject.h b/dlls/dmusic/dmobject.h > index ad6bf6d..ffc683c 100644 > --- a/dlls/dmusic/dmobject.h > +++ b/dlls/dmusic/dmobject.h > @@ -1,6 +1,5 @@ > /* > * Base IDirectMusicObject Implementation > - * Keep in sync with the master in dlls/dmusic/dmobject.h > * > * Copyright (C) 2014 Michael Stefaniuc > * > bye michael

1 0

Re: [PATCH 3/5] riched20: Implement GetSize()
by Marvin May 18, 2015

May 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13453 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/5] riched20: Implement GetWeight()
by Marvin May 18, 2015

May 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13452 Your paranoid android. === build (build) === Patch failed to apply

1 0

Why does ntdll/thread.c use pthread_attr_setstack
by Mate Antunovic May 18, 2015

May 18, 2015

I have noticed that RtlCreateUserThread in dlls/ntdll.thread.c uses the following call pthread_attr_setstack( &attr, teb->DeallocationStack, (char *)teb->Tib.StackBase - (char *)teb->DeallocationStack ); I have the source code from release 1.7.41. I am working on a complex project that traces the execution of programs running in Wine (won't go into detail here). I have noticed problems in RtlCreateUserThread when services.exe is launched in my environment. Basically the call to pthread_create causes a SIGSEGV. Let me make it clear that under ordinary conditions, Wine works fine. Playing around with things, I note that if I change the call above to be pthread_attr_setstacksize(&attr, 0x10000), then I don't get the same problem. My question is, why does the exact position of the stack need to be set in this way?

1 0

Re: [PATCH] oledlg: Make object name menu item localized
by Alex Henrie May 18, 2015

May 18, 2015

+ WCHAR objectW[50]; /* should be enough*/ In the past I was told to always allocate memory in multiplies of 8 bytes,[1] and I personally have started to prefer powers of 2 in particular. Alexandre seems to prefer allocating at least 64 characters for short strings like this, judging from how he amended a proposed patch of mine several years ago.[2] + if (!LoadStringW(OLEDLG_hInstance, IDS_VERBMENU_OBJECT, objectW, sizeof(objectW)/sizeof(WCHAR))) { + static const WCHAR enobjectW[] = {'&','O','b','j','e','c','t',0}; + strcpyW(objectW, enobjectW); + } Is this really necessary? How could LoadString fail? I recently submitted a very similar patch [3] and didn't have to provide a special fallback. Just to be clear, I do really appreciate you taking the time to make sure that Wine is properly localized :-) I just don't want to see the codebase made unnecessarily complicated or inefficient. -Alex [1] https://www.winehq.org/pipermail/wine-devel/2011-December/093516.html [2] https://source.winehq.org/git/wine.git/commitdiff/6e5bba1b60f97fce34415ea30… [3] https://www.winehq.org/pipermail/wine-patches/2015-May/139132.html

2 1

Re: [PATCH 1/2] kernel32: Implement GetSystemTimePreciseAsFileTime
by Andrew Eikum May 17, 2015

May 17, 2015

On Thu, May 07, 2015 at 11:02:34PM +0300, Martin Storsjo wrote: > +/*********************************************************************** > + * GetSystemTimePreciseAsFileTime (KERNEL32.@) > + * > + * Get the current time in utc format, with <1 us precision. > + * > + * RETURNS > + * Nothing. > + */ > +VOID WINAPI GetSystemTimePreciseAsFileTime( > + LPFILETIME time) /* [out] Destination for the current utc time */ > +{ > + GetSystemTimeAsFileTime(time); > +} I don't know why this one's not getting in. I have a couple small guesses. Personally, I'm opposed to including a bunch of documentation in Wine. I don't think Wine is the right place to document the Windows API. I don't know if others feel this way, or if this is enough for rejection. You're also using VOID, LPJUNK, etc, which I think we're trying to avoid these days. Andrew

3 3

Re: [PATCH] kernel32: Implement a few more classes in GetFileInformationByHandleEx
by Marvin May 17, 2015

May 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13414 Your paranoid android. === wvistau64 (32 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:444: Test failed: attributes of file "testfile.xxx" are 0x0820

2 1

Re: oledlg: Partially implement OleUIAddVerbMenuW(), with basic tests
by Marvin May 14, 2015

May 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13373 Your paranoid android. === build (build) === Patch failed to apply

2 1

Why WINE renders the text in winecfg and notepad differently?
by John Found May 14, 2015

May 14, 2015

In the attached picture, you can see, how the UI text differs for the simultaneously running WINE applications - notepad and winecfg. They both are running in the same WINEPREFIX and I expected to have the same appearance. Why this happens and how I can make them to look the same? Regards -- http://fresh.flatassembler.net http://asm32.info John Found <johnfound(a)asm32.info>

2 4

Re: mshtml: Initialize output value before passing it to VariantCopy.
by Marvin May 14, 2015

May 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13368 Your paranoid android. === wvistau64 (32 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue === w2008s64 (32 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue === w7u (32 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue === w8 (32 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue === wvistau64 (64 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue === w2008s64 (64 bit events) === events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue events.c:1083: Test failed: get_returnValue failed: 80020008 events.c:1084: Test failed: unexpected returnValue

1 0

Re: ntdll/tests: Wait for pending file operations to complete.
by Marvin May 14, 2015

May 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13361 Your paranoid android. === w8 (32 bit file) === file.c:407: Test failed: mismatched file size for L"WindowsUpdate.log"

1 0

Re: [PATCH 3/3] user32: Fall back to downscaling the big icon for ICON_SMALL2.
by Marvin May 14, 2015

May 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13357 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH] d3d11.idl: add the basic interfaces to enable video decoding
by Stefan Dösinger May 13, 2015

May 13, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, This patch looks better. Ultimately Henri and Alexandre have to decide if they're happy with it. Henri is on vacation this week, so don't expect much movement until Monday. Am 2015-05-11 um 15:41 schrieb Steve Lhomme: > +interface ID3D11VideoDecoderOutputView : ID3D11View > +{ > + void GetDesc( > + [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc ); > +} There's a space that doesn't match the rest of the patch, but does match what's in the MS headers. Since it is the only case I can spot I think it's a typo in a self-typed header rather than a missed fixup in a copypasted header. You don't have to use the same parameter names in Methods or functions. Instead of "pDesc" you can e.g. use "desc". The rest of the header already uses pCrap though, so I'm ok with the current way. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVUy8wAAoJEN0/YqbEcdMwXHwQAJd+LDxvH03XR5L/+bpxZB/o U6g7cgMmtkklfSeCazZrUe0R5ZZExbmmIN+bBr6GJpbQezVQW3vng9EQj6ihfBjf 6CEKr9BJF/xOhYdHPrhg3yxaD9MZrnsXa9llNFGds6SI0q1L8uCclyAuPxV+AoSO fxgElN7/+LCRTwEM9shdwuxVELrikW52UmVTEajhNematVixplOh6pJMe+8XyPp/ iSn+6p/jBeytKzjb83uUnyGqVaFLOIg9ywR2PPeA43RvNYVnfV9agxeOGJYvO7Zw mKWmv+fG9sIXzvF/G9upnceE69YHf8WoIdEHW+kZsOl2ctRRB4ycBHp0rG4s2IeH f1XpENP55lT+dYIc/Tef8IdpABzmGD7JwtnbLyxRbF4F9Qwfe6x7GP3VtEBp1M/+ 5nePonYZ4N55sShelaU8X7/JxUuZb8onlz1UfEXJkIykopyQJJw49rXkQv7OFm2k xyJAsXCQk5Z9sqXXBuFxUnKkip9P8UaLOwFJ8WFUVgHrkS9UAceiehUKgvpcwYfX vxh48j6gAE4fBEUBVOlXiR4lMV7cDUWIoJdCopUkzxysPMp/hi3BcDk7EdrF9LX9 c01jQc2N+JwzjIyNhSC01Jk23Qp2lOG+pUT1UrKcACesoB1H6Zm3QbNv5hVgUfkz pFuJsryqPWxQFS02SvTu =ToVh -----END PGP SIGNATURE-----

2 1

Re: [PATCH 1/2] user32: Use window class small icon if the window does not have its own.
by Sebastian Lackner May 13, 2015

May 13, 2015

On 13.05.2015 07:36, Alex Henrie wrote: > We were already doing this for ICON_SMALL2, which is supposed to be > almost identical to ICON_SMALL: > https://source.winehq.org/git/wine.git/blob/5f35f1a8dbbc9dc3fa629a7f123e045… > https://msdn.microsoft.com/en-us/library/windows/desktop/ms632625%28v=vs.85… > > This patch is part 1 of the fix for > https://bugs.winehq.org/show_bug.cgi?id=29337 > --- > dlls/user32/defwnd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dlls/user32/defwnd.c b/dlls/user32/defwnd.c > index bcd6f91..935134d 100644 > --- a/dlls/user32/defwnd.c > +++ b/dlls/user32/defwnd.c > @@ -634,6 +634,7 @@ static LRESULT DEFWND_DefWinProc( HWND hwnd, UINT msg, WPARAM wParam, LPARAM lPa > { > case ICON_SMALL: > ret = wndPtr->hIconSmall; > + if (!ret) ret = (HICON)GetClassLongPtrW( hwnd, GCLP_HICONSM ); > break; > case ICON_BIG: > ret = wndPtr->hIcon; > The patch breaks existing tests (user32/win): win.c:2009: Test failed: wrong small icon 0x3b0058/0

1 0

Re: [PATCH 2/2] kernel32: Implement a few more classes in GetFileInformationByHandleEx
by Martin Storsjö May 12, 2015

May 12, 2015

On Thu, 7 May 2015, Martin Storsjo wrote: > --- > dlls/kernel32/file.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/dlls/kernel32/file.c b/dlls/kernel32/file.c > index 006db1c..9bf318e 100644 > --- a/dlls/kernel32/file.c > +++ b/dlls/kernel32/file.c > @@ -23,6 +23,7 @@ > #include "config.h" > #include "wine/port.h" > > +#include <assert.h> > #include <stdarg.h> > #include <stdio.h> > #include <errno.h> > @@ -894,11 +895,10 @@ BOOL WINAPI GetFileInformationByHandleEx( HANDLE handle, FILE_INFO_BY_HANDLE_CLA > { > NTSTATUS status; > IO_STATUS_BLOCK io; > + FILE_INFORMATION_CLASS nt_class; > > switch (class) > { > - case FileBasicInfo: > - case FileStandardInfo: > case FileRenameInfo: > case FileDispositionInfo: > case FileAllocationInfo: > @@ -919,8 +919,24 @@ BOOL WINAPI GetFileInformationByHandleEx( HANDLE handle, FILE_INFO_BY_HANDLE_CLA > SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); > return FALSE; > > + case FileBasicInfo: > + case FileStandardInfo: > case FileNameInfo: > - status = NtQueryInformationFile( handle, &io, info, size, FileNameInformation ); > + switch (class) { > + case FileBasicInfo: > + nt_class = FileBasicInformation; > + break; > + case FileStandardInfo: > + nt_class = FileStandardInformation; > + break; > + case FileNameInfo: > + nt_class = FileNameInformation; > + break; > + default: > + assert(0); > + break; > + } > + status = NtQueryInformationFile( handle, &io, info, size, nt_class ); > if (status != STATUS_SUCCESS) > { > SetLastError( RtlNtStatusToDosError( status ) ); > -- > 1.8.1.2 Is there anything concrete that needs to be fixed in this (and the other kernel32 patch in the same thread) to be acceptable? // Martin

2 2

Re: [PATCH] d3d11.idl: add the basic interfaces to enable video decoding
by Steve Lhomme May 11, 2015

May 11, 2015

Arf, sorry for all the noise. This patch compiles but doesn't run fine. I'll investigate. On Mon, May 11, 2015 at 2:02 PM, Steve Lhomme <robux4(a)videolabs.io> wrote: > --- > include/d3d11.idl | 168 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 168 insertions(+) > > diff --git a/include/d3d11.idl b/include/d3d11.idl > index 3726d32..79db53f 100644 > --- a/include/d3d11.idl > +++ b/include/d3d11.idl > @@ -2125,6 +2125,174 @@ interface ID3D11Device : IUnknown > UINT GetExceptionMode(); > } > > +typedef enum D3D11_VDOV_DIMENSION > +{ > + D3D11_VDOV_DIMENSION_UNKNOWN = 0, > + D3D11_VDOV_DIMENSION_TEXTURE2D > +} D3D11_VDOV_DIMENSION; > + > +typedef struct D3D11_TEX2D_VDOV > +{ > + UINT ArraySlice; > +} D3D11_TEX2D_VDOV; > + > +typedef struct D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC > +{ > + GUID DecodeProfile; > + D3D11_VDOV_DIMENSION ViewDimension; > + > + union > + { > + D3D11_TEX2D_VDOV Texture2D; > + }; > +} D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC; > + > +[ > + object, > + local, > + uuid(c2931aea-2a85-4f20-860f-fba1fd256e18) > +] > +interface ID3D11VideoDecoderOutputView : ID3D11View > +{ > + void GetDesc( [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc); > +} > + > +[ > + object, > + local, > + uuid(3c9c5b51-995d-48d1-9b8d-fa5caeded65c) > +] > +interface ID3D11VideoDecoder : ID3D11DeviceChild > +{ > +} > + > +typedef enum D3D11_VIDEO_DECODER_BUFFER_TYPE > +{ > + D3D11_VIDEO_DECODER_BUFFER_PICTURE_PARAMETERS = 0, > + D3D11_VIDEO_DECODER_BUFFER_MACROBLOCK_CONTROL, > + D3D11_VIDEO_DECODER_BUFFER_RESIDUAL_DIFFERENCE, > + D3D11_VIDEO_DECODER_BUFFER_DEBLOCKING_CONTROL, > + D3D11_VIDEO_DECODER_BUFFER_INVERSE_QUANTIZATION_MATRIX, > + D3D11_VIDEO_DECODER_BUFFER_SLICE_CONTROL, > + D3D11_VIDEO_DECODER_BUFFER_BITSTREAM, > + D3D11_VIDEO_DECODER_BUFFER_MOTION_VECTOR, > + D3D11_VIDEO_DECODER_BUFFER_FILM_GRAIN > +} D3D11_VIDEO_DECODER_BUFFER_TYPE; > + > +typedef struct D3D11_ENCRYPTED_BLOCK_INFO > +{ > + UINT NumEncryptedBytesAtBeginning; > + UINT NumBytesInSkipPattern; > + UINT NumBytesInEncryptPattern; > +} D3D11_ENCRYPTED_BLOCK_INFO; > + > +typedef struct D3D11_VIDEO_DECODER_BUFFER_DESC > +{ > + D3D11_VIDEO_DECODER_BUFFER_TYPE BufferType; > + UINT BufferIndex; > + UINT DataOffset; > + UINT DataSize; > + UINT FirstMBaddress; > + UINT NumMBsInBuffer; > + UINT Width; > + UINT Height; > + UINT Stride; > + UINT ReservedBits; > + void *pIV; > + UINT IVSize; > + BOOL PartialEncryption; > + D3D11_ENCRYPTED_BLOCK_INFO EncryptedBlockInfo; > +} D3D11_VIDEO_DECODER_BUFFER_DESC; > + > +[ > + object, > + local, > + uuid(61f21c45-3c0e-4a74-9cea-67100d9ad5e4) > +] > +interface ID3D11VideoContext : ID3D11DeviceChild > +{ > + HRESULT GetDecoderBuffer( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] D3D11_VIDEO_DECODER_BUFFER_TYPE BufferType, > + [out] UINT *pBufferSize, > + [out] void **ppBuffer); > + HRESULT ReleaseDecoderBuffer( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] D3D11_VIDEO_DECODER_BUFFER_TYPE BufferType); > + HRESULT DecoderBeginFrame( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] ID3D11VideoDecoderOutputView *pVideoDecoderOutputView, > + [in] UINT ContentKeySize, > + [in] const void *pContentKey); > + HRESULT DecoderEndFrame( > + [in] ID3D11VideoDecoder *pDecoder); > + HRESULT SubmitDecoderBuffers( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] UINT NumBuffers, > + [in] const D3D11_VIDEO_DECODER_BUFFER_DESC *pBufferDesc); > +} > + > +typedef struct D3D11_VIDEO_DECODER_DESC > +{ > + GUID Guid; > + UINT SampleWidth; > + UINT SampleHeight; > + DXGI_FORMAT OutputFormat; > +} D3D11_VIDEO_DECODER_DESC; > + > +typedef struct D3D11_VIDEO_DECODER_CONFIG > +{ > + GUID guidConfigBitstreamEncryption; > + GUID guidConfigMBcontrolEncryption; > + GUID guidConfigResidDiffEncryption; > + UINT ConfigBitstreamRaw; > + UINT ConfigMBcontrolRasterOrder; > + UINT ConfigResidDiffHost; > + UINT ConfigSpatialResid8; > + UINT ConfigResid8Subtraction; > + UINT ConfigSpatialHost8or9Clipping; > + UINT ConfigSpatialResidInterleaved; > + UINT ConfigIntraResidUnsigned; > + UINT ConfigResidDiffAccelerator; > + UINT ConfigHostInverseScan; > + UINT ConfigSpecificIDCT; > + UINT Config4GroupedCoefs; > + USHORT ConfigMinRenderTargetBuffCount; > + USHORT ConfigDecoderSpecific; > +} D3D11_VIDEO_DECODER_CONFIG; > + > +[ > + object, > + local, > + uuid(10ec4d5b-975a-4689-b9e4-d0aac30fe333) > +] > +interface ID3D11VideoDevice : IUnknown > +{ > + HRESULT CreateVideoDecoder( > + [in] const D3D11_VIDEO_DECODER_DESC *pVideoDesc, > + [in] const D3D11_VIDEO_DECODER_CONFIG *pConfig, > + [out] ID3D11VideoDecoder **ppVideoDecoder); > + UINT GetVideoDecoderProfileCount(void); > + HRESULT GetVideoDecoderProfile( > + [in] UINT Index, > + [out] GUID *pDecoderProfile); > + HRESULT CheckVideoDecoderFormat( > + [in] const GUID *pDecoderProfile, > + [in] DXGI_FORMAT Format, > + [out] BOOL *pSupported); > + HRESULT CreateVideoDecoderOutputView( > + [in] ID3D11Resource *pResource, > + [in] const D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc, > + [out] ID3D11VideoDecoderOutputView **ppVideoDecoderOutputView); > + HRESULT GetVideoDecoderConfigCount( > + [in] const D3D11_VIDEO_DECODER_DESC *pDesc, > + [out] UINT *pCount); > + HRESULT GetVideoDecoderConfig( > + [in] const D3D11_VIDEO_DECODER_DESC *pDesc, > + [in] UINT Index, > + [out] D3D11_VIDEO_DECODER_CONFIG *pConfig); > +} > + > typedef enum D3D11_CREATE_DEVICE_FLAG { > D3D11_CREATE_DEVICE_SINGLETHREADED = 0x0001, > D3D11_CREATE_DEVICE_DEBUG = 0x0002, > -- > 2.4.0 > > >

1 0

Re: [PATCH] d3d11.idl: add the interfaces necessary to use the D3D11 video decoder
by Stefan Dösinger May 11, 2015

May 11, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-05-11 um 11:53 schrieb Steve Lhomme: > On Mon, May 11, 2015 at 11:10 AM, Stefan Dösinger >> This patch still shows plenty of signs that it was copypasted >> from Microsoft's headers. > > Care to elaborate ? Suspicious trailing whitespaces at exactly the same place where Microsoft's code has them. There are more telling signs that I don't want to point out since I want a cleanly written header, not one that has a few problematic symptoms fixed. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVUIP5AAoJEN0/YqbEcdMw2IEQAIagS0sWyxW/HtEyztMgpfQZ gzzQkC0Uwlf+PGdFTAM4kyJVljqlHdgu/ZMqmABeNnqW3jsHQmCvIVv3ahvSa1Y8 rl9cWWxoYl31BLFPy6F+QN8QUsvX4Hnz96bYxy2M733XWLodSWMlCAzvFpdLPfa3 bZ9BOAsRfkLKxEzdz0adjJtwxdPwwF/CwGwjucrHGiBVW4RCB01gYSagUK9LZxVH VMsFFWi0YbfzforISKGSGC4tF0iDUwGzQ7V5QAMZmnDiVpZXz47shzFXiOP1jaM/ kEnMQXkPH1vMqKwXK7HqbsN0qALxzN5DiMgMxtVUTyelAKlOT+c4Fyd0PSFpyi1r uvSM1M2gxh3NjZ/BSNh5GSwZgkAwCe5PaN0xDVWZ8c4GPm7e6n61XKvdm/NEtvjM modJb6WUx5iWkWY58sBbi4VG5Zl3eu+cqNKtZd3mo0m/LefF061DrAgMO+bSYiza JwHYyqfWVOyzGpuks7k1k7aub+YemJrGXT84LWoDlshf+xWUk0duszWySAFtBKSG XgJILPLSzRir1OQa39orFmAqCiMJwVh1pwuie1cQ9zq2GmyezilAD9Co1Qns9dSi an0MQlh1SpTnoWE1wduk2mcU1Q7GdanVgyATSWl7Any4FAn4Gru+nlW85dPDcIhp lM8l59NlJaTcdAnGPQEp =5XCl -----END PGP SIGNATURE-----

1 0

Re: [PATCH] d3d11.idl: add the interfaces necessary to use the D3D11 video decoder
by Stefan Dösinger May 11, 2015

May 11, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 This patch still shows plenty of signs that it was copypasted from Microsoft's headers. Am 2015-05-11 um 11:00 schrieb Steve Lhomme: > From: Steve Lhomme <slhomme(a)matroska.org> > > --- > include/d3d11.idl | 878 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 870 insertions(+), 8 deletions(-) > > diff --git a/include/d3d11.idl b/include/d3d11.idl > index 3726d32..70afbd5 100644 > --- a/include/d3d11.idl > +++ b/include/d3d11.idl > @@ -2125,16 +2125,878 @@ interface ID3D11Device : IUnknown > UINT GetExceptionMode(); > } > > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_MOCOMP_NOFGT, 0x1b81be64, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_MOCOMP_FGT, 0x1b81be65, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_IDCT_NOFGT, 0x1b81be66, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_IDCT_FGT, 0x1b81be67, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_NOFGT, 0x1b81be68, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_FGT, 0x1b81be69, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_WITHFMOASO_NOFGT, 0xd5f04ff9, 0x3418, 0x45d8, 0x95, 0x61, 0x32, 0xa7, 0x6a, 0xae, 0x2d, 0xdd);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_STEREO_PROGRESSIVE_NOFGT, 0xd79be8da, 0x0cf1, 0x4c81, 0xb8, 0x2a, 0x69, 0xa4, 0xe2, 0x36, 0xf4, 0x3d);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_STEREO_NOFGT, 0xf9aaccbb, 0xc2b6, 0x4cfc, 0x87, 0x79, 0x57, 0x07, 0xb1, 0x76, 0x05, 0x52);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_H264_VLD_MULTIVIEW_NOFGT, 0x705b9d82, 0x76cf, 0x49d6, 0xb7, 0xe6, 0xac, 0x88, 0x72, 0xdb, 0x01, 0x3c);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_WMV8_POSTPROC, 0x1b81be80, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_WMV8_MOCOMP, 0x1b81be81, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_WMV9_POSTPROC, 0x1b81be90, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_WMV9_MOCOMP, 0x1b81be91, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_WMV9_IDCT, 0x1b81be94, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_VC1_POSTPROC, 0x1b81beA0, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_VC1_MOCOMP, 0x1b81beA1, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_VC1_IDCT, 0x1b81beA2, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_VC1_VLD, 0x1b81beA3, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_VC1_D2010, 0x1b81beA4, 0xa0c7, 0x11d3, 0xb9, 0x84, 0x00, 0xc0, 0x4f, 0x2e, 0x73, 0xc5);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG4PT2_VLD_SIMPLE, 0xefd64d74, 0xc9e8, 0x41d7, 0xa5, 0xe9, 0xe9, 0xb0, 0xe3, 0x9f, 0xa3, 0x19);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG4PT2_VLD_ADVSIMPLE_NOGMC, 0xed418a9f, 0x010d, 0x4eda, 0x9a, 0xe3, 0x9a, 0x65, 0x35, 0x8d, 0x8d, 0x2e);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG4PT2_VLD_ADVSIMPLE_GMC, 0xab998b5b, 0x4258, 0x44a9, 0x9f, 0xeb, 0x94, 0xe5, 0x97, 0xa6, 0xba, 0xae);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_HEVC_VLD_MAIN, 0x5b11d51b, 0x2f4c, 0x4452, 0xbc, 0xc3, 0x09, 0xf2, 0xa1, 0x16, 0x0c, 0xc0);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_HEVC_VLD_MAIN10, 0x107af0e0, 0xef1a, 0x4d19, 0xab, 0xa8, 0x67, 0xa1, 0x63, 0x07, 0x3d, 0x13);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG2_MOCOMP, 0xe6a9f44b, 0x61b0, 0x4563, 0x9e, 0xa4, 0x63, 0xd2, 0xa3, 0xc6, 0xfe, 0x66);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG2_IDCT, 0xbf22ad00, 0x03ea, 0x4690, 0x80, 0x77, 0x47, 0x33, 0x46, 0x20, 0x9b, 0x7e);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG2_VLD, 0xee27417f, 0x5e28, 0x4e65, 0xbe, 0xea, 0x1d, 0x26, 0xb5, 0x08, 0xad, 0xc9);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG1_VLD, 0x6f3ec719, 0x3735, 0x42cc, 0x80, 0x63, 0x65, 0xcc, 0x3c, 0xb3, 0x66, 0x16);") > +cpp_quote("DEFINE_GUID(D3D11_DECODER_PROFILE_MPEG2and1_VLD, 0x86695f12, 0x340e, 0x4f04, 0x9f, 0xd3, 0x92, 0x53, 0xdd, 0x32, 0x74, 0x60);") > + > +typedef struct D3D11_VIDEO_DECODER_DESC > +{ > + GUID Guid; > + UINT SampleWidth; > + UINT SampleHeight; > + DXGI_FORMAT OutputFormat; > +} D3D11_VIDEO_DECODER_DESC; > + > +typedef struct D3D11_VIDEO_DECODER_CONFIG > +{ > + GUID guidConfigBitstreamEncryption; > + GUID guidConfigMBcontrolEncryption; > + GUID guidConfigResidDiffEncryption; > + UINT ConfigBitstreamRaw; > + UINT ConfigMBcontrolRasterOrder; > + UINT ConfigResidDiffHost; > + UINT ConfigSpatialResid8; > + UINT ConfigResid8Subtraction; > + UINT ConfigSpatialHost8or9Clipping; > + UINT ConfigSpatialResidInterleaved; > + UINT ConfigIntraResidUnsigned; > + UINT ConfigResidDiffAccelerator; > + UINT ConfigHostInverseScan; > + UINT ConfigSpecificIDCT; > + UINT Config4GroupedCoefs; > + USHORT ConfigMinRenderTargetBuffCount; > + USHORT ConfigDecoderSpecific; > +} D3D11_VIDEO_DECODER_CONFIG; > + > +typedef enum D3D11_VIDEO_DECODER_BUFFER_TYPE > +{ > + D3D11_VIDEO_DECODER_BUFFER_PICTURE_PARAMETERS = 0, > + D3D11_VIDEO_DECODER_BUFFER_MACROBLOCK_CONTROL = 1, > + D3D11_VIDEO_DECODER_BUFFER_RESIDUAL_DIFFERENCE = 2, > + D3D11_VIDEO_DECODER_BUFFER_DEBLOCKING_CONTROL = 3, > + D3D11_VIDEO_DECODER_BUFFER_INVERSE_QUANTIZATION_MATRIX = 4, > + D3D11_VIDEO_DECODER_BUFFER_SLICE_CONTROL = 5, > + D3D11_VIDEO_DECODER_BUFFER_BITSTREAM = 6, > + D3D11_VIDEO_DECODER_BUFFER_MOTION_VECTOR = 7, > + D3D11_VIDEO_DECODER_BUFFER_FILM_GRAIN = 8 > +} D3D11_VIDEO_DECODER_BUFFER_TYPE; > + > +typedef struct D3D11_ENCRYPTED_BLOCK_INFO > +{ > + UINT NumEncryptedBytesAtBeginning; > + UINT NumBytesInSkipPattern; > + UINT NumBytesInEncryptPattern; > +} D3D11_ENCRYPTED_BLOCK_INFO; > + > +typedef struct D3D11_VIDEO_DECODER_BUFFER_DESC > +{ > + D3D11_VIDEO_DECODER_BUFFER_TYPE BufferType; > + UINT BufferIndex; > + UINT DataOffset; > + UINT DataSize; > + UINT FirstMBaddress; > + UINT NumMBsInBuffer; > + UINT Width; > + UINT Height; > + UINT Stride; > + UINT ReservedBits; > + void *pIV; > + UINT IVSize; > + BOOL PartialEncryption; > + D3D11_ENCRYPTED_BLOCK_INFO EncryptedBlockInfo; > +} D3D11_VIDEO_DECODER_BUFFER_DESC; > + > +typedef struct D3D11_VIDEO_DECODER_EXTENSION > +{ > + UINT Function; > + void *pPrivateInputData; > + UINT PrivateInputDataSize; > + void *pPrivateOutputData; > + UINT PrivateOutputDataSize; > + UINT ResourceCount; > + ID3D11Resource **ppResourceList; > +} D3D11_VIDEO_DECODER_EXTENSION; > + > +typedef enum D3D11_VIDEO_FRAME_FORMAT > +{ > + D3D11_VIDEO_FRAME_FORMAT_PROGRESSIVE = 0, > + D3D11_VIDEO_FRAME_FORMAT_INTERLACED_TOP_FIELD_FIRST = 1, > + D3D11_VIDEO_FRAME_FORMAT_INTERLACED_BOTTOM_FIELD_FIRST = 2 > +} D3D11_VIDEO_FRAME_FORMAT; > + > +typedef enum D3D11_VIDEO_USAGE > +{ > + D3D11_VIDEO_USAGE_PLAYBACK_NORMAL = 0, > + D3D11_VIDEO_USAGE_OPTIMAL_SPEED = 1, > + D3D11_VIDEO_USAGE_OPTIMAL_QUALITY = 2 > +} D3D11_VIDEO_USAGE; > + > +typedef struct D3D11_VIDEO_PROCESSOR_CONTENT_DESC > +{ > + D3D11_VIDEO_FRAME_FORMAT InputFrameFormat; > + DXGI_RATIONAL InputFrameRate; > + UINT InputWidth; > + UINT InputHeight; > + DXGI_RATIONAL OutputFrameRate; > + UINT OutputWidth; > + UINT OutputHeight; > + D3D11_VIDEO_USAGE Usage; > +} D3D11_VIDEO_PROCESSOR_CONTENT_DESC; > + > +typedef struct D3D11_VIDEO_PROCESSOR_CAPS > +{ > + UINT DeviceCaps; > + UINT FeatureCaps; > + UINT FilterCaps; > + UINT InputFormatCaps; > + UINT AutoStreamCaps; > + UINT StereoCaps; > + UINT RateConversionCapsCount; > + UINT MaxInputStreams; > + UINT MaxStreamStates; > +} D3D11_VIDEO_PROCESSOR_CAPS; > + > +typedef struct D3D11_VIDEO_PROCESSOR_RATE_CONVERSION_CAPS > +{ > + UINT PastFrames; > + UINT FutureFrames; > + UINT ProcessorCaps; > + UINT ITelecineCaps; > + UINT CustomRateCount; > +} D3D11_VIDEO_PROCESSOR_RATE_CONVERSION_CAPS; > + > +typedef struct D3D11_VIDEO_PROCESSOR_CUSTOM_RATE > +{ > + DXGI_RATIONAL CustomRate; > + UINT OutputFrames; > + BOOL InputInterlaced; > + UINT InputFramesOrFields; > +} D3D11_VIDEO_PROCESSOR_CUSTOM_RATE; > + > +typedef enum D3D11_VIDEO_PROCESSOR_FILTER > +{ > + D3D11_VIDEO_PROCESSOR_FILTER_BRIGHTNESS = 0, > + D3D11_VIDEO_PROCESSOR_FILTER_CONTRAST = 1, > + D3D11_VIDEO_PROCESSOR_FILTER_HUE = 2, > + D3D11_VIDEO_PROCESSOR_FILTER_SATURATION = 3, > + D3D11_VIDEO_PROCESSOR_FILTER_NOISE_REDUCTION = 4, > + D3D11_VIDEO_PROCESSOR_FILTER_EDGE_ENHANCEMENT = 5, > + D3D11_VIDEO_PROCESSOR_FILTER_ANAMORPHIC_SCALING = 6, > + D3D11_VIDEO_PROCESSOR_FILTER_STEREO_ADJUSTMENT = 7 > +} D3D11_VIDEO_PROCESSOR_FILTER; > + > +typedef struct D3D11_VIDEO_CONTENT_PROTECTION_CAPS > +{ > + UINT Caps; > + UINT KeyExchangeTypeCount; > + UINT BlockAlignmentSize; > + ULONGLONG ProtectedMemorySize; > +} D3D11_VIDEO_CONTENT_PROTECTION_CAPS; > + > +typedef struct D3D11_VIDEO_PROCESSOR_FILTER_RANGE > +{ > + int Minimum; > + int Maximum; > + int Default; > + float Multiplier; > +} D3D11_VIDEO_PROCESSOR_FILTER_RANGE; > + > +typedef struct D3D11_VIDEO_COLOR_RGBA > +{ > + float R; > + float G; > + float B; > + float A; > +} D3D11_VIDEO_COLOR_RGBA; > + > +typedef struct D3D11_VIDEO_COLOR_YCbCrA > +{ > + float Y; > + float Cb; > + float Cr; > + float A; > +} D3D11_VIDEO_COLOR_YCbCrA; > + > +typedef struct D3D11_VIDEO_COLOR > +{ > + union > + { > + D3D11_VIDEO_COLOR_YCbCrA YCbCr; > + D3D11_VIDEO_COLOR_RGBA RGBA; > + }; > +} D3D11_VIDEO_COLOR; > + > +typedef struct D3D11_VIDEO_PROCESSOR_COLOR_SPACE > +{ > + UINT Usage :1; > + UINT RGB_Range :1; > + UINT YCbCr_Matrix :1; > + UINT YCbCr_xvYCC :1; > + UINT Nominal_Range :2; > + UINT Reserved : 26; > +} D3D11_VIDEO_PROCESSOR_COLOR_SPACE; > + > +typedef enum D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE > +{ > + D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE_OPAQUE = 0, > + D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE_BACKGROUND = 1, > + D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE_DESTINATION = 2, > + D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE_SOURCE_STREAM = 3 > +} D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE; > + > +typedef enum D3D11_VIDEO_PROCESSOR_OUTPUT_RATE > +{ > + D3D11_VIDEO_PROCESSOR_OUTPUT_RATE_NORMAL = 0, > + D3D11_VIDEO_PROCESSOR_OUTPUT_RATE_HALF = 1, > + D3D11_VIDEO_PROCESSOR_OUTPUT_RATE_CUSTOM = 2 > +} D3D11_VIDEO_PROCESSOR_OUTPUT_RATE; > + > +typedef enum D3D11_VIDEO_PROCESSOR_STEREO_FORMAT > +{ > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_MONO = 0, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_HORIZONTAL = 1, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_VERTICAL = 2, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_SEPARATE = 3, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_MONO_OFFSET = 4, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_ROW_INTERLEAVED = 5, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_COLUMN_INTERLEAVED = 6, > + D3D11_VIDEO_PROCESSOR_STEREO_FORMAT_CHECKERBOARD = 7 > +} D3D11_VIDEO_PROCESSOR_STEREO_FORMAT; > + > +typedef enum D3D11_VIDEO_PROCESSOR_STEREO_FLIP_MODE > +{ > + D3D11_VIDEO_PROCESSOR_STEREO_FLIP_NONE = 0, > + D3D11_VIDEO_PROCESSOR_STEREO_FLIP_FRAME0 = 1, > + D3D11_VIDEO_PROCESSOR_STEREO_FLIP_FRAME1 = 2 > +} D3D11_VIDEO_PROCESSOR_STEREO_FLIP_MODE; > + > +typedef enum D3D11_VIDEO_PROCESSOR_ROTATION > +{ > + D3D11_VIDEO_PROCESSOR_ROTATION_IDENTITY = 0, > + D3D11_VIDEO_PROCESSOR_ROTATION_90 = 1, > + D3D11_VIDEO_PROCESSOR_ROTATION_180 = 2, > + D3D11_VIDEO_PROCESSOR_ROTATION_270 = 3 > +} D3D11_VIDEO_PROCESSOR_ROTATION; > + > +[ > + object, > + local, > + uuid(3c9c5b51-995d-48d1-9b8d-fa5caeded65c) > +] > +interface ID3D11VideoDecoder : ID3D11DeviceChild > +{ > + HRESULT GetCreationParameters( > + [out] D3D11_VIDEO_DECODER_DESC *pVideoDesc, > + [out] D3D11_VIDEO_DECODER_CONFIG *pConfig); > + HRESULT GetDriverHandle( > + [out] HANDLE *pDriverHandle); > +} > + > +[ > + object, > + local, > + uuid(1d7b0652-185f-41c6-85ce-0c5be3d4ae6c) > +] > +interface ID3D11VideoProcessor : ID3D11DeviceChild > +{ > + void GetContentDesc( > + [out] D3D11_VIDEO_PROCESSOR_CONTENT_DESC *pDesc); > + void GetRateConversionCaps( > + [out] D3D11_VIDEO_PROCESSOR_RATE_CONVERSION_CAPS *pCaps); > +} > + > +typedef enum D3D11_VPOV_DIMENSION > +{ > + D3D11_VPOV_DIMENSION_UNKNOWN = 0, > + D3D11_VPOV_DIMENSION_TEXTURE2D = 1, > + D3D11_VPOV_DIMENSION_TEXTURE2DARRAY = 2 > +} D3D11_VPOV_DIMENSION; > + > +typedef struct D3D11_TEX2D_VPOV > +{ > + UINT MipSlice; > +} D3D11_TEX2D_VPOV; > + > +typedef struct D3D11_TEX2D_ARRAY_VPOV > +{ > + UINT MipSlice; > + UINT FirstArraySlice; > + UINT ArraySize; > +} D3D11_TEX2D_ARRAY_VPOV; > + > +typedef struct D3D11_VIDEO_PROCESSOR_OUTPUT_VIEW_DESC > +{ > + D3D11_VPOV_DIMENSION ViewDimension; > + > + union > + { > + D3D11_TEX2D_VPOV Texture2D; > + D3D11_TEX2D_ARRAY_VPOV Texture2DArray; > + }; > +} D3D11_VIDEO_PROCESSOR_OUTPUT_VIEW_DESC; > + > +[ > + object, > + local, > + uuid(a048285e-25a9-4527-bd93-d68b68c44254) > +] > +interface ID3D11VideoProcessorOutputView : ID3D11View > +{ > + void GetDesc( [out] D3D11_VIDEO_PROCESSOR_OUTPUT_VIEW_DESC *pDesc); > +} > + > +[ > + object, > + local, > + uuid(9b32f9ad-bdcc-40a6-a39d-d5c865845720) > +] > +interface ID3D11CryptoSession : ID3D11DeviceChild > +{ > + void GetCryptoType( > + [out] GUID *pCryptoType); > + void GetDecoderProfile( > + [out] GUID *pDecoderProfile); > + HRESULT GetCertificateSize( > + [out] UINT *pCertificateSize); > + HRESULT GetCertificate( > + [in] UINT CertificateSize, > + [out] BYTE *pCertificate); > + void GetCryptoSessionHandle( > + [out] HANDLE *pCryptoSessionHandle); > +} > + > +#define D3D11_OMAC_SIZE 16 > + > +typedef struct D3D11_OMAC > +{ > + BYTE Omac[D3D11_OMAC_SIZE]; > +} D3D11_OMAC; > + > +typedef enum D3D11_AUTHENTICATED_CHANNEL_TYPE > +{ > + D3D11_AUTHENTICATED_CHANNEL_D3D11 = 1, > + D3D11_AUTHENTICATED_CHANNEL_DRIVER_SOFTWARE = 2, > + D3D11_AUTHENTICATED_CHANNEL_DRIVER_HARDWARE = 3 > +} D3D11_AUTHENTICATED_CHANNEL_TYPE; > + > +typedef struct D3D11_AUTHENTICATED_CONFIGURE_OUTPUT > +{ > + D3D11_OMAC omac; > + GUID ConfigureType; > + HANDLE hChannel; > + UINT SequenceNumber; > + HRESULT ReturnCode; > +} D3D11_AUTHENTICATED_CONFIGURE_OUTPUT; > + > +[ > + object, > + local, > + uuid(3015a308-dcbd-47aa-a747-192486d14d4a) > +] > +interface ID3D11AuthenticatedChannel : ID3D11DeviceChild > +{ > + HRESULT GetCertificateSize( > + [out] UINT *pCertificateSize); > + HRESULT GetCertificate( > + [in] UINT CertificateSize, > + [out] BYTE *pCertificate); > + void GetChannelHandle( > + [out] HANDLE *pChannelHandle); > +} > + > +typedef enum D3D11_VPIV_DIMENSION > +{ > + D3D11_VPIV_DIMENSION_UNKNOWN = 0, > + D3D11_VPIV_DIMENSION_TEXTURE2D = 1 > +} D3D11_VPIV_DIMENSION; > + > +typedef struct D3D11_TEX2D_VPIV > +{ > + UINT MipSlice; > + UINT ArraySlice; > +} D3D11_TEX2D_VPIV; > + > +typedef struct D3D11_VIDEO_PROCESSOR_INPUT_VIEW_DESC > +{ > + UINT FourCC; > + D3D11_VPIV_DIMENSION ViewDimension; > + > + union > + { > + D3D11_TEX2D_VPIV Texture2D; > + }; > +} D3D11_VIDEO_PROCESSOR_INPUT_VIEW_DESC; > + > +[ > + object, > + local, > + uuid(11ec5a5f-51dc-4945-ab34-6e8c21300ea5) > +] > +interface ID3D11VideoProcessorInputView : ID3D11View > +{ > + void GetDesc( [out] D3D11_VIDEO_PROCESSOR_INPUT_VIEW_DESC *pDesc); > +} > + > +typedef enum D3D11_VDOV_DIMENSION > +{ > + D3D11_VDOV_DIMENSION_UNKNOWN = 0, > + D3D11_VDOV_DIMENSION_TEXTURE2D = 1 > +} D3D11_VDOV_DIMENSION; > + > +typedef struct D3D11_TEX2D_VDOV > +{ > + UINT ArraySlice; > +} D3D11_TEX2D_VDOV; > + > +typedef struct D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC > +{ > + GUID DecodeProfile; > + D3D11_VDOV_DIMENSION ViewDimension; > + > + union > + { > + D3D11_TEX2D_VDOV Texture2D; > + }; > +} D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC; > + > +[ > + object, > + local, > + uuid(c2931aea-2a85-4f20-860f-fba1fd256e18) > +] > +interface ID3D11VideoDecoderOutputView : ID3D11View > +{ > + void GetDesc( [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc); > +} > + > +typedef struct D3D11_VIDEO_PROCESSOR_STREAM > +{ > + BOOL Enable; > + UINT OutputIndex; > + UINT InputFrameOrField; > + UINT PastFrames; > + UINT FutureFrames; > + ID3D11VideoProcessorInputView **ppPastSurfaces; > + ID3D11VideoProcessorInputView *pInputSurface; > + ID3D11VideoProcessorInputView **ppFutureSurfaces; > + ID3D11VideoProcessorInputView **ppPastSurfacesRight; > + ID3D11VideoProcessorInputView *pInputSurfaceRight; > + ID3D11VideoProcessorInputView **ppFutureSurfacesRight; > +} D3D11_VIDEO_PROCESSOR_STREAM; > + > +[ > + object, > + local, > + uuid(61f21c45-3c0e-4a74-9cea-67100d9ad5e4) > +] > +interface ID3D11VideoContext : ID3D11DeviceChild > +{ > + HRESULT GetDecoderBuffer( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] D3D11_VIDEO_DECODER_BUFFER_TYPE Type, > + [out] UINT *pBufferSize, > + [out] void **ppBuffer); > + HRESULT ReleaseDecoderBuffer( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] D3D11_VIDEO_DECODER_BUFFER_TYPE Type); > + HRESULT DecoderBeginFrame( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] ID3D11VideoDecoderOutputView *pView, > + [in] UINT ContentKeySize, > + [in] const void *pContentKey); > + HRESULT DecoderEndFrame( > + [in] ID3D11VideoDecoder *pDecoder); > + HRESULT SubmitDecoderBuffers( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] UINT NumBuffers, > + [in] const D3D11_VIDEO_DECODER_BUFFER_DESC *pBufferDesc); > + HRESULT DecoderExtension( > + [in] ID3D11VideoDecoder *pDecoder, > + [in] const D3D11_VIDEO_DECODER_EXTENSION *pExtensionData); > + void VideoProcessorSetOutputTargetRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] BOOL Enable, > + [in] const RECT *pRect); > + void VideoProcessorSetOutputBackgroundColor( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] BOOL YCbCr, > + [in] const D3D11_VIDEO_COLOR *pColor); > + void VideoProcessorSetOutputColorSpace( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] const D3D11_VIDEO_PROCESSOR_COLOR_SPACE *pColorSpace); > + void VideoProcessorSetOutputAlphaFillMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE AlphaFillMode, > + [in] UINT StreamIndex); > + void VideoProcessorSetOutputConstriction( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] BOOL Enable, > + [in] SIZE Size); > + void VideoProcessorSetOutputStereoMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] BOOL Enable); > + HRESULT VideoProcessorSetOutputExtension( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] const GUID *pExtensionGuid, > + [in] UINT DataSize, > + [in] void *pData); > + void VideoProcessorGetOutputTargetRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] BOOL *Enabled, > + [out] RECT *pRect); > + void VideoProcessorGetOutputBackgroundColor( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] BOOL *pYCbCr, > + [out] D3D11_VIDEO_COLOR *pColor); > + void VideoProcessorGetOutputColorSpace( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] D3D11_VIDEO_PROCESSOR_COLOR_SPACE *pColorSpace); > + void VideoProcessorGetOutputAlphaFillMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] D3D11_VIDEO_PROCESSOR_ALPHA_FILL_MODE *pAlphaFillMode, > + [out] UINT *pStreamIndex); > + void VideoProcessorGetOutputConstriction( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] BOOL *pEnabled, > + [out] SIZE *pSize); > + void VideoProcessorGetOutputStereoMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [out] BOOL *pEnabled); > + HRESULT VideoProcessorGetOutputExtension( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] const GUID *pExtensionGuid, > + [in] UINT DataSize, > + [out] void *pData); > + void VideoProcessorSetStreamFrameFormat( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] D3D11_VIDEO_FRAME_FORMAT FrameFormat); > + void VideoProcessorSetStreamColorSpace( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] const D3D11_VIDEO_PROCESSOR_COLOR_SPACE *pColorSpace); > + void VideoProcessorSetStreamOutputRate( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] D3D11_VIDEO_PROCESSOR_OUTPUT_RATE OutputRate, > + [in] BOOL RepeatFrame, > + [in] const DXGI_RATIONAL *pCustomRate); > + void VideoProcessorSetStreamSourceRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] const RECT *pRect); > + void VideoProcessorSetStreamDestRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] const RECT *pRect); > + void VideoProcessorSetStreamAlpha( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] FLOAT Alpha); > + void VideoProcessorSetStreamPalette( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] UINT Count, > + [in] const UINT *pEntries); > + void VideoProcessorSetStreamPixelAspectRatio( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] const DXGI_RATIONAL *pSourceAspectRatio, > + [in] const DXGI_RATIONAL *pDestinationAspectRatio); > + void VideoProcessorSetStreamLumaKey( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] FLOAT Lower, > + [in] FLOAT Upper); > + void VideoProcessorSetStreamStereoFormat( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] D3D11_VIDEO_PROCESSOR_STEREO_FORMAT Format, > + [in] BOOL LeftViewFrame0, > + [in] BOOL BaseViewFrame0, > + [in] D3D11_VIDEO_PROCESSOR_STEREO_FLIP_MODE FlipMode, > + [in] int MonoOffset); > + void VideoProcessorSetStreamAutoProcessingMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable); > + void VideoProcessorSetStreamFilter( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] D3D11_VIDEO_PROCESSOR_FILTER Filter, > + [in] BOOL Enable, > + [in] int Level); > + HRESULT VideoProcessorSetStreamExtension( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] const GUID *pExtensionGuid, > + [in] UINT DataSize, > + [in] void *pData); > + void VideoProcessorGetStreamFrameFormat( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] D3D11_VIDEO_FRAME_FORMAT *pFrameFormat); > + void VideoProcessorGetStreamColorSpace( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] D3D11_VIDEO_PROCESSOR_COLOR_SPACE *pColorSpace); > + void VideoProcessorGetStreamOutputRate( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] D3D11_VIDEO_PROCESSOR_OUTPUT_RATE *pOutputRate, > + [out] BOOL *pRepeatFrame, > + [out] DXGI_RATIONAL *pCustomRate); > + void VideoProcessorGetStreamSourceRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled, > + [out] RECT *pRect); > + void VideoProcessorGetStreamDestRect( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled, > + [out] RECT *pRect); > + void VideoProcessorGetStreamAlpha( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled, > + [out] FLOAT *pAlpha); > + void VideoProcessorGetStreamPalette( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] UINT Count, > + [out] UINT *pEntries); > + void VideoProcessorGetStreamPixelAspectRatio( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled, > + [out] DXGI_RATIONAL *pSourceAspectRatio, > + [out] DXGI_RATIONAL *pDestinationAspectRatio); > + void VideoProcessorGetStreamLumaKey( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled, > + [out] FLOAT *pLower, > + [out] FLOAT *pUpper); > + void VideoProcessorGetStreamStereoFormat( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnable, > + [out] D3D11_VIDEO_PROCESSOR_STEREO_FORMAT *pFormat, > + [out] BOOL *pLeftViewFrame0, > + [out] BOOL *pBaseViewFrame0, > + [out] D3D11_VIDEO_PROCESSOR_STEREO_FLIP_MODE *pFlipMode, > + [out] int *MonoOffset); > + void VideoProcessorGetStreamAutoProcessingMode( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnabled); > + void VideoProcessorGetStreamFilter( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] D3D11_VIDEO_PROCESSOR_FILTER Filter, > + [out] BOOL *pEnabled, > + [out] int *pLevel); > + HRESULT VideoProcessorGetStreamExtension( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] const GUID *pExtensionGuid, > + [in] UINT DataSize, > + [out] void *pData); > + HRESULT VideoProcessorBlt( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] ID3D11VideoProcessorOutputView *pView, > + [in] UINT OutputFrame, > + [in] UINT StreamCount, > + [in] const D3D11_VIDEO_PROCESSOR_STREAM *pStreams); > + HRESULT NegotiateCryptoSessionKeyExchange( > + [in] ID3D11CryptoSession *pCryptoSession, > + [in] UINT DataSize, > + [in,out] void *pData); > + void EncryptionBlt( > + [in] ID3D11CryptoSession *pCryptoSession, > + [in] ID3D11Texture2D *pSrcSurface, > + [in] ID3D11Texture2D *pDstSurface, > + [in] UINT IVSize, > + [in,out] void *pIV); > + void DecryptionBlt( > + [in] ID3D11CryptoSession *pCryptoSession, > + [in] ID3D11Texture2D *pSrcSurface, > + [in] ID3D11Texture2D *pDstSurface, > + [in] D3D11_ENCRYPTED_BLOCK_INFO *pEncryptedBlockInfo, > + [in] UINT ContentKeySize, > + [in] const void *pContentKey, > + [in] UINT IVSize, > + [in,out] void *pIV); > + void StartSessionKeyRefresh( > + [in] ID3D11CryptoSession *pCryptoSession, > + [in] UINT RandomNumberSize, > + [out] void *pRandomNumber); > + void FinishSessionKeyRefresh( > + [in] ID3D11CryptoSession *pCryptoSession); > + HRESULT GetEncryptionBltKey( > + [in] ID3D11CryptoSession *pCryptoSession, > + [in] UINT KeySize, > + [out] void *pReadbackKey); > + HRESULT NegotiateAuthenticatedChannelKeyExchange( > + [in] ID3D11AuthenticatedChannel *pChannel, > + [in] UINT DataSize, > + [in,out] void *pData); > + HRESULT QueryAuthenticatedChannel( > + [in] ID3D11AuthenticatedChannel *pChannel, > + [in] UINT InputSize, > + [in] const void *pInput, > + [in] UINT OutputSize, > + [out] void *pOutput); > + HRESULT ConfigureAuthenticatedChannel( > + [in] ID3D11AuthenticatedChannel *pChannel, > + [in] UINT InputSize, > + [in] const void *pInput, > + [out] D3D11_AUTHENTICATED_CONFIGURE_OUTPUT *pOutput); > + void VideoProcessorSetStreamRotation( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [in] BOOL Enable, > + [in] D3D11_VIDEO_PROCESSOR_ROTATION Rotation); > + void VideoProcessorGetStreamRotation( > + [in] ID3D11VideoProcessor *pVideoProcessor, > + [in] UINT StreamIndex, > + [out] BOOL *pEnable, > + [out] D3D11_VIDEO_PROCESSOR_ROTATION *pRotation); > +} > + > +[ > + object, > + local, > + uuid(31627037-53ab-4200-9061-05faa9ab45f9) > +] > +interface ID3D11VideoProcessorEnumerator : ID3D11DeviceChild > +{ > + HRESULT GetVideoProcessorContentDesc( > + [out] D3D11_VIDEO_PROCESSOR_CONTENT_DESC *pContentDesc); > + HRESULT CheckVideoProcessorFormat( > + [in] DXGI_FORMAT Format, > + [out] UINT *pFlags); > + HRESULT GetVideoProcessorCaps( > + [out] D3D11_VIDEO_PROCESSOR_CAPS *pCaps); > + HRESULT GetVideoProcessorRateConversionCaps( > + [in] UINT TypeIndex, > + [out] D3D11_VIDEO_PROCESSOR_RATE_CONVERSION_CAPS *pCaps); > + HRESULT GetVideoProcessorCustomRate( > + [in] UINT TypeIndex, > + [in] UINT CustomRateIndex, > + [out] D3D11_VIDEO_PROCESSOR_CUSTOM_RATE *pRate); > + HRESULT GetVideoProcessorFilterRange( > + [in] D3D11_VIDEO_PROCESSOR_FILTER Filter, > + [out] D3D11_VIDEO_PROCESSOR_FILTER_RANGE *pRange); > +} > + > +[ > + object, > + local, > + uuid(10ec4d5b-975a-4689-b9e4-d0aac30fe333) > +] > +interface ID3D11VideoDevice : IUnknown > +{ > + HRESULT CreateVideoDecoder( > + [in] const D3D11_VIDEO_DECODER_DESC *pVideoDesc, > + [in] const D3D11_VIDEO_DECODER_CONFIG *pConfig, > + [out] ID3D11VideoDecoder **ppDecoder); > + HRESULT CreateVideoProcessor( > + [in] ID3D11VideoProcessorEnumerator *pEnum, > + [in] UINT RateConversionIndex, > + [out] ID3D11VideoProcessor **ppVideoProcessor); > + HRESULT CreateAuthenticatedChannel( > + [in] D3D11_AUTHENTICATED_CHANNEL_TYPE ChannelType, > + [out] ID3D11AuthenticatedChannel **ppAuthenticatedChannel); > + HRESULT CreateCryptoSession( > + [in] const GUID *pCryptoType, > + [in] const GUID *pDecoderProfile, > + [in] const GUID *pKeyExchangeType, > + [out] ID3D11CryptoSession **ppCryptoSession); > + HRESULT CreateVideoDecoderOutputView( > + [in] ID3D11Resource *pResource, > + [in] const D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc, > + [out] ID3D11VideoDecoderOutputView **ppVDOVView); > + HRESULT CreateVideoProcessorInputView( > + [in] ID3D11Resource *pResource, > + [in] ID3D11VideoProcessorEnumerator *pEnum, > + [in] const D3D11_VIDEO_PROCESSOR_INPUT_VIEW_DESC *pDesc, > + [out] ID3D11VideoProcessorInputView **ppVPIView); > + HRESULT CreateVideoProcessorOutputView( > + [in] ID3D11Resource *pResource, > + [in] ID3D11VideoProcessorEnumerator *pEnum, > + [in] const D3D11_VIDEO_PROCESSOR_OUTPUT_VIEW_DESC *pDesc, > + [out] ID3D11VideoProcessorOutputView **ppVPOView); > + HRESULT CreateVideoProcessorEnumerator( > + [in] const D3D11_VIDEO_PROCESSOR_CONTENT_DESC *pDesc, > + [out] ID3D11VideoProcessorEnumerator **ppEnum); > + UINT GetVideoDecoderProfileCount(void); > + HRESULT GetVideoDecoderProfile( > + [in] UINT Index, > + [out] GUID *pDecoderProfile); > + HRESULT CheckVideoDecoderFormat( > + [in] const GUID *pDecoderProfile, > + [in] DXGI_FORMAT Format, > + [out] BOOL *pSupported); > + HRESULT GetVideoDecoderConfigCount( > + [in] const D3D11_VIDEO_DECODER_DESC *pDesc, > + [out] UINT *pCount); > + HRESULT GetVideoDecoderConfig( > + [in] const D3D11_VIDEO_DECODER_DESC *pDesc, > + [in] UINT Index, > + [out] D3D11_VIDEO_DECODER_CONFIG *pConfig); > + HRESULT GetContentProtectionCaps( > + [in] const GUID *pCryptoType, > + [in] const GUID *pDecoderProfile, > + [out] D3D11_VIDEO_CONTENT_PROTECTION_CAPS *pCaps); > + HRESULT CheckCryptoKeyExchange( > + [in] const GUID *pCryptoType, > + [in] const GUID *pDecoderProfile, > + [in] UINT Index, > + [out] GUID *pKeyExchangeType); > + HRESULT SetPrivateData( > + [in] REFGUID guid, > + [in] UINT DataSize, > + [in] const void *pData); > + HRESULT SetPrivateDataInterface( > + [in] REFGUID guid, > + [in] const IUnknown *pData); > +} > + > typedef enum D3D11_CREATE_DEVICE_FLAG { > - D3D11_CREATE_DEVICE_SINGLETHREADED = 0x0001, > - D3D11_CREATE_DEVICE_DEBUG = 0x0002, > - D3D11_CREATE_DEVICE_SWITCH_TO_REF = 0x0004, > - D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS = 0x0008, > - D3D11_CREATE_DEVICE_BGRA_SUPPORT = 0x0020, > - D3D11_CREATE_DEVICE_DEBUGGABLE = 0x0040, > + D3D11_CREATE_DEVICE_SINGLETHREADED = 0x0001, > + D3D11_CREATE_DEVICE_DEBUG = 0x0002, > + D3D11_CREATE_DEVICE_SWITCH_TO_REF = 0x0004, > + D3D11_CREATE_DEVICE_PREVENT_INTERNAL_THREADING_OPTIMIZATIONS = 0x0008, > + D3D11_CREATE_DEVICE_BGRA_SUPPORT = 0x0020, > + D3D11_CREATE_DEVICE_DEBUGGABLE = 0x0040, > D3D11_CREATE_DEVICE_PREVENT_ALTERING_LAYER_SETTINGS_FROM_REGISTRY = 0x0080, > - D3D11_CREATE_DEVICE_DISABLE_GPU_TIMEOUT = 0x0100, > - D3D11_CREATE_DEVICE_VIDEO_SUPPORT = 0x0800 > + D3D11_CREATE_DEVICE_DISABLE_GPU_TIMEOUT = 0x0100, > + D3D11_CREATE_DEVICE_VIDEO_SUPPORT = 0x0800 > } D3D11_CREATE_DEVICE_FLAG; > > const UINT D3D11_SDK_VERSION = 7; > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVUHHsAAoJEN0/YqbEcdMwt5IP/RQUorEad9xeKijd+ylUAZNH k9W6EpbcMUcwd8bWEE95XQadiG+NQ/IpQDrVAanqX8yW5rA9ldfVZmX5AzgQDY1b 2+z6DZ41S8AqUQFkjakJmlAJu9KAEh+jbDFEl5742ZRu0XARF1cQkJ8tDuNKOmUY dPetkbiPVNoP3wbfTr5PaQD5Ti4IgzkoPXP2ZEnLw//BGbqvj8zODN3KEEPrXW4X Vx9lGihijOiSbCs225sBCA9gV5qGdtAZaDRaYBhcBhssL79/zfe+IhRgSlFDfN9G DVu7MhCbJpC4ZhMiJq7XwywBFDFmRKRJ6ppOi5luUHOuowooG1OV71j+zkiTcId0 xkKiwz7hvRn634rbP8MO7jShVGJczYJRCECNYa8UcIz1IFJm/jas1lj3fNt0mZlw DWzOv5MxvNVyI61IgQs2kgJhOjKmya62Wsz1f7W4TFWazMg2/QKN4K97P2GH3B4L sypDv7Zgszds4kZDnihVzbJY115XlrbEEjyC2/wTzLr07ThwaFQGs1xlOkIYFiJY GrRdouYJlfGmg1vCV7BOgNkeQrOdEXWOgmD9lw3cDWqnBMvabVBPYWPUGk62yzNQ F9o0hktsMOAN+eHqD1kH5EcZX5qICIb+ys0SWWpROAkfnS3cbJfdBHeNYiRAFMfZ TVNEg78wDgXDA8MmxhAQ =efTb -----END PGP SIGNATURE-----

2 1

Re: [PATCH] add the interfaces necessary to use the D3D11 video decoder
by Matteo Bruni May 11, 2015

May 11, 2015

2015-05-08 9:03 GMT+02:00 Steve Lhomme <robux4(a)videolabs.io>: > Anyone has anything to say about this ? > > Thanks > > On Tue, May 5, 2015 at 1:52 PM, Steve Lhomme <robux4(a)videolabs.io> wrote: >> This is needed by VLC. Hi Steve, some parts of the patch are clearly copypasted from the MS idl, which is a deal breaker. While rewriting those parts try to use the wined3d style, like putting the '*' next to the variable instead of the type. Another potential issue (noticed by Henri) is that D3D11_VIDEO_PROCESSOR_COLOR_SPACE uses bitfields which aren't generally portable. I don't know if their implementation on Windows is compatible with the one used by the OSs and architectures we support. If that's not the case then we have a problem...

2 1

Re: [PATCH 5/5] shell32: Implement FolderItemVerbs::Item()
by Marvin May 10, 2015

May 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13306 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CB87106 === w2003std (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\Administrator\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CAA259F === wvistau64 (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 75C4B510 === w2008s64 (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7522B578 === w7u (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 76C263C4 === wvistau64 (64 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 000007FEFEA52BD9 === w2008s64 (64 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 000007FEFE352A7D

1 0

Re: [PATCH 3/5] shell32: Implement FolderItemVerbs_get_Count()
by Marvin May 10, 2015

May 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13305 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CB87106 === w2003std (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\Administrator\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CAA259F === wvistau64 (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 75C4B510 === w2008s64 (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7522B578 === w7u (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 76C263C4 === wvistau64 (64 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 000007FEFEA52BD9 === w2008s64 (64 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 000007FEFE352A7D

1 0

Re: [PATCH 2/5] shell32: Added FolderItemVerbs stub
by Marvin May 10, 2015

May 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13304 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CB87106 === w2003std (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\Administrator\\Local Settings\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7CAA259F === wvistau64 (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 75C4B510 === w2008s64 (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 7522B578 === w7u (32 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 76C263C4 === wvistau64 (64 bit shelldispatch) === shelldispatch: unhandled exception c0000005 at 000007FEFEA52BD9 === w2008s64 (64 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" shelldispatch: unhandled exception c0000005 at 000007FEFE352A7D

1 0

Re: [PATCH 1/5] shell32: Implement ParseName()
by Marvin May 10, 2015

May 10, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13303 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\winetest\\Local Settings\\Temp\\cadabra" === w2003std (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Documents and Settings\\Administrator\\Local Settings\\Temp\\cadabra" === w2008s64 (32 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra" === w2008s64 (64 bit shelldispatch) === shelldispatch.c:737: Test failed: path L"C:\\Users\\Administrator\\AppData\\Local\\Temp\\cadabra"

1 0

WineTest log size
by Francois Gouget May 8, 2015

May 8, 2015

TL;DR: The todo below generates more than 90 KB of test report data. It would be really nice to fix it. storage32.c:3401: todo_wine ok(failed == expect_failed, "open with byte %x locked, mode %x %s but should %s\n", Some of my WineTest reports went over the 1.5MB limit again and while the issue was not what I initially thought, I wrote a script (see attachment) to slice and dice them to figure out who contributes what. Lines Bytes Category 1530 114848 9 traces generating >= 5120 bytes each 1842 106511 33 traces generating 2048 - 5119 bytes each 7020 358649 2221 traces generating < 2048 bytes each 2071 180266 9 todos generating >= 5120 bytes each 842 67746 20 todos generating 2048 - 5119 bytes each 4622 329705 2894 todos generating < 2048 bytes each 170 15372 Test failed 2787 144801 Others -------------------- 20884 1317898 Total Traces are easy to deal with so I've sent some patches. We'll see how it goes. The todos are much harder as they require fixing Wine. Still, if we manage to fix the top 9 we'll save around 180 KB. The next 66 KB require fixing 20 more todos, which is still somewhat plausible, but it gets hopeless after that. The 'Others' category corresponds to the report header with the dlls list, and to the per test summaries. So we're looking at minimum report size of 813 KB, but in practice we're unlikely to get below 1 MB. Here are the top 20 traces and todos: $ dupcount --traces *.report | head -n 20 Lines Chars Match 296 31777 font.c:3711: # Patch pending 339 20378 protocol.c:765: # Patch pending 143 14471 ddrawmodes.c:369: # Patch pending 171 9576 loader.c:1414: # Patch pending 226 9121 clipboard.c:154: # Patch pending 90 9050 ddrawmodes.c:340: # Patch pending 105 7875 istream.c:486: # Patch pending 82 7444 win.c:82: 78 5156 button.c:588: 85 5015 shlview.c:59: 145 4785 locale.c:3296: # Patch pending 131 4716 protocol.c:583: # Patch pending 54 4539 http.c:428: 56 4300 metafile.c:1736: 75 4050 locale.c:3215: # Patch pending 145 3936 locale.c:3190: # Patch pending 57 3846 msg.c:11475: 98 3626 clipboard.c:132: # Patch pending 48 3574 metafile.c:504: $ dupcount -e '^[^:]*:[0-9]*: Test marked todo*:' *.report | head -n 20 Lines Chars Match 902 93357 storage32.c:3401: Test marked todo: 296 21312 sock.c:2741: Test marked todo: 256 18176 virtual.c:3350: Test marked todo: 256 14592 ebrowser.c:1742: Test marked todo: 110 8405 shlexec.c:1472: Test marked todo: 22 6530 shlexec.c:1462: Test marked todo: 74 6395 font.c:3789: Test marked todo: 92 6074 propvariant.c:169: Test marked todo: 63 5425 font.c:3781: Test marked todo: 63 4788 file.c:4209: Test marked todo: 63 4714 file.c:4207: Test marked todo: 29 4569 dib.c:1322: Test marked todo: 64 4504 graphics.c:3686: Test marked todo: 64 4432 graphics.c:3657: Test marked todo: 64 4432 graphics.c:3674: Test marked todo: 54 4042 saxreader.c:2393: Test marked todo: 42 3982 qcap.c:337: Test marked todo: 38 3834 saxreader.c:2489: Test marked todo: 25 3764 batch.c:312: Test marked todo: -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Indifference will certainly be the downfall of mankind, but who cares?

2 1

Re: gdi32/tests: Silence some font traces that generate too many lines.
by Marvin May 8, 2015

May 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13293 Your paranoid android. === wvistau64 (32 bit font) === The test timed out

1 0

Re: [PATCH] add the interfaces necessary to use the D3D11 video decoder
by Qian Hong May 8, 2015

May 8, 2015

Hi Steve, On Fri, May 8, 2015 at 3:03 PM, Steve Lhomme <robux4(a)videolabs.io> wrote: > Anyone has anything to say about this ? Thanks for your contribution, glad to see VLC people! I'm not the right person to ack your patch, but I can help to point out a few tiny formatting issues: - The patch title could be rename to "include: Add D3D11 video decoder interfaces" Here is an example of this stile of patch title: `git show e35f82665cfdb40231c2e0a8a41c81642273160d` - There are a couple of trailing spaces in the code which should be removed, for example: 94 + UINT NumEncryptedBytesAtBeginning;<spaces> 176 +typedef struct D3D11_VIDEO_PROCESSOR_CUSTOM_RATE<space> and about 90+ more lines with trailing spaces. Could you fix that and resubmit? Thanks! -- Regards, Qian Hong - http://www.winehq.org

1 0

[PATCH 1/2] cmd/tests: Add tests for console InsertMode
by Hugh McMaster May 7, 2015

May 7, 2015

Alexandre, What changes to you want to see for my InsertMode tests to be committed? http://source.winehq.org/patches/data/111149 Thanks, Hugh -- Hugh McMaster

1 0

Re: winecfg: add all Windows versions and accompanying error message (try 5)
by Jason Overland May 6, 2015

May 6, 2015

Is there anything I can do to improve this patch? Thanks, Jason On 04/30/2015 01:56 PM, Jason Overland wrote: > This supercedes winecfg: add all Windows versions and accompanying error message (try 4). > > Changes since try 4: > > Windows versions that are unavailable in 64 bit prefixes now have a different text in the combobox saying as such. They still display an error dialog if the user tries to select them.

1 0

Re: user32: After handling an internal message give a chance to real message to arrive.
by Alexandre Julliard May 6, 2015

May 6, 2015

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > @@ -2931,7 +2931,10 @@ static BOOL peek_message( MSG *msg, HWND hwnd, UINT first, UINT last, UINT flags > else > peek_message( msg, info.msg.hwnd, info.msg.message, > info.msg.message, flags | PM_REMOVE, changed_mask ); > - continue; > + > + /* give a chance to real message to arrive */ > + HeapFree( GetProcessHeap(), 0, buffer ); > + return FALSE; Why do you need to leave the function instead of checking for further messages? What is the issue you are seeing? -- Alexandre Julliard julliard(a)winehq.org

2 17

Wine Joysticks, seeking a plan
by Aric Stewart May 6, 2015

May 6, 2015

Hi all, Ok I sat down with Ken (the benefits of being in the same office) and after a lengthy discussion I have come to terms with how it may not be the most ideal plan to put the joystick driver into the graphics driver. However I am still of the strong opinion that we need some sort of better joystick architecture and I know Alexandre is also of the like mindset. This was discussed back on 2005 and I know there was also recent discussion around BSD that also involves this. I also have an itch to start to poke at xinput, but I have no interest in poking at xinput with the current way joysticks are handled. When I was working on this driver thing Alexandre expressed he was pretty opposed to having a whole new set of platform specific wine drivers. (winejoystick_mac, winejoystick_linux, etc...) But if we at least did that we would reduce code duplication by not having the platform specific code duplicated in 2 (with xinput it would become 3) places and have it collected in one place. Now completely unresearched but it may be possible to make a single joystick driver, maybe replacing winejoystick.drv that would build only the platform code that is relevant. but before I do another big chunk of work I am seeking some community buy-in and not just discuss with with Alexandre. I understand if the USB driver path gets actually fleshed out and we try to support Joysticks via that then all this separate driver work would fall away and be replaced. We of course need to make sure we come up with a plan that Alexandre will approve of. Would a replacement winejoystick.drv that holds all the platform specific code be acceptable? Is there a case where we would want that driver to be able to build multiple platform code? Maybe Linux and Linux Input? I will admit I am pretty ignorant of the Linux side of this whole situation. Ideas? Comments? thanks! -aric

7 9

Re: [PATCH 1/2] shell32: Implement Application property of IShellFolderViewDual
by Marvin May 5, 2015

May 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13252 Your paranoid android. === wxppro (32 bit shelldispatch) === shelldispatch.c:389: Test failed: unexpected type guid {efd84b2d-4bcf-4298-be25-eb542a59fbda} === w2003std (32 bit shelldispatch) === shelldispatch.c:389: Test failed: unexpected type guid {efd84b2d-4bcf-4298-be25-eb542a59fbda}

1 0

Re: (resend) server: fixup input windows on thread_detach
by Alexandre Julliard May 5, 2015

May 5, 2015

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -637,7 +637,7 @@ DECL_HANDLER(set_thread_desktop) > if (!current->process->desktop) > set_process_default_desktop( current->process, new_desktop, req->handle ); > > - if (old_desktop != new_desktop && current->queue) detach_thread_input( current ); > + if (old_desktop != new_desktop && current->queue) detach_thread_input( current, NULL ); You should also update the thread input in that case. There's no reason to require a specific thread for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] ddraw/tests: Add a ddraw2 specular lighting test.
by Marvin May 4, 2015

May 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13219 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH 2/4] wined3d: Keep track of renderbuffer capabilities.
by Henri Verbeet May 4, 2015

May 4, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 36be539..ad9b496 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -4095,7 +4095,7 @@ static BOOL wined3d_check_pixel_format_color(const struct wined3d_gl_info *gl_in > BYTE redSize, greenSize, blueSize, alphaSize, colorBits; > > /* Float formats need FBOs. If FBOs are used this function isn't called */ > - if (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_FLOAT) > + if (format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_FLOAT) That's not wrong as such, but it is pretty arbitrary. WINED3DFMT_FLAG_FLOAT is a basic property of the format, like e.g. the component masks and sizes, it shouldn't depend on the resource type. Once we'll get proper integer types for d3d10, it will probably make sense to keep track of the type (INT/UINT/FLOAT/UNORM/SNORM) as an enumeration instead, perhaps even per-component. > @@ -4178,8 +4178,8 @@ HRESULT CDECL wined3d_check_depth_stencil_match(const struct wined3d *wined3d, > ds_format = wined3d_get_format(&adapter->gl_info, depth_stencil_format_id); > if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > { > - if ((rt_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_RENDERTARGET) > - && (ds_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if ((rt_format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_RENDERTARGET) > + && (ds_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) This is actually wrong. At least, as long as we don't allow (plain) renderbuffers to be used for FBO attachments. There's nothing in the spec that says formats that can be used for color rendering with renderbuffers have to be available for color rendering with textures as well, and in fact that's much of the reason for this patch set. > @@ -998,9 +998,9 @@ static BOOL fbo_blit_supported(const struct wined3d_gl_info *gl_info, enum wined > break; > > case WINED3D_BLIT_OP_DEPTH_BLIT: > - if (!(src_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if (!(src_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) Similar to WINED3DFMT_FLAG_FLOAT, these are basic properties of the format.

2 4

Re: server: fixup input windows on thread_detach
by Alexandre Julliard May 4, 2015

May 4, 2015

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1075,6 +1075,27 @@ int attach_thread_input( struct thread *thread_from, struct thread *thread_to ) > return ret; > } > > +/* ensure the input data is correct for the thread after detach */ > +void correct_thread_input( struct thread *thread_from ) > +{ > + if (thread_from->queue) > + { > + struct thread *thread; > + if (thread_from->queue->input->focus) > + { > + thread = get_window_thread( thread_from->queue->input->focus ); > + if (thread != thread_from) thread_from->queue->input->focus = 0; > + release_object( thread ); > + } > + if (thread_from->queue->input->active) > + { > + thread = get_window_thread( thread_from->queue->input->active ); > + if (thread != thread_from) thread_from->queue->input->active = 0; > + release_object( thread ); > + } > + } > +} This needs to be done inside detach_thread_input so that it happens for all callers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32: Properly handle closing sockets during a select call.
by Marvin May 4, 2015

May 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13205 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at C0000241

1 0

Re: [2/3] ntdll: Introduce a helper function to check for existance of server handles.
by Alexandre Julliard May 4, 2015

May 4, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1417,6 +1417,7 @@ > # Server interface > @ cdecl -norelay wine_server_call(ptr) > @ cdecl wine_server_fd_to_handle(long long long ptr) > +@ cdecl wine_server_handle_exists(long long) > @ cdecl wine_server_handle_to_fd(long long ptr ptr) > @ cdecl wine_server_release_fd(long long) > @ cdecl wine_server_send_fd(long) Why do you need a new export for this? Is it just to avoid a dup() call or is there another reason? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: jscript: Date.parse: long date with '/' or '-' (try2)
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13202 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

libwine
by Theodore Dubois May 3, 2015

May 3, 2015

Hi, I’ve been looking at the wine code, and wondering why all the initialization code is in libwine.so. I would think it would make more sense to put it in the wine executable itself. Any explanations? ~Theodore

1 0

Re: jscript: Date.parse: long date with '/' or '-' (try2)
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13201 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Re: [PATCH 5/5] shell32: Better handle creation/destruction of shellview window
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13190 Your paranoid android. === wxppro (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected === w2003std (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected === wvistau64 (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === w2008s64 (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === wvistau64 (64 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === w2008s64 (64 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected

1 0

Re: [PATCH 4/5] explorer: Return IShellBrowser in response to SID_STopLevelBrowser
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13189 Your paranoid android. === wvistau64 (64 bit shelldispatch) === The test timed out

1 0