May 2015 - Wine-Devel - list.winehq.org

Re: (resend) server: fixup input windows on thread_detach
by Alexandre Julliard May 5, 2015

May 5, 2015

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -637,7 +637,7 @@ DECL_HANDLER(set_thread_desktop) > if (!current->process->desktop) > set_process_default_desktop( current->process, new_desktop, req->handle ); > > - if (old_desktop != new_desktop && current->queue) detach_thread_input( current ); > + if (old_desktop != new_desktop && current->queue) detach_thread_input( current, NULL ); You should also update the thread input in that case. There's no reason to require a specific thread for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/5] ddraw/tests: Add a ddraw2 specular lighting test.
by Marvin May 4, 2015

May 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13219 Your paranoid android. === build (build) === Make failed

2 1

Re: [PATCH 2/4] wined3d: Keep track of renderbuffer capabilities.
by Henri Verbeet May 4, 2015

May 4, 2015

On 30 April 2015 at 00:00, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c > index 36be539..ad9b496 100644 > --- a/dlls/wined3d/directx.c > +++ b/dlls/wined3d/directx.c > @@ -4095,7 +4095,7 @@ static BOOL wined3d_check_pixel_format_color(const struct wined3d_gl_info *gl_in > BYTE redSize, greenSize, blueSize, alphaSize, colorBits; > > /* Float formats need FBOs. If FBOs are used this function isn't called */ > - if (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_FLOAT) > + if (format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_FLOAT) That's not wrong as such, but it is pretty arbitrary. WINED3DFMT_FLAG_FLOAT is a basic property of the format, like e.g. the component masks and sizes, it shouldn't depend on the resource type. Once we'll get proper integer types for d3d10, it will probably make sense to keep track of the type (INT/UINT/FLOAT/UNORM/SNORM) as an enumeration instead, perhaps even per-component. > @@ -4178,8 +4178,8 @@ HRESULT CDECL wined3d_check_depth_stencil_match(const struct wined3d *wined3d, > ds_format = wined3d_get_format(&adapter->gl_info, depth_stencil_format_id); > if (wined3d_settings.offscreen_rendering_mode == ORM_FBO) > { > - if ((rt_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_RENDERTARGET) > - && (ds_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if ((rt_format->flags[WINED3D_GL_RES_TYPE_RB] & WINED3DFMT_FLAG_RENDERTARGET) > + && (ds_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) This is actually wrong. At least, as long as we don't allow (plain) renderbuffers to be used for FBO attachments. There's nothing in the spec that says formats that can be used for color rendering with renderbuffers have to be available for color rendering with textures as well, and in fact that's much of the reason for this patch set. > @@ -998,9 +998,9 @@ static BOOL fbo_blit_supported(const struct wined3d_gl_info *gl_info, enum wined > break; > > case WINED3D_BLIT_OP_DEPTH_BLIT: > - if (!(src_format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) > + if (!(src_format->flags[WINED3D_GL_RES_TYPE_RB] & (WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL))) Similar to WINED3DFMT_FLAG_FLOAT, these are basic properties of the format.

2 4

Re: server: fixup input windows on thread_detach
by Alexandre Julliard May 4, 2015

May 4, 2015

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -1075,6 +1075,27 @@ int attach_thread_input( struct thread *thread_from, struct thread *thread_to ) > return ret; > } > > +/* ensure the input data is correct for the thread after detach */ > +void correct_thread_input( struct thread *thread_from ) > +{ > + if (thread_from->queue) > + { > + struct thread *thread; > + if (thread_from->queue->input->focus) > + { > + thread = get_window_thread( thread_from->queue->input->focus ); > + if (thread != thread_from) thread_from->queue->input->focus = 0; > + release_object( thread ); > + } > + if (thread_from->queue->input->active) > + { > + thread = get_window_thread( thread_from->queue->input->active ); > + if (thread != thread_from) thread_from->queue->input->active = 0; > + release_object( thread ); > + } > + } > +} This needs to be done inside detach_thread_input so that it happens for all callers. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ws2_32: Properly handle closing sockets during a select call.
by Marvin May 4, 2015

May 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13205 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at C0000241

1 0

Re: [2/3] ntdll: Introduce a helper function to check for existance of server handles.
by Alexandre Julliard May 4, 2015

May 4, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -1417,6 +1417,7 @@ > # Server interface > @ cdecl -norelay wine_server_call(ptr) > @ cdecl wine_server_fd_to_handle(long long long ptr) > +@ cdecl wine_server_handle_exists(long long) > @ cdecl wine_server_handle_to_fd(long long ptr ptr) > @ cdecl wine_server_release_fd(long long) > @ cdecl wine_server_send_fd(long) Why do you need a new export for this? Is it just to avoid a dup() call or is there another reason? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: jscript: Date.parse: long date with '/' or '-' (try2)
by Marvin May 4, 2015

May 4, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13202 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

libwine
by Theodore Dubois May 4, 2015

May 4, 2015

Hi, I’ve been looking at the wine code, and wondering why all the initialization code is in libwine.so. I would think it would make more sense to put it in the wine executable itself. Any explanations? ~Theodore

1 0

Re: jscript: Date.parse: long date with '/' or '-' (try2)
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13201 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

2 1

Re: [PATCH 5/5] shell32: Better handle creation/destruction of shellview window
by Marvin May 3, 2015

May 3, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13190 Your paranoid android. === wxppro (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected === w2003std (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected === wvistau64 (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === w2008s64 (32 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === wvistau64 (64 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected === w2008s64 (64 bit shlview) === shlview.c:573: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:586: Test failed: unexpected shlview.c:605: Test failed: unexpected shlview.c:579: Test failed: unexpected shlview.c:579: Test failed: unexpected

1 0