May 2015 - Wine-Devel - list.winehq.org

Re: msvcirt: Share exceptions implementation with msvcp
by Alexandre Julliard May 26, 2015

May 26, 2015

Iván Matellanes <matellanesivan(a)gmail.com> writes: > This is the first patch of my GSoC project :) > It implements the exceptions in msvcirt by using the code in msvcp90. > @@ -304,13 +304,15 @@ typedef enum __exception_type { > EXCEPTION_RERAISE, > EXCEPTION, > EXCEPTION_BAD_ALLOC, > - EXCEPTION_BAD_CAST, > EXCEPTION_LOGIC_ERROR, > +#ifndef _MSVCIRT > EXCEPTION_LENGTH_ERROR, > EXCEPTION_OUT_OF_RANGE, > EXCEPTION_INVALID_ARGUMENT, > EXCEPTION_RUNTIME_ERROR, > EXCEPTION_FAILURE, > + EXCEPTION_BAD_CAST, > +#endif Please avoid as many ifdefs as possible. For instance, having extra enums or unexported functions doesn't do any harm, so there's no reason to make a special case for them. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/4] riched20: Implement tomTrackParms/tomCacheParms
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13590 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wxppro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2003std (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w8 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700

1 0

Re: [PATCH 1/4] riched20: Support ITextFont instances detached from a range
by Marvin May 26, 2015

May 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13589 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wxppro (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2003std (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w8 (32 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === wvistau64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 === w2008s64 (64 bit richole) === richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700 richole.c:1838: Test failed: got -1 richole.c:1939: Test failed: got 700

1 0

Re: [2/3] widl: Fix handling of circular imports that involve the file passed on the command line.
by Alexandre Julliard May 25, 2015

May 25, 2015

Francois Gouget <fgouget(a)free.fr> writes: > --- > tools/widl/parser.l | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/widl/parser.l b/tools/widl/parser.l > index b911186..2333687 100644 > --- a/tools/widl/parser.l > +++ b/tools/widl/parser.l > @@ -488,6 +488,9 @@ int do_import(char *fname) > int ptr = import_stack_ptr; > int ret, fd; > > + if (strcmp(import_stack_ptr ? import_stack[0].input_name : input_name, > + fname) == 0) > + return 0; /* initial source file */ This won't work for out-of-tree builds. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/ole32: Silence a FIXME
by Stefan Dösinger May 25, 2015

May 25, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-05-25 um 07:56 schrieb Hugh McMaster: > This fixme appears on wine init either before console output or > after it. The fixme text is interrupting the output for Wine's > CLI-based programs, making the output difficult to read. WINEDEBUG=-all is the best way to deal with disturbing debug output. Or if you want other fixmes WINEDEBUG=-ole helps for this specific one. Though in many other places trying to QI an unknown interface is a WARN, not a FIXME. Which interface(s) are the application(s) / other libs trying to QI? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVYtuhAAoJEN0/YqbEcdMwaLcP/iP/cWFNiqommeRRFXKpv1GN gCxfqO3H5H/dWlobvFahZ6caZvRg87tw940dO6l9ch3i29A3ooJR0QNmJefk4WBa RGCp+g9lDxqIp9KvsnHGeHN4gdNXdIkNDtTusuDi1HC31MW3Wcl9rL3eCwTLeK3O 6QNTmAgUK+ZJM5xvBcTPMEidqgw2+L8SyjRTS3I84NPa5tZhRWV5gwvglBIKlvlk j2ve5wu7MYMyCU0yadmDyCioLeVzMMvIK1vFTkMbLlWlQc+ni2wgAvjD51ODW9Mg LiJJow6CVnyIF2htAaqs1bVWgtRYiFkHecidliJzqlP3CS11dmys0izy4GCO5nCZ 8vQpvVjHnKjzyrTaHkJJnGXdCSFhcDdjj2VlxrhKZy0C5TUKhsu9HLux3ZZnh8rX 3LX/Di16PgALnx28oAGaA/tkjuutdToZioHVi6V4doRZu1gVQAVdVuqu+jyj8rnR GQfdUbBsMN0sfdm4wzG2Ls+BdPyymq4FtgvMoYjH7Ue3+4smQu0EilmTCHAnQdZU OjF4dUgOqSdenQOWbVJGuiQzabwfxfQVePVlUuse7sthnXf8xAk5CCEBl/ITvYxZ vbORohm8+Xr1yQ9qi7rgRB1ItU3ThrEUFm6DAruIHUtgfiK4zVXczFXh83GXoPur mY9cApML3tVu3Q0S+WtK =5NtD -----END PGP SIGNATURE-----

3 2

Re: [PATCH 5/5] riched20/tests: Initial tests for font duplication behavior
by Marvin May 24, 2015

May 24, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13570 Your paranoid android. === w2000pro (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wxppro (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2003std (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wvistau64 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2008s64 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w8 (32 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === wvistau64 (64 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1 === w2008s64 (64 bit richole) === richole.c:1938: Test failed: got -1 richole.c:1976: Test failed: got -1 richole.c:1986: Test failed: got -1

1 0

Re: [PATCH] d3d11.idl: add the basic interfaces to enable video decoding
by Steve Lhomme May 24, 2015

May 24, 2015

Any update on this patch ? Should I submit again with the one space removed ? Steve On Wed, May 13, 2015 at 11:06 AM, Steve Lhomme <robux4(a)videolabs.io> wrote: > On Wed, May 13, 2015 at 1:02 PM, Stefan Dösinger > <stefandoesinger(a)gmail.com> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> >> This patch looks better. Ultimately Henri and Alexandre have to decide >> if they're happy with it. Henri is on vacation this week, so don't >> expect much movement until Monday. > > No problem. > >> Am 2015-05-11 um 15:41 schrieb Steve Lhomme: >>> +interface ID3D11VideoDecoderOutputView : ID3D11View >>> +{ >>> + void GetDesc( >>> + [out] D3D11_VIDEO_DECODER_OUTPUT_VIEW_DESC *pDesc ); >>> +} >> There's a space that doesn't match the rest of the patch, but does match >> what's in the MS headers. Since it is the only case I can spot I think >> it's a typo in a self-typed header rather than a missed fixup in a >> copypasted header. > > Should I resubmit without the extra space ? > >> You don't have to use the same parameter names in Methods or functions. >> Instead of "pDesc" you can e.g. use "desc". The rest of the header >> already uses pCrap though, so I'm ok with the current way. > > I checked the other d3d IDL files in the repo to match what's already > in use and pDesc is very common, for example in d3d10.idl. > >> -----BEGIN PGP SIGNATURE----- >> Version: GnuPG v2 >> >> iQIcBAEBAgAGBQJVUy8wAAoJEN0/YqbEcdMwXHwQAJd+LDxvH03XR5L/+bpxZB/o >> U6g7cgMmtkklfSeCazZrUe0R5ZZExbmmIN+bBr6GJpbQezVQW3vng9EQj6ihfBjf >> 6CEKr9BJF/xOhYdHPrhg3yxaD9MZrnsXa9llNFGds6SI0q1L8uCclyAuPxV+AoSO >> fxgElN7/+LCRTwEM9shdwuxVELrikW52UmVTEajhNematVixplOh6pJMe+8XyPp/ >> iSn+6p/jBeytKzjb83uUnyGqVaFLOIg9ywR2PPeA43RvNYVnfV9agxeOGJYvO7Zw >> mKWmv+fG9sIXzvF/G9upnceE69YHf8WoIdEHW+kZsOl2ctRRB4ycBHp0rG4s2IeH >> f1XpENP55lT+dYIc/Tef8IdpABzmGD7JwtnbLyxRbF4F9Qwfe6x7GP3VtEBp1M/+ >> 5nePonYZ4N55sShelaU8X7/JxUuZb8onlz1UfEXJkIykopyQJJw49rXkQv7OFm2k >> xyJAsXCQk5Z9sqXXBuFxUnKkip9P8UaLOwFJ8WFUVgHrkS9UAceiehUKgvpcwYfX >> vxh48j6gAE4fBEUBVOlXiR4lMV7cDUWIoJdCopUkzxysPMp/hi3BcDk7EdrF9LX9 >> c01jQc2N+JwzjIyNhSC01Jk23Qp2lOG+pUT1UrKcACesoB1H6Zm3QbNv5hVgUfkz >> pFuJsryqPWxQFS02SvTu >> =ToVh >> -----END PGP SIGNATURE-----

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 10)
by Marvin May 23, 2015

May 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13560 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [3/3] ws2_32: Add WSAPoll() implementation
by Marvin May 23, 2015

May 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=13559 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

WineConf 2015
by Tom Wickline May 22, 2015

May 22, 2015

I posted this on the wineconf mailing list but I'm not sure everyone is currently subscribed to that list so I'm posting here as well. Their is a Facebook page setup for anyone interested in WineConf 2015 to confirm their attendance, post to page, like, invite etc etc. https://www.facebook.com/events/734919546617361/ Cheers, Tom

1 0