June 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] user32: Erase backgrounds of owner-drawn buttons with the default color.
by Alexandre Julliard June 23, 2015

June 23, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -268,13 +268,7 @@ LRESULT ButtonWndProc_common(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam, > { > HDC hdc = (HDC)wParam; > RECT rc; > - HBRUSH hBrush; > - HWND parent = GetParent(hWnd); > - if (!parent) parent = hWnd; > - hBrush = (HBRUSH)SendMessageW(parent, WM_CTLCOLORBTN, (WPARAM)hdc, (LPARAM)hWnd); > - if (!hBrush) /* did the app forget to call defwindowproc ? */ > - hBrush = (HBRUSH)DefWindowProcW(parent, WM_CTLCOLORBTN, > - (WPARAM)hdc, (LPARAM)hWnd); > + HBRUSH hBrush = GetSysColorBrush(COLOR_BTNFACE); This would need a more convincing test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Don't leave behind open explorer windows.
by Marvin June 23, 2015

June 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14594 Your paranoid android. === w2003std (32 bit progman_dde) === progman_dde.c:377: Test failed: Window "C:\Documents and Settings\All Users\Start Menu\Programs\Group1" was not created in 45 seconds - assumed failure. [S_G:12] === w7u (32 bit progman_dde) === progman_dde.c:519: Test failed: DeleteGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:13] === wvistau64 (64 bit progman_dde) === progman_dde.c:571: Test failed: DeleteItem f2g1Name.lnk: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_I:5]

1 0

Re: [PATCH 1/2] user32: Send BM_SETCHECK before WM_CAPTURECHANGED and add tests.
by Marvin June 23, 2015

June 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14585 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10547: Test failed: expected PeekMessage to return FALSE, got 1

1 0

Re: ntdll: Randomize security cookie when available
by Alexandre Julliard June 23, 2015

June 23, 2015

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -3620,7 +3620,30 @@ typedef struct _FPO_DATA { > WORD cbFrame : 2; > } FPO_DATA, *PFPO_DATA; > > -typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY { > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY64 { > + DWORD Size; > + DWORD TimeDateStamp; > + WORD MajorVersion; > + WORD MinorVersion; > + DWORD GlobalFlagsClear; > + DWORD GlobalFlagsSet; > + DWORD CriticalSectionDefaultTimeout; > + ULONGLONG DeCommitFreeBlockThreshold; > + ULONGLONG DeCommitTotalFreeThreshold; > + ULONGLONG LockPrefixTable; > + ULONGLONG MaximumAllocationSize; > + ULONGLONG VirtualMemoryThreshold; > + ULONGLONG ProcessAffinityMask; > + DWORD ProcessHeapFlags; > + WORD CSDVersion; > + WORD Reserved1; > + ULONGLONG EditList; > + ULONGLONG SecurityCookie; > + ULONGLONG SEHandlerTable; > + ULONGLONG SEHandlerCount; > +} IMAGE_LOAD_CONFIG_DIRECTORY64, *PIMAGE_LOAD_CONFIG_DIRECTORY64; > + > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY32 { > DWORD Size; > DWORD TimeDateStamp; > WORD MajorVersion; You'll need to update the generated tests: gcc -c -o generated.o ../../../../wine/dlls/ntdll/tests/generated.c -I. \ -I../../../../wine/dlls/ntdll/tests -I../../../include -I../../../../wine/include -D__WINESRC__ \ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_IMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:842:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:865:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:866:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:868:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:869:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:870:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:873:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:874:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:875:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:876:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:877:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:878:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:879:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:882:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:883:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:884:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:885:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:888:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:891:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:894:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:895:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:896:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:897:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:898:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:899:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:900:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:901:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:902:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:903:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_PIMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:2108:5: error: size of unnamed array is negative Makefile:348: recipe for target 'generated.o' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: Fix RegEnumValueW when enumerating long values.
by Bernhard Übelacker June 23, 2015

June 23, 2015

Hello, please ignore this patch for now. It seems that systemfontfileenumerator_GetCurrentFontFile uses RegEnumValueW in a way not supported on Windows - with giving NULL parameters for value and/or val_count [1]. When RegEnumValueW is called with proper value parameter the problem with not returning correct count would not happen already. So, as far as I see, first all uses of RegEnumValue with NULL parameters for value or val_count need a fix. Kind regards, Bernhard [1] https://testbot.winehq.org/JobDetails.pl?Key=14533

4 5

[7/11]hidclass.sys: Implement HID devices
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/device.c | 560 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 86 +++++++ dlls/hidclass.sys/main.c | 4 + 4 files changed, 651 insertions(+) create mode 100644 dlls/hidclass.sys/device.c

2 2

[2/11]hidclass.sys: add a wine native hid device driver service
by Aric Stewart June 22, 2015

June 22, 2015

Allow for Minidriver registration --- configure | 2 + configure.ac | 1 + dlls/hidclass.sys/Makefile.in | 8 ++++ dlls/hidclass.sys/hid.h | 53 +++++++++++++++++++++++++ dlls/hidclass.sys/hidclass.sys.spec | 2 + dlls/hidclass.sys/main.c | 78 +++++++++++++++++++++++++++++++++++++ loader/wine.inf.in | 13 +++++++ 7 files changed, 157 insertions(+) create mode 100644 dlls/hidclass.sys/Makefile.in create mode 100644 dlls/hidclass.sys/hid.h create mode 100644 dlls/hidclass.sys/hidclass.sys.spec create mode 100644 dlls/hidclass.sys/main.c

2 2

[9/11]hidclass.sys: Add Plug-and-play interfaces
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 4 +- dlls/hidclass.sys/descriptor.c | 1092 ++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 8 + dlls/hidclass.sys/main.c | 1 + dlls/hidclass.sys/pnp.c | 301 +++++++++++ 5 files changed, 1405 insertions(+), 1 deletion(-) create mode 100644 dlls/hidclass.sys/descriptor.c create mode 100644 dlls/hidclass.sys/pnp.c

2 2

Re: [1/2] msi/tests: Fix test failures on win2k3.
by Marvin June 22, 2015

June 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14545 Your paranoid android. === wvistau64 (32 bit install) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit install) === The test timed out

1 0

Re: [PATCH 3/5] wined3d: Remove ffp_proj_control flag from the GLSL shader backend.
by Henri Verbeet June 22, 2015

June 22, 2015

On 19 June 2015 at 00:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Using the GLSL shader backend implies GLSL vp and fp replacements, An argument could perhaps be made that it should, but currently that's not true. You can still use the the GLSL shader backend with e.g. fixed function fragment processing with some level of success. The only reason it doesn't happen much in practice is the way select_vertex_implementation() and select_fragment_implementation() are implemented, but that's external to the shader backend.

3 2

[4/11]hidclass.sys: Implement a report ring buffer
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/buffer.c | 166 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 13 ++++ 3 files changed, 180 insertions(+) create mode 100644 dlls/hidclass.sys/buffer.c

2 1

Re: gdi32/tests: Japanese Win 7 uses MS Shell Dlg as its default GUI font.
by Akihiro Sagawa June 22, 2015

June 22, 2015

Hello Huw, Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7: > font.c:5799: Test failed: 4(1): expected height 15, got 12 > font.c:5808: 4(1): default gui font is MS UI Gothic As both systems are running with Japanese locale, I compared my Windows 7 settings with testbot's one. And, I found that testbot returns different GetSystemDefaultUILanguage() value. In other words, testbot returns 0x0409 (English US)[1], but my PC returns 0x0411 (Japanese). [1] https://testbot.winehq.org/JobDetails.pl?Key=14511&log_206=1#k206 I'm not sure if the configuration is on purpose, or not. However, the test needs to be updated on that point. Akihiro Sagawa

3 4

Re: [PATCH (resend)] winealsa: Make string "Unknown sound card" translatable.
by Alexandre Julliard June 22, 2015

June 22, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > --- > dlls/winealsa.drv/Makefile.in | 4 +++- > dlls/winealsa.drv/mmdevdrv.c | 9 +++++++-- > dlls/winealsa.drv/resource.h | 19 +++++++++++++++++++ > dlls/winealsa.drv/winealsa.rc | 29 +++++++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 3 deletions(-) > create mode 100644 dlls/winealsa.drv/resource.h > create mode 100644 dlls/winealsa.drv/winealsa.rc Adding translation in drivers doesn't work very well, it needs some more makefile support. It would be better to do this some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: Add SystemDefaultUILanguage setting to OS info.
by Akihiro Sagawa June 22, 2015

June 22, 2015

On Sun, 21 Jun 2015 14:15:15 +0900, Akihiro Sagawa wrote: > Some of testbots have a different value as expected. And, a certain GDI > function seems to be affected by this setting. So, it's worth to be > logging. > --- > programs/winetest/main.c | 1 + > 1 file changed, 1 insertion(+) Please ignore this patch. I confirmed SystemDefaultUILanguage doesn't affect GDI functions. Akihiro Sagawa

1 0

Re: winedbg: Avoid direct comparison of enum with -1 in packet_set_breakpoint.
by Michael Stefaniuc June 22, 2015

June 22, 2015

Hello Gerald, On 06/19/2015 11:48 PM, Gerald Pfeifer wrote: > clang 3.4.1 complains as follows when compiling this: > > gdbproxy.c:2147:23: warning: comparison of constant -1 with > expression of type 'enum be_xpoint_type' is always false > > I see two ways to address this: adding a dummy set to -1 to the > enum, or casting the enum to int before comparing against -1. > > The patch below implements the first approach; if you prefer, > I'll provide a patch for the other approach. adding an element be_xpoint_free to the enum is better than a cast. > > Gerald > --- > programs/winedbg/gdbproxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c > index dd63f7d..181b32a 100644 > --- a/programs/winedbg/gdbproxy.c > +++ b/programs/winedbg/gdbproxy.c > @@ -2144,7 +2144,7 @@ static enum packet_return packet_set_breakpoint(struct gdb_context* gdbctx) > /* really set the Xpoint */ > for (xpt = &gdbctx->Xpoints[NUM_XPOINT - 1]; xpt >= gdbctx->Xpoints; xpt--) > { > - if (xpt->type == -1) > + if ((int)xpt->type == -1) > { > if (be_cpu->insert_Xpoint(gdbctx->process->handle, > gdbctx->process->process_io, &gdbctx->context, > bye michael

1 0

[11/11]hidclass.sys: Add os x minidriver
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/hid.h | 3 + dlls/hidclass.sys/main.c | 6 + dlls/hidclass.sys/minidriver_osx.c | 546 +++++++++++++++++++++++++++++++++++++ 4 files changed, 556 insertions(+) create mode 100644 dlls/hidclass.sys/minidriver_osx.c

1 0

[10/11]include: add HID_REVISION
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidclass.h | 2 ++ 1 file changed, 2 insertions(+)

1 0

[8/11]include: add IRP_MJ_POWER minor function codes
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/wdm.h | 5 +++++ 1 file changed, 5 insertions(+)

1 0

[6/11]include: HID_XFER_PACKET to hidclass.h
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidclass.h | 6 ++++++ 1 file changed, 6 insertions(+)

1 0

[5/11]include: new ddk/hidtypes.h include file
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidtypes.h | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 include/ddk/hidtypes.h

1 0

[3/11]hidclass.sys: Implement helper IoCallMinidriver
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/hid.h | 1 + dlls/hidclass.sys/main.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+)

1 0

[1/11]loader: add Dev Class for HID devices
by Aric Stewart June 22, 2015

June 22, 2015

--- loader/wine.inf.in | 2 ++ 1 file changed, 2 insertions(+)

1 0

[14/14]hid: Implement HidP_GetScaledUsageValue
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++------ include/ddk/hidpi.h | 1 + 3 files changed, 48 insertions(+), 7 deletions(-)

1 0

[13/14]hid: Implement HidP_MaxUsageListLength
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 2 +- 3 files changed, 55 insertions(+), 2 deletions(-)

1 0

[12/14]hid: Implement HidD_GetAttributes
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 20 +++++++++++++++++++- include/ddk/hidsdi.h | 9 +++++++++ 3 files changed, 29 insertions(+), 2 deletions(-)

1 0