June 2015 - Wine-Devel - list.winehq.org

RE: [PATCH 1/3] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 5).
by Aaryaman Vasishta June 25, 2015

June 25, 2015

> > This is by no means a full review, just a couple of obvious things I noticed. > > On 24 June 2015 at 17:02, Aaryaman Vasishta <jem456.vasishta at gmail.com <https://www.winehq.org/mailman/listinfo/wine-devel>> wrote: > >* +static HRESULT CALLBACK surface_callback(IDirectDrawSurface *surface, DDSURFACEDESC *desc, void *context) > *>* +{ > *>* + IDirectDrawClipper *d3drm_clipper = NULL; > *Initializing this to NULL is pointless, you initialize it before all > uses with the IDirectDrawSurface_GetClipper() call below. > > >* + if (context) > *>* + { > *"context" should always be non-NULL here. > > >* + hr = IDirectDrawSurface_GetClipper(surface, &d3drm_clipper); > *>* + ok(hr == DD_OK, "Cannot get attached clipper from primary surface (hr = %x).\n", hr); > *>* + if (SUCCEEDED(hr)) > *You have an ok() one line above that states "hr == DD_OK" at this > point. If the GetClipper() call failed you'd get a test failure. > > Once you've found the primary you can of course return DDENUMRET_CANCEL. > > I think you're making things too complicated though. I'd just call > EnumSurfaces() with "&primary" as context pointer, set it in the > callback, and then just do the rest of the tests after EnumSurfaces() > returns, instead of trying to fit those into the callback. > > Thank you for the suggestions! I have decided to return the primary surface directly, and set it to NULL if it doesn't exist via the context, something like this, which seems to run fine on my windows machine: > static HRESULT CALLBACK surface_callback(IDirectDrawSurface *surface, > DDSURFACEDESC *desc, void **context) > { > IDirectDrawClipper *d3drm_clipper; > HRESULT hr; > > if (desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) > { > *context = surface; > return DDENUMRET_CANCEL; > } > IDirectDrawSurface_Release(surface); > > return DDENUMRET_OK; > } > Then in the tests, simply check if the context returned is NULL, if yes then perform related tests on it inside the test. Thank you!

1 1

Re: [3/14]hid: translated HidD_ functions to their IOCTLs
by Nikolay Sivov June 25, 2015

June 25, 2015

On 25.06.2015 18:15, Aric Stewart wrote: > BOOLEAN WINAPI HidD_SetFeature(HANDLE HidDeviceObject, PVOID ReportBuffer, ULONG ReportBufferLength) > { > - FIXME("(%p %p %u) stub\n", HidDeviceObject, ReportBuffer, ReportBufferLength); > - return FALSE; > + TRACE("(%p %p %u)\n", HidDeviceObject, ReportBuffer, ReportBufferLength); > + return DeviceIoControl(HidDeviceObject, IOCTL_HID_SET_OUTPUT_REPORT, ReportBuffer, ReportBufferLength, NULL, 0, NULL, NULL); > } I can't say I know anything about that, but this looks like a typo, maybe it should use IOCTL_HID_SET_FEATURE?

1 0

Re: d3dx9-36: Save multiplications to improve performance
by Matteo Bruni June 25, 2015

June 25, 2015

2015-06-25 4:07 GMT+02:00 David Adam <david.adam.cnrs(a)gmail.com>: > Hello, > > with my dual-core, for sides=65000 the gain is about 40%. It probably has more to do with avoiding the division than the multiplication. Can you add a test for a polygon with that many faces and see if the result matches native better with the simplification or without?

1 0

Re: [1/3] d3dcompiler: Share the source with d3dcompiler_46 (try 2)
by Matteo Bruni June 25, 2015

June 25, 2015

2015-06-25 12:30 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Rename define to D3D_COMPILER_VERSION > > Changelog: > d3dcompiler: Share the source with d3dcompiler_46 > > > Best Regards > Alistair Leslie-Hughes Series looks good to me, thanks!

1 0

Re: [PATCH 1/3] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 5).
by Henri Verbeet June 25, 2015

June 25, 2015

This is by no means a full review, just a couple of obvious things I noticed. On 24 June 2015 at 17:02, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > +static HRESULT CALLBACK surface_callback(IDirectDrawSurface *surface, DDSURFACEDESC *desc, void *context) > +{ > + IDirectDrawClipper *d3drm_clipper = NULL; Initializing this to NULL is pointless, you initialize it before all uses with the IDirectDrawSurface_GetClipper() call below. > + if (context) > + { "context" should always be non-NULL here. > + hr = IDirectDrawSurface_GetClipper(surface, &d3drm_clipper); > + ok(hr == DD_OK, "Cannot get attached clipper from primary surface (hr = %x).\n", hr); > + if (SUCCEEDED(hr)) You have an ok() one line above that states "hr == DD_OK" at this point. If the GetClipper() call failed you'd get a test failure. Once you've found the primary you can of course return DDENUMRET_CANCEL. I think you're making things too complicated though. I'd just call EnumSurfaces() with "&primary" as context pointer, set it in the callback, and then just do the rest of the tests after EnumSurfaces() returns, instead of trying to fit those into the callback.

1 0

Re: wineboot: Create MachineGuid registry value.
by Alexandre Julliard June 25, 2015

June 25, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > The MachineGuid registry key should exist even without calling CryptAcquireContextW. > Optionally we could remove the remove the corresponding code from advapi32 afterwards. This doesn't need to run at every boot, so you can probably stick it into the registration of some crypto dll like wintrust. And please also remove the advapi32 code. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [1/3] wininet/tests: Add tests for overriding host header.
by Marvin June 25, 2015

June 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14698 Your paranoid android. === w7u (32 bit http) === http.c:2891: Test failed: HttpSendRequest failed http.c:2896: Test failed: HttpQueryInfo failed http.c:2897: Test failed: got status 0, expected 200 http.c:5813: Test failed: HttpAddRequestHeadersA failed 12019 http.c:5819: Test failed: HttpQueryInfoA failed 12019 http.c:5820: Test failed: header missing

1 0

Re: [1/3] wininet/tests: Add tests for overriding host header.
by Sebastian Lackner June 25, 2015

June 25, 2015

On 25.06.2015 12:27, Sebastian Lackner wrote: > From: Michael Müller <michael(a)fds-team.de> > > --- > dlls/wininet/tests/http.c | 109 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 109 insertions(+) > The testbot already shows a test failure on Win7, but it seems to be random. It doesn't occur in a second run: https://newtestbot.winehq.org/JobDetails.pl?Key=14699.

1 0

Re: [PATCH (resend)] cmd: Consistently wrap lines to 75 characters.
by Alexandre Julliard June 25, 2015

June 25, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > 75 characters is the maximum length of a line before gettext breaks it, > so this convention will cause each translatable string to fit snugly > into the po files. It's also about what we were doing anyway, just not > consistently. > > The biggest advantage to consistent line wrapping is that translators > will no longer have to guess where they should insert line breaks. You'll need to also update the duplicate text in programs/start, and it would be nice if you could try to fix at least some of the translations so that we don't have to invalidate all of them. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3drm: Mark DllCanUnloadNow and DllGetClassObject as private.
by Alexandre Julliard June 25, 2015

June 25, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -19,5 +19,5 @@ > @ stdcall D3DRMVectorScale(ptr ptr float) > @ stdcall D3DRMVectorSubtract(ptr ptr ptr) > @ stdcall Direct3DRMCreate(ptr) > -@ stub DllCanUnloadNow > -@ stub DllGetClassObject > +@ stub -private DllCanUnloadNow > +@ stub -private DllGetClassObject Private is not useful on a stub. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] cmd: fix invalid "else if" execution (try2)
by Marvin June 25, 2015

June 25, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14664 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 693 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 694 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 697 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 698 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 700 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 702 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 703 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 717 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 718 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 719 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 723 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 724 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 725 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 731 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 732 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 745 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 755 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 756 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 757 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 767 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 768 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 769 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 770 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 774 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 775 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 776 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 783 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1367 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1368 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1369 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path(a)foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1370 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1371 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1372 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1373 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1374 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1376 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1379 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1380 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1383 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1384 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1385 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar') === w2003std (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 692 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 693 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 694 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 695 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 696 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 697 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 698 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 699 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 700 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 702 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 703 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 704 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 708 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 709 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 712 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 715 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 716 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 717 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 718 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 719 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 720 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 721 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 722 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 723 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 724 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 725 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 727 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 728 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 729 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 730 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 731 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 732 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 734 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 735 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 736 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 737 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 738 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 740 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 741 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 742 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 743 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 744 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 745 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 747 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 748 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 749 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 750 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 751 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 752 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 753 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 755 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 756 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 757 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 758 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 759 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 760 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 761 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 762 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 763 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 764 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 765 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 767 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 768 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 769 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 770 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 771 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 772 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 773 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 774 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 775 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 776 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 778 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 779 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 780 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 781 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 782 (got 'Found missing result: "C:\Documents and Settings\Administrator\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 783 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1367 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1368 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1369 (got 'C:\Documents and Settings\Administrator\My Documents\foobar\foodir2', wanted '@drive@@path(a)foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1370 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1371 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1372 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1373 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1374 (got '--- Extra endlocal in called batch', wanted '@drive@@path(a)foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1376 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1379 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1380 (got 'C:\Documents and Settings\Administrator\My Documents\foobar', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1383 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1384 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1385 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path(a)foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 318 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

2 2

Re: ntdll: Randomize security cookie when available (try 3)
by Alexandre Julliard June 25, 2015

June 25, 2015

André Hentschel <nerv(a)dawncrow.de> writes: > + /* randomize security cookie */ > + > + if (IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG < nt->OptionalHeader.NumberOfRvaAndSizes && > + (pos = nt->OptionalHeader.DataDirectory[IMAGE_DIRECTORY_ENTRY_LOAD_CONFIG].VirtualAddress)) > + { > + IMAGE_LOAD_CONFIG_DIRECTORY *loadcfg = (IMAGE_LOAD_CONFIG_DIRECTORY *)(ptr + pos); > + ULONG_PTR *cookie = (ULONG_PTR *)loadcfg->SecurityCookie; > + > + srand( time( NULL ) ); > + *cookie = rand(); This won't be random at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

When/how to build separate debug symbol files
by Ken Thomases June 25, 2015

June 25, 2015

Hi, I'm investigating how to best make Wine build and install debug symbol files on OS X. My understanding is that, on Linux, the distros usually provide a separate package for a user to install Wine's debug symbols. From recent work in dbghelp, I'm guessing such a package installs debug symbol files next to the corresponding binary or in a .debug subdirectory next to it. Is that correct? How do packagers generate such separate debug symbol files? Is it a special option (make target?) in Wine's build process? Or is it a post-processing step after Wine is built and installed to a staging directory? How does this interact with stripping during building for the non-debug-symbol, normal Wine package? For what it's worth, I'm working on make dbghelp support DWARF-2 debug info on OS X <https://bugs.winehq.org/show_bug.cgi?id=22384>. On OS X, the normal link step does not transfer the DWARF-2 debug info from the object files to the file binary. Rather, you have to execute a separate command, dsymutil, to "link" the debug info, but that ends up in a separate file, not the binary. So, the first part is figuring out when to invoke dsymutil and where to put the debug symbol file. The second part is having dbghelp find that debug symbol file. I think I have a handle on the second part. The first part is what I'm trying to figure out. The dsymutil depends on references from the linked binary to the original object files from which it was created. Those references are in the STABS info. So, it has to be invoked 1) at a point where those object files are accessible, and 2) before the binary has been stripped of the necessary references. A problem that may be unique to OS X is how to support debugging when running Wine build from source, either run from the build tree or installed by the user. Since the debug information isn't easily accessible unless the separate dsymutil step was done, we may want to do it at link time, not just at install time. Unfortunately, that largely defeats the point of separating out debug linking from normal linking, which was to save time and disk space. Thanks, Ken

3 3

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Alex Henrie June 25, 2015

June 25, 2015

2015-06-18 2:08 GMT-06:00 Alexandre Julliard <julliard(a)winehq.org>: > So now I want to take a step back, and take the time to look at what we > are doing wrong, and listen to new ideas. I'd like to encourage > everyone, but especially people who are disgruntled or have given up > hope that we'd ever change, to send (either in this thread or by private > mail) their suggestions for what we should be doing differently, and how. As a relatively new Wine developer, I submitted a UTF-7 implementation copied from ReactOS, but it was rejected without explanation. After some prodding, I was told that I needed to rewrite the code from scratch.[2] Then, after I rewrote the patches, I was told to put the implementation in kernel32 instead of libwine.[3] The next patchset was ignored, but I finally got a couple of cryptic messages about a buffer overflow and table-based tests.[4][5] Later I got more cryptic messages about needing more tests, but again I was not told what needed to be tested, just "think about it".[6][7] Finally I was told "this isn't going anywhere",[9] "you have nowhere near enough tests"[10] and "if you're too stupid to know what you're doing wrong then you shouldn't contribute".[11] The above process literally lasted from January to December 2012. After that, I was so upset with the Wine project and AJ in particular that I did not submit a single patch to Wine for more than a year.[12] When I finally decided to try submitting the UTF-7 patches again in October 2014, I begged AJ for feedback and once again got nothing specific.[13] In desperation, I turned to IRC and was invited to participate in Wine Staging. They patiently provided specific, line-by-line feedback and even helped rewrite the code in a couple of places. They also accepted the code into their fork to get some real-world testing.[14] By the end of November 2014 (less than two months later!) the patchset was accepted into mainline Wine.[12] Wine has been one of the worst, if not the worst, open source project I have ever worked with. (I think it's a tie between Wine and Qt's QSerialPort module, but that's another story.) My UTF-7 experience illustrates exactly why we need Wine Staging or something like it: Without the detailed feedback that the Wine Staging developers provided, this feature would have never been accepted. Furthermore, I would not have learned the tips and tricks that I needed to know to write acceptable patches in the future. The idea that all discussion and development needs to happen on wine-devel and wine-patches in order to gain trust is BS. AJ was unwilling to take more than a glance at the UTF-7 patches until they had gone through probably a hundred iterations on GitHub and the wine-staging IRC channel. In my experience, AJ is far more likely to accept a patch done right the first time than a patch submitted 12 times because the submitter keeps finding problems with it. Alexandre, the best thing you could do differently is to provide verbose feedback on every patch. You have been working on Wine for a very long time and what is obvious to you is not obvious to everyone else. If you don't have time to write feedback yourself, ask another Wine developer to do it. Ideally we would have a list of trusted advisors for each program and DLL, people who are available to answer questions in their areas of expertise. It would also be a good idea to notice new developers, assign tutors to them, and have the tutors welcome the new developers and offer to answer questions. Please understand that I like Wine, I want to attract new Wine developers, and I want to see it become the most popular Windows API implementation. I hope you can take this email as constructive criticism without it negatively affecting my Julliard Rank™ ;-) -Alex [1] https://www.winehq.org/pipermail/wine-devel/2012-January/093705.html [2] https://www.winehq.org/pipermail/wine-devel/2012-May/095451.html [3] https://www.winehq.org/pipermail/wine-devel/2012-July/096531.html [4] https://www.winehq.org/pipermail/wine-devel/2012-August/096867.html [5] https://www.winehq.org/pipermail/wine-devel/2012-August/096872.html [6] https://www.winehq.org/pipermail/wine-devel/2012-September/096901.html [7] https://www.winehq.org/pipermail/wine-devel/2012-September/096910.html [8] https://www.winehq.org/pipermail/wine-devel/2012-December/097994.html [9] https://www.winehq.org/pipermail/wine-devel/2012-December/098015.html [10] https://www.winehq.org/pipermail/wine-devel/2012-December/098036.html [11] https://www.winehq.org/pipermail/wine-devel/2012-December/098051.html [12] https://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Alex+He… [13] https://www.winehq.org/pipermail/wine-devel/2014-October/105402.html [14] https://github.com/wine-compholio/wine-staging/commit/04467e7e68b12850349fb…

6 6

Re: d3dcompiler: Share the source with d3dcompiler_46
by Matteo Bruni June 24, 2015

June 24, 2015

2015-06-24 12:15 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > diff --git a/dlls/d3dcompiler_46/Makefile.in b/dlls/d3dcompiler_46/Makefile.in > index 08c5145..41c98f7 100644 > --- a/dlls/d3dcompiler_46/Makefile.in > +++ b/dlls/d3dcompiler_46/Makefile.in > @@ -1,6 +1,24 @@ > MODULE = d3dcompiler_46.dll > +IMPORTS = dxguid uuid > +EXTRALIBS = $(LIBWPP) > +EXTRADEFS = -D_D3DCOMPILER_VER=46 That define isn't used yet, right? I guess you can keep it around but maybe call it D3D_COMPILER_VERSION since there is such a define in recent d3dcompiler.h from the SDK. Or just drop it for the time being and reintroduce it when there will be a need to distinguish the version we're compiling for from the shared code. Otherwise it looks fine to me. Maybe rename d3dcompiler_43_main.c to just main.c? That change can be a separate patch.

1 0

Re: [PATCH 1/2] msvcp90: Set _Locimp vtable in _Locimp ctors (Valgrind) (try2) (was: msvcp90: Call _Locimp vector dtor (Valgrind))
by Piotr Caban June 24, 2015

June 24, 2015

On 06/24/15 16:46, Daniel Lehman wrote: > +DEFINE_RTTI_DATA0(locale__Locimp, 0, ".?AV_Locimp(a)locale@std@@") There should be: DEFINE_RTTI_DATA1(locale__Locimp, 0, &locale_facet_rtti_base_descriptor, ".?AV_Locimp(a)locale@std@@") Cheers, Piotr

1 0

Re: [PATCH] cmd: fix invalid "else if" execution
by Frédéric Delanoy June 24, 2015

June 24, 2015

On Tue, Jun 23, 2015 at 11:33 PM, Thomas Faller <tfaller1(a)gmx.de> wrote: > > Fix for: https://bugs.winehq.org/show_bug.cgi?id=37478 > > --- > programs/cmd/builtins.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) You should add a test case. -- Frédéric Delanoy

1 0

Re: [PATCH 2/2] msvcp90: Copy name in _Getctype (Valgrind)
by Piotr Caban June 24, 2015

June 24, 2015

On 06/23/15 22:57, Daniel Lehman wrote: > + name = ___lc_locale_name_func()[LC_COLLATE]; > + size = wcslen(name)+1; > + ret->name = malloc(size*sizeof(*name)); > + if (!ret->name) throw_exception(EXCEPTION_BAD_ALLOC, NULL); > + memcpy(ret->name, name, size); There should be size*sizeof(*name) in memcpy. Also please rename the variable to len if it's used to store length (or store buffer size in it). Thanks, Piotr

1 0

Re: [PATCH 1/2] msvcp90: Call _Locimp vector dtor (Valgrind)
by Piotr Caban June 24, 2015

June 24, 2015

Hi, the bug is caused by incorrect vtable being set in locale__Locimp_ctor_transparent and locale__Locimp_copy_ctor functions. The locale_facet vtable is correct and should not be changed. Cheers, Piotr

1 0

Re: [PATCH 3/3] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D (try 4).
by Stefan Dösinger June 24, 2015

June 24, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-06-23 um 20:19 schrieb Aaryaman Vasishta: > + hr = IDirectDraw2_SetCooperativeLevel(ddraw, window, coop_level); > + ok(SUCCEEDED(hr), "Failed to set cooperative level, hr %#x.\n", hr); As long as you're always passing coop_level = DDSCL_NORMAL I don't think there's a need for the parameter. > + if (coop_level & DDSCL_NORMAL) > + { > + IDirectDrawClipper *clipper; > + > + hr = IDirectDraw2_CreateClipper(ddraw, 0, &clipper, NULL); > + ok(SUCCEEDED(hr), "Failed to create clipper, hr %#x.\n", hr); > + hr = IDirectDrawClipper_SetHWnd(clipper, 0, window); > + ok(SUCCEEDED(hr), "Failed to set clipper window, hr %#x.\n", hr); > + hr = IDirectDrawSurface_SetClipper(surface, clipper); > + ok(SUCCEEDED(hr), "Failed to set surface clipper, hr %#x.\n", hr); > + IDirectDrawClipper_Release(clipper); > + } I wonder why the ddraw test is setting a clipper on the offscreen surface. It should not have an effect. Henri, do you remember why this is done? > + hr = IDirect3D2_QueryInterface(d3d2, &IID_IDirectDraw, (void**)&ddraw); Why aren't you using the existing ddraw1 interface variable? > + primary_surface_found = FALSE; > + hr = IDirectDraw_EnumSurfaces(ddraw, DDENUMSURFACES_ALL | DDENUMSURFACES_DOESEXIST, > + NULL, NULL, surface_callback); > + ok(hr == DD_OK, "Failed to enumerate surfaces (hr = %x).\n", hr); > + ok(!primary_surface_found, "Primary surface shouldn't be created by CreateDeviceFromD3D.\n"); > + IDirectDraw_Release(ddraw); > + > + hr = IDirectDrawSurface_GetAttachedSurface(surface, &caps, &ds); > + ok(hr == DD_OK, "Cannot get attached depth surface (hr = %x).\n", hr); > + > + desc.dwSize = sizeof(desc); > + hr = IDirectDrawSurface_GetSurfaceDesc(ds, &desc); > + ok(hr == DD_OK, "Cannot get z surface desc structure (hr = %x).\n", hr); I think here it would be interesting to confirm that the Z surface is the one created by create_device(). -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVicS1AAoJEN0/YqbEcdMwYNkQAIJL8xzJEd4WjLNzIw8wIuq3 BZiLV8SZIVTlCgZERHQQ46CqtG1MZ4JdZEOvEQpw1pGK0Keq3xTgPE7LLgNZzXx6 fg0Xm1CT9MwWalbj31HelKMB7yHnxTNHhE2oDncDboITI26kxL46IdCsTwJZD9cc yg65kkluHAUyT3+7+k7FFu7ZP3mQUOxnim4YkI3jx48Ls6snhMz6RZwTygZdJXvR eQ0pD/tMdGN/wDBy+y+Dehn2yWScbRgoO1GCqOLH4/L6y8rlAdLMSMZv4HWVN74m cAvpxKC0nketkROouNkDcHrjEhFbL3DnBeNRfd5IfnORgHjwZipqqv7dXhGWELZL R7ZpjtLEzV5/dL2pDjZri3j6Xpi5vZRhlMdiKAvCcNNYfFtXJcZSwlK0AP8ek1SF Lhr3RiOmY0RQ7a2K0Z0UqXCNr+vibBEsfBLdqhuTsC4ipMSzygo0J9dCVIoM9VOl SqjtXo0N6YdzZR0IGpSDuE/uCy33vu1D4ykqyW7UBGkT2CUNTVxfUEPkERnr26E0 h11OrBrNKoNSlxaeg1IcVdh9iipabkAF+iL5XqDsXzT/45TrvBvKsYYL+eRSSbtE q94hxYKMupoIHFtsx62wwhVZUYsf/8x27662aDmY3LmixAb8iOR08lo2JhKczOSZ mootefOFvk8PZPkF5Z8G =Zo0P -----END PGP SIGNATURE-----

2 2

Re: [PATCH 2/3] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface (try 4).
by Stefan Dösinger June 24, 2015

June 24, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, One I don't like here is the hardcoded DDSCAPS_SYSTEMEMORY for the Z buffer. You need it on Windows because of the RGB device and Wine doesn't check, so it kinda works. But I recommend to do something like this: BOOL use_sysmem_zbuffer; ... hr = IDirect3DRM2_CreateDeviceFromSurface(d3drm2, &driver, ddraw, surface, &device2); hr = IDirect3DRMDevice2_GetDirect3DDevice2(device2, &d3ddevice2); hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &d3drm_surface); hr = IDirectDrawSurface_GetAttachedSurface(d3drm_surface, &caps, &ds); hr = IDirectDrawSurface_GetSurfaceDesc(ds, &desc); use_sysmem_zbuffer = desc->ddsCaps.dwCaps & DDSCAPS_SYSTEMMEMORY; ... /* Release everything */ /* Create new sysmem surface */ when creating the new Z buffer set DDSCAPS_SYSTEMMEMORY only if use_sysmem_zbuffer is true. Another thing to test: After destroying the d3drm device is the Z buffer removed from the surface when (a) d3drm created it and (b) you created it? Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVicXHAAoJEN0/YqbEcdMw73gP/3wLEdptNIWr2IFNXJHoSZ15 2g3annULMUw++NvXuBXY1RJdUiR0UQxbGyRNJtFzl8KN66lbl2DOY9/ePkgahIbB 0XKedAtS8F5zoLwRHrbZ/VGSI5Kv8ClHSi0F+jZ5Og9TvwqYKC40vNaBC2WXlSHL KSmOzilln0xDFPecaqyIwbLNO7y1DBnQ7sncLgGCuyxrWM8lK0vmXcAxubS5JyJJ Hd0chD6+EpjxisVWZUVNLFV1HEN9zyL6VDSYcJnNNp9ufGKh6wAoFcywx1vyQTsX tiicEYlW90rvhM2dIZ/m6EcJsR/n6E4iMlj2S4yq9Kc4jySMaC0bYa0B4vPQbbaj YUcQ10qmuH/saROVPjjwjT5O1xISVZ2OOlk3PQYbwVSa1afOMU0ZZu5xNYmkRJ71 21r9cBqePMtIzWixxq+5DiYIRaSDelODlGD8P+LdfYu51DZK3oi1GK0vwX46wHmX M6S6i583uj//ZaZAVG/iCkZ9IPrnkqUnWe8WVGqy1KKJ/e/goq8eQhK9bUHz0GCM BCaklF368VarJWQ0S2ggtdZ006cnc+aqOlfJTRA4UoSfQGU6ACne/blCeJBIGMwv 4mwtvNQvZIvoO6sUW+kmU7T6vCsyxVGfVq96csPbqNvSlidLl8H8IN7f8DK65feW w4s6zvEsdURxeHfcOUNL =bY5s -----END PGP SIGNATURE-----

2 2

Re: [2/2] msimtf: Add stub implementation for IActiveIMMMessagePumpOwner.
by Nikolay Sivov June 24, 2015

June 24, 2015

On 24.06.2015 0:48, Thomas Faber wrote: > +static HRESULT WINAPI ActiveIMMApp_IActiveIMMMessagePumpOwner_QueryInterface(IActiveIMMMessagePumpOwner* iface, > + REFIID iid, LPVOID *ppvOut) > +{ > + ActiveIMMApp *This = impl_from_IActiveIMMMessagePumpOwner(iface); > + return IActiveIMMApp_QueryInterface(&This->IActiveIMMApp_iface, iid, ppvOut); > +} It's usually up to author, but I'll still mention this - no need to prefix function names with ActiveIMMApp_ because there's no other IActiveIMMMessagePumpOwner implementation, so names won't collide. It would be nice to have a simple test too, to make sure QI supports this interface, but as we don't have tests dir at all for this module it could be a separate patch I guess.

2 1

Re: [1/2] dimm.idl: Add IActiveIMMMessagePumpOwner.
by Nikolay Sivov June 24, 2015

June 24, 2015

What's a reason for having it declared like that: -- + HRESULT OnTranslateMessage([in] const struct tagMSG *pMsg); --- Why not use MSG*?

2 3

Re: d3dcompiler: Add D3DReadFileToBlob, D3DWriteBlobToFile, , D3DCompileFromFile, D3DCompile2 stubs
by Matteo Bruni June 24, 2015

June 24, 2015

2015-06-23 10:41 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Currently the code for d3dcompiler_*dll's is in the _43 version. > > However these function belong in d3dcompiler_46+ > > So, > 1. Is it ok to use private functions? I don't know all the implications of that but it doesn't seem to be necessarily wrong. > If not, how should it be done? Keep in mind that d3d9, d3d10, x_input will > have the same issue at some point. Not sure what you mean with d3d9 here. Did you mean d3dx9? > 2. Could it be done like the msvrt* libraites? However since the structures > haven't changed between versions maybe this isn't the best way. There are / have been a few bugs reported for d3dx9 with applications failing to cope with forwarded functions (e.g. https://bugs.winehq.org/show_bug.cgi?id=21817) and I imagine similar problems might also happen with d3dcompiler so that would be a point in favor of this solution. Moreover, in general each native d3dcompiler_xx (AND each d3dx9_xx!) version has a separate copy of the HLSL compiler inside and each one has a different version of the compiler. That means you will get things like https://bugs.winehq.org/show_bug.cgi?id=33770#c7 unless we can generate different code for different d3dcompiler_xx.dll versions. Another one of those I know of is that functions inside ASCII effect files can be "overloaded" with multiple implementations for different shader versions. In older d3dx9 you specify the target version by spelling it out in the function definition, but that changed at some point and the older syntax just doesn't work on newer HLSL compiler versions. So I think this is the route we want to take eventually. Maybe your patch is fine for the time being though. > 3. Move the code the latest DLL. That would work but notice that the same thing might (will?) repeat after MS releases new versions of d3dcompiler_xx.dll with new exports. BTW, I should have asked this earlier: what do you need those newer d3dcompiler_xx.dlls for? AFAIU those versions > 43 are never installed in system32 and applications are supposed to just bring a copy in their application directory (e.g. see the "Redistribution" section in http://blogs.msdn.com/b/chuckw/archive/2012/05/07/hlsl-fxc-and-d3dcompile.a… or point 6c in https://msdn.microsoft.com/en-us/library/windows/desktop/ee663275%28v=vs.85…)

2 1

Re: [PATCH 1/3] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 4).
by Stefan Dösinger June 23, 2015

June 23, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Looks pretty good, there are 2 minor issues left (see below) and 3 code style things: Am 2015-06-23 um 20:19 schrieb Aaryaman Vasishta: > +BOOL primary_surface_found = FALSE; Please make it static. Also no need to initialize global variables, they're set to zero by the compiler. (Same as static variables inside a function). > + if ((desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) == DDSCAPS_PRIMARYSURFACE) desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE is enough in this case as there's only one flag. > + clipper = context; > + ok(clipper == d3drm_clipper, "Expected clipper returned == %p, got %p.\n", clipper, d3drm_clipper); > + IDirectDrawClipper_Release(d3drm_clipper); ok(clipper == context, "..."); should work, no need to have an extra variable for this. > +static void test_create_device_from_clipper(void) > +{ This function tests IDirect3DRM2 / IDirect3DRMDevice2. Think about how you want to add version 1 and 3 tests. Either add them in the same function or create 3 test functions. I prefer the latter case, but then you may want to name them test_create_device_from_clipper{1,2,3} or similar. > + hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, 300, 200, &device2); > + ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice2 interface (hr = %x).\n", hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + cref2 = get_refcount((IUnknown *)clipper); > + todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 = %u.\n", ref1, ref2); > + todo_wine ok(cref2 > cref1, "expected cref2 > cref1, got cref1 = %u , cref2 = %u.\n", cref1, cref2); Please also show that the d3drm2 refcount is untouched. This also applies to patches 2 and 3. > + hr = IDirectDraw_SetDisplayMode(ddraw, 640, 480, 16); > + ok(hr == DD_OK, "Cannot set display mode to 16bpp (hr = %x).\n", hr); Please use the current desktop width and height here (i.e., what was returned from GetDisplayMode earlier). Setting a lower resolution has the tendency to screw up window and desktop icon positioning. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVib/vAAoJEN0/YqbEcdMw8UoP+gLjxDhe3SjrslH3I0h3cM0M W9KbODhgTmn+C2j3a2rOXvbllAXkjAI9oSnbKp3msE4uJw7GT5QOx+y1828xVF54 RhxoQsYJuXAptAzzlwOS9Dpj5f8sebfj8AG3KENEeMBaKPJFnuER2AHD7o0Bl9Td LVXbSWjvkhsGIRSW2JWKVFQIRdCKaeiRciA0ScH/yQxxL0h/1BOdoLqzc5+Nv6wW /drwTUVR0MQrqzNt3qKPnhNNe2CXS7DQvc4KA1s0WsNxTbrl1orKXDclls1UhL5L iIIJtVF0H7jPE5kF5yVsW0uyjojNI7EnEbVtQQHecFV1UfLQQhykIbw3Vc/tg8Up lpkaEtQvSUYsJMIWKyG9nTAsoz1ZAeb8k97YH8SS/HtG3dZzOThLkPjfbpOPRxeK 07d2P+I4FkyXdiDNZ/dzXIuJUGoBriXM/rPJFqnHWrOm3Lor6GqhKXE+SxOpPeOA rUcVYfd/XEJPT+7PIOdeu/C9ldUPjVmV3BpWze0oXaj9noLJUWojk4E0emsazaUB bXXcJfj0r65SnFUUbxmwjZK50OdF36iku3Oohgl7kpmatWF3IN1g9BmgoDnXuHi8 8xVAi+6OQm7+oU04kZi/4KHPAg41FcMBnxtuxYBASn0NZvaY002ZMWpfCAbdV6pX LouyQXU2ct2Y5h78u9FG =F7Cf -----END PGP SIGNATURE-----

2 1

Re: [PATCH 2/2] user32: Erase backgrounds of owner-drawn buttons with the default color.
by Alexandre Julliard June 23, 2015

June 23, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -268,13 +268,7 @@ LRESULT ButtonWndProc_common(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam, > { > HDC hdc = (HDC)wParam; > RECT rc; > - HBRUSH hBrush; > - HWND parent = GetParent(hWnd); > - if (!parent) parent = hWnd; > - hBrush = (HBRUSH)SendMessageW(parent, WM_CTLCOLORBTN, (WPARAM)hdc, (LPARAM)hWnd); > - if (!hBrush) /* did the app forget to call defwindowproc ? */ > - hBrush = (HBRUSH)DefWindowProcW(parent, WM_CTLCOLORBTN, > - (WPARAM)hdc, (LPARAM)hWnd); > + HBRUSH hBrush = GetSysColorBrush(COLOR_BTNFACE); This would need a more convincing test. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Don't leave behind open explorer windows.
by Marvin June 23, 2015

June 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14594 Your paranoid android. === w2003std (32 bit progman_dde) === progman_dde.c:377: Test failed: Window "C:\Documents and Settings\All Users\Start Menu\Programs\Group1" was not created in 45 seconds - assumed failure. [S_G:12] === w7u (32 bit progman_dde) === progman_dde.c:519: Test failed: DeleteGroup Group1: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_G:13] === wvistau64 (64 bit progman_dde) === progman_dde.c:571: Test failed: DeleteItem f2g1Name.lnk: Expected Error DMLERR_NO_ERROR, received DMLERR_EXECACKTIMEOUT. [D_I:5]

1 0

Re: [PATCH 1/2] user32: Send BM_SETCHECK before WM_CAPTURECHANGED and add tests.
by Marvin June 23, 2015

June 23, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14585 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10547: Test failed: expected PeekMessage to return FALSE, got 1

1 0

Re: ntdll: Randomize security cookie when available
by Alexandre Julliard June 23, 2015

June 23, 2015

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -3620,7 +3620,30 @@ typedef struct _FPO_DATA { > WORD cbFrame : 2; > } FPO_DATA, *PFPO_DATA; > > -typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY { > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY64 { > + DWORD Size; > + DWORD TimeDateStamp; > + WORD MajorVersion; > + WORD MinorVersion; > + DWORD GlobalFlagsClear; > + DWORD GlobalFlagsSet; > + DWORD CriticalSectionDefaultTimeout; > + ULONGLONG DeCommitFreeBlockThreshold; > + ULONGLONG DeCommitTotalFreeThreshold; > + ULONGLONG LockPrefixTable; > + ULONGLONG MaximumAllocationSize; > + ULONGLONG VirtualMemoryThreshold; > + ULONGLONG ProcessAffinityMask; > + DWORD ProcessHeapFlags; > + WORD CSDVersion; > + WORD Reserved1; > + ULONGLONG EditList; > + ULONGLONG SecurityCookie; > + ULONGLONG SEHandlerTable; > + ULONGLONG SEHandlerCount; > +} IMAGE_LOAD_CONFIG_DIRECTORY64, *PIMAGE_LOAD_CONFIG_DIRECTORY64; > + > +typedef struct _IMAGE_LOAD_CONFIG_DIRECTORY32 { > DWORD Size; > DWORD TimeDateStamp; > WORD MajorVersion; You'll need to update the generated tests: gcc -c -o generated.o ../../../../wine/dlls/ntdll/tests/generated.c -I. \ -I../../../../wine/dlls/ntdll/tests -I../../../include -I../../../../wine/include -D__WINESRC__ \ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \ -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 -gstrict-dwarf -g -O2 -fno-diagnostics-show-caret ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_IMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:842:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:865:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:866:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:868:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:869:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:870:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:873:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:874:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:875:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:876:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:877:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:878:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:879:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:882:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:883:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:884:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:885:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:888:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:891:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:894:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:895:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:896:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:897:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:898:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:899:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:900:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:901:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:902:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c:903:5: error: size of unnamed array is negative ../../../../wine/dlls/ntdll/tests/generated.c: In function ‘test_pack_PIMAGE_LOAD_CONFIG_DIRECTORY’: ../../../../wine/dlls/ntdll/tests/generated.c:2108:5: error: size of unnamed array is negative Makefile:348: recipe for target 'generated.o' failed -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: Fix RegEnumValueW when enumerating long values.
by Bernhard Übelacker June 23, 2015

June 23, 2015

Hello, please ignore this patch for now. It seems that systemfontfileenumerator_GetCurrentFontFile uses RegEnumValueW in a way not supported on Windows - with giving NULL parameters for value and/or val_count [1]. When RegEnumValueW is called with proper value parameter the problem with not returning correct count would not happen already. So, as far as I see, first all uses of RegEnumValue with NULL parameters for value or val_count need a fix. Kind regards, Bernhard [1] https://testbot.winehq.org/JobDetails.pl?Key=14533

4 5

[7/11]hidclass.sys: Implement HID devices
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/device.c | 560 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 86 +++++++ dlls/hidclass.sys/main.c | 4 + 4 files changed, 651 insertions(+) create mode 100644 dlls/hidclass.sys/device.c

2 2

[2/11]hidclass.sys: add a wine native hid device driver service
by Aric Stewart June 22, 2015

June 22, 2015

Allow for Minidriver registration --- configure | 2 + configure.ac | 1 + dlls/hidclass.sys/Makefile.in | 8 ++++ dlls/hidclass.sys/hid.h | 53 +++++++++++++++++++++++++ dlls/hidclass.sys/hidclass.sys.spec | 2 + dlls/hidclass.sys/main.c | 78 +++++++++++++++++++++++++++++++++++++ loader/wine.inf.in | 13 +++++++ 7 files changed, 157 insertions(+) create mode 100644 dlls/hidclass.sys/Makefile.in create mode 100644 dlls/hidclass.sys/hid.h create mode 100644 dlls/hidclass.sys/hidclass.sys.spec create mode 100644 dlls/hidclass.sys/main.c

2 2

[9/11]hidclass.sys: Add Plug-and-play interfaces
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 4 +- dlls/hidclass.sys/descriptor.c | 1092 ++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 8 + dlls/hidclass.sys/main.c | 1 + dlls/hidclass.sys/pnp.c | 301 +++++++++++ 5 files changed, 1405 insertions(+), 1 deletion(-) create mode 100644 dlls/hidclass.sys/descriptor.c create mode 100644 dlls/hidclass.sys/pnp.c

2 2

Re: [1/2] msi/tests: Fix test failures on win2k3.
by Marvin June 22, 2015

June 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14545 Your paranoid android. === wvistau64 (32 bit install) === Failure running script in VM: timed out waiting for the child process === w8 (32 bit install) === The test timed out

1 0

Re: [PATCH 3/5] wined3d: Remove ffp_proj_control flag from the GLSL shader backend.
by Henri Verbeet June 22, 2015

June 22, 2015

On 19 June 2015 at 00:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Using the GLSL shader backend implies GLSL vp and fp replacements, An argument could perhaps be made that it should, but currently that's not true. You can still use the the GLSL shader backend with e.g. fixed function fragment processing with some level of success. The only reason it doesn't happen much in practice is the way select_vertex_implementation() and select_fragment_implementation() are implemented, but that's external to the shader backend.

3 2

[4/11]hidclass.sys: Implement a report ring buffer
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/buffer.c | 166 ++++++++++++++++++++++++++++++++++++++++++ dlls/hidclass.sys/hid.h | 13 ++++ 3 files changed, 180 insertions(+) create mode 100644 dlls/hidclass.sys/buffer.c

2 1

Re: gdi32/tests: Japanese Win 7 uses MS Shell Dlg as its default GUI font.
by Akihiro Sagawa June 22, 2015

June 22, 2015

Hello Huw, Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7: > font.c:5799: Test failed: 4(1): expected height 15, got 12 > font.c:5808: 4(1): default gui font is MS UI Gothic As both systems are running with Japanese locale, I compared my Windows 7 settings with testbot's one. And, I found that testbot returns different GetSystemDefaultUILanguage() value. In other words, testbot returns 0x0409 (English US)[1], but my PC returns 0x0411 (Japanese). [1] https://testbot.winehq.org/JobDetails.pl?Key=14511&log_206=1#k206 I'm not sure if the configuration is on purpose, or not. However, the test needs to be updated on that point. Akihiro Sagawa

3 4

Re: [PATCH (resend)] winealsa: Make string "Unknown sound card" translatable.
by Alexandre Julliard June 22, 2015

June 22, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > --- > dlls/winealsa.drv/Makefile.in | 4 +++- > dlls/winealsa.drv/mmdevdrv.c | 9 +++++++-- > dlls/winealsa.drv/resource.h | 19 +++++++++++++++++++ > dlls/winealsa.drv/winealsa.rc | 29 +++++++++++++++++++++++++++++ > 4 files changed, 58 insertions(+), 3 deletions(-) > create mode 100644 dlls/winealsa.drv/resource.h > create mode 100644 dlls/winealsa.drv/winealsa.rc Adding translation in drivers doesn't work very well, it needs some more makefile support. It would be better to do this some other way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winetest: Add SystemDefaultUILanguage setting to OS info.
by Akihiro Sagawa June 22, 2015

June 22, 2015

On Sun, 21 Jun 2015 14:15:15 +0900, Akihiro Sagawa wrote: > Some of testbots have a different value as expected. And, a certain GDI > function seems to be affected by this setting. So, it's worth to be > logging. > --- > programs/winetest/main.c | 1 + > 1 file changed, 1 insertion(+) Please ignore this patch. I confirmed SystemDefaultUILanguage doesn't affect GDI functions. Akihiro Sagawa

1 0

Re: winedbg: Avoid direct comparison of enum with -1 in packet_set_breakpoint.
by Michael Stefaniuc June 22, 2015

June 22, 2015

Hello Gerald, On 06/19/2015 11:48 PM, Gerald Pfeifer wrote: > clang 3.4.1 complains as follows when compiling this: > > gdbproxy.c:2147:23: warning: comparison of constant -1 with > expression of type 'enum be_xpoint_type' is always false > > I see two ways to address this: adding a dummy set to -1 to the > enum, or casting the enum to int before comparing against -1. > > The patch below implements the first approach; if you prefer, > I'll provide a patch for the other approach. adding an element be_xpoint_free to the enum is better than a cast. > > Gerald > --- > programs/winedbg/gdbproxy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/winedbg/gdbproxy.c b/programs/winedbg/gdbproxy.c > index dd63f7d..181b32a 100644 > --- a/programs/winedbg/gdbproxy.c > +++ b/programs/winedbg/gdbproxy.c > @@ -2144,7 +2144,7 @@ static enum packet_return packet_set_breakpoint(struct gdb_context* gdbctx) > /* really set the Xpoint */ > for (xpt = &gdbctx->Xpoints[NUM_XPOINT - 1]; xpt >= gdbctx->Xpoints; xpt--) > { > - if (xpt->type == -1) > + if ((int)xpt->type == -1) > { > if (be_cpu->insert_Xpoint(gdbctx->process->handle, > gdbctx->process->process_io, &gdbctx->context, > bye michael

1 0

[11/11]hidclass.sys: Add os x minidriver
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/Makefile.in | 1 + dlls/hidclass.sys/hid.h | 3 + dlls/hidclass.sys/main.c | 6 + dlls/hidclass.sys/minidriver_osx.c | 546 +++++++++++++++++++++++++++++++++++++ 4 files changed, 556 insertions(+) create mode 100644 dlls/hidclass.sys/minidriver_osx.c

1 0

[10/11]include: add HID_REVISION
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidclass.h | 2 ++ 1 file changed, 2 insertions(+)

1 0

[8/11]include: add IRP_MJ_POWER minor function codes
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/wdm.h | 5 +++++ 1 file changed, 5 insertions(+)

1 0

[6/11]include: HID_XFER_PACKET to hidclass.h
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidclass.h | 6 ++++++ 1 file changed, 6 insertions(+)

1 0

[5/11]include: new ddk/hidtypes.h include file
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidtypes.h | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 include/ddk/hidtypes.h

1 0

[3/11]hidclass.sys: Implement helper IoCallMinidriver
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hidclass.sys/hid.h | 1 + dlls/hidclass.sys/main.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+)

1 0

[1/11]loader: add Dev Class for HID devices
by Aric Stewart June 22, 2015

June 22, 2015

--- loader/wine.inf.in | 2 ++ 1 file changed, 2 insertions(+)

1 0

[14/14]hid: Implement HidP_GetScaledUsageValue
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++------ include/ddk/hidpi.h | 1 + 3 files changed, 48 insertions(+), 7 deletions(-)

1 0

[13/14]hid: Implement HidP_MaxUsageListLength
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 2 +- 3 files changed, 55 insertions(+), 2 deletions(-)

1 0

[12/14]hid: Implement HidD_GetAttributes
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 20 +++++++++++++++++++- include/ddk/hidsdi.h | 9 +++++++++ 3 files changed, 29 insertions(+), 2 deletions(-)

1 0