June 2015 - Wine-Devel - list.winehq.org

[11/14]hid: Implement HidD_GetInputReport
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidd.c | 8 ++++++++ include/ddk/hidsdi.h | 1 + 3 files changed, 10 insertions(+), 1 deletion(-)

1 0

[10/14]hid: Implement HidD_GetPreparsedData and HidD_FreePreparsedData
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 4 ++-- dlls/hid/hidd.c | 25 +++++++++++++++++++++++++ include/ddk/hidclass.h | 9 +++++++++ include/ddk/hidsdi.h | 2 ++ 4 files changed, 38 insertions(+), 2 deletions(-)

1 0

[9/14]hid: Implement HidP_InitializeReportForID
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 63 insertions(+), 1 deletion(-)

1 0

[8/14]hid: Implement HidP_GetUsageValue
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 64 insertions(+), 1 deletion(-)

1 0

[7/14]hid: Implement HidP_GetUsages
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + 3 files changed, 125 insertions(+), 1 deletion(-)

1 0

[6/14]hid: Implement HidP_GetValueCaps
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 2 ++ 3 files changed, 62 insertions(+), 1 deletion(-)

1 0

[5/14]hid: Implement HidP_GetButtonCaps
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidpi.h | 1 + include/wine/hid.h | 2 +- 4 files changed, 58 insertions(+), 2 deletions(-)

1 0

[4/14]hid: Implement HidP_GetCaps
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/Makefile.in | 1 + dlls/hid/hid.spec | 2 +- dlls/hid/hidp.c | 53 ++++++++++++++++ include/ddk/hidpi.h | 168 +++++++++++++++++++++++++++++++++++++++++++++++++++ include/ddk/hidsdi.h | 2 +- include/wine/hid.h | 80 ++++++++++++++++++++++++ 6 files changed, 304 insertions(+), 2 deletions(-) create mode 100644 dlls/hid/hidp.c create mode 100644 include/ddk/hidpi.h create mode 100644 include/wine/hid.h

1 0

[3/14]hid: translated HidD_ functions to their IOCTLs
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/hidd.c | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-)

1 0

[2/14]hid: break HidD_ functions out into their own module
by Aric Stewart June 22, 2015

June 22, 2015

--- dlls/hid/Makefile.in | 1 + dlls/hid/hidd.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++++ dlls/hid/main.c | 40 +------------------------------- 3 files changed, 67 insertions(+), 39 deletions(-) create mode 100644 dlls/hid/hidd.c

1 0

[1/14]include: add ddk/hidclass.h
by Aric Stewart June 22, 2015

June 22, 2015

--- include/ddk/hidclass.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 include/ddk/hidclass.h

1 0

HID work, two sets of patches
by Aric Stewart June 22, 2015

June 22, 2015

Hi all, So I have been working on HID support for the last few months. I have something ready for public review. It is not quite in shape to submit but since this is such a huge bit of work with so many moving pieces I thought it would be useful to have people able to help me make sure it works right. Answer to question #1, This is only implemented for Mac right now. That is because I know the mac HID stuff well and could do it. There will of course be a need for a linux minidriver as well, (like the mac minidriver) but I am not qualified to write that. I would be more than happy to help someone write it. Answer to question #2, No, this is not hooked up anywhere yet. Ideally it will get hooked up to be the bases for the winejoystick.drv, dinput, xinput and RawInput. I have a very rough implementation for winejoystick.drv but it is so rough that I am not presenting it yet. Answer to question #3, yes it works. I both have written my own HID client as well as the Microsoft hclient.exe test application and they work using this code as expected. Answer to question #4, No, this will most likely NOT support windows minidrivers. Mostly because of the lack of any sort of real plug and play support. There are some architecture bits that may be tricky with windows native minidrivers in .sys format. It is not outside the realm of doable eventually but I do not expect it to work right now. Finally, this is only the start. It is not implementing output or feature reports and there are still a lot of things to improve and implement. But I feel like I need to start getting this out into the public. Yes I will be submitting these and going through the whole process, but the more eyes and people willing to help me make these correct the better. That is why they are going to wine-devel first. So all comments welcome, but be kind. this was a lot of work and I am sure I made some stupid mistakes somewhere. -aric

1 0

Re: gdi32/freetype: Properly handle loading of FT_Long-sized types (Valgrind)
by Marc Bessières June 21, 2015

June 21, 2015

Hi Nicolay, May I ask you a question on your patch? Why is the last line of the below extract still using reg_load_dword, and not reg_load_ftlong, while the cast was removed? It doesn't seem good to me, or there is something special about the flags? Cheers, Marc @@ -1541,10 +1549,10 @@ static void load_face(HKEY hkey_face, WCHAR *face_name, Family *family, void *bu else face->FullName = NULL; - reg_load_dword(hkey_face, face_index_value, (DWORD*)&face- >face_index); + reg_load_ftlong(hkey_face, face_index_value, &face->face_index); reg_load_dword(hkey_face, face_ntmflags_value, &face->ntmFlags); - reg_load_dword(hkey_face, face_version_value, (DWORD*)&face- >font_version); - reg_load_dword(hkey_face, face_flags_value, (DWORD*)&face->flags); + reg_load_ftlong(hkey_face, face_version_value, &face->font_version); + reg_load_dword(hkey_face, face_flags_value, &face->flags);

2 2

Re: server: return NULL from device_open_file on failure to allocate fd
by Sebastian Lackner June 19, 2015

June 19, 2015

On 20.06.2015 00:22, Daniel Lehman wrote: > > Does this patch address a real issue or is it just by looking at the source? &file->obj should not lead to an invalid memory access because its just a more convenient way to do a type conversion. If file == NULL, then &file->obj will also be NULL. Of course its a matter of taste what is easier to read. Regards, Sebastian

2 1

Re: DInput axis mapping explanation
by Michael Gardner June 19, 2015

June 19, 2015

Thank you, Aric! I have a couple more questions, if you have time to answer them. 1) Is Wine affected by the joystick mapping that can be done via jscal (and if not, why)? 2) How would I see the list of values as returned by the device, so I know what mapping to construct?

1 0

Re: [PATCH 5/5] wined3d: Add a setting for requesting OpenGL core profile usage.
by Henri Verbeet June 19, 2015

June 19, 2015

On 19 June 2015 at 00:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -199,6 +200,14 @@ static BOOL wined3d_dll_init(HINSTANCE hInstDLL) > > if (hkey || appkey) > { > + if (!get_config_key( hkey, appkey, "UseCore", buffer, size)) > + { > + if (!strcmp(buffer,"enabled")) > + { > + TRACE("Requested OpenGL Core profile.\n"); > + wined3d_settings.use_core = TRUE; > + } > + } > if ( !get_config_key( hkey, appkey, "UseGLSL", buffer, size) ) > { > if (!strcmp(buffer,"disabled")) Would it make sense to express this in terms of the maximum (desktop) GL version to use instead? I imagine that at some point we'll want to use GL versions beyond 3.2, at which point it may be useful to have something a bit more flexible than just core/classic. > @@ -1711,6 +1709,7 @@ struct wined3d_gl_limits > > struct wined3d_gl_info > { > + BOOL legacy_gl; > DWORD glsl_version; > struct wined3d_gl_limits limits; > DWORD reserved_glsl_constants, reserved_arb_constants; This could probably just be an entry in the wined3d_gl_extension enum, which I suppose might have advantages if we need this information for building e.g. state or format tables.

2 2

Re: [PATCH 1/8] kernel32: Implement GetVolumePathName.
by Nikolay Sivov June 19, 2015

June 19, 2015

> + const WCHAR fallbackpathW[] = { 'C',':','\\',0 }; This doesn't look right, could we make it dynamic using actual system drive? Same goes for tests, where you got hardcoded C:\ drive. According to docs this function should follow symlinks, will it potentially work with this implementation? Was it tested? I think it makes sense to submit tests first, maybe combining them a little, to have 1 tests patch instead of 4.

2 1

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois June 19, 2015

June 19, 2015

> First, yes, we do have hacks in CrossOver, but I think 'a lot' is > unfair. We really try to avoid those hacks, and we work hard to > eliminate them. For example, I reviewed our tracker that lists our > hacks. We have about 100 outstanding; in the last 6 months, we removed > 4 with upstream fixes, and added 1 new one. Further, we have long felt > that our diff with winehq was tragically large. But nicely, I can now > compare it to wine-staging, and claim that it is relatively modest > <grin>. We touch 28K lines in 228 files versus 100K lines in 509 files > for wine-staging [1]. May I suggest you eliminate those hacks by merging them into the Wine codebase? Right now I have a feeling that Wine is wonderful, but Codeweavers is evil. It seems that this feeling is shared by many non-Codeweavers Wine developers. Codeweavers has done a lot of work on Wine, which I really appreciate, but I wish they would be much more open. I think there should, at least, be a public database listing all the hacks that are in Crossover. That way, I would know what the heck was going on inside those windowless walls. This may sound unthinkable, but I would also suggest going further and releasing the source code for the hacks. Not the Crossover-only ones like sendwndcmd.exe. Or the ones that can't be released because of NDAs. I mean the ones that would improve the vanilla Wine distribution. It seems possible to me that you're not releasing these hacks because they would improve vanilla Wine to the point where nobody would be willing to pay for Crossover anymore. If that is true, it's the other reason that I think Codeweavers is evil. I mean, can't you make enough money on consulting for companies that think that Crossover/Codeweavers is better because it costs more money? If there's no openness about what Crossover is doing to Wine, I just can't trust them to develop it. ~Theodore

20 29

Re: gdi32/tests: Japanese Win 7 uses MS Shell Dlg as its default GUI font.
by Marvin June 19, 2015

June 19, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14490 Your paranoid android. === wvistau64 (32 bit font) === The test timed out === wvistau64 (64 bit font) === The test timed out

2 1

Re: [etags] repair make etags
by Alexandre Julliard June 18, 2015

June 18, 2015

marc.bessieres(a)mykolab.com writes: > @@ -68,7 +68,7 @@ TAGSFLAGS = --langmap='c:+.idl.l.rh,make:(Make*.in)' > > TAGS etags: > $(RM) TAGS > - (test -d .git && git ls-files || find -L $(top_srcdir) -name '*.[ch]' -print) | xargs etags -a $(TAGSFLAGS) > + (test -d .git && git ls-files '*.[chly]' '*.idl' || find -L $(top_srcdir) -name '*.[ch]' -print) | xargs etags -a This will make the results less useful. You could add different commands based on the available etags, though installing exuberant-ctags may be an easier fix... -- Alexandre Julliard julliard(a)winehq.org

2 1

d3drm patch feedback
by Stefan Dösinger June 18, 2015

June 18, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Here's the feedback for the patch you posted on IRC: > + GUID driver = IID_IDirect3DRGBDevice; Do you need this? Can't you just pass &IID_IDirect3DRGBDevice to CreateDeviceFromClipper? It may generate a const warning though. > + hr = DirectDrawCreateClipper(0, &clipper, NULL); > + ok(hr == DD_OK, "Cannot get IDirectDrawClipper interface (hr = %x).\n", hr); > + hr = IDirectDrawClipper_SetHWnd(clipper, 0, window); > + ok(hr == DD_OK, "Cannot set HWnd to Clipper (hr = %x).\n", hr); Can you pass a NULL clipper? If this crashes, just put a comment in the test. What if the clipper has no HWND and no clip list? Call GetClipper on the render target and see if the clipper is assigned. > + hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, 300, 200, &device2); For the sake of completeness pass 0 width and height. I expect one of the two results: Either it returns an error, or d3drm starts to use the window dimensions for the render target now. > + todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %d , ref2 = %d\n", ref1, ref2); Minor detail: Use %u for unsigned. > + ok((surface_desc.dwWidth == 300) && (surface_desc.dwHeight == 200), "Expected surface dimentions = 300, 200, got %d, %d.\n", > + surface_desc.dwWidth, surface_desc.dwHeight); > + ok((surface_desc.ddsCaps.dwCaps & (DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE)) == (DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE), > + "Expected caps containing %x, got %x.\n", DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE, surface_desc.ddsCaps.dwCaps); > + expected_flags = DDSD_PIXELFORMAT | DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT | DDSD_PITCH; > + ok(surface_desc.dwFlags == expected_flags, "Expected %x for flags, got %x.\n", expected_flags, surface_desc.dwFlags); Test the pixel format here. First query the current bpp with EnumDisplaySettings and check that the pixel format matches the screen properties. > + /* Check if ddraw supports change of display mode */ The comment is somewhat outdated. Either remove it or say something like "Test if the render target format follows the screen format". > + ok(surface_desc.ddpfPixelFormat.dwRGBBitCount == 16, "Expected 16bpp, got %dbpp.\n", > + surface_desc.ddpfPixelFormat.dwRGBBitCount); Similar to the %u -> %u above Once these are fixed the patch can go to wine-patches as far as I'm concerned. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVgt8QAAoJEN0/YqbEcdMwOTYP/jXwDY+gUs/zmAyqB5hJp8by FO0YSZsi0Z3QMMzfqenCy9+/PmqjMHyRPQvhM8CFpcdWsUi8bH6PzTiooAYOcvzf GXEnj46T1O0wiJfLK+RnzfvYNzITLWf2XK6ek1OtP1z6Y3JhADXwoLW/tSM+kKp7 Crih31t9ewiSMG5iebcSdviI59WrFtUHmS9Mdp5UnWVQB8smZII8c+VAOf/SmWZ1 cGKosFncJVNuXpF0fq5gWiy3m1VcJ1xoWsG1rXbrOzVFvpw+20twa1FgZm9Z6I3c Pxj2prH2Lz9u7tDZUr75dg3ucRPcUe2QP2bTwwBDDq4oaUZYKgXBLrz94AVZ/Y+j datcVFY7KwY2byGmxmO+0I+iWyj26CIg13jo20gqfRfjt92DFlfi5/Mm/e97rCa1 0V38s0kqN5o4rvU+QbUwHfvHIgr4kAFWZPjDmZd3YececQuoeC7FszND/43UD0tK MTd1Na3hFa5m6zO7oe4fPfGYX55tVhEzphiRkH4K0R0ZTxRsZGGqQoSFAHeAJDH6 0hPd3XjVHxSpHQNd8/8aFeOMJ8pBR+4MRUMcFBDn0XlDUYw0kUdvRkttKoNVCSGw H0BS00wj/fs/G4D/pCLEFEX7wF9qDM5O6xKQRoyXG3+i9oN+zdzCNMs6SV1J2Bci Jedz7Aw7+yAByiH/GePR =aa6D -----END PGP SIGNATURE-----

2 1

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois June 17, 2015

June 17, 2015

> While it seems Theodore didn't do his homework and didn't know about that source distribution, one of his point remains: > it's not a database, git, or something easily readable, just a blob Yes, I really hate that it’s a huge blob. I’m working on a little project to try and diff Crossover’s wine and wine 1.7.25, and identify all the hacks. The github repo is tbodt/crossover-wine, but I haven’t actually done any real work on it yet. Currently, it’s nothing but a fork of wine-mirror/wine. We’ll see when I get around to it. ~Theodore

1 0

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Theodore Dubois June 17, 2015

June 17, 2015

I originally sent this email to Jeremy, but forgot to CC the mailing list. ~Theodore On Jun 16, 2015, at 1:48 PM, Theodore Dubois <tblodt(a)icloud.com> wrote: >> I'm obviously very sad that you perceive us as evil. Do you mind me >> asking where you got that feeling from? If there is an information >> source that is revealing all of our evil secrets, I'd like to know about >> it. <grin> > > I thought you were evil because I didn't realize that all your hacks are actually already public. (And those <evil grin>s.) I'm sorry. > >> All of our Wine code, including our hacks, is publicly released, here: >> https://www.codeweavers.com/products/faq/source/ > > I had seen that source page, but I didn't realize it contained all the hacks. I thought it was just the main Wine source code. > >> Um, nearly all of the work that we do on CrossOver is done by sending >> public emails to this mailing list. How is that not open? Or perhaps I >> should ask - what gave you the impression that we did not develop openly? > > I thought that because you were evil, you must have some non-public mailing list. I guess I was wrong. > > Well, now I don't feel CodeWeavers is evil anymore. You are doing some awesome work on Wine. Without it, Wine would not have gotten to the point where it could run Crysis. > > ~Theodore

1 0

Re: [1/2] winhttp/tests: Fix a test failure on win2k.
by Marvin June 17, 2015

June 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14399 Your paranoid android. === w8 (32 bit winhttp) === winhttp.c:864: Test failed: failed to send request 2148074273 winhttp.c:868: Test failed: failed to retrieve certificate context 12019 winhttp.c:873: Test failed: failed to retrieve key bitness 4317 winhttp.c:877: Test failed: failed to retrieve certificate info 12019 winhttp.c:890: Test failed: failed to receive response 12019 winhttp.c:895: Test failed: failed unexpectedly 12019 winhttp.c:896: Test failed: request failed unexpectedly 3735928559 winhttp.c:907: Test failed: WinHttpReadData failed: 12019. winhttp.c:911: Test failed: read_size = 0

1 0

IDirect3DRM*::CreateDeviceFrom* tests
by Aaryaman Vasishta June 17, 2015

June 17, 2015

Testing if pixel format of the render target changes when the mode is changed: https://testbot.winehq.org/JobDetails.pl?Key=14395 <https://testbot.winehq.org/JobDetails.pl?Key=14356> All the three tests together: https://testbot.winehq.org/JobDetails.pl?Key=14403 Please review the code and let me know of any modifications that are required. Thank you! Jam

1 1

Re: [2/2] Add stub dll d3dcompiler_47 (try 2)
by Matteo Bruni June 17, 2015

June 17, 2015

2015-06-17 8:01 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > Removed LPVOID > > Changelog: > Add stub dll d3dcompiler_47 > > > Best Regards > Alistair Leslie-Hughes Both patches look good to me. Thanks Alistair!

1 0

Re: [PATCH 2/8] wined3d: Avoid potential division by 0 when computing fog scale.
by Henri Verbeet June 17, 2015

June 17, 2015

On 16 June 2015 at 22:45, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > get_fog_start_end(context, state, &start, &end); > - scale = 1.0f / (end - start); > + scale = end == start ? INFINITY : 1.0f / (end - start); Do we really need this? It almost feels nicer to just pass "end - start" to the shader and handle the division there, or perhaps even just pass "start".

3 3

[PATCH 1/2] secur32: Added support for a few more algorithms in schannel_get_cipher_algid.
by Hugh McMaster June 17, 2015

June 17, 2015

On Tue, 16 Jun 2015 13:46:32 +0200, Jacek Caban wrote: >- case GNUTLS_CIPHER_AES_256_CBC: return CALG_AES; >+ case GNUTLS_CIPHER_AES_128_GCM: return CALG_AES_128; >+ case GNUTLS_CIPHER_AES_192_CBC: return CALG_AES_192; >+ case GNUTLS_CIPHER_AES_256_GCM: >+ case GNUTLS_CIPHER_AES_256_CBC: return CALG_AES_256; Those changes are causing fatal build errors in Wine: schannel_gnutls.c: In function ‘schannel_get_cipher_algid’: schannel_gnutls.c:272:10: error: ‘GNUTLS_CIPHER_AES_128_GCM’ undeclared (first use in this function) case GNUTLS_CIPHER_AES_128_GCM: return CALG_AES_128; ^ schannel_gnutls.c:272:10: note: each undeclared identifier is reported only once for each function it appears in schannel_gnutls.c:274:10: error: ‘GNUTLS_CIPHER_AES_256_GCM’ undeclared (first use in this function) case GNUTLS_CIPHER_AES_256_GCM: ^ make[1]: *** [schannel_gnutls.o] Error 1 make[1]: Leaving directory `/home/hugh/wine-test/dlls/secur32' make: *** [dlls/secur32] Error 2 -- Hugh McMaster

3 5

Re: [PATCH 3/8] wined3d: Cleanup and simplify texture sampling code generation.
by Henri Verbeet June 17, 2015

June 17, 2015

On 16 June 2015 at 22:45, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > switch (resource_type) > { > case WINED3D_SHADER_RESOURCE_TEXTURE_1D: ... > + type_part = "1D"; > break; There's nothing necessarily wrong with this, but it also seems that aside from the "texrect" handling you could just use the same lookup table you're using for the coordinate mask size.

1 0

Re: [PATCH] riched20: Fix link notification conditions and add tests.
by Alexandre Julliard June 17, 2015

June 17, 2015

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -4121,6 +4121,10 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, > return 0; > case WM_SETCURSOR: > { > + POINT cursor_pos; > + if (wParam == (WPARAM)editor->hWnd && GetCursorPos(&cursor_pos) && > + ScreenToClient(editor->hWnd, &cursor_pos)) > + ME_LinkNotify(editor, msg, 0, MAKELPARAM(cursor_pos.x, cursor_pos.y)); Getting the current cursor position doesn't look right, it should be the message position. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [2/3] ntdll: Alter security cookie on WIN64 (try 2)
by Alexandre Julliard June 17, 2015

June 17, 2015

André Hentschel <nerv(a)dawncrow.de> writes: > This time ARM64-only > I had trouble with that patch for x86_64 when testing EmEditor... > Still it is the only way to get an app on arm64 to start... There shouldn't be any reason to make this platform-specific, or 64-bit specific for that matter. And a hardcoded cookie is not exactly secure... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/3] riched20/tests: Some more EM_SETSEL tests
by Marvin June 17, 2015

June 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14363 Your paranoid android. === w2008s64 (64 bit editor) === editor.c:5939: Test failed: wrong event mask (0x0) during WM_COMMAND

2 1

Re: [1/2] Add stub dll d3dcompiler_46
by Matteo Bruni June 17, 2015

June 17, 2015

2015-06-16 11:14 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi, > > > Changelog: > Add stub dll d3dcompiler_46 > > > Best Regards > Alistair Leslie-Hughes These two patches look fine to me except for the LPJUNK + hungarian notation in DllMain(). BTW where did you find that version number for d3dcompiler_46? Windows 8 SDK? Just curious, I found two different version of d3dcompiler_46.dll bundled with various stuff which have different version numbers (even between them).

2 1

Re: [PATCH 1/4] msvcr120: Add ___lc_locale_name_func implementation
by Marvin June 16, 2015

June 16, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14355 Your paranoid android. === w2008s64 (32 bit msvcr120) === msvcr120.c:209: Test failed: 0 - lc_names[1] = L"en-US" msvcr120.c:206: Test failed: 2 - lc_names[1] = L"zh-CN" msvcr120.c:209: Test failed: 3 - lc_names[1] = L"nl-NL" msvcr120.c:209: Test failed: 4 - lc_names[1] = L"en-US" msvcr120.c:209: Test failed: 5 - lc_names[1] = L"fr-FR" msvcr120.c:209: Test failed: 6 - lc_names[1] = L"de-DE" msvcr120.c:209: Test failed: 7 - lc_names[1] = L"hu-HU" msvcr120.c:209: Test failed: 8 - lc_names[1] = L"is-IS" msvcr120.c:209: Test failed: 9 - lc_names[1] = L"ja-JP" msvcr120.c:209: Test failed: 10 - lc_names[1] = L"ko-KR" msvcr120.c:209: Test failed: 11 - lc_names[1] = L"es-MX" === w2008s64 (64 bit msvcr120) === msvcr120.c:209: Test failed: 0 - lc_names[1] = L"en-US" msvcr120.c:206: Test failed: 2 - lc_names[1] = L"zh-CN" msvcr120.c:209: Test failed: 3 - lc_names[1] = L"nl-NL" msvcr120.c:209: Test failed: 4 - lc_names[1] = L"en-US" msvcr120.c:209: Test failed: 5 - lc_names[1] = L"fr-FR" msvcr120.c:209: Test failed: 6 - lc_names[1] = L"de-DE" msvcr120.c:209: Test failed: 7 - lc_names[1] = L"hu-HU" msvcr120.c:209: Test failed: 8 - lc_names[1] = L"is-IS" msvcr120.c:209: Test failed: 9 - lc_names[1] = L"ja-JP" msvcr120.c:209: Test failed: 10 - lc_names[1] = L"ko-KR" msvcr120.c:209: Test failed: 11 - lc_names[1] = L"es-MX"

1 0

Re: Wine developer frustration (was Re: ntdll: Improve stub of NtQueryEaFile.)
by Jeremy White June 16, 2015

June 16, 2015

Hi all, On 06/15/2015 02:32 PM, Michael Müller wrote: > Hi Jeremy, > > I actually intended to send the following response to wine-devel, but > the other Wine Staging developers feared that this might continue the > flamewar. Nevertheless, I think the ideas should still reach you, just > treat them as my personal opinion. In case you are comfortable with the > content, feel free to forward or respond to it on wine-devel. I thought these were all interesting points, and wanted to respond publicly. > > I think it is too easy to blame Alexandre for all Wine problems. He is > involved in some of them, but there are also other ways to improve Wine > which are completely unrelated to him. I think even CodeWeavers could > make Wine more community-friendly simply by being more transparent. > > Here are two examples of what I mean: > > 1. CodeWeavers adds a lot of hacks to Crossover to get applications to > work, in case a proper fix would be too much work. From what I have > heard those hacks are only added after the problem has been analyzed and > documented in your bug tracker. I don't understand though why no one in > the Wine community access to this analysis (i.e. why are these bugs not > documented in the public bug tracker)? It seems to be a waste of energy > if the Wine community needs to debug the problem a second time. I think that breaks down into two issues. First, yes, we do have hacks in CrossOver, but I think 'a lot' is unfair. We really try to avoid those hacks, and we work hard to eliminate them. For example, I reviewed our tracker that lists our hacks. We have about 100 outstanding; in the last 6 months, we removed 4 with upstream fixes, and added 1 new one. Further, we have long felt that our diff with winehq was tragically large. But nicely, I can now compare it to wine-staging, and claim that it is relatively modest <grin>. We touch 28K lines in 228 files versus 100K lines in 509 files for wine-staging [1]. Second, for bugs, yes, we do have our own bug tracker, and it is (mostly) private. That's appropriate for CrossOver only bugs, and we do have a lot of customers with whom we have confidentiality agreements, so it's necessary in that case. We do have an official company policy that any Wine related bug in our tracker is supposed to have a related WineHQ bug, and we are supposed to bias our troubleshooting and work in favor of WineHQ. That is true for all bugs, including ones that are hacks. In doing a spot check of that, it looks like we don't do that great a job of adhering to that policy; maybe 30% of the time (although we do have a number of staff members who are particularly good at mostly using WineHQ). I have to agree that this is arguably less than ideal, and I will exhort our staff to do better. But my gut sense is that the perception may be that we have this magical treasure trove of extra information, and the reality is fairly far from that. > > 2. CodeWeavers seems to act like a black box from my point of view. It > is not really clear what you guys are working on and therefore a lot of > Wine developers (who are not part of CW) try to avoid touching the same > areas of Wine. As far as I know CW is currently working on Office 2013 > for example, but there is not a single bug in the WineHQ bug tracker > about this. On the other hand I talked with some CW developers on the > IRC and I had the impression that they wouldn't mind help from the > community to fix certain issues. We all profit from having those bugs > fixed faster. Ouch. I'm not sure how to respond to that. I think we've been accused of being a bit opaque in the past, and I think I've promised to try to do better. Looks like I failed. We do tend to get a lot of NDAs and things that make us careful with information, but we also just have a lot of the strong silent types on staff. But the very last thing I want to do is suppress any work on Wine. My thinking, though, has long been the opposite of yours. That if we advertise an area of work, we risk a 'chilling' effect. There are far more bugs with 'Office' than we could ever handle by ourselves; I would never want someone to stay away from a bug that looked interesting or fun, just because we tend to do a lot of the work on Office. I always thought the perk of being a non CW Wine hacker is that you get to pick and choose the fun parts. I get to make the CW hackers do the yucky, nasty, stuff... <evil grin>. Further, we really do just about all of our work on wine-devel; you can tell what we're working on just by seeing the patches there. For the record, we are working on Office 2013, which is right now mired in a lot of work on dwrite, I believe. If you look at Henri and Nikolay's recent patches, you'll see the work on it. We have lovely purple blobs in Excel instead of readable text (although I'm told I can have those blobs in any color I like). Beyond that, our work is all over the map. I guess the action item here remains the same - for us to do a better job of communicating, so we no longer seem mysterious or opaque. I'll work on that. > > Alexandre needs to find a way how to improve the patch acceptance > process in a way he feels comfortable with, but before everyone starts > blaming him for all problems, there are also other areas which can be > improved. Don't get me wrong, I don't want to say that CW is root of all > evil (I think its very great that you guys keep Wine alive), I just > thought you might be interested in these ideas, especially because these > are things where you have influence on. Yes, thank you - this is very helpful. I think there is clearly a problem, a problem that has gotten worse lately, and it would be great if we can find a way to improve matters. Again, there is far more than enough work to do; to lose any energy to misunderstanding or inter personal friction is just stupid and inefficient. One issue you didn't raise that I want to elevate as a straw man, and then knock down, is the perception that an @codeweavers.com email address is some sort of guarantee of patch acceptance. Trust me, I am painfully aware that it doesn't help :-/. It is true that I tend to hire people that Alexandre trusts (which makes sense, if you think about it), but that's a different way of coloring the situation. And I can tell you that Alexandre is a man of deep integrity, and he is both personally committed to keeping his work on Wine separate from his work for CodeWeavers, and CodeWeavers is contractually bound to allow that. > > Not directly related to the previous mail, but I think its not > sufficient to hope that WineConf will automatically solve all problems. > The WineConf might be a good place to discuss individual ideas, but we > may want to start collecting them in advance. Agreed; hence my desire to make sure to get this down in the email archives as well, and my hope that we can articulate the concerns and possible improvements now as well. But there is something really powerful about meeting face to face that is very nice. It's particularly nice when you can go to the bar to curse Alexandre over beers later <grin>. Cheers, Jeremy [1] This was my methodology, which may be flawed: wine-staging git, removing outsized fonts-Missing_Fonts patch: [~/xfer/wine-staging/patches] grep -h '^diff' */00*.patch | sort | uniq | wc -l 509 [~/xfer/wine-staging/patches] cat */00*.patch | wc -l 107666 CrossOver stats: [~/w/crossover/wine] git diff wine-1.7.45 | grep -h '^diff' | wc -l 228 [~/w/crossover/wine] git diff wine-1.7.45 | wc -l 28388

1 0

Re: ntdll: Improve stub of NtQueryEaFile.
by Alexandre Julliard June 16, 2015

June 16, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Based on a patch by Qian Hong. I don't remember seeing any such patch. Qian is around, so I expect he should be able to submit his own work himself. Then you can submit your part as your own separate patch. It's not a big deal for a small patch like this, but I don't want you to get into the habit of submitting patches containing bits and pieces of other people's work. I expect developers to stand behind their work, and take responsibility for getting their patches committed. Helping them is good, but taking over their work isn't. -- Alexandre Julliard julliard(a)winehq.org

15 26

Re: scrrun: Implement ITextStream Close
by Marvin June 16, 2015

June 16, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14331 Your paranoid android. === w2000pro (32 bit filesystem) === filesystem.c:1385: Test failed: got 0x800a005b === w2003std (32 bit filesystem) === filesystem.c:1385: Test failed: got 0x800a005b

1 0

Re: [1/2] ntdll: Set platform register x18 to TEB on ARM64 (resend)
by Alexandre Julliard June 16, 2015

June 16, 2015

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -788,6 +788,17 @@ void signal_free_thread( TEB *teb ) > > > /********************************************************************** > + * set_x18 > + * > + * Win64/ARM applications expect the TEB pointer to be in the x18 platform register. > + */ > +extern void set_x18( TEB *teb ); > +__ASM_GLOBAL_FUNC( set_x18, > + "mov x18, x0\n\t" /* TEB -> platform register */ > + "ret" ) You don't really need a global function for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

odbccp32: Implement SQLGetPrivateProfileString (try 5)
by Hugh McMaster June 16, 2015

June 16, 2015

On Sun, 14 Jun 2015 14:58:36 +1000, Alistair Leslie-Hughes wrote: > >+ ret = SQLGetPrivateProfileStringW(sect, entry, string, retval, cbRetBuffer, file); >+ if(ret) >+ { >+ WideCharToMultiByte(CP_ACP, 0, retval, -1, RetBuffer, cbRetBuffer, NULL, NULL); >+ RetBuffer[ret] = 0; >+ } If retval is null terminated, you do not need RetBuffer[ret] = 0;. The -1 in WideCharToMultiByte means the function calculates the length of the input string, including any null terminating character. If the input string is null terminated, the output string is also null terminated. So, if this is the case, you are actually null-terminating twice and, depending on the size of cbRetBuffer, the second null termination may be out of bounds. If retval isn't null terminated, you should use the return value of WideCharToMultiByte (the number of bytes written to RetBuffer) instead of 'ret'.

1 0

Re: scrrun: Implement ITextStream Close
by Nikolay Sivov June 16, 2015

June 16, 2015

> struct textstream *This = impl_from_ITextStream(iface); > - FIXME("(%p): stub\n", This); > - return E_NOTIMPL; > + HRESULT hr = S_OK; > + > + TRACE("(%p)\n", This); > + > + if(!CloseHandle(This->file)) > + hr = S_FALSE; > + > + This->file = NULL; > + > + return hr; This could be right way to do it, but it would be interesting to see what happens to other methods behavior when called on closed stream, like Read() for example.

2 1

Re: odbccp32: Implement SQLGetPrivateProfileString (try 5)
by Nikolay Sivov June 16, 2015

June 16, 2015

> + sect = heap_strdupAtoW(lpszSection); > + entry = heap_strdupAtoW(lpszEntry); > + string = heap_strdupAtoW(lpszDefault); > + file = heap_strdupAtoW(lpszFilename); > + retval = heap_alloc(cbRetBuffer*sizeof(WCHAR)); > + > + ret = SQLGetPrivateProfileStringW(sect, entry, string, retval, cbRetBuffer, file); > + if(ret) > + { > + WideCharToMultiByte(CP_ACP, 0, retval, -1, RetBuffer, cbRetBuffer, NULL, NULL); > + RetBuffer[ret] = 0; > + } > + > + heap_free(sect); > + heap_free(entry); > + heap_free(string); > + heap_free(file); > + > + heap_free(retval); Structurally it's fine, but you're using WCHAR count as CP_ACP char count, and it's wrong assumption in general.

1 0

Re: [1/3] winhttp: Improve parsing of cookie values.
by Marvin June 16, 2015

June 16, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14301 Your paranoid android. === w2000pro (32 bit winhttp) === winhttp.c:945: Test failed: failed to receive response 12152 winhttp.c:950: Test failed: failed unexpectedly 12019 winhttp.c:951: Test failed: request failed unexpectedly 3735928559

2 1

Re: [2/3] msvcirt: Add implementation of streambuf::sputc
by Piotr Caban June 16, 2015

June 16, 2015

On 06/15/15 17:34, Iván Matellanes wrote: > + test_overflow_this = &sb2; > + ret = (int) call_func2(p_streambuf_sputc, &sb3, 'c'); You probably wanted to set the test_overflow_this to sb3 here. Thanks, Piotr

1 0

Re: [PATCH 1/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromClipper (try 2).
by Stefan Dösinger June 15, 2015

June 15, 2015

Hi, > + hr = DirectDrawCreateClipper(0, &clipper, NULL); > + ref = get_refcount((IUnknown *)clipper); You're not reading ref anywhere as far as I can see. Did you forget to re-check the refcount after creating the device? If the refcount is incremented by 2 or more: See if the clipper is assigned to the render target and / or depth stencil. This wouldn't really do anything, but it's Microsoft we're talking about here. > + hr = IDirect3DRM_QueryInterface(d3drm1, &IID_IDirect3DRM2, (void **)&d3drm2); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM3 interface (hr = %x).\n", hr); Minor mistake: IDirect3DRM2 vs IDirect3DRM3. > + memcpy(&driver, &IID_IDirect3DRGBDevice, sizeof(GUID)); I think an assignment should do the job. > + hr = IDirect3DRM2_CreateDeviceFromClipper(d3drm2, clipper, &driver, rc.right, rc.bottom, &device2); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMDevice2 interface (hr = %x).\n", hr); I'd say "Cannot create IDirect3DRMDevice2 (hr = ...)" here. You're not retrieving an interface here. > + /* Fetch immediate mode device in order to access render target */ > + hr = IDirect3DRMDevice2_GetDirect3DDevice2(device2, &d3ddevice2); > + todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice2 interface (hr = %x).\n", hr); > + if (FAILED(hr)) > + { > + IDirect3DRMDevice2_Release(device2); > + IDirect3DRM2_Release(d3drm2); > + IDirect3DRM_Release(d3drm1); > + IDirectDrawClipper_Release(clipper); > + return; > + } You can use the cleanup label here too if you initialize the interface pointers to NULL and add checks for NULL before calling release. > + /* Check properties of primary and depth surfaces */ > + desc.dwSize = sizeof(desc); > + hr = IDirectDrawSurface_GetSurfaceDesc(surface, &desc); > + ok(hr == DD_OK, "Cannot get surface desc structure (hr = %x).\n", hr); > + if (FAILED(hr)) > + goto cleanup; Minor nitpick: A "primary" surface represents the screen content. The correct term in in this case is "render target". Note that a primary surface can be a render target in fullscreen mode. > + ok((desc.dwWidth == rc.right) && (desc.dwHeight == rc.bottom), "Expected surface dimentions = %d, %d, got %d, %d.\n", > + rc.right, rc.bottom, desc.dwWidth, desc.dwHeight); > + expected_caps = DDSCAPS_OFFSCREENPLAIN | DDSCAPS_3DDEVICE | DDSCAPS_SYSTEMMEMORY; > + todo_wine ok(desc.ddsCaps.dwCaps == expected_caps, "Expected %x for caps, got %x.\n", expected_caps, desc.ddsCaps.dwCaps); As discussed on IRC ignore DDSCAPS_SYSTEMMEMORY here. I think it happens because you use a RGB device, and I don't think it's something we should care about unless an application depends on this. Check dwRGBBitCount of the render target. It should match the bit depth of the screen mode. > + if (FAILED(hr = IDirectDraw_SetDisplayMode(ddraw, desc.dwWidth, desc.dwHeight, 8))) > + { > + win_skip("Cannot set display mode to 8bpp (hr = %x), skipping tests.\n", hr); > + IDirectDrawSurface7_Release(surface7); > + IDirectDrawSurface_Release(ds); > + IDirectDrawSurface_Release(surface); > + IUnknown_Release(unknown); > + IDirectDraw_Release(ddraw); > + goto cleanup; > + } There's no need to try to set the display mode to 8. Also testing if changing the mode works is outside the scope of this test. What's interesting is that the pixel format of the primary surface of a new device after changing the mode. Please also check the Z bit depth, and if the surface has stencil bits.

2 2

Re: [PATCH 2/5] wined3d: Implement SM4 discard in the GLSL shader backend.
by Matteo Bruni June 15, 2015

June 15, 2015

2015-06-15 14:07 GMT+02:00 Henri Verbeet <hverbeet(a)codeweavers.com>: > --- > dlls/wined3d/glsl_shader.c | 35 +++++++++++++++++++++-------------- > 1 file changed, 21 insertions(+), 14 deletions(-) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 5ba246e..eb98ffe 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -4704,22 +4704,29 @@ static void shader_glsl_texreg2rgb(const struct wined3d_shader_instruction *ins) > * If any of the first 3 components are < 0, discard this pixel */ > static void shader_glsl_texkill(const struct wined3d_shader_instruction *ins) > { > - struct glsl_dst_param dst_param; > + if (ins->ctx->reg_maps->shader_version.major >= 4) > + { > + struct glsl_src_param src_param; > > - /* The argument is a destination parameter, and no writemasks are allowed */ > - shader_glsl_add_dst_param(ins, &ins->dst[0], &dst_param); > - if (ins->ctx->reg_maps->shader_version.major >= 2) > + shader_glsl_add_src_param(ins, &ins->src[0], WINED3DSP_WRITEMASK_0, &src_param); > + shader_addline(ins->ctx->buffer, "if (bool(floatBitsToUint(%s))) discard;\n", src_param.param_str); > + } > + else > { > - if (ins->ctx->reg_maps->shader_version.major >= 4) > - FIXME("SM4 discard not implemented.\n"); > - /* 2.0 shaders compare all 4 components in texkill */ > - shader_addline(ins->ctx->buffer, "if (any(lessThan(%s.xyzw, vec4(0.0)))) discard;\n", dst_param.reg_name); > - } else { > - /* 1.X shaders only compare the first 3 components, probably due to the nature of the texkill > - * instruction as a tex* instruction, and phase, which kills all a / w components. Even if all > - * 4 components are defined, only the first 3 are used > - */ > - shader_addline(ins->ctx->buffer, "if (any(lessThan(%s.xyz, vec3(0.0)))) discard;\n", dst_param.reg_name); > + struct glsl_dst_param dst_param; > + > + /* The argument is a destination parameter, and no writemasks are allowed */ > + shader_glsl_add_dst_param(ins, &ins->dst[0], &dst_param); > + > + /* 2.0 shaders compare all 4 components in texkill. */ > + if (ins->ctx->reg_maps->shader_version.major >= 2) > + shader_addline(ins->ctx->buffer, "if (any(lessThan(%s.xyzw, vec4(0.0)))) discard;\n", dst_param.reg_name); > + /* 1.x shaders only compare the first 3 components, probably due to > + * the nature of the texkill instruction as a tex* instruction, and > + * phase, which kills all .w components. Even if all 4 components are > + * defined, only the first 3 are used. */ > + else > + shader_addline(ins->ctx->buffer, "if (any(lessThan(%s.xyz, vec3(0.0)))) discard;\n", dst_param.reg_name); > } > } > > -- > 2.1.4 FWIW, https://msdn.microsoft.com/en-us/library/windows/desktop/hh446968%28v=vs.85… mentions two variants of the discard instruction. Any clue how is that _z vs _nz part encoded?

2 1

DInput axis mapping explanation
by Michael Gardner June 15, 2015

June 15, 2015

Please forgive me if this is the wrong list or a stupid question, but I already tried wine-users and the WineHQ forums and no one could answer. I'm trying to understand Wine's DirectInput axis mapping feature (registry key HKEY_CURRENT_USER\Software\Wine\DirectInput). The documentation at http://wiki.winehq.org/UsefulRegistryKeys gives some details but seems to assume you already know how the feature works. (You could also consider this an RFE for better DInput axis mapping docs, which I'd be happy to write if I can first understand the feature.) I understand that I can make a registry key with the same name as my joystick device and a value that's a comma-separated list of axes, which will act as some kind of mapping. But how does this mapping work? What is being mapped to what, exactly? The docs give an example mapping without explaining what it does, or how you'd arrive at that mapping given whatever result you're looking for. I've also read https://forum.winehq.org/viewtopic.php?t=14899, but it also doesn't explain how these mappings work in the abstract. Once again, my apologies if this is the wrong place, but if there's anyone who might have the knowledge I'm looking for then it would be the Wine devs.

2 1

Re: [PATCH] winscard: add stubs for SCardListReadersA/W (try 2)
by Matteo Bruni June 15, 2015

June 15, 2015

2015-06-15 9:31 GMT+02:00 Marcus Meissner <marcus(a)jet.franken.de>: > From: Austin English <austinenglish(a)gmail.com> > > Fixes http://bugs.winehq.org/show_bug.cgi?id=26978 > > replaced return code after suggestion by Bruno Jesus. > --- > dlls/winscard/winscard.c | 12 ++++++++++++ > dlls/winscard/winscard.spec | 4 ++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c > index bcf8129..70b3914 100644 > --- a/dlls/winscard/winscard.c > +++ b/dlls/winscard/winscard.c > @@ -129,3 +129,15 @@ void WINAPI SCardReleaseStartedEvent(void) > { > FIXME("stub\n"); > } > + > +LONG WINAPI SCardListReadersA(SCARDCONTEXT context, LPCSTR groups, LPSTR readers, LPDWORD buflen) Not sure it matters much here but I'd stick to avoiding LP* types, as by usual Wine style.

1 0

Re: riched: Added ITextDocument2 definition and corresponding tests
by Alexandre Julliard June 15, 2015

June 15, 2015

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > From 5583828198dff5f5e19606ba11f1cf961f78f7c5 Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <nsivov(a)codeweavers.com> > Date: Tue, 2 Jun 2015 01:32:52 +0300 > Subject: [PATCH] riched: Added ITextDocument2 definition and corresponding > tests It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M riched20.dll -p riched20_test.exe.so richole && touch richole.ok fixme:ole:RemUnknown_QueryInterface No interface for iid {00000019-0000-0000-c000-000000000046} fixme:richedit:IRichEditOleImpl_inner_fnQueryInterface 0x3334e0: unhandled interface {01c25500-4268-11d1-883a-3c8b00c10000} richole.c:150: Test failed: got 0x80004002 wine: Unhandled page fault on read access to 0x00000000 at address 0x7ed4b59e (thread 0009), starting debugger... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: Use random names when caching very long urls.
by Piotr Caban June 15, 2015

June 15, 2015

Hi, this will not work for filenames a little shorter than MAX_PATH. Whole file path needs to fit into MAX_PATH characters (not only the file name). Thanks, Piotr

1 0

Re: [PATCH 2/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface (try 2).
by Stefan Dösinger June 15, 2015

June 15, 2015

> Am 11.06.2015 um 13:51 schrieb Aaryaman Vasishta <jem456.vasishta(a)gmail.com>: > > + hr = IDirect3DDevice2_GetRenderTarget(d3ddevice2, &surface); > + ok(hr == DD_OK, "Cannot get surface to the render target (hr = %x)\n", hr); > + if (FAILED(hr)) > + goto cleanup; > + > + /* Check properties of primary and depth surfaces */ > + memset(&desc, 0, sizeof(desc)); > + desc.dwSize = sizeof(desc); > + hr = IDirectDrawSurface_GetSurfaceDesc(surface, &desc); > + ok(hr == DD_OK, "Cannot get surface desc structure (hr = %x)\n", hr); > + if (FAILED(hr)) > + goto cleanup; Checking the surface desc isn't really relevant here. The interesting check is if the render target returned by GetRenderTarget is the surface you passed to CreateDeviceFromSurface. Please add a test that shows that an error is returned if the surface was created without 3DDEVICE. > > + hr = IDirectDrawSurface_GetAttachedSurface(surface, &caps, &ds); > + ok(hr == DD_OK, "Cannot get attached depth surface (hr = %x)\n", hr); > + if (FAILED(hr)) > + goto cleanup; What happens if you attach a depth surface yourself before calling CreateDeviceFromSurface? Does d3drm replace it? > + hr = IDirectDrawSurface_QueryInterface(surface, &IID_IDirectDrawSurface7, (void**)&surface7); > + ok(hr == DD_OK, "Cannot get IDirectDrawSurface7 interface (hr = %x)\n", hr); > + > + IDirectDrawSurface_Release(ds); > + IDirectDrawSurface_Release(surface); > + IDirectDrawSurface7_Release(surface7); The QueryInterface call here is redundant.

3 3