August 2015 - Wine-Devel - list.winehq.org

Re: WS2_32: WSACleanup implementation, server-side, plus remove todos around passing tests. This also fixes bug 32910
by Marvin Aug. 29, 2015

Aug. 29, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16405 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

3 2

Re: [PATCH 1/4] xaudio2: Implement device activation
by Andrew Eikum Aug. 29, 2015

Aug. 29, 2015

Please don't merge these patches. I got some feedback on IRC and will be sending improved versions. Andrew On Mon, Aug 24, 2015 at 10:31:36AM -0500, Andrew Eikum wrote: > This adds a build-time dependency on openal, and a run-time dependency > on openal-soft's ALC_SOFT_loopback extension. > > --- > configure.ac | 3 +- > dlls/xaudio2_7/Makefile.in | 1 + > dlls/xaudio2_7/xaudio_dll.c | 274 +++++++++++++++++++++++++++++++++++++++++++- > 3 files changed, 274 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 004e79d..dea394f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1738,8 +1738,9 @@ then > AC_DEFINE_UNQUOTED(HAVE_OPENAL,1,[Define to 1 if OpenAL is available])],,) > fi > WINE_NOTICE_WITH(openal,[test "x$ac_cv_lib_openal" != xyes], > - [libopenal ${notice_platform}development files not found (or too old), OpenAL won't be supported.]) > + [libopenal ${notice_platform}development files not found (or too old), OpenAL and XAudio2 won't be supported]) > test "x$ac_cv_lib_openal" = xyes || enable_openal32=${enable_openal32:-no} > +test "x$ac_cv_lib_openal" = xyes || enable_xaudio2_7=${enable_xaudio2_7:-no} > > dnl **** Check for libkstat **** > if test "$ac_cv_header_kstat_h" = "yes" > diff --git a/dlls/xaudio2_7/Makefile.in b/dlls/xaudio2_7/Makefile.in > index 6bdf362..5a09c82 100644 > --- a/dlls/xaudio2_7/Makefile.in > +++ b/dlls/xaudio2_7/Makefile.in > @@ -1,5 +1,6 @@ > MODULE = xaudio2_7.dll > IMPORTS = advapi32 kernel32 ole32 user32 uuid > +EXTRALIBS = $(OPENAL_LIBS) > > C_SRCS = \ > xaudio_dll.c > diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c > index 6bb48e6..95740fa 100644 > --- a/dlls/xaudio2_7/xaudio_dll.c > +++ b/dlls/xaudio2_7/xaudio_dll.c > @@ -41,8 +41,14 @@ > #include "mmdeviceapi.h" > #include "audioclient.h" > > +#include <AL/al.h> > +#include <AL/alc.h> > +#include <AL/alext.h> > + > WINE_DEFAULT_DEBUG_CHANNEL(xaudio2); > > +static ALCdevice *(ALC_APIENTRY *palcLoopbackOpenDeviceSOFT)(const ALCchar*); > + > static HINSTANCE instance; > > static void dump_fmt(const WAVEFORMATEX *fmt) > @@ -86,6 +92,13 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD reason, void *pReserved) > case DLL_PROCESS_ATTACH: > instance = hinstDLL; > DisableThreadLibraryCalls( hinstDLL ); > + > + if(!alcIsExtensionPresent(NULL, "ALC_SOFT_loopback") || > + !(palcLoopbackOpenDeviceSOFT = alGetProcAddress("alcLoopbackOpenDeviceSOFT"))){ > + ERR("XAudio2 requires the ALC_SOFT_loopback extension (OpenAL-Soft >= 1.14)\n"); > + return FALSE; > + } > + > break; > } > return TRUE; > @@ -173,6 +186,14 @@ struct _IXAudio2Impl { > > WCHAR **devids; > UINT32 ndevs; > + > + IAudioClient *aclient; > + IAudioRenderClient *render; > + > + WAVEFORMATEXTENSIBLE fmt; > + > + ALCdevice *al_device; > + ALCcontext *al_ctx; > }; > > static inline IXAudio2Impl *impl_from_IXAudio2(IXAudio2 *iface) > @@ -190,6 +211,32 @@ IXAudio2Impl *impl_from_IXAudio2MasteringVoice(IXAudio2MasteringVoice *iface) > return CONTAINING_RECORD(iface, IXAudio2Impl, IXAudio2MasteringVoice_iface); > } > > +static DWORD get_channel_mask(unsigned int channels) > +{ > + switch(channels){ > + case 0: > + return 0; > + case 1: > + return KSAUDIO_SPEAKER_MONO; > + case 2: > + return KSAUDIO_SPEAKER_STEREO; > + case 3: > + return KSAUDIO_SPEAKER_STEREO | SPEAKER_LOW_FREQUENCY; > + case 4: > + return KSAUDIO_SPEAKER_QUAD; /* not _SURROUND */ > + case 5: > + return KSAUDIO_SPEAKER_QUAD | SPEAKER_LOW_FREQUENCY; > + case 6: > + return KSAUDIO_SPEAKER_5POINT1; /* not 5POINT1_SURROUND */ > + case 7: > + return KSAUDIO_SPEAKER_5POINT1 | SPEAKER_BACK_CENTER; > + case 8: > + return KSAUDIO_SPEAKER_7POINT1_SURROUND; /* Vista deprecates 7POINT1 */ > + } > + FIXME("Unknown speaker configuration: %u\n", channels); > + return 0; > +} > + > static void WINAPI XA2SRC_GetVoiceDetails(IXAudio2SourceVoice *iface, > XAUDIO2_VOICE_DETAILS *pVoiceDetails) > { > @@ -891,7 +938,29 @@ static void WINAPI XA2M_GetOutputMatrix(IXAudio2MasteringVoice *iface, > static void WINAPI XA2M_DestroyVoice(IXAudio2MasteringVoice *iface) > { > IXAudio2Impl *This = impl_from_IXAudio2MasteringVoice(iface); > + > TRACE("%p\n", This); > + > + EnterCriticalSection(&This->lock); > + > + if(!This->aclient){ > + LeaveCriticalSection(&This->lock); > + return; > + } > + > + IAudioRenderClient_Release(This->render); > + This->render = NULL; > + > + IAudioClient_Release(This->aclient); > + This->aclient = NULL; > + > + alcCloseDevice(This->al_device); > + This->al_device = NULL; > + > + alcDestroyContext(This->al_ctx); > + This->al_ctx = NULL; > + > + LeaveCriticalSection(&This->lock); > } > > /* not present in XAudio2 2.7 */ > @@ -1164,6 +1233,8 @@ static ULONG WINAPI IXAudio2Impl_Release(IXAudio2 *iface) > HeapFree(GetProcessHeap(), 0, sub); > } > > + IXAudio2MasteringVoice_DestroyVoice(&This->IXAudio2MasteringVoice_iface); > + > if(This->devenum) > IMMDeviceEnumerator_Release(This->devenum); > for(i = 0; i < This->ndevs; ++i) > @@ -1322,6 +1393,28 @@ static HRESULT WINAPI IXAudio2Impl_CreateSubmixVoice(IXAudio2 *iface, > return S_OK; > } > > +static ALenum al_get_loopback_format(const WAVEFORMATEXTENSIBLE *fmt) > +{ > + if(fmt->Format.wFormatTag == WAVE_FORMAT_PCM || > + (fmt->Format.wFormatTag == WAVE_FORMAT_EXTENSIBLE && > + IsEqualGUID(&fmt->SubFormat, &KSDATAFORMAT_SUBTYPE_PCM))){ > + switch(fmt->Format.wBitsPerSample){ > + case 8: > + return AL_UNSIGNED_BYTE_SOFT; > + case 16: > + return AL_SHORT_SOFT; > + case 32: > + return AL_INT_SOFT; > + } > + }else if(fmt->Format.wFormatTag == WAVE_FORMAT_IEEE_FLOAT || > + (fmt->Format.wFormatTag == WAVE_FORMAT_EXTENSIBLE && > + IsEqualGUID(&fmt->SubFormat, &KSDATAFORMAT_SUBTYPE_IEEE_FLOAT))){ > + if(fmt->Format.wBitsPerSample == 32) > + return AL_FLOAT_SOFT; > + } > + return 0; > +} > + > static HRESULT WINAPI IXAudio2Impl_CreateMasteringVoice(IXAudio2 *iface, > IXAudio2MasteringVoice **ppMasteringVoice, UINT32 inputChannels, > UINT32 inputSampleRate, UINT32 flags, const WCHAR *deviceId, > @@ -1329,8 +1422,12 @@ static HRESULT WINAPI IXAudio2Impl_CreateMasteringVoice(IXAudio2 *iface, > AUDIO_STREAM_CATEGORY streamCategory) > { > IXAudio2Impl *This = impl_from_IXAudio2(iface); > + IMMDevice *dev; > + HRESULT hr; > + WAVEFORMATEX *fmt; > + ALCint attrs[7]; > > - FIXME("(%p)->(%p, %u, %u, 0x%x, %s, %p, 0x%x): stub!\n", This, > + TRACE("(%p)->(%p, %u, %u, 0x%x, %s, %p, 0x%x)\n", This, > ppMasteringVoice, inputChannels, inputSampleRate, flags, > wine_dbgstr_w(deviceId), pEffectChain, streamCategory); > > @@ -1340,12 +1437,183 @@ static HRESULT WINAPI IXAudio2Impl_CreateMasteringVoice(IXAudio2 *iface, > if(pEffectChain) > WARN("Effect chain is unimplemented\n"); > > - /* TODO: Initialize mmdevice */ > + EnterCriticalSection(&This->lock); > > /* there can only be one Mastering Voice, so just build it into XA2 */ > + if(This->aclient){ > + LeaveCriticalSection(&This->lock); > + return XAUDIO2_E_INVALID_CALL; > + } > + > + if(!deviceId){ > + if(This->ndevs == 0){ > + LeaveCriticalSection(&This->lock); > + return ERROR_NOT_FOUND; > + } > + deviceId = This->devids[0]; > + } > + > + hr = IMMDeviceEnumerator_GetDevice(This->devenum, deviceId, &dev); > + if(FAILED(hr)){ > + WARN("GetDevice failed: %08x\n", hr); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + hr = IMMDevice_Activate(dev, &IID_IAudioClient, > + CLSCTX_INPROC_SERVER, NULL, (void**)&This->aclient); > + if(FAILED(hr)){ > + WARN("Activate(IAudioClient) failed: %08x\n", hr); > + IMMDevice_Release(dev); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + IMMDevice_Release(dev); > + > + hr = IAudioClient_GetMixFormat(This->aclient, &fmt); > + if(FAILED(hr)){ > + WARN("GetMixFormat failed: %08x\n", hr); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + if(sizeof(WAVEFORMATEX) + fmt->cbSize > sizeof(WAVEFORMATEXTENSIBLE)){ > + FIXME("Mix format doesn't fit into WAVEFORMATEXTENSIBLE!\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + if(inputChannels == XAUDIO2_DEFAULT_CHANNELS) > + inputChannels = fmt->nChannels; > + if(inputSampleRate == XAUDIO2_DEFAULT_SAMPLERATE) > + inputSampleRate = fmt->nSamplesPerSec; > + > + memcpy(&This->fmt, fmt, sizeof(WAVEFORMATEX) + fmt->cbSize); > + This->fmt.Format.nChannels = inputChannels; > + This->fmt.Format.nSamplesPerSec = inputSampleRate; > + This->fmt.Format.nBlockAlign = This->fmt.Format.nChannels * This->fmt.Format.wBitsPerSample / 8; > + This->fmt.Format.nAvgBytesPerSec = This->fmt.Format.nSamplesPerSec * This->fmt.Format.nBlockAlign; > + This->fmt.dwChannelMask = get_channel_mask(This->fmt.Format.nChannels); > + > + CoTaskMemFree(fmt); > + fmt = NULL; > + > + hr = IAudioClient_IsFormatSupported(This->aclient, > + AUDCLNT_SHAREMODE_SHARED, &This->fmt.Format, &fmt); > + if(hr == S_FALSE){ > + if(sizeof(WAVEFORMATEX) + fmt->cbSize > sizeof(WAVEFORMATEXTENSIBLE)){ > + FIXME("Mix format doesn't fit into WAVEFORMATEXTENSIBLE!\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + memcpy(&This->fmt, fmt, sizeof(WAVEFORMATEX) + fmt->cbSize); > + } > + > + CoTaskMemFree(fmt); > + > + hr = IAudioClient_Initialize(This->aclient, AUDCLNT_SHAREMODE_SHARED, > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, inputSampleRate /* 1s buffer */, > + 0, &This->fmt.Format, NULL); > + if(FAILED(hr)){ > + WARN("Initialize failed: %08x\n", hr); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + hr = IAudioClient_GetService(This->aclient, &IID_IAudioRenderClient, > + (void**)&This->render); > + if(FAILED(hr)){ > + WARN("GetService(IAudioRenderClient) failed: %08x\n", hr); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + /* setup openal context */ > + attrs[0] = ALC_FORMAT_CHANNELS_SOFT; > + switch(inputChannels){ > + case 1: > + attrs[1] = ALC_MONO_SOFT; > + break; > + case 2: > + attrs[1] = ALC_STEREO_SOFT; > + break; > + case 4: > + attrs[1] = ALC_QUAD_SOFT; > + break; > + case 6: > + attrs[1] = ALC_5POINT1_SOFT; > + break; > + case 7: > + attrs[1] = ALC_6POINT1_SOFT; > + break; > + case 8: > + attrs[1] = ALC_7POINT1_SOFT; > + break; > + default: > + WARN("OpenAL doesn't support %u channels\n", inputChannels); > + LeaveCriticalSection(&This->lock); > + return AUDCLNT_E_UNSUPPORTED_FORMAT; > + } > + attrs[2] = ALC_FREQUENCY; > + attrs[3] = inputSampleRate; > + attrs[4] = ALC_FORMAT_TYPE_SOFT; > + attrs[5] = al_get_loopback_format(&This->fmt); > + attrs[6] = 0; > + > + if(!attrs[5]){ > + WARN("OpenAL can't output samples in this format\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + This->al_device = palcLoopbackOpenDeviceSOFT(NULL); > + if(!This->al_device){ > + WARN("alcLoopbackOpenDeviceSOFT failed\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + This->al_ctx = alcCreateContext(This->al_device, attrs); > + if(!This->al_ctx){ > + WARN("alcCreateContext failed\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + if(alcMakeContextCurrent(This->al_ctx) == ALC_FALSE){ > + WARN("alcMakeContextCurrent failed\n"); > + hr = XAUDIO2_E_DEVICE_INVALIDATED; > + goto exit; > + } > + > + IAudioClient_Start(This->aclient); > + > *ppMasteringVoice = &This->IXAudio2MasteringVoice_iface; > > - return S_OK; > +exit: > + if(FAILED(hr)){ > + if(This->render){ > + IAudioRenderClient_Release(This->render); > + This->render = NULL; > + } > + if(This->aclient){ > + IAudioClient_Release(This->aclient); > + This->aclient = NULL; > + } > + if(This->al_ctx){ > + alcDestroyContext(This->al_ctx); > + This->al_ctx = NULL; > + } > + if(This->al_device){ > + alcCloseDevice(This->al_device); > + This->al_device = NULL; > + } > + } > + > + LeaveCriticalSection(&This->lock); > + > + return hr; > } > > static HRESULT WINAPI IXAudio2Impl_StartEngine(IXAudio2 *iface) > -- > 2.5.0 > > > >

4 5

Re: ws2_32: WSACleanup cleans up open sockets (OSX only)
by Ken Thomases Aug. 29, 2015

Aug. 29, 2015

Hi, Thanks for contributing to Wine. I've commented on the patch in-line below: On Jul 31, 2015, at 10:19 PM, Matt Durgavich <mattdurgavich(a)gmail.com> wrote: > +static void close_open_sockets() { > +#ifdef HAVE_LIBPROC_H > + int pid = getpid(); > + int bufferSizeNeeded = proc_pidinfo(pid, PROC_PIDLISTFDS, 0, NULL, 0); This function isn't documented and the header which declares it says it's SPI rather than API and can change at any time. Also, is this the right approach generally? This is going to close all Unix sockets opened by the process, not just Win32 sockets opened by ws2_32. Is it safe/proper for WSACleanup to close sockets that it didn't open? Isn't it possible that other parts of Wine could open Unix sockets for other reasons? Or that system libraries or frameworks might do so to carry out requests made by Wine? > + if (bufferSizeNeeded > 0) { > + struct proc_fdinfo *infos = (struct proc_fdinfo*)malloc(bufferSizeNeeded); > + int ret = proc_pidinfo(pid, PROC_PIDLISTFDS, 0, infos, bufferSizeNeeded); > + int numfds = bufferSizeNeeded / PROC_PIDLISTFD_SIZE; Shouldn't you use ret / PROC_PIDLISTFD_SIZE (assuming no error)? > + if (ret >= 0) { > + for (int i = 0; i < numfds; ++i ) { I don't think declaring the loop variable in the loop is allowed by Wine's coding standards. > + int32_t fd = infos[i].proc_fd; > + uint32_t type = infos[i].proc_fdtype; > + if (type == PROX_FDTYPE_SOCKET) { > + TRACE("Closing socket with descriptor %d\n", fd); > + close(fd); > + } > + } > + } > + free(infos); > + } > +#else > + FIXME("stub") > +#endif > +} > > /*********************************************************************** > * WSACleanup (WS2_32.116) > @@ -1458,8 +1490,14 @@ INT WINAPI WSACleanup(void) > if (num_startup) { > num_startup--; > TRACE("pending cleanups: %d\n", num_startup); > + if (num_startup == 0) { > + TRACE("cleaning up open sockets"); > + close_open_sockets(); > + } > return 0; > } > + > + /* Close all sockets */ What's this last comment about? Did you mean to put it above? > SetLastError(WSANOTINITIALISED); > return SOCKET_ERROR; > } > -Ken

5 28

Congratulations / thanks to our 2015 GSoC Students
by Austin English Aug. 29, 2015

Aug. 29, 2015

I wanted to send a note congratulating our Google Summer of Code students for all passing their reviews, and thanking them for their work on Wine this summer. I hope you've enjoyed working on Wine and will continue to work with us in the future. -- -Austin

4 3

Wine and OS/X
by Jonathan Allen Aug. 28, 2015

Aug. 28, 2015

Dear Wine list, I hope this isn't too off-topic, but can someone tell me if Wine works on OS/X and, if so, is there a binary download for it? Jonathan

2 1

Re: [PATCH 5/5] xaudio2/tests: Add callback tests
by Marvin Aug. 28, 2015

Aug. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16390 Your paranoid android. === build (build) === Unable to regenerate dlls/xaudio2_7/Makefile Unable to regenerate dlls/xaudio2_7/Makefile

1 0

Re: [PATCH 4/5] xaudio2: Add a simple audio streaming test
by Marvin Aug. 28, 2015

Aug. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16389 Your paranoid android. === build (build) === Unable to regenerate dlls/xaudio2_7/Makefile Unable to regenerate dlls/xaudio2_7/Makefile

1 0

Re: [PATCH 5/5] d3d11/tests: Add test for 2D texture interfaces.
by Henri Verbeet Aug. 28, 2015

Aug. 28, 2015

On 28 August 2015 at 00:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + hr = ID3D11Texture2D_QueryInterface(texture, &IID_IDXGISurface, (void **)&surface); > + ok(hr == E_NOINTERFACE, "Texture should not implement IDXGISurface.\n"); > + if (SUCCEEDED(hr)) IDXGISurface_Release(surface); You don't need the Release(), if the QueryInterface() would succeed the test would fail. > + if (FAILED(hr)) > + { > + skip("2D textures do not implement ID3D10Texture2D, skipping tests.\n"); This should probably be a win_skip(). You're leaking the device here. > + hr = ID3D11Device_CreateTexture2D(device, &desc, NULL, &texture); > + ok(SUCCEEDED(hr), "%u: Failed to create a 2d texture, hr %#x.\n", i, hr); > + if (FAILED(hr)) continue; ... > + hr = ID3D11Texture2D_QueryInterface(texture, &IID_IDXGISurface, (void **)&surface); > + ok(SUCCEEDED(hr), "%u: Texture should implement IDXGISurface.\n", i); > + if (SUCCEEDED(hr)) IDXGISurface_Release(surface); ... > + hr = ID3D11Texture2D_QueryInterface(texture, &IID_ID3D10Texture2D, (void **)&d3d10_texture); > + ok(SUCCEEDED(hr), "%u: Texture should implement ID3D10Texture2D.\n", i); > + if (SUCCEEDED(hr)) > + { Similar to above, you don't need to account for conditions where the test would fail.

1 0

Re: [PATCH 4/5] d3d11/tests: Port test_create_texture2d() from d3d10core.
by Henri Verbeet Aug. 28, 2015

Aug. 28, 2015

On 28 August 2015 at 00:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static ID3D11Device *create_default_device(void) > +{ > + ID3D11Device *device; > + > + if (SUCCEEDED(D3D11CreateDevice(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, NULL, 0, D3D11_SDK_VERSION, > + &device, NULL, NULL))) > + return device; > + if (SUCCEEDED(D3D11CreateDevice(NULL, D3D_DRIVER_TYPE_WARP, NULL, 0, NULL, 0, D3D11_SDK_VERSION, > + &device, NULL, NULL))) > + return device; > + if (SUCCEEDED(D3D11CreateDevice(NULL, D3D_DRIVER_TYPE_REFERENCE, NULL, 0, NULL, 0, D3D11_SDK_VERSION, > + &device, NULL, NULL))) > + return device; > + > + return NULL; > +} > + I think I'd make the "feature_level" parameter to the existing create_device() a pointer, and then make it optional. See also e.g. create_device() in dlls/d3d9/tests/device.c.

1 0

Re: [PATCH 3/5] d3d11: Implement d3d11_device_CreateTexture2D().
by Henri Verbeet Aug. 28, 2015

Aug. 28, 2015

On 28 August 2015 at 00:39, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static inline struct d3d10_texture2d *impl_from_ID3D11Texture2D(ID3D11Texture2D *iface) > +{ > + return CONTAINING_RECORD(iface, struct d3d10_texture2d, ID3D11Texture2D_iface); > +} > + We usually try to keep these in the file that contains the interface implementation, texture.c in this case. We do make the occasional exception though. > + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > + if (!object) You could just do "if (!(object = HeapAlloc(...)))" here, but it doesn't matter that much. > @@ -2006,15 +2025,12 @@ static HRESULT STDMETHODCALLTYPE d3d10_device_CreateTexture2D(ID3D10Device1 *ifa > { > struct d3d_device *device = impl_from_ID3D10Device(iface); > D3D11_TEXTURE2D_DESC d3d11_desc; > + ID3D11Texture2D *d3d11_texture; > struct d3d10_texture2d *object; > HRESULT hr; > > TRACE("iface %p, desc %p, data %p, texture %p.\n", iface, desc, data, texture); > > - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); > - if (!object) > - return E_OUTOFMEMORY; > - > d3d11_desc.Width = desc->Width; > d3d11_desc.Height = desc->Height; > d3d11_desc.MipLevels = desc->MipLevels; > @@ -2026,16 +2042,14 @@ static HRESULT STDMETHODCALLTYPE d3d10_device_CreateTexture2D(ID3D10Device1 *ifa > d3d11_desc.CPUAccessFlags = d3d11_cpu_access_flags_from_d3d10_cpu_access_flags(desc->CPUAccessFlags); > d3d11_desc.MiscFlags = d3d11_resource_misc_flags_from_d3d10_resource_misc_flags(desc->MiscFlags); > > - if (FAILED(hr = d3d10_texture2d_init(object, device, &d3d11_desc, data))) > - { > - WARN("Failed to initialize texture, hr %#x.\n", hr); > - HeapFree(GetProcessHeap(), 0, object); > + if (FAILED(hr = d3d11_device_CreateTexture2D(&device->ID3D11Device_iface, &d3d11_desc, > + (const D3D11_SUBRESOURCE_DATA *)data, &d3d11_texture))) > return hr; > - } > > + object = impl_from_ID3D11Texture2D(d3d11_texture); > *texture = &object->ID3D10Texture2D_iface; > > - TRACE("Created ID3D10Texture2D %p\n", object); > + TRACE("Created ID3D10Texture2D %p.\n", object); > > return S_OK; > } This change doesn't really seem worth it. You do save a couple of lines by avoiding the memory allocation, but you need to make impl_from_ID3D11Texture2D() available outside of texture.c to do it. You could create a d3d_texture2d_create() function similar to e.g. d3d9_swapchain_create() in d3d9 and avoid the duplication that way, but it may not make much of a difference in line count. Up to you.

1 0

Re: [PATCH 5/5] d3d11/tests: Add test for 2D texture interfaces.
by Marvin Aug. 28, 2015

Aug. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16380 Your paranoid android. === w7u (32 bit d3d11) === d3d11.c:360: Test failed: 0: Texture should implement ID3D10Texture2D. d3d11.c:352: Test failed: 2: Failed to create a 2d texture, hr 0x8007000e. === w8 (32 bit d3d11) === d3d11.c:360: Test failed: 0: Texture should implement ID3D10Texture2D.

2 1

Re: ieframe: Fixed random test failures.
by Marvin Aug. 28, 2015

Aug. 28, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16383 Your paranoid android. === w2000pro (32 bit webbrowser) === webbrowser.c:2972: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2977: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE webbrowser.c:2972: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2977: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE webbrowser.c:2972: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEBACK_FALSE webbrowser.c:2977: Test failed: expected Invoke_COMMANDSTATECHANGE_NAVIGATEFORWARD_FALSE

1 0

What would the best approach for adding securing Wine and is it a reasonable goal?
by Steven Stewart-Gallus Aug. 28, 2015

Aug. 28, 2015

Hello, I noticed that CreateRestrictedToken basically just duplicates the token and doesn't do anything. This makes sense as Wine is implemented as a compatibility library and program loader and not as a virtual machine and Windows programs running on Wine can break out and access Linux system calls so making CreateRestrictedToken do anything more wouldn't accomplish anything. I think it would be really cool though if CreateRestrictedToken and similar sandboxing APIs actually accomplished something in Wine though. What would the best approach for securing Wine be and is it a reasonable goal? First, see http://wiki.winehq.org/SecuringWine. So far, I can think of a few approaches. The first approach is to make a whole operating system such as ReactOS. The second approach is making a whole operating system that only has device drivers for working on top of virtual machines or hypervisors. The third approach is making a kernel that runs as a normal user process on top of a full OS (similar to User-Mode Linux or a weekend project I am working on at https://gitlab.com/sstewartgallus/wum, also see the Chrome sandbox at https://www.chromium.org/developers/design-documents/sandbox, https://code.google.com/p/chromium/wiki/LinuxSandboxing and https://dev.chromium.org/developers/design-documents/sandbox/osx-sandboxing…) The fourth approach is to abandon securing Wine itself and simply run Wine programs inside separate sandboxes. ReactOS already serves as an example of the first approach. The second approach is basically similar to ReactOS. My project at https://gitlab.com/sstewartgallus/wum serves as a tiny example of of the third approach might work. The fourth approach of separate sandboxes is actually very simple. One possible implementation of this fourth approach on Linux might be to use a script like the sandbox-X.sh script shown below and remove the Z: symlink in dosdevices (this isn't actually needed or improves security but just looks nice.) Note that to make this script work I had to do some configuration to let my automatically su into the sandbox account. As well, I also had to download a dummy Xorg configuration to the home directory of the sandbox account. Thank you, Steven Stewart-Gallus sandbox-X.sh: #! /bin/sh set -e set -C set -u exec su -l -c 'exec sh <&3' sstewartgallus-sandbox 3<<'EOF' set -e set -C set -u exec 3<&- export DISPLAY=':76' export XPRA_SOCKET_DIR='/tmp' exec xpra\ start\ ${DISPLAY}\ --xvfb="Xorg -noreset +extension GLX +extension RANDR +extension RENDER -logfile ./${DISPLAY}.log -config ./xorg.conf"\ "--no-daemon"\ "--mmap-group"\ "--no-sharing"\ "--bell"\ "--system-tray"\ "--xsettings"\ "--cursors"\ "--encoding=rgb"\ "--clipboard"\ --start-child=xterm

2 1

Re: [1/3] comdlg32: Implement open dropdown menu.
by Marvin Aug. 27, 2015

Aug. 27, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16371 Your paranoid android. === wvistau64 (64 bit itemdlg) === No test summary line found

1 0

Re: Winelib and C++ static initialization
by Luke Dunstan Aug. 27, 2015

Aug. 27, 2015

On Thu, 27 Aug 2015 at 00:44 Stefan Dösinger <stefandoesinger(a)gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > You dropped the wine-devel CC. Was that intentional? There are people > who have more clues about winelib than I do. > No, it was accidental, sorry. > > >> I found that OutputDebugStringA doesn't write anything here, > >> even if successful. I replaced it with printf calls to get > >> actual output. > > > > OK, but why exactly is this necessary? This is just an artificial > > example to demonstrate the general problem. > I looked into the source code of OutputDebugStringA, but I couldn't find > an obvious answer. It certainly does a lot more than just write a string > to STDOUT. I didn't really understand what it was doing. > Yes, it sends the message to the attached debugger if any, not to stdout. On Windows or Wine you can run SysInternals DbgView.exe to see it. It's just an example though, and many other APIs also crash when called from initialisers. >> Though it's not quite working here either: > > > > Any ideas why, or how it could be fixed? > Sorry, no idea :-( . > > > Yes. My hope was that Winelib could be used to help port a legacy > > Windows CE 4.x application to Linux (ARM, though I am testing on > > x86 right now). Initially I could try compiling on Windows and > > running it on Linux, but the real goal would be to port the > > application in stages, so changing a few modules at a time to use > > Linux APIs while leaving some parts using the Win32 (and MFC) APIs. > > Eventually there would be no need for Winelib but I'd expect that > > porting all of the code at once would resulting in a lot more > > debugging effort because changes would not be localised. > Hmm yeah, that sounds like a task where you need winelib. Unfortunately > winelib isn't something that gets used a lot, and even less so with C++. > > Also keep in mind that Wine doesn't target Windows CE applications, so > you'll have to invest a lot of time into bridging Windows CE <-> Win32 > differences. > Yes I understand, but fortunately most of the application also runs on normal Win32. You'll also have to compile MFC with Winelib to target ARM. It should > be possible to compile MFC (or at least parts of it) with winelib, but > I don't expect this to be easy either. > That's true, and that was actually the first thing I tried to do. I tried both static and dynamic libraries but it crashes before it gets to WinMain(), hence my question. GDB can trap the crash but the stack trace gives no function names or other useful information. (gdb) bt #0 0x00000000 in ?? () #1 0x7ec4b7c0 in ?? () #2 0x7ec4b77e in ?? () #3 0x7ec4b79e in ?? () #4 0xb7febd77 in ?? () Backtrace stopped: previous frame inner to this frame (corrupt stack?) Winedbg cannot even get that far. But I will try 1.7... Luke

2 1

Re: [2/4] comdlg32: Implement open dropdown menu.
by Alexandre Julliard Aug. 27, 2015

Aug. 27, 2015

Vincent Povirk <madewokherd(a)gmail.com> writes: > This implements the open dropdown button as a separate button, rather > than using BS_SPLITBUTTON, which is unimplemented in Wine. This adds > some complexity, but I don't think it changes things enough to get in > the way of other work on this component. > > I have an implementation using BS_SPLITBUTTON that works on Windows, > and could theoretically be used once we have support for window class > redirection and BS_SPLITBUTTON. I will send that to wine-devel so you > can see how much complexity this approach adds, and what the correct > approach will look like. It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M comdlg32.dll -p comdlg32_test.exe.so itemdlg && touch itemdlg.ok itemdlg.c:2088: Test succeeded inside todo block: got 0x00000000. itemdlg.c:2089: Test succeeded inside todo block: got 0. Makefile:270: recipe for target 'itemdlg.ok' failed make: *** [itemdlg.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/5] dxgi/tests: Add a Test presentation parameter combinations.
by Marvin Aug. 26, 2015

Aug. 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16348 Your paranoid android. === wvistau64 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w2008s64 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w7u (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 35. device.c:1173: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 36. device.c:1173: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 42. device.c:1173: Test failed: Got usage 160, expected 60, test 42, buffer 15. === w8 (32 bit device) === device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 24. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 25. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 27. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 28. device.c:1173: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 29. device.c:1173: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 35. device.c:1173: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 36. device.c:1173: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 40. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 41. device.c:1173: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1128: Test failed: Got unexpected hr 0x87a0001, test 42. device.c:1173: Test failed: Got usage 160, expected 60, test 42, buffer 15. === wvistau64 (64 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42. === w2008s64 (64 bit device) === device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 12. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 13. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 19. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 35. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 36. device.c:1128: Test failed: Got unexpected hr 0x887a0001, test 42.

1 0

Re: [PATCH 4/5] d3d8/tests: Test presentation parameter combinations.
by Marvin Aug. 26, 2015

Aug. 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16347 Your paranoid android. === w8 (32 bit device) === device.c:1216: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1261: Test failed: Reset failed, hr 0x88760868. device.c:1263: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1267: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1274: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1275: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1276: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1277: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1278: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1279: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1284: Test failed: Screen width is 640, expected 800. device.c:1285: Test failed: Screen height is 480, expected 600. device.c:1291: Test failed: Back buffer width is 640, expected 800. device.c:1293: Test failed: Back buffer height is 480, expected 600. device.c:1323: Test failed: Screen width is 640, expected 1024. device.c:1324: Test failed: Screen height is 480, expected 768. device.c:2571: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2576: Test failed: The focus window is active. device.c:2584: Test failed: Got unexpected hr 0x88760869. device.c:2590: Test failed: Got unexpect screen size 800x600. device.c:2605: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2614: Test failed: Got unexpect screen size 800x600. device.c:2627: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2635: Test failed: Got unexpect width 640. device.c:2636: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 5/5] dxgi/tests: Add a Test presentation parameter combinations.
by Henri Verbeet Aug. 26, 2015

Aug. 26, 2015

On 26 August 2015 at 21:50, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + wc.lpfnWndProc = DefWindowProcA; > + wc.lpszClassName = "dxgi_test_wc"; > + RegisterClassA(&wc); Do we really need that?

1 0

Winelib and C++ static initialization
by Luke Dunstan Aug. 26, 2015

Aug. 26, 2015

Hi, I am new to Winelib and I have crashes with very basic C++ code. Consider the following code: #include <windows.h> struct MyInit { MyInit() { OutputDebugStringA("Init ctor\n"); } }; MyInit InitObj; extern "C" int CALLBACK WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { OutputDebugStringA("WinMain()\n"); return 0; } If I compile it on Ubuntu 32-bit with wine-1.6.2 with: wineg++ -c -mno-cygwin -o hello.o hello.cpp wineg++ -mwindows -mno-cygwin -o hellocpp.exe hello.o The result is: $ ./hellocpp.exe Segmentation fault (core dumped) On Windows this program obviously outputs "Init ctor\n" followed by "WinMain()\n", as viewed in DbgView. Removing the call to OutputDebugStringA from the static constructor prevents the crash in Winelib. How do I get C++ static initialization to work properly in Winelib? Thanks, Luke

2 1

Re: [1/2] msi: Don't add the same environment string more than once.
by Marvin Aug. 26, 2015

Aug. 26, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16331 Your paranoid android. === w7u (32 bit action) === The test timed out === w8 (32 bit action) === The test timed out === wvistau64 (64 bit action) === The test timed out

1 0

Re: [PATCH 3/3] kernel32/tests: Add tests for Invariant
by Alexandre Julliard Aug. 26, 2015

Aug. 26, 2015

Daniel Lehman <dlehman(a)esri.com> writes: > + { X(LOCALE_SNATIVEDIGITS), "0123456789" }, > + { X(LOCALE_SCURRENCY), "" }, Please avoid non-ASCII characters in source code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] reg: simplify root key search
by Stefan Dösinger Aug. 26, 2015

Aug. 26, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Something is still wrong with the submission: $ git am ~/Desktop/\[PATCH\ 1_2\]\ reg\:\ simplify\ root\ key\ search\ -\ Michel\ Zou\ \<xantares09\(a)hotmail.com\>\ -\ 2015-08-25\ 2150.eml Applying: reg: simplify root key search /home/stefan/src/wine/.git/rebase-apply/patch:33: trailing whitespace. static const WCHAR short_hklm[] = {'H','K','L','M',0}; /home/stefan/src/wine/.git/rebase-apply/patch:34: trailing whitespace. static const WCHAR short_hkcu[] = {'H','K','C','U',0}; /home/stefan/src/wine/.git/rebase-apply/patch:35: trailing whitespace. static const WCHAR short_hkcr[] = {'H','K','C','R',0}; /home/stefan/src/wine/.git/rebase-apply/patch:36: trailing whitespace. static const WCHAR short_hku[] = {'H','K','U',0}; /home/stefan/src/wine/.git/rebase-apply/patch:37: trailing whitespace. static const WCHAR short_hkcc[] = {'H','K','C','C',0}; error: patch failed: programs/reg/reg.c:22 error: programs/reg/reg.c: patch does not apply Patch failed at 0001 reg: simplify root key search It looks like the patch has Windows line endings, but AFAIK that shouldn't break git am. I strongly recommend to use git send-email to make git send the patches directly to the SMTP server instead of going through text files and MUAs. That avoids issues like that pretty reliably. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJV3as6AAoJEN0/YqbEcdMwEfYP/1ibDcxPQ9VF6tKyfQKVeuVW cC1rFbAbbXdWPxALIiJa/qEz/3DKV4j1tIvU68GA6SE5gh4XLsVfH1Li66PX3KQy 6ytqG263r677dDxjTPIJHOTsl4ncFvCVHkVz3cn9zBLM3G6V8BLeL4rCVFq1Wso0 pNS5abhVQNzDTY+gLG2oh9XqtLuI2oAmF6YO/VklVKF8pVwN50RX7FXJuGwlhScn +6GvzOLrkirbTL1jKW+v+4BZ22CjzGRZPVMGPlmgGIdyexVjoG8nAlfvLoH6+Qds 6WQatGcHFNnJjE275Snl9EjnspfedMLcYWspbbC7IsWDvdMrt8LawUGDOyZsqxzC yUYnMHNaotC7K0FpqHG+OKTRgrJy8dX10xSkTAhj6FtLj49BFhNb7hWsqc3T//g6 GlcmCYxWXNmseOt5t5E/v4eb9XowBab9Mv4zNU8sFZWlfUvbv3vMnhfzjslZnHNY h+yBR9OQZiKInPsHxW3wsuIIt0xBjPE1RHUac9vfPc031PvjqYulQ2PfQkUyljo2 vHwqCU6i9S8Y2INd7PwOggoHqE9SKMFvaRg9Tf5vOiG9YQHtaTWHj+xgQsb5DRxd QWV+uK0gZW2UX0ozxzrCK2Kd5mEhTRd/dVZK75/ALoprf2r7aqU7gS+4aQYActlL LIk5K82tvISRR7QdN0KN =cTjQ -----END PGP SIGNATURE-----

2 1

Re: [PATCH v2 2/2] ucrtbase: Hook up some functions with new names to existing implementations
by Alexandre Julliard Aug. 25, 2015

Aug. 25, 2015

Martin Storsjo <martin(a)martin.st> writes: > These are some functions that on a first glance seem to have a > matching signature even though the exact symbol name isn't the > same as in msvcr120. It would be better to create a separate function, unless there is strong evidence that they are doing the exact same thing. For example, I expect that there's a reason for having both malloc and malloc_base; mapping them to the same function would make any difference hard to spot. -- Alexandre Julliard julliard(a)winehq.org

2 2

FW: [PATCH 2/2] kernel32: add Invariant string table wrc: add support for LANG_INVARIANT
by Daniel Lehman Aug. 25, 2015

Aug. 25, 2015

-----Original Message----- From: wine-patches [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of Daniel Lehman Sent: Monday, August 24, 2015 12:27 PM To: 'wine-patches(a)winehq.org' Subject: [PATCH 2/2] kernel32: add Invariant string table wrc: add support for LANG_INVARIANT I noticed this was marked as "Superseded". What is it superseded by? https://source.winehq.org/patches/data/113923 (I also noticed the subject got messed up, so I can resubmit if needed) thanks daniel

2 1