August 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 1/4] msvcp110: Add tr2_sys__Copy_file_wchar implementation and test.(try 2)
by Marvin Aug. 17, 2015

Aug. 17, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16059 Your paranoid android. === build (build) === Patch failed to apply

1 0

Request for help with running Unreal ED 3.0 in Wine (from developer Running With Scissors)
by Jon M Aug. 17, 2015

Aug. 17, 2015

Greetings everyone, I work as a project manager and developer for Running with Scissors. We have a game called POSTAL 2 that natively supports Linux and runs on the Unreal 2 engine, and includes modding Steam workshop features. Sadly, the Level editor (based on UnrealED 3.0) is not supported in Linux, and rewriting it to support it natively is out of the question. However, when running the Windows build under Wine, almost everything works perfectly, including navigating the viewports and rebuilding the maps. It’s so close to being perfectly usable as a level editor, with one major caveat - not being able to select actors or surfaces by clicking or access their right click menus to add actors. It is possible select actors with marquee select in the orthographic views, and you are able to add static meshes to a level via the Insert button in the Static Mesh browser. The texture browser also has issues with selection which can be worked around by increasing the size in the View menu. It run a bit slow but well enough for practical use (20 FPS in the viewports on bigger maps on a 2.8ghz CPU). There is a log on the WineHQ database regarding this here which focuses on the UT2004 editor, but the problems are much the same. https://appdb.winehq.org/objectManager.php?sClass=version&iId=4638 Reason I'm interested in this is because, with that one thing fixed, we could use a Wine wrapper and put the SDK up for Linux on Steam and elsewhere. We'd even have it so it hands off to the native Linux version of the game when testing the map from the editor. It would be quite a thing to be one of the few games with a full SDK for Linux on Steam. No one is maintaining this it seems in WineHQ, but there is a a least a chance the fix it needs may not be too hard to work out, so I'm hoping to find someone that's willing to see if they can fix this (and any other problems we come across in QA). Thank you for your time in reading this, Jon

2 3

Re: Assorted spelling and typos fixes
by Henri Verbeet Aug. 17, 2015

Aug. 17, 2015

On 17 August 2015 at 15:14, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > - TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p," > + TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p,\n" > "\tshader_byte_code_length %lu, input_layout %p\n", This is the same as 113682, same comment applies.

1 0

Implementation patches for d3drm's CreateDeviceFromD3D.
by Aaryaman Vasishta Aug. 17, 2015

Aug. 17, 2015

Attached is the patches for implementing CreateDeviceFromD3D. Please take a look and provide feedback, if any. Thank you! Aaryaman

2 8

Re: [PATCH 2/2] d3d10core: Add missing \n in trace.
by Henri Verbeet Aug. 17, 2015

Aug. 17, 2015

On 16 August 2015 at 22:21, Józef Kucia <jkucia(a)codeweavers.com> wrote: > - TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p," > + TRACE("iface %p, element_descs %p, element_count %u, shader_byte_code %p,\n" > "\tshader_byte_code_length %lu, input_layout %p\n", I'd rather just remove the '\t'. In particular, having newlines in the middle of TRACEs makes it a bit harder to extract all calls from a single thread from a log.

1 0

Re: [PATCH 1/2] includes: Add D3D11CreateDeviceAndSwapChain declaration to d3d11.idl.
by Henri Verbeet Aug. 17, 2015

Aug. 17, 2015

On 16 August 2015 at 22:21, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +cpp_quote("HRESULT WINAPI D3D11CreateDeviceAndSwapChain(IDXGIAdapter*,D3D_DRIVER_TYPE,HMODULE,UINT,") > +cpp_quote(" const D3D_FEATURE_LEVEL*,UINT,UINT,const DXGI_SWAP_CHAIN_DESC*,IDXGISwapChain**,ID3D11Device**,") > +cpp_quote(" D3D_FEATURE_LEVEL*,ID3D11DeviceContext**);") The existing declarations aren't really helping here, but could you please avoid using cpp_quote and include parameter names?

1 0

Re: [PATCH] shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories.
by Olivier F. R. Dierick Aug. 15, 2015

Aug. 15, 2015

Hello, I noticed tests failures in shlfileop while trying to add a new test. The failures were in parts that are not touched by my patches (same errors that you got). I have a patch ready for submission that correct the failures in the existing tests. You may want to wait until I submit my patch and it is committed before submitting your patch again. I'll submit my patch as soon as possible. Regards. Le vendredi 14 août 2015 à 21:18 +0800, Zhenbo Li a écrit : > This patch fixes bug 25207. Seems that a dozen of apps are affected by > this bug, so please tell me how I can improve this patch if this patch > can't be committed directly. > > There will be a test error: > shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR > > It is not related to my patch. > > Hope you enjoy your weekend. > > --- > dlls/shell32/shlfileop.c | 11 +++++++++-- > dlls/shell32/tests/shlfileop.c | 6 +++--- > 2 files changed, 12 insertions(+), 5 deletions(-) > > -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be

2 4

Re: monthcal.c patch.txt
by Nikolay Sivov Aug. 15, 2015

Aug. 15, 2015

On 14.08.2015 19:54, s.p. wrote: > Countries use different rules for determining week numbers. For the > classic month calendar however, windows seems to ignore the first week > of the year registry setting. The attached file 'patch.txt' addresses > this quirk by simply implementing the rules of ISO8601. Although this > patch works and has been tested, it is not intended as a complete fix. > For that it probably needs some more investigation. Usage: > > > cd wine/dlls/comctl32 > patch monthcal.c < patch.txt > > Greets, sbmpost Hi, what is that registry settings you're talking about? I think I heard about different week numbering used in different countries, what are you using as a test case? I think what we actually want is locale-dependent algorithm for that (but it will require some research and testing, because monthcal could differ from what you'd expect).

1 0

Re: [PATCH 9/9] msvcp110: Add tr2_sys__Unlink implementation and test.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16028 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 8/9] msvcp110: Add tr2_sys__Symlink implementation and test.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16027 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 7/9] msvcp110: Add tr2_sys__Link implementation and test.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16026 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 6/9] msvcp120/tests: Add test of tr2_sys__Open_dir, tr2_sys__Read_dir and tr2_sys__Close_dir.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16025 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/9] msvcp120/tests: Add tr2_sys__Last_write_time test.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16024 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/9] msvcp110: Add tr2_sys__Last_write_time implementation and test.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16023 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories.
by Marvin Aug. 14, 2015

Aug. 14, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16012 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:818: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

1 0

Prelink usage
by Michael Cronenworth Aug. 14, 2015

Aug. 14, 2015

Does prelink still provide any benefits in wine? The package is being retired in Fedora so starting with 1.7.48 the wine package will no longer be compiled with it. A few applications I have run under 1.7.48 still function, but I am curious to know the possible failure cases. Thanks, Michael

4 6

Re: [PATCH] mshtml: Handle nsIDOMWindow_GetFrames returning NULL
by Jacek Caban Aug. 14, 2015

Aug. 14, 2015

Hi Indrek, On 08/09/15 09:09, Indrek Altpere wrote: > + if(!nsframes) { > + WARN("nsIDOMWindow_GetFrames returned NULL nsframes: %p\n", This->nswindow); > + return E_FAIL; The patch looks mostly good, but I think we should return DISP_E_MEMBERNOTFOUND in this case. Thanks, Jacek

1 0

Re: [PATCH] msvcr120: Implement strtof and _strtof_l (try 2)
by Henri Verbeet Aug. 13, 2015

Aug. 13, 2015

On 13 August 2015 at 02:23, Bernhard Übelacker <bernhardu(a)vr-web.de> wrote: > +static inline BOOL almost_equal(float d1, float d2) { > + if(d1-d2>-1e-30 && d1-d2<1e-30) > + return TRUE; > + return FALSE; > +} > + You almost never want to compare floating point values like that. See e.g. compare_float() in dlls/ddraw/tests/ddraw7.c for a better (if perhaps not quite perfect) way. E.g. for the FLT_MAX case this only works because you happen to get an exact match. "1e-30" is a double instead of a float. Of course this is probably copied from the existing tests, so I suppose I can't complain too much.

2 1

Re: [PATCH] msvcr120: implement strtof and _strtof_l
by Piotr Caban Aug. 12, 2015

Aug. 12, 2015

On 08/12/15 00:42, Bernhard Übelacker wrote: > + ok(*(unsigned*)&f == __inf_bytes && sizeof(unsigned) == sizeof(float), "f = %x\n", *(unsigned*)&f); It would be nicer to use _finitef from msvcr120 here. Thanks to it you can avoid __inf_bytes and __ninf_bytes declaration. Thanks, Piotr

1 0

Re: [PATCH 1/2] reg: simplify root key search
by Sebastian Lackner Aug. 11, 2015

Aug. 11, 2015

On 06.08.2015 23:14, xantares 09 wrote: > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > --- > programs/reg/reg.c | 85 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 43 insertions(+), 42 deletions(-) It is a bit pointless to send patches anonymously to the wine-patches mailing list. No matter if you are the author or not, when you are sending the patches you are the person responsible for it. To establish trust, all developers should use their real names here on the mailing lists. (see the rules for submitting patches: http://wiki.winehq.org/SubmittingPatches ) Besides that I see much bigger chances when Jonathan would send these patches himself. He is experienced with his own code, can respond to feedback, can fix regressions if it causes problems, and so on. For people new to Wine development its always easier to start with some self-written patches. @Jonathan: I would like to encourage you again to give it another try. If you need any help, feel free to ask me. I assume Stefan Dösinger would also be willing to help again. Regards, Sebastian

3 2

Re: [1/3] usp10/tests: Add tests for control character glyphs.
by Marvin Aug. 11, 2015

Aug. 11, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15955 Your paranoid android. === wvistau64 (32 bit usp10) === Failure running script in VM: timed out waiting for the child process

1 0

Re: quartz: waveparser support wav file generated by ffmpeg (try3)
by Dmitry Timoshkov Aug. 11, 2015

Aug. 11, 2015

"Changhui LIU" <liuchanghui(a)linuxdeepin.com> wrote: > Superseded patch 113457. > > > Change log: > remove todo_wine win_skip The patch looks good, and it actually more closely resembles mmioDescend behaviour (except of alignment to even boundary, but that's a separate issue). -- Dmitry.

2 1

Re: comctl32: ILC_COLORDDB imagelists can be created with 0 sizes
by Huw Davies Aug. 11, 2015

Aug. 11, 2015

On Mon, Aug 10, 2015 at 08:21:52PM -0500, Aric Stewart wrote: > diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c > index 6f13846..fcf5162 100644 > --- a/dlls/comctl32/tests/imagelist.c > +++ b/dlls/comctl32/tests/imagelist.c > @@ -1994,6 +1994,47 @@ static void test_create_destroy(void) > ok(rc == FALSE, "ImageList_Destroy(0xdeadbeef) should fail and not crash\n"); > } > > +static void test_0size_DIB(void) > +{ > + INT cx, cy; > + HIMAGELIST himl; > + IImageList *imgl; > + HRESULT hr; > + INT ret; > + > + himl = ImageList_Create(0, 14, ILC_COLORDDB, 4, 4); This seems an odd choice of function name when you're actually testing DDBs. Also, I think zero_size is much nicer than 0size. Better yet, move all of these into test_create_destroy() where it'll make the difference in behaviour between these and the DIBs more apparent. Huw.

1 0

Re: comctl32: ILC_COLORDDB imagelists can be created with 0 sizes
by Marvin Aug. 11, 2015

Aug. 11, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=15944 Your paranoid android. === w2000pro (32 bit imagelist) === imagelist: unhandled exception c0000005 at 0041CED0

1 0

Re: [PATCH 2/5] dwrite: Use OS/2 table data to set font style, make it preferable
by Dmitry Timoshkov Aug. 10, 2015

Aug. 10, 2015

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > if (tt_os2) { > + USHORT version = GET_BE_WORD(tt_os2->version); > + USHORT fsSelection = GET_BE_WORD(tt_os2->fsSelection); > + > if (GET_BE_WORD(tt_os2->usWidthClass) <= DWRITE_FONT_STRETCH_ULTRA_EXPANDED) > props->stretch = GET_BE_WORD(tt_os2->usWidthClass); > > props->weight = GET_BE_WORD(tt_os2->usWeightClass); > + if (version >= 4 && (fsSelection & OS2_FSSELECTION_OBLIQUE)) > + props->style = DWRITE_FONT_STYLE_OBLIQUE; > + else if (fsSelection & OS2_FSSELECTION_ITALIC) > + props->style = DWRITE_FONT_STYLE_ITALIC; It's much better to use freetype flags for bold and italic, that way styles will match between gdi32 and dwrite. Besides I'd prefer to trust freetype instead of some handmade code which was not tested by thousands of fonts out there. -- Dmitry.

2 4