August 2015 - Wine-Devel - list.winehq.org

Re: d3drm: Implement IDirect3DRM{2-3}::CreateDeviceFromClipper
by Marvin Aug. 18, 2015

Aug. 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16105 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement IDirect3DRM::CreateDeviceFromClipper
by Marvin Aug. 18, 2015

Aug. 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16104 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Add version specific tests frr CreateDeviceFrom* methods.
by Marvin Aug. 18, 2015

Aug. 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16103 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/2] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D (try 10).
by Marvin Aug. 18, 2015

Aug. 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16102 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3drm: Implement GetDirect3DDevice
by Aaryaman Vasishta Aug. 18, 2015

Aug. 18, 2015

Apologies! All the patches sent this minute were sent by mistake - I'll be sending the proper patch set now. Jam On Tue, Aug 18, 2015 at 7:23 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/d3drm/device.c | 27 ++++++++++++++++++++++++--- > dlls/d3drm/tests/d3drm.c | 4 ++-- > 2 files changed, 26 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3drm/device.c b/dlls/d3drm/device.c > index b703077..bb8eeae 100644 > --- a/dlls/d3drm/device.c > +++ b/dlls/d3drm/device.c > @@ -418,7 +418,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device1_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device1_GetDirect3DDevice(IDirect3DRMDevice > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > @@ -772,7 +779,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device2_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device2_GetDirect3DDevice(IDirect3DRMDevice2 > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice2(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > @@ -1139,7 +1153,14 @@ static D3DRMTEXTUREQUALITY WINAPI > d3drm_device3_GetTextureQuality(IDirect3DRMDev > > static HRESULT WINAPI d3drm_device3_GetDirect3DDevice(IDirect3DRMDevice3 > *iface, IDirect3DDevice **d3d_device) > { > - FIXME("iface %p, d3d_device %p stub!\n", iface, d3d_device); > + struct d3drm_device *device = impl_from_IDirect3DRMDevice3(iface); > + TRACE("iface %p, d3d_device %p!\n", iface, d3d_device); > + > + if (device->device) > + { > + *d3d_device = device->device; > + return D3DRM_OK; > + } > > return E_NOTIMPL; > } > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 959dbc3..4b5cd92 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -2008,7 +2008,7 @@ static void test_create_device_from_clipper1(void) > > /* Fetch immediate mode device in order to access render target */ > hr = IDirect3DRMDevice_GetDirect3DDevice(device1, &d3ddevice1); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface > (hr = %x).\n", hr); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface (hr = > %x).\n", hr); > if (FAILED(hr)) > goto cleanup; > > @@ -2103,7 +2103,7 @@ static void test_create_device_from_clipper1(void) > ok(hr == D3DRM_OK, "Cannot create IDirect3DRMDevice interface (hr = > %x).\n", hr); > > hr = IDirect3DRMDevice_GetDirect3DDevice(device1, &d3ddevice1); > - todo_wine ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface > (hr = %x).\n", hr); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DDevice interface (hr = > %x).\n", hr); > if (FAILED(hr)) > goto cleanup; > > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: tempory patch by slackner
by Aaryaman Vasishta Aug. 18, 2015

Aug. 18, 2015

My bad, I sent the wrong folder of patches -.- ignore all patches sent this minute please. Jam On Tue, Aug 18, 2015 at 7:23 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/windowscodecs/icnsformat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/windowscodecs/icnsformat.c > b/dlls/windowscodecs/icnsformat.c > index 54c7707..5d48a1a 100644 > --- a/dlls/windowscodecs/icnsformat.c > +++ b/dlls/windowscodecs/icnsformat.c > @@ -179,7 +179,7 @@ static ULONG WINAPI > IcnsFrameEncode_Release(IWICBitmapFrameEncode *iface) > if (This->icns_image != NULL) > HeapFree(GetProcessHeap(), 0, This->icns_image); > > - > IWICBitmapFrameEncode_Release(&This->encoder->IWICBitmapFrameEncode_iface); > + > IWICBitmapEncoder_Release(&This->encoder->IWICBitmapEncoder_iface); > HeapFree(GetProcessHeap(), 0, This); > } > > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: [PATCH 1/2] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromSurface (try 8).
by Marvin Aug. 18, 2015

Aug. 18, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=16101 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcr120: Implement strtof and _strtof_l (try 3)
by Henri Verbeet Aug. 18, 2015

Aug. 18, 2015

On 14 August 2015 at 04:44, Bernhard Übelacker <bernhardu(a)vr-web.de> wrote: > + /*strtof*/ > + f = p_strtof(float1, &end); > + ok(compare_float(f, 12.1, 4096), "f = %lf\n", f); Is it really that inaccurate, or did you just copy 4096 from the ddraw tests?

2 4

Re: mshtml: Wine Gecko 2.40 release.
by Austin English Aug. 18, 2015

Aug. 18, 2015

You forgot to push the tag: http://sourceforge.net/p/wine/wine-gecko/ref/master/tags/ On Tue, Aug 11, 2015 at 8:11 AM, Jacek Caban <jacek(a)codeweavers.com> wrote: > --- > dlls/appwiz.cpl/addons.c | 6 +- > dlls/mshtml/nsembed.c | 6 +- > dlls/mshtml/nsiface.idl | 114 ++++++++++++++++++++-------------- > dlls/mshtml/nsio.c | 155 > +++++++++++++++++++++++++++++++++++++---------- > 4 files changed, 199 insertions(+), 82 deletions(-) > > > > > -- -Austin

2 2

Re: ntdll: Move cookie initialization code from memory management to loader.
by Dmitry Timoshkov Aug. 18, 2015

Aug. 18, 2015

Sebastian Lackner <sebastian(a)fds-team.de> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=39040 > > Manually testing reveals that the security cookie is not initialized by NtMapViewOfSection. > > However, I guess nobody will be surprised, that this testing revealed even more differences. > In fact, the whole relocation logic is implemented at the wrong place, it should also be > moved to the loader to be compatible with modern versions of Windows (tested on Windows 7). Last attempt in trying to get some comments/attention was the following patch (which didn't receive any responce just like previous two e-mails): https://www.winehq.org/pipermail/wine-patches/2012-April/113746.html I'll resend once again if Alexandre is willing to review it it provide some suggestions. Alexandre? -- Dmitry.

2 1