January 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] server: Implement serial port read interval timeouts.
by Alexandre Julliard Jan. 21, 2016

Jan. 21, 2016

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Cc: Sebastian Lackner <sebastian(a)fds-team.de> > > Fixes https://bugs.winehq.org/show_bug.cgi?id=39875 > > There is a test program attached to the bug report. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > server/async.c | 13 +++++++++++++ > server/fd.c | 6 ++++++ > server/file.h | 2 ++ > server/serial.c | 3 +++ > 4 files changed, 24 insertions(+) That's a good start, but I think you should be able to do it through the reselect_async fd operation, without making changes to the generic async code. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] ddraw/tests: Port test_lockrect_invalid to other versions (v2).
by Marvin Jan. 21, 2016

Jan. 21, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19863 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2523: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2338: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw1) === ddraw1.c:2187: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2254: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: Updated WineHQ.org
by Theodore Dubois Jan. 20, 2016

Jan. 20, 2016

You are allowed to use table layout (i.e: display: table, display: table-cell, etc.) Just not <table> tags. ~Theodore > On Jan 20, 2016, at 11:53 AM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: > > This is why I miss using tables for HTML layout. This kind of problem was easy to solve with tables. But Nooooo tables are bad now. :-| > > I only applied my resize handler to the right side. I could apply it to the left side as well, but I think that will cause issues as the two sides fight over who should be the correct height. > > On 01/20/2016 01:44 PM, Ruslan Kabatsayev wrote: >> On Wed, Jan 20, 2016 at 10:19 PM, Jeremy Newman <jnewman(a)codeweavers.com> wrote: >>> On 01/20/2016 12:10 AM, Ruslan Kabatsayev wrote: >>>> >>>> Current version makes the Download/Support/Development/Donate block >>>> have twice the needed height with my 782px wide Chromium window, i.e. >>>> has empty space under the links. >>> >>> >>> This is by design. I added some jquery-fu to make sure that box was the same >>> height as the two boxes to the left of it. I think this looks better than a >>> larger empty black space under it. >>> >>> I do notice that at that width that the Development link does get a bit too >>> close to the edge of the box. Perhaps I should shrink down the font size by >>> a couple of px. >> >> OK, that thing was due my too old Chromium, it appears not >> reproducible with current versions. >> >> The jquery-fu though seems to not always work, namely with zoomed out >> page, see "zoomed" attachment (zoom is 50% there). This remains true >> with up-to-date Chromium and Firefox. >> >>> >>> -N > >

1 0

Updated WineHQ.org
by Jeremy Newman Jan. 20, 2016

Jan. 20, 2016

I have updated the WineHQ.org main website with a new mobile friendly (bootstrap based) theme. The goal was the preserve the old look somewhat, while bringing it up to modern standards. I've ported most of the existing translations for the home page. Sub-pages will need to be updated. Translators, please update your sub-pages. Please update download.template first. -N

3 6

WWN?
by André Hentschel Jan. 20, 2016

Jan. 20, 2016

Hi, As you might have noticed, I lost time and motivation to do WWN. Someone out there to continue it? Then I would cleanup the tools for it and guide her/him into using them.

1 0

Re: [PATCH 1/2] d3drm: Fix QueryInterface for IDirect3DRMTexture* (v2).
by Henri Verbeet Jan. 20, 2016

Jan. 20, 2016

On 19 January 2016 at 15:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid)); > - return E_NOINTERFACE; > + return CLASS_E_CLASSNOTAVAILABLE; I missed this in the original patch as well, but now the message doesn't match the return value. These two patches seem fine otherwise.

2 1

Re: [2/2] comctl32: Don't update the status if the item is no longer valid.
by Nikolay Sivov Jan. 20, 2016

Jan. 20, 2016

On 19.01.2016 17:45, Akihiro Sagawa wrote: > > This fixes https://bugs.winehq.org/show_bug.cgi?id=39677 > > Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> > --- > dlls/comctl32/listview.c | 2 +- > dlls/comctl32/tests/listview.c | 22 ++++++++++++++++++++++ > 2 files changed, 23 insertions(+), 1 deletion(-) > I think this is correct, but to make sure I fully understand what's going on. The idea is to return early from _SetItemT() for the case when old focused item index is larger than current number items in a list? >From reading surrounding code, it looks like application will receive state notifications for item number that's no longer valid, am I right? > + /* The focused item isn't updated after the invalidation */ The opposite is true, focused item is updated in this new test, from 0 to -1 (nothing focused), please fix this comment to reflect that. > comctl32: Don't update the status if the item is no longer valid. Subject needs some adjusting to, something like "Prevent invalid focuse change notifications from LVS_OWNERDATA lists", or similar. Right now it's not clear what 'status' and 'item' mean in this context. Thanks for debugging this.

2 1

Re: [PATCH] ntoskrnl.exe: Implement ZwLoadDriver and ZwUnloadDriver
by Dmitry Timoshkov Jan. 20, 2016

Jan. 20, 2016

Aric Stewart <aric(a)codeweavers.com> wrote: > Code is mostly moved from winedevice.exe > winedevice.exe now uses these functions > > With consultation and help from Damjan Jovanovic This code is broken in so many ways, so I woudn't bother listing them all. -- Dmitry.

2 1

Re: [PATCH] d2d1: Don't update target dpi if only one SetDpi() argument is zero
by Henri Verbeet Jan. 20, 2016

Jan. 20, 2016

On 19 January 2016 at 22:43, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > @@ -1436,6 +1436,8 @@ static void STDMETHODCALLTYPE d2d_d3d_render_target_SetDpi(ID2D1RenderTarget *if > dpi_x = 96.0f; > dpi_y = 96.0f; > } > + else if (dpi_x == 0.0f || dpi_y == 0.0f) > + return; > Should this affect rendertarget creation (i.e., d2d_d3d_render_target_init()) as well? What about bitmap creation?

2 1

Re: [PATCH 1/8] wined3d: Do not update surface when empty box is passed.
by Henri Verbeet Jan. 20, 2016

Jan. 20, 2016

On 19 January 2016 at 22:28, Józef Kucia <jkucia(a)codeweavers.com> wrote: > if (box->left >= box->right || box->right > sub_resource->width > - || box->top >= box->bottom || box->bottom > sub_resource->height) > + || box->top >= box->bottom || box->bottom > sub_resource->height > + || box->front >= box->back) It seems likely that you'll need to validate box->back against sub_resource->depth as well, although you may need 3D textures for a reliable test.

1 0