January 2016 - Wine-Devel - list.winehq.org

Backup of wiki.winehq.org?
by Michael Stefaniuc Jan. 11, 2016

Jan. 11, 2016

Hello Dimi, do you have a recent backup of wiki.winehq.org? The bloody spammers went nuts and even renamed the FrontPage to one of their spammer pages... I tried to move it back but MoinMoin didn't let me as it generated a new standard FrontPage. And it seems I have removed by mistake our real FrontPage before I could copy and paste its content over :( So could you please restore the FrontPage from the backup? While you are at it please block those 3 accounts used by the spammer(s). thanks bye michael

3 4

Re: [PATCH] d3dx9/test: magic isn't part of the dds structure
by Józef Kucia Jan. 11, 2016

Jan. 11, 2016

On Mon, Jan 11, 2016 at 10:46 AM, Alistair Leslie-Hughes < leslie_alistair(a)hotmail.com> wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3dx9_36/tests/surface.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/dlls/d3dx9_36/tests/surface.c b/dlls/d3dx9_36/tests/surface.c > index 183086f..5a20658 100644 > --- a/dlls/d3dx9_36/tests/surface.c > +++ b/dlls/d3dx9_36/tests/surface.c > @@ -200,7 +200,6 @@ struct dds_pixel_format > > struct dds_header > { > - DWORD magic; > DWORD size; > DWORD flags; > DWORD height; > @@ -222,7 +221,6 @@ static void fill_dds_header(struct dds_header *header) > { > memset(header, 0, sizeof(*header)); > > - header->magic = MAKEFOURCC('D','D','S',' '); > header->size = sizeof(*header); > header->flags = DDS_CAPS | DDS_WIDTH | DDS_HEIGHT | DDS_PIXELFORMAT; > header->height = 4; > @@ -250,10 +248,12 @@ static void check_dds_pixel_format_(unsigned int > line, > D3DXIMAGE_INFO info; > struct > { > + DWORD magic; > struct dds_header header; > BYTE data[256]; > } dds; > > + dds.magic = MAKEFOURCC('D','D','S',' '); > fill_dds_header(&dds.header); > dds.header.pixel_format.flags = flags; > dds.header.pixel_format.fourcc = fourcc; > @@ -281,6 +281,7 @@ static void test_dds_header_handling(void) > D3DXIMAGE_INFO info; > struct > { > + DWORD magic; > struct dds_header header; > BYTE data[4096 * 1024]; > } *dds; > @@ -399,9 +400,10 @@ static void test_dds_header_handling(void) > > for (i = 0; i < sizeof(tests) / sizeof(tests[0]); i++) > { > - DWORD file_size = sizeof(dds->header) + tests[i].pixel_data_size; > + DWORD file_size = sizeof(dds->magic) + sizeof(dds->header) + > tests[i].pixel_data_size; > assert(file_size <= sizeof(*dds)); > > + dds->magic = MAKEFOURCC('D','D','S',' '); > fill_dds_header(&dds->header); > dds->header.flags |= tests[i].flags; > dds->header.width = tests[i].width; > @@ -1235,6 +1237,7 @@ static void > test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > ID3DXBuffer *buffer; > IDirect3DSurface9 *surface; > struct dds_header *header; > + BYTE *data; > > hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, 4, 4, > D3DFMT_A8R8G8B8, D3DPOOL_SCRATCH, &surface, NULL); > if (FAILED(hr)) { > @@ -1257,9 +1260,10 @@ static void > test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > todo_wine ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); > if (SUCCEEDED(hr)) > { > - header = ID3DXBuffer_GetBufferPointer(buffer); > + data = ID3DXBuffer_GetBufferPointer(buffer); > + header = (struct dds_header *)(data + sizeof(DWORD)); > > - ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS > signature.\n"); > + ok( *(DWORD*)data == MAKEFOURCC('D','D','S',' '), "Invalid DDS > signature.\n"); > ok(header->size == 124, "Invalid DDS size %u.\n", header->size); > ok(!header->height, "Got unexpected height %u.\n", > header->height); > ok(!header->width, "Got unexpected width %u.\n", header->width); > @@ -1274,9 +1278,10 @@ static void > test_D3DXSaveSurfaceToFileInMemory(IDirect3DDevice9 *device) > > hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, > NULL, NULL); > ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr); > - header = ID3DXBuffer_GetBufferPointer(buffer); > > - ok(header->magic == MAKEFOURCC('D','D','S',' '), "Invalid DDS > signature.\n"); > + data = ID3DXBuffer_GetBufferPointer(buffer); > + header = (struct dds_header *)(data + sizeof(DWORD)); > + ok( *(DWORD*)data == MAKEFOURCC('D','D','S',' '), "Invalid DDS > signature.\n"); > ok(header->size == 124, "Invalid DDS size %u.\n", header->size); > ok(header->height == 4, "Got unexpected height %u.\n", > header->height); > ok(header->width == 4, "Got unexpected width %u.\n", header->width); > -- > 2.6.4 > > > > What's the point of this change? It doesn't fix anything and doesn't make code more readable. If the file signature isn't included in the DDS header size it doesn't necessarily mean we have to move it out of struct dds_header.

2 1

Re: [PATCH 2/3] xaudio2_7: Move source to shared xaudio2 directory
by Alistair Leslie-Hughes Jan. 11, 2016

Jan. 11, 2016

Hi Andrew, On 09/01/16 04:03, Andrew Eikum wrote: > Currently, all of Wine's xaudio2 modules forward their implementations > to xaudio2_7. This fails when the user installs native xaudio2_7 and > tries to use a built-in xaudio DLL like xaudio2_8. Instead, we should > use the shared source mechanism to build each xaudio DLL independent > of the others. > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > > This is the first patch in a long series to move all 22 xaudio DLLs to > use shared source. These first two show the idea; the following > patches move all xaudio2_* DLLs, then xapofx1_*, then x3daudio1_*. > Next, there are a few cleanup patches to remove the run-time version > logic, since we can now do it at compile-time. > > dlls/{xaudio2_7 => xaudio2}/compat.c | 0 > dlls/{xaudio2_7 => xaudio2}/xapofx.c | 0 > dlls/{xaudio2_7 => xaudio2}/xaudio_classes.idl | 0 > dlls/{xaudio2_7 => xaudio2}/xaudio_dll.c | 0 > dlls/{xaudio2_7 => xaudio2}/xaudio_private.h | 0 > dlls/xaudio2_7/Makefile.in | 2 ++ > 6 files changed, 2 insertions(+) Whats the reason behind moving the source into a separate directory? It's not needed, have a look d3dcompiler_46 which uses the source in d3dcompiler_43. If you have main.c in each directory the build script is smart enough to compile the correct one, if that is your concern. Best Regards Alistair Leslie-Hughes

3 2

Re: shell32/tests: Check the hProcess field when ShellExecuteEx() fails.
by Marvin Jan. 11, 2016

Jan. 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19588 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt2A18.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt2A18.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt2A18.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt2A18.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2302: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde")]' shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2290: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtFF28.tmp\test file.sde") failed: rc=29 err=2

2 1

Re: [1/2] bcrypt: Add support for SHA hashes on Linux using Nettle.
by Damjan Jovanovic Jan. 11, 2016

Jan. 11, 2016

Hi I don't believe it's possible to use Nettle in Wine right now, due to its copyright license: "Nettle is dual licenced under the GNU General Public License version 2 or later, and the GNU Lesser General Public License version 3 or later. When using Nettle, you must comply fully with all conditions of at least one of these licenses." ( http://www.lysator.liu.se/~nisse/nettle/nettle.html#Copyright) Wine is only LGPLv2+, which isn't compatible with either. Besides, why not GnuTLS or Mozilla's NSS? Regards Damjan On Mon, Jan 11, 2016 at 12:25 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > v2: Load Nettle dynamically. > > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > configure.ac | 13 +++ > dlls/bcrypt/Makefile.in | 1 + > dlls/bcrypt/bcrypt_main.c | 199 > ++++++++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 208 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 2b1dd81..32b09ad 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -60,6 +60,7 @@ AC_ARG_WITH(ldap, > AS_HELP_STRING([--without-ldap],[do not use LDAP]), > [if test "x$withval" = "xno"; then ac_cv_header_ldap_h=no; > ac_cv_header_lber_h=no; fi]) > AC_ARG_WITH(mpg123, AS_HELP_STRING([--without-mpg123],[do not use the > mpg123 library])) > AC_ARG_WITH(netapi, AS_HELP_STRING([--without-netapi],[do not use the > Samba NetAPI library])) > +AC_ARG_WITH(nettle, AS_HELP_STRING([--without-nettle],[do not use > Nettle])) > AC_ARG_WITH(openal, AS_HELP_STRING([--without-openal],[do not use > OpenAL]), > [if test "x$withval" = "xno"; then ac_cv_header_AL_al_h=no; > ac_cv_header_OpenAL_al_h=no; fi]) > AC_ARG_WITH(opencl, AS_HELP_STRING([--without-opencl],[do not use > OpenCL]), > @@ -1274,6 +1275,18 @@ fi > WINE_WARNING_WITH(gnutls,[test "x$ac_cv_lib_soname_gnutls" = "x"], > [libgnutls ${notice_platform}development files not > found, no schannel support.]) > > +dnl **** Check for libnettle *** > +if test "x$with_nettle" != "xno" > +then > + WINE_PACKAGE_FLAGS(NETTLE,[nettle],,,, > + [AC_CHECK_HEADER([nettle/sha2.h], > + > [WINE_CHECK_SONAME(nettle,nettle_sha512_init,,[NETTLE_CFLAGS=""],[$NETTLE_LIBS])], > + [NETTLE_CFLAGS=""])]) > +fi > +WINE_WARNING_WITH(nettle,[test "x$ac_cv_lib_soname_nettle" = "x" -a \ > + > "x$ac_cv_header_CommonCrypto_CommonDigest_h" != "xyes"], > + [libnettle ${notice_platform}development files not > found, no crypto support (bcrypt).]) > + > dnl **** Check which curses lib to use *** > CURSES_LIBS="" > if test "$ac_cv_header_ncurses_h" = "yes" > diff --git a/dlls/bcrypt/Makefile.in b/dlls/bcrypt/Makefile.in > index 87e1429..e83cbab 100644 > --- a/dlls/bcrypt/Makefile.in > +++ b/dlls/bcrypt/Makefile.in > @@ -1,5 +1,6 @@ > MODULE = bcrypt.dll > IMPORTS = advapi32 > +EXTRAINCL = $(NETTLE_CFLAGS) > > C_SRCS = \ > bcrypt_main.c > diff --git a/dlls/bcrypt/bcrypt_main.c b/dlls/bcrypt/bcrypt_main.c > index 9cc5227..e66a70f 100644 > --- a/dlls/bcrypt/bcrypt_main.c > +++ b/dlls/bcrypt/bcrypt_main.c > @@ -18,10 +18,14 @@ > */ > > #include "config.h" > +#include "wine/port.h" > > #include <stdarg.h> > #ifdef HAVE_COMMONCRYPTO_COMMONDIGEST_H > #include <CommonCrypto/CommonDigest.h> > +#elif defined(SONAME_LIBNETTLE) > +#include <nettle/sha1.h> > +#include <nettle/sha2.h> > #endif > > #include "ntstatus.h" > @@ -32,10 +36,73 @@ > #include "bcrypt.h" > > #include "wine/debug.h" > +#include "wine/library.h" > #include "wine/unicode.h" > > WINE_DEFAULT_DEBUG_CHANNEL(bcrypt); > > +static HINSTANCE instance; > + > +#if defined(SONAME_LIBNETTLE) && > !defined(HAVE_COMMONCRYPTO_COMMONDIGEST_H) > +WINE_DECLARE_DEBUG_CHANNEL(winediag); > + > +static void *libnettle_handle; > +#define MAKE_FUNCPTR(f) static typeof(f) * p##f > +MAKE_FUNCPTR(nettle_sha1_init); > +MAKE_FUNCPTR(nettle_sha256_init); > +MAKE_FUNCPTR(nettle_sha384_init); > +MAKE_FUNCPTR(nettle_sha512_init); > +MAKE_FUNCPTR(nettle_sha1_update); > +MAKE_FUNCPTR(nettle_sha256_update); > +MAKE_FUNCPTR(nettle_sha512_update); > +MAKE_FUNCPTR(nettle_sha1_digest); > +MAKE_FUNCPTR(nettle_sha256_digest); > +MAKE_FUNCPTR(nettle_sha384_digest); > +MAKE_FUNCPTR(nettle_sha512_digest); > +#undef MAKE_FUNCPTR > + > +static BOOL nettle_init(void) > +{ > + if (!(libnettle_handle = wine_dlopen( SONAME_LIBNETTLE, RTLD_NOW, > NULL, 0 ))) > + { > + ERR_(winediag)( "failed to load libnettle, no crypto support\n" ); > + return FALSE; > + } > + > +#define LOAD_FUNCPTR(f) \ > + if (!(p##f = wine_dlsym( libnettle_handle, #f, NULL, 0 ))) \ > + { \ > + ERR( "failed to load %s\n", #f ); \ > + goto fail; \ > + } > + > + LOAD_FUNCPTR(nettle_sha1_init) > + LOAD_FUNCPTR(nettle_sha256_init) > + LOAD_FUNCPTR(nettle_sha384_init) > + LOAD_FUNCPTR(nettle_sha512_init) > + LOAD_FUNCPTR(nettle_sha1_update) > + LOAD_FUNCPTR(nettle_sha256_update) > + LOAD_FUNCPTR(nettle_sha512_update) > + LOAD_FUNCPTR(nettle_sha1_digest) > + LOAD_FUNCPTR(nettle_sha256_digest) > + LOAD_FUNCPTR(nettle_sha384_digest) > + LOAD_FUNCPTR(nettle_sha512_digest) > +#undef LOAD_FUNCPTR > + return TRUE; > + > +fail: > + wine_dlclose( libnettle_handle, NULL, 0 ); > + libnettle_handle = NULL; > + return FALSE; > +} > + > +static void nettle_deinit(void) > +{ > + wine_dlclose( libnettle_handle, NULL, 0 ); > + libnettle_handle = NULL; > +} > +#endif /* SONAME_LIBNETTLE && !HAVE_COMMONCRYPTO_COMMONDIGEST_H */ > + > NTSTATUS WINAPI BCryptEnumAlgorithms(ULONG dwAlgOperations, ULONG > *pAlgCount, > BCRYPT_ALGORITHM_IDENTIFIER > **ppAlgList, ULONG dwFlags) > { > @@ -203,7 +270,7 @@ static NTSTATUS hash_init( struct hash *hash ) > return STATUS_SUCCESS; > } > > -static void hash_update( struct hash *hash, UCHAR *input, ULONG size ) > +static NTSTATUS hash_update( struct hash *hash, UCHAR *input, ULONG size ) > { > switch (hash->alg_id) > { > @@ -225,8 +292,9 @@ static void hash_update( struct hash *hash, UCHAR > *input, ULONG size ) > > default: > ERR( "unhandled id %u\n", hash->alg_id ); > - break; > + return STATUS_NOT_IMPLEMENTED; > } > + return STATUS_SUCCESS; > } > > static NTSTATUS hash_finish( struct hash *hash, UCHAR *output, ULONG size > ) > @@ -255,6 +323,105 @@ static NTSTATUS hash_finish( struct hash *hash, > UCHAR *output, ULONG size ) > } > return STATUS_SUCCESS; > } > +#elif defined(SONAME_LIBNETTLE) > +struct hash > +{ > + struct object hdr; > + enum alg_id alg_id; > + union > + { > + struct sha1_ctx sha1_ctx; > + struct sha256_ctx sha256_ctx; > + struct sha512_ctx sha512_ctx; > + } u; > +}; > + > +static NTSTATUS hash_init( struct hash *hash ) > +{ > + if (!libnettle_handle) return STATUS_NOT_IMPLEMENTED; > + > + switch (hash->alg_id) > + { > + case ALG_ID_SHA1: > + pnettle_sha1_init( &hash->u.sha1_ctx ); > + break; > + > + case ALG_ID_SHA256: > + pnettle_sha256_init( &hash->u.sha256_ctx ); > + break; > + > + case ALG_ID_SHA384: > + pnettle_sha384_init( &hash->u.sha512_ctx ); > + break; > + > + case ALG_ID_SHA512: > + pnettle_sha512_init( &hash->u.sha512_ctx ); > + break; > + > + default: > + ERR( "unhandled id %u\n", hash->alg_id ); > + return STATUS_NOT_IMPLEMENTED; > + } > + return STATUS_SUCCESS; > +} > + > +static NTSTATUS hash_update( struct hash *hash, UCHAR *input, ULONG size ) > +{ > + if (!libnettle_handle) return STATUS_NOT_IMPLEMENTED; > + > + switch (hash->alg_id) > + { > + case ALG_ID_SHA1: > + pnettle_sha1_update( &hash->u.sha1_ctx, size, input ); > + break; > + > + case ALG_ID_SHA256: > + pnettle_sha256_update( &hash->u.sha256_ctx, size, input ); > + break; > + > + case ALG_ID_SHA384: > + pnettle_sha512_update( &hash->u.sha512_ctx, size, input ); > + break; > + > + case ALG_ID_SHA512: > + pnettle_sha512_update( &hash->u.sha512_ctx, size, input ); > + break; > + > + default: > + ERR( "unhandled id %u\n", hash->alg_id ); > + return STATUS_NOT_IMPLEMENTED; > + } > + return STATUS_SUCCESS; > +} > + > +static NTSTATUS hash_finish( struct hash *hash, UCHAR *output, ULONG size > ) > +{ > + if (!libnettle_handle) return STATUS_NOT_IMPLEMENTED; > + > + switch (hash->alg_id) > + { > + case ALG_ID_SHA1: > + pnettle_sha1_digest( &hash->u.sha1_ctx, size, output ); > + break; > + > + case ALG_ID_SHA256: > + pnettle_sha256_digest( &hash->u.sha256_ctx, size, output ); > + break; > + > + case ALG_ID_SHA384: > + pnettle_sha384_digest( &hash->u.sha512_ctx, size, output ); > + break; > + > + case ALG_ID_SHA512: > + pnettle_sha512_digest( &hash->u.sha512_ctx, size, output ); > + break; > + > + default: > + ERR( "unhandled id %u\n", hash->alg_id ); > + return STATUS_NOT_IMPLEMENTED; > + } > + return STATUS_SUCCESS; > +} > #else > struct hash > { > @@ -268,9 +435,10 @@ static NTSTATUS hash_init( struct hash *hash ) > return STATUS_NOT_IMPLEMENTED; > } > > -static void hash_update( struct hash *hash, UCHAR *input, ULONG size ) > +static NTSTATUS hash_update( struct hash *hash, UCHAR *input, ULONG size ) > { > ERR( "support for hashes not available at build time\n" ); > + return STATUS_NOT_IMPLEMENTED; > } > > static NTSTATUS hash_finish( struct hash *hash, UCHAR *output, ULONG size > ) > @@ -484,8 +652,7 @@ NTSTATUS WINAPI BCryptHashData( BCRYPT_HASH_HANDLE > handle, UCHAR *input, ULONG s > if (!hash || hash->hdr.magic != MAGIC_HASH) return > STATUS_INVALID_HANDLE; > if (!input) return STATUS_INVALID_PARAMETER; > > - hash_update( hash, input, size ); > - return STATUS_SUCCESS; > + return hash_update( hash, input, size ); > } > > NTSTATUS WINAPI BCryptFinishHash( BCRYPT_HASH_HANDLE handle, UCHAR > *output, ULONG size, ULONG flags ) > @@ -499,3 +666,25 @@ NTSTATUS WINAPI BCryptFinishHash( BCRYPT_HASH_HANDLE > handle, UCHAR *output, ULON > > return hash_finish( hash, output, size ); > } > + > +BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) > +{ > + switch (reason) > + { > + case DLL_PROCESS_ATTACH: > + instance = hinst; > + DisableThreadLibraryCalls( hinst ); > +#if defined(SONAME_LIBNETTLE) && > !defined(HAVE_COMMONCRYPTO_COMMONDIGEST_H) > + nettle_init(); > +#endif > + break; > + > + case DLL_PROCESS_DETACH: > + if (reserved) break; > +#if defined(SONAME_LIBNETTLE) && > !defined(HAVE_COMMONCRYPTO_COMMONDIGEST_H) > + nettle_deinit(); > +#endif > + break; > + } > + return TRUE; > +} > -- > 2.6.4 > > > >

3 2

Re: [PATCH 1/2] dnsapi: migrating to res_nquery and partial DnsQueryEx implementation
by Hans Leidekker Jan. 11, 2016

Jan. 11, 2016

On Sun, 2016-01-10 at 16:55 +0300, Donat Enikeev wrote: > There was a note about res_query bug in MacOSX 10.4: > /* call res_init() just once because of a bug in Mac OS X 10.4, call once per thread on systems that have per-thread _res */ > > I've removed it while migratign to res_nquery, let me please clarify reasons: > > 1. I found no proof that bug is fair for res_nquery for MacOSX 10.4 > 2. I believe that generally res_init was not designed to be reliable under several calls > Quote from manual: "res_init() and res_query() use some static (global) state stored in the _res structure, rendering these functions non-thread-safe" That information is outdated, _res is a per-thread variable on modern systems. In any case, you should put the implementation of DnsQueryEx in a separate patch.

1 0

Re: hidclass.sys: Properly quit hid_device_thread when both completion event and halt event are signaled (try 2)
by Qian Hong Jan. 11, 2016

Jan. 11, 2016

The patch looks good to me, Aric, would you mind sign off the patch? I'm glad to sign off, but I'm not qualified enough :) On Tue, Dec 29, 2015 at 11:19 AM, Changhui LIU <liuchanghui(a)linuxdeepin.com> wrote: > Superseded patch 117285. > > Try 2: Fixed IRP completion event will not be signaled if a driver is > misbehaving and is blocked or crashes while processing an IRP. > -- Regards, Qian Hong - http://www.winehq.org

5 7

Re: shell32/tests: Fix the shortcut vs. class interaction test.
by Marvin Jan. 11, 2016

Jan. 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19590 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt11FC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt11FC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt11FC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt11FC.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2300: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde")]' shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2288: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt7F55.tmp\test file.sde") failed: rc=29 err=2

1 0

Re: shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
by Marvin Jan. 11, 2016

Jan. 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19587 Your paranoid android. === w1064 (32 bit shlexec) === shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2299: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde")]' shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE3FF.tmp\test file.sde") failed: rc=29 err=2 === w1064 (64 bit shlexec) === shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1846.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1846.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1846.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1846.tmp\test file.sde") failed: rc=29 err=2

1 0

Re: [01/12] shell32/tests: The expectedArgs parameter of the DDE tests is an argument count, not a boolean.
by Marvin Jan. 11, 2016

Jan. 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19403 Your paranoid android. === wxppro (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w2003std (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === wvistau64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w2008s64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w7u (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w7pro64 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w8 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w864 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w1064 (32 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2299: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde")]' shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wtE4CD.tmp\test file.sde") failed: rc=29 err=2 === wvistau64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w2008s64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w7pro64 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w864 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 === w1064 (64 bit shlexec) === shlexec.c:2294: Test failed: argcA expected 3, but got 4 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2287: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt91AC.tmp\test file.sde") failed: rc=29 err=2

3 3