November 2016 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

Re: include: Avoid overflow (warning) in RGBA_MAKE.
by Dmitry Timoshkov Feb. 26, 2017

Feb. 26, 2017

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > --- a/include/d3dtypes.h > +++ b/include/d3dtypes.h > @@ -53,7 +53,7 @@ typedef LONG D3DFIXED; > #define RGBA_GETRED(rgb) (((rgb) >> 16) & 0xff) > #define RGBA_GETGREEN(rgb) (((rgb) >> 8) & 0xff) > #define RGBA_GETBLUE(rgb) ((rgb) & 0xff) > -#define RGBA_MAKE(r, g, b, a) ((D3DCOLOR) (((a) << 24) | ((r) << 16) | ((g) << 8) | (b))) > +#define RGBA_MAKE(r, g, b, a) ((D3DCOLOR) (((unsigned)(a) << 24) | ((r) << 16) | ((g) << 8) | (b))) This is a public header, probably you need to fix the callers of this macro instead. -- Dmitry.

3 4

Re: kernel32: Avoid two potential buffer overflows of cStr in create_hardware_branch.
by Sebastian Lackner Feb. 12, 2017

Feb. 12, 2017

On 08.10.2016 22:31, Gerald Pfeifer wrote: > + char cStr[sizeof(dent->d_name)+sizeof(procname_ide_media)], http://man7.org/linux/man-pages/man3/readdir.3.html says: """The standard also notes that the use of sizeof(d_name) is incorrect; use strlen(d_name) instead. (On some systems, this field is defined as char d_name[1]!)""" This means your solution will not work on all systems.

3 4

RE: msvcirt: Avoid "array subscript above array bounds" warnings in test_ostrstream and test_strstreambuf.
by Filip Frackiewicz Dec. 24, 2016

Dec. 24, 2016

Hi Gerald, In wine-1.9.22-129-g906e770 I see the array subscript warnings in the following location: ../../../../wine/dlls/msvcirt/tests/msvcirt.c: In function ‘test_strstream’: ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6861:34: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.ebuf == buffer + 0x7fffffff || pssb->base.ebuf == (char*) -1, ~~~~~~~^~~~~~~~~~~~ ../../../../wine/dlls/msvcirt/tests/msvcirt.c:6868:35: warning: array subscript is above array bounds [-Warray-bounds] ok(pssb->base.epptr == buffer + 0x7fffffff || pssb->base.epptr == (char*) -1, Thought I'd let you know as I just encountered this while compiling the 64-bit version of Wine. Cheers, Filip

2 1

Re: [2/2 v2] winex11: Use XIAllDevices to select for XI_RawMotion
by Henri Verbeet Dec. 12, 2016

Dec. 12, 2016

On 18 November 2016 at 12:43, Carlos Garnacho <carlosg(a)gnome.org> wrote: > Change the strategy used to get raw motion from slave devices. Instead > of selecting for XI2 events for every slave device individually, do it > for XIAllDevices, and store the current device's relative X/Y valuators > so they can be quickly looked up in the XI_RawMotion events received. > I think this makes sense, and in my (limited) testing this correctly handles the case of attaching a new input device. I do have a few minor comments though: > +static void update_relative_valuators(XIAnyClassInfo **valuators, > + int n_valuators) This should probably just be "static void update_relative_valuators( XIAnyClassInfo **valuators, int n_valuators )" > + free( thread_data->x_rel_valuator ); > + free( thread_data->y_rel_valuator ); ... > + thread_data->x_rel_valuator = malloc( sizeof(XIValuatorClassInfo) ); > + memcpy ( thread_data->x_rel_valuator, class, sizeof(XIValuatorClassInfo) ); We generally avoid malloc()/free() in Wine code and use HeapAlloc()/HeapFree() instead. The main consideration has to do with the way address space is allocated for Win32 applications, effectively making malloc() space a bit more scarce than HeapAlloc() space. We'd probably prefer the sizeof as "sizeof(*thread_data->x_rel_valuator)", or perhaps "sizeof(*class)". I'm not sure how much we should worry about this in practice, but when multiple slaves are attached to the master, and they're not completely idle, update_relative_valuators() can end up getting called quite a bit. It doesn't seem hard to at least do the allocation only once, and only update the data in update_relative_valuators(). Perhaps it's also fine the way it is though. > - XISetMask( mask_bits, XI_ButtonPress ); This was added intentionally (see also https://bugs.winehq.org/show_bug.cgi?id=27522#c18) Perhaps it's no longer needed, but that would need to be a separate patch. > + pointer_info = pXIQueryDevice( data->display, data->xi2_core_pointer, &count ); > + update_relative_valuators( pointer_info->classes, pointer_info->num_classes ); > + pXIFreeDeviceInfo( pointer_info ); ... > + pXISelectEvents( data->display, DefaultRootWindow( data->display ), &mask, 1 ); I'm not too concerned about it, but can this race? I.e. switching slaves between when update_relative_valuators() is called above and when XISelectEvents() takes effect. Applies to querying the devices list as well. > + if (thread_data->xi2_current_slave == 0) We'd typically write that "if (!thread_data->xi2_current_slave)", although I don't think anyone would be overly concerned about it. > + for (i = 0; i <= max ( x_rel->number, y_rel->number ); i++) > + { > +»······if (!XIMaskIsSet( event->valuators.mask, i )) continue; > +»······val = *values++; > +»······if (i == x_rel->number) > +»······{ > + input.u.mi.dx = dx = val; > +»······ if (x_rel->min < x_rel->max) > + input.u.mi.dx = val * (virtual_rect.right - virtual_rect.left) > + / (x_rel->max - x_rel->min); > +»······} > +»······if (i == y_rel->number) > +»······{ > +»······ input.u.mi.dy = dy = val; > +»······ if (y_rel->min < y_rel->max) You're using tabs for indentation here.

2 1

Re: [v2] preloader: Allow a debugger to find ld.so's rendezvous-struct
by Alexandre Julliard Dec. 11, 2016

Dec. 11, 2016

Keno Fischer <keno(a)juliacomputing.com> writes: > @@ -123,6 +123,18 @@ static struct wine_preload_info preload_info[] = > { 0, 0 } /* end of list */ > }; > > +/* A fake .dynamic section through which we can inform the debugger of the > + address of the chain-loaded dynamic linker's rendezvous struct */ > +__asm__( > +".section .dynamic,\"aw\"\n" > +".global _DYNAMIC\n" > +"_DYNAMIC: .quad 21\n" // DT_DEBUG > +".quad 0\n" > +".quad 0\n" > +".quad 0\n" > +".previous\n" > +); This is causing a warning here: gcc -m32 -c -o preloader.o preloader.c -I. -I../include -D__WINESRC__ -fno-builtin -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Werror -g -O2 -fno-diagnostics-show-caret {standard input}: Assembler messages: {standard input}:5: Warning: setting incorrect section attributes for .dynamic -- Alexandre Julliard julliard(a)winehq.org

2 6

WineTest reference Linux machines
by Francois Gouget Dec. 9, 2016

Dec. 9, 2016

CodeWeavers has two machines that I have been running WineTest on, in Linux, Windows 8.1 and Windows 10, in 32 and 64 bit. They are identical except for the graphics cards: AMD HD6800 for cw1 and Nvidia GTX560 for cw2. During WineConf we decided that these should be able to run WineTest on Linux without any errors and thus become reference WineTest machines. We are not quite there yet so here is the current status starting with the 32 bit tests. * crypt32:chain Some of the certificates used by this test are present on Windows but missing on Linux, thus causing the error. Hans is looking into it and either the test will be modified to use other certificates present on both platforms, or the certificates will be added to these boxes. In the latter case this will be documented on the Wiki: https://wiki.winehq.org/Conformance_Tests#Running_WineTest_in_Wine * d2d1:d2d1, d3d10core:device These tests only fails on the GTX560. The reason is unknown. We need someone to look into it. * d3d8:device, d3d9:d3d9ex, d3d9:device, d3d9:visual Matteo fixed the radeon driver configuration and is looking into these failures, at least for the HD6800 case. It is possible some of these failures are caused by the window manager (currently xfwm from Xfce). Replacing the windows manager is no issue, we just need to know which one to pick. fvwm2? * kernel32:console, kernel32:process These failures happen because the tests are being run from cron, with their output redirected to a log file and thus they have no real terminal to work with. Interestingly the 64 bit tests are not failing. Vincent is investigating whether the tests should be modified or whether the test should be run from an xterm, screen session or some equivalent. * user32:winstation winstation.c:959: Test succeeded inside todo block: unexpected foreground window (nil) The cause for this failure has not been identified. Another window manager issue? * ws2_32:sock sock.c:2811: Test succeeded inside todo block: Test[2]: expected 0, got 0 We need someone to investigate this failure. It looks like it's random and relatively rare. Some tests just cannot be made to work reliably on Linux due to the asynchronous nature of X11 messaging. So another decision that was made that tests should be run up to 3 times until they succeed. It's not entirely clear if that applies to all tests or just to specific tests that are known to be flaky. The practical upshot is that people running 'make test' can re-run it a couple of times if it fails at first, and if it succeeds after 3 tries then you can consider that it's all good. These machines run WineTest so the results can be uploaded to test.winehq.org (with the relevant header describing the machine, the dlls, etc). So WineTest may need to be updated to deal with flaky tests according to policy. Here is more detail about these machines: * i7-2600K (4 cores+hyperthreading at 3.4GHz) * 16 GB of RAM * 768 GB of spinning disk * Debian 8.2 64 bit * cw1: AMD HD6800 running the open-source radeon driver. * cw2: Nvidia GTX560 running the proprietary driver. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

Serial port sniffing problem
by Bill Lionheart Dec. 6, 2016

Dec. 6, 2016

Using Wine version 1.8 on Ubuntu 14.04.5 I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a serial interface. The device is supplied with a Prolific USB serial converter which comes up as /dev/ttyUSB0 which I have sym linked to COM1 The bundled GPRS tracker config software installs and runs OK under Wine. But my attempts to sniff the serial port traffic fails using all the standard Linux methods I know. I also tried using the Windows program Serial Port Monitor under Wine http://www.eltima.com/products/serial-port-monitor/ . This program says it cannot detect any serial ports. Under Windows 7 the config program and Serial Port Monitor both work well and I can intercept all the serial traffic Any ideas please folks? Bill

3 4

Re: [PATCH] user32: Handle WM_SYSKEYDOWN in MENU_SuspendPopup.
by Alexandre Julliard Dec. 5, 2016

Dec. 5, 2016

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Technically, all the stuff about WM_SYSKEYDOWN is unnecessary. All we > really need to do is fix the error handling, or remove this questionable > optimization altogether. I'm not sure what you mean by that. Also you are essentially reverting d75b0cdc986f464f3067767cd53aca6b85feb366, I'd like to hear some justification for that. -- Alexandre Julliard julliard(a)winehq.org

2 5

Windows 2008 does not support MP3 correctly in msacm32.dll?
by Bruno Jesus Dec. 4, 2016

Dec. 4, 2016

Hi, in an attempt to add MP3 tests from Michael Müller it looks like the only machine that has trouble is Windows 2008 [1]. Around half of the tests are rejected while in all other versions it worked fine. Could there be a simple explanation to this? [1] https://testbot.winehq.org/JobDetails.pl?Key=27009 Best wishes, Bruno

2 2

Re: [v2 1/2] wined3d: Implement primitive restart index.
by Józef Kucia Dec. 4, 2016

Dec. 4, 2016

On Fri, Nov 18, 2016 at 4:44 AM, Andrew Wesie <awesie(a)gmail.com> wrote: > @@ -8602,6 +8602,16 @@ static void shader_glsl_init_context_state(struct wined3d_context *context) > > gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE); > checkGLcall("GL_PROGRAM_POINT_SIZE"); > + if (gl_info->supported[ARB_ES3_COMPATIBILITY]) > + { > + /* We prefer this method because it correctly handles 16-bit and 32-bit indices. */ > + gl_info->gl_ops.gl.p_glEnable(GL_PRIMITIVE_RESTART_FIXED_INDEX); > + checkGLcall("GL_PRIMITIVE_RESTART_FIXED_INDEX"); > + } Is it really safe to enable the primitive restart for all D3D versions? Shouldn't we enable it just for D3D10+? See, e.g., e47a735f762ebe1545bb366c7e9e2b90db7c7f80, if it's decided that this should be enabled just for D3D10+. > + else > + { > + WARN("Missing support for primitive restart index.\n"); > + } This is not important, but ideally this would be a FIXME() for D3D10+ feature level >= 10_0 and nothing otherwise. > } > > static void shader_glsl_get_caps(const struct wined3d_gl_info *gl_info, struct shader_caps *caps) > diff --git a/dlls/wined3d/wined3d_gl.h b/dlls/wined3d/wined3d_gl.h > index b71190d..7bd2d6a 100644 > --- a/dlls/wined3d/wined3d_gl.h > +++ b/dlls/wined3d/wined3d_gl.h > @@ -55,6 +55,7 @@ enum wined3d_gl_extension > ARB_DRAW_ELEMENTS_BASE_VERTEX, > ARB_DRAW_INSTANCED, > ARB_ES2_COMPATIBILITY, > + ARB_ES3_COMPATIBILITY, > ARB_EXPLICIT_ATTRIB_LOCATION, > ARB_FRAGMENT_COORD_CONVENTIONS, > ARB_FRAGMENT_PROGRAM, The extension has to be also added to the "core_extensions" table.

2 2

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by André Hentschel Dec. 2, 2016

Dec. 2, 2016

Hi, comments inline Am 22.11.2016 um 20:46 schrieb Jeremy White: > -ULONG WINAPI MAPISendMail(LHANDLE session, ULONG_PTR uiparam, > +static ULONG BrowserSendMail(LHANDLE session, ULONG_PTR uiparam, > lpMapiMessage message, FLAGS flags, ULONG reserved) > { > ULONG ret = MAPI_E_FAILURE; > @@ -291,6 +370,129 @@ exit: > return ret; > } Do you need all those parameters? > +/************************************************************************** > + * XDGSendMail > + * > + * Send a message using xdg-email mail client. > + * > + */ > +ULONG XDGSendMail(LHANDLE session, ULONG_PTR uiparam, > + lpMapiMessage message, FLAGS flags, ULONG reserved) Same here Also should be a static function > + > + TRACE("(0x%08lx 0x%08lx %p 0x%08x 0x%08x)\n", session, uiparam, message, flags, reserved); I'd keep the TRACE in the WINAPI function > + > + if (!message) > + return MAPI_E_FAILURE; maybe this check, too > + max_args = 1 + (2 + message->nRecipCount + message->nFileCount) * 2; > + argv = HeapAlloc(GetProcessHeap(), 0, (max_args + 1) * sizeof(*argv)); > + if (!argv) > + return MAPI_E_INSUFFICIENT_MEMORY; > + > + ret = add_argument(argv, &argc, "xdg-email", NULL); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + > + if (message->lpOriginator) > + TRACE("From: %s (unused)\n", debugstr_a(message->lpOriginator->lpszAddress)); Why is the TRACE message different from the original function? > + > + for (i = 0; i < message->nRecipCount; i++) > + { > + if (!message->lpRecips) > + { > + WARN("Recipient %d missing\n", i); > + ret = MAPI_E_FAILURE; > + goto exit; > + } > + > + if (message->lpRecips[i].lpszAddress) > + { > + ret = add_target(argv, &argc, message->lpRecips[i].ulRecipClass, add_target is only used in one place, no need for a helper function IMO > + message->lpRecips[i].lpszAddress); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + } > + else > + FIXME("Name resolution and entry identifiers not supported\n"); > + } > + > + for (i = 0; i < message->nFileCount; i++) > + { > + TRACE("File Path: %s, name %s\n", debugstr_a(message->lpFiles[i].lpszPathName), > + debugstr_a(message->lpFiles[i].lpszFileName)); > + ret = add_file(argv, &argc, message->lpFiles[i].lpszPathName, message->lpFiles[i].lpszFileName); Same for add_file Hope that helps

2 1

Call for tests - GNU/Linux & specially OSX - iphlpapi
by Bruno Jesus Dec. 1, 2016

Dec. 1, 2016

Hello all, in order to exercise an IP ordering problem from bug 40247 (OSX) [1] I would like to request help for testing the crosstest at [2]. Valid testers must have at least 1 network interface with a valid IP and a the loopback interface up. A good test should result in 1 error, if not send me the results anyway, only the traces from lines 262 and 266 are needed (first in the log, 10 lines should be enough). If you find the lines I'm expecting just paste them, if you don't have patience just attach the whole results, pĺease. Sample output: bruno(a)Note:~/programs/wine32/dlls/iphlpapi/tests$ wine iphlpapi_crosstest.exe iphlpapi.c:262: Entry[0]: addr 127.0.0.1, dwIndex 1, wType 0x1 iphlpapi.c:266: Test failed: Loopback interface wrongly at position 0/3 iphlpapi.c:262: Entry[1]: addr 192.168.1.34, dwIndex 3, wType 0x1 iphlpapi.c:262: Entry[2]: addr 192.168.112.1, dwIndex 4, wType 0x1 iphlpapi.c:262: Entry[3]: addr 192.168.27.1, dwIndex 5, wType 0x1 [1] https://bugs.winehq.org/show_bug.cgi?id=40247 [2] https://testbot.winehq.org/JobDetails.pl?Key=27012 Thanks in advance, Bruno

2 2

Testing Direct3D
by Fabian Maurer Dec. 1, 2016

Dec. 1, 2016

Hello Wine-Devel, It might be a stupid question, but how do you test the Direct3D implementation? I don't mean the conformance tests, these too need to get the data somewhere. So you probably have a windows running somewhere. I currently I don't have a windows machine to test on though. Only a Virtualbox VM, and this doesn't offer (reliable) 3D acceleration for DX > 9. Do you have your own windows machine dedicated to this, or how do you do it?

3 5

Re: [PATCH 1/2] server: Store async list in process object and use that to find async in cansel_async request.
by Alexandre Julliard Dec. 1, 2016

Dec. 1, 2016

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -614,6 +615,7 @@ static void process_destroy( struct object *obj ) > > /* we can't have a thread remaining */ > assert( list_empty( &process->thread_list )); > + assert( list_empty( &process->asyncs )); I don't think that this is guaranteed, I believe that there can still be asyncs in the queues of shared files. We'd probably need to clear them explicitly at process exit. -- Alexandre Julliard julliard(a)winehq.org

2 4

wine-1.8.6-rc1 Available
by Michael Stefaniuc Nov. 30, 2016

Nov. 30, 2016

Hello guys, I have pushed wine-1.8.6-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ After introducing a regression into 1.8.5 I got a little bit risk averse so just 51 cherry-picks this time. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. But that might change as I'm travelling at the moment. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Fix a regression introduced in 1.8.5 (#41627) - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.6 (total 35): 27671 ComboFix fails to install 29661 wineboot unable to create win32 prefix if the directory already exists 29916 ElsterFormular cannot make use of default PDF viewer (e. g. Okular) 30368 AMD Radeon 6480g detected as ATI Radeon 3200 30673 Smart Cutter 1.9.4 crashes when the button OPEN is pressed 32694 NVIDIA GTX 690 not in the list of recognized cards. 33636 wine cmd: invalid behaviour of '&' operator 35025 Max Payne 2 Demo: checkboxes in options dialog have missing window styles 35658 Anthem Room Correction 2 v1.0.1 reports 'Unknown COM error 0x80004001' (needs IAudioEndpointVolume::GetVolumeRange method implementation) 36101 Wow Hangs at login screen when coming from battle.net launcher (only with gxapi Opengl) 39447 Unimplemented function hid.dll.HidP_TranslateUsagesToI8042ScanCodes 39734 ProtectDisc Driver 11: acedrv11.sys crashes 40448 Final Fantasy XI: Missing character models, potential black screen and crashes 40540 ReadIntervalTimeout is ignored if there is data in the buffer when ReadFile is called and no data arrives after that 40746 Microsoft Expression Web 4 crashes when opening site, needs rpcrt4.dll.NdrAsyncServerCall 40861 Kingsoft Office 2012 needs ntoskrnl.exe.IoAttachDevice 40999 Epic Games Launcher needs ws2_32.InetNtopW 41021 Zombie Army trilogy needs msvcr100.dll._fpieee_flt 41050 Age of Mythology: Extended Edition needs api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vswscanf 41090 Multiple games (Starcraft 2, UE4 games) require vcruntime140.dll.__intrinsic_setjmp 41142 gcc6: server build warnings 41224 WineD3D8 crashes on Windows with GTAVC and i915-class video 41284 dbghelp_dwarf: parse_cie_details unknown CIE version 4 (clang/mesa/valgrind) 41308 iconfig.exe needs msvcr120.??0_Condition_variable(a)details@Concurrency@@QAE(a)XZ 41343 Ellisys Visual USB needs unimplemented function newdev.dll.DiInstallDriverA 41389 ComboFix fails to install: complains about missing HKLM\System\CurrentControlSet\Control\hivelist 41405 Hornbill Supportworks Client 7.6.0: crashes with ExtFloodFill when open 'Incident Details' pane 41428 The Forest: Terminal gets spammed with errors if Steam is running 41570 Xenia emulator needs unimplemented function api-ms-win-core-rtlsupport-l1-1.RtlLookupFunctionEntry called in 64-bit code 41602 Videos do not play in Age of Empires 41627 MS Word 2010 crash when exiting on Wine stable 1.8.5. 41640 add rx 480 into directx.c 41642 S3CC921 programmer app needs ntoskrnl.exe.KeSetTimerEx 41651 WScript object name on wine is case sensitive which should not be the case (vbscript) 41705 Build fails in dpnet: redefinition of typedef 'SOCKADDR' ---------------------------------------------------------------- Changes since 1.8.5: Alex Henrie (1): ntdll: Skip synchronous read if a serial read interval timeout is set. Alexandre Julliard (2): server: Avoid some compiler warnings when EWOULDBLOCK == EAGAIN. ntdll: Add a helper function for registering a file read async I/O. Alistair Leslie-Hughes (2): comdlg32/tests: Test when a directory is passed to OpenFileName Dialog. dpnet: Header files cleanup. Andrew Eikum (1): mmdevapi: Implement IAudioEndpointVolume::GetVolumeRange. Andrew Kanaber (1): wined3d: Add id for Broadwell Xeon E3 GPU. Andrey Gusev (1): user32: Add support for WS_EX_RIGHT style. André Hentschel (1): loader/wine.inf: Open pdf files using winebrowser. Aric Stewart (1): hid: Stub HidP_TranslateUsagesToI8042ScanCodes. Austin English (5): wine.inf: Add HKLM\System\CurrentControlSet\Control\hivelist key. newdev: Add DiInstallDriverA/W stubs. api-ms-win-core-rtlsupport-l1-1-0: Add missing forwards. ntoskrnl.exe: Add IoAttachDevice stub. ntoskrnl.exe: Add KeSetTimerEx stub. Bernhard Übelacker (1): ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. Bruno Jesus (3): xinput1_3: Prefer builtin DLL. comdlg32: Avoid crash when a path is passed into Open File Dialog. msvfw32/tests: Add tests for ICInfo(). Carlos Rafael Ramirez (1): cmd: When 'if' condition is not met, ignore the next commands in the list. Daniel Lehman (2): ucrtbase: Add __stdio_common_vfwprintf. ucrtbase: Add __stdio_common_vfwscanf. Filip Frąckiewicz (5): wined3d: Add NVIDIA GTX 690 (GK104) to the GPU list. wined3d: Add AMD Radeon HD 6480G IGP. wined3d: Add NVIDIA GTX 980 Ti. wined3d: Add NVIDIA GTX 675MX to the GPU list. wined3d: Add NVIDIA GTX 760 Ti to the GPU list. Grazvydas Ignotas (1): wined3d: Add Polaris GPUs and their driver. Huw D. M. Davies (3): ucrtbase: Add __stdio_common_vswscanf(). gdi32: Check that ExtFloodFill()'s initial co-ordinates lie within the dib. fonts: Fix typo in glyph name. Jacek Caban (4): msctf: Don't call ITextStoreACP::UnadviseSink in context destructor. msctf: Added Push/Pop context tests. vbscript: Call GetItemInfo() with original item name. secur32: Use %LATEST_RECORD_VERSION gnutls priority. Józef Kucia (1): wined3d: Improve advertized driver version for Windows 10. Matteo Bruni (2): wined3d: Recognize a couple of Haswell / Broadwell GPUs on macOS. wined3d: Add a bunch of Broadwell and Skylake PCI ids and descriptions. Michael Müller (2): ntdll: Open current working directory with FILE_TRAVERSE access. msvfw32: Use case insensitive compare in ICInfo for fourcc codes. Nikolay Sivov (3): dbghelp: Support CIE version 4 in parse_cie_details(). rpcrt4: Added NdrAsyncServerCall stub. ucrtbase: Fix some spec file entries. Philipp Hoppermann (1): ws2_32: Implement InetNtopW. Piotr Caban (5): ucrtbase: Add __intrinsic_setjmp implementation. msvcrt: Add _fpieee_flt stub. msvcrt: Support fdiv m64fp in i386 _fpieee_flt. msvcr110: Add Concurrency::details::_Condition_variable class stub. msvcr120: Add _Condition_variable implementation. Ruslan Kabatsayev (1): wined3d: Initialise p_wglGetPixelFormat when USE_WIN32_OPENGL is defined. Sebastian Lackner (1): server: Allow to create win32 prefix when directory already exists. -- Michael Stefaniuc mstefani(a)winehq.org

1 0

Re: [PATCH 8/9] d3d10core/tests: Add test for two sided stencil.
by Henri Verbeet Nov. 30, 2016

Nov. 30, 2016

On 30 November 2016 at 12:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + ds_desc.FrontFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilFunc = D3D10_COMPARISON_NEVER; > + ds_desc.BackFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilFunc = D3D10_COMPARISON_ALWAYS; It's fine for a start, but note that this test doesn't do much for front/back stencil ops. Also, fwiw, in d3d9:visual there's stencil_cull_test() that's similar.

1 0

Re: [PATCH 03/10] server: Use async object to transfer IRP result to client.
by Alexandre Julliard Nov. 30, 2016

Nov. 30, 2016

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/server/file.h b/server/file.h > index c0a53a2..75a2e03 100644 > --- a/server/file.h > +++ b/server/file.h > @@ -53,6 +53,8 @@ struct fd_ops > void (*reselect_async)( struct fd *, struct async_queue *queue ); > /* cancel an async operation */ > int (*cancel_async)(struct fd *, struct process *process, struct thread *thread, client_ptr_t iosb); > + /* find an async operation in queues */ > + struct async *(*find_async)( struct fd *fd, struct process *process, client_ptr_t client_async ); > }; I think a per-process list of async/iosb would make more sense. There should be nothing file type specific about finding an async. It could probably be used to get rid of cancel_async() too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Github mirror seems to be out-of-sync
by Akihiro Sagawa Nov. 30, 2016

Nov. 30, 2016

Source code admin, Official Github mirror, https://github.com/wine-mirror/wine, seems to be not updated for a few days. Could you take a look? Thanks in advance. Akihiro Sagawa

2 2

Re: [resend] fusion: Avoid buffer overflow in enum_gac_assemblies.
by Alexandre Julliard Nov. 29, 2016

Nov. 29, 2016

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ Marvin indicated testing went fine, and I did not see any feedback > for two weeks. Only the description below has changed a little. ] > > In enum_gac_assemblies we have the following > > sprintf(buf, ", Version=%s, Culture=%s, PublicKeyToken=%s", > ffd.cFileName, culture, ptr); > > culture is declared as char[MAX_PATH], and WIN32_FIND_DATAA.cFileName > is CHAR[260], so a mere size of MAX_PATH for the output buffer buf is > not sufficient. > > (We need to double sizeof(ffd.cFileName) since ptr also points > into it.) They all point into the same path, so the total size is not going to exceed MAX_PATH (modulo the additionally printed chars). And it doesn't make sense to fix this buffer but not the other ones, you are just moving the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Serial port sniffing problem
by Christopher Harrington Nov. 29, 2016

Nov. 29, 2016

(copying list again, below edited for brevity) On Tue, Nov 29, 2016 at 12:39 PM Bill Lionheart <billlionheart(a)gmail.com> wrote: > $ ls -Fl > lrwxrwxrwx 1 bill bill 10 May 11 2014 c: -> ../drive_c/ > lrwxrwxrwx 1 bill bill 12 Jan 6 2016 com1 -> /dev/ttyUSB0 > > $ id -a > uid=1001(bill) gid=1001(bill) > groups=1001(bill),20(dialout) > $ ls -l /dev/ttyUSB0 > crw-rw---- 1 root dialout 188, 0 Nov 29 18:27 /dev/ttyUSB0 > > > All of this definitely looks correct. Here are a couple more suggestions: 1. Try creating a brand new wine prefix. Yours certainly has a beard on it and there may be artifacts of older copies of Wine that could be impacting your testing. Anyway, this essentially would look like moving ~/.wine to somewhere else, installing your test application again, and re-creating your com1 file in dosdevices/. You can always move your .wine directory back if it has important stuff in it. 2. See if using a more current version of Wine improves anything. You say you're on Wine 1.8; if you could be more specific (try running wine --version) that might give someone a lightbulb. 3. Crossover from Codeweavers is appallingly affordable if you haven't looked into that yet, and it comes with professional support. Anyway, wine-devel is more for discussion of development of Wine itself, not a support forum. What you're probably looking for is wine-users. I'm not subscribed to wine-users, so I can't copy your email there, but you can subscribe here: https://www.winehq.org/mailman/listinfo/wine-users Good luck. > > On 29 November 2016 at 17:57, Christopher Harrington > <ironiridis+winehq(a)gmail.com> wrote: > > On Tue, Nov 29, 2016 at 1:22 AM Bill Lionheart <billlionheart(a)gmail.com> > > wrote: > >> > >> Using Wine version 1.8 on Ubuntu 14.04.5 > >> I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a > >> serial interface. The device is supplied with a Prolific USB serial > >> converter which comes up as /dev/ttyUSB0 which > >> I have sym linked to COM1 > > > > > > Can you please cd into your dosdevices folder and run this command? > > > > ls -Fl > > > > (that's an uppercase F and a lowercase L) > > > > Then we will also need to see permissions of the serial device, so run > this: > > > > ls -l /dev/ttyUSB0 > > > > That's a lowercase L again... and run this too: > > > > id -a > > > > With all this info we can rule out a couple problems, chief among them: > > 1. Is the symlink named correctly and actually pointing to something that > > exists > > 2. Do you actually have permissions to access the serial port > > > > If you provide the output of all three of these commands, we should be > able > > to help. > > > > -Chris > > > >> > >> > > > > > > -- > Professor of Applied Mathematics > University of Manchester > http://www.maths.manchester.ac.uk/bl >

1 0

Re: [PATCH v2] ws2_32/tests: Add IDN resolution tests for GetAddrInfoW
by Marvin Nov. 29, 2016

Nov. 29, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26981 Your paranoid android. === w7u (32 bit sock) === sock.c:8270: Test failed: Overlapped TransmitFile failed. sock.c:8272: Test failed: Overlapped TransmitFile sent an unexpected number of bytes (219 != 209).

1 0

Re: [PATCH 9/9] d3d11/tests: Add test for typed UAV loads.
by Henri Verbeet Nov. 29, 2016

Nov. 29, 2016

On 29 November 2016 at 12:06, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 326 insertions(+) > This fails for me on Windows: d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 5: Got 0x00000010, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 3).

2 1