November 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 4/5] d3d11/tests: Add test for shader input register limits.
by Henri Verbeet Nov. 29, 2016

Nov. 29, 2016

On 25 November 2016 at 12:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The "ps_many_resources_code" shader bytecode is very big because texture > resources cannot be indexed and the loop is unrolled. > > --- > dlls/d3d11/tests/d3d11.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 221 insertions(+) > This doesn't work here. In particular: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #5: fixme:d3d_shader:print_glsl_info_log error: Too many fragment shader texture samplers ... fixme:d3d:context_bind_shader_resources Shader 0x18bb10 needs 21 samplers, but only 16 are supported.

2 3

Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW
by Alexandre Julliard Nov. 29, 2016

Nov. 29, 2016

Bruno Jesus <00cpxxx(a)gmail.com> writes: > I'm using €.linux.it because I could not find any standard domain name > for validation. Maybe winehq.org could have a IDN sub-domain name to > test. I created テスト.winehq.org for this purpose. > Also instead of broken'ing every test to catch Windows <= 7 I'm > skipping before, so real failures are not lost due to broken covering > them in Win >= 8. I still think it's better to avoid version checks. You can do broken() on the first test and skip the others if you detect the Win 7 behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Add some uuids present on Windows 10.
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 16:43, Huw Davies wrote: > +DEFINE_GUID(IID_UnknownInterface22, 0x42f85136, 0xdb7e, 0x439c, 0x85,0xf1, 0xe4,0x07,0x5d,0x13,0x5f,0xc8); This one is IID_IFileDialog.

2 1

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > Since put_ProcessImageFileName appears to validate the image name that is > supplied, the normal put/get/compare was excluded because it returned > E_INVALIDARG even for a fully qualified filename. An investigation for another > day. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/tests/Makefile.in | 2 +- > dlls/hnetcfg/tests/policy.c | 32 +++++++++++++++++++++++++++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/tests/Makefile.in b/dlls/hnetcfg/tests/Makefile.in > index aa4062a..5e1ce91 100644 > --- a/dlls/hnetcfg/tests/Makefile.in > +++ b/dlls/hnetcfg/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = hnetcfg.dll > -IMPORTS = ole32 uuid > +IMPORTS = ole32 uuid oleaut32 > > C_SRCS = \ > policy.c > diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c > index a3ed4b2..a05b02e 100644 > --- a/dlls/hnetcfg/tests/policy.c > +++ b/dlls/hnetcfg/tests/policy.c > @@ -65,6 +65,36 @@ static void test_interfaces(void) > INetFwMgr_Release(manager); > } > > +static void test_NetFwAuthorizedApplication(void) > +{ > + INetFwAuthorizedApplication *app; > + HRESULT hr; > + > + hr = CoCreateInstance(&CLSID_NetFwAuthorizedApplication, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > + &IID_INetFwAuthorizedApplication, (void**)&app); > + ok(hr == S_OK, "got: %08x\n", hr); > + if(hr == S_OK) > + { It's not really necessary to protect it like that. If creation consistently fails test or all tests should be skipped. > + static WCHAR empty[] = {0}; > + BSTR bstr; > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, NULL); > + ok(hr == E_POINTER, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, &bstr); > + ok(hr == S_OK, "got: %08x\n", hr); > + ok(!bstr, "got: %s\n", wine_dbgstr_w(bstr)); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, NULL); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, empty); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); Please use actual BSTR here. > + > + INetFwAuthorizedApplication_Release(app); > + } > +} > + > START_TEST(policy) > { > INetFwMgr *manager; > @@ -84,7 +114,7 @@ START_TEST(policy) > INetFwMgr_Release(manager); > > test_interfaces(); > - > + test_NetFwAuthorizedApplication(); > > CoUninitialize(); > } >

1 0

Re: [v2 PATCH 1/2] hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > From: Michael Müller <michael(a)fds-team.de> > > v2: > Corrected error return values. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/apps.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/apps.c b/dlls/hnetcfg/apps.c > index 2b8d78c..a89e6a7 100644 > --- a/dlls/hnetcfg/apps.c > +++ b/dlls/hnetcfg/apps.c > @@ -38,6 +38,7 @@ typedef struct fw_app > { > INetFwAuthorizedApplication INetFwAuthorizedApplication_iface; > LONG refs; > + BSTR filename; > } fw_app; > > static inline fw_app *impl_from_INetFwAuthorizedApplication( INetFwAuthorizedApplication *iface ) > @@ -60,6 +61,7 @@ static ULONG WINAPI fw_app_Release( > if (!refs) > { > TRACE("destroying %p\n", fw_app); > + if (fw_app->filename) SysFreeString( fw_app->filename ); There's no need for this check. > HeapFree( GetProcessHeap(), 0, fw_app ); > } > return refs; > @@ -252,7 +254,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_POINTER; > + > + if (!This->filename) > + { > + *imageFileName = NULL; > + return S_OK; > + } > + > + *imageFileName = SysAllocString( This->filename ); > + return *imageFileName ? S_OK : E_OUTOFMEMORY; > } You can reduce this to --- *imageFileName = SysAllocString( This->filename ); return *imageFileName || !This->filename ? S_OK : E_OUTOFMEMORY; --- > > static HRESULT WINAPI fw_app_put_ProcessImageFileName( > @@ -262,7 +275,12 @@ static HRESULT WINAPI fw_app_put_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %s\n", This, debugstr_w(imageFileName)); > - return S_OK; > + > + if (!imageFileName || !imageFileName[0]) > + return E_INVALIDARG; > + > + This->filename = SysAllocString( imageFileName ); > + return This->filename ? S_OK : E_OUTOFMEMORY; > } What happens if you call put_ProcessImageFileName() repeatedly?

1 0

Re: hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Alistair Leslie-Hughes Nov. 29, 2016

Nov. 29, 2016

On 24/11/16 07:22, Bruno Jesus wrote: > From: Michael Müller <michael(a)fds-team.de> > > Manually tested using vbscript. > > @@ -250,7 +252,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_INVALIDARG; The return value here is incorrect. I've sent an updated patch+tests to wine-patches Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Marvin Nov. 29, 2016

Nov. 29, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26959 Your paranoid android. === wxppro (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === w2003std (32 bit policy) === policy.c:85: Test failed: got: 80070008 policy.c:89: Test failed: got: 80070003 policy.c:92: Test failed: got: 80070003 === wvistau64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w2008s64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7u (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w7pro64 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w8 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w864 (32 bit policy) === policy.c:92: Test failed: got: 80070003 === w1064 (32 bit policy) === policy.c:92: Test failed: got: 80070003

1 0

Re: [PATCH] wincodecs: Trigger conversion to target format in WriteSource()
by Dmitry Timoshkov Nov. 28, 2016

Nov. 28, 2016

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Does this even fix a real application? What exactly this patch is supposed to fix? -- Dmitry.

1 0

Re: [v3] cmd/tests: chaining rules of pipe and else
by Marvin Nov. 28, 2016

Nov. 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26946 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Undocumented function prototype
by Marco Savelli Nov. 28, 2016

Nov. 28, 2016

Hi everybody! I'm new to this list. I found this page (in deutsch) which seems to document an otherwise undocumented function, namely GetPermLayers from aphelp.dll. I don't know where they got it, but seems a realistic definition. Hope it helps. And thanks for your development effort, go on this way! :D P.S. It' in delphi, there's a "var" keyword, which should means (from google, I'm not a delphist) an optional argument. IDA PRO gives error when given the last two args. Hope you can figure out where's the problem

3 4

Re: [PATCH 3/3] wintrust/tests: Remove a test that crashes on Windows 8 amd 10.
by Marvin Nov. 28, 2016

Nov. 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26944 Your paranoid android. === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001

1 0

Re: [PATCH 2/3] wintrust/tests: Initialize the pSigState member to prevent Windows 8 and 10 from crashing.
by Marvin Nov. 28, 2016

Nov. 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26943 Your paranoid android. === w8 (32 bit softpub) === softpub: unhandled exception c0000005 at 7511A63B === w864 (32 bit softpub) === softpub: unhandled exception c0000005 at 7772A63B === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 768B0B90 === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF9B8F === w1064 (64 bit softpub) === softpub.c:254: Test failed: Expected S_OK, got 00000001 softpub.c:257: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FFC77A7F593

1 0

Re: [2/5] strmbase: Add validation checks when updating source rectangle.
by Andrew Eikum Nov. 28, 2016

Nov. 28, 2016

On Sun, Nov 20, 2016 at 03:33:22PM +0900, Akihiro Sagawa wrote: > @@ -53,6 +53,26 @@ HRESULT WINAPI BaseControlVideo_Destroy(BaseControlVideo *pControlVideo) > return BaseDispatch_Destroy(&pControlVideo->baseDispatch); > } > > +static HRESULT BaseControlVideoImpl_CheckSourceRect(BaseControlVideo *This, RECT *pSourceRect) > +{ > + LONG VideoWidth, VideoHeight; > + HRESULT hr; > + > + if (pSourceRect->top < 0 || pSourceRect->left < 0 || > + pSourceRect->top >= pSourceRect->bottom || > + pSourceRect->left >= pSourceRect->right) > + return E_INVALIDARG; I'm not opposed to spelling it out, but you could use IsRectEmpty() here instead. > + > + hr = BaseControlVideoImpl_GetVideoSize((IBasicVideo *)This, &VideoWidth, &VideoHeight); > + if (FAILED(hr)) > + return hr; > + > + if (pSourceRect->bottom > VideoHeight || pSourceRect->right > VideoWidth) > + return E_INVALIDARG; > + Shouldn't these use (bottom - top) and (right - left)? Andrew

2 2

Do we delete spammers accounts from bugzilla?
by Bruno Jesus Nov. 28, 2016

Nov. 28, 2016

Today we had one more piece of spam, the bot registered the account a few moments before creating a bug. In this case should we use bugzilla's admin features to delete the user? Best wishes, Bruno

3 3

Re: [v2] cmd/tests: chaining rules of pipe and else
by Marvin Nov. 28, 2016

Nov. 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26937 Your paranoid android. === wxppro (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w2003std (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7u (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7pro64 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w8 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w864 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w1064 (32 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') batch.c:313: Test failed: unexpected char 0x27 position 0 in line 540 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === w2008s64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w7pro64 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w864 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]') === w1064 (64 bit) === batch.c:313: Test failed: unexpected char 0x2d position 0 in line 391 (got '---', wanted 'g2:[g1,g2]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 393 (got '---', wanted 'h3:[h2:[h1,h2],h3]@or_broken(a)h3:[h2:,h3]') batch.c:313: Test failed: unexpected char 0x2d position 0 in line 395 (got '---', wanted 'i4:[i3:[i2:[i1,i2],i3],i4]@or_broken(a)i4:[i3:[i2:,i3],i4]@or_broken(a)i4:[i3:,i4]')

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Lauri Kenttä Nov. 26, 2016

Nov. 26, 2016

Testbot reports a failure on Vista, but that is not related to my patch. -- Lauri Kenttä

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Marvin Nov. 26, 2016

Nov. 26, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26929 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2 2/5] d3d9/tests: Add test for occlusion query with result bigger than UINT32_MAX.
by Marvin Nov. 25, 2016

Nov. 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26917 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: ntdll/tests: The fpu exception offset is broken on 32-bit Windows 8 too.
by Marvin Nov. 25, 2016

Nov. 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26914 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x2e0000/0x2e0001 exception: unhandled exception 80000004 at 002E0000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x2e0001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x300000/0x300001 exception: unhandled exception 80000004 at 00300000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x300001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH] winspool: Use all Fields from DRIVER_INFO_8A when we add a Printer Driver.
by Huw Davies Nov. 25, 2016

Nov. 25, 2016

On Fri, Nov 25, 2016 at 12:49:40AM +0100, Detlef Riekenberg wrote: > + if ((Level > 7) && diA->pszzColorProfiles) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, NULL, 0); > + diW.pszzColorProfiles = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, diW.pszzColorProfiles, len); > + } This is a 'multi-sz' string, so you need the same handling as 'pDependentFiles' here. > + if ((Level > 7) && diA->pszInfPath) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, NULL, 0); > + diW.pszInfPath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, diW.pszInfPath, len); > + } > + > + if ((Level > 7) && diA->pszzCoreDriverDependencies) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, NULL, 0); > + diW.pszzCoreDriverDependencies = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, diW.pszzCoreDriverDependencies, len); > + } The same goes for pszzCoreDriverDependencies. > if (Level > 7) { > - FIXME("level %u is incomplete\n", Level); > + diW.dwPrinterDriverAttributes = diA->dwPrinterDriverAttributes; > + diW.ftMinInboxDriverVerDate = diA->ftMinInboxDriverVerDate; > + diW.dwlMinInboxDriverVerVersion = diA->dwlMinInboxDriverVerVersion; > } > > res = AddPrinterDriverExW(nameW, Level, (LPBYTE) &diW, dwFileCopyFlags); > @@ -7018,6 +7061,11 @@ BOOL WINAPI AddPrinterDriverExA(LPSTR pName, DWORD Level, LPBYTE pDriverInfo, DW You're leaking pHelpFile. > HeapFree(GetProcessHeap(), 0, diW.pszOEMUrl); > HeapFree(GetProcessHeap(), 0, diW.pszHardwareID); > HeapFree(GetProcessHeap(), 0, diW.pszProvider); > + HeapFree(GetProcessHeap(), 0, diW.pszPrintProcessor); > + HeapFree(GetProcessHeap(), 0, diW.pszVendorSetup); > + HeapFree(GetProcessHeap(), 0, diW.pszzColorProfiles); > + HeapFree(GetProcessHeap(), 0, diW.pszInfPath); > + HeapFree(GetProcessHeap(), 0, diW.pszzCoreDriverDependencies); > > TRACE("=> %u with %u\n", res, GetLastError()); > return res;

1 0

Re: 2 of 13 [PATCH] po: Update Simplified Chinese translation (v3).
by Jactry Zeng Nov. 24, 2016

Nov. 24, 2016

This looks good to me. Thanks for your contribution! 2016-11-23 0:09 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 1202 ++++++++++++++++++++++++++++++ > ++++------------------------- > 1 file changed, 687 insertions(+), 515 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 1/2] shlwapi: Remove dot segments for URLs starting with /
by Jacek Caban Nov. 24, 2016

Nov. 24, 2016

Hi Daniel, On 24.11.2016 00:44, Daniel Lehman wrote: > diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c > index 879a734..5de9076 100644 > --- a/dlls/shlwapi/url.c > +++ b/dlls/shlwapi/url.c > @@ -372,6 +372,9 @@ HRESULT WINAPI UrlCanonicalizeW(LPCWSTR pszUrl, LPWSTR pszCanonicalized, > dwFlags |= URL_ESCAPE_UNSAFE; > state = 5; > is_file_url = TRUE; > + } else if(url[0] == '/') { > + state = 2; Wouldn't state 5 be more appropriate? > + is_file_url = TRUE; It would be interesting to have tests using URL_WININET_COMPATIBILITY and URL_FILE_USE_PATHURL flags. is_file_url usually affects slashes conversion in such cases, but you set it too late to take such effect. It may be right, but tests would be nice. Thanks, Jacek

1 0

Re: [PATCH 04/11] wined3d: Introduce wined3d_device_set_unordered_access_view().
by Henri Verbeet Nov. 24, 2016

Nov. 24, 2016

On 23 November 2016 at 14:36, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + FIXME("Unordered access view unsupported yet (layers %u-%u).\n", > + desc->u.texture.layer_idx, desc->u.texture.layer_count); I don't think you can do that in English. You'd either have "UAV unsupported" or "UAV not supported yet". In the specific case here, I'd probably use something like "Unsupported layer selection %u+%u.\n" or something along those lines though.

1 0

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles
by Henri Verbeet Nov. 24, 2016

Nov. 24, 2016

On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) > +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) > { > - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); > + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); > + > + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); > + > + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); > + if (dash_count > style->dash_count) > + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); That doesn't look right.

2 2

Re: [PATCH v2] msvcrt: Add _lfind_s
by Piotr Caban Nov. 24, 2016

Nov. 24, 2016

Hi Daniel, it fails to compile: ../../tools/winegcc/winegcc -o api-ms-win-crt-utility-l1-1-0.dll.so -B../../tools/winebuild -m32 -fasynchronous-unwind-tables -shared ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec \ ../../libs/port/libwine_port.a ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec:6: function '_lfind_s' not defined winegcc: ../../tools/winebuild/winebuild failed Makefile:166: recipe for target 'api-ms-win-crt-utility-l1-1-0.dll.so' failed make[1]: *** [api-ms-win-crt-utility-l1-1-0.dll.so] Error 2 Thank you, Piotr

1 0