November 2016 - Wine-Devel - list.winehq.org

Re: [PATCH 2/2] gdiplus: Implement GdipBitmapGetHistogram()
by Vincent Povirk Nov. 1, 2016

Nov. 1, 2016

> + ok(ch1[0x3f] == WIDTH, "Got green (0x3f) %u\n", ch1[0x3f]); > + ok(ch2[0x20] == WIDTH, "Got blue (0x20) %u\n", ch1[0x20]); > + > +return; > + > + /* ARGB histogram from RGB data. */ > + stat = pGdipBitmapGetHistogram(bm, HistogramFormatARGB, 256, ch0, ch1, ch2, NULL); > + expect(InvalidParameter, stat); That return doesn't look like it's supposed to be there.

2 1

Re: [PATCH] ws2_32: Fix the default behavior of IPV6_V6ONLY
by Marvin Nov. 1, 2016

Nov. 1, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26345 Your paranoid android. === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF126F94

3 2

Re: [PATCH 2/2] gdiplus: Implement GdipBitmapGetHistogram()
by Dmitry Timoshkov Nov. 1, 2016

Nov. 1, 2016

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + for (x = 0; x < width; x++) > + for (y = 0; y < height; y++) > + { > + ARGB color; > + > + GdipBitmapGetPixel(bitmap, x, y, &color); > + set_histogram_point[format](color, ch0, ch1, ch2, ch3); > + } > + > + return Ok; > +} One of the very least things that could be done about this very ineffecient implementation is to make the width traversing an inner loop. -- Dmitry.

1 0

Re: wined3d: Add ARB_texture_env_crossbar extension.
by Henri Verbeet Nov. 1, 2016

Nov. 1, 2016

This isn't very useful on its own. Do you intend to use the extension for something?

1 0