December 2016 - Wine-Devel - list.winehq.org

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind)
by Hans Leidekker Dec. 13, 2016

Dec. 13, 2016

On Mon, 2016-12-12 at 16:20 -0600, Austin English wrote: > This avoids a stack smashing error when running > dlls/webservices/tests/writer.c under Valgrind. > > diff --git a/dlls/webservices/writer.c b/dlls/webservices/writer.c > index c1f1b0c..07b32d8 100644 > --- a/dlls/webservices/writer.c > +++ b/dlls/webservices/writer.c > @@ -1369,7 +1369,7 @@ static HRESULT text_to_utf8text( const WS_XML_TEXT *text, WS_XML_UTF8_TEXT **ret > case WS_XML_TEXT_TYPE_DOUBLE: > { > const WS_XML_DOUBLE_TEXT *double_text = (const WS_XML_DOUBLE_TEXT *)text; > - unsigned char buf[24]; /* "-1.1111111111111111E-308" */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308" */ > unsigned short fpword; > ULONG len; Please add a comment with motivation for the increased buffer size.

1 0

Re: [PATCH] advapi32: Add tests for StartTrace().
by Marvin Dec. 13, 2016

Dec. 13, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27322 Your paranoid android. === wxppro (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1216: Test failed: Expected success, got 161 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 161 === w2003std (32 bit eventlog) === eventlog.c:1170: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:1220: Test failed: Expected ERROR_ALREADY_EXISTS, got 32

1 0

Re: [PATCH] mmdevapi: Fix pointer type cast
by Andrew Eikum Dec. 12, 2016

Dec. 12, 2016

On Sat, Dec 10, 2016 at 08:54:51AM +0300, Nikolay Sivov wrote: > diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c > index 221fb39..b189e8e 100644 > --- a/dlls/mmdevapi/devenum.c > +++ b/dlls/mmdevapi/devenum.c > @@ -613,7 +613,7 @@ static HRESULT WINAPI MMDevice_Activate(IMMDevice *iface, REFIID riid, DWORD cls > if (SUCCEEDED(hr)) > { > IPersistPropertyBag *ppb; > - hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void*)&ppb); > + hr = IUnknown_QueryInterface((IUnknown*)*ppv, &IID_IPersistPropertyBag, (void **)&ppb); > if (SUCCEEDED(hr)) > { > /* ::Load cannot assume the interface stays alive after the function returns, Seems like this (and other similar cleanup patches) should be deferred until after freeze, right? Andrew

3 2

Re: [2/2 v2] winex11: Use XIAllDevices to select for XI_RawMotion
by Henri Verbeet Dec. 12, 2016

Dec. 12, 2016

On 18 November 2016 at 12:43, Carlos Garnacho <carlosg(a)gnome.org> wrote: > Change the strategy used to get raw motion from slave devices. Instead > of selecting for XI2 events for every slave device individually, do it > for XIAllDevices, and store the current device's relative X/Y valuators > so they can be quickly looked up in the XI_RawMotion events received. > I think this makes sense, and in my (limited) testing this correctly handles the case of attaching a new input device. I do have a few minor comments though: > +static void update_relative_valuators(XIAnyClassInfo **valuators, > + int n_valuators) This should probably just be "static void update_relative_valuators( XIAnyClassInfo **valuators, int n_valuators )" > + free( thread_data->x_rel_valuator ); > + free( thread_data->y_rel_valuator ); ... > + thread_data->x_rel_valuator = malloc( sizeof(XIValuatorClassInfo) ); > + memcpy ( thread_data->x_rel_valuator, class, sizeof(XIValuatorClassInfo) ); We generally avoid malloc()/free() in Wine code and use HeapAlloc()/HeapFree() instead. The main consideration has to do with the way address space is allocated for Win32 applications, effectively making malloc() space a bit more scarce than HeapAlloc() space. We'd probably prefer the sizeof as "sizeof(*thread_data->x_rel_valuator)", or perhaps "sizeof(*class)". I'm not sure how much we should worry about this in practice, but when multiple slaves are attached to the master, and they're not completely idle, update_relative_valuators() can end up getting called quite a bit. It doesn't seem hard to at least do the allocation only once, and only update the data in update_relative_valuators(). Perhaps it's also fine the way it is though. > - XISetMask( mask_bits, XI_ButtonPress ); This was added intentionally (see also https://bugs.winehq.org/show_bug.cgi?id=27522#c18) Perhaps it's no longer needed, but that would need to be a separate patch. > + pointer_info = pXIQueryDevice( data->display, data->xi2_core_pointer, &count ); > + update_relative_valuators( pointer_info->classes, pointer_info->num_classes ); > + pXIFreeDeviceInfo( pointer_info ); ... > + pXISelectEvents( data->display, DefaultRootWindow( data->display ), &mask, 1 ); I'm not too concerned about it, but can this race? I.e. switching slaves between when update_relative_valuators() is called above and when XISelectEvents() takes effect. Applies to querying the devices list as well. > + if (thread_data->xi2_current_slave == 0) We'd typically write that "if (!thread_data->xi2_current_slave)", although I don't think anyone would be overly concerned about it. > + for (i = 0; i <= max ( x_rel->number, y_rel->number ); i++) > + { > +»······if (!XIMaskIsSet( event->valuators.mask, i )) continue; > +»······val = *values++; > +»······if (i == x_rel->number) > +»······{ > + input.u.mi.dx = dx = val; > +»······ if (x_rel->min < x_rel->max) > + input.u.mi.dx = val * (virtual_rect.right - virtual_rect.left) > + / (x_rel->max - x_rel->min); > +»······} > +»······if (i == y_rel->number) > +»······{ > +»······ input.u.mi.dy = dy = val; > +»······ if (y_rel->min < y_rel->max) You're using tabs for indentation here.

2 1

Re: [PATCH] shlwapi: Avoid 'else if' for IStream_fnQueryInterface.
by Nikolay Sivov Dec. 12, 2016

Dec. 12, 2016

On Mon, 12 Dec 2016 13:24:38 +0200 Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/shlwapi/regstream.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/dlls/shlwapi/regstream.c b/dlls/shlwapi/regstream.c > index 1b0ca4e..d886c0c 100644 > --- a/dlls/shlwapi/regstream.c > +++ b/dlls/shlwapi/regstream.c > @@ -67,9 +67,7 @@ static HRESULT WINAPI IStream_fnQueryInterface(IStream *iface, REFIID riid, LPVO > > *ppvObj = NULL; > > - if(IsEqualIID(riid, &IID_IUnknown)) /*IUnknown*/ > - *ppvObj = This; > - else if(IsEqualIID(riid, &IID_IStream)) /*IStream*/ > + if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IStream)) > *ppvObj = This; > > if(*ppvObj) Please return interface pointer, to IStream_iface. Also TRACE() for this method needs simplification, but it could be a separate change.

1 0

Re: [PATCH resend 13/18] wined3d: Use depth/stencil formats for typeless resources only when WINED3DUSAGE_DEPTHSTENCIL is set.
by Henri Verbeet Dec. 12, 2016

Dec. 12, 2016

On 9 December 2016 at 11:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > const struct wined3d_format *wined3d_get_format(const struct wined3d_gl_info *gl_info, > - enum wined3d_format_id format_id) > + enum wined3d_format_id format_id, unsigned int resource_usage) > { > + const struct wined3d_format *format; > int idx = get_format_idx(format_id); > + unsigned int i; > > if (idx == -1) > { > - FIXME("Can't find format %s (%#x) in the format lookup table\n", > + FIXME("Can't find format %s (%#x) in the format lookup table.\n", > + debug_d3dformat(format_id), format_id); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > + } > + > + format = &gl_info->formats[idx]; > + > + if (resource_usage & WINED3DUSAGE_DEPTHSTENCIL && wined3d_format_is_typeless(format)) > + { > + for (i = 0; i < ARRAY_SIZE(typeless_depth_stencil_formats); ++i) > + { > + if (typeless_depth_stencil_formats[i].typeless_id == format_id) > + return &gl_info->formats[WINED3D_FORMAT_COUNT + i]; > + } > + > + FIXME("Cannot find depth/stencil typeless format %s (%#x).\n", > debug_d3dformat(format_id), format_id); > - /* Get the caller a valid pointer */ > - idx = get_format_idx(WINED3DFMT_UNKNOWN); > + return &gl_info->formats[get_format_idx(WINED3DFMT_UNKNOWN)]; > } > > - return &gl_info->formats[idx]; > + return format; > } > I do have some concerns about whether returning different wined3d_format structures for different usages/bind flags is better than having different GL internal formats for different usages/bind flags within the same wined3d_format structure, but lets give it a try.

1 0

Re: [v2] preloader: Allow a debugger to find ld.so's rendezvous-struct
by Alexandre Julliard Dec. 11, 2016

Dec. 11, 2016

Keno Fischer <keno(a)juliacomputing.com> writes: > @@ -123,6 +123,18 @@ static struct wine_preload_info preload_info[] = > { 0, 0 } /* end of list */ > }; > > +/* A fake .dynamic section through which we can inform the debugger of the > + address of the chain-loaded dynamic linker's rendezvous struct */ > +__asm__( > +".section .dynamic,\"aw\"\n" > +".global _DYNAMIC\n" > +"_DYNAMIC: .quad 21\n" // DT_DEBUG > +".quad 0\n" > +".quad 0\n" > +".quad 0\n" > +".previous\n" > +); This is causing a warning here: gcc -m32 -c -o preloader.o preloader.c -I. -I../include -D__WINESRC__ -fno-builtin -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -Wlogical-op -gdwarf-2 -gstrict-dwarf -fno-omit-frame-pointer -Werror -g -O2 -fno-diagnostics-show-caret {standard input}: Assembler messages: {standard input}:5: Warning: setting incorrect section attributes for .dynamic -- Alexandre Julliard julliard(a)winehq.org

2 6

Re: [PATCH] po: Update Simplified Chinese translation.
by Jactry Zeng Dec. 11, 2016

Dec. 11, 2016

This looks good to me. Thank you, Mingcong! 2016-12-11 0:12 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 588 ++++++++++++++++++++++++++++++ > +++--------------------------- > 1 file changed, 324 insertions(+), 264 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Source.winehq.org down?
by Filip Frackiewicz Dec. 10, 2016

Dec. 10, 2016

Sorry for the bother but is source.winehq.org down for anyone? Filip

3 2

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Stefan Dösinger Dec. 10, 2016

Dec. 10, 2016

Am 2016-12-07 um 06:27 schrieb Bruno Jesus: > @@ -2433,6 +2438,12 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > union generic_unix_sockaddr unix_addr; > int n, ret; > > + if (network_disabled) > + { > + errno = EHOSTUNREACH; > + return -1; > + } > + Shouldn't it be possible to achieve a similar effect with a LD_PRELOAD library?

2 2

WineTest reference Linux machines
by Francois Gouget Dec. 9, 2016

Dec. 9, 2016

CodeWeavers has two machines that I have been running WineTest on, in Linux, Windows 8.1 and Windows 10, in 32 and 64 bit. They are identical except for the graphics cards: AMD HD6800 for cw1 and Nvidia GTX560 for cw2. During WineConf we decided that these should be able to run WineTest on Linux without any errors and thus become reference WineTest machines. We are not quite there yet so here is the current status starting with the 32 bit tests. * crypt32:chain Some of the certificates used by this test are present on Windows but missing on Linux, thus causing the error. Hans is looking into it and either the test will be modified to use other certificates present on both platforms, or the certificates will be added to these boxes. In the latter case this will be documented on the Wiki: https://wiki.winehq.org/Conformance_Tests#Running_WineTest_in_Wine * d2d1:d2d1, d3d10core:device These tests only fails on the GTX560. The reason is unknown. We need someone to look into it. * d3d8:device, d3d9:d3d9ex, d3d9:device, d3d9:visual Matteo fixed the radeon driver configuration and is looking into these failures, at least for the HD6800 case. It is possible some of these failures are caused by the window manager (currently xfwm from Xfce). Replacing the windows manager is no issue, we just need to know which one to pick. fvwm2? * kernel32:console, kernel32:process These failures happen because the tests are being run from cron, with their output redirected to a log file and thus they have no real terminal to work with. Interestingly the 64 bit tests are not failing. Vincent is investigating whether the tests should be modified or whether the test should be run from an xterm, screen session or some equivalent. * user32:winstation winstation.c:959: Test succeeded inside todo block: unexpected foreground window (nil) The cause for this failure has not been identified. Another window manager issue? * ws2_32:sock sock.c:2811: Test succeeded inside todo block: Test[2]: expected 0, got 0 We need someone to investigate this failure. It looks like it's random and relatively rare. Some tests just cannot be made to work reliably on Linux due to the asynchronous nature of X11 messaging. So another decision that was made that tests should be run up to 3 times until they succeed. It's not entirely clear if that applies to all tests or just to specific tests that are known to be flaky. The practical upshot is that people running 'make test' can re-run it a couple of times if it fails at first, and if it succeeds after 3 tries then you can consider that it's all good. These machines run WineTest so the results can be uploaded to test.winehq.org (with the relevant header describing the machine, the dlls, etc). So WineTest may need to be updated to deal with flaky tests according to policy. Here is more detail about these machines: * i7-2600K (4 cores+hyperthreading at 3.4GHz) * 16 GB of RAM * 768 GB of spinning disk * Debian 8.2 64 bit * cw1: AMD HD6800 running the open-source radeon driver. * cw2: Nvidia GTX560 running the proprietary driver. -- Francois Gouget <fgouget(a)codeweavers.com>

4 9

Code freeze
by Alexandre Julliard Dec. 9, 2016

Dec. 9, 2016

Folks, The release of 2.0-rc1 marks the beginning of code freeze towards 2.0. Most of you probably know the drill already, but from now on, only targeted bug fixes and other "safe" changes, like test fixes, translation updates, etc. will be accepted. I know that many people will soon be out for the holidays, but I hope we can still make significant progress with the open bugs, particularly with the bugs from the regression list. Now would also be a good time to retest your favorite applications to make sure that there are no regressions that we have missed. As usual, I'll be making release candidates every week, until we run out of bugs... Thank you all for helping make Wine 2.0 as good as we can! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/7] server: Added support for message mode named pipes.
by Alexandre Julliard Dec. 9, 2016

Dec. 9, 2016

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/kernel32/tests/pipe.c | 74 ++----- > dlls/ntdll/file.c | 7 +- > dlls/ntdll/tests/file.c | 2 +- > server/async.c | 15 ++ > server/file.h | 2 + > server/named_pipe.c | 499 > ++++++++++++++++++++++++++++++++++++++++++--- > 6 files changed, 510 insertions(+), 89 deletions(-) This is causing various random failures during make test. I don't have a good reproducible case, but it seems to randomly break communication with services. For instance I see mountmgr-related errors, or hangs in the msi tests. -- Alexandre Julliard julliard(a)winehq.org

3 6

Re: dsound: Avoid casts from COM object to interface.
by Andrew Eikum Dec. 9, 2016

Dec. 9, 2016

On Thu, Dec 08, 2016 at 11:29:42AM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 43b252d..d11c864 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -452,8 +452,8 @@ static HRESULT DirectSoundDevice_CreateSoundBuffer( > > if (device->primary) { > WARN("Primary Buffer already created\n"); > - IDirectSoundBuffer_AddRef((LPDIRECTSOUNDBUFFER8)(device->primary)); > - *ppdsb = (LPDIRECTSOUNDBUFFER)(device->primary); > + *ppdsb = (IDirectSoundBuffer *)&device->primary->IDirectSoundBuffer8_iface; > + IDirectSoundBuffer_AddRef(*ppdsb); > } else { Changing the order of these statements makes me nervous. Some applications use the returned pointers before the function returns, see 6a7c2f66e0569d2419eb9619e78716a9a5f94966. Andrew

1 0

[PATCH][RFC] msctf: Remove incorrect dereference of double pointer.
by Brock York Dec. 9, 2016

Dec. 9, 2016

This is my attempt at a fix for Helldivers crashing on startup. This is my first Wine patch and I don't know the msctf system. I'm removing a dereference because it *seems* like the right thing to do. It seems to pass the msctf tests on my Arch box. If someone with more knowledge of msctf can give this a review and see if it's sane that would be appreciated. --------Patch below-------- Fixes https://bugs.winehq.org/show_bug.cgi?id=41252 ThreadMgr_QueryInterface is expecting ppvOut to be a pointer to a pointer. When UIElementMgr_QueryInterface calls the ThreadMgr_QueryInterface function it derefences the void **ppvOut making it a void *ppvOut when passing it in. When ThreadMgr_QueryInterface attempts to dereference this pointer to assign a pointer to it, it is instead accessing the value ppvOut is suppose to be pointing at. When the pointer ppvOut points to is NULL this causes a null pointer dereference Tested on Arch Linux Signed-off-by: Brock York <twunknown(a)gmail.com> --- dlls/msctf/threadmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index e1f56f1..62ddfd2 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -1187,7 +1187,7 @@ static HRESULT WINAPI UIElementMgr_QueryInterface(ITfUIElementMgr *iface, REFIID { ThreadMgr *This = impl_from_ITfUIElementMgr(iface); - return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, *ppvOut); + return ITfThreadMgrEx_QueryInterface(&This->ITfThreadMgrEx_iface, iid, ppvOut); } static ULONG WINAPI UIElementMgr_AddRef(ITfUIElementMgr *iface) -- 2.10.2

2 1

Re: [website] German translation for release 1.9.24
by Henri Verbeet Dec. 9, 2016

Dec. 9, 2016

On 8 December 2016 at 16:06, Julian Rüger <jr98(a)gmx.net> wrote: > Dear D3D guys (esp. Stefan), do you have any suggestions or better translations for "unordered access views"? > Thanks! > My German isn't great, but "ungeordneten View-Zugriffen" sounds like "unordered view access" to me, which would be something else. (An UAV is a resource view that allows unordered/random read/write access to a resource from a shader, as opposed to e.g. shader resource views that only allow read access, or e.g. render target views that allow write access but only to a specific location.) You should probably check if Microsoft has an official translation for this, but lacking that I'd expect something along the lines of "ungeordnete Zugriffsview". Or whatever the appropriate translation of "view" would be in this context.

3 2

Re: [PATCH] ws2_32: Fix build failure on Mac
by Bruno Jesus Dec. 8, 2016

Dec. 8, 2016

On Fri, Dec 9, 2016 at 3:11 AM, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ws2_32/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index 3cdeade..6bf3c9d 100644 > --- a/dlls/ws2_32/socket.c > +++ b/dlls/ws2_32/socket.c > @@ -1230,7 +1230,7 @@ static BOOL get_dont_fragment(SOCKET s, int level, BOOL *out) > static int once; > if (!once++) > FIXME("IP_DONTFRAGMENT for IPv6 not supported in this platform\n"); > - return TRUE /* fake success */ > + return TRUE; /* fake success */ > #endif Sorry for that, I tested the defines before cloning the block and for some reason I messed the last block.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Alexandre Julliard Dec. 8, 2016

Dec. 8, 2016

Lauri Kenttä <lauri.kentta(a)gmail.com> writes: > v2: Win8 and Win10 give different results (sometimes even > different different results), so mark some cases as broken. > Also simplify the patch overall. I don't think that painting on the desktop window is a very useful test, and it can fail for various reasons. If the goal is to test LockWindowUpdate, you should do that with top-level windows instead. -- Alexandre Julliard julliard(a)winehq.org

3 5

Re: [PATCH 09/11] wined3d: Recognize dynamic linking shader instructions.
by Henri Verbeet Dec. 8, 2016

Dec. 8, 2016

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This patch was written while testing the ret instruction in subroutines. Sets > of function bodies/tables are not parsed yet. If preferred, it can be split > into 5 patches (one for each instruction). > Not enough to make you redo it, but yes, split would have been preferred.

1 0

Re: [PATCH 08/11] d3d11/tests: Add test for primitive restart.
by Henri Verbeet Dec. 8, 2016

Dec. 8, 2016

On 7 December 2016 at 12:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + get_texture_readback(test_context.backbuffer, 0, &rb); > + for (y = 0; y < 480; ++y) > + { > + for (x = 0; x < 640; ++x) > + { > + DWORD color = get_readback_color(&rb, x, y); > + DWORD expected_color; > + if (x < 240) > + expected_color = 0xffffff00; > + else if (x >= 640 - 240) > + expected_color = 0xff0000ff; > + else > + expected_color = 0x00000000; > + ok(compare_color(color, expected_color, 1), > + "Test %u: Got 0x%08x, expected 0x%08x at (%u, %u).\n", > + i, color, expected_color, x, y); > + } > + } > + release_resource_readback(&rb); For what it's worth, if we'll have more tests like this in the future, adding an optional rectangle argument to check_texture_color() may be useful.

1 0

Re: [PATCH] wincodecs: Remove some of error handling duplication in InitializePredefined()
by Dmitry Timoshkov Dec. 8, 2016

Dec. 8, 2016

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > case WICBitmapPaletteTypeFixedHalftone125: > colors = generate_halftone125_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone216: > colors = generate_halftone216_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone252: > colors = generate_halftone252_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > case WICBitmapPaletteTypeFixedHalftone256: > colors = generate_halftone256_palette(&count, add_transparent); > - if (!colors) return E_OUTOFMEMORY; > break; > > default: > @@ -406,6 +417,9 @@ static HRESULT WINAPI PaletteImpl_InitializePredefined(IWICPalette *iface, > return E_INVALIDARG; > } > > + if (!colors) > + return E_OUTOFMEMORY; That's hardly an improvement, at best this is a personal preference. When I wrote this code I was considering other versions as well, and current variant I like better. Please leave this code as it is. -- Dmitry.

1 0

Re: [PATCH] uxtheme: Return E_POINTER if RECT pointer is NULL.
by Nikolay Sivov Dec. 8, 2016

Dec. 8, 2016

On Tue, 6 Dec 2016 08:37:32 +0100 Hadrien Boizard <h.boizard(a)gmail.com> wrote: > DrawTextW(hdc, pszText, iCharCount, &rt, dwTextFlags|DT_CALCRECT); > + if(!pExtentRect) > + return E_POINTER; > *pExtentRect = rt; This needs a test.

1 0

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.
by Bruno Jesus Dec. 7, 2016

Dec. 7, 2016

On Tue, Nov 22, 2016 at 5:46 PM, Jeremy White <jwhite(a)codeweavers.com> wrote: > Signed-off-by: Jeremy White <jwhite(a)codeweavers.com> > --- > This addresses https://bugs.winehq.org/show_bug.cgi?id=11770 for systems with xdg-email. Hi, for unknown reasons I did not receive the v4 email so I'm replying here. Is there any way to test this without Microsoft Office? Best wishes, Bruno

2 1

Re: [PATCH] msacm32: Support conversion from 24-bit PCM
by Lauri Kenttä Dec. 7, 2016

Dec. 7, 2016

On 2016-12-05 19:28, Andrew Eikum wrote: > +static inline short C2416(int s) > +{ > + return HIWORD(s); > +} > + Just wondering: Is it true that msacm32 doesn't do any dithering? -- Lauri Kenttä

2 1

Re: [PATCH] kernel32/tests: Mask out FILE_ATTRIBUTE_COMPRESSED to prevent failures.
by Marvin Dec. 7, 2016

Dec. 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27243 Your paranoid android. === wxppro (32 bit file) === file.c:2389: Test failed: open failed for modes 40/2/40010000/2 file.c:2393: Test failed: wrong error code 32

1 0

Re: [TEST v2] user32/tests: Add tests for LockWindowUpdate.
by Marvin Dec. 7, 2016

Dec. 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27238 Your paranoid android. === wvistau64 (32 bit win) === win.c:8981: Test failed: GetActiveWindow() = 000200E0 win.c:8981: Test failed: GetFocus() = 000200E0 === w8 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200 === w864 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00111100 win.c:9390: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9397: Test failed: test 4: GetPixel: got 00ffffff, expected ffffffff win.c:9400: Test failed: test 5: GetPixel: got 00ffffff, expected 00222200

1 0

Re: [TEST] user32/tests: Add tests for LockWindowUpdate.
by Marvin Dec. 7, 2016

Dec. 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27237 Your paranoid android. === w8 (32 bit win) === win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (32 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (32 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w864 (64 bit win) === win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff === w1064 (64 bit win) === win.c:9386: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9388: Test failed: test 0: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00222200, expected ffffffff win.c:9394: Test failed: test 2: GetPixel: got 00222200, expected 00111100 win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff win.c:9403: Test failed: test 5: GetPixel: got 00222200, expected 00111100 win.c:9391: Test failed: test 1: GetPixel: got 00111100, expected ffffffff win.c:9400: Test failed: test 4: GetPixel: got 00222200, expected ffffffff

1 0

Re: [PATCH] ws2_32: Add support to disable networking with envvar WINENONET=1
by Jens Reyer Dec. 7, 2016

Dec. 7, 2016

On 07.12.2016 07:27, Bruno Jesus wrote: > I have used this in some situations to check how network enabled applications react to not having network access. IMO it is useful but if nobody cares I don't mind it being rejected. I like it. Can you document it in a manpage? Greets jre

2 2

Re: [PATCH] d2d1/tests: Change rotation angle in test_bitmap_brush().
by Henri Verbeet Dec. 7, 2016

Dec. 7, 2016

On 7 December 2016 at 13:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Fixes the test failure with Nvidia binary driver. > Well yes, but that's a much less interesting rotation.

1 0

Re: [PATCH] user32/tests: Add tests for LockWindowUpdate.
by Marvin Dec. 6, 2016

Dec. 6, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27177 Your paranoid android. === w8 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (32 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w864 (64 bit win) === win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff === w1064 (64 bit win) === win.c:9388: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9398: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff win.c:9410: Test failed: GetPixel: got 00123456, expected 00dedbef win.c:9393: Test failed: GetPixel: got 00dedbef, expected ffffffff win.c:9405: Test failed: GetPixel: got 00123456, expected ffffffff

1 0

WineHQ packages for 1.9.24
by Rosanne DiMesio Dec. 6, 2016

Dec. 6, 2016

WineHQ packages for 1.9.24 still haven't been built for any of the distros, and users are asking about them. What's going on? -- Rosanne DiMesio dimesio(a)earthlink.net

3 2

Serial port sniffing problem
by Bill Lionheart Dec. 6, 2016

Dec. 6, 2016

Using Wine version 1.8 on Ubuntu 14.04.5 I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a serial interface. The device is supplied with a Prolific USB serial converter which comes up as /dev/ttyUSB0 which I have sym linked to COM1 The bundled GPRS tracker config software installs and runs OK under Wine. But my attempts to sniff the serial port traffic fails using all the standard Linux methods I know. I also tried using the Windows program Serial Port Monitor under Wine http://www.eltima.com/products/serial-port-monitor/ . This program says it cannot detect any serial ports. Under Windows 7 the config program and Serial Port Monitor both work well and I can intercept all the serial traffic Any ideas please folks? Bill

3 4

Calling msvcp90 (C++) functions from Wine code
by Lauri Kenttä Dec. 6, 2016

Dec. 6, 2016

Hey, In a patch [1] I ended up recreating a function that practically exists already in msvcp90 as tr2_sys__Equivalent_wchar. However, I'm guessing it's not okay to call tr2_sys__Equivalent_wchar directly, since it's really a C++ function. Is there some valid and portable way to use this tr2_sys__Equivalent_wchar within another part of Wine (in this case, cmd.exe), to avoid duplicate code? [1] http://source.winehq.org/patches/data/128310 -- Lauri Kenttä

3 3

Re: [PATCH] user32: Handle WM_SYSKEYDOWN in MENU_SuspendPopup.
by Alexandre Julliard Dec. 5, 2016

Dec. 5, 2016

Alex Henrie <alexhenrie24(a)gmail.com> writes: > Technically, all the stuff about WM_SYSKEYDOWN is unnecessary. All we > really need to do is fix the error handling, or remove this questionable > optimization altogether. I'm not sure what you mean by that. Also you are essentially reverting d75b0cdc986f464f3067767cd53aca6b85feb366, I'd like to hear some justification for that. -- Alexandre Julliard julliard(a)winehq.org

2 5

Re: [PATCH v3] cmd: Fix copying when the dest is one of the sources.
by Marvin Dec. 5, 2016

Dec. 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27154 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2] cmd: Fix copying when the dest is one of the sources.
by Marvin Dec. 5, 2016

Dec. 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27152 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 534 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: kernel32: Implement Process thread attribute lists.
by Dmitry Timoshkov Dec. 5, 2016

Dec. 5, 2016

Huw Davies <huw(a)codeweavers.com> wrote: > diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec > index 3c25286..224e6ae 100644 > --- a/dlls/kernel32/kernel32.spec > +++ b/dlls/kernel32/kernel32.spec ... > +@ stdcall DeleteProcThreadAttributeList(ptr) ... > +@ stdcall InitializeProcThreadAttributeList(ptr long long ptr) ... > +@ stdcall UpdateProcThreadAttribute(ptr long long ptr long ptr ptr) UMS (User Mode Scheduler) stuff should be implemented in ntdll and kernel32 APIs should be either forwards or thin wrappers around the ntdll exports. So, to avoid duplicate efforts this all from the start needs to be implemeted in ntdll. -- Dmitry.

2 5

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Hans Leidekker Dec. 5, 2016

Dec. 5, 2016

On Sat, 2016-12-03 at 00:15 -0200, Bruno Jesus wrote: > @@ -2446,8 +2476,32 @@ static int WS2_send( int fd, struct ws2_async *wsa, int flags ) > return -1; > } > > + if (wsa->addr->sa_family == WS_AF_INET) > + { > + /* When the target IPv4 address ends in 255 we are going to check if > + * it matches the broadcast address. Trying to send the packet without > + * setting SO_BROADCAST results in EACCES, to avoid that we will enable > + * the flag and send the packet, after that we will restore the flag > + * This is the most common estimate to reduce the number of UDP packets > + * that we need to check. */ > + struct sockaddr_in *addr = (struct sockaddr_in*) hdr.msg_name; > + in_addr_t address = addr->sin_addr.s_addr; > + > + if (address != INADDR_BROADCAST && (address & 0xFF000000) == 0xFF000000) This doesn't work for a /25 network, for example. You really need to use the network mask here to calculate the broadcast address. > +/* required for broadcast tests */ > +static void disable_firewall(void) > +{ > + system("netsh firewall set opmode disable"); /* XP */ > + system("netsh Advfirewall set allprofiles state off"); /* >= Vista*/ > +} > + > +static void enable_firewall(void) > +{ > + system("netsh firewall set opmode enable"); /* XP */ > + system("netsh Advfirewall set allprofiles state on"); /* >= Vista*/ > +} This will not work if the test is run as an unprivileged user. It would be better to use an API like INetFwMgr and skip the affected tests when you can't modify the firewall. I'm working on a fix for a similar problem in the rpcrt4 test. I can share a patch if you're interested.

3 6

Re: [PATCH v2] wined3d: Implement SM5 atomic_umax/min instructions.
by Józef Kucia Dec. 5, 2016

Dec. 5, 2016

On Sun, Dec 4, 2016 at 6:49 PM, Kimmo Myllyvirta <kimmo.myllyvirta(a)gmail.com> wrote: > @@ -897,6 +899,8 @@ static const struct wined3d_sm4_opcode_info opcode_table[] = > {WINED3D_SM5_OP_LD_STRUCTURED, WINED3DSIH_LD_STRUCTURED, "u", "iiR"}, > {WINED3D_SM5_OP_STORE_STRUCTURED, WINED3DSIH_STORE_STRUCTURED, "U", "iiu"}, > {WINED3D_SM5_OP_ATOMIC_IADD, WINED3DSIH_ATOMIC_IADD, "U", "ii"}, >+ {WINED3D_SM5_OP_ATOMIC_UMAX, WINED3DSIH_ATOMIC_UMAX, "U", "uu"}, >+ {WINED3D_SM5_OP_ATOMIC_UMIN, WINED3DSIH_ATOMIC_UMIN, "U", "uu"}, This is wrong. The generated GLSL code will produce compiler errors. FWIW, I should have patches for various atomics with some tests soon.

2 1

Re: [PATCH 03/18] d3d11/tests: Add test for depth/stencil shader resource views.
by Henri Verbeet Dec. 5, 2016

Dec. 5, 2016

On 5 December 2016 at 12:04, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 335 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 335 insertions(+) > This fails here on Windows: d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6578: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6582: Test failed: Got unexpected value 1.00000000e+002 at (0, 0), sub-resource 0. d3d11.c:6590: Test failed: Got unexpected value 2.55199997e+002 at (0, 0), sub-resource 0. d3d11.c:6594: Test failed: Got unexpected value 3.29999995e+000 at (0, 0), sub-resource 0. d3d11.c:6598: Test failed: Got unexpected value 4.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6524: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6528: Test failed: Got unexpected value 0.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6532: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0. d3d11.c:6550: Test failed: Got unexpected value 6.00000024e-001 at (0, 0), sub-resource 0. d3d11.c:6554: Test failed: Got unexpected value 1.00000000e+000 at (0, 0), sub-resource 0.

1 0

Re: [PATCH 02/18] wined3d: Set default sampler minification filter to GL_NEAREST.
by Józef Kucia Dec. 5, 2016

Dec. 5, 2016

On Mon, Dec 5, 2016 at 12:04 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > This seems to be required for reading stencil values. The GL spec says > "When sampling the stencil index only NEAREST filtering is supported.". > The GL spec is inconsistent about this, but Mesa refuses to sample > stencil index values with the GL_NEAREST_MIPMAP_NEAREST filter. The NEAREST_MIPMAP_NEAREST is going to be allowed in Mesa (there is a patch for this [1]). However, the ARB_stencil_texturing spec was never updated, and an implementation of OpenGL which does not expose GL 4.5 doesn't have to allow using NEAREST_MIPMAP_NEAREST for stencil texturing. [1] - https://lists.freedesktop.org/archives/mesa-dev/2016-December/137309.html

1 0

Re: [PATCH] user32: Fix handling of invert_y in DrawTextExW.
by Dmitry Timoshkov Dec. 5, 2016

Dec. 5, 2016

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > From: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> 1. this needs some tests 2. are you planning to fix any regressions caused by this patch without relying on Sebastian's help? -- Dmitry.

2 2

Windows 2008 does not support MP3 correctly in msacm32.dll?
by Bruno Jesus Dec. 4, 2016

Dec. 4, 2016

Hi, in an attempt to add MP3 tests from Michael Müller it looks like the only machine that has trouble is Windows 2008 [1]. Around half of the tests are rejected while in all other versions it worked fine. Could there be a simple explanation to this? [1] https://testbot.winehq.org/JobDetails.pl?Key=27009 Best wishes, Bruno

2 2

Re: [PATCH] Updated Readme with Github Markdown
by Alex Henrie Dec. 4, 2016

Dec. 4, 2016

Hello Varunram, and thanks for your interest in contributing to Wine. The patch you submitted is very unlikely to be accepted because we, like the Linux kernel and many other projects, optimize our READMEs for terminal text editors rather than for GitHub. Also, if you submit any more patches in the future, please be sure to use your real name and include a Signed-off-by line. -Alex

1 0

WineHQ Forums: Slackware multi-lib Wine build issues
by Bob Wya Dec. 4, 2016

Dec. 4, 2016

Hiya, I've gotten really stuck trying to help out a Slackware user (yes they still exist!) on the WineHQ forums... Been bashing away at this problem for over a month now. He's trying to build a Shared WoW64 Wine. The build logs look clean. But the 32-bit half of Wine is segfaulting immediately. The 64-bit half appears to function as normal. I feel like I've hit a brick wall now... Anyone able to help? See: https://forum.winehq.org/viewtopic.php?f=8&t=27879 -- All the best, Robert

1 0

Re: [v2 1/2] wined3d: Implement primitive restart index.
by Józef Kucia Dec. 4, 2016

Dec. 4, 2016

On Fri, Nov 18, 2016 at 4:44 AM, Andrew Wesie <awesie(a)gmail.com> wrote: > @@ -8602,6 +8602,16 @@ static void shader_glsl_init_context_state(struct wined3d_context *context) > > gl_info->gl_ops.gl.p_glEnable(GL_PROGRAM_POINT_SIZE); > checkGLcall("GL_PROGRAM_POINT_SIZE"); > + if (gl_info->supported[ARB_ES3_COMPATIBILITY]) > + { > + /* We prefer this method because it correctly handles 16-bit and 32-bit indices. */ > + gl_info->gl_ops.gl.p_glEnable(GL_PRIMITIVE_RESTART_FIXED_INDEX); > + checkGLcall("GL_PRIMITIVE_RESTART_FIXED_INDEX"); > + } Is it really safe to enable the primitive restart for all D3D versions? Shouldn't we enable it just for D3D10+? See, e.g., e47a735f762ebe1545bb366c7e9e2b90db7c7f80, if it's decided that this should be enabled just for D3D10+. > + else > + { > + WARN("Missing support for primitive restart index.\n"); > + } This is not important, but ideally this would be a FIXME() for D3D10+ feature level >= 10_0 and nothing otherwise. > } > > static void shader_glsl_get_caps(const struct wined3d_gl_info *gl_info, struct shader_caps *caps) > diff --git a/dlls/wined3d/wined3d_gl.h b/dlls/wined3d/wined3d_gl.h > index b71190d..7bd2d6a 100644 > --- a/dlls/wined3d/wined3d_gl.h > +++ b/dlls/wined3d/wined3d_gl.h > @@ -55,6 +55,7 @@ enum wined3d_gl_extension > ARB_DRAW_ELEMENTS_BASE_VERTEX, > ARB_DRAW_INSTANCED, > ARB_ES2_COMPATIBILITY, > + ARB_ES3_COMPATIBILITY, > ARB_EXPLICIT_ATTRIB_LOCATION, > ARB_FRAGMENT_COORD_CONVENTIONS, > ARB_FRAGMENT_PROGRAM, The extension has to be also added to the "core_extensions" table.

2 2

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Lauri Kenttä Dec. 3, 2016

Dec. 3, 2016

On 2016-12-03 22:27, Lauri Kenttä wrote: > Inspired by bug 7961. > > v2: Apparently Windows has much more strict limits for file names on > native file systems (compared to VirtualBox shared folders), so this > version of the patch leaves out some of the more problematic ones. > Tested on Windows 2003 Server with NTFS. The remaining TestBot failures are not my fault, again. Also, the "much more strict limits" part was a bit exaggerated. There were simply two file names ending with dots, even though I knew they wouldn't work on FAT32 or NTFS. I thought I had removed them already. Anyway, that's fixed in this v2. -- Lauri Kenttä

1 0

Re: [PATCH v2] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin Dec. 3, 2016

Dec. 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27101 Your paranoid android. === wxppro (32 bit file) === file.c:2388: Test failed: open failed for modes 0/2/c0000000/2 file.c:2392: Test failed: wrong error code 32 === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820

1 0

Re: [PATCH] kernel32/tests: Test FindFirstFile etc. with wildcards.
by Marvin Dec. 3, 2016

Dec. 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27099 Your paranoid android. === wxppro (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2003std (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (32 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7u (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w8 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (32 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === wvistau64 (64 bit file) === file.c:460: Test failed: attributes of file "testfile.xxx" are 0x0820 file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w2008s64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w7pro64 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w864 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none === w1064 (64 bit file) === file.c:2898: Test failed: FindFirstFile with '*.' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '*. .' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with '* ..' found correctly '.', '..', 'a', 'aa', 'aaa', 'aaaa', found incorrectly '.a', '..a', '.aa', '.aaa', and missed none file.c:2898: Test failed: FindFirstFile with ' *..' found correctly none, found incorrectly '.aaa', and missed 'a' file.c:2898: Test failed: FindFirstFile with '?' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?. ' found correctly 'a', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??.' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '??. ' found correctly 'a', 'aa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '???.' found correctly 'a', 'aa', 'aaa', found incorrectly '.', '..', and missed none file.c:2898: Test failed: FindFirstFile with '?.??.' found correctly '.', '.a', '.aa', 'a', 'a.a', 'a.aa', found incorrectly '..', and missed none

1 0

Re: [PATCH] ws2_32: Implement automatic broadcast for UDP sockets on sendto() (try 2)
by Marvin Dec. 2, 2016

Dec. 2, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27089 Your paranoid android. === w2003std (32 bit sock) === An error occurred while retrieving the test report: network read got a premature EOF (getfile:ListSize:0/4) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0