December 2016 - Wine-Devel - list.winehq.org

Re: [v3] winex11: Use XIAllDevices to select for XI_RawMotion
by Carlos Garnacho Dec. 15, 2016

Dec. 15, 2016

Hi all, Got this message from Marvin about "formatting", but I'm not sure what could have triggered this. Getting picky I see the parens at the update_relative_valuators function aren't alright given surrounding code style, but I see nothing specifically against https://wiki.winehq.org/Submitting_Patches#Code_guidelines or https://source.winehq.org/patches/#legend Is there anything actually wrong? I'll be happy to send an updated patch. Cheers, Carlos On Mon, Dec 12, 2016 at 11:15 PM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Formatting". > > This means that there are some formatting issues with your > patch. Either the author's full name, email address, or Signed-off-by > headers are missing, indentation is messed up (usually from editing > with a non-standard tab size), or there are gratuitous formatting > changes to the code. You need to resend a fixed patch. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

2 2

wine-staging status
by Michael Cronenworth Dec. 14, 2016

Dec. 14, 2016

Hi, Is Wine Staging on hiatus? MIA? DIA? It has been one month since the last release with no signs of any new commits. I sent an e-mail to Sebastian but no response yet. Thanks, Michael

3 2

Re: [PATCH 3/3] msvcrt: Make wcstoi64 support various Unicode digits.
by Henri Verbeet Dec. 14, 2016

Dec. 14, 2016

On 13 December 2016 at 19:48, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: > @@ -2027,6 +2027,19 @@ static int wctoint(WCHAR c, int base) > v = c - 'A' + 10; > else if ('a' <= c && c <= 'z') > v = c - 'a' + 10; > + else { > + /* Unicode points that contain digits 0-9; keep this sorted! */ > + static const WCHAR zeros[] = { > + 0x660, 0x6f0, 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, > + 0xd66, 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0xff10 > + }; > + int i; > + for (i = 0; i < sizeof(zeros)/sizeof(zeros[0]) && c >= zeros[i]; ++i) { > + if (zeros[i] <= c && c < zeros[i] + base) { Using "base" here seems questionable. That would imply that e.g. with base 16, "\x6f2\x6fa"/"۲ۺ" would return "42". Is that really the case? For what it's worth, note also that Wine has wine_fold_string(), which should be consistent with FoldString().

4 8

Re: [PATCH 1/3] msvcrt/tests: Test wcstoi64 with various Unicode digits.
by Piotr Caban Dec. 14, 2016

Dec. 14, 2016

Hi Lauri, On 12/13/16 19:48, Lauri Kenttä wrote: > + static const WCHAR zeros[] = { > + 0xe50, 0xed0, 0x1040, 0x17e0, 0x1810, 0x660, 0x6f0, 0xff10, > + 0x966, 0x9e6, 0xa66, 0xae6, 0xb66, 0xc66, 0xce6, 0xd66 > + }; Please also add a test for Tibetan digits range: https://unicode-table.com/en/0F20/ > + /* Test various unicode digits */ > + for (i = 0; i < sizeof(zeros) / sizeof(zeros[0]); ++i) { > + WCHAR tmp[] = {zeros[i]+4, zeros[i], zeros[i]+5, 0}; > + res = p_wcstoi64(tmp, NULL, 0); > + todo_wine ok(res == 405, "with zero = %#x: got %d, expected 405\n", zeros[i], (int)res); Could you please also add following test: tmp[1] = zeros[i]+10; res = p_wcstoi64(tmp, NULL, 16); ok(res == 4, ...); Thank you, Piotr

2 1

Re: webservices: allocate enough memory for WS_XML_TEXT_TYPE_DOUBLE (Valgrind) (try 2)
by Henri Verbeet Dec. 14, 2016

Dec. 14, 2016

On 13 December 2016 at 20:17, Austin English <austinenglish(a)gmail.com> wrote: > + /* buf was originally [24], increased to 48 to prevent a stack smashing error when running tests under Valgrind */ > + unsigned char buf[48]; /* "-1.1111111111111111E-308". */ The more interesting comment would perhaps be what actually happens and why this helps. One thing I do notice is that while 24 chars would be enough to hold "-1.1111111111111111E-308", that doesn't leave any room for the \0 terminator, while the other cases above this one do seem to include space for that.

2 5

Re: [PATCH] shlwapi: Changed UrlEscapeW error paths and add tests
by Jacek Caban Dec. 14, 2016

Dec. 14, 2016

Hi Fabian, On 13.12.2016 22:53, Fabian Maurer wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=41956 > > Also changed wininet:HTTP_HandleRedirect to not break it. > On windows output buffer must not be NULL, > and size must not be NULL or zero, > or it won't return the number of needed characters. Please send wininet changes as separated patch. They don't depend on shlwapi, so may be applied separately, before shlwapi patch. Other than that and one small comment bellow, the patch looks good. Thanks. > + /* Check error paths */ > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); You set and test size although the actual call doesn't use it. Please remove lines with size. Same in a few more cases. > + > + size = 0; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 0; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 0, "got %d, expected %d\n", size, 0); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, NULL, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, NULL, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_INVALIDARG, "got %x, expected %x\n", ret, E_INVALIDARG); > + ok(size == 1, "got %d, expected %d\n", size, 1); > + > + size = 1; > + ret = UrlEscapeW(path_test, empty_string, &size, URL_ESCAPE_SPACES_ONLY); > + ok(ret == E_POINTER, "got %x, expected %x\n", ret, E_POINTER); > + ok(size == 6, "got %d, expected %d\n", size, 6); Thanks, Jacek

3 2

Wine Swag and Promotion
by Aric Stewart Dec. 13, 2016

Dec. 13, 2016

Hello all, So at this last wineconf we had a great discussion around promotion of the wine project and how we get more interaction with the broader open source developer and user community. As part of that we really wanted people to step up and volunteer to attend conferences, Linux user groups, shows and wherever they can to talk about wine. Jeremy reminded everyone that there is money in the wine project budget to compensate people for expenses around this. The job I volunteered to take on was that of swag master. It was agreed that we should have some things to give away at these events. Many projects have stickers and other goodies that they distribute, sell or otherwise get out into the community to increase visible footprint. The expense of these will come out of the wine project funds and we need to discuss the best way to manage it. Right now, I still have a number of leftover badge flags from FOSDEM, probably about 100 of them. If you are attending a conference with badges and you want some to distribute contact me and I can get that sent out. My first thought was that we should have a sticker stockpile. Stickers seem like a good first step. Here I have brought in Jana from CodeWeavers Marketing to help. She has agreed to design some stickers for us when she has free time (probably prototypes in early Jan) and talk to her production contacts on quotes for production of the stickers. We are thinking 2" x 4" oval or die-cut stickers. The price per sticker drops so dramatically with volume that doing smaller on demand printings seems counter productive. This would mean that there would be a mailing expense to ship the stickers from St. Paul, MN to each event. But with enough time, less expensive shipping can be selected and it just seems like the shipping expense would be out-weighted by production savings. The question I am posing out to you, the broader community, is if this sounds like a good first step plan? Also, what else do you think we should have a swag? Should I reorder badge flags when we run out? I know t-shirts are always popular but they tend to be enough more expensive that they are not really give-away items. Thoughts? I will send more info when Jana produces the sticker prototypes. Finally, I do have the flags, so right now, if you are off to an event and want to start with that as swag feel free to contact me! Thanks! -aric

2 1

Re: winhttp: Handle EINTR from connect and poll.
by Bruno Jesus Dec. 13, 2016

Dec. 13, 2016

On Tue, Dec 13, 2016 at 7:33 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > dlls/winhttp/net.c | 47 +++++++++++++++++++++++++++++++++-------------- > 1 file changed, 33 insertions(+), 14 deletions(-) Hi, Isn't it better to make winhttp use ws2_32 just like wininet change [1]? Then we would have a single point for all networking code and EINTR is already covered in ws2_32. [1] http://source.winehq.org/git/wine.git/commitdiff/5436fef80722fe7896aed5e659… Best Regards, Bruno

2 3

Re: [PATCH 3/3] wined3d: Filter messages for fullscreen mode changes.
by Marvin Dec. 13, 2016

Dec. 13, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27335 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: [PATCH 2/3] d3d9/tests: Add test showing WM_SIZE is not sent during fullscreen mode change.
by Marvin Dec. 13, 2016

Dec. 13, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27334 Your paranoid android. === w864 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4425: Test failed: cw is 0xf60, expected 0x7f. device.c:4434: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0