February 2016 - Wine-Devel - list.winehq.org

Re: user32: Select text control content while setting initial dialog focus
by Hugh McMaster Feb. 16, 2016

Feb. 16, 2016

On Tue, 16 Feb 2016 08:04:35 +0800, Dmitry Timoshkov wrote: >>Piotr Caban wrote: >> --- a/dlls/user32/dialog.c >> +++ b/dlls/user32/dialog.c >> @@ -707,7 +707,11 @@ static HWND DIALOG_CreateIndirect( HINSTANCE hInst, LPCVOID dlgTemplate, >> focus = GetNextDlgTabItem( hwnd, 0, FALSE ); >> if (!focus) focus = GetNextDlgGroupItem( hwnd, 0, FALSE ); >> if (focus) >> + { >> + if (SendMessageW( focus, WM_GETDLGCODE, 0, 0 ) & DLGC_HASSETSEL) >> + SendMessageW( focus, EM_SETSEL, 0, -1 ); >> SetFocus( focus ); >> + } >> } > >Selecting the text on SetFocus() is the job of DefDlgProc(), it's worth >to investigate why it doesn't work. I'm guessing this doesn't work for the same (or similar) reasons as with the combo box issue. -- Hugh McMaster

1 0

Re: shell32/tests: Take into account the Windows 10 DDE race condition.
by Marvin Feb. 16, 2016

Feb. 16, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20511 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:1685: Test failed: ShellExecute(verb="QuotedLowerL", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1714: Test failed: ShellExecute(verb="QuotedLowerL", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.shlexec") argvA3 expected 'QuotedLowerL', but key not found or empty shlexec.c:1722: Test failed: ShellExecute(verb="QuotedLowerL", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.shlexec") argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.shlexec', but key not found or empty shlexec.c:1714: Test failed: ShellExecute(verb="QuotedUpperL", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.shlexec") argvA3 expected 'QuotedUpperL', got 'QuotedLowerL' shlexec.c:1685: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\masked file.shlexec") WaitForSingleObject returned 258 shlexec.c:1714: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\masked file.shlexec") argvA3 expected 'Open', but key not found or empty shlexec.c:1722: Test failed: ShellExecute(file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\masked file.shlexec") argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\masked file.shlexec', but key not found or empty shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" failed: rc=2 err=2 shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" failed: rc=2 err=2 shlexec.c:2456: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2473: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" failed: rc=2 err=2 shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2 file.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.exe"", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.exe" param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2 file.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2 file.exe"", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2 file.exe" param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2 param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\notexist.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\notexist.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="cmd", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="cmd param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="xyzwxyzwxyz", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2570: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test file.sde") Assoc ext=".sde", verb="Open", rawcmd="1", cmdtail="xyzwxyzwxyz param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2855: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2858: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec") argvA3 expected 'Exec', but key not found or empty shlexec.c:2859: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2.exe', but key not found or empty shlexec.c:2863: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2868: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp") WaitForSingleObject returned 258 shlexec.c:2868: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2871: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp") argvA3 expected 'Exec', but key not found or empty shlexec.c:2872: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2.exe', but key not found or empty shlexec.c:2876: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="%TMPDIR%") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2880: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="%TMPDIR%") WaitForSingleObject returned 258 shlexec.c:2880: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="%TMPDIR%") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2883: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="%TMPDIR%") argvA3 expected 'Exec', but key not found or empty shlexec.c:2884: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="%TMPDIR%") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\test2.exe', but key not found or empty shlexec.c:2889: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp\wtD46E.tmp" Exec", dir="C:\Users\Public\Documents:C:\Users\winetest\AppData\Local\Temp\wtD45E.tmp") ShlexecVar expected 'Present', but key not found or empty

1 0

Re: advapi32/tests: Use todo_wine_if() in tests
by Marvin Feb. 16, 2016

Feb. 16, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20503 Your paranoid android. === w1064 (32 bit security) === security.c:3753: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:3794: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:3798: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3807: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0)

1 0

Re: wininet/tests: Use todo_wine_if() in tests
by Marvin Feb. 15, 2016

Feb. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20501 Your paranoid android. === w1064 (32 bit http) === http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1763: Test failed: Expected 2, got 4 http.c:1764: Test failed: Expected CRLF, got ' http.c:2398: Test failed: count was wrong http.c:2399: Test failed: http data wrong, got: Garbage: Header http.c:3062: Test failed: HttpAddRequestHeaders succeeded http.c:3063: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3068: Test failed: code = 200, expected 400 http.c:3068: Test failed: unexpected status code 200, expected 400 http.c:3068: Test failed: unexpected status code 200, expected 400 http.c:524: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: crypt32/tests: Use todo_wine_if() in tests
by Marvin Feb. 15, 2016

Feb. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20499 Your paranoid android. === w1064 (32 bit chain) === chain.c:128: Test failed: Expected CRYPT_E_NOT_FOUND, got 00000002 === w864 (64 bit store) === store.c:2596: Test failed: CertAddCertificateContextToStore failed store.c:2597: Test failed: Unexpected cert3 store: unhandled exception c0000005 at 000000000044D8EE

1 0

Re: [PATCH] packet: create packet.dll and Implement GetAdapterNames
by Sebastian Lackner Feb. 15, 2016

Feb. 15, 2016

I am not sure if André wants to have this dll in wine, but nevertheless, here some comments. On 14.02.2016 16:10, Jianqiu Zhang wrote: > From dfc572cd1b1cdf51b84a5e367d054473c3c3e99d Mon Sep 17 00:00:00 2001 > From: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net> > Date: Sun, 14 Feb 2016 17:27:37 +0800 > Subject: [PATCH] packet: create packet.dll and Implement GetAdapterNames > > Signed-off-by: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net> > --- > dlls/packet/Makefile.in | 5 ++++ > dlls/packet/packet.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++ > dlls/packet/packet.spec | 32 +++++++++++++++++++++++++ Changes to configure.ac are missing. In this case its especially critical because compilation of packet.dll would have to be disabled, when pcap header files are not present. Take a look at how its done for wpcap.dll. > 3 files changed, 100 insertions(+) > create mode 100644 dlls/packet/Makefile.in > create mode 100644 dlls/packet/packet.c > create mode 100644 dlls/packet/packet.spec > > diff --git a/dlls/packet/Makefile.in b/dlls/packet/Makefile.in > new file mode 100644 > index 0000000..6ab9f08 > --- /dev/null > +++ b/dlls/packet/Makefile.in > @@ -0,0 +1,5 @@ > +MODULE = packet.dll > +DELAYIMPORTS = iphlpapi A regular import would make more sense here. > + > +C_SRCS = \ > + packet.c > diff --git a/dlls/packet/packet.c b/dlls/packet/packet.c > new file mode 100644 > index 0000000..c6d1568 > --- /dev/null > +++ b/dlls/packet/packet.c > @@ -0,0 +1,63 @@ > +#include "config.h" > +#include "wine/port.h" > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "windows.h" > +#include "wine/debug.h" > + > +#include "winsock2.h" > +#include "iphlpapi.h" > +#include "ntddndis.h" > + > +#include <pcap/pcap.h> For the first patch, you will most likely not need all those headers. You should add them in later patches, whenever you implement a function which needs them. > + > +WINE_DEFAULT_DEBUG_CHANNEL(packet); > + > +BOOLEAN PacketGetAdapterNames(char *nameList, PULONG pSize) The calling convention (CDECL, WINAPI) is missing. Also, variable names are usually lower-case only, and without "p" prefix. Types like P* or LP* should also be avoided in the wine source. > +{ > + IP_ADAPTER_INFO *adInfo, *adInfoList = NULL; > + DWORD errcode; > + ULONG needsize = 0, minDescLen = 0, minAdNameLen = 0, minTotLen = 0, nameOffset, descOffset; > + > + TRACE("nameList %p &size %p size %d\n", nameList, pSize, *pSize); > + > + errcode = GetAdaptersInfo(adInfoList, &needsize); > + adInfoList = HeapAlloc(GetProcessHeap(), 0, needsize); Its a matter of taste, but checking return values for HeapAlloc functions usually does not hurt. > + > + TRACE("Get the needed space(%d) for adInfo\n", needsize); > + > + errcode = GetAdaptersInfo(adInfoList, &needsize); > + if(errcode) > + { You are leaking memory here. The same applies for a couple of other return paths. > + SetLastError(errcode); > + return FALSE; > + } > + for(adInfo = adInfoList; adInfo != NULL; adInfo = adInfo->Next) > + { > + minAdNameLen += lstrlenA(adInfo->AdapterName) + 1; > + minDescLen += lstrlenA(adInfo->Description) + 1; > + } > + minTotLen = minAdNameLen + minDescLen + 2; > + TRACE("minAdNameLen = %d, minDescLen = %d\n", minAdNameLen, minDescLen); Such a trace is only useful during debugging. > + if(nameList == NULL || *pSize < minTotLen) > + { > + SetLastError(ERROR_INSUFFICIENT_BUFFER); > + *pSize = minTotLen; > + return FALSE; > + } > + > + nameOffset = descOffset = 0; > + for(adInfo = adInfoList; adInfo != NULL; adInfo = adInfo->Next) > + { > + lstrcpyA(nameList + nameOffset, adInfo->AdapterName); > + lstrcpyA(nameList + minAdNameLen + descOffset + 1, adInfo->Description); > + nameOffset += lstrlenA(adInfo->AdapterName) + 1; > + descOffset += lstrlenA(adInfo->Description) + 1; > + } > + nameList[minAdNameLen] = '\0'; > + nameList[minTotLen - 1] = '\0'; > + return TRUE; > +} > diff --git a/dlls/packet/packet.spec b/dlls/packet/packet.spec > new file mode 100644 > index 0000000..b7f2781 > --- /dev/null > +++ b/dlls/packet/packet.spec > @@ -0,0 +1,32 @@ > + 1 stub PacketAllocatePacket Wine does not care about exact ordinal numbers. You can mark them all as "@". > + 2 stub PacketCloseAdapter > + 3 stub PacketFreePacket > + 4 cdecl PacketGetAdapterNames(str long) The first parameter is a buffer which is filled out by the function, so 'ptr' would make more sense. The second parameter is a pointer, not long. > + 5 stub PacketGetAirPcapHandle > + 6 stub PacketGetDriverVersion > + 7 stub PacketGetNetInfoEx > + 8 stub PacketGetNetType > + 9 stub PacketGetReadEvent > +10 stub PacketGetStats > +11 stub PacketGetStatsEx > +12 stub PacketGetVersion > +13 stub PacketInitPacket > +14 stub PacketIsDumpEnded > +15 stub PacketLibraryVersion > +16 stub PacketOpenAdapter > +17 stub PacketReceivePacket > +18 stub PacketRequest > +19 stub PacketSendPacket > +20 stub PacketSendPackets > +21 stub PacketSetBpf > +22 stub PacketSetBuff > +23 stub PacketSetDumpLimits > +24 stub PacketSetDumpName > +25 stub PacketSetHwFilter > +26 stub PacketSetLoopbackBehavior > +27 stub PacketSetMinToCopy > +28 stub PacketSetMode > +29 stub PacketSetNumWrites > +30 stub PacketSetReadTimeout > +31 stub PacketSetSnapLen > +32 stub PacketStopDriver > > > >

1 0

Re: [PATCH] mscoree: Implement ICorRuntimeHost::CreateDomain{, Ex}(). (try 2)
by Vincent Povirk Feb. 15, 2016

Feb. 15, 2016

I wrote a test program (attached), and it doesn't work: CreateDomain failed, hr=80004002 I didn't investigate, but I remember the issue I ran into when I tried to implement this. AppDomain.CreateDomain doesn't return a "real" AppDomain object, it returns a TransparentProxy, and the TransparentProxy doesn't support the _AppDomain interface. The real AppDomain object lives in the newly-created appdomain. I think you could get the real AppDomain and an IUnknown pointer for it if you used the newly-created MonoDomain, but I suspect the MonoDomain pointer you're getting is also wrong. Also, I'm not sure it's necessary to lock the RuntimeHost while creating the new AppDomain, it should only be needed when accessing the list.

1 1

Re: [PATCH 2/2] ntdll: Improve invalid paramater handling in NtAccessCheck.
by Marvin Feb. 15, 2016

Feb. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20489 Your paranoid android. === w1064 (32 bit security) === security.c:3802: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:3843: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:3847: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3856: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0)

1 0

Re: [PATCH 1/2] advapi32/tests: Add invalid paramater tests for AccessCheck.
by Marvin Feb. 15, 2016

Feb. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20488 Your paranoid android. === w1064 (32 bit security) === security.c:3806: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:3847: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:3851: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3860: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0)

1 0

Re: [PATCH] kernel32/tests: Use todo_wine_if() in tests
by Marvin Feb. 15, 2016

Feb. 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20487 Your paranoid android. === w1064 (32 bit locale) === locale.c:2365: Test failed: LCMapStringEx should fail with bad locale name locale.c:2366: Test failed: unexpected error code -559038737 locale.c:2457: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4167: Test failed: IsValidLocaleName should have failed locale.c:4169: Test failed: IsValidLocaleName should have failed locale.c:4534: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4536: Test failed: For id 7, Expected IVC, got '' === w1064 (32 bit loader) === loader.c:2733: Test failed: Test 0: ResolveDelayLoadedAPI failed loader.c:2734: Test failed: Test 0: expected 74374550, got 00000000 loader.c:2733: Test failed: Test 1: ResolveDelayLoadedAPI failed loader.c:2734: Test failed: Test 1: expected 72BC2CF0, got 00000000 loader.c:2733: Test failed: Test 2: ResolveDelayLoadedAPI failed loader.c:2734: Test failed: Test 2: expected 74372DC0, got 00000000 loader.c:2741: Test failed: Test 3: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2742: Test failed: Test 3: Wrong callback count: 0 loader.c:2741: Test failed: Test 4: ResolveDelayLoadedAPI succeeded with 00000000 loader.c:2742: Test failed: Test 4: Wrong callback count: 0 loader.c:1820: Test failed: expected STILL_ACTIVE, got 195 loader.c:1855: Test failed: expected STILL_ACTIVE, got 195

1 0