February 2016 - Wine-Devel - list.winehq.org

Re: bthprops.cpl: add BluetoothFindFirstRadio/BluetoothFindRadioClose stubs (try 2)
by Dmitry Timoshkov Feb. 25, 2016

Feb. 25, 2016

Austin English <austinenglish(a)gmail.com> wrote: > +/********************************************************************* > + * BluetoothFindFirstRadio > + */ > +HBLUETOOTH_RADIO_FIND WINAPI BluetoothFindFirstRadio(BLUETOOTH_FIND_RADIO_PARAMS *params, HANDLE *radio) > +{ > + FIXME("(%p %p): stub!\n", params, radio); > + *radio = NULL; > + SetLastError(ERROR_NO_MORE_ITEMS); > + return NULL; > +} > + > +HBLUETOOTH_RADIO_FIND WINAPI BluetoothFindRadioClose(HBLUETOOTH_RADIO_FIND find) > +{ > + FIXME("(%p): stub!\n", find); > + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > + return FALSE; > +} Is there a reason that first API has a comment while second does not? Also, both APIs have the same return type but you return NULL vs. FALSE. -- Dmitry.

1 0

Re: [PATCH] mshtml: Fixed tests on some IE versions.
by Marvin Feb. 24, 2016

Feb. 24, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20862 Your paranoid android. === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w1064 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found === w1064 (64 bit) === No test summary line found

1 0

Re: [PATCH v2] ntdll: Finish serial reads of size 0 immediately.
by Alexandre Julliard Feb. 24, 2016

Feb. 24, 2016

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -854,11 +857,11 @@ NTSTATUS WINAPI NtReadFile(HANDLE hFile, HANDLE hEvent, > goto done; > } > } > - else if (type == FD_TYPE_SERIAL || type == FD_TYPE_DEVICE) > + else if (type == FD_TYPE_SERIAL) > { > - if (async_read && (!offset || offset->QuadPart < 0)) > + if (!length) > { > - status = STATUS_INVALID_PARAMETER; > + status = STATUS_SUCCESS; > goto done; I think it would be cleaner to use the same code path as the other types (calling read() first) instead of adding a special case for serial. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Ignore WM_CHILDACTIVATE on disabled windows in DefMDIChildProc.
by Marvin Feb. 24, 2016

Feb. 24, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20854 Your paranoid android. === w1064 (32 bit msg) === msg.c:6356: Test failed: Update region shouldn't be empty msg.c:6590: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6592: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6362: Test failed: Regions are different msg.c:6362: Test failed: Regions are different msg.c:6362: Test failed: Regions are different

1 0

Re: [PATCH v2] winex11.drv: Make the GL context current even if no drawables were given.
by Ken Thomases Feb. 24, 2016

Feb. 24, 2016

On Feb 23, 2016, at 7:46 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > - if (ret) > - { > - NtCurrentTeb()->glContext = ctx; > - ctx->has_been_current = TRUE; > - ctx->hdc = hdc; > - ctx->drawables[0] = gl->drawable; > - ctx->drawables[1] = gl->drawable; > - ctx->refresh_drawables = FALSE; > - goto done; > - } > + if (ret) > + { > + NtCurrentTeb()->glContext = ctx; > + ctx->has_been_current = TRUE; > + ctx->hdc = NULL; > + ctx->drawables[0] = drawable; > + ctx->drawables[1] = drawable; > + ctx->refresh_drawables = FALSE; > + } You lost the assignment of hdc to ctx->hdc. -Ken

1 0

Re: [PATCH] d3d10core/tests: Silence absolute value warnings. (Clang)
by Henri Verbeet Feb. 23, 2016

Feb. 23, 2016

On 19 February 2016 at 23:50, Charles Davis <cdavis5x(a)gmail.com> wrote: > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> > --- For what it's worth, writing something like "Silence ... warnings" in the subject line is a good way to get a patch rejected on principle. However, we do have similar casts in the d3d9 tests because there's actually an issue, albeit a pretty pedantic one. (Unsigned to signed conversion is implementation defined for values that can't be represented with the signed type, but any implementation we care about is going to do the right thing.) I'll also use the occasion to note that I have my reservations about LLVM/Clang as a project.

1 0

Re: [PATCH 4/8] wined3d: Simplify FBO cleanup on resource destruction.
by Henri Verbeet Feb. 23, 2016

Feb. 23, 2016

On 14 February 2016 at 21:33, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > @@ -65,18 +66,21 @@ static void surface_cleanup(struct wined3d_surface *surface) > if (surface->rb_multisample) > { > TRACE("Deleting multisample renderbuffer %u.\n", surface->rb_multisample); > + context_gl_resource_released(device, surface->rb_multisample, TRUE); > gl_info->fbo_ops.glDeleteRenderbuffers(1, &surface->rb_multisample); I'm not sure it would necessarily be much better, but one alternative would be to make the context do the deletion.

2 2

Re: [PATCH 5/5 try2] msvcp120/tests: Run _Unlink tests inside temp directory
by Marvin Feb. 23, 2016

Feb. 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20825 Your paranoid android. === w2008s64 (64 bit msvcp120) === msvcp120.c:1975: Test failed: pad_copy.cnd = FEFEFEFEFEFEFEFE msvcp120.c:1976: Test failed: pad_copy.mtx = FEFEFEFEFEFEFEFE msvcp120.c:1981: Test failed: pad_copy.vtable was set msvcp120.c:1982: Test failed: pad_copy.cnd = FEFEFEFEFEFEFEFE msvcp120.c:1983: Test failed: pad_copy.mtx = FEFEFEFEFEFEFEFE

1 0

Re: [PATCH 4/5 try2] msvcp120: Added _Pad class tests
by Marvin Feb. 23, 2016

Feb. 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20824 Your paranoid android. === w2008s64 (64 bit msvcp120) === msvcp120.c:1968: Test failed: pad_copy.cnd = FEFEFEFEFEFEFEFE msvcp120.c:1969: Test failed: pad_copy.mtx = FEFEFEFEFEFEFEFE msvcp120.c:1974: Test failed: pad_copy.vtable was set msvcp120.c:1975: Test failed: pad_copy.cnd = FEFEFEFEFEFEFEFE msvcp120.c:1976: Test failed: pad_copy.mtx = FEFEFEFEFEFEFEFE

1 0

Re: [PATCH 2/2] winex11.drv: Make the GL context current even if no drawables were given.
by Alexandre Julliard Feb. 23, 2016

Feb. 23, 2016

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -1833,26 +1833,29 @@ static BOOL glxdrv_wglMakeCurrent(HDC hdc, struct wgl_context *ctx) > return TRUE; > } > > - if ((gl = get_gl_drawable( WindowFromDC( hdc ), hdc ))) > + if (!hdc || (gl = get_gl_drawable( WindowFromDC( hdc ), hdc ))) > { > - if (ctx->fmt != gl->format) > + if (gl && ctx->fmt != gl->format) > { > WARN( "mismatched pixel format hdc %p %p ctx %p %p\n", hdc, gl->format, ctx, ctx->fmt ); > SetLastError( ERROR_INVALID_PIXEL_FORMAT ); > goto done; > } > > - TRACE("hdc %p drawable %lx fmt %p ctx %p %s\n", hdc, gl->drawable, gl->format, ctx->ctx, > - debugstr_fbconfig( gl->format->fbconfig )); > + if (gl) > + TRACE("hdc %p drawable %lx fmt %p ctx %p %s\n", hdc, gl->drawable, gl->format, ctx->ctx, > + debugstr_fbconfig( gl->format->fbconfig )); > + else > + TRACE("ctx %p (no drawable)\n", ctx->ctx); > > - ret = pglXMakeCurrent(gdi_display, gl->drawable, ctx->ctx); > + ret = pglXMakeCurrent(gdi_display, gl ? gl->drawable : None, ctx->ctx); > if (ret) > { > NtCurrentTeb()->glContext = ctx; > ctx->has_been_current = TRUE; > ctx->hdc = hdc; > - ctx->drawables[0] = gl->drawable; > - ctx->drawables[1] = gl->drawable; > + ctx->drawables[0] = gl ? gl->drawable : 0; > + ctx->drawables[1] = gl ? gl->drawable : 0; You really want a separate code path instead of adding pointer checks everywhere. -- Alexandre Julliard julliard(a)winehq.org

2 1