March 2016 - Wine-Devel - list.winehq.org

Error handling in RpcBindingVectorFree (dlls/rpcrt4/rpc_binding.c)
by Gerald Pfeifer Nov. 22, 2020

Nov. 22, 2020

Looking at RPC_STATUS WINAPI RpcBindingVectorFree( RPC_BINDING_VECTOR** BindingVector ) { RPC_STATUS status; ULONG c; TRACE("(%p)\n", BindingVector); for (c=0; c<(*BindingVector)->Count; c++) { status = RpcBindingFree(&(*BindingVector)->BindingH[c]); } HeapFree(GetProcessHeap(), 0, *BindingVector); *BindingVector = NULL; return RPC_S_OK; } we currently always ignore the outcome of RpcBindingFree and return RPC_S_OK. However, there is one case where RpcBindingFree returns something different (which is if *Binding is null when RPC_S_INVALID_BINDING is returned). What is the proper way of handling this? Just keeping the code as is and removing the unused status variable? Breaking the loop once RpcBindingFree returns something different from RPC_S_OK? Continuing and returning the first / the last status different from RPC_S_OK? Gerald

1 1

ntoskrnl.exe: unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces
by Qian Hong Sept. 28, 2018

Sept. 28, 2018

Dear all, While test another online bank with wine ActiveX, I got an unimplemented fuction of ntoskrnl: IoGetDeviceInterfaces, I found it listed in http://source.winehq.org/WineAPI/ntoskrnl.html as a stup, so I can't understand this log: wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 0022), starting debugger... Grateful for any explain! env: wine1.3.12 on Ubuntu 10.04 Here are the steps: 1. install an ActiveX from https://e.bank.ecitic.com/perbank5/plugs/CNCBSecPkg_EN.exe $ rm -rf ~/.wine $ winetricks -q mfc42 $ wine CNCBSecPkg_EN.exe fixme:ole:DllRegisterServer stub fixme:win:DisableProcessWindowsGhosting : stub fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:msg:ChangeWindowMessageFilter c057 00000001 fixme:ole:CoCreateInstance no instance created for interface {ea1afb91-9e28-4b86-90e9-9e9f8a5eefaf} of class {56fdf344-fd6d-11d0-958a-006097c9a090}, hres is 0x80004002 fixme:sfc:SfcIsFileProtected ((nil), L"C:\\Program Files\\\4e2d\4fe1\94f6\884c\7f51\94f6\5b89\5168\63a7\4ef6\\unins000.exe") stub fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 -1: stub! fixme:win:WINNLSEnableIME hUnknown1 0x1011a bUnknown2 0: stub! wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces called at address 0x7b839552 (thread 002b), starting debugger... wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting wine: Call from 0x7b839552 to unimplemented function ntoskrnl.exe.IoGetDeviceInterfaces, aborting 2. open the online bank entry with wine builtin IE, then IE will crash: $ wine iexplore https://e.bank.ecitic.com/perbank5/signIn.do Please checkout the full log here: http://pastebin.com/rbAg7gwj Should I file a singel bug in ntoskrnl component , or separate bugs, one for ntoskrnl and one for the IE crashing? Generalliy what component should I switch while file a bug about IE crashing? Many thanks! -- Regards, Qian Hong - Sent from Ubuntu http://www.ubuntu.com/

5 6

ODBC Databases: Jet/Access success
by Barry Bird June 14, 2018

June 14, 2018

Good Afternoon. In section 3.3.6.2 of your User Guide you ask readers to report successes with databases other than MS SQL. Well here's one (I know Access 2000 can work with Wine, but this doesn't require Access): How to set up Wine to enable Windows programs that read and write to Jet (Access) databases using ODBC. I write such programs in C and use the API defined in ODBC API Reference http://msdn.microsoft.com/en-us/library/ms714562%28VS.85%29.aspx They work fine on Windows and only require Mingw to be installed to compile and link them, both for console programs and those using Windows SDK. You then can write interactive programs in C which use a full-featured SQL database which comes bundled with Windows. No need to purchase Access. With the set-up below they will also run on Linux (Kubuntu 9.04) and Wine 1.1.26. You need to update the registry to install the Access drivers. Under Windows, export from the Registry to *.reg files the registry entries - HKLM\Software\ODBC - HKLM\Software\Microsoft\Jet all subsidiary keys and values come with them. You can carefully edit these files to remove drivers and DSNs you don't need. Import these files using the registry editor in wine: wine regedit.exe. You need to bring across from Windows to Windows\System32 under wine: clbcatq.dll comres.dll expsrv.dll msjet40.dll mswstr10.dll msjter40.dll msjint40.dll msjtes40.dll msrd3x40.dll odbc32.dll odbccp32.dll odbcji32.dll odbcjt32.dll odbcad32.exe odbcint.dll odbctrac.dll vbajet32.dll Register this server in wine: wine regsvr32.exe msjtes40.dll No need to install MDAC. To use Windows ODBC drivers, you have to override Wine's odbccp32.dll and odbc32.dll with the native versions because the Wine versions are currently wired directly to Linux's unixodbc. This can be done by setting up the ODBC Data Source Administrator odbcad32.exe using winecfg: - Add the program to the Applications tab - then in the libraries tab, pick from 'New override for library' drop-down odbc32.dll and odbccp32.dll add them and edit them to be Native for Windows. Then if you do wine odbcad32.exe this brings up the ODBC Data Source Administrator window as in the Windows Control Panel If needed, set up (System) DSNs using this program. Bring across the programs and *.mdb database files from Windows. Using winecfg, you need to set up each program you want to run with overrides for odbc32.dll and odbccp32.dll (Applications and Libraries tabs) as above. The programs should then run as they did in Windows but perhaps a bit slower with: wine Odbc-prog.exe This has been tested twice on a clean .wine install. I cannot vouch for support of all API and SQL facilities however. I hope someone finds this useful. Barry Bird

5 4

Re: user32: Avoid -Wmisleading-indentation warnings and fix comments in comments in test_AppendMenu.
by Dmitry Timoshkov Aug. 11, 2016

Aug. 11, 2016

Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > diff --git a/dlls/user32/tests/menu.c b/dlls/user32/tests/menu.c > index 33d8eb8..ea965cd 100644 > --- a/dlls/user32/tests/menu.c > +++ b/dlls/user32/tests/menu.c > @@ -3992,13 +3992,15 @@ static void test_AppendMenu(void) > mii.wID = 206; > ret = InsertMenuItemA(hmenu, 0, TRUE, &mii); > ok(ret, "InsertMenuItem failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 206, MF_SEPARATOR, MFS_GRAYED); > +} > mii.wID = 207; > ret = SetMenuItemInfoA(hmenu, 0, TRUE, &mii); > ok(ret, "SetMenuItemInfo failed\n"); > -if (0) /* FIXME: uncomment once Wine is fixed */ > +if (0) /* FIXME: enable once Wine is fixed */ { > check_menu_items(hmenu, 207, MF_SEPARATOR, MFS_GRAYED); > +} > DestroyMenu(hmenu); > > hbmp = CreateBitmap(1, 1, 1, 1, NULL); Please don't make the code look uglier than it already is. I'd personally argue that checking and forcing indentation rules by a C compiler is pretty disappointing and actually misleading. That warning should be turned off by default IMHO. -- Dmitry.

3 2

WineHQ upgrade breaking dinput8:dinput?
by Francois Gouget Aug. 7, 2016

Aug. 7, 2016

This is a truly weird one. dinput8:dinput start failing on the 17th, the day after WineHQ was upgraded: https://test.winehq.org/data/tests/dinput8:dinput.html What makes this weird is that: * There has been no change to these tests between bd332f53f2d7 and 966a07149a02. In fact the last patch goes back to 2013. So it's not a bad patch. * The failures happen on every 32 bit test environment, from XP to Windows 10, VM or not, TestBot or not. Only 64 bit is spared. * I compiled a dinput8_crosstest.exe binary bd332f53f2d7 which was not failing according to the test.winehq.org results. But all I got is failures: - 887b445bb878, 8th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21611 - bd332f53f2d7, 16th, 0 test.winehq.org failures, 13 here: https://testbot.winehq.org/JobDetails.pl?Key=21610 - 329dfee70c35, 22nd, 13 test.winehq.org failures, 13 here https://testbot.winehq.org/JobDetails.pl?Key=21609 My MinGW compiler is more recent than the one WineHQ was using before the upgrade however. So I think this points to a compiler-related issue. The official WineTest binaries are build on WineHQ so I suspect the MinGW upgrade is somehow responsible for the new failures. However I don't know if the old compiler was masking them, of if the new one is causing them. Any ideas? For reference: * Debian Testing (my environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 5.3.1 20160205 * Debian 7 (close to former WineHQ environment): $ i686-w64-mingw32-gcc --version i686-w64-mingw32-gcc (GCC) 4.9.1 -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

5 15

WineConf 2016
by Michael Stefaniuc June 19, 2016

June 19, 2016

Hello guys, it's that time of the year again where we start thinking about the next WineConf. Last year would already have been the turn for North America so the next WineConf will happen definitely there. Jeremy White / CodeWeavers, as always, was very generous and offered to host it in Minneapolis (or was it St. Paul? ;). But if you're in US / Canada and really hoped to host the next WineConf now is your time to speak up! The Twin Cities are beautiful at -30 C but we wouldn't mind seeing other places too. bye michael

4 4

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

Re: [PATCH 5/5] wined3d: Alpha test emulation for core profile contexts.
by Henri Verbeet April 6, 2016

April 6, 2016

On 31 March 2016 at 19:51, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + shader_addline(buffer, "if (alpha_test)\n"); > + if (alpha_func != WINED3D_CMP_NEVER) > + shader_addline(buffer, " if (!(%s[0].a %s alpha_ref))\n", > + get_fragment_output(gl_info), comparison_operator[alpha_func - WINED3D_CMP_NEVER]); > + shader_addline(buffer, " discard;\n"); Is there really an advantage to having the "alpha_test" uniform instead of just mapping disabled alpha test to WINED3D_CMP_ALWAYS? > @@ -973,6 +981,7 @@ struct ps_compile_args { > WORD texcoords_initialized; /* MAX_TEXTURES, 8 */ > BOOL pointsprite; > BOOL flatshading; > + enum wined3d_cmp_func alpha_func; > }; > > enum fog_src_type { > @@ -2022,6 +2031,7 @@ struct ffp_frag_settings > unsigned char pointsprite : 1; > unsigned char flatshading : 1; > unsigned char padding : 5; > + enum wined3d_cmp_func alpha_func; "alpha_func" only needs 4 bits (3 if you just mask the 4th bit), so would still fit in the padding. That applies somewhat to struct ps_compile_args as well, although we may care less there.

2 3

Re: ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. (try 2)
by Sebastian Lackner April 1, 2016

April 1, 2016

On 29.03.2016 22:13, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39734 > > This patch should avoid crash in acedrv11.sys. > IoAllocateIrp is called with a stack_size of -128. > Therefore ExAllocatePool gets a negative size value. > > Tested against Windows XP. > (See the test based on wine-staging "driver testing framework" attached to the bug.) > ( https://newtestbot.winehq.org/JobDetails.pl?Key=21722 testrun by Sebastian Lackner.) > > Try 1: https://www.winehq.org/pipermail/wine-patches/2016-March/148587.html > Review 1: https://www.winehq.org/pipermail/wine-devel/2016-March/112476.html > > Changes since try 1: > - Fix usage of wrong variable. > - Use a better name for variable. > - Simplify if statement. > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Thanks for the updated version. Could you maybe also add a couple of additional tests with charge_quota = TRUE? Since you are changing both versions, I'm fearing a bit that your changes could break other situations. If there are no unexpected test failures it looks good to me.

2 1

Re: [v8 1/6] d3dx9: Implement preshader parsing.
by Matteo Bruni March 31, 2016

March 31, 2016

2016-03-29 17:22 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > +enum pres_reg_tables > +{ > + PRES_REGTAB_IMMED, /* immediate double constants from CLIT */ I don't quite recall, I might be contradicting my own earlier comments here but at this point this comment doesn't seem to add much. General (and late) note, we usually tend to be more verbose with variable or type names and avoid too cryptic abbreviations. I don't think it's worth changing everything now though. > +struct d3dx_preshader > +{ > + struct d3dx_regstore regs; > + > + unsigned int ins_count; > + struct d3dx_pres_ins *ins; > + > + struct d3dx_const_tab inputs; > +}; > + > + > +struct d3dx_param_eval That double empty line seems unnecessary. > -HRESULT d3dx_create_param_eval(struct d3dx9_base_effect *base_effect, void *byte_code, unsigned int byte_code_size, > +enum pres_ops > +{ > + PRESHADER_OP_NOP, > + PRESHADER_OP_MOV, > + PRESHADER_OP_MAX_ENUM > +}; Maybe rename _MAX_ENUM to _UNKNOWN? At least for this patch series you don't really need that enum value though (see below). > +static HRESULT regstore_alloc_table(struct d3dx_regstore *rs, unsigned int table) > +{ > + unsigned int size; > + > + size = rs->table_sizes[table] * table_info[table].reg_component_count * table_info[table].component_size; > + if (size) > + { > + rs->tables[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); > + rs->table_value_set[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + sizeof(*rs->table_value_set[table]) * > + ((rs->table_sizes[table] + PRES_BITMASK_BLOCK_SIZE - 1) / PRES_BITMASK_BLOCK_SIZE)); Indentation. > +static void regstore_set_values(struct d3dx_regstore *rs, unsigned int table, void *data, > + unsigned int start_offset, unsigned int count) > +{ > + unsigned int block_idx, start, end, start_block, end_block; > + > + if (!count) > + return; > + > + memcpy((BYTE *)rs->tables[table] + start_offset * table_info[table].component_size, > + data, count * table_info[table].component_size); Indentation. > + for (i = 0; i < PRESHADER_OP_MAX_ENUM; ++i) > + if (ins_code == pres_op_info[i].opcode) > + break; > + if (i == PRESHADER_OP_MAX_ENUM) > + { > + FIXME("Unknown opcode %#x, raw %#x.\n", ins_code, ins_raw); > + return NULL; > + } I'd use ARRAY_SIZE(pres_op_info) instead of PRESHADER_OP_MAX_ENUM. > + cdesc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*cdesc) * desc.Constants); > + inputs_param = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*inputs_param) * desc.Constants); AFAICS neither really needs HEAP_ZERO_MEMORY. You should also check those allocations and bail out if either one fails. > +static void update_table_sizes_consts(unsigned int *table_sizes, struct d3dx_const_tab *ctab) > +{ > + unsigned int i, table, max_register; > + > + for (i = 0; i < ctab->input_count; ++i) > + { > + max_register = ctab->inputs[i].RegisterIndex + ctab->inputs[i].RegisterCount; > + table = ctab->regset2table[ctab->inputs[i].RegisterSet]; > + if (table < PRES_REGTAB_COUNT) > + table_sizes[table] = max(table_sizes[table], max_register); > + } > +} > + > +static void update_table_size(unsigned int *table_sizes, unsigned int table, unsigned int offset) > +{ > + table_sizes[table] = max(table_sizes[table], get_reg_offset(table, offset) + 1); > +} Why not use it also in update_table_sizes_consts()? The "table < PRES_REGTAB_COUNT" check should then go into the update_table_size() helper. > + if (const_count > UINT_MAX / sizeof(double)) > + { > + WARN("Invalid immediate constants count %u.\n", const_count); > + return NULL; > + } > + if (p - ptr + const_count * (sizeof(double) / sizeof(unsigned int)) >= count) > + { > + WARN("Byte code buffer ends unexpectedly.\n"); > + return NULL; > + } The first check seems unnecessary, if the idea was to avoid integer overflows in the second check you can rewrite that one instead (e.g. by dividing by sizeof(unsigned int) both sides of the inequality). That second check can probably be improved by verifying that the constants fit into the CLIT comment instead (see below). BTW, the function return type is HRESULT, those returns generate warnings for me. > + pres->ins = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*pres->ins) * pres->ins_count); You should probably check this allocation too. > + for (i = 0; i < pres->ins_count; ++i) > + { > + unsigned int *ptr_next; > + > + ptr_next = parse_pres_ins(p, count, &pres->ins[i]); > + if (!ptr_next) > + return D3DXERR_INVALIDDATA; > + count -= ptr_next - p; > + p = ptr_next; > + } > + > + if (!count) > + { > + WARN("Byte code buffer ends unexpectedly.\n"); > + return D3DXERR_INVALIDDATA; > + } These kinds of size checks probably work but they are somewhat hard to follow. You could instead check the size of each comment section (making sure that it doesn't overflow the whole bytecode buffer) and then check that you don't go outside of each comment while parsing it. find_bytecode_comment() could do the first check before returning and, for example, also return the comment size so that the caller can use it to validate the relevant accesses. Hopefully what I mean is clear enough, otherwise as usual feel free to ask. > +err_out: > + FIXME("Error creating parameter evaluator.\n"); > + d3dx_free_param_eval(peval); > *peval_out = NULL; > - return E_NOTIMPL; > + return; > +} That return is now unnecessary.

1 0

Re: [PATCH 2/2] d3dx10: Add D3DX10UnsetAllDeviceObjects stub
by Matteo Bruni March 31, 2016

March 31, 2016

2016-03-29 9:07 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Reference: https://bugs.winehq.org/show_bug.cgi?id=27035 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Applying: d3dx10: Add D3DX10UnsetAllDeviceObjects stub .git/rebase-apply/patch:35: new blank line at EOF. + .git/rebase-apply/patch:52: new blank line at EOF. + warning: 2 lines add whitespace errors. Looks okay otherwise.

1 0

Re: [PATCH v2 1/5] ddraw/tests: Add a test for color varyings clamping.
by Marvin March 31, 2016

March 31, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21816 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

wine-1.8.2-rc1 Available
by Michael Stefaniuc March 31, 2016

March 31, 2016

Hello guys, sorry for the delay in preparing the next Stable release. Too much stuff going on and I couldn't focus on Wine. I have pushed today an informal wine-1.8.2-rc1 to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ 1.8.2-rc1 is fairly complete(*) from my point of view. The plan is to give the interested developers about a week time to look at the proposed 1.8.2. On Wednesday next week I plan to hand over the "final" to Alexandre, with a probable release on Friday next week. Depending on the feedback / outcry I might do another release candidate before Wednesday. (*) I wanted to include: Bug 39092 - Regression introduced with xaudio2_8 too. It is a beast to cherry-pick due to the dependencies and dependencies of dependencies... 1.8.2-rc1 is already big enough: - I have included this time interesting commits I have found interesting, mostly based on the additional information in the patch submission. - 32 bugs fixed (of which 6 are regressions). - 86 patches (of which 7 are tests only). - With test file changes filtered out: 95 files changed, 1873 insertions(+), 770 deletions(-) - The biggest "offender" for those changes is Bug 25086 - Multiple games and applications need kernel32.GetLogicalProcessorInformationEx implementation - I have attached the filtered diffstat While I have added a (lightweight) tag to it, I didn't bother with the rest of the release stuff. I have included that info in this email though. ---------------------------------------------------------------- Bugs fixed in 1.8.2-rc1 (total 32) [12652] Tom Clancy's Rainbow Six: Vegas 2 fails to launch (number of quality levels for D3DMULTISAMPLE_NONMASKABLE multiple-sample type must not exceed 8) [13683] Ultima IX: Mouse pointer missing when reading books, under inventory [14617] Multiple Visual Basic 5/6 applications using ActiveX components depend on Standard OLE Types Typelib which is missing from 'olepro32.dll' [15473] Adobe After Effects 4 crashes on startup [25086] Multiple games and applications need kernel32.GetLogicalProcessorInformationEx implementation (CPU-Z 1.72, Splinter Cell: Blacklist, Adobe CC 2015, Kontakt 5) [30687] Powerpoint 2003/2007: embedded video play/pause on click no longer works [32827] Legrand XlPro 3 (MFC app) crashes on startup (failure to load registry-free COM servers via app hook, 'OleCreate' must ignore HRESULT of 'IOleObject::GetMiscStatus') [33787] IE8 crashes on new tab [33988] Star Wars: The Force Unleashed II - Crashes with a page fault [34174] MinGW installer 0.5-beta-20120426-1 fails to process log files (sharing violation on temp file used for piped output) [34318] Multiple games and applications need ntdll.dll.EtwRegisterTraceGuidsW (Process Hacker 2.x, Far Cry 4) [35187] Jade Empire Special Edition configuration tool always resetting video settings [36013] bleem! 1.4 (PlayStation emulator) fails on startup, complaining with 'Not enough memory to load program!' [37115] Calling ReadFile from WINBASEAPI (WinBase.h) with zero read length causes hang [37288] Not implemented feature System.Drawing.Pen.ResetTransform() [37536] Native MSVCP120.dll override requires implementation of msvcr120.dll._W_Gettnames (Desura client) [37556] CompareStringW should abort on the first nonmatching character to avoid invalid memory access. [38314] Mouse Wheel doesn't work for Jagged Alliance 2 version 1.13 (it uses MOUSEHOOKSTRUCTEX) [39591] Crimzon Clover: Page fault on launch [39838] Wreckfest Server: Crashes at startup, unimplemented function KERNEL32.dll.GetConsoleScreenBufferInfoEx & SetConsoleScreenBufferInfoEx [39866] XIIZeal (steam) immediately exits on start [39875] Starcraft can't see Direct Cable Connection games hosted on another computer [39878] Diablo II does not start on 64bit system with more than 2GB VRAM cards [39908] SuperTux 0.3.5a crashes on startup, needs msvcr120.dll.strtof [40021] IDEA v1.7 fails to start [40053] Romance of the Three Kingdoms 13 (三國志13) fails to start [40083] Heroes of the Storm Freezes/Crashes after its recent updates [40129] MSI Reading and Writing Behaves differently than Windows [40147] Assertion 'm->state == STATE_PASSIVE' failed at pulse/mainloop.c:827 on starting Skype 7.18.0.112 [40201] EccoPro only works on Wine 1.6.2 [40204] Steam client fails to start with UmePlus font installed, when running in dwrite mode [40222] IMalloc(Spy)::Free nullptr ---------------------------------------------------------------- Changes since 1.8.1: Alex Henrie (1): ntdll: Finish serial reads of size 0 immediately. Alexandre Julliard (3): make_unicode: Fix typo in Indic syllable table generation. server: Implement serial port read interval timeouts. advapi32: Fix null termination in RegQueryInfoKeyA. Alistair Leslie-Hughes (7): user32: Don't crash in DrawTextEx when tab length is zero. olepro32: Add typelib resource. include: Add GdipGetPenTransform, GdipSetPenTransform declarations. gdiplus/tests: Add Pen Transform tests. gdiplus: Implement GdipGetPenTransform. gdiplus: Implement GdipSetPenTransform. gdiplus: Implement GdipResetPenTransform. Andrew Eikum (5): oleaut32: Don't clear BSTR size. mciqtz: Implement MCI_RESUME. xaudio2: Handle openal source allocation failure. winepulse.drv: Check that the server connection actually succeeded. ntdll: Implement SystemLogicalProcessorInformationEx. André Hentschel (2): winemaker: Markup fixes in German translation. ntdll: Set TPIDRURW also on ARMv8-A. Anton Baskanov (1): quartz: Set the result to 1.0 in FilterGraph::GetRate. Aric Stewart (1): winejoystick.drv: Initialize unhandled dwPOV to JOY_POVCENTERED. Austin English (1): kernel32: Add GetConsoleScreenBufferInfoEx/SetConsoleScreenBufferInfoEx stubs. Bernhard Übelacker (2): include: Implement todo_wine_if for usage in wine tests. msvcr120: Implement strtof and _strtof_l. Charles Davis (3): winex11.drv: Actually query the swap method attribute. dwrite: Fix typos, and fix definition of Mac LangCodes for Welsh and up. configure: Check for __builtin_ms_va_list on all x86_64 platforms. Christopher Thielen (1): user32: A window may be notified with WM_CAPTURECHANGED about itself if SetCapture() is called twice. Dmitry Timoshkov (1): kernel32: CompareStringW should abort on the first nonmatching character to avoid an invalid memory access. Frédéric Delanoy (1): winemaker: Markup fixes in French translation. Hans Leidekker (2): msiexec: Fix manpage markup for repair and logging modifiers. msi: Fix the CHAR column type. Henri Verbeet (1): ntdll: Add special handling for int $0x2d exceptions. Hugh McMaster (1): reg: Remove stub output from the 'add' and 'delete' functions. Huw D. M. Davies (1): ole32: The type of the size of IMalloc'ed blocks is SIZE_T. Jacek Caban (4): ntdll: Pass SYNCHRONIZE flag in NtOpenFile and NtCreateFile calls. ntdll: Don't call NtOpenKeyEx directly from NtOpenKey. kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping. ntdll: Moved RegisterTraceGuids[AW] implementation to ntdll. Jens Reyer (2): loader: Fix macro-not-defined error from man. winemaker: Fix macro-not-defined errors from man. Józef Kucia (3): wined3d: Validate render state in wined3d_device_set_render_state(). wined3d: Limit amount of video memory for older Windows versions. wined3d: Allow to query if surface format supports gamma correction. Kira Backes (1): user32: Add MOUSEHOOKSTRUCTEX for mouse wheel support. Marcus Meissner (1): manpages: Markup fixes. Matteo Bruni (2): wined3d: Limit the number of WINED3D_MULTISAMPLE_NON_MASKABLE quality levels reported. wined3d: Add WINED3DFMT_FLAG_RENDERTARGET to WINED3DFMT_B5G5R5X1_UNORM. Michael Müller (6): msvideo.dll16: Translate 16 bit address in lparam for MCIWNDM_SETTIMEFORMATA message. include: Add definitions for Win8 pseudo handles. server: Add support for Win8 pseudo handles. advapi32/tests: Add tests for Win8 pseudo handles. kernel32: Allow to pass NULL as old protection in VirtualProtect for Win9x compatibility. user32: Preserve beginning of extra data for MDI windows. Miklós Máté (2): winex11: Add 1280x960 resolution. wined3d: Warn only once about unsupported wrap state. Nikolay Sivov (12): ole2disp: Implement SafeArrayGetDim(). ole2disp: Implement SafeArrayGetElemsize(). ole2disp: Implement SafeArrayLock()/SafeArrayUnlock(). ole2disp: Implement SafeArrayAccessData()/SafeArrayUnaccessData(). include: Fix IsBad* prototypes. ctl3d32: Claim success in Ctl3dRegister(). ole32: Ignore GetMiscStatus() returned value in OleCreate(). dwrite: Handle font data initialization failure when building collections. ntdll/tests: Some tests for NtQuerySystemInformationEx(). ntdll: Add NtQuerySystemInformationEx() stub. kernel32: Forward GetLogicalProcessorInformationEx() to ntdll. ole32: Don't call spy on IMalloc::Free(NULL). Paul Gofman (1): d3dx9: Fix D3DXIntersectTri function. Piotr Caban (5): msxml3: Update xmlNode reference count when nodes are merged in node_insert_before. msxml3: Store information about ignorrable whitespace nodes in xmlNode._private variable. msxml3: Reimplement node_get_text helper so it uses information about ignorred white space nodes. msxml3: Add support for CDATA nodes in node_get_text. msvcr110: Add _W_Gettnames implementation. Sebastian Lackner (13): vcomp/tests: Reenable architecture dependent tests. vcomp: Implement 64-bit atomic instructions. ntdll: Implement RtlInterlockedPushListSListEx and fix calling convention of RtlInterlockedPushListSList. kernel32/tests: Clean up interlocked SList tests. kernel32: Forward InterlockedPushListSList[Ex] to ntdll. cmd: Fix sharing permissions of piped output files. vmm.vxd: Fix protection flags passed to VirtualAlloc. ntdll: Mimic Windows behaviour when calling debug service. ntdll: Implement handling of int $0x2d for x86_64. ntdll/tests: Add more tests for calling int $0x2d on x86 and x86_64. ntdll/tests: Add additional tests for instruction pointer in debug service tests. ntdll/tests: Add separate tests for exception handling of int $0x3. ntdll: Fix up instruction pointer in context for EXCEPTION_BREAKPOINT on x86_64. bye michael

1 0

Re: [PATCH 1/2] d3dx10: Add D3D10CreateEffectPoolFromMemory stub
by Józef Kucia March 31, 2016

March 31, 2016

On Tue, Mar 29, 2016 at 9:07 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > dlls/d3d10/d3d10.spec | 2 +- > dlls/d3d10/d3d10_main.c | 9 +++++++++ > dlls/d3d10_1/d3d10_1.spec | 2 +- > include/d3d10effect.h | 2 ++ The subject prefix should be "d3d10:". > +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags, > + ID3D10Device *device, ID3D10EffectPool **effectpool) > +{ Please use "effect_pool" instead of "effectpool", mainly for consistency (snake_case). > + FIXME("data %p, data_size %lu, fx_flags %#x, device %p, effectpool %p.\n", > + data, data_size, fx_flags, device, effectpool); The FIXME() message should end with "stub!" or "stub.". > + return E_NOTIMPL; > +} > + I think you can remove this additional empty line. > diff --git a/include/d3d10effect.h b/include/d3d10effect.h > index 1494894..5dafdae 100644 > --- a/include/d3d10effect.h > +++ b/include/d3d10effect.h > @@ -832,6 +832,8 @@ HRESULT WINAPI D3D10CompileEffectFromMemory(void *data, SIZE_T data_size, const > ID3D10Blob **effect, ID3D10Blob **errors); > HRESULT WINAPI D3D10CreateEffectFromMemory(void *data, SIZE_T data_size, UINT flags, > ID3D10Device *device, ID3D10EffectPool *effect_pool, ID3D10Effect **effect); > +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags, > + ID3D10Device *device, ID3D10EffectPool **effectpool); It should be "effect_pool" instead of "effectpool".

1 0

Re: [PATCH (try2)] setupapi: Fix spec entries for handle parameters
by Sebastian Lackner March 31, 2016

March 31, 2016

On 30.03.2016 17:00, Andrew Eikum wrote: > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > > try2: Turns out there's a whole bunch more of these. I think I got > most/all of them. > > dlls/setupapi/setupapi.spec | 118 ++++++++++++++++++++++---------------------- > 1 file changed, 59 insertions(+), 59 deletions(-) Is there any specific reason why you want to change that? Using "long" for handles is usually perfectly fine and it depends on the exact implementation details if its a pointer or just an index into a handle table.

3 2

Re: [PATCH] msvcr120: Add scalbn
by Piotr Caban March 31, 2016

March 31, 2016

On 03/31/16 08:45, Daniel Lehman wrote: @ cdecl scalbn(double long) MSVCRT__scalb It will not compile in case of i386 wine. MSVCRT__scalb is defined inside ifdef. Thanks, Piotr

1 0

Need some advice on shell32
by Mathy Vanvoorden March 31, 2016

March 31, 2016

Hello, In an effort to get myself acquainted with the code I searched for some bugs I might be able to solve in Bugzilla. I found this one: https://bugs.winehq.org/show_bug.cgi?id=32079 Basically it says that an open file dialog in for example notepad or notepad++ doesn't show hidden files when the "Show hidden files" option is set in winecfg. I have traced this back to the fact that the ShowDotFiles option is only checked in the NT functions in ntdll, but notepad (and notepad++) use the comdlg32 open dialog which does not use those NT functions but the shell32 ones. It seems to me that the comdlg32 open dialog should check if ShowDotFiles is active and if so, to pass the SHCONTF_INCLUDEHIDDEN flag to the shell32 objects. But I might (probably?) be wrong. Can someone verify that this is the way to go before I start writing a patch? -- Met vriendelijke groeten, Best regards, Mathy Vanvoorden

3 7

Re: [PATCH 4/4] mshtml: Added IHTMLElement::outerText tests.
by Marvin March 30, 2016

March 30, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21790 Your paranoid android. === wxppro (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === wvistau64 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7u (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7pro64 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w8 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w864 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w1064 (32 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === wvistau64 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w7pro64 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w864 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1 === w1064 (64 bit dom) === dom.c:6968: Test failed: put_outerText failed: 00000000 dom.c:6971: Test failed: expected len = 2, got 1

2 1

Re: [PATCH] t2embed: Implement TTGetEmbeddingType()
by Marvin March 30, 2016

March 30, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21774 Your paranoid android. === build (build) === Make failed

2 1

Re: ntoskrnl.exe: Make IoAllocateIrp not crash on negative values.
by Sebastian Lackner March 29, 2016

March 29, 2016

On 27.03.2016 20:27, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39734 > > Changes should avoid crash in acedrv11.sys. > IoAllocateIrp is called with a stack_size of -128. > > Tested against Windows XP. > (See the test based on wine-staging "driver testing framework".) For reference, here a testbot run which confirms that the change is correct (for XP/2003): https://newtestbot.winehq.org/JobDetails.pl?Key=21722 > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/ntoskrnl.exe/ntoskrnl.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c > index 36488a7..f2ccc61 100644 > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -592,15 +592,20 @@ PIRP WINAPI IoAllocateIrp( CCHAR stack_size, BOOLEAN charge_quota ) > { > SIZE_T size; > PIRP irp; > + CCHAR _stack_size = stack_size; > > TRACE( "%d, %d\n", stack_size, charge_quota ); > > - size = sizeof(IRP) + stack_size * sizeof(IO_STACK_LOCATION); > + if (_stack_size <= 0 || (_stack_size > 1 && stack_size < 8)) > + _stack_size = 8; I would suggest to use a different variable, its very easy to mix up "stack_size" and "_stack_size". You even mixed it up yourself in the if() condition above. ;) If you want, you can also simplify the condition to (stack_size < 8 && stack_size != 1). > + > + size = sizeof(IRP) + _stack_size * sizeof(IO_STACK_LOCATION); > irp = ExAllocatePool( NonPagedPool, size ); > if (irp == NULL) > return NULL; > IoInitializeIrp( irp, size, stack_size ); > - irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > + if (stack_size >= 1 && stack_size <= 8) > + irp->AllocationFlags = IRP_ALLOCATED_FIXED_SIZE; > if (charge_quota) > irp->AllocationFlags |= IRP_LOOKASIDE_ALLOCATION; > return irp; >

2 1

Re: [PATCH] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v3).
by Henri Verbeet March 29, 2016

March 29, 2016

On 28 March 2016 at 20:02, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > v3: Add bitmap verification, use InitFromFile and other minor improvements. > Implementing InitFromFile() should be a separate patch from implementing LoadTexture(). > if (FAILED(hr = d3drm_texture_create(&object))) > return hr; > > + if (FAILED(hr = IDirect3DRMTexture_InitFromFile(&object->IDirect3DRMTexture_iface, filename))) > + { > + d3drm_texture_destroy(object); > + return hr; > + } > + > + object->d3drm = iface; > + IDirect3DRM_AddRef(iface); It would be good to back this up with tests. It would seem more natural to pass the IDirect3DRM interface to d3drm_texture_create(). If that's how it's supposed to work, you can make that change in a separate patch. > @@ -39,6 +40,9 @@ struct d3drm_texture > IDirect3DRMTexture IDirect3DRMTexture_iface; > IDirect3DRMTexture2 IDirect3DRMTexture2_iface; > IDirect3DRMTexture3 IDirect3DRMTexture3_iface; > + IDirect3DRM *d3drm; > + D3DRMIMAGE *image; > + BOOL internal_image_created; You don't really need internal_image_created, you can probably just add a destroy callback. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, > + BOOL load_upside_down) DECLSPEC_HIDDEN; > + > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) DECLSPEC_HIDDEN; These are internal helper functions now. > @@ -4109,36 +4111,94 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "Test %u: expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", i, ref1, ref2); > + > + hr = IDirect3DRMTexture_InitFromFile(texture1, filename); > + ok(hr == D3DRMERR_BADOBJECT, "Test %u: Expected hr == D3DRMERR_BADOBJECT, got %#x.\n", i, hr); > + /* It's odd, but InitFromFile seems to AddRef IDirect3DRM even if it fails. */ So a test for the refcounts would be appropriate here. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ This is an internal helper function now and should be static. You never use "d3drm". > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors; > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; There's not reason to use signed types for any of these. > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + if (bpl * h > UINT_MAX) > + { > + return NULL; > + } This doesn't work. If "bpl * h" would be larger than UINT_MAX it would overflow before the comparison. In fact, strictly speaking things become implementation defined above INT_MAX already, since you're using signed types for "bpl" and "h". What you'd typically do is something like "if (h > UINT_MAX / bpl)". Note that the calculation of "bpl" itself can overflow as well. So you'd need something like "if (align(w, 4) > UINT_MAX / (bpp / 8))" there as well. > + if (!(colors = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*colors)))) > + { > + WARN("Not enough memory to allocate palette, returning NULL.\n"); > + return NULL; > + } > + > + > + if (!(image = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)))) > + { > + WARN("Not enough memory to allocate image struct, returning NULL.\n"); > + return NULL; > + } You probably don't need HEAP_ZERO_MEMORY for either of these. You certainly don't for "colors", and you should probably just initialise the few fields in "image" that you don't already. You also leak "colors" if the allocation for "image" fails. The indentation for the WARN is wrong. > + if (!(image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, bpl * h))) > + { > + WARN("Not enough memory to allocate image buffer, returning NULL.\n"); > + return NULL; > + } You don't need HEAP_ZERO_MEMORY here if you're going to memset() it again below. You leak "colors" and "image" on failure. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); I think 0xff is clearer than 255. The "sizeof(unsigned char)" doesn't add much. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, num_colors * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Like above, you use HEAP_ZERO_MEMORY here, but immediately memcpy() over it. You leak on error. > + if (!(image->palette = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 256 * sizeof(*image->palette)))) > + { > + WARN("Not enough memory to allocate image palette, returning NULL.\n"); > + return NULL; > + } Leak on error. > static HRESULT WINAPI d3drm_texture1_InitFromFile(IDirect3DRMTexture *iface, const char *filename) > { > - FIXME("iface %p, filename %s stub!\n", iface, debugstr_a(filename)); > + struct d3drm_texture *object = impl_from_IDirect3DRMTexture(iface); I'd suggest "texture" instead of "object". > + if (object->d3drm) > + { > + /* InitFromFile seems to AddRef IDirect3DRM even if it fails. */ > + IDirect3DRM_AddRef(object->d3drm); > + } This is very suspicious, since you always assign "object->d3drm" after calling InitFromFile(). It's not backed up by tests either.

2 4

Re: [v7 2/7] d3dx9: Implement preshader parsing.
by Matteo Bruni March 29, 2016

March 29, 2016

2016-03-28 9:20 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > Changes > - Changed opcode function to take double arguments and return double Good catch. > +static struct op_info pres_op_info[] = > +{ > + {0x000, "nop", 0, 0, NULL }, /* PRESHADER_OP_NOP */ > + {0x100, "mov", 1, 0, pres_mov}, /* PRESHADER_OP_MOV */ > +}; I think this can be const. > +struct d3dx_pres_ins > +{ > + enum pres_ops op; > + /* first input argument is scalar, > + scalar component is propagated */ > + BOOL scalar_op; > + unsigned int component_count; > + struct d3dx_pres_operand inputs[3]; The maximum number of input operands could use a #define. Not a huge deal though. > +static void regstore_free_tables(struct d3dx_regstore *rs) > +{ > + unsigned int i; > + > + for (i = PRES_REGTAB_FIRST; i <= PRES_REGTAB_LAST; ++i) > + { > + if (rs->tables[i]) > + HeapFree(GetProcessHeap(), 0, rs->tables[i]); > + if (rs->table_value_set[i]) > + HeapFree(GetProcessHeap(), 0, rs->table_value_set[i]); > + } > +} You don't need to check for non-NULL, HeapFree() handles NULL arguments just fine. > +static unsigned int *find_bytecode_comment(unsigned int *ptr, unsigned int fourcc) > +{ > + while ((*ptr & 0xffff) == 0xfffe) > + { > + if (*(ptr + 1) == fourcc) > + return ptr + 2; > + ptr += 1 + (*ptr >> 16); > + } > + return NULL; > +} This is probably paranoid but in theory a broken or malicious effect could send you rummaging outside of the bytecode buffer so all the offsets should be checked. I don't think it's critical in practice i.e. I'll probably sleep just fine if you decide to ignore this issue... > +static unsigned int *parse_pres_arg(unsigned int *ptr, struct d3dx_pres_operand *opr) > +{ > + static const enum pres_reg_tables reg_table[8] = > + { > + PRES_REGTAB_COUNT, PRES_REGTAB_IMMED, PRES_REGTAB_CONST, PRES_REGTAB_COUNT, > + PRES_REGTAB_OCONST, PRES_REGTAB_OBCONST, PRES_REGTAB_OICONST, PRES_REGTAB_REG Matter of taste, so feel free to ignore this, but PRES_REGTAB_REG sounds a bit vague to me. I'd go with something like PRES_REGTAB_TEMP. > + if (input_count != pres_op_info[i].input_count) > + { > + FIXME("Actual input args %u, expected %u, instruction %s.\n", input_count, > + pres_op_info[i].input_count, pres_op_info[i].mnem); > + return NULL; > + } > + for (i = 0; i < input_count; ++i) > + { > + ptr = parse_pres_arg(ptr, &ins->inputs[i]); > + if (!ptr) > + return NULL; > + } Another pretty paranoid potential check, here you could verify that input_count is < ARRAY_SIZE(ins->inputs). Of course that could only fail if we encounter some instruction with more than 3 components AND we update pres_op_info BUT we forget to update struct d3dx_pres_ins, but I don't think it would hurt to be safe... > + for (i = 0; i < pres->ins_count; ++i) > + { > + unsigned int table; > + > + for (j = 0; j < pres_op_info[pres->ins[i].op].input_count; ++j) > + { > + table = pres->ins[i].inputs[j].table; > + max_offset = get_reg_offset(table, pres->ins[i].inputs[j].offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + table = pres->ins[i].output.table; > + max_offset = get_reg_offset(table, pres->ins[i].output.offset + pres->ins[i].component_count - 1); > + pres->regs.table_sizes[table] = max(pres->regs.table_sizes[table], max_offset + 1); > + } > + update_table_sizes_consts(pres->regs.table_sizes, &pres->inputs); It probably makes sense to add a small update_table_size() helper (or similar), the "same" 3 lines are repeated in the loop for the input operands, for the output operand and in update_table_sizes_consts(). > + for (i = PRES_REGTAB_IMMED + 1; i <= PRES_REGTAB_LAST; ++i) It depends on what is coming up next but maybe it would make sense to add an enum for "PRES_REGTAB_IMMED + 1" (incidentally, PRES_REGTAB_FIRST is never used in this patch series). > + { > + TRACE("table_sizes[%u] %u.\n", i, peval->pres.regs.table_sizes[i]); That trace looks a bit like a debugging leftover. > + if (FAILED(regstore_alloc_table(&peval->pres.regs, i))) > + { > + hr = E_OUTOFMEMORY; > + goto err_out; > + } > + } > + > + if (TRACE_ON(d3dx)) > + dump_bytecode(byte_code, byte_code_size); > + > + *peval_out = peval; > + TRACE("retval %u, *peval_out %p.\n", D3D_OK, *peval_out); Same with this. This one in particular doesn't seem worth keeping. > + return D3D_OK; > + > +err_out: > + FIXME("Error creating parameter evaluator.\n"); > + d3dx_free_param_eval(peval); > *peval_out = NULL; > - return E_NOTIMPL; > + TRACE("retval %u, *peval_out %p.\n", hr, *peval_out); > + return hr; > +} You could print the HRESULT in the FIXME (e.g. FIXME("Error creating parameter evaluator, returning %#x.\n", hr)). Tracing the value of *peval_out doesn't seem particularly worthwhile. > +static void d3dx_free_const_tab(struct d3dx_const_tab *ctab) > +{ > + if (ctab->inputs) > + HeapFree(GetProcessHeap(), 0, ctab->inputs); > + if (ctab->inputs_param) > + HeapFree(GetProcessHeap(), 0, ctab->inputs_param); > + if (ctab->ctab) > + ID3DXConstantTable_Release(ctab->ctab); > +} > + > +static void d3dx_free_preshader(struct d3dx_preshader *pres) > +{ > + if (pres->ins) > + HeapFree(GetProcessHeap(), 0, pres->ins); > + > + regstore_free_tables(&pres->regs); > + d3dx_free_const_tab(&pres->inputs); > } You can drop all those ifs (I think there are a few more of them in the middle of the patch I haven't specifically mentioned).

2 5

Re: [v2 PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet March 29, 2016

March 29, 2016

On 29 March 2016 at 01:21, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + static D2D1_PIXEL_FORMAT invalid_formats[] = > + { > + { DXGI_FORMAT_UNKNOWN, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + { DXGI_FORMAT_B8G8R8A8_UNORM, D2D1_ALPHA_MODE_UNKNOWN }, > + { DXGI_FORMAT_R8G8B8A8_UNORM, D2D1_ALPHA_MODE_PREMULTIPLIED }, > + }; I should have noticed before, but this should be const.

2 1

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Henri Verbeet March 29, 2016

March 29, 2016

On 28 March 2016 at 23:03, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + hr = IDirect3DDevice7_GetDirect3D(device, &d3d); > + ok(SUCCEEDED(hr), "Failed to get d3d interface, hr %#x.\n", hr); I suppose this is borrowed from test_shademode() where it's used to create the vertex buffers, but you're not using "d3d" anywhere here.

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.
by Piotr Caban March 28, 2016

March 28, 2016

Hi YongHao, On 03/18/16 17:24, YongHao Hu wrote: > dlls/msvcr120/tests/msvcr120.c | 300 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 300 insertions(+) I don't think this is a good approach for adding tests of critical_section class. Executing tons of enter/leave calls is not really testing much. Your test_critical_section_lock tests will probably pass if you comment all critical section related calls out (it passed on my computer in 10 consecutive runs, never failed, probably it's because the code was optimized during compilation). Testing 5s/6s timeouts is also not a good idea. Because of it the tests are running much longer. It would be much better if you test following things: - just check some basic functionality of enter/leave: enter cs in main thread, start new thread that tries to enter it as well, wait for 100ms and check that it was not able to enter the cs, then leave cs in main thread and wait for thread to enter cs and finish - check some basic functionality of try_lock: use it to lock the cs, check if it fails on locked cs Also the tests failed on testbot, I was not checking why. Thanks, Piotr

3 3

Re: [PATCH 2/5] ddraw/tests: Add a test for color varyings clamping.
by Marvin March 28, 2016

March 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21748 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/3] d2d1/tests: Basic test for ID2D1DCRenderTarget creation
by Henri Verbeet March 28, 2016

March 28, 2016

On 28 March 2016 at 22:18, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + hr = ID2D1Factory_CreateDCRenderTarget(factory, &desc, &rt); > + todo_wine > + ok(hr == D2DERR_UNSUPPORTED_PIXEL_FORMAT, "Failed to create target, hr %#x.\n", hr); ... > + hr = ID2D1DCRenderTarget_EndDraw(rt, NULL, NULL); > + ok(hr == D2DERR_WRONG_STATE, "EndDraw() failed, hr %#x.\n", hr); Those messages are a bit misleading. (For what it's worth, we usually use "Got unexpected hr %#x.\n" for those.)

1 0

Re: [PATCH] d2d1: Added a stub implementation for ID2D1DCRenderTarget
by Nikolay Sivov March 28, 2016

March 28, 2016

Please ignore this one for now.

1 0

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture(v2).
by Henri Verbeet March 28, 2016

March 28, 2016

On 20 March 2016 at 19:24, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p\n", iface, debugstr_a(filename), texture); Missing period. > @@ -853,15 +859,19 @@ static HRESULT WINAPI d3drm2_CreateUserVisual(IDirect3DRM2 *iface, > static HRESULT WINAPI d3drm2_LoadTexture(IDirect3DRM2 *iface, > const char *filename, IDirect3DRMTexture2 **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, filename %s, texture %p stub!\n", iface, debugstr_a(filename), texture); > + TRACE("iface %p, filename %s, texture %p.\n", iface, debugstr_a(filename), texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = IDirect3DRM3_LoadTexture(&d3drm->IDirect3DRM3_iface, filename, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture2_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, &IID_IDirect3DRMTexture2, (void**)texture); > + IDirect3DRMTexture3_Release(texture3); > + if (FAILED(hr)) > + return hr; > > return D3DRM_OK; > } This is probably ok, but you may want to consider just introducing a helper function instead. I.e.: if (FAILED(hr = d3drm_load_texture(d3drm, filename, TRUE, &object))) return hr; IDirect3DRMTexture2_AddRef(*texture = &object->IDirect3DRMTexture2_iface); return D3DRM_OK; What happens when d3drm_texture_load() is called multiple times on the same texture? Should that be possible? > +void d3drm_texture_destroy(struct d3drm_texture *texture); Missing DECLSPEC_HIDDEN. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) DECLSPEC_HIDDEN; This line is a bit long. Try to stick to 120 columns as a maximum, preferably a bit less. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down); Missing DECLSPEC_HIDDEN. > @@ -4103,24 +4105,34 @@ static void test_load_texture(void) > > hr = IDirect3DRM_LoadTexture(d3drm1, filename, &texture1); > ok(SUCCEEDED(hr), "Test %u: Failed to load texture, hr %#x.\n", i, hr); > + ref2 = get_refcount((IUnknown *)d3drm1); > + ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u, ref2 = %u.\n", ref1, ref2); The message should mention which test (i.e., "i") failed. > d3drm_img = IDirect3DRMTexture_GetImage(texture1); > - todo_wine ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > + ok(!!d3drm_img, "Test %u: Failed to get image.\n", i); > if (d3drm_img) > test_bitmap_data(i * 4, d3drm_img, FALSE, tests[i].w, tests[i].h, tests[i].palettized); Now that IDirect3DRMTexture_GetImage() succeeds, you can remove the "if (d3drm_img)". > +void d3drm_texture_destroy(struct d3drm_texture *texture) > +{ > + if (texture->image) > + { > + TRACE("Releasing attached members.\n"); > + HeapFree(GetProcessHeap(), 0, texture->image->buffer1); > + if(texture->image->palette) Missing space between "if" and "(". > + HeapFree(GetProcessHeap(), 0, texture->image->palette); > + HeapFree(GetProcessHeap(), 0, texture->image); This seems a bit suspicious. Supposedly the "image" argument to d3drm3_CreateTexture() can be used to create a texture on an existing image. The documentation isn't very explicit about it, but suggests that the image data isn't copied in that case. So I'm not sure the texture is supposed to be responsible for destroying the image. In general I think it's not entirely clear how things like CreateTexture(), LoadTexture() and InitFromFile() etc. are supposed to interact. > +HRESULT d3drm_texture_load(struct d3drm_texture *texture, IDirect3DRM *d3drm, const char *path, BOOL load_upside_down) > +{ > + BITMAPINFO *info; > + BITMAPFILEHEADER *bmp_header; > + unsigned char *buffer; > + DWORD size; > + HANDLE hfile, hmapping; > + > + hfile = CreateFileA(path, GENERIC_READ, FILE_SHARE_READ, 0, OPEN_EXISTING, 0, 0); > + if (hfile == INVALID_HANDLE_VALUE) > + return D3DRMERR_BADFILE; > + > + size = GetFileSize(hfile, NULL); > + if (size == INVALID_FILE_SIZE) > + { > + DeleteObject(hfile); > + return D3DRMERR_BADVALUE; > + } You never use "size" after this, but you probably should. I also think you meant CloseHandle() instead of DeleteObject(). > + buffer = MapViewOfFile(hmapping, FILE_MAP_READ, 0, 0, 0); > + if (buffer == NULL) "if (!buffer)", or even "if (!(buffer = MapViewOfFile(...)))" > + bmp_header = (BITMAPFILEHEADER *)buffer; > + info = (BITMAPINFO *) (buffer + sizeof(*bmp_header)); Or just "info = (BITMAPINFO *)bmp_header + 1;". You should validate that this is actually a BMP file. You should also check which version of the BITMAPINFOHEADER structure the file has. > +D3DRMIMAGE *d3drm_create_image(unsigned char *buffer, BITMAPINFO *info, BOOL palette, BOOL upside_down) > +{ > + D3DRMPALETTEENTRY *colors = (D3DRMPALETTEENTRY *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 257 * sizeof(*colors)); Is "257" there intentional? The cast is unnecessary. HeapAlloc() can fail. Do you need HEAP_ZERO_MEMORY here? > + D3DRMIMAGE *image; > + BOOL black_used = FALSE; > + LONG w = info->bmiHeader.biWidth; > + LONG h = abs(info->bmiHeader.biHeight); > + int i, j, k; > + unsigned int idx, buffer1_idx; > + unsigned char *buffer1; > + int bpp = info->bmiHeader.biBitCount == 24 ? 32 : info->bmiHeader.biBitCount; > + int bpl = palette ? w : ((w + 3) & ~3) * bpp / 8; > + int num_colors = 0; > + struct colors_24bpp > + { > + BYTE red; > + BYTE green; > + BYTE blue; > + } *color; > + color = (struct colors_24bpp *)buffer; > + > + image = (D3DRMIMAGE *)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*image)); > + image->buffer1 = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(unsigned char) * bpl * h); This is unsafe. Consider e.g. what happens when the header gives you 0x10000 for width and height. > + buffer1 = image->buffer1; > + memset(buffer1, 255, sizeof(unsigned char) * bpl * h); You just initialised the memory with HEAP_ZERO_MEMORY, and now you're overwriting it again. At least one of these two initialisations is unnecessary, and quite possibly both of them.

3 21

Re: [PATCH 10/10] jscript: Find Function.arguments on the stack instead of storing it in FunctionInstance object.
by Marvin March 28, 2016

March 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21743 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

RE: regedit: Display REG_DWORD_BIG_ENDIAN values
by Hugh McMaster March 28, 2016

March 28, 2016

On Monday, March 28 2016, 21:05 UTC+11, Nikolay Sivov wrote: >On 28.03.2016 12:52, Hugh McMaster wrote: >> Signed-off-by: Hugh McMaster >> --- >> programs/regedit/listview.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c >> index c0119ff..5b1bd80 100644 >> --- a/programs/regedit/listview.c >> +++ b/programs/regedit/listview.c >> @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, >> ListView_SetItemTextW(hwndLV, index, 2, buf); >> } >> break; >> + case REG_DWORD_BIG_ENDIAN: { >> + DWORD i, value = 0; >> + BYTE *data = ValBuf; >> + WCHAR buf[64]; >> + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; >> + for (i = 0; i < dwCount; i++) { >> + value <<= 8; >> + value |= data[i]; >> + } >> + sprintfW(buf, fmt, value, value); >> + ListView_SetItemTextW(hwndLV, index, 2, buf); >> + } >> + break; >> case REG_BINARY: { >> unsigned int i; >> LPBYTE pData = ValBuf; >> >dwCount is always 1 in this case, dwCount is 4 for REG_DWORD and REG_DWORD_BIG_ENDIAN. >so it could be simplified to the point of swapping 'value' and >falling through to REG_DWORD case. I didn't check tests, but >you sure you need to modify what RegQueryValueExW() returns? On Windows, regedit displays the REG_DWORD type in little endian order and the REG_DWORD_BIG_ENDIAN type in big endian order. But both "reg query" and RegQueryValueEx() return any type of DWORD in little endian order. While it is true that there is common code in REG_DWORD and the BIG_ENDIAN case, I'm not sure there is a clean way to handle the endianness without checking for and handling the value type a second time.

1 0

[GSoC] Mailinglist discussions
by André Hentschel March 28, 2016

March 28, 2016

Hi, This year it's not possible to communicate with the GSoC Students over the GSoC-Project site. I guess the reason is to force communication with the community. Thus I suggest to move the discussions to wine-devel and prefix them with [GSoC] Thx

3 2

Re: msvcirt: Avoid superfluous comparison in some compilers
by Henri Verbeet March 28, 2016

March 28, 2016

On 27 March 2016 at 13:57, Iván Matellanes <matellanesivan(a)gmail.com> wrote: > - if (dir < SEEKDIR_beg || dir > SEEKDIR_end || !(mode & (OPENMODE_in|OPENMODE_out))) > + if ((dir != SEEKDIR_beg && dir != SEEKDIR_cur && dir != SEEKDIR_end) || !(mode & (OPENMODE_in|OPENMODE_out))) I'm not sure you're really making it better by adding another comparison. One alternative you may want to consider is just "(unsigned int)dir > SEEKDIR_end".

2 1

Re: regedit: Display REG_DWORD_BIG_ENDIAN values
by Nikolay Sivov March 28, 2016

March 28, 2016

On 28.03.2016 12:52, Hugh McMaster wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/listview.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c > index c0119ff..5b1bd80 100644 > --- a/programs/regedit/listview.c > +++ b/programs/regedit/listview.c > @@ -174,6 +174,19 @@ static void AddEntryToList(HWND hwndLV, LPWSTR Name, DWORD dwValType, > ListView_SetItemTextW(hwndLV, index, 2, buf); > } > break; > + case REG_DWORD_BIG_ENDIAN: { > + DWORD i, value = 0; > + BYTE *data = ValBuf; > + WCHAR buf[64]; > + WCHAR fmt[] = {'0','x','%','0','8','x',' ','(','%','u',')',0}; > + for (i = 0; i < dwCount; i++) { > + value <<= 8; > + value |= data[i]; > + } > + sprintfW(buf, fmt, value, value); > + ListView_SetItemTextW(hwndLV, index, 2, buf); > + } > + break; > case REG_BINARY: { > unsigned int i; > LPBYTE pData = ValBuf; > dwCount is always 1 in this case, so it could be simplified to the point of swapping 'value' and falling through to REG_DWORD case. I didn't check tests, but you sure you need to modify what RegQueryValueExW() returns?

1 0

Re: Assorted spelling fixes.
by Marvin March 28, 2016

March 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21718 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

1 0

Re: Assorted spelling fixes.
by Marvin March 28, 2016

March 28, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21717 Your paranoid android. === w864 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4317: Test failed: cw is 0xf60, expected 0x7f. device.c:4326: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: Assorted spelling fixes.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21714 Your paranoid android. === wvistau64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w2008s64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7u (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w7pro64 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w8 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w864 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === w1064 (32 bit moniker) === moniker: unhandled exception c0000005 at 0042D889 === wvistau64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w2008s64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w7pro64 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w864 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A === w1064 (64 bit moniker) === moniker: unhandled exception c0000005 at 0000000000426C3A

1 0

Re: Assorted spelling fixes.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21712 Your paranoid android. === w864 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: Assorted spelling fixes.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21705 Your paranoid android. === w1064 (32 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42]. === w1064 (64 bit uri) === uri.c:7615: Test failed: Expected google.com.uk but got L"com.uk" on uri_tests[71].str_props[3]. uri.c:7615: Test failed: Expected google.uk.1 but got L"uk.1" on uri_tests[73].str_props[3]. uri.c:7613: Test failed: GetPropertyBSTR returned 0x00000000, expected 0x00000001. On uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected but got L".uk" on uri_tests[76].str_props[3]. uri.c:7615: Test failed: Expected google.com.[] but got L"com.[]" on uri_tests[77].str_props[3]. uri.c:7800: Test failed: Error: Expected google.com.uk but got L"com.uk" on uri_tests[71]. uri.c:7800: Test failed: Error: Expected google.uk.1 but got L"uk.1" on uri_tests[73]. uri.c:7798: Test failed: Error: GetDomain returned 0x00000000, expected 0x00000001 on uri_tests[76]. uri.c:7800: Test failed: Error: Expected but got L".uk" on uri_tests[76]. uri.c:7800: Test failed: Error: Expected google.com.[] but got L"com.[]" on uri_tests[77]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[71].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 11 but got 4 on uri_tests[73].str_props[3]. uri.c:8078: Test failed: Error: GetPropertyLength returned 0x00000000, expected 0x00000001 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 0 but got 3 on uri_tests[76].str_props[3]. uri.c:8080: Test failed: Error: Expected a length of 13 but got 6 on uri_tests[77].str_props[3]. uri.c:8147: Test failed: Error: Received flag for property 3 when not expected on uri_tests[76]. uri.c:8197: Test failed: Error: Wasn't expecting to have property 3 on uri_tests[76]. uri.c:10487: Test failed: Error: Expected google.com.uk but got L"com.uk" instead on uri_parse_tests[42]. uri.c:10490: Test failed: Error: Expected 13, but got 6 instead on uri_parse_tests[42].

1 0

Re: Assorted spelling fixes.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21704 Your paranoid android. === wvistau64 (32 bit action) === The test timed out

1 0

Re: Assorted spelling fixes.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21702 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2326: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2326: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2510: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2657: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2657: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level

1 0

[GSoC] Support of pluggable theming engines
by André Hentschel March 27, 2016

March 27, 2016

Hi Ivan, all, You say in your proposal that you want to start with rewriting 30% of comctl32. Why so much? Is it currently needed for the gtk3 code in wine-staging?

4 11

Re: [v6 1/7] d3dx9: Introduce preshaders in effect.
by Matteo Bruni March 27, 2016

March 27, 2016

2016-03-23 18:02 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: Sorry, I thought about this only now: > @@ -5569,7 +5579,15 @@ static HRESULT d3dx9_parse_resource(struct d3dx9_base_effect *base, const char * > param->referenced_param = get_parameter_by_name(base, NULL, object->data); > if (param->referenced_param) > { > - TRACE("Mapping to parameter %p.\n", param->referenced_param); > + struct d3dx_parameter *refpar = param->referenced_param; > + > + TRACE("Mapping to parameter %p, having object id %u.\n", refpar, refpar->object_id); > + if (refpar->type == D3DXPT_VERTEXSHADER || refpar->type == D3DXPT_PIXELSHADER) > + { > + struct d3dx_object *refobj = &base->objects[refpar->object_id]; > + > + d3dx_create_param_eval(base, refobj->data, refobj->size, refpar->type, &refpar->param_eval); > + } If a parameter is referenced multiple times in an effect this probably allocates the param_eval structure more than once, leaking all but the last copy (well, it depends on the implementation of d3dx_create_param_eval(), but it should be the case here). I haven't tested that directly but I have tested that two references to the vs_arr array seem to lead to a similar issue WRT the array elements (i.e. the vertex shaders).

2 3

Re: d3d8: Unlock already unlocked surface does not fail
by Stefan Dösinger March 27, 2016

March 27, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-03-27 um 13:05 schrieb David Adam: > Signed-off-by: David Adam <david.adam.cnrs(a)gmail.com> > --- > dlls/d3d8/surface.c | 9 ++++----- > dlls/d3d8/tests/visual.c | 14 ++++++++++++++ > 2 files changed, 18 insertions(+), 5 deletions(-) > > diff --git a/dlls/d3d8/surface.c b/dlls/d3d8/surface.c > index 565f642..376bc6f 100644 > --- a/dlls/d3d8/surface.c > +++ b/dlls/d3d8/surface.c > @@ -271,11 +271,10 @@ static HRESULT WINAPI d3d8_surface_UnlockRect(IDirect3DSurface8 *iface) > hr = wined3d_resource_unmap(wined3d_texture_get_resource(surface->wined3d_texture), surface->sub_resource_idx); > wined3d_mutex_unlock(); > > - switch(hr) > - { > - case WINEDDERR_NOTLOCKED: return D3DERR_INVALIDCALL; > - default: return hr; > - } > + if (hr == WINEDDERR_NOTLOCKED) > + return D3D_OK; I suspect that similarly to lock validation the behavior of double unlocks depends on the resource type (surface vs texture). > @@ -178,6 +178,8 @@ static D3DCOLOR get_surface_color(IDirect3DSurface8 *surface, UINT x, UINT y) > > hr = IDirect3DSurface8_UnlockRect(surface); > ok(SUCCEEDED(hr), "Failed to unlock surface, hr=%#x.\n", hr); > + hr = IDirect3DSurface8_UnlockRect(surface); > + ok(SUCCEEDED(hr), "Failed to double unlock surface, hr=%#x.\n", hr); We have test_surface_double_unlock() in device.c and test_lockrect_invalid(). The test fits there better than sprinkled all around visual.c. (I have a preference for merging test_surface_double_unlock into test_lockrect_invalid, but I haven't looked closely how well that'll work) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW+AcxAAoJEN0/YqbEcdMwSYMP/ifDlI7N/z6QcEL6lRo9WsDr C+WfvTA6R4SRY+Wc/rWihX821b1mApv+kk9CSnZDSV96tpXKikjQdsMM5pB91oDW PDXxNkuoGpo1AR6gS5rve3fWc3vgRXSy7XzPLXAOlL6PF/lxbDcD/jixj8PjI6NZ Oel1ukbYuAr8dINKS8oB4tTZg59Pq/devXepJNlxxzfg11lgnoiF2kBYAlKZp+qC e59bWeZMixzB7ChzSUpAxlpjd+yipdtnVLKrq2codNYZn2Z+tV959MAZO+YYB35I BtHoSFNF16omLJ6qu9ZDZISOesep4YAlHyicERkZKR6kikaGI1/ezkxZtzD9zREn EDK5L+Trhar+XW/WgEYwJtIk9PAkJgLU53W5hgoq9TeDguMEtszvFj2GTStGEVnd M+dNN/4DQNg1aqCj1yRoom7N7WCVExWxdw9PlgqOFW68EjlNxZM2uO8S5pTNKx95 cBfxLYCI+agYj/aw3xOL3/yzNe4tI/pp+thsDlTqQZaXXTb3/S+ilChGEED9pQOz rHRQCP8yTsV9YtjWa2F+a/uSYP/LkZ9qFMkVzV9/nRw9GxpD0s2F7RdZVqhdW+VY eXW/YSDN+Mm8YF7MkWCKCeodDHL/VVqlDiEx8e+XQ96uELoiV2WP/GiVCwtjVMmb 9fib0jMQDGufm0Txe57H =pNWk -----END PGP SIGNATURE-----

1 0

Re: [1/3] user32/tests: Test loading monochrome icons.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21687 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2571: Test failed: LoadImage() failed with 0. cursoricon.c:2571: Test failed: LoadImage() failed with 0.

2 1

Re: [3/3] user32: Correctly determine bit count for BITMAPCOREINFO in is_dib_monochrome.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21689 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: [2/3] user32: Handle BITMAPCOREINFO when loading icons.
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21688 Your paranoid android. === w8 (32 bit cursoricon) === cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (32 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 00000000: (00000000, 00000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w864 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0. === w1064 (64 bit cursoricon) === cursoricon.c:1403: Test failed: Create cursor failed. cursoricon.c:1408: Test failed: GetIconInfo() failed. cursoricon.c:1410: Test failed: Last error: 1402 cursoricon.c:1425: Test failed: DestroyCursor() failed. cursoricon.c:1427: Test failed: Last error: 1402 cursoricon.c:1560: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1567: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1568: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0x0). cursoricon.c:1569: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 1). cursoricon.c:1575: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1587: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1593: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1602: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1604: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1605: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1608: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1627: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1633: Test failed: Create cursor failed (error = -559038737). cursoricon.c:1639: Test failed: Unexpected number of steps in cursor (0 != 1) cursoricon.c:1646: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1648: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1649: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbeef). cursoricon.c:1652: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != ~0). cursoricon.c:1669: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:1681: Test failed: Create cursor failed (error = deadbeef). cursoricon.c:1687: Test failed: Unexpected number of steps in cursor (0 != 3) cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 0. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xc0de). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 1. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xcafe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1698: Test failed: GetCursorFrameInfo() failed for cursor 0000000000000000: (0000000000000000, 0000000000000000). cursoricon.c:1439: Test failed: GetIconInfo() failed cursoricon.c:1700: Test failed: GetCursorFrameInfo() returned wrong cursor data for frame 2. cursoricon.c:1701: Test failed: GetCursorFrameInfo() unexpected param 4 value (0xdead != 0xbabe). cursoricon.c:1704: Test failed: GetCursorFrameInfo() unexpected param 5 value (57005 != 3). cursoricon.c:1712: Test failed: DestroyCursor() failed (error = 1402). cursoricon.c:2570: Test failed: LoadImage() failed with 0. cursoricon.c:2570: Test failed: LoadImage() failed with 0.

1 0

Re: d3d8: Unlock already unlocked surface does not fail
by Marvin March 27, 2016

March 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21685 Your paranoid android. === w8 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w864 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. === w1064 (32 bit visual) === visual.c:4173: Test failed: Failed to double unlock readback surface, hr 0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c. visual.c:182: Test failed: Failed to double unlock surface, hr=0x8876086c.

1 0

Re: [PATCH] winex11: Don't put a default icon on modal dialogs.
by Alexandre Julliard March 26, 2016

March 26, 2016

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -611,7 +612,7 @@ static void fetch_icon_data( HWND hwnd, HICON icon_big, HICON icon_small ) > if (!icon_small) icon_small = (HICON)GetClassLongPtrW( hwnd, GCLP_HICONSM ); > } > > - if (!GetIconInfo(icon_big, &ii)) return; > + if (!GetIconInfo(icon_small, &ii) && !GetIconInfo(icon_big, &ii)) return; This doesn't make sense. What are you trying to do? -- Alexandre Julliard julliard(a)winehq.org

2 5

[GSOC] Implement rendering for Direct3D Retained Mode
by Aaryaman Vasishta March 26, 2016

March 26, 2016

Hi, I have applied to GSoC this year, and I'm intending to continue my work on d3drm over this summer. Please review the proposal and provide feedback/comments, it would be very appreciated :) Cheers, Aaryaman

1 1

Re: [PATCH 1/3] msvcrt: Call C structured exception translator in x86_64 __CxxFrameHandler
by Piotr Caban March 26, 2016

March 26, 2016

Please ignore this patches for now, they are too buggy. It was working quite well in my tests but crashes with most real applications. Looks like local unwinding is implemented incorrectly. Thanks, Piotr

1 0

Re: [PATCH 5/5] d3d9/tests: Add a test for color varyings clamping.
by Marvin March 25, 2016

March 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21679 Your paranoid android. === w8 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (32 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w864 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1. === w1064 (64 bit visual) === visual.c:21659: Test failed: Got unexpected color 0x00808080, case 1.

1 0

Re: Need some advice on shell32
by Mathy Vanvoorden March 25, 2016

March 25, 2016

2016-03-25 16:15 GMT+01:00 Vincent Povirk <madewokherd(a)gmail.com>: > You didn't copy the list. Was that intentional? > Sorry, it was not, I recently switched to gmail and didn't notice the mailinglist fell off the CC list. > Related: While doing the research I came across some people trying to find > > out if the user is showing hidden files and there are some references to > > checking > Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\Hidden, > > would it not make sense to store the setting there in the same way > instead > > of the wine config? I'm not sure what the policy on this is. > > I'd consider "Are dotfiles hidden files?" and "Should shell views > display hidden files?" two distinct questions that should have > distinct settings. > I agree, they are.

1 0

Question about wine XWindow to HWND mapping
by Brandon Adkins March 25, 2016

March 25, 2016

Hi guys. I am working on porting a Windows application over to Linux, and my hope is to use Wine to make that go as quickly as possible. In my research, I have found one possible hangup, and hopefully you guys can answer it in a few minutes, vs the week or so of work for me to test it out myself. Long story short, I have an application which creates child HWNDs. The application also launches separate processes. When WM_PAINT messages come in for those child HWNDs, it passes the HWND to one of the other processes, and that other process is the one that actually draws on it. This works great on Windows. But I have found out that Wine only makes XWindows for top level HWNDs. So my question is: Can an application in wine perform operations (like drawing, BitBlting) onto a child HWND owned by another process? Any tips or guidance you can give will be greatly appreciated. Best regards!

2 2

Re: [PATCH] riched20: Implement ITextRange::ScrollIntoView.
by Huw Davies March 24, 2016

March 24, 2016

On Fri, Mar 18, 2016 at 11:59:52AM -0700, Adam Buchbinder wrote: > diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c > index 7c6c5d5..de3c7a0 100644 > --- a/dlls/riched20/tests/richole.c > +++ b/dlls/riched20/tests/richole.c > @@ -53,6 +53,7 @@ static HWND new_window(LPCSTR lpClassName, DWORD dwStyle, HWND parent) > HWND hwnd = CreateWindowA(lpClassName, NULL, > dwStyle | WS_POPUP | WS_HSCROLL | WS_VSCROLL | WS_VISIBLE, > 0, 0, 200, 60, parent, NULL, hmoduleRichEdit, NULL); > + ok(hwnd != NULL, "class: %s, error: %d\n", lpClassName, (int) GetLastError()); > return hwnd; > } > > @@ -761,6 +762,66 @@ static void test_ITextRange_GetChar(void) > ITextRange_Release(txtRge); > } > > +/* Helper function for testing ITextRange_ScrollIntoView */ > +static void check_range(HWND w, ITextDocument* doc, int first, int lim, > + LONG bStart, int expected_nonzero) { Please put the opening brace on a new line. More importantly, I get a test failure: richole.c:785: Test failed: Moved scrollbar is at 60, should be 0. (Range 0-160.) Huw.

2 3

Re: [PATCH] wined3d: Support D3DFMT_L8 format as render target when supported by GPU.
by Henri Verbeet March 24, 2016

March 24, 2016

On 23 March 2016 at 09:56, Paul Gofman <gofmanp(a)gmail.com> wrote: > Tested on Intel HD 4000 (L8 rt is not supported) and NVIDIA GeForce 650M > (L8 rt supported). Changes in query_internal_format are for avoiding > ERR in output when format is not supported as render target (RENDERTARGET > flag is cleared in check_fbo_compat which is called later). Is this needed by an application? Luminance formats aren't supposed to be color-renderable according to the OpenGL spec, and that's why you're getting GL_INVALID_ENUM in query_internal_format(). Does NVIDIA have some extension that allows this? > @@ -11279,6 +11279,7 @@ static void pixelshader_blending_test(void) > {"D3DFMT_R32F", D3DFMT_R32F, 0x0018ffff, 0x0020ffff}, > {"D3DFMT_G32R32F", D3DFMT_G32R32F, 0x001818ff, 0x002010ff}, > {"D3DFMT_A32B32G32R32F", D3DFMT_A32B32G32R32F, 0x00181800, 0x00201000}, > + {"D3DFMT_L8", D3DFMT_L8, 0x00181818, 0x002010ff}, The 0x002010ff there doesn't look right. It's also not exactly ideal that the red and green channels end up with the same values after blending, although that's and existing issue with the test.

3 7

Re: jscript: Added a few more arguments tests.
by Sebastian Lackner March 24, 2016

March 24, 2016

On 24.03.2016 16:39, Jacek Caban wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/jscript/tests/lang.js | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Was it intentional that the newly added function is never called?

2 1

Re: jscript: Added a few more arguments tests.
by Marvin March 24, 2016

March 24, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21665 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [v3] bcrypt: Added BCryptHash function.
by Patrick Armstrong March 24, 2016

March 24, 2016

Thanks for all the help with the reviews! > On Mar 24, 2016, at 2:53 AM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > > > >

1 0

Possible security bug with unmount
by Cédric Picard March 24, 2016

March 24, 2016

Hi, I find that DIR_unmount_device in wine/dlls/ntdll/directory.c (latest git) is looking like an unsafe use of system(). If a device was mounted to a point such as ";ls" I think it would be passed to system and cause a command injection. I didn't open a bug because I wasn't able to really test it due to my lack of knowledge of wine and because I can't think of a real world attack based on this as it needs to mount a device first but I think it's worth at least a thorough check. Cédric Picard

5 6

Re: [PATCH 1/4] xmllite/writer: Handle initial and ready states in the rest of tested Write* methods
by Dmitry Timoshkov March 24, 2016

March 24, 2016

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + switch (This->state) > + { > + case XmlWriterState_Initial: > + return E_UNEXPECTED; > + case XmlWriterState_DocClosed: > + return WR_E_INVALIDACTION; > + default: > + ; > + } What's wrong with explicit 'break;' instead of weird ';'? -- Dmitry.

1 0

Re: oleaut32: add OleLoadPictureFile stub (try 2)
by Dmitry Timoshkov March 24, 2016

March 24, 2016

Austin English <austinenglish(a)gmail.com> wrote: > -422 stub OleLoadPictureFile > +422 stdcall OleLoadPictureFile(long ptr) ... > +HRESULT WINAPI OleLoadPictureFile(VARIANT file, LPDISPATCH *picture) > +{ > + FIXME("(%p),stub!\n", picture); > + return E_NOTIMPL; > +} Is passing VARIANT by value supposed to be represented like this in a .spec file? -- Dmitry.

2 1

Re: oleaut32: add OleLoadPictureFile stub
by Andrew Eikum March 23, 2016

March 23, 2016

> + * OleLoadPictureFile (OLEAUT32.422) > + */ > +HRESULT WINAPI OleLoadPictureFile(VARIANT file, LPDISPATCH *picture) > +{ > + FIXME("(%p),stub!\n", picture); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > +/*********************************************************************** This should return an HRESULT, right? Probably E_NOTIMPL. Andrew

2 1

Re: [v2] d3d9: Add test for D3DFMT_L8 format as render target.
by Henri Verbeet March 23, 2016

March 23, 2016

On 23 March 2016 at 17:17, Paul Gofman <gofmanp(a)gmail.com> wrote: > @@ -11295,10 +11296,10 @@ static void pixelshader_blending_test(void) > /* Quad with R=0x10, G=0x20 */ > quad1[] = > { > - {{-1.0f, -1.0f, 0.1f}, 0x80102000}, > - {{-1.0f, 1.0f, 0.1f}, 0x80102000}, > - {{ 1.0f, -1.0f, 0.1f}, 0x80102000}, > - {{ 1.0f, 1.0f, 0.1f}, 0x80102000}, > + {{-1.0f, -1.0f, 0.1f}, 0x80103000}, > + {{-1.0f, 1.0f, 0.1f}, 0x80103000}, > + {{ 1.0f, -1.0f, 0.1f}, 0x80103000}, > + {{ 1.0f, 1.0f, 0.1f}, 0x80103000}, > }, The patch looks fine at first sight, but you should probably either update the comment or just remove it.

1 0

XInput and HID - architecture
by Juan Jose Gonzalez March 23, 2016

March 23, 2016

Hi, I got a bit stuck and would like to hear your opinion on the XInput HID backend, specifically on the mappings, i.e. the code that "accepts" a certain device based on its properties and then maps its buttons and axes to XInput buttons and axes. As long as the mappings are fixed, i.e. are not supposed to be extended or edited by the user, everything can be compiled into xinput1_3.dll. However, I would like to provide a "xinput.cpl" control panel node for xinput similar to "joy.cpl", where the user can not only test the XInput gamepads, but also manage the XInput-HID backend mappings. The first part can be accomplished by using xinput1_3.dll. However, in order to load and persist different mappings, the second part requires access to the functions that serialize and deserialize the mappings. It also needs some way of getting raw capabilities and changes in HID devices in order to be able to create new mappings. Here are some possible ways of solving it: * Extend xinput1_3.dll with the required management functions and add a "wine/xinput_hid_mgmt.h" or similar header that declares those methods. xinput.cpl could then simply use xinput1_3.dll to perform all management functions. I'm not sure if this would break anything due to the additional exports in the dll. * Extract the mapping load and store logic into a separate "xinputhid.dll" or similar. I this case both xinput1_3.dll and xinput.cpl would access this library to load and store mappings. * Move the xinput core and backends into a driver and let xinput1_3.dll access it via IOCTLs. I believe this is the way it works on windows, although there doesn't seem to be any freely available documentation regarding the internal architecture. The XInput-HID backend could then create its own kernel object as a management interface, which could be accessed by xinput.cpl. This would have the added effect of having a single instance managing the xinput devices if several programs are running at the same time, which mimics the behavior of windows. What do you think would be the best option? Is there another way I haven't mentioned? - Juan

6 24

Re: [PATCH 2/5] d3d11/tests: Add test for ClearRenderTargetView().
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21619 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/5] d3d10core/tests: Add test for ClearRenderTargetView().
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21618 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 4/4] xmllite/writer: Fix WriteEndElement()/WriteFullEndElement() on ready state
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21608 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] xmllite/writer: Properly fail on initial state in WriteEndElement()
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21607 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] xmllite/writer: Fix initial state handling in WriteEndDocument()
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21606 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/4] xmllite/tests: A test for Write* behaviour on initial writer state
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21605 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [v2] bcrypt: Added BCryptHash function.
by Hans Leidekker March 23, 2016

March 23, 2016

On Tue, 2016-03-22 at 07:50 -0700, Patrick Armstrong wrote: > +NTSTATUS WINAPI BCryptHash( BCRYPT_ALG_HANDLE algorithm, UCHAR *secret, ULONG secretlen, > + UCHAR *input, ULONG inputlen, UCHAR *output, ULONG outputlen ) > +{ > + NTSTATUS status; > + BCRYPT_HASH_HANDLE handle; > + > + TRACE( "%p, %p, %u, %p, %u, %p, %u\n", algorithm, secret, secretlen, > + input, inputlen, output, outputlen ); > + > + status = BCryptCreateHash( algorithm, &handle, NULL, 0, secret, secretlen, 0); > + if (status != STATUS_SUCCESS) > + { > + BCryptDestroyHash( handle ); > + return status; > + } BCryptCreateHash doesn't return a handle when it fails. > NTSTATUS WINAPI BCryptCloseAlgorithmProvider(BCRYPT_ALG_HANDLE, ULONG); > NTSTATUS WINAPI BCryptCreateHash(BCRYPT_ALG_HANDLE, BCRYPT_HASH_HANDLE *, PUCHAR, ULONG, PUCHAR, ULONG, ULONG); > NTSTATUS WINAPI BCryptDestroyHash(BCRYPT_HASH_HANDLE); > +NTSTATUS WINAPI BCryptHash(BCRYPT_ALG_HANDLE, PUCHAR, ULONG, PUCHAR, ULONG, PUCHAR, ULONG); > NTSTATUS WINAPI BCryptEnumAlgorithms(ULONG, ULONG *, BCRYPT_ALGORITHM_IDENTIFIER **, ULONG); > NTSTATUS WINAPI BCryptFinishHash(BCRYPT_HASH_HANDLE, PUCHAR, ULONG, ULONG); > NTSTATUS WINAPI BCryptGenRandom(BCRYPT_ALG_HANDLE, PUCHAR, ULONG, ULONG); While you're at it, please keep these sorted.

1 0

Re: [v5 2/8] d3dx9: Introduce preshaders in effect.
by Matteo Bruni March 23, 2016

March 23, 2016

2016-03-21 14:55 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > @@ -5435,9 +5416,30 @@ static HRESULT d3dx9_parse_array_selector(struct d3dx9_base_effect *base, struct > } > TRACE("Unknown DWORD: 0x%.8x.\n", *(DWORD *)(ptr + string_size)); > > - FIXME("Parse preshader.\n"); > + d3dx_create_param_eval(base, (DWORD *)(ptr + string_size) + 1, object->size - (string_size + 1), > + D3DXPT_INT, &param->param_eval); Does this do the right thing if ptr + string_size is aligned to a DWORD? In other words, does the bytecode contain 4 bytes of padding if string_size % 4 == 0?

2 2

Re: mshtml: Fixed remaining xmlhttprequest test failures.
by Marvin March 23, 2016

March 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21603 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [tools 2/2] Support for disabling and enabling warnings, handle warning number 2368
by Nikolay Sivov March 23, 2016

March 23, 2016

On 20.03.2016 13:12, Bolotov Sergey wrote: > diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c > index 8b65ead..137bb2d 100644 > --- a/tools/widl/write_msft.c > +++ b/tools/widl/write_msft.c > @@ -51,6 +51,7 @@ > #include "header.h" > #include "hash.h" > #include "typetree.h" > +#include "parser.h" > > enum MSFT_segment_index { > MSFT_SEG_TYPEINFO = 0, /* type information */ > @@ -504,7 +505,7 @@ static int ctl2_alloc_guid( > offset = ctl2_find_guid(typelib, hash_key, &guid->guid); > if (offset != -1) > { > - if (pedantic) > + if (is_warning_enabled(2368)) > warning("duplicate uuid {%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x}\n", > guid->guid.Data1, guid->guid.Data2, guid->guid.Data3, > guid->guid.Data4[0], guid->guid.Data4[1], guid->guid.Data4[2], guid->guid.Data4[3], > Duplicate UUID is not a warning 2368, it's an error 2270, I don't think you can suppress it, so we should really abort compilation at this point. Also if we're doing this, it looks cleaner to have is_warning..() check within warning(), so you can check there if it's enabled or not, and it's possible 'pedantic' should take precedence. Could you share a minimal idl you're using to test that?

2 3

Re: [v5 8/8] d3dx9: Implement setting named shader constants in effect.
by Matteo Bruni March 22, 2016

March 22, 2016

2016-03-21 14:55 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > +HRESULT d3dx_set_shader_const_fxlc(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, > + struct d3dx_parameter *param, unsigned int vs) Using a BOOL for the vs flag seems nicer. > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > index fec9de4..1770046 100644 > --- a/dlls/d3dx9_36/preshader.c > +++ b/dlls/d3dx9_36/preshader.c > @@ -242,7 +242,7 @@ static void regstore_set_values(struct d3dx_regstore *rs, unsigned int table, vo > static unsigned int regstore_is_val_set_reg(struct d3dx_regstore *rs, unsigned int table, unsigned int reg_idx) > { > return rs->table_value_set[table][reg_idx / PRES_BITMASK_BLOCK_SIZE] & > - (1ul << (reg_idx % PRES_BITMASK_BLOCK_SIZE)); > + (1u << (reg_idx % PRES_BITMASK_BLOCK_SIZE)); When you end up changing stuff introduced in a previous patch in the series you know there is something wrong ;) I guess it's a rebase glitch (by any chance, was this a remnant of a try with the uint_ptr idea you mentioned earlier?) > +HRESULT d3dx_param_eval_set_shader_constants(struct IDirect3DDevice9 *device, struct d3dx_param_eval *peval) > +{ > + HRESULT hr, res; > + struct d3dx_preshader *pres = &peval->pres; > + struct d3dx_regstore *rs = &pres->regs; > + > + TRACE("device %p, peval %p, param_type %u.\n", device, peval, peval->param_type); > + > + if (FAILED(hr = set_constants(rs, &pres->inputs))) > + return hr; > + if (FAILED(hr = execute_preshader(pres))) > + return hr; > + if (FAILED(hr = set_constants(rs, &peval->shader_inputs))) > + return hr; > + > + #define SET_TABLE(table, func_suff, type) \ > + { \ > + unsigned int is, n; \ > + \ > + is = 0; \ > + while (is < rs->table_sizes[table]) \ > + {\ > + n = 0; \ > + while (is < rs->table_sizes[table] && !regstore_is_val_set_reg(rs, table, is)) \ > + is++; \ > + while (is + n < rs->table_sizes[table] && regstore_is_val_set_reg(rs, table, is + n)) \ > + n++; \ > + if (!n) \ > + continue; \ > + TRACE("setting %u consts at %u.\n", n, is); \ > + hr = IDirect3DDevice9_##func_suff(device, is, \ > + (const type *)rs->tables[table] + is * table_info[table].reg_component_count, n); \ > + if (FAILED(hr)) \ > + { \ > + ERR(#func_suff " failed, hr %#x.\n", hr); \ > + res = hr; \ > + } \ > + is += n; \ > + } \ > + regstore_reset_table(rs, table); \ > + } > + res = D3D_OK; > + if (peval->param_type == D3DXPT_VERTEXSHADER) > + { > + SET_TABLE(PRES_REGTAB_OCONST, SetVertexShaderConstantF, float); > + SET_TABLE(PRES_REGTAB_OICONST, SetVertexShaderConstantI, int); > + SET_TABLE(PRES_REGTAB_OBCONST, SetVertexShaderConstantB, BOOL); > + } > + else if (peval->param_type == D3DXPT_PIXELSHADER) > + { > + SET_TABLE(PRES_REGTAB_OCONST, SetPixelShaderConstantF, float); > + SET_TABLE(PRES_REGTAB_OICONST, SetPixelShaderConstantI, int); > + SET_TABLE(PRES_REGTAB_OBCONST, SetPixelShaderConstantB, BOOL); > + } > + else > + { > + FIXME("Unexpected parameter type %u.\n", peval->param_type); > + return D3DERR_INVALIDCALL; > + } > + #undef SET_TABLE This is certainly hard to handle nicely because of the multiple similar d3d9 functions with slightly different signatures but I think it's better to avoid macros (especially such large ones) as much as possible. There are multiple ways to achieve that. Perhaps the easiest one is to turn SET_TABLE into a function taking an array of enum PRES_REG_TABLES (which, btw, should be lowercase) and the shader type as additional parameters, loop over the tables and call the correct d3d9 function by using two levels of switches (or ifs). The type isn't really necessary, you can calculate the offset with table_info[].component_size.

2 2

Re: [v5 1/8] d3dx9: Add test for preshader in effect.
by Matteo Bruni March 22, 2016

March 22, 2016

2016-03-21 14:55 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > +struct test_struct > +{ > + float3 v1; > + float fv; > + float4 v2; > +}; > + > +test_struct ts1[1] = {{{9, 10, 11}, 12, {13, 14, 15, 16}}}; > +test_struct ts2[2] = {{{0, 0, 0}, 0, {0, 0, 0, 0}}, {{1, 2, 3}, 4, {5, 6, 7, 8}}}; Is it also possible to create a struct with an array field? And an array of those structs? > + static const struct > + { > + const char *comment; > + BOOL todo[4]; > + unsigned int result[4]; > + } > + test_effect_preshader_op_results[] = > + { > + {"1 / op", { TRUE, TRUE, TRUE, TRUE}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > +#if __x86_64__ > + {"rsq", { TRUE, TRUE, TRUE, TRUE}, {0x7f800000, 0x7f800000, 0x3f2c985d, 0x1f800000}}, > +#else > + {"rsq", { TRUE, TRUE, TRUE, TRUE}, {0x7f800000, 0x7f800000, 0x3f2c985c, 0x1f800001}}, > +#endif > + {"mul", { TRUE, TRUE, TRUE, TRUE}, {0x00000000, 0x80000000, 0x40d33334, 0x7f800000}}, > + {"add", {FALSE, TRUE, TRUE, TRUE}, {0x3f800000, 0x40000000, 0xc0a66666, 0x7f7fffff}}, > + {"lt", {FALSE, FALSE, TRUE, FALSE}, {0x3f800000, 0x3f800000, 0x00000000, 0x00000000}}, > + {"ge", { TRUE, TRUE, FALSE, TRUE}, {0x00000000, 0x00000000, 0x3f800000, 0x3f800000}}, > + {"neg", { TRUE, TRUE, TRUE, TRUE}, {0x80000000, 0x00000000, 0x400ccccd, 0xff7fffff}}, > + {"rcp", { TRUE, TRUE, TRUE, TRUE}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > + {"frac", {FALSE, FALSE, TRUE, FALSE}, {0x00000000, 0x00000000, 0x3f4ccccc, 0x00000000}}, > + {"min", {FALSE, TRUE, TRUE, TRUE}, {0x00000000, 0x80000000, 0xc0400000, 0x40800000}}, > + {"max", { TRUE, TRUE, TRUE, TRUE}, {0x3f800000, 0x40000000, 0xc00ccccd, 0x7f7fffff}}, > +#if __x86_64__ > + {"sin", {FALSE, TRUE, TRUE, TRUE}, {0x00000000, 0x80000000, 0xbf4ef99e, 0xbf0599b3}}, > + {"cos", { TRUE, TRUE, TRUE, TRUE}, {0x3f800000, 0x3f800000, 0xbf16a803, 0x3f5a5f96}}, > +#else > + {"sin", {FALSE, TRUE, TRUE, TRUE}, {0x00000000, 0x80000000, 0xbf4ef99e, 0x3f792dc4}}, > + {"cos", { TRUE, TRUE, TRUE, TRUE}, {0x3f800000, 0x3f800000, 0xbf16a803, 0xbe6acefc}}, > +#endif > + {"den mul",{ TRUE, TRUE, TRUE, TRUE}, {0x7f800000, 0xff800000, 0xbb94f209, 0x000051ec}}, > + {"dot", {FALSE, TRUE, TRUE, FALSE}, {0x00000000, 0x7f800000, 0x41f00000, 0x00000000}}, > +#if __x86_64__ > + {"prec", { TRUE, TRUE, TRUE, FALSE}, {0x2b8cbccc, 0x2c0cbccc, 0xac531800, 0x00000000}} > +#else > + {"prec", { TRUE, TRUE, FALSE, FALSE}, {0x2b8cbccc, 0x2c0cbccc, 0x00000000, 0x00000000}} > +#endif > + }; I don't like those #ifdefs much although apparently I don't have nicer suggestions.

2 2

Re: [v5 5/8] d3dx9: Implement fxlc constants (expressions) in effect.
by Matteo Bruni March 22, 2016

March 22, 2016

2016-03-21 14:55 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > +static unsigned int regstore_is_val_set_reg(struct d3dx_regstore *rs, unsigned int table, unsigned int reg_idx) > +{ > + return rs->table_value_set[table][reg_idx / PRES_BITMASK_BLOCK_SIZE] & > + (1ul << (reg_idx % PRES_BITMASK_BLOCK_SIZE)); > +} Actually you don't want "ul" here, just "u". > +static void regstore_set_float(struct d3dx_regstore *rs, unsigned int table, unsigned int offset, float v) > +{ > + BYTE *p; > + unsigned int reg_idx; > + > + p = (BYTE *)rs->tables[table] + table_info[table].component_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : *(float *)p = v; break; > + case PRES_VT_DOUBLE: *(double *)p = v; break; > + case PRES_VT_INT : *(int *)p = roundf(v); break; > + case PRES_VT_BOOL : *(BOOL *)p = !!v; break; > + } > + reg_idx = OFFSET2REG(table, offset); > + rs->table_value_set[table][reg_idx / PRES_BITMASK_BLOCK_SIZE] |= > + 1ul << (reg_idx % PRES_BITMASK_BLOCK_SIZE); Same here. > +static HRESULT set_constants_param(struct d3dx_regstore *rs, struct d3dx_const_tab *const_tab, > + D3DXHANDLE hc, struct d3dx_parameter *param) > +{ > + ID3DXConstantTable *ctab = const_tab->ctab; > + D3DXCONSTANT_DESC desc; > + unsigned int const_count, param_count, i, j, n, table, start_offset; > + unsigned int nminor, nmajor, major_stride, inp_ind; Nitpick, also rename nmajor/nminor to major_size or just major (resp. minor). inp_ind also feels like it has room for improvement, although I don't have any good suggestion. > +#define ARGS_ARRAY_SIZE 8 > +static HRESULT execute_preshader(struct d3dx_preshader *pres) > +{ > + unsigned int i, j, k; > + float args[ARGS_ARRAY_SIZE]; Doesn't this need to be double to preserve the precision of the immediate operands / literals? I guess that means the regstore should also be able to return doubles.

1 0

Re: [v5 3/8] d3dx9: Implement preshader parsing.
by Matteo Bruni March 22, 2016

March 22, 2016

2016-03-21 14:55 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > +enum PRES_VALUE_TYPE Please use lowercase for type names. > +#define OFFSET2REG(table, offset) ((offset) / table_info[table].reg_component_count) I think this could be a function instead, that's usually preferred to macros when possible. Not sure about the name, maybe get_reg_offset(). > +static HRESULT regstore_alloc_table(struct d3dx_regstore *rs, unsigned int table) > +{ > + unsigned int sz; Nitpick, I would just spell out "size", it's pretty short anyway. > +static void regstore_set_values(struct d3dx_regstore *rs, unsigned int table, void *data, > + unsigned int start_offset, unsigned int count) > +{ > + unsigned int reg_idx; > + > + if (!count) > + return; > + > + memcpy((BYTE *)rs->tables[table] + start_offset * table_info[table].component_size, > + data, count * table_info[table].component_size); > + for (reg_idx = OFFSET2REG(table, start_offset); reg_idx <= OFFSET2REG(table, start_offset + count - 1); > + ++reg_idx) > + rs->table_value_set[table][reg_idx / PRES_BITMASK_BLOCK_SIZE] |= > + 1u << (reg_idx % PRES_BITMASK_BLOCK_SIZE); This might be optimized, enabling each bit one by one doesn't seem very efficient. > +} > + > +static void dump_bytecode(void *data, unsigned int size) > +{ > + unsigned int *bytecode = (unsigned int *)data; > + unsigned int i, j, n; > + > + size /= 4; Nitpick, sizeof(*bytecode).

1 0

Re: [v4 2/6] d3dx9: add preshaders to effect.
by Matteo Bruni March 22, 2016

March 22, 2016

2016-03-17 12:59 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > +enum PRES_REG_TABLES > +{ > + PRES_REGTAB_NONE, > + PRES_REGTAB_IMMED, /* immediate double constants from CLIT */ > + PRES_REGTAB_CONST, > + PRES_REGTAB_VERTEX, /* not used */ > + PRES_REGTAB_OCONST, > + PRES_REGTAB_OBCONST, > + PRES_REGTAB_OICONST, > + PRES_REGTAB_REG, > + PRES_REGTAB_MAX, > + PRES_REGTAB_FIRST = PRES_REGTAB_IMMED, > + PRES_REGTAB_LAST = PRES_REGTAB_REG, > +}; You can drop PRES_REGTAB_NONE unless it's going to be used. > +++ b/dlls/d3dx9_36/preshader.c > @@ -0,0 +1,627 @@ > +/* > + * FX preshader parsing & execution, setting shader constants > + * from effect parameters. > + * It looks like that kind of general file description is omitted in newer source files. Maybe drop it? I don't particularly care though. > + /* TODO: use double precision for x64 arch */ > + {sizeof(float), 4, PRES_VT_FLOAT } /* PRES_REGTAB_REG */ Nitpick, just mention "64 bit" or something, we don't want to make all the non-Intel archs angry ;) > +#define PRES_VS_BITS_PER_WORD (sizeof(unsigned int) * 8) What does the _VS_ part of the name mean? I'm also a bit thrown off by the _WORD part, mostly because in Win32 WORD is a 16 bit while DWORD is 32 bit and unsigned int is also 32 bit. Maybe it's just me, I don't know. > +static void dump_shader_bytecode(void *data, unsigned int size) > +{ > + unsigned int *words = (unsigned int *)data; Same here. I guess you could call it "bytecode" or such. > +static unsigned int *find_bytecode_comment(unsigned int *ptr, unsigned int fourcc) > +{ > + while ((*ptr & 0xFFFF) == 0xFFFE) A couple leftover uppercase hexadecimal constants. > + hr = D3DXGetShaderConstantTable(byte_code, &ctab); > + if (FAILED(hr) || !ctab) > + { > + TRACE("Could not get CTAB data, hr %#x.\n", hr); > + /* returning OK is not a typo */ > + return D3D_OK; > + } Sorry, back to that comment again. I guess it would be better to spell out why that's the intended return value instead (e.g. "Not returning an error, shaders without a CTAB are valid."). > +static void dump_arg(struct d3dx_regstore *rs, struct d3dx_pres_operand *arg, int component_count) > +{ > + static const char *xyzw_str = "xyzw"; > + unsigned int i, table; > + > + table = arg->table; > + if (table == PRES_REGTAB_IMMED) > + { > + TRACE("("); > + for (i = 0; i < component_count; ++i) > + TRACE(i < component_count - 1 ? "%lf, " : "%lf", > + ((double *)rs->tables[PRES_REGTAB_IMMED])[arg->offset + i]); %lf is not right, %f already expects a double. I'd just use %.16e (which has the added benefit of showing something different from 0 in the "precision" test from the previous patch). Another option would be to use the same format used by MS when disassembling shaders, although this seems to be a case where it's worth diverging. > +static void dump_ins(struct d3dx_regstore *rs, struct d3dx_pres_ins *ins) > +{ > + unsigned int i; > + > + TRACE(" %s ", pres_op_info[ins->op].mnem); > + dump_arg(rs, &ins->output, pres_op_info[ins->op].func_all_comps ? 1 : ins->component_count); > + for (i = 0; i < pres_op_info[ins->op].input_count; ++i) > + { > + TRACE(","); With a blank after the comma it would be prettier. There is still some inconsistent formatting (e.g. "== NULL" vs "!", uppercase hexadecimals, cnt vs count). A possible idea to split this patch further: what if you move the addition of (most of) the contents of the various functions in preshader.c to a separate patch? That is, make a patch which adds the various calls to d3dx_create_param_eval(), d3dx_free_param_eval() and similar (i.e. most if not all the changes to effect.c) but only introduces a skeleton implementation of those functions in preshader.c. Those are actually fleshed out only in the next patch. Many of the new preshader-related definitions can probably also go into the second patch. The traces of the disassembled preshader can also potentially go to a separate patch (leaving only dump_shader_bytecode() in the initial implementation - btw, I think it should be called dump_preshader_bytecode() given the renaming of the other stuff).

2 2

Re: [tools 1/2] Handle "midl_pragma warning" statement in parser
by Nikolay Sivov March 22, 2016

March 22, 2016

On 20.03.2016 13:11, Bolotov Sergey wrote: > Signed-off-by: Bolotov Sergey <bolotov.s.s(a)yandex.ru> > --- > tools/widl/parser.h | 2 ++ > tools/widl/parser.l | 25 +++++++++++++++++++++++++ > tools/widl/parser.y | 38 +++++++++++++++++++++++++++++++++++++- > tools/widl/widltypes.h | 7 +++++++ > 4 files changed, 71 insertions(+), 1 deletion(-) > > diff --git a/tools/widl/parser.h b/tools/widl/parser.h > index 1bcc3c1..c15d874 100644 > --- a/tools/widl/parser.h > +++ b/tools/widl/parser.h > @@ -45,6 +45,8 @@ void pop_import(void); > > int is_type(const char *name); > > +int do_warning(char *toggle, warning_list_t *wnum); > + > extern char *temp_name; > > #endif > diff --git a/tools/widl/parser.l b/tools/widl/parser.l > index 5c2dcab..65e0f45 100644 > --- a/tools/widl/parser.l > +++ b/tools/widl/parser.l > @@ -164,6 +164,7 @@ UUID *parse_uuid(const char *u) > yy_pop_state(); > } > <PP_PRAGMA>[^\n]* parser_lval.str = xstrdup(yytext); yy_pop_state(); return aPRAGMA; > +<INITIAL>^{ws}*"midl_pragma warning" return tPRAGMA_WARNING; > <INITIAL,ATTR>\" yy_push_state(QUOTE); cbufidx = 0; > <QUOTE>\" { This is wrong, any number of spaces is allowed before 'warning'. > yy_pop_state(); > @@ -555,3 +556,27 @@ void abort_import(void) > for (ptr=0; ptr<import_stack_ptr; ptr++) > unlink(import_stack[ptr].temp_name); > } > + > +static void warning_disable(int warning) > +{ > + printf("disable %d\n", warning); > +} > + > +static void warning_enable(int warning) > +{ > + printf("enable %d\n", warning); > +} > + > +int do_warning(char *toggle, warning_list_t *wnum) > +{ > + warning_t *warning; > + if(!strcmp(toggle, "disable")) > + LIST_FOR_EACH_ENTRY(warning, wnum, warning_t, entry) > + warning_disable(warning->num); > + else if(!strcmp(toggle, "enable")) > + LIST_FOR_EACH_ENTRY(warning, wnum, warning_t, entry) > + warning_enable(warning->num); > + else > + return 0; > + return 1; > +} You remove this in next patch, I think it'd be enough to add parser support first, so widl does not fail on such construct, and add handling as 2/2. Why do you need this in a first place? Is it to process some third party idls?

1 0

Re: [PATCH 1/6] ddraw/tests: Rewrite blt_test().
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21588 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w8 (32 bit visual) === visual.c:1387: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:1387: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1387: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Student interested in GSoC 2016 implementing D3DX9 API idea
by Xu Zhao March 22, 2016

March 22, 2016

Hello Wine Community, First congrats that Wine Project get accepted into GSoC 2016 summer organization! I am currently a PhD student in University of Toronto and I am interested in the D3DX9 API implementation task. Mainly because I would like to see more games can run in wine because of my work! My research field is operating system so I am a pretty good C/CPP programmer. However I am not very familiar with DirectX related programming and hopefully I can get some help from the community, like where to start. I have read the wiki entry of D3DX9 API and want to get some help in selecting a reasonable sized API list, maybe someone can reply and provide some help? Thank you! Regards, - Xu -- Xu Zhao i(a)xuzhao.net

2 2

Server Downtime 2016-03-16 19:00 CDT
by Jeremy Newman March 22, 2016

March 22, 2016

WineHQ.org and all related websites will be offline for maintenance and upgrades on 2016-03-16 starting at 19:00 CDT. This downtime should last 1-2 hours. Some websites may remain offline longer if they need additional work. I'll reply to this post when everything looks to be back online. -N

4 6

Re: [PATCH 2/6] ddraw/tests: Get rid of the unused "d3d" variable in test_shademode().
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21589 Your paranoid android. === w1064 (32 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw1) === ddraw1.c:2209: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] vulkan-icd: Add stub dll.
by Roderick Colenbrander March 22, 2016

March 22, 2016

Hi Gabríel, Thanks for your patch. Depending on the direction where you intend to take this, I'm not sure if we need this dll. Note I haven't done much with Vulkan myself yet, but following the analogy of opengl32, the ICD portion should be inside winex11.drv (and our other drivers). It is what should export this function call ultimately and similar needs to host the x11 related vulkan code, which has to live in here as well, because such code is not supposed to live outside winex11.drv. Thanks, Roderick On Mon, Mar 21, 2016 at 8:26 PM, Gabríel Arthúr Pétursson <gabriel(a)system.is> wrote: > Signed-off-by: Gabríel Arthúr Pétursson <gabriel(a)system.is> > --- > configure.ac | 1 + > dlls/vulkan-icd/Makefile.in | 2 ++ > dlls/vulkan-icd/vulkan-icd.spec | 1 + > 3 files changed, 4 insertions(+) > create mode 100644 dlls/vulkan-icd/Makefile.in > create mode 100644 dlls/vulkan-icd/vulkan-icd.spec > > diff --git a/configure.ac b/configure.ac > index 77c54c8..04ddb54 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3310,6 +3310,7 @@ WINE_CONFIG_DLL(vnbt.vxd,enable_win16) > WINE_CONFIG_DLL(vnetbios.vxd,enable_win16) > WINE_CONFIG_DLL(vssapi) > WINE_CONFIG_DLL(vtdapi.vxd,enable_win16) > +WINE_CONFIG_DLL(vulkan-icd,,[implib]) > WINE_CONFIG_DLL(vwin32.vxd,enable_win16) > WINE_CONFIG_DLL(w32skrnl,enable_win16) > WINE_CONFIG_DLL(w32sys.dll16,enable_win16) > diff --git a/dlls/vulkan-icd/Makefile.in b/dlls/vulkan-icd/Makefile.in > new file mode 100644 > index 0000000..c41bf8f > --- /dev/null > +++ b/dlls/vulkan-icd/Makefile.in > @@ -0,0 +1,2 @@ > +MODULE = vulkan-icd.dll > +IMPORTLIB = vulkan-icd > diff --git a/dlls/vulkan-icd/vulkan-icd.spec b/dlls/vulkan-icd/vulkan-icd.spec > new file mode 100644 > index 0000000..db3616e > --- /dev/null > +++ b/dlls/vulkan-icd/vulkan-icd.spec > @@ -0,0 +1 @@ > +@ stub vk_icdGetInstanceProcAddr > -- > 2.7.0 > > >

2 3

Re: services: Make release_process() static.
by Sebastian Lackner March 22, 2016

March 22, 2016

On 22.03.2016 11:26, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > programs/services/services.c | 12 ++++++------ > programs/services/services.h | 1 - > 2 files changed, 6 insertions(+), 7 deletions(-) > I do not mind if this patch is accepted, but follow patches would have to undo this change again. We also need the function from other services files.

1 0

Re: [PATCH 2/2] ddraw/tests: Use SetRect() instead of open coding it.
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21571 Your paranoid android. === w864 (32 bit d3d) === d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w1064 (32 bit d3d) === d3d.c:2311: Test failed: Unexpected destination texture level pixels; 2031 differences at 0 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 518 differences at 1 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 138 differences at 2 level d3d.c:2311: Test failed: Unexpected destination texture level pixels; 46 differences at 3 level d3d.c:2492: Test failed: Unexpected destination texture level pixels; 257 differences d3d.c:2636: Test failed: Unexpected destination texture level pixels; 256 differences at 2 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 64 differences at 3 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 16 differences at 4 level d3d.c:2636: Test failed: Unexpected destination texture level pixels; 4 differences at 5 level === w8 (32 bit visual) === visual.c:1478: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1478: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1478: Test failed: unexpected colortable on offscreen surface

2 1

Failing mshtml:xmlhttprequest test
by Francois Gouget March 22, 2016

March 22, 2016

Since the WineHQ.org upgrade the mshtml:xmlhttprequest test has been failing on all platforms: xmlhttprequest.c:448: Test failed: Expect Server: Apache, got L"Apache/2.4.10 (Debian)" Due to: 583 static const struct HEADER_TYPE expect_headers[] = { 584 {"Server", "Apache"}, 585 {"Accept-Ranges", "bytes"}, Fixing the failure is easy, but maybe the test should be more flexible? It could be annoying to have to upgrade it with each minor server upgrade. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Theory is where you know everything but nothing works. Practice is where everything works but nobody knows why. Sometimes they go hand in hand: nothing works and nobody knows why.

2 1

Re: [PATCH 1/2] ddraw/tests: Fix copy&paste errors in open coded SetRect()
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21570 Your paranoid android. === w8 (32 bit visual) === visual.c:1486: Test failed: unexpected colortable on offscreen surface === w864 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1486: Test failed: unexpected colortable on offscreen surface === w1064 (32 bit visual) === visual.c:307: Test failed: Clear rectangle 3(pos, neg) has color 0000ff00 visual.c:309: Test failed: Clear rectangle 1(pos, pos) has color 0000ff00 visual.c:311: Test failed: Clear rectangle 4(NULL) has color 0000ff00 visual.c:313: Test failed: Clear rectangle 4(neg, neg) has color 0000ff00 visual.c:1486: Test failed: unexpected colortable on offscreen surface

2 1

Re: [PATCH] msctf/tests: Fix a crash on unsupported interface
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21569 Your paranoid android. === w864 (32 bit inputprocessor) === inputprocessor.c:787: Test failed: Deactivation came unexpectedly === w1064 (64 bit inputprocessor) === inputprocessor.c:787: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH 2/2] msctf: Added stub ITextStoreACPServices support for context ITextStoreACPSink
by Marvin March 22, 2016

March 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21563 Your paranoid android. === w864 (32 bit inputprocessor) === inputprocessor.c:793: Test failed: Deactivation came unexpectedly

2 1

Re: [PATCH 1/2] d3drm: Move struct d3drm_texture to header for global access.
by Henri Verbeet March 21, 2016

March 21, 2016

On 20 March 2016 at 19:24, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > @@ -1038,12 +1029,11 @@ static const struct IDirect3DRMTexture3Vtbl d3drm_texture3_vtbl = > d3drm_texture3_SetValidationCallback, > }; > > -HRESULT Direct3DRMTexture_create(REFIID riid, IUnknown **out) > +HRESULT d3drm_texture_create(struct d3drm_texture **texture) > { > struct d3drm_texture *object; > - HRESULT hr; > > - TRACE("riid %s, out %p.\n", debugstr_guid(riid), out); > + TRACE("out %p.\n", texture); You'll also want to fix the TRACE message here.

2 1

Re: [PATCH] include: Use fixed stack size for rbtree.
by Henri Verbeet March 21, 2016

March 21, 2016

On 20 March 2016 at 21:05, Gabríel Arthúr Pétursson <gabriel(a)system.is> wrote: > struct wine_rb_stack > { > - struct wine_rb_entry ***entries; > size_t count; > - size_t size; > + struct wine_rb_entry **entries[2 * sizeof(void *) * 8]; > }; Why do you think this is a good idea?

4 12

Re: shell32: Don't return argified string in FindExecutable
by Alexandre Julliard March 21, 2016

March 21, 2016

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -698,10 +698,15 @@ static UINT SHELL_FindExecutable(LPCWSTR lpPath, LPCWSTR lpFile, LPCWSTR lpVerb, > > if (retval > 32) > { > - DWORD finishedLen; > - SHELL_ArgifyW(lpResult, resultLen, command, xlpFile, pidl, args, &finishedLen); > - if (finishedLen > resultLen) > - ERR("Argify buffer not large enough.. truncated\n"); > + if (exec_only) > + lstrcpynW(lpResult, command, resultLen); > + else > + { > + DWORD finishedLen; > + SHELL_ArgifyW(lpResult, resultLen, command, xlpFile, pidl, args, &finishedLen); > + if (finishedLen > resultLen) > + ERR("Argify buffer not large enough.. truncated\n"); > + } That's not much of an improvement, and I don't see why it should be limited to FindExecutable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: bcrypt: Added BCryptHash function.
by Hans Leidekker March 21, 2016

March 21, 2016

On Fri, 2016-03-18 at 09:26 -0700, Patrick Armstrong wrote: > +NTSTATUS WINAPI BCryptHash( BCRYPT_ALG_HANDLE algorithm, UCHAR *secret, ULONG secretlen, > + UCHAR *input, ULONG inputlen, UCHAR *output, ULONG outputlen ) > +{ > + NTSTATUS status; > + BCRYPT_ALG_HANDLE handle; This should be BCRYPT_HASH_HANDLE. > + TRACE( "%p, %p, %u, %p, %u, %p, %u\n", algorithm, secret, secretlen, > + input, inputlen, output, outputlen ); > + > + status = BCryptCreateHash( algorithm, &handle, NULL, 0, secret, secretlen, 0); > + if (status != STATUS_SUCCESS) > + { > + goto cleanup_bcrypt_hash; > + } There's no need for cleanup here. > + status = BCryptHashData( handle, input, inputlen, 0 ); > + if (status != STATUS_SUCCESS) > + { > + goto cleanup_bcrypt_hash; > + } >+ > + status = BCryptFinishHash( handle, output, outputlen, 0 ); > + if (status != STATUS_SUCCESS) > + { > + goto cleanup_bcrypt_hash; > + } > + > + return BCryptDestroyHash( handle ); > + > +cleanup_bcrypt_hash: > + > + BCryptDestroyHash( handle ); > + > + return status; > +} I don't think this goto is better than repeated BCryptDestroyHash calls.

1 0

Re: [v4 3/6] d3dx9: implement fxlc constants (expressions) in effect.
by Matteo Bruni March 21, 2016

March 21, 2016

2016-03-17 12:59 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > @@ -2616,7 +2630,7 @@ static void d3dx9_set_material_parameter(enum MATERIAL_TYPE op, D3DMATERIAL9 *ma > D3DCOLORVALUE c = *(D3DCOLORVALUE *)value; > > TRACE("%s, value (%f %f %f %f).\n", material_tbl[op].name, c.r, c.g, c.b, c.a); > - *(D3DCOLORVALUE *)((char *)material + material_tbl[op].offset) = c; > + *(D3DCOLORVALUE *)((BYTE *)material + material_tbl[op].offset) = c; > break; > } > default: While you're at it, you could change the format strings to use %.8e for the float values. > +static void regstore_reset_table(struct d3dx_regstore *rs, unsigned int table) > +{ > + unsigned int sz; > + > + sz = rs->table_sizes[table] * table_info[table].reg_component_count * table_info[table].component_size; > + > + memset(rs->tables[table], 0, sz); > + memset(rs->table_value_set[table], 0, > + sizeof(*rs->table_value_set[table]) * > + ((rs->table_sizes[table] + PRES_VS_BITS_PER_WORD - 1) / PRES_VS_BITS_PER_WORD)); > +} This function is unused and the compiler should throw a warning about it. > + rs->table_value_set[table][reg_idx / PRES_VS_BITS_PER_WORD] |= > + 1 << (reg_idx % PRES_VS_BITS_PER_WORD); That should be "1u", otherwise here shifting by 31 is technically undefined behavior and there are some compilers that complain about it. The line continuation is also misindented. > + while (param->member_count && param->element_count) > + { > + if (param->element_count > 1) > + { > + FIXME("Unexpected param having both elements and members.\n"); > + return D3DERR_INVALIDCALL; > + } > + param = &param->members[0]; > + } I don't quite understand what you're trying to do here but it doesn't look right. > + TRACE("%s rows %u, par columns %u, par class %u, par flags %u, par bytes %u, c rows %u," \ > + "c columns %u, c class %u, c bytes %u, transpose %u.\n", > + desc.Name, param->rows, param->columns, param->class, param->flags, param->bytes, > + desc.Rows, desc.Columns, desc.Class, desc.Bytes, transpose); I would make two separate TRACEs for parameter and constant info. Also the string comes from the application so you should use debugstr_a(). Something like: TRACE("Constant %s rows %u, columns %u, class %u, bytes %u.\n", debugstr_a(desc.Name), desc.Rows, desc.Columns, desc.Class, desc.Bytes); TRACE("Parameter rows %u, columns %u, class %u, flags %#x, bytes %u, transpose %#x.\n", param->rows, param->columns, param->class, param->flags, param->bytes, transpose); Gmail will probably mangle the code but you get the point.

2 2

Wine fonts
by Jens Reyer March 21, 2016

March 21, 2016

Hi, I'm currently working on the correct Debian packaging of the fonts. Afaik vanilla wine installs the following ttf-fonts: marlett.ttf symbol.ttf tahomabd.ttf tahoma.ttf wingding.ttf I realize that these are indeed necessary for the fon-fonts to display correctly. However in the source there are additionally the following ttf: courier.ttf fixedsys_jp.ttf fixedsys.ttf ms_sans_serif.ttf small_fonts_jp.ttf small_fonts.ttf system.ttf Shouldn't these be installed, too? I haven't noted any difference, but that could be because I don't know how to test this. Can anybody with more knowledge enlighten me? Thanks in advance! jre

2 1

Re: winscard: add stubs for SCardListReadersA/W (try 4)
by Nikolay Sivov March 21, 2016

March 21, 2016

Spec file needs fixing too.

1 0

Re: winscard: add stubs for SCardListReadersA/W (try 3)
by Nikolay Sivov March 20, 2016

March 20, 2016

> +LONG WINAPI SCardListReadersA(SCARDCONTEXT context, const CHAR *groups, char *readers, DWORD *buflen) > +{ > + FIXME("(%lx, %s, %s, %p) stub\n", context, debugstr_a(groups), debugstr_a(readers), buflen); > + return SCARD_F_INTERNAL_ERROR; > +} > + > +LONG WINAPI SCardListReadersW(SCARDCONTEXT context, const WCHAR *groups, WCHAR *readers, DWORD *buflen) > +{ > + FIXME("(%lx, %s, %s, %p) stub\n", context, debugstr_w(groups), debugstr_w(readers), buflen); > + return SCARD_F_INTERNAL_ERROR; > +} 'readers' is an out buffer.

1 0

Re: [PATCH v2 2/6] wined3d: Implement copying of buffer resources.
by Henri Verbeet March 20, 2016

March 20, 2016

On 20 March 2016 at 23:15, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + buffer_get_memory(dst_buffer, context, &dst_bo_address); > + buffer_get_memory(src_buffer, context, &src_bo_address); > + > + dst_buffer_mem = dst_buffer->resource.heap_memory; > + src_buffer_mem = src_buffer->resource.heap_memory; > + > + if (!dst_buffer_mem && !src_buffer_mem) > + { The way struct wined3d_bo_address works is that if the "buffer_object" field is non-zero, the "addr" field is relative to the start of the corresponding buffer object, and otherwise it's relative to the start of system memory. I.e., the correct check here should be for src_bo_address.buffer_object and dst_bo_address.buffer_object being non-zero, and you should be able to use src_bo_address.addr and dst_bo_address.addr instead of src_buffer_mem and dst_buffer_mem in most other places. > + if (gl_info->supported[ARB_COPY_BUFFER]) > + { > + GL_EXTCALL(glBindBuffer(GL_COPY_READ_BUFFER, src_bo_address.buffer_object)); > + GL_EXTCALL(glBindBuffer(GL_COPY_WRITE_BUFFER, dst_bo_address.buffer_object)); > + GL_EXTCALL(glCopyBufferSubData(GL_COPY_READ_BUFFER, GL_COPY_WRITE_BUFFER, src_offset, dst_offset, size)); The "addr" field is always going to be NULL in practice for buffer resources, but strictly speaking you should use something like "(INT_PTR)src_bo_address.add + src_offset" instead of just "src_offset" here.

2 1

prelink
by version2013＠openmailbox.org March 20, 2016

March 20, 2016

According to [1], prelink is no longer needed. When I configure wine-1.9.6, I get the warning message, "configure: WARNING: prelink not found and linker does not support relocation, base address of core dlls won't be set correctly." [1] http://oldwiki.winehq.org/Prelink

4 3

Re: [PATCH 1/2] d3drm: Move struct d3drm_texture to header for global access.
by Józef Kucia March 20, 2016

March 20, 2016

On Sun, Mar 20, 2016 at 7:24 PM, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > CloseHandle(file); > - > - hr = Direct3DRMTexture_create(&IID_IDirect3DRMTexture3, (IUnknown**)&This->materials[i].texture); > + struct d3drm_texture *texture_object; > + hr = d3drm_texture_create(&texture_object); > if (FAILED(hr)) Put the "texture_object" declaration at the beginning of the block or the function. Mixed declarations and code is C99 feature and is not allowed in Wine. Also, "if (FAILED(hr = d3drm_texture_create(&texture_object)))" would be preferred.

1 0

Re: [2/3] shell32/tests: Move a file URL test to test_fileurl().
by Marvin March 20, 2016

March 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21531 Your paranoid android. === wvistau64 (32 bit shlexec) === shlexec.c:1690: Test failed: ShellExecute(verb="", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\masked file.shlexec") WaitForSingleObject returned 258 shlexec.c:1698: Test failed: ShellExecute(verb="", file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\masked file.shlexec"") ShlexecVar expected 'Present', but key not found or empty shlexec.c:1712: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\masked file.shlexec"") argvA3 expected 'Open', but key not found or empty shlexec.c:1714: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\masked file.shlexec"") argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\masked file.shlexec', but key not found or empty shlexec.c:1723: Test failed: ShellExecute(verb="LowerL", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1772: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.shlexec"") argcA expected 5, but got 6 shlexec.c:1773: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.shlexec"") argvA3 expected 'Open', got 'UpperL' shlexec.c:1775: Test failed: ShellExecute(file=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.shlexec"") argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.shlexec', got 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test' shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail=""%1"", ddeexec="[open("%1")]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="%1", ddeexec="[open(%1)]", app="shlexec", topic="dde" failed: rc=2 err=2 shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec", topic="dde", ifexec="[ifexec("%1")]" failed: rc=2 err=2 shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", app="shlexec" failed: rc=2 err=2 shlexec.c:2466: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2483: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="0", cmdtail="", ddeexec="[open("%1")]", topic="dde" failed: rc=2 err=2 shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2 file.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.exe"", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.exe" param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2 file.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2 file.exe"", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail=""C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2 file.exe" param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2 param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\notexist.exe", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\notexist.exe param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="cmd", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="cmd param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="xyzwxyzwxyz", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2580: Test failed: ShellExecuteEx(mask="0x8540", file="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test file.sde") Assoc class="shlexec.sde", verb="Open", rawcmd="1", cmdtail="xyzwxyzwxyz param", ddeexec="[test]", topic="shlexec" ShlexecVar expected 'Present', but key not found or empty shlexec.c:2855: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2858: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec") argvA3 expected 'Exec', but key not found or empty shlexec.c:2859: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2.exe', but key not found or empty shlexec.c:2863: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2868: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp") WaitForSingleObject returned 258 shlexec.c:2868: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2871: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp") argvA3 expected 'Exec', but key not found or empty shlexec.c:2872: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="C:\Users\winetest\AppData\Local\Temp\wtD670.tmp") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2.exe', but key not found or empty shlexec.c:2876: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="%TMPDIR%") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2880: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="%TMPDIR%") WaitForSingleObject returned 258 shlexec.c:2880: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="%TMPDIR%") ShlexecVar expected 'Present', but key not found or empty shlexec.c:2883: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="%TMPDIR%") argvA3 expected 'Exec', but key not found or empty shlexec.c:2884: Test failed: ShellExecuteEx(mask="0x808640", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="%TMPDIR%") longPath expected 'C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\test2.exe', but key not found or empty shlexec.c:2889: Test failed: ShellExecuteEx(mask="0x808440", file="test2.exe", params="shlexec "C:\Users\winetest\AppData\Local\Temp\wtD670.tmp\wtD671.tmp" Exec", dir="C:\Users\Public\Documents:C:\Users\winetest\AppData\Local\Temp\wtD670.tmp") ShlexecVar expected 'Present', but key not found or empty

1 0

Re: [1/3] shell32/tests: Delete the shlproto test class when done.
by Marvin March 20, 2016

March 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21530 Your paranoid android. === wvistau64 (64 bit shlexec) === shlexec.c:1979: Test failed: ShellExecuteEx(mask="0x8640", file="shlproto://%TMPDIR%/bar") WaitForSingleObject returned 258 shlexec.c:1983: Test failed: ShellExecuteEx(mask="0x8640", file="shlproto://%TMPDIR%/bar") argvA3 expected 'URL', but key not found or empty shlexec.c:1984: Test failed: ShellExecuteEx(mask="0x8640", file="shlproto://%TMPDIR%/bar") argvA4 expected 'shlproto://C:\Users\winetest\AppData\Local\Temp\wtCE84.tmp/bar', but key not found or empty shlexec.c:1988: Test failed: ShellExecute(verb="", file="%urlprefix%foo") ShlexecVar expected 'Present', but key not found or empty

1 0

Re: [v4 1/6] d3dx9: add test for preshader in effect.
by Matteo Bruni March 19, 2016

March 19, 2016

2016-03-17 12:59 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: Nice job. I have a few nitpicks still... > +static const D3DXVECTOR4 test_effect_preshader_fconstsv[] = > +{ > + {11.0f, 12.0f, 13.0f, 0.0f}, > + {21.0f, 22.0f, 23.0f, 0.0f}, > + {31.0f, 32.0f, 33.0f, 0.0f}, > + {41.0f, 42.0f, 43.0f, 0.0f}, > + {11.0f, 21.0f, 31.0f, 0.0f}, > + {12.0f, 22.0f, 32.0f, 0.0f}, > + {13.0f, 23.0f, 33.0f, 0.0f}, > + {14.0f, 24.0f, 34.0f, 0.0f}, > + {11.0f, 12.0f, 13.0f, 14.0f}, > + {21.0f, 22.0f, 23.0f, 24.0f}, > + {31.0f, 32.0f, 33.0f, 34.0f}, > + {11.0f, 21.0f, 31.0f, 41.0f}, > + {12.0f, 22.0f, 32.0f, 42.0f}, > + {13.0f, 23.0f, 33.0f, 43.0f}, > + {4.0f, 5.0f, 6.0f, 7.0f} > +}; > + > +static const D3DXVECTOR4 test_effect_preshader_fconstsp[] = > +{ > + {11.0f, 21.0f, 0.0f, 0.0f}, > + {12.0f, 22.0f, 0.0f, 0.0f}, > + {13.0f, 23.0f, 0.0f, 0.0f}, > + {11.0f, 12.0f, 0.0f, 0.0f}, > + {21.0f, 22.0f, 0.0f, 0.0f}, > + {31.0f, 32.0f, 0.0f, 0.0f}, > + {11.0f, 12.0f, 0.0f, 0.0f}, > + {21.0f, 22.0f, 0.0f, 0.0f}, > + {11.0f, 21.0f, 0.0f, 0.0f}, > + {12.0f, 22.0f, 0.0f, 0.0f}, > + {11.0f, 12.0f, 13.0f, 0.0f}, > + {21.0f, 22.0f, 23.0f, 0.0f}, > + {11.0f, 21.0f, 31.0f, 0.0f}, > + {12.0f, 22.0f, 32.0f, 0.0f} > +}; > + > +static const BOOL test_effect_preshader_bconsts[] = > +{ > + TRUE, FALSE, TRUE, FALSE, TRUE, FALSE > +}; > + > +static const struct > +{ > + const char *comment; > + unsigned int todo[4]; > + unsigned int result[4]; > +} > +test_effect_preshader_op_results[] = > +{ > + {"1 / op", {1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > + {"rsq", {1, 1, 3, 3}, {0x7f800000, 0x7f800000, 0x3f2c985d, 0x1f800000}}, > + {"mul", {1, 1, 1, 1}, {0x00000000, 0x80000000, 0x40d33334, 0x7f800000}}, > + {"add", {0, 1, 1, 1}, {0x3f800000, 0x40000000, 0xc0a66666, 0x7f7fffff}}, > + {"lt", {0, 0, 1, 0}, {0x3f800000, 0x3f800000, 0x00000000, 0x00000000}}, > + {"ge", {1, 1, 0, 1}, {0x00000000, 0x00000000, 0x3f800000, 0x3f800000}}, > + {"neg", {1, 1, 1, 1}, {0x80000000, 0x00000000, 0x400ccccd, 0xff7fffff}}, > + {"rcp", {1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > + {"frac", {0, 0, 1, 0}, {0x00000000, 0x00000000, 0x3f4ccccc, 0x00000000}}, > + {"min", {0, 1, 1, 1}, {0x00000000, 0x80000000, 0xc0400000, 0x40800000}}, > + {"max", {1, 1, 1, 1}, {0x3f800000, 0x40000000, 0xc00ccccd, 0x7f7fffff}}, > + {"sin", {0, 1, 1, 3}, {0x00000000, 0x80000000, 0xbf4ef99e, 0xbf0599b3}}, > + {"cos", {1, 1, 1, 3}, {0x3f800000, 0x3f800000, 0xbf16a803, 0x3f5a5f96}}, > + {"den mul",{1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbb94f209, 0x000051ec}}, > + {"dot", {0, 1, 1, 0}, {0x00000000, 0x7f800000, 0x41f00000, 0x00000000}}, > + {"prec", {1, 1, 2, 0}, {0x2b8cbccc, 0x2c0cbccc, 0x00000000, 0x00000000}} > +}; > + > +#define TEST_EFFECT_PRES_NFLOATV ARRAY_SIZE(test_effect_preshader_fconstsv) > +#define TEST_EFFECT_PRES_NFLOATP ARRAY_SIZE(test_effect_preshader_fconstsp) > +#define TEST_EFFECT_PRES_NFLOATMAX (TEST_EFFECT_PRES_NFLOATV > TEST_EFFECT_PRES_NFLOATP ? \ > + TEST_EFFECT_PRES_NFLOATV : TEST_EFFECT_PRES_NFLOATP) > +#define TEST_EFFECT_PRES_NBOOL ARRAY_SIZE(test_effect_preshader_bconsts) > +#define TEST_EFFECT_PRES_NOPTESTS ARRAY_SIZE(test_effect_preshader_op_results) Those arrays above should probably be inside test_effect_preshader(), unless you plan to add other functions needing them. > + for ( ; i < 16; ++i) Those spaces in place of the first "for" expression look weird. Just leave that empty i.e. for (; i < 16; ++i) > + for (i = 0; i < TEST_EFFECT_PRES_NOPTESTS; ++i) > + { > + unsigned int *v; > + > + hr = IDirect3DDevice9_GetLight(device, i % 8, &light); > + v = i < 8 ? (unsigned int *)&light.Diffuse : (unsigned int *)&light.Ambient; > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + for (j = 0; j < 4; ++j) > + todo_wine_if(test_effect_preshader_op_results[i].todo[j] & 1) > + ok(v[j] == test_effect_preshader_op_results[i].result[j] > + || ((test_effect_preshader_op_results[i].todo[j] & 2) > + && broken(v[j] != test_effect_preshader_op_results[i].result[j])), > + "Operation %s, component %u, expected %#x, got %#x (%g).\n", > + test_effect_preshader_op_results[i].comment, j, > + test_effect_preshader_op_results[i].result[j], v[j], ((float *)v)[j]); I don't like that broken(), it isn't checking much (i.e. the condition is true for almost any value) and overloading the "todo" field for that doesn't seem too clean. Maybe something like this for the test results table would help: static const struct { const char *name; unsigned int expected[4]; BOOL todo[4]; unsigned int expected_broken[4]; } I think all the broken results are != 0 so expected_broken also works as a flag. If that's not the case you can add explicit "BOOL broken[4]" flags. You can then leave out the todo and expected_broken fields for the table entries which don't require them, since they end up zero-initialized. Maybe also add a small comment for each broken value, if it makes sense? > + todo_wine ok(!memcmp(byte_code, > + &test_effect_preshader_effect_blob[TEST_EFFECT_PRESHADER_VSHADER_POS + > + 1 * TEST_EFFECT_PRESHADER_VSHADER_LEN], byte_code_size), You can leave out the "1 *", it's pretty clear either way.

2 2

Re: [PATCH 2/5] wined3d: Implement copying of buffer resources.
by Henri Verbeet March 19, 2016

March 19, 2016

On 18 March 2016 at 12:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +HRESULT wined3d_buffer_copy(struct wined3d_buffer *dst_buffer, unsigned int dst_offset, > + struct wined3d_buffer *src_buffer, unsigned int src_offset, unsigned int size) > +{ > + BYTE *dst_buffer_mem, *src_buffer_mem; > + const struct wined3d_gl_info *gl_info; > + struct wined3d_context *context; > + struct wined3d_device *device; > + > + device = dst_buffer->resource.device; > + > + context = context_acquire(device, NULL); > + gl_info = context->gl_info; > + > + buffer_internal_preload(dst_buffer, context, NULL); > + buffer_internal_preload(src_buffer, context, NULL); > + > + dst_buffer_mem = dst_buffer->resource.heap_memory; > + src_buffer_mem = src_buffer->resource.heap_memory; This is probably fine, but I wonder why you're not using buffer_get_memory()? Somewhat related, there may be something to be said for the function just taking wined3d_bo_address structures and a size, although I don't have an immediate use for that yet. > + > + if (!dst_buffer_mem && !src_buffer_mem) > + { > + if (!gl_info->supported[ARB_COPY_BUFFER]) > + { > + FIXME("Direct buffer copy not supported.\n"); > + return WINED3DERR_INVALIDCALL; > + } I think that's fine, but we could of course implement that case by mapping the buffers and using memcpy().

2 2

Re: [PATCH 3/5] wined3d: Add support for buffers in wined3d_device_copy_sub_resource().
by Henri Verbeet March 19, 2016

March 19, 2016

On 18 March 2016 at 12:30, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (src_offset > src_resource->size > + || src_offset + size > src_resource->size That's not a safe way to validate "size". For large enough values of "size", "src_offset + size" may wrap to something smaller than "src_resource->size". You'd typically do something like "size > src_resource->size - src_offset" instead.

1 0

Re: [PATCH] msvcr120/tests: Add critical section test.
by Marvin March 18, 2016

March 18, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21522 Your paranoid android. === w2008s64 (64 bit msvcr120) === msvcr120: unhandled exception c0000005 at 000007FEF6F8B045

1 0

GSoC Idea: Winetest Graphical User Interface
by Zhenbo Li March 18, 2016

March 18, 2016

Hello, I'm Zhenbo Li. This year, I wish to work on a project related to wine test suite. Previously, I sent a mail for Winetest Scripting Interface. A better winetest.exe should have such functions: 1. Choose which dlls to be tested. Users could use GUI, CLI, or a config file. 2. Show the result in winetest, or render it to html 3. Allow to leave tag and email blank if the user doesn't want to submit the result to test.winehq.org, and they can fill them when submitting them. I'm wondering whether this job would be enough for a summer, and I'm glad to write a script for wine test suite as another part of my job. Really appreciate your comments. -- Have a nice day! Zhenbo Li

6 7

Re: [v3 resend 2/6] d3dx9: add preshaders to effect.
by Matteo Bruni March 17, 2016

March 17, 2016

2016-03-10 19:50 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> Looks pretty good to me in general. I also like d3dx_param_eval and related names. > + for (i = 0; i < param->element_count; i++) > + { > + if (param->members[i].type != param->type) > + { > + FIXME("Unexpected member parameter type %u (need %u).\n", param->members[i].type, param->type); I would use "expected" or something similar instead of "need" in this message. > diff --git a/dlls/d3dx9_36/preshader.c b/dlls/d3dx9_36/preshader.c > new file mode 100644 > index 0000000..409c00f > --- /dev/null > +++ b/dlls/d3dx9_36/preshader.c > @@ -0,0 +1,688 @@ > +/* > + * FX preshader parsing & execution, setting shader constants > + * from effect parameters. > + * > + * Copyright 2016 Paul Gofman > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "config.h" > +#include "wine/port.h" > + > +#include "windef.h" > +#include "wingdi.h" Not your fault but those shouldn't be there. wingdi.h is already included by d3dx9_36_private.h, while windef.h is not but still it's necessary to avoid errors when including d3dx9_36_private.h. I'm sending a patch cleaning up the includes in d3dx9 (and renaming d3dx9_36_private.h to d3dx9_private.h while at it), please update this patch accordingly. > +static const struct > +{ > + unsigned int value_size; > + unsigned int reg_value_cnt; Just my preference, I would go with component_size and component_count (or maybe reg_component_count). > + {sizeof(float), 4, PRES_VT_FLOAT } /* PRES_REGTAB_REG */ I think I had tested this in the past and it turned out temporaries are stored as doubles. I'll see if I can find something. > +static const char *table_symbol[] = > +{ > + "(null)", "imm", "c", "v", "oc", "ob", "oi", "r" > +}; > + > +static const char *xyzw_str = "xyzw"; I haven't checked but maybe you can put those directly in the function using them. > + > +#define OFFSET2REG(table, offset) ((offset) / table_info[table].reg_value_cnt) > + > +static const enum PRES_REG_TABLES pres_regset2table[] = > +{ > + PRES_REGTAB_OBCONST, /* D3DXRS_BOOL */ > + PRES_REGTAB_OICONST, /* D3DXRS_INT4 */ > + PRES_REGTAB_CONST, /* D3DXRS_FLOAT4 */ > + PRES_REGTAB_NONE, /* D3DXRS_SAMPLER */ > +}; > + > +static const enum PRES_REG_TABLES shad_regset2table[] = > +{ > + PRES_REGTAB_OBCONST, /* D3DXRS_BOOL */ > + PRES_REGTAB_OICONST, /* D3DXRS_INT4 */ > + PRES_REGTAB_OCONST, /* D3DXRS_FLOAT4 */ > + PRES_REGTAB_NONE, /* D3DXRS_SAMPLER */ > +}; > + > +struct d3dx_pres_operand > +{ > + enum PRES_REG_TABLES table; > + /* offset is value index, not register index, e. g. > + offset for value c3.y is 17 (3 * 4 + 1) */ As I mentioned already, I would refer to "components" instead of "values". > + unsigned int offset; > +}; > + > +struct d3dx_pres_ins > +{ > + enum PRES_OPS op; > + /* first input argument is scalar, > + scalar component is propagated */ > + BOOL scalar_op; > + unsigned int ncomps; > + unsigned int ninp_args; Something like "component_count" and "operands_count" (or "input_count", or whatever) seems nicer. Similarly for the other counts. > + > +struct d3dx_param_eval > +{ > + enum param_eval_type peval_type; I feel like I might have already asked this, sorry if that's the case: do you really need this field? At least for what I can see at the moment you can do without since it's used only in d3dx_create_param_eval(), which is where you set the field, and in d3dx_param_eval_set_shader_constants(), where you don't really need it. > + D3DXPARAMETER_TYPE param_type; This one can also probably be avoided (e.g. by passing it down the call chain from the d3dx_parameter struct) although it's probably a bit more useful so I don't mind. > + > + struct d3dx_preshader pres; > + struct d3dx_const_tab shader_inputs; > +}; > + > +static HRESULT regstore_alloc_table(struct d3dx_regstore *rs, unsigned int table) > +{ > + unsigned int sz; > + > + sz = rs->table_sizes[table] * table_info[table].reg_value_cnt * table_info[table].value_size; > + if (sz) > + { > + rs->tables[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sz); > + rs->table_value_set[table] = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + sizeof(*rs->table_value_set[table]) * > + ((rs->table_sizes[table] + PRES_VS_BITS_PER_WORD - 1) / PRES_VS_BITS_PER_WORD)); > + if (!rs->tables[table] || !rs->table_value_set[table]) > + return E_OUTOFMEMORY; > + } > + return D3D_OK; > +} > + > +static void regstore_free_tables(struct d3dx_regstore *rs) > +{ > + unsigned int i; > + > + for (i = PRES_REGTAB_IMMED; i < PRES_REGTAB_MAX; i++) Maybe add a couple of enum PRES_REGTAB_FIRST and PRES_REGTAB_LAST and use them here? > + for (j = 0; j < n; j++) > + TRACE("0x%08X,", words[i + j]); Please use lowercase hexadecimals. > + if (ninp_args != pres_op_info[i].ninp_args) > + { > + FIXME("Actual input args %u, expected %u, instruction %s.\n", ninp_args, > + pres_op_info[i].ninp_args, pres_op_info[i].mnem); > + return NULL; > + } > + ins->ninp_args = ninp_args; It shouldn't be necessary to store the number of arguments in the instruction structure at the moment, although maybe there is some variable-arguments opcode? > + hr = E_FAIL; This seems unnecessary. > + > -- git am complains about that empty line at the end of the file.

2 2

Re: TestBot job 21484 results: winhttp/tests: Fix test failures.
by Hans Leidekker March 17, 2016

March 17, 2016

On Thu, 2016-03-17 at 04:21 -0500, Marvin wrote: > === w864 (32 bit winhttp) === > > winhttp: > winhttp.c:1030: Test failed: failed to send request 2148074273 > winhttp.c:1034: Test failed: failed to retrieve certificate context 12019 > winhttp.c:1039: Test failed: failed to retrieve key bitness 4317 > winhttp.c:1043: Test failed: failed to retrieve certificate info 12019 > winhttp.c:1056: Test failed: failed to receive response 12019 > winhttp.c:1060: Test failed: failed to query available data 12019 > winhttp.c:1061: Test failed: available_size = 0 > winhttp.c:1066: Test failed: failed unexpectedly 12019 > winhttp.c:1067: Test failed: request failed unexpectedly 3735928559 > winhttp.c:1078: Test failed: WinHttpReadData failed: 12019. Here's a clean run: https://testbot.winehq.org/JobDetails.pl?Key=21483 In this test run without my patch the same error occurs only on that VM, but in a different test: https://testbot.winehq.org/JobDetails.pl?Key=21482 I don't remember seeing this failure before, so it looks like an unrelated issue that was also introduced with the upgrade.

1 0

Re: winhttp/tests: Fix test failures.
by Marvin March 17, 2016

March 17, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21484 Your paranoid android. === w864 (32 bit winhttp) === winhttp.c:1030: Test failed: failed to send request 2148074273 winhttp.c:1034: Test failed: failed to retrieve certificate context 12019 winhttp.c:1039: Test failed: failed to retrieve key bitness 4317 winhttp.c:1043: Test failed: failed to retrieve certificate info 12019 winhttp.c:1056: Test failed: failed to receive response 12019 winhttp.c:1060: Test failed: failed to query available data 12019 winhttp.c:1061: Test failed: available_size = 0 winhttp.c:1066: Test failed: failed unexpectedly 12019 winhttp.c:1067: Test failed: request failed unexpectedly 3735928559 winhttp.c:1078: Test failed: WinHttpReadData failed: 12019.

1 0

Home Stretch for the New Wiki
by Kyle Auble March 16, 2016

March 16, 2016

Hi everybody, I just wanted to update you all on the state of the wiki. This email may seem long but it isn't too dense; feel free to skip the numbers, but for anyone that might appreciate some figures, the old wiki had... Total pages: 841 (Less) system pages: ~150 Actual pages by us: ~690 These consisted of... Redirects ~45 Homepages ~150 Categories ~25 Content pages: ~470 Of the content pages, we had... English pages: 384 Translations: ~86 Of the translations, between 20-26 were immediately disqualified (either as less than 50% actually translated or a translation of an English page we rejected). Alex H mentioned that most of the translations probably weren't worth migrating, but we thought we should leave that up to potential translators. For those remaining English pages... Already ported in some way: 153 Rejected as not worth porting: 169 Still unfinished: 62 Of these last 62, we actually have relatively clear plans for how to port ~25 of them, leaving just 35 or so as truly up for grabs. Furthermore, we've tried to leave a quick note on http://oldwiki.winehq.org/PageMigration for every page that still needs a decision. And of course, people are free to override our rejections if they really want to keep a page (we left an explanation for every rejection at the top of the relevant page) While some of those last 35 pages are really just a matter of policy (e.g. do we want a page for every command, even if it's a stub?), many of them have at least one or two technical notes that seem to supplement the API documentation. These are the ones where we would really appreciate input or decisions from developers, particularly whether anything is worth moving to the Developers' docs. Finally, as Rosanne and I made alternating edits, we discussed a few points that we think are worth keeping in mind for the future: 1. If a page is experimental / dev-oriented, try to make that clear from the name, text, and possibly a bold note (for example, a lot of users were apparently misinterpreting "WineOnWindows" as a stable feature they could use) 2. If you're using a distro/OS with its own wiki page, keeping an eye on its page for incorrect or outdated info would be great, even if only every few months. I updated several of them last year, testing what I could and researching docs on and outside WineHQ for changes, but it's no substitute for someone that knows first-hand what each one requires. 3. If you don't agree with a change, don't be afraid to revert it and start a discussion for the page, especially now that we have the talk pages. 4. The wiki is a natural place for things like to-do lists and transient notes, but if the same information can be easily written so that it's just as useful 5 years from now, aim for timelessness. If more of the wiki ages well, it should be easier to keep track of the things that may bit-rot. 5. Finally, if you want to start a new page, check to see if you could somehow add your info to existing pages first. Obviously we don't want the pages to get too long and it's totally subjective in the end, but it seems the more the pages spread out wildly, the more likely they are to wind up orphaned and abandoned. Have a good start to your spring everybody, Kyle

1 0

Re: [PATCH 1/2] d3drm: Change signature of d3drm_texture_create.
by Henri Verbeet March 16, 2016

March 16, 2016

The subject line is pretty vague. On 15 March 2016 at 22:19, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > @@ -193,8 +194,16 @@ static HRESULT WINAPI d3drm1_CreateTexture(IDirect3DRM *iface, > D3DRMIMAGE *image, IDirect3DRMTexture **texture) > { > FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, texture); > + struct d3drm_texture *object; > + HRESULT hr; You mix declarations and code here. The compiler should have warned about that. > + hr = d3drm_texture_create(&object); > + if (FAILED(hr)) > + return hr; We would generally write that as if (FAILED(hr = d3drm_texture_create(&object))) return hr; not a big deal though. > +IDirect3DRMTexture *IDirect3DRMTexture_from_impl(struct d3drm_texture *texture) > +{ > + return &texture->IDirect3DRMTexture_iface; > +} > + > +IDirect3DRMTexture2 *IDirect3DRMTexture2_from_impl(struct d3drm_texture *texture) > +{ > + return &texture->IDirect3DRMTexture2_iface; > +} > + > +IDirect3DRMTexture3 *IDirect3DRMTexture3_from_impl(struct d3drm_texture *texture) > +{ > + return &texture->IDirect3DRMTexture3_iface; > +} I don't think these are an improvement, I'd prefer them just written out. > -HRESULT Direct3DRMTexture_create(REFIID riid, IUnknown **out) > +HRESULT d3drm_texture_create(struct d3drm_texture **out) I think "texture" would be a more appropriate name than "out" here.

2 2

Re: dsound: Avoid implicit cast of interface pointer. [RFC]
by Henri Verbeet March 16, 2016

March 16, 2016

On 16 March 2016 at 05:46, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > To catch errors like http://source.winehq.org/patches/data/120308 easier in the future, > I would like to propose, that we replace CONTAINING_RECORD and similar macros with a > typesafe definition (on compilers where this is possible). The linux kernel source > contains an example how to do that, but there are multiple solutions available: > > #define container_of(ptr, type, member) ({ \ > const typeof( ((type *)0)->member ) *__mptr = (ptr); \ > (type *)( (char *)__mptr - offsetof(type,member) );}) > > One disadvantage is that we'll have to add explicit casts to a couple of places, like below. > Other dlls which would require explicit casts at a couple of places: > > amstream, d2d1, d3d11, d3d8, d3d9, ddraw, dwrite, msxml3, oleaut32, quartz, rpcrt4, vbscript > That implies you've tried the change. Did you find any issues other than the one in 120308? If not, I think this is rarely an issue in practice and not worth making legitimate cases uglier for.

2 1

Re: ddraw/tests: Fix function name in multiple ok() messages. (resend)
by Henri Verbeet March 16, 2016

March 16, 2016

On 7 March 2016 at 08:40, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > I assume this patch was missed somehow, resending. > No, the patch is just not very useful.

3 3

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture.
by Henri Verbeet March 16, 2016

March 16, 2016

On 15 March 2016 at 22:19, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > dlls/d3drm/Makefile.in | 2 +- > dlls/d3drm/d3drm.c | 35 +++++-- > dlls/d3drm/d3drm_private.h | 6 ++ > dlls/d3drm/tests/d3drm.c | 22 ++++- > dlls/d3drm/texture.c | 224 ++++++++++++++++++++++++++++++++++++++++++++- > 5 files changed, 273 insertions(+), 16 deletions(-) > I briefly looked at this, and it has some issues, some perhaps more obvious than others. But let's work on the first patch in the series first.

1 0

Re: [PATCH] shell32: Implement NIM_SETVERSION in Shell_NotifyIcon()
by Roman Pišl March 16, 2016

March 16, 2016

Hello, thank you for paying attention to this patch. Please, give me a hint how should I split the patch. Should I create three separate patches - shell32, explorer and winex11? I'm ready to do what is necessary. Best regards Roman Pišl On Tuesday 15 of March 2016 10:12:31 you wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Needs splitting". > > This means that the patch needs to be split, either because it > contains unrelated changes that should be their own separate patch, or > because it's too large for review. You need to find a way to resend > the changes in smaller chunks. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email.

2 1

[RFC] winex11: Don't put a default icon on modal dialogs.
by Alex Henrie March 15, 2016

March 15, 2016

Fixes https://bugs.winehq.org/show_bug.cgi?id=29336 when using the xfwm4 window manager. Could some other developers take a look at this patch? It passes the test program attached to the bug report, but I am not sure that it is the right way. --- dlls/winex11.drv/window.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 4789f98..63d256a 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -274,7 +274,7 @@ static unsigned long get_mwm_decorations( struct x11drv_win_data *data, if ((style & WS_CAPTION) == WS_CAPTION) { ret |= MWM_DECOR_TITLE | MWM_DECOR_BORDER; - if (style & WS_SYSMENU) ret |= MWM_DECOR_MENU; + if ((style & WS_SYSMENU) && data->icon_pixmap) ret |= MWM_DECOR_MENU; if (style & WS_MINIMIZEBOX) ret |= MWM_DECOR_MINIMIZE; if (style & WS_MAXIMIZEBOX) ret |= MWM_DECOR_MAXIMIZE; } @@ -603,7 +603,8 @@ static void fetch_icon_data( HWND hwnd, HICON icon_big, HICON icon_small ) { icon_big = (HICON)SendMessageW( hwnd, WM_GETICON, ICON_BIG, 0 ); if (!icon_big) icon_big = (HICON)GetClassLongPtrW( hwnd, GCLP_HICON ); - if (!icon_big) icon_big = LoadIconW( 0, (LPWSTR)IDI_WINLOGO ); + if (!icon_big && !(GetWindowLongW( hwnd, GWL_EXSTYLE ) & WS_EX_DLGMODALFRAME)) + icon_big = LoadIconW( 0, (LPWSTR)IDI_WINLOGO ); } if (!icon_small) { @@ -611,7 +612,7 @@ static void fetch_icon_data( HWND hwnd, HICON icon_big, HICON icon_small ) if (!icon_small) icon_small = (HICON)GetClassLongPtrW( hwnd, GCLP_HICONSM ); } - if (!GetIconInfo(icon_big, &ii)) return; + if (!GetIconInfo(icon_small, &ii) && !GetIconInfo(icon_big, &ii)) return; hDC = CreateCompatibleDC(0); bits = get_bitmap_argb( hDC, ii.hbmColor, ii.hbmMask, &size ); -- 2.7.3

1 0

Re: [v6] shell32: fix two bugs in IQueryAssocations
by Theodore Dubois March 15, 2016

March 15, 2016

OK. I'll resend with the changes suggested. ~Theodore On Mar 15, 2016, at 07:03 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: Theodore Dubois <tblodt(a)icloud.com> writes: The reason I need the macro is: If I wrote ok(getstring_test(whatever)), first the ok macro would call winetest_set_location with the current line number, and then it would call getstring_test. The ok macros in getstring_test would call winetest_set_location and overwrite the location of the actual test. Then if getstring_test returns with a failure, the error message has the wrong line number. The only way to fix this is to call getstring_test on one line and call ok on the next line. There's no reason to call ok on the getstring_test result, since getstring_test would have already reported the error. If you want to know which caller triggered it, you can pass a line number or some string description to getstring_test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v6] shell32: fix two bugs in IQueryAssocations
by Alexandre Julliard March 15, 2016

March 15, 2016

Theodore Dubois <tblodt(a)icloud.com> writes: > + > + /* This macro is necessary because of what the ok macro expands to. Failures would report the wrong line number. */ > +#define TEST_GET_STRING(a,p,s,es) \ > + getstring_test_result = getstring_test(a,p,s,es);\ > + ok(getstring_test_result, "\n"); It would be better to avoid the macro and write the tests explicitly, with meaningful error messages. Also, any chance to split the patch? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture.
by Aaryaman Vasishta March 15, 2016

March 15, 2016

I forgot to remove some trailing whitespaces - sorry about that! I will send another patch without them if needed.

1 1

Re: [PATCH 2/2] d3drm: Partially Implement IDirect3DRM*::LoadTexture.
by Marvin March 15, 2016

March 15, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21458 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [v3 resend 3/6] d3dx9: implement fxlc constants (expressions) in effect.
by Matteo Bruni March 15, 2016

March 15, 2016

2016-03-10 19:50 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > +static float regstore_get_float(struct d3dx_regstore *rs, unsigned int table, unsigned int offset) > +{ > + BYTE *p; > + > + p = (BYTE *)rs->tables[table] + table_info[table].value_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : return *(float *)p; > + case PRES_VT_DOUBLE: return *(double *)p; > + case PRES_VT_INT : return *(int *)p; > + case PRES_VT_BOOL : return *(BOOL *)p ? 1.0f : -0.0f; I guess that -0.0f comes from some test? > + /* no EOL in WARN to dump arg in the same line */ > + WARN("Using uninitialized input "); > + dump_arg(rs, opr, comp); > + TRACE(".\n"); > + dump_ins(rs, ins); You can probably do without the comment, it's pretty clear anyway. > +#define ARGS_ARRAY_SIZE 8 > +static HRESULT execute_preshader(struct d3dx_preshader *pres) > +{ > + unsigned int i, j, k; > + float args[ARGS_ARRAY_SIZE]; > + float res; > + > + for (i = 0; i < pres->nins; i++) > + { > + struct d3dx_pres_ins *ins; > + struct op_info *oi; > + > + ins = &pres->ins[i]; > + oi = &pres_op_info[ins->op]; > + if (oi->func_all_comps) > + { > + if (ins->ninp_args * ins->ncomps > ARGS_ARRAY_SIZE) > + { > + FIXME("Too much arguments (%u) for one instruction.\n", ins->ninp_args * ins->ncomps); That should be "Too many". > +HRESULT d3dx_param_eval_set_shader_constants(struct IDirect3DDevice9 *device, struct d3dx_param_eval *peval) This function is unused in this patch. Please move it to the first patch requiring it (I think that's patch 6/6). BTW, splitting patch 6/6 would be nice although I don't have any suggestions on how to do that in a sensible manner... > +HRESULT d3dx_param_eval_get_shader_parameters(struct d3dx_param_eval *peval, struct d3dx_parameter ***param, > + unsigned int *nparam, D3DXCONSTANT_DESC **cdesc) > +{ > + *nparam = peval->shader_inputs.ninputs; > + *param = peval->shader_inputs.inputs_param; > + *cdesc = peval->shader_inputs.inputs; > + return D3D_OK; > +} You don't use this function in this patch either. Also it doesn't seem useful, it isn't an improvement to just assigning those three pointers directly in the caller IMO.

2 2

Re: [v3 1/6] d3dx9: add test for preshader in effect.
by Matteo Bruni March 15, 2016

March 15, 2016

2016-03-10 15:23 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- Looks much better, thanks. I still have a few comments though. > + for (i = 0; i < 256; i++) > + { > + hr = IDirect3DDevice9_SetVertexShaderConstantF(device, i, > + (const float *)&fvect_empty, 1); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + } > + for (i = 0; i < TEST_EFFECT_PRES_NFLOATP; i++) > + { > + hr = IDirect3DDevice9_SetPixelShaderConstantF(device, i, > + (const float *)&fvect_empty, 1); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + } I know it was me who suggested to clear all the 256 float shader constants but it looks a bit weird if the same doesn't happen for the other constant types. It's also not very useful if those additional constants aren't checked later on. I would change the initialization of the other constant types in the same way (maybe with a define or something instead of the plain number?) and then check that those are not modified by BeginPass(). > + bval = FALSE; > + for (i = 0; i < TEST_EFFECT_PRES_NBOOL; i++) > + { > + hr = IDirect3DDevice9_SetPixelShaderConstantB(device, i, &bval, 1); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + } > + > + hr = effect->lpVtbl->Begin(effect, &npasses, 0); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + > + par = effect->lpVtbl->GetParameterByName(effect, NULL, "g_Pos2"); > + ok(par != NULL, "GetParameterByName failed.\n"); > + > + hr = effect->lpVtbl->SetVector(effect, par, &fvect1); > + ok(hr == D3D_OK, "SetFloatArray failed, hr %#x.\n", hr); This message is still wrong. > + > + hr = effect->lpVtbl->BeginPass(effect, 0); > + todo_wine ok(hr == D3D_OK, "Got result %#x.\n", hr); > + > + hr = IDirect3DDevice9_GetVertexShaderConstantF(device, 0, (float *)fdata, TEST_EFFECT_PRES_NFLOATV); We usually avoid the cast in these cases with something like "&fdata->x". > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + todo_wine ok(!memcmp(fdata, test_effect_preshader_fconstsv, sizeof(test_effect_preshader_fconstsv)), > + "Vertex shader float constants do not match.\n"); > + hr = IDirect3DDevice9_GetPixelShaderConstantF(device, 0, (float *)fdata, TEST_EFFECT_PRES_NFLOATP); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + todo_wine ok(!memcmp(fdata, test_effect_preshader_fconstsp, sizeof(test_effect_preshader_fconstsp)), > + "Pixel shader float constants do not match.\n"); > + > + hr = IDirect3DDevice9_GetPixelShaderConstantB(device, 0, bdata, TEST_EFFECT_PRES_NBOOL); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + for (i = 0; i < TEST_EFFECT_PRES_NBOOL; i++) > + todo_wine_if(!bdata[i] != !test_effect_preshader_bconsts[i]) > + ok(!bdata[i] == !test_effect_preshader_bconsts[i], > + "Pixel shader boolean constants do not match.\n"); > + > + for (i = 0; i < TEST_EFFECT_PRES_NOPTESTS; i++) > + { > + unsigned int *v; > + > + hr = IDirect3DDevice9_GetLight(device, i % 8, &light); > + v = i < 8 ? (unsigned int *)&light.Diffuse : (unsigned int *)&light.Ambient; > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + for (j = 0; j < 4; j++) > + todo_wine_if(test_effect_preshader_op_results[i].todo[j] & 1) > + ok(v[j] == test_effect_preshader_op_results[i].result[j] || > + ((test_effect_preshader_op_results[i].todo[j] & 2) && > + broken(v[j] != test_effect_preshader_op_results[i].result[j])), > + "Operation %s, component %u, expected %#x, got %#x.\n", > + test_effect_preshader_op_results[i].comment, j, > + test_effect_preshader_op_results[i].result[j], v[j]); The indentation is pretty weird here. Even if you keep the ok on the same column of the todo_wine_if (to make its removal a few patches later nicer) the continuations of the ok condition should be indented, matching the other continuation lines. FWIW in newer d3d code we usually put the operators at the start of the next line (instead of at the end of the previous line) in line continuations. Also we prefer preincrement to postincrement of typical 'for' induction variables. > + ok(!!vshader, "Got NULL vshader.\n"); This double negation is unnecessary. > + > + hr = IDirect3DVertexShader9_GetFunction(vshader, NULL, &byte_code_size); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + byte_code = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, byte_code_size); > + hr = IDirect3DVertexShader9_GetFunction(vshader, byte_code, &byte_code_size); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + ok(byte_code_size > 1, "Got unexpected byte code size %u.\n", byte_code_size); > + todo_wine ok(!memcmp(byte_code, > + &test_effect_preshader_effect_blob[TEST_EFFECT_PRESHADER_VSHADER_POS + > + 1 * TEST_EFFECT_PRESHADER_VSHADER_LEN], byte_code_size), > + "Incorrect shader selected.\n"); > + HeapFree(GetProcessHeap(), 0, byte_code); > + IDirect3DVertexShader9_Release(vshader); > + > + hr = IDirect3DDevice9_SetVertexShader(device, NULL); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + > + hr = effect->lpVtbl->SetVector(effect, par, &fvect1); > + ok(hr == D3D_OK, "SetFloatArray failed, hr %#x.\n", hr); > + hr = effect->lpVtbl->CommitChanges(effect); > + todo_wine ok(hr == D3D_OK, "Got result %#x.\n", hr); > + hr = IDirect3DDevice9_GetVertexShader(device, &vshader); > + ok(hr == D3D_OK, "Got result %#x.\n", hr); > + ok(!vshader, "Incorrect shader selected.\n"); > + if (vshader) > + IDirect3DVertexShader9_Release(vshader); I think you can remove this release too.

2 2

Re: [PATCH v2 08/12] wined3d: Implement stencil clear in wined3d_device_clear_rendertarget_view().
by Henri Verbeet March 15, 2016

March 15, 2016

On 15 March 2016 at 10:52, Józef Kucia <jkucia(a)codeweavers.com> wrote: > static HRESULT cpu_blit_depth_fill(struct wined3d_device *device, > - struct wined3d_rendertarget_view *view, const RECT *rect, float depth) > + struct wined3d_rendertarget_view *view, const RECT *rect, DWORD clear_flags, Minor typo.

1 0

Re: [PATCH 2/3] winex11.drv: Fix handling of CF_DIBV5 clipboard data.
by Alexandre Julliard March 15, 2016

March 15, 2016

Charles Davis <cdavis5x(a)gmail.com> writes: > @@ -1149,9 +1154,7 @@ static BOOL X11DRV_CLIPBOARD_RenderSynthesizedBitmap(Display *display) > lpbmih = GlobalLock(lpSource->hData); > if (lpbmih) > { > - offset = sizeof(BITMAPINFOHEADER) > - + ((lpbmih->biBitCount <= 8) ? (sizeof(RGBQUAD) * > - (1 << lpbmih->biBitCount)) : 0); > + offset = lpbmih->biSize - lpbmih->biSizeImage; This doesn't look right. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dinput: Support IUnknown in the IDirectInputEffect COM object. (2nd try)
by Huw Davies March 15, 2016

March 15, 2016

On Tue, Mar 15, 2016 at 11:43:58AM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > v2: Use IsEqualIID consistently. Thanks Huw! > > And of course again not even compile tested as I don't have a Mac. Yes, > I need to set me up with a cross compile for that. > gcc -m32 -c -o joystick_osx.o joystick_osx.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes \ -Wwrite-strings -Wpointer-arith -gdwarf-2 -fno-omit-frame-pointer -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 joystick_osx.c: In function ‘effect_QueryInterface’: joystick_osx.c:1477: error: ‘riid’ undeclared (first use in this function) joystick_osx.c:1477: error: (Each undeclared identifier is reported only once joystick_osx.c:1477: error: for each function it appears in.) make: *** [joystick_osx.o] Error 1 > > dlls/dinput/joystick_osx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 6a8926d..19ca070 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -1474,7 +1474,7 @@ static HRESULT WINAPI effect_QueryInterface(IDirectInputEffect *iface, > > TRACE("%p %s %p\n", This, debugstr_guid(guid), out); > > - if(IsEqualIID(guid, &IID_IDirectInputEffect)){ > + if(IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(guid, &IID_IDirectInputEffect)){ > *out = iface; > IDirectInputEffect_AddRef(iface); > return S_OK; > -- > 2.4.3 > >

1 0

Re: dinput: Support IUnknown in the IDirectInputEffect COM object.
by Huw Davies March 15, 2016

March 15, 2016

On Tue, Mar 15, 2016 at 10:37:16AM +0100, Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dinput/joystick_osx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 6a8926d..19ca070 100644 > --- a/dlls/dinput/joystick_osx.c > +++ b/dlls/dinput/joystick_osx.c > @@ -1474,7 +1474,7 @@ static HRESULT WINAPI effect_QueryInterface(IDirectInputEffect *iface, > > TRACE("%p %s %p\n", This, debugstr_guid(guid), out); > > - if(IsEqualIID(guid, &IID_IDirectInputEffect)){ > + if(IsEqualGUID(riid, &IID_IUnknown) || IsEqualIID(guid, &IID_IDirectInputEffect)){ It looks a bit strange to mix IsEqualGUID and IsEqualIID. Huw.

2 3

GSoC Idea: Tools - Winetest Scripting Interface
by Zhenbo Li March 15, 2016

March 15, 2016

Hello, I'm Zhenbo Li. I participated in GSoC twice. This year, I want to work on "Tools - Winetest Scripting Interface". After "make test", checking the output in stdout manually is horrible. As ok() macro is used quite widely, my patches should cause no surprise. That is to say, other developers need to read neither my patches nor the changelog to continue their jobs, although ok() macro and other tools for test have been changed. I think there will be two steps for the goal: 1. ok() macro ===================== int winetest_vok( int condition, const char *msg, __winetest_va_list args ) { tls_data* data=get_tls_data(); if (data->todo_level){...} else { if (!condition) { printf( "%s:%d: Test failed: ", data->current_file, data->current_line ); vprintf(msg, args); InterlockedIncrement(&failures); return 0; } else{.....} } } Instead of printing all the data to stderr, I think we can write a wrapper static void test_print(const char *s) { if(want_print_to_file) fprintf(file_handle, s); printf(s); } It needs some work to make sure that the file_handle is opened/closed successfully. With that, we can record the failed tests to a file, and developers don't need to find them in stdout anymore. 2. compare the results ======================= On the idea page, it says that any scripting language is acceptable. I prefer Python3. To make the code simple, I think editing runtest script is the best solution. Currently, our logic in Makefile is htmllocation.ok: ../../../tools/runtest $(RUNTESTFLAGS) -T ../../.. -M mshtml.dll -p mshtml_test.exe.so htmllocation && touch $@ And in runtest, we have exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$@" I don't want to touch Makefile. Instead, I'm going to add some options for runtest. For example, one can use ../../../tools/runtest $(RUNTESTFLAGS) -new_option expected_errors_generated before -T ../../.. -M mshtml.dll -p mshtml_test.exe.so htmllocation And in runtest script, we can expected_errors_generated and new_errors_got, then tell that whether the test result has been changed. It should be easy for developers to write a script for git bisect or other circumstance. Problems ========= This approach seems to be quite simple, and there are some conditions can't be handled. For example void test_foo(sturct Data *d){ ret = foo(d); ok(ret, "foo(%s) is %d\n", data_to_str(d), ret); } struct Data list[]={a,b,c,d,e}; void test(){ for(i in list) test_foo(i); } I think we should not do too much "smart deduce" here, and don't hide what's happening to other developers. Maybe we can add another option for runtest script: --scrict=false This is my humble idea for Wine's GSoC 2016. If this project goes well, working on wine test suit will be much more satisfying(although still boring). I appreciate for your comment. With you a happy weekend. -- Have a nice day! Zhenbo Li

6 15

Re: winemac: Call the EnumDisplayMonitors callback using a wrapper.
by Henri Verbeet March 15, 2016

March 15, 2016

On 15 March 2016 at 05:50, Ken Thomases <ken(a)codeweavers.com> wrote: > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > For <https://bugs.winehq.org/show_bug.cgi?id=40297>. > > dlls/winemac.drv/display.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > Is this really specific to winemac, or would it be more appropriate to add the wrapper in user32?

1 0

Re: winemac: Call the EnumDisplayMonitors callback using a wrapper.
by Ken Thomases March 15, 2016

March 15, 2016

On Mar 14, 2016, at 11:50 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > > Signed-off-by: Ken Thomases <ken(a)codeweavers.com> > --- > For <https://bugs.winehq.org/show_bug.cgi?id=40297>. > > dlls/winemac.drv/display.c | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) Dmitry pointed out that this version misaligns the stack, so ignore it. I'll submit another try tomorrow. -Ken

1 0

Re: [PATCH] crypt32/tests: Accept Windows 10 results.
by Alexandre Julliard March 15, 2016

March 15, 2016

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -336,11 +336,13 @@ static void testStringToBinaryA(void) > /* Bad strings */ > for (i = 0; i < sizeof(badStrings) / sizeof(badStrings[0]); i++) > { > - bufLen = 0; > + bufLen = 0xdeadbeef; > + SetLastError(0xdeadbeef); > + /* This succeeds on Windows 10 with our CRYPT_STRING_BASE64 test data */ > ret = pCryptStringToBinaryA(badStrings[i].str, 0, badStrings[i].format, > NULL, &bufLen, NULL, NULL); > - ok(!ret && GetLastError() == ERROR_INVALID_DATA, > - "Expected ERROR_INVALID_DATA, got ret=%d le=%u\n", ret, GetLastError()); > + ok((!ret && GetLastError() == ERROR_INVALID_DATA) || broken(ret), > + "%d: Expected FALSE with ERROR_INVALID_DATA, got ret=%d le=%u len=%d\n", i, ret, GetLastError(), bufLen); I'm not convinced this should be considered broken. It would be worth testing some other truly bad strings, and the CRYPT_STRING_STRICT flag also. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msrle32: Use the correct number of colors when biClrUsed = 0 (try 2)
by Alexandre Julliard March 15, 2016

March 15, 2016

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -1647,27 +1655,33 @@ static LRESULT DecompressBegin(CodecInfo *pi, LPCBITMAPINFOHEADER lpbiIn, > > if (lpbiIn->biCompression != BI_RGB) > { > + int colors; > + > + if (lpbiIn->biClrUsed == 0) > + colors = 1 << lpbiIn->biBitCount; > + else > + colors = lpbiIn->biClrUsed; I don't think you want to do that for biBitCount > 8. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] winex11: Don't create a temporary context each time X11DRV_wglBindTexImageARB is called.
by Matteo Bruni March 14, 2016

March 14, 2016

2016-03-12 14:57 GMT+01:00 Miklós Máté <mtmkls(a)gmail.com>: > Theoretically wglBindTexImageARB is supposed to be a fast > render-to-texture method, and creating a new context is anything but fast. > > This fixes horrible performance in Star Wars > Knights of the Old Republic when post-process effects are enabled. > > v2: fix context caching, fix destructor, fix comments > v3: better handling of context delete > > Signed-off-by: Miklós Máté <mtmkls(a)gmail.com> Thank you for following up after the review comments. Unfortunately I think there is one more (and hopefully last) bit which still needs addressing: > @@ -2301,6 +2314,7 @@ static struct wgl_pbuffer *X11DRV_wglCreatePbufferARB( HDC hdc, int iPixelFormat > SetLastError(ERROR_NO_SYSTEM_RESOURCES); > goto create_failed; /* unexpected error */ > } > + list_add_head( &pbuffer_list, &object->entry ); > TRACE("->(%p)\n", object); > return object; This needs to be done inside the critical section, so please put EnterCriticalSection() + LeaveCriticalSection() around it. FTR the wglCreateContext and wglCreateContextAttribsARB implementation functions indirectly acquire and release the critical section via get_gl_drawable() / release_gl_drawable(). It looks good to me otherwise.

1 0

Re: [v2 6/6] d3dx9: imlement setting named shader constants in effect.
by Matteo Bruni March 14, 2016

March 14, 2016

2016-03-10 14:51 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > + unsigned i, j; We usually avoid the bare "unsigned". > + for (i = 0; i < parameters_count; i++) > + if (params[i] && params[i]->class == D3DXPC_OBJECT && params[i]->type == D3DXPT_SAMPLER) > + { > + struct d3dx_sampler *sampler; > + > + sampler = (struct d3dx_sampler *)params[i]->data; > + TRACE("sampler %s, register index %u, state count %u.\n", params[i]->name, > + cdesc[i].RegisterIndex, sampler->state_count); > + for (j = 0; j < sampler->state_count; j++) > + { > + hr = d3dx9_apply_state(effect, pass, &sampler->states[j], > + cdesc[i].RegisterIndex + (vs ? D3DVERTEXTEXTURESAMPLER0 : 0)); > + if (FAILED(hr)) > + ret = hr; > + } > + } It's better to add brackets to the for, for greater clarity.

1 0

Re: [2/2] user32: Skip menu loop for empty popup menus.
by Marvin March 14, 2016

March 14, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21431 Your paranoid android. === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

1 0

Re: [PATCH 2/2] d3d11/tests: Port swapchain_flip to d3d11.
by Henri Verbeet March 14, 2016

March 14, 2016

On 13 March 2016 at 19:08, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > --- > > I am not using create_test_context in this test because it would introduce > asymetry in how back buffer 0 is created that would make the test more > difficult to read in my opinion. It would probably be worth it, mostly because you also get to use draw_quad() that way. We could also consider making the "backbuffer" and "backbuffer_rtv" members arrays. For the moment it's probably more important that it matches the d3d10core test though. > > Signed-off-by: Stefan Dösinger <stefandoesinger(a)gmx.at> If you put the Signed-off-by here, it won't be put in the commit message.

2 2

Re: [PATCH 1/2] windowscodecs: Stub IWICMetadataQueryReader
by Vincent Povirk March 14, 2016

March 14, 2016

You're referencing the block reader in MetadataQueryReader_CreateInstance but not releasing it in mqr_Release.

1 0

Re: [PATCH 1/8] wined3d: Introduce wined3d_rendertarget_view_clear().
by Henri Verbeet March 14, 2016

March 14, 2016

On 14 March 2016 at 00:03, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/wined3d/device.c | 18 +----------------- > dlls/wined3d/surface.c | 22 ++-------------------- > dlls/wined3d/view.c | 40 ++++++++++++++++++++++++++++++++++++++++ > dlls/wined3d/wined3d_private.h | 3 +++ > 4 files changed, 46 insertions(+), 37 deletions(-) > I'm not sure how I feel about this change. There doesn't seem to be a particularly compelling reason to change this, although I suppose there's no strong reason not to either. I guess it depends on where you're going with this.

2 2

Re: [PATCH 2/2] ole32: Fix refcounting of IObjContext per-thread instance
by Huw Davies March 14, 2016

March 14, 2016

On Mon, Mar 14, 2016 at 08:10:00AM +0300, Nikolay Sivov wrote: > Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> > --- > dlls/ole32/compobj.c | 57 +++++++++++++++++++--------------------------- > dlls/ole32/tests/compobj.c | 46 ++++++++++++++++++++++--------------- > 2 files changed, 51 insertions(+), 52 deletions(-) > > diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c > index b095aeb..1081f98 100644 > --- a/dlls/ole32/compobj.c > +++ b/dlls/ole32/compobj.c > @@ -4683,10 +4683,13 @@ static ULONG Context_AddRef(Context *This) > > static ULONG Context_Release(Context *This) > { > - ULONG refs = InterlockedDecrement(&This->refs); > - if (!refs) > + if (!This->refs) > + { Since this is non-standard it needs a comment. Probably just referring to the constructor below. > HeapFree(GetProcessHeap(), 0, This); > - return refs; > + return 0; > + } > + > + return InterlockedDecrement(&This->refs); > } > > static HRESULT WINAPI Context_CTI_QueryInterface(IComThreadingInfo *iface, REFIID riid, LPVOID *ppv) > @@ -4924,39 +4927,19 @@ static const IObjContextVtbl Context_Object_Vtbl = > */ > HRESULT WINAPI CoGetObjectContext(REFIID riid, void **ppv) > { > - APARTMENT *apt = COM_CurrentApt(); > - Context *context; > + IObjContext *context; > HRESULT hr; > > TRACE("(%s, %p)\n", debugstr_guid(riid), ppv); > > *ppv = NULL; > - if (!apt) > - { > - if (!(apt = apartment_find_multi_threaded())) > - { > - ERR("apartment not initialised\n"); > - return CO_E_NOTINITIALIZED; > - } > - apartment_release(apt); > - } > - > - context = HeapAlloc(GetProcessHeap(), 0, sizeof(*context)); > - if (!context) > - return E_OUTOFMEMORY; > - > - context->IComThreadingInfo_iface.lpVtbl = &Context_Threading_Vtbl; > - context->IContextCallback_iface.lpVtbl = &Context_Callback_Vtbl; > - context->IObjContext_iface.lpVtbl = &Context_Object_Vtbl; > - context->refs = 1; > - > - hr = IComThreadingInfo_QueryInterface(&context->IComThreadingInfo_iface, riid, ppv); > - IComThreadingInfo_Release(&context->IComThreadingInfo_iface); > + hr = CoGetContextToken((ULONG_PTR*)&context); > + if (FAILED(hr)) > + return hr; > > - return hr; > + return IObjContext_QueryInterface(context, riid, ppv); > } > > - > /*********************************************************************** > * CoGetContextToken [OLE32.@] > */ > @@ -4985,16 +4968,22 @@ HRESULT WINAPI CoGetContextToken( ULONG_PTR *token ) > > if (!info->context_token) > { > - HRESULT hr; > - IObjContext *ctx; > + Context *context; > + > + context = HeapAlloc(GetProcessHeap(), 0, sizeof(*context)); > + if (!context) > + return E_OUTOFMEMORY; > + > + context->IComThreadingInfo_iface.lpVtbl = &Context_Threading_Vtbl; > + context->IContextCallback_iface.lpVtbl = &Context_Callback_Vtbl; > + context->IObjContext_iface.lpVtbl = &Context_Object_Vtbl; Add a comment here stating that context_token does not take a ref. > + context->refs = 0; > > - hr = CoGetObjectContext(&IID_IObjContext, (void **)&ctx); > - if (FAILED(hr)) return hr; > - info->context_token = ctx; > + info->context_token = &context->IObjContext_iface; > } > > *token = (ULONG_PTR)info->context_token; > - TRACE("apt->context_token=%p\n", info->context_token); > + TRACE("context_token=%p\n", info->context_token); > > return S_OK; > } I'm wondering whether this patch could be split since it's doing rather more than fixing a ref counting issue. Could you move the constructor to CoGetContextToken first and then fix the refs, or would that mess up the tests? Huw.

2 2

Re: [PATCH 6/8] d3d10core/tests: Add test for ClearDepthStencilView().
by Henri Verbeet March 14, 2016

March 14, 2016

On 14 March 2016 at 00:03, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static float get_readback_float(struct texture_readback *rb, unsigned int x, unsigned int y) > +{ > + return rb->texture > + ? ((float *)rb->mapped_texture.pData)[rb->mapped_texture.RowPitch * y / sizeof(float) + x] : NAN; > +} Can the texture ever legitimately be NULL?

2 1

Re: [PATCH 2/8] wined3d: Implement depth clear in wined3d_device_clear_rendertarget_view().
by Henri Verbeet March 14, 2016

March 14, 2016

On 14 March 2016 at 00:03, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -4100,7 +4110,13 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi > rect = &r; > } > > - return wined3d_rendertarget_view_clear(view, rect, WINED3DCLEAR_TARGET, color, 0.0f, 0); > + if (!(flags & WINED3DCLEAR_TARGET) == !(flags & (WINED3DCLEAR_ZBUFFER | WINED3DCLEAR_STENCIL))) > + { > + ERR("Color and depth/stencil clears are mutually exclusive.\n"); > + return WINED3DERR_INVALIDCALL; > + } You may not need this. The documentation suggests depth/stencil views can only be created on depth formats, and I'd be inclined to believe it. IIRC it doesn't say much about creating rendertarget views on depth/stencil formats, but I wouldn't be all that surprised if that's not allowed either. In that case you'd just need to check the flags against the format capabilities. > +const char *debug_color(const struct wined3d_color *color) > +{ > + if (!color) > + return "(null)"; > + return wine_dbg_sprintf("{%.8e, %.8e, %.8e, %.8e}", > + color->r, color->g, color->b, color->a); > +} This is fine, but might as well be a separate change. There are a couple of other places where we trace wined3d_color values as well, the easiest way to find them is probably to look for the format string.

2 1

Re: d3drm: Use debugstr_a to print a string that can be NULL.
by Henri Verbeet March 14, 2016

March 14, 2016

On 14 March 2016 at 10:36, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > - TRACE("Mesh name is '%s'\n", This->name ? This->name : ""); > + TRACE("Mesh name is '%s'\n", debugstr_a(This->name)); You should remove the quotes, since debugstr_a() also adds quotes. Note that just being external data is enough reason to use debugstr_a(), it doesn't matter much if it can be NULL or not in that regard.

2 1

Re: [PATCH] Read operation's type explicitly as QStringList
by Nikolay Sivov March 14, 2016

March 14, 2016

On 13.03.2016 19:12, Łukasz Wojniłowicz wrote: > Fixes bug #360129 > --- > kmymoney/plugins/csvimport/investprocessing.cpp | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > Hi, Łukasz. Just pointing out so this patch is not lost by accident - wrong mailing list. You aimed for https://mail.kde.org/pipermail/kmymoney-devel/ probably or some list next to it.

1 0

Re: [PATCH] kernel32/tests: Skip ResolveDelayLoadedAPI tests on Win10+
by Nikolay Sivov March 13, 2016

March 13, 2016

On 13.03.2016 19:42, André Hentschel wrote: > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > dlls/kernel32/tests/loader.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/dlls/kernel32/tests/loader.c b/dlls/kernel32/tests/loader.c > index c35cf25..30cc2e4 100644 > --- a/dlls/kernel32/tests/loader.c > +++ b/dlls/kernel32/tests/loader.c > @@ -2728,6 +2728,11 @@ static void test_ResolveDelayLoadedAPI(void) > > cb_count = 0; > ret = pResolveDelayLoadedAPI(hlib, delaydir, failuredllhook, NULL, &itda[i], 0); > + if (!ret && td[i].succeeds) > + { > + win_skip("Skipping broken ResolveDelayLoadedAPI implementation\n"); > + goto cleanup; > + } > if (td[i].succeeds) > { > ok(ret != NULL, "Test %u: ResolveDelayLoadedAPI failed\n", i); > @@ -2745,6 +2750,7 @@ static void test_ResolveDelayLoadedAPI(void) > delaydir++; > } > > +cleanup: > FreeLibrary(hlib); > trace("deleting %s\n", dll_name); > DeleteFileA(dll_name); > So what's exactly wrong with it on Win10? Silencing failures does not seem useful if actual issue was not investigated.

1 0

Re: [PATCH] d3d9/tests Accept Windows 10 result
by Stefan Dösinger March 13, 2016

March 13, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-03-13 um 17:04 schrieb Detlef Riekenberg: > Windows 10 is returning D3D_OK, so the recent behavior seems to be > better as before. That's why I used D3D_OK as expected result, > marked the old S_PRESENT_MODE_CHANGED as broken and removed the > wine_todo I think the new behavior is more broken than the old one. "It needs a present call to pick up a mode change" - If my memory serves me right the issue was that CheckDeviceState would incorrectly return D3D_OK instead of S_PRESENT_MODE_CHANGED when the mode was changed. Now it's always wrong, even with a preceding Present call. Of course in light of the Windows 10 results we may have to redefine "wrong". -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJW5aMEAAoJEN0/YqbEcdMweH8P/2OQymbb9EhNw4YqaXw0lcVN ozmH/7MYrxM4V1zzk+1+7XBR7nlIwDFRBGYw6LaZCiCmJYDfb1CTpYbSoVokHzQo UW2aCJCVRNWnZ5L72aZ12AoFq5sIuUX0FCAWhnpT4rNU7/bv35T/Zz0h439vn4RN +USZIHayRpmsJbhSbSn9VejSyin7GhBZ3VD7Qcd+7MqBxqOATX5p62cgFg+KUPkN Wi1HelDEHNsybHE4U60zYcZ2uxZxh7alfP6FjOtffOOxYilmG5eGEpGQX/dRIIv7 wxAfkjy/lgZqV9T4kEVyVO4tiwf9Vj1ccijkBNOttP7cFNGA4IM5W/urSWxL0uPd QEzP3QUv03NPN9Mtgq7K+DOyZmMUeedU+dHcCTwPJj/GTuXGxs2KHpLURXiAWXjD they7Iog2TEBFWuDskx58RHJyevbzKfWqfeM6/nJew5ter19W62Y1Sn01hfI0Ym0 aaTdzj+/tnf5pdc5Mgu6AtSRbApziwtYdfn4xGyEImw7J4pu7BnSmzHk8FMowtHm Dy2+GKE0FlmpAExwo0FAY2z6fCvMtIQMYzinU95LYaWvIggjsUo3wII3PxLtjKY0 8gXqBk+6WUUeDrAKqRqdkMCdzLBsVrlmxlj37KhfmPNCvG9gAlnMRegNW9eZkE2F aqvHGFSUrJzmk9CPtwtt =+25F -----END PGP SIGNATURE-----

1 0

Re: [PATCH] kernel32/tests: Skip ResolveDelayLoadedAPI tests on Win10+
by Marvin March 13, 2016

March 13, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21399 Your paranoid android. === w864 (32 bit loader) === loader.c:1820: Test failed: expected STILL_ACTIVE, got 195 loader.c:1855: Test failed: expected STILL_ACTIVE, got 195 === w1064 (32 bit loader) === loader.c:1820: Test failed: expected STILL_ACTIVE, got 195 loader.c:1855: Test failed: expected STILL_ACTIVE, got 195 === w864 (64 bit loader) === loader.c:1820: Test failed: expected STILL_ACTIVE, got 195 loader.c:1855: Test failed: expected STILL_ACTIVE, got 195 === w1064 (64 bit loader) === loader.c:1820: Test failed: expected STILL_ACTIVE, got 195 loader.c:1855: Test failed: expected STILL_ACTIVE, got 195

1 0

Builtin DLL View
by Keno Fischer March 12, 2016

March 12, 2016

Hello everyone, out of curiosity, I was tracking down why a piece of code in julia [1] threw an assertion when running under wine, but not on windows proper. The problem in this piece of code turned out to be that VirtualQuery is claiming a region of memory is free, when it is actually occupied by part of one of the builtin dlls. If I understand correctly what's happening here is that builtin dlls are regular shared objects on the host system, and get loaded as such, but contain the respective windows dll inside of them (modulo header, which gets created in `map_dll` by mapping over a couple of pages in the middle). Later, after going through the load callback, `virtual_create_builtin_view` records the appropriate information in the view map. However, it only records what it knows about the inner dll, not the shared object wrapper around it. I was thinking of preparing a patch, but I am not sure how to go about it. Options I could see: - Expand the mapping in `virtual_create_builtin_view`. This seems most straightforward, but I don't quite know what the proper way to pass this information through to here is. Or maybe we can parse the wrapper's header right in the function, if we assume that it's base will always be 64K before the PE header base? - Unmap the parts of the shared library that do not constitute the inner dll. I would imagine that at some point wine stops relying on the native dynamic linker, at which point it would probably be safe to just unmap the extra pages such that view agrees with what is actually mapped. I'd be happy to put together a patch, but I'll need some guidance on how best to do this, since I haven't looked at the Wine codebase before today. [1] https://github.com/JuliaLang/julia/blob/01dd5ec0b25fc5fa8cf1fbae6bb00ef5874…

1 0

Re: kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping.
by Dmitry Timoshkov March 11, 2016

March 11, 2016

Thanks, I have only style related comments, and since I'm an author of existing tests I'd prefer to keep an original style if possible. Jacek Caban <jacek(a)codeweavers.com> wrote: > --- a/dlls/advapi32/tests/security.c > +++ b/dlls/advapi32/tests/security.c > @@ -5560,17 +5560,23 @@ static void test_filemap_security(void) > char temp_path[MAX_PATH]; > char file_name[MAX_PATH]; > DWORD ret, i, access; > - HANDLE file, mapping, dup; > + HANDLE file, mapping, dup, created_mapping; > static const struct > { > - int generic, mapped; > + DWORD generic, mapped; Please leave 'int' type, it changes nothing. > + BOOL open_only; > } map[] = > { > { 0, 0 }, > { GENERIC_READ, STANDARD_RIGHTS_READ | SECTION_QUERY | SECTION_MAP_READ }, > { GENERIC_WRITE, STANDARD_RIGHTS_WRITE | SECTION_MAP_WRITE }, > { GENERIC_EXECUTE, STANDARD_RIGHTS_EXECUTE | SECTION_MAP_EXECUTE }, > - { GENERIC_ALL, STANDARD_RIGHTS_REQUIRED | SECTION_ALL_ACCESS } > + { GENERIC_ALL, STANDARD_RIGHTS_REQUIRED | SECTION_ALL_ACCESS }, > + { SECTION_MAP_READ | SECTION_MAP_WRITE, SECTION_MAP_READ | SECTION_MAP_WRITE}, > + { SECTION_MAP_WRITE, SECTION_MAP_WRITE}, > + { SECTION_MAP_READ | SECTION_QUERY, SECTION_MAP_READ | SECTION_QUERY}, > + { SECTION_QUERY, SECTION_MAP_READ, TRUE }, > + { SECTION_QUERY | SECTION_MAP_READ, SECTION_QUERY | SECTION_MAP_READ } > }; > static const struct > { > @@ -5599,6 +5605,8 @@ static void test_filemap_security(void) > > for (i = 0; i < sizeof(prot_map)/sizeof(prot_map[0]); i++) > { > + if (map[i].open_only) continue; > + > SetLastError(0xdeadbeef); > mapping = CreateFileMappingW(file, NULL, prot_map[i].prot, 0, 4096, NULL); > if (prot_map[i].mapped) > @@ -5645,6 +5653,8 @@ static void test_filemap_security(void) > > for (i = 0; i < sizeof(map)/sizeof(map[0]); i++) > { > + if (map[i].open_only) continue; > + > SetLastError( 0xdeadbeef ); > ret = DuplicateHandle(GetCurrentProcess(), mapping, GetCurrentProcess(), &dup, > map[i].generic, FALSE, 0); > @@ -5659,6 +5669,24 @@ static void test_filemap_security(void) > CloseHandle(mapping); > CloseHandle(file); > DeleteFileA(file_name); > + > + created_mapping = CreateFileMappingA( INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, 0x1000, > + "Wine Test Open Mapping"); > + ok( created_mapping != NULL, "CreateFileMapping failed with error %u\n", GetLastError() ); > + > + for(i=0; i < sizeof(map)/sizeof(*map); i++) Please add spaces around '=' and use sizeof(map[0]) for consistency with existing code. > + { > + if (!map[i].generic) continue; > + > + mapping = OpenFileMappingA( map[i].generic, FALSE, "Wine Test Open Mapping"); > + ok( mapping != NULL, "OpenFileMapping failed with error %d\n", GetLastError()); > + access = get_obj_access( mapping ); > + ok( access == map[i].mapped, "[%d] unexpected access flags %x, expected %x\n", > + i, access, map[i].mapped ); Please use "%d:" instead of [%d] and %#x instead of %x for consistency with existing code. P.S. That's perfectly fine to completely ignore my comments, just wanted to show how it looks like for comparison with d3d-like acceptance policy :) -- Dmitry.

3 4

Attachments missing in new wiki
by Qian Hong March 11, 2016

March 11, 2016

Hi folks, Thanks for migrating the wiki to new site. Recently two different people ask me about attachments on https://wiki.winehq.org/WineConf2015, and I found they are missing, anyone knows what happen during the migration? Should we manually upload again? Is there backup for the attachments from old side? Thanks! -- Regards, Qian Hong - http://www.winehq.org

5 5

Re: [PATCH 2/6] ddraw/tests: Skip initialising "quad" and "indices" in test_specular_lighting() if a 3D device can't be crea
by Marvin March 11, 2016

March 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21376 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === The test timed out

1 0

Re: [PATCH try2] kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping.
by Marvin March 11, 2016

March 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21372 Your paranoid android. === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping.
by Marvin March 11, 2016

March 11, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21371 Your paranoid android. === w1064 (32 bit security) === security.c:3964: Test failed: MACHINE\Software owner SID (S-1-5-18) != Administrators SID (S-1-5-32-544). security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4005: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4009: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4018: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: kernel32: Don't set unconditionally SECTION_QUERY flag in OpenFileMapping.
by Dmitry Timoshkov March 11, 2016

March 11, 2016

Hi Jacek, Jacek Caban <jacek(a)codeweavers.com> wrote: > +static void test_OpenFileMapping(void) > +{ > + HANDLE created_handle, handle; > + DWORD access; > + int i; > + > + static const struct { > + DWORD open_access; > + DWORD handle_access; > + } access_tests[] = { > + { FILE_MAP_ALL_ACCESS, STANDARD_RIGHTS_REQUIRED | SECTION_QUERY | SECTION_EXTEND_SIZE | SECTION_MAP_EXECUTE | SECTION_MAP_READ | SECTION_MAP_WRITE }, > + { SECTION_MAP_READ | SECTION_MAP_WRITE, SECTION_MAP_READ | SECTION_MAP_WRITE}, > + { SECTION_MAP_WRITE, SECTION_MAP_WRITE}, > + { SECTION_MAP_READ | SECTION_QUERY, SECTION_MAP_READ | SECTION_QUERY}, > + { SECTION_QUERY, SECTION_MAP_READ }, > + { SECTION_QUERY | SECTION_MAP_READ, SECTION_QUERY | SECTION_MAP_READ }, > + { GENERIC_READ, READ_CONTROL | SECTION_MAP_READ | SECTION_QUERY } > + }; > + > + created_handle = CreateFileMappingA( INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, 0x1000, > + "Wine Test Open Mapping"); > + ok( created_handle != NULL, "CreateFileMapping failed with error %u\n", GetLastError()); > + > + for(i=0; i < sizeof(access_tests)/sizeof(*access_tests); i++) > + { > + handle = OpenFileMappingA( access_tests[i].open_access, FALSE, "Wine Test Open Mapping"); > + ok( handle != NULL, "OpenFileMapping failed with error %d\n", GetLastError()); > + access = get_obj_access( handle ); > + ok( access == access_tests[i].handle_access, "[%d] unexpected access flags %x, expected %x\n", > + i, access, access_tests[i].handle_access ); > + CloseHandle( handle ); > + } > + > + CloseHandle( created_handle ); > + } Please correct me if I'm mistaken but this test is basically a modified copy of test_filemap_security() from dlls/advapi32/tests/security.c, why not add it there and extend the test if needed so that all related tests are collected in one place? -- Dmitry.

2 1

Re: [v2 3/6] d3dx9: implement fxlc constants (expressions) in effect.
by Marvin March 10, 2016

March 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21342 Your paranoid android. === w8 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w864 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w1064 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w864 (64 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w1064 (64 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c.

2 1

Re: [v2 1/6] d3dx9: add test for preshader in effect.
by Marvin March 10, 2016

March 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21340 Your paranoid android. === w8 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w864 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w1064 (32 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w864 (64 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. === w1064 (64 bit effect) === effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c. effect.c:3668: Test failed: Got result 0x8876086c.

1 0

Re: [PATCH 3/6] d3dx9: implement fxlc constants (expressions) in effect.
by Marvin March 10, 2016

March 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21341 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: wined3d: add Nvidia GPU SKUS (950,950M,960,960M)
by Henri Verbeet March 10, 2016

March 10, 2016

On 10 March 2016 at 01:40, Rob Walker <bob.mt.wya(a)gmail.com> wrote: > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX950, "NVIDIA GeForce GTX 950", DRIVER_NVIDIA_GEFORCE8, 2048}, > + {HW_VENDOR_NVIDIA, CARD_NVIDIA_GEFORCE_GTX950, "NVIDIA GeForce GTX 950M", DRIVER_NVIDIA_GEFORCE8, 2048}, This looks wrong. You're also missing a sign-off line.

1 0

Re: winex11.drv: Allow grabed window belonging to a different thread in send_mouse_input.
by Henri Verbeet March 10, 2016

March 10, 2016

On 8 March 2016 at 17:01, Jacek Caban <jacek(a)codeweavers.com> wrote: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > > If we call XGrabPointer on a window belonging to a different thread, we > may end up handling its events with different display and being unable > to associate X11 window with HWND. Is calling SetCapture() on a window from a different thread really supposed to be valid? Assuming it is, wouldn't it then be easier to grab the window from the correct thread instead? (Similar to how e.g. WM_X11DRV_CLIP_CURSOR works.)

2 1

Re: [PATCH] ole32: Implement CoGetCurrentLogicalThreadId()
by Huw Davies March 10, 2016

March 10, 2016

On Wed, Mar 09, 2016 at 11:43:26PM +0300, Nikolay Sivov wrote: > diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c > index 183d8a0..e0c396f 100644 > --- a/dlls/ole32/tests/compobj.c > +++ b/dlls/ole32/tests/compobj.c > @@ -3093,6 +3093,21 @@ static void test_IMallocSpy(void) > ok(hr == CO_E_OBJNOTREG, "got 0x%08x\n", hr); > } > > +static void test_CoGetCurrentLogicalThreadId(void) > +{ > + GUID id, id2; > + HRESULT hr; > + > + hr = CoGetCurrentLogicalThreadId(NULL); > + ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); > + > + memset(&id, 0, sizeof(id)); > + memset(&id2, 0, sizeof(id2)); > + hr = CoGetCurrentLogicalThreadId(&id); > + ok(hr == S_OK, "got 0x%08x\n", hr); > + ok(memcmp(&id, &id2, sizeof(id)), "got zero id\n"); Any reason why you didn't do ok(!IsEqualGUID(&id, &GUID_NULL), ...) here? A follow-up patch could implement Context_CTI_GetCurrentLogicalThreadId() using CoGetCurrentLogicalThreadId(). Huw.

2 1

Re: [PATCH 2/6] d3dx9: add preshaders to effect.
by Matteo Bruni March 10, 2016

March 10, 2016

2016-03-09 14:38 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/Makefile.in | 3 +- > dlls/d3dx9_36/d3dx9_36_private.h | 36 +++ > dlls/d3dx9_36/effect.c | 80 +++-- > dlls/d3dx9_36/preshader.c | 671 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 757 insertions(+), 33 deletions(-) > create mode 100644 dlls/d3dx9_36/preshader.c > > diff --git a/dlls/d3dx9_36/Makefile.in b/dlls/d3dx9_36/Makefile.in > index 95e3045..b71b38e 100644 > --- a/dlls/d3dx9_36/Makefile.in > +++ b/dlls/d3dx9_36/Makefile.in > @@ -19,6 +19,7 @@ C_SRCS = \ > texture.c \ > util.c \ > volume.c \ > - xfile.c > + xfile.c \ > + preshader.c Please keep this in alphabetic order. > @@ -5427,6 +5407,7 @@ static HRESULT d3dx9_parse_array_selector(struct d3dx9_base_effect *base, struct > DWORD string_size; > struct d3dx_object *object = &base->objects[param->object_id]; > char *ptr = object->data; > + HRESULT ret; > > TRACE("Parsing array entry selection state for parameter %p.\n", param); > > @@ -5443,9 +5424,30 @@ static HRESULT d3dx9_parse_array_selector(struct d3dx9_base_effect *base, struct > } > TRACE("Unknown DWORD: 0x%.8x.\n", *(DWORD *)(ptr + string_size)); > > - FIXME("Parse preshader.\n"); > + d3dx_create_preshader(base, (DWORD *)(ptr + string_size) + 1, object->size - (string_size + 1), > + D3DXPT_INT, &param->pres); > + ret = D3D_OK; > + param = param->referenced_param; > + if (param->type == D3DXPT_VERTEXSHADER || param->type == D3DXPT_PIXELSHADER) > + { > + UINT i; > > - return D3D_OK; > + for (i = 0; i < param->element_count; i++) > + { > + if (param->members[i].type != param->type) > + { > + FIXME("Unexpected member parameter type %u (need %u).\n", param->members[i].type, param->type); > + return D3DXERR_INVALIDDATA; > + } > + if (!param->members[i].pres) > + { > + TRACE("Creating preshader for object %u.\n", param->members[i].object_id); > + object = &base->objects[param->members[i].object_id]; > + d3dx_create_preshader(base, object->data, object->size, param->type, &param->members[i].pres); > + } > + } > + } > + return ret; We discussed about this a bit already and arguably it's a matter of conventions but: a shader in an effect might have a preshader (PRES comment with its various subparts) or not. Calling the "plain" CTAB constants a "preshader" doesn't seem right to me. > +#define MIN(a, b) ((a) < (b) ? (a) : (b)) > +#define MAX(a, b) ((a) > (b) ? (a) : (b)) min() and max() are already defined and should be usable. > + > +enum preshader_type > +{ > + PRES_TYPE_FXLC, > + PRES_TYPE_SHADER > +}; You should rename this to something that doesn't imply that "plain shader constants" are a preshader type or drop it entirely (depending on how you separate the preshader from the plain constants an explicit type field might not be necessary). > + > +enum PRES_OPS > +{ > + PO_NOP, > + PO_MOV, > + PO_OP_MAX > +}; I would use somewhat longer and more descriptive names (e.g. PRESHADER_OP_NOP). > + > +typedef float (*pres_op_func)(float *args, int ncomp); > + > +static float pres_mov(float *args, int ncomp) {return args[0];} > + > +#define PRES_OPCODE_MASK 0x7FF00000 > +#define PRES_OPCODE_SHIFT 20 > +#define PRES_SCALAR_FLAG 0x80000000 > +#define PRES_NCOMP_MASK 0x0000FFFF > + > +#define FOURCC_PRES 0x53455250 > +#define FOURCC_CLIT 0x54494C43 > +#define FOURCC_FXLC 0x434C5846 > +#define FOURCC_PRSI 0x49535250 > +#define PRES_SIGN 0x46580000 Please use lowercase hexadecimal constants. > +struct op_info > +{ > + DWORD opcode; > + char mnem[8]; > + unsigned int ninp_args; > + BOOL func_all_comps; > + pres_op_func func; > +}; > + > +static struct op_info pres_op_info[] = > +{ > + {0x000, "nop", 0, 0, NULL }, /* PO_NOP */ > + {0x100, "mov", 1, 0, pres_mov}, /* PO_MOV */ > +}; > + > +enum PRES_VALUE_TYPE > +{ > + PRES_VT_FLOAT, > + PRES_VT_DOUBLE, > + PRES_VT_INT, > + PRES_VT_BOOL > +}; > + > +enum PRES_TABLES > +{ > + PRES_TAB_NONE, > + PRES_TAB_IMMED, /* immediate double constants from CLIT */ > + PRES_TAB_CONST, /* preshader input float constants */ > + PRES_TAB_VERTEX, /* not used */ > + PRES_TAB_OCONST, /* shader input float constants */ > + PRES_TAB_OBCONST, /* shader input bool constants */ > + PRES_TAB_OICONST, /* shader input int constants */ > + PRES_TAB_REG, /* registers */ > + PRES_TAB_MAX > +}; Same here, with more expressive names you might not need comments at all (although they seem pretty clear already). BTW, what is that PRES_TAB_VERTEX entry? > + > +static const struct > +{ > + unsigned int value_size; > + unsigned int reg_value_cnt; > + enum PRES_VALUE_TYPE type; > +} > +table_info[] = > +{ > + {0, 0}, > + {sizeof(double), 1, PRES_VT_DOUBLE}, /* PRES_TAB_IMMED */ > + {sizeof(float), 4, PRES_VT_FLOAT }, /* PRES_TAB_CONST */ > + {sizeof(float), 4, PRES_VT_FLOAT }, /* PRES_TAB_VERTEX */ > + {sizeof(float), 4, PRES_VT_FLOAT }, /* PRES_TAB_OCONST */ > + {sizeof(BOOL), 1, PRES_VT_BOOL }, /* PRES_TAB_OBCONST */ > + {sizeof(int), 4, PRES_VT_INT, }, /* PRES_TAB_OICONST */ > + {sizeof(float), 4, PRES_VT_FLOAT } /* PRES_TAB_REG */ > +}; > + > +static const char *table_symbol[] = > +{ > + "(null)", "imm", "c", "v", "oc", "ob", "oi", "r" > +}; > + > +static const char *xyzw_str = "xyzw"; > + > +#define OFFSET2REG(table, offset) ((offset) / table_info[table].reg_value_cnt) > + > +static const enum PRES_TABLES pres_regset2table[] = > +{ > + PRES_TAB_OBCONST, /* D3DXRS_BOOL */ > + PRES_TAB_OICONST, /* D3DXRS_INT4 */ > + PRES_TAB_CONST, /* D3DXRS_FLOAT4 */ > + PRES_TAB_NONE, /* D3DXRS_SAMPLER */ > +}; > + > +static const enum PRES_TABLES shad_regset2table[] = > +{ > + PRES_TAB_OBCONST, /* D3DXRS_BOOL */ > + PRES_TAB_OICONST, /* D3DXRS_INT4 */ > + PRES_TAB_OCONST, /* D3DXRS_FLOAT4 */ > + PRES_TAB_NONE, /* D3DXRS_SAMPLER */ > +}; > + > +struct d3dx_pres_operand > +{ > + enum PRES_TABLES table; > + unsigned int offset; /* value index, not register index */ That probably isn't very clear. Maybe call it "component index" instead of "value index" or write a longer comment. > +}; > + > +struct d3dx_pres_ins > +{ > + enum PRES_OPS op; > + BOOL scalar_op; /* first input argument is scalar, > + first scalar component is propagated */ Maybe put the comment above the field instead. > + unsigned int ncomps; > + unsigned int ninp_args; > + struct d3dx_pres_operand inputs[3]; > + struct d3dx_pres_operand output; > +}; > + > +#define PRES_VS_BITS_PER_WORD (sizeof(DWORD)*8) > + > +struct d3dx_const_tab > +{ > + unsigned int ninputs; > + D3DXCONSTANT_DESC *inputs; > + struct d3dx_parameter **inputs_param; > + ID3DXConstantTable *ctab; > + /* TODO: do not keep input constant structure > + (use it only at the parse stage) */ > + const enum PRES_TABLES *regset2table; > +}; > + > +struct d3dx_fxlc I would call this d3dx_preshader, > +{ > + void *tables[PRES_TAB_MAX]; > + unsigned int table_sizes[PRES_TAB_MAX]; /* registers count */ > + DWORD *table_value_set[PRES_TAB_MAX]; > + > + unsigned int nins; > + struct d3dx_pres_ins *ins; > + > + struct d3dx_const_tab inputs; > +}; > + > +struct d3dx_preshader and this one d3dx_shader or something. > +{ > + enum preshader_type pres_type; > + D3DXPARAMETER_TYPE param_type; > + > + struct d3dx_fxlc fxlc; > + struct d3dx_const_tab shader_inputs; > +}; > + > +static void val_set_reg(struct d3dx_fxlc *fxlc, unsigned int table, unsigned int reg_idx) > +{ > + fxlc->table_value_set[table][reg_idx / PRES_VS_BITS_PER_WORD] |= > + 1 << (reg_idx % PRES_VS_BITS_PER_WORD); > +} > + > +static void dump_shader_bytecode(void *data, unsigned int size) > +{ > + DWORD *words = (DWORD *)data; > + unsigned int i, j, n; > + > + size /= 4; > + i = 0; > + while (i < size) > + { > + n = MIN(size - i, 15); > + for (j = 0; j < n; j++) > + MESSAGE("0x%08X,", words[i + j]); > + i += n; > + MESSAGE("\n"); > + } > +} I would just use TRACE instead. 15 seems a bit too much, I'd stick to 8 per line or so. Also please use lowercase with hex. > + > +static DWORD *find_bytecode_comment(DWORD *ptr, DWORD fourcc) > +{ > + while ((*ptr & 0xFFFF) == 0xFFFE) > + { > + if (*(ptr + 1) == fourcc) > + return ptr + 2; > + ptr += 1 + (*ptr >> 16); > + } > + return NULL; > +} > + > +static DWORD *parse_pres_arg(DWORD *ptr, struct d3dx_pres_operand *opr) > +{ > + if (*ptr != 0) > + { > + FIXME("Relative addressing not supported yet, word %#x.\n", *ptr); > + return NULL; > + } > + ptr++; > + > + if (*ptr < 1 || *ptr >= PRES_TAB_MAX || *ptr == PRES_TAB_VERTEX) It's probably better to use the proper enum value instead of '1'. > +static HRESULT get_constants_desc(DWORD *byte_code, struct d3dx_const_tab *out, struct d3dx9_base_effect *base) > +{ > + ID3DXConstantTable *ctab; > + D3DXCONSTANT_DESC *cdesc; > + struct d3dx_parameter **inputs_param; > + D3DXCONSTANTTABLE_DESC desc; > + HRESULT hr; > + D3DXHANDLE hc; > + unsigned int i; > + unsigned int cnt; > + > + out->inputs = cdesc = NULL; > + out->ctab = NULL; > + out->inputs_param = NULL; > + out->ninputs = 0; > + inputs_param = NULL; > + hr = D3DXGetShaderConstantTable(byte_code, &ctab); > + if (FAILED(hr) || !ctab) > + { > + TRACE("Could not get CTAB data, hr %#x.\n", hr); > + /* returnin OK is not a typo */ But that is a typo ;) > + return D3D_OK; > + } > + hr = ID3DXConstantTable_GetDesc(ctab, &desc); > + if (FAILED(hr)) > + { > + FIXME("Could not get CTAB desc, hr %#x.\n", hr); > + goto err_out; > + } > + > + cdesc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(D3DXCONSTANT_DESC) * desc.Constants); > + inputs_param = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct d3dx_parameter **) * desc.Constants); Here you can use sizeof on the variable, as with your other patch, e.g.: cdesc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*cdesc) * desc.Constants); inputs_param = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*inputs_param) * desc.Constants); Notice that the second allocation was wrong. I haven't looked in detail at the rest of the patch, although I spotted a number of formatting issues.

2 1

Re: wined3d: Use a printf format specifier to avoid a compiler warning [-Wformat-security]
by Józef Kucia March 10, 2016

March 10, 2016

On Thu, Mar 10, 2016 at 7:46 AM, Hugh McMaster <hugh.mcmaster(a)outlook.com> wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/wined3d/glsl_shader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index 85244c8..8b0f617 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -342,7 +342,7 @@ static void shader_glsl_append_imm_ivec(struct wined3d_string_buffer *buffer, > if (size > 1) > shader_addline(buffer, "ivec%u(%s%s%s%s)", size, str[0], str[1], str[2], str[3]); > else > - shader_addline(buffer, str[0]); > + shader_addline(buffer, "%s", str[0]); > } > > static const char *get_info_log_line(const char **ptr) > -- > 1.9.1 > > > This should be fixed by 120126 (https://www.winehq.org/pipermail/wine-patches/2016-March/148053.html)

1 0

Wiki migration update
by Rosanne DiMesio March 9, 2016

March 9, 2016

The old MoinMoin wiki (http://oldwiki.winehq.org) is going to be taken down at the end of this month. Dimi will provide a tarball archive; snapshots should also be available on archive.org. Kyle has set up a page migration status page on http://oldwiki.winehq.org/PageMigration; you can check the status of any pages you are interested in there. If you decide to port any of remaining pages yourself, please update its status on that page and leave a note at the top of the ported page saying "This page has been ported to the new wiki." -- Rosanne DiMesio dimesio(a)earthlink.net

1 0

Re: [PATCH 1/6] d3dx9: add test for preshader in effect.
by Matteo Bruni March 9, 2016

March 9, 2016

Hi Paul, I have a few more comments, in addition to Henri's (BTW thank you for taking a look). 2016-03-09 14:38 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/tests/effect.c | 755 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 755 insertions(+) > > diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c > index a785f4d..8c5b5bb 100644 > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -3009,6 +3009,760 @@ static void test_effect_states(IDirect3DDevice9 *device) > ok(value == 3, "Got result %u, expected %u.\n", value, 1); > } > > +/* > + * fxc.exe /Tfx_2_0 > + */ > +#if 0 > +float4 g_Pos1; > +float4 g_Pos2; > +float4 g_Selector[2] = {{0, 0, 0, 0}, {10, 10, 10, 10}}; > + > +float4 opvect1 = {0.0, -0.0, -2.2, 3.402823466e+38F}; > +float4 opvect2 = {1.0, 2.0, -3.0, 4.0}; > + > +int4 g_iVect = {4, 3, 2, 1}; > + > +vertexshader vs_arr[3] = > +{ > + asm > + { > + vs_1_0 > + def c0, 1, 1, 1, 1 > + mov oPos, c0 > + }, Indentation. > + asm > + { > + vs_1_1 > + def c0, 2, 2, 2, 2 > + mov oPos, c0 > + }, > + asm > + { > + vs_2_0 > + def c0, 3, 3, 3, 3 > + mov oPos, c0 > + } > +}; > + > +row_major float4x3 m4x3row={{11, 12, 13}, {21, 22, 23}, {31, 32, 33}, {41, 42, 43}}; > +row_major float3x4 m3x4row={{11, 12, 13, 14}, {21, 22, 23, 24}, {31, 32, 33, 34}}; > +column_major float4x3 m4x3column={{11, 12, 13},{21, 22, 23},{31, 32, 33},{41, 42, 43}}; > +column_major float3x4 m3x4column={{11, 12, 13, 14}, {21, 22, 23, 24}, {31, 32, 33, 34}}; > +row_major float2x2 m2x2row={{11, 12}, {21, 22}}; > +column_major float2x2 m2x2column={{11, 12}, {21, 22}}; > +row_major float2x3 m2x3row={{11, 12, 13}, {21, 22, 23}}; > +column_major float2x3 m2x3column={{11, 12, 13}, {21, 22, 23}}; > +row_major float3x2 m3x2row={{11, 12}, {21, 22}, {31, 32}}; > +column_major float3x2 m3x2column={{11, 12}, {21, 22}, {31, 32}}; Formatting. > + > +row_major bool2x3 mb2x3row = { {true, false, true}, {false, true, true}}; > +column_major bool2x3 mb2x3column = { {true, false, true}, {false, true, true}}; > + > +struct VS_OUTPUT > +{ > + float4 Position : POSITION; // vertex position > + float2 TextureUV : TEXCOORD0; // vertex texture coords > + float4 Diffuse : COLOR0; // vertex diffuse color > +}; Those comments don't seem particularly useful. > +static float test_effect_preshader_fconstsp[][4] = > +{ > + {11.0, 21.0, 0.0 , 0.0 }, Numbers are usually right-aligned. Also those need the 'f' suffix. The whitespace before the '}' seems wrong. > +static BOOL test_effect_preshader_bconsts[] = > +{ > + 1, 0, 1, 0, 1, 0 > +}; If you're using BOOL, you should also use TRUE and FALSE. > +static void test_effect_preshader(IDirect3DDevice9 *device) > +{ > + const static D3DXVECTOR4 fvect1 = {28.0f, 29.0f, 30.0f, 31.0f}; > + const static D3DXVECTOR4 fvect2 = {0.0f, 0.0f, 1.0f, 0.0f}; > + const static float fvect_empty[] = {-9999.0f, -9999.0f, -9999.0f, -9999.0f}; > + HRESULT hr; > + ID3DXEffect *effect; > + D3DXHANDLE par; > + UINT npasses; > + BOOL bval; > + D3DLIGHT9 light; > + DWORD value; > + float fdata[TEST_EFFECT_PRES_NFLOATMAX * 4]; > + BOOL bdata[TEST_EFFECT_PRES_NBOOL]; > + IDirect3DVertexShader9 *vshader; > + void *byte_code; > + UINT byte_code_size; Just use unsigned int instead of UINT or DWORD IMO. > + > + unsigned int i, j; > + > + hr = D3DXCreateEffect(device, test_effect_preshader_effect_blob, sizeof(test_effect_preshader_effect_blob), > + NULL, NULL, 0, NULL, &effect, NULL); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + > + for (i = 0; i < TEST_EFFECT_PRES_NFLOATV; i++) > + { > + hr = IDirect3DDevice9_SetVertexShaderConstantF(device, 0, fvect_empty, 1); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + } That is repeatedly setting c0, right? I don't think that's what you meant to do here. Regardless, you probably want to initialize all 256 float constant registers. > + hr = effect->lpVtbl->Begin(effect, &npasses, 0); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + > + par = effect->lpVtbl->GetParameterByName(effect, NULL, "g_Pos2"); > + ok(par != NULL, "GetParameterByName failed.\n"); > + > + hr = effect->lpVtbl->SetVector(effect, par, &fvect1); > + ok(hr == D3D_OK, "SetFloatArray failed, hr %#x,\n", hr); Typo. More of the same below. > + for (i = 0; i < TEST_EFFECT_PRES_NOPTESTS; i++) > + { > + DWORD *v; > + > + hr = IDirect3DDevice9_GetLight(device, i % 8, &light); > + v = i < 8 ? (DWORD *)&light.Diffuse : (DWORD *)&light.Ambient; > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + if (i < TEST_EFFECT_PRES_NOPTESTS) This seems either wrong or unnecessary.

1 0

Re: [1/2] gdiplus/tests: Add tests for 0-pixel pens.
by Marvin March 9, 2016

March 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21326 Your paranoid android. === wxppro (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w2003std (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === wvistau64 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w2008s64 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w7u (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w7pro64 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w8 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w864 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w1064 (32 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === wvistau64 (64 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w2008s64 (64 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w7pro64 (64 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w864 (64 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0 === w1064 (64 bit graphics) === graphics.c:3903: Test failed: 1: expected 1, got 0 graphics.c:3928: Test failed: 1: expected 1, got 0

1 0

Re: [PATCH 1/6] d3dx9: add test for preshader in effect.
by Henri Verbeet March 9, 2016

March 9, 2016

On 9 March 2016 at 14:38, Paul Gofman <gofmanp(a)gmail.com> wrote: > +static float test_effect_preshader_fconstsv[][4] = > +{ > + {11.0, 12.0, 13.0, 0.0 }, > + {21.0, 22.0, 23.0, 0.0 }, > + {31.0, 32.0, 33.0, 0.0 }, > + {41.0, 42.0, 43.0, 0.0 }, > + {11.0, 21.0, 31.0, 0.0 }, > + {12.0, 22.0, 32.0, 0.0 }, > + {13.0, 23.0, 33.0, 0.0 }, > + {14.0, 24.0, 34.0, 0.0 }, > + {11.0, 12.0, 13.0, 14.0}, > + {21.0, 22.0, 23.0, 24.0}, > + {31.0, 32.0, 33.0, 34.0}, > + {11.0, 21.0, 31.0, 41.0}, > + {12.0, 22.0, 32.0, 42.0}, > + {13.0, 23.0, 33.0, 43.0} > +}; > + > +static float test_effect_preshader_fconstsp[][4] = > +{ > + {11.0, 21.0, 0.0 , 0.0 }, > + {12.0, 22.0, 0.0 , 0.0 }, > + {13.0, 23.0, 0.0 , 0.0 }, > + {11.0, 12.0, 0.0 , 0.0 }, > + {21.0, 22.0, 0.0 , 0.0 }, > + {31.0, 32.0, 0.0 , 0.0 }, > + {11.0, 12.0, 0.0 , 0.0 }, > + {21.0, 22.0, 0.0 , 0.0 }, > + {11.0, 21.0, 0.0 , 0.0 }, > + {12.0, 22.0, 0.0 , 0.0 }, > + {11.0, 12.0, 13.0, 0.0 }, > + {21.0, 22.0, 23.0, 0.0 }, > + {11.0, 21.0, 31.0, 0.0 }, > + {12.0, 22.0, 32.0, 0.0 } > +}; > + > +static BOOL test_effect_preshader_bconsts[] = > +{ > + 1, 0, 1, 0, 1, 0 > +}; > + > +static struct > +{ > + const char *comment; > + BOOL todo[4]; > + DWORD result[4]; > +} > +test_effect_preshader_op_results[] = > +{ > + {"1 / op", {1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > + {"rsq", {1, 1, 3, 3}, {0x7f800000, 0x7f800000, 0x3f2c985d, 0x1f800000}}, > + {"mul", {1, 1, 1, 1}, {0x00000000, 0x80000000, 0x40d33334, 0x7f800000}}, > + {"add", {0, 1, 1, 1}, {0x3f800000, 0x40000000, 0xc0a66666, 0x7f7fffff}}, > + {"lt", {0, 0, 1, 0}, {0x3f800000, 0x3f800000, 0x00000000, 0x00000000}}, > + {"ge", {1, 1, 0, 1}, {0x00000000, 0x00000000, 0x3f800000, 0x3f800000}}, > + {"neg", {1, 1, 1, 1}, {0x80000000, 0x00000000, 0x400ccccd, 0xff7fffff}}, > + {"rcp", {1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbee8ba2e, 0x00200000}}, > + {"frac", {0, 0, 1, 0}, {0x00000000, 0x00000000, 0x3f4ccccc, 0x00000000}}, > + {"min", {0, 1, 1, 1}, {0x00000000, 0x80000000, 0xc0400000, 0x40800000}}, > + {"max", {1, 1, 1, 1}, {0x3f800000, 0x40000000, 0xc00ccccd, 0x7f7fffff}}, > + {"sin", {0, 1, 1, 3}, {0x00000000, 0x80000000, 0xbf4ef99e, 0xbf0599b3}}, > + {"cos", {1, 1, 1, 3}, {0x3f800000, 0x3f800000, 0xbf16a803, 0x3f5a5f96}}, > + {"den mul",{1, 1, 1, 1}, {0x7f800000, 0xff800000, 0xbb94f209, 0x000051ec}}, > + {"dot", {0, 1, 1, 0}, {0x00000000, 0x7f800000, 0x41f00000, 0x00000000}} > +}; These should all be const. I'd probably use D3DXVECTOR4 for the float constant arrays. > +#define TEST_EFFECT_PRES_NFLOATV (sizeof(test_effect_preshader_fconstsv) / sizeof(*test_effect_preshader_fconstsv)) > +#define TEST_EFFECT_PRES_NFLOATP (sizeof(test_effect_preshader_fconstsp) / sizeof(*test_effect_preshader_fconstsp)) > +#define TEST_EFFECT_PRES_NFLOATMAX (TEST_EFFECT_PRES_NFLOATV > TEST_EFFECT_PRES_NFLOATP ? \ > + TEST_EFFECT_PRES_NFLOATV : TEST_EFFECT_PRES_NFLOATP) > +#define TEST_EFFECT_PRES_NBOOL (sizeof(test_effect_preshader_bconsts) / sizeof(*test_effect_preshader_bconsts)) > +#define TEST_EFFECT_PRES_NOPTESTS (sizeof(test_effect_preshader_op_results) / \ > + sizeof(*test_effect_preshader_op_results)) I think you should either just write these out, or introduce an ARRAY_SIZE macro. > + const static D3DXVECTOR4 fvect1 = {28.0f, 29.0f, 30.0f, 31.0f}; > + const static D3DXVECTOR4 fvect2 = {0.0f, 0.0f, 1.0f, 0.0f}; > + const static float fvect_empty[] = {-9999.0f, -9999.0f, -9999.0f, -9999.0f}; This is not wrong, but the usual order is "static const". > + todo_wine_if(!!bdata[i] != !!test_effect_preshader_bconsts[i]) You can write that as "!bdata[i] != !test_effect_preshader_bconsts[i]" without changing the meaning. > + todo_wine ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); %#x to make it clear it's a hexadecimal value. You don't need to print the expected value if it's a constant. > + hr = IDirect3DDevice9_GetVertexShader(device, &vshader); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + ok(vshader != NULL, "Got NULL vshader.\n"); > + if (vshader) > + { That kind of thing is pointless, if "vshader" was NULL, the test would have failed. > + ok(vshader == NULL, "Incorrect shader selected.\n"); I would prefer those as "ok(!vshader, ...);", but it's just style.

2 6

Re: configure: Fix cross-compiling of 32-bit Wine for OSX.
by Alexandre Julliard March 9, 2016

March 9, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -175,6 +175,13 @@ case $host in > AC_SUBST(TARGETFLAGS,"-marm") > ;; > i[[3456789]]86*) > + if test "$cross_compiling" = "yes"; then > + CC="$CC -m32" > + CXX="$CXX -m32" > + host_cpu="i386" > + notice_platform="32-bit " > + AC_SUBST(TARGETFLAGS,"-m32") > + fi The idea is that if you are cross-compiling, you have already specified the correct host so this shouldn't be needed. How does the OS/X cross-compiler behave? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/5] user32: Add initial out of window procedure slots test
by Dmitry Timoshkov March 9, 2016

March 9, 2016

Piotr Caban <piotr(a)codeweavers.com> wrote: > +static LRESULT WINAPI winproc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + if(!hwnd) { > + int *count = (int*)lparam; > + (*count)++; > + } > + return 0; > +} > + > +static LRESULT WINAPI winproc2(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) > +{ > + return 0; > +} ... > + memset(&wnd_classA, 0, sizeof(wnd_classA)); > + wnd_classA.lpszClassName = "winproc_test"; > + wnd_classA.lpfnWndProc = &winproc; Should be just "winproc" instead of "&winproc" > + ok(SetWindowLongPtrA(hwnd, GWLP_WNDPROC, (LONG_PTR)&winproc2), > + "SetWindowLongPtr failed with error %d\n", GetLastError()); Same here. -- Dmitry.

2 1

Re: [PATCH 5/6] d3d10core/tests: Add test for aoffimmi modifier.
by Henri Verbeet March 9, 2016

March 9, 2016

On 8 March 2016 at 17:46, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d10core/tests/device.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > This (and the equivalent d3d11 test) fails for me on Windows: device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 0). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (0, 1). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 0). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (1, 1). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 0). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (2, 1). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 0). device.c:4022: Test failed: Test 18: Got unexpected color 0x00000000 at (3, 1).

1 0

Re: [PATCH 2/6] wined3d: Extend shader_glsl_gen_sample_code() to support offsets.
by Henri Verbeet March 9, 2016

March 9, 2016

On 8 March 2016 at 17:46, Józef Kucia <jkucia(a)codeweavers.com> wrote: > +static void shader_glsl_append_imm_ivec(struct wined3d_string_buffer *buffer, > + const int *values, unsigned int size) > +{ > + const char *fmt = "%#x"; > + char str[4][17] = {{0}}; I guess this is inspired by shader_glsl_append_imm_vec4(), but I think you can just append to the buffer here. > + if (1 > size || size > 4) I don't think "1 > size" is all that more readable than "!size". > + for (i = size - 1; i >= 0; --i) > + { > + sprintf(str[i], fmt, values[i]); > + fmt = "%#x, "; > + } If you use ", %#x" for the format you don't need the awkward reverse loop. > - if (flags != WINED3D_GLSL_SAMPLE_LOAD) > - ERR("Unexpected flags for texelFetch %#x.\n", flags & ~WINED3D_GLSL_SAMPLE_LOAD); > + static const DWORD texel_fetch_flags = WINED3D_GLSL_SAMPLE_LOAD | WINED3D_GLSL_SAMPLE_OFFSET; > + if (flags & ~texel_fetch_flags) > + ERR("Unexpected flags for texelFetch %#x.\n", flags & ~texel_fetch_flags); The original had this as well, of course, but "Unexpected flags %#x for texelFetch.\n" may be better.

1 0

Re: [PATCH v2 2/5] dxgi: Add feature level support.
by Henri Verbeet March 9, 2016

March 9, 2016

On 8 March 2016 at 23:19, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -214,7 +215,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_adapter_CheckInterfaceSupport(IDXGIAdapter > return DXGI_ERROR_UNSUPPORTED; > } > > - if (FAILED(hr = dxgi_check_d3d10_support(adapter->parent, adapter))) > + if (FAILED(hr = dxgi_check_feature_level_support(adapter->parent, adapter, &feature_level, 1))) > return DXGI_ERROR_UNSUPPORTED; I don't think this does what you want it to do, > -HRESULT dxgi_check_d3d10_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter) > +HRESULT dxgi_check_feature_level_support(struct dxgi_factory *factory, struct dxgi_adapter *adapter, > + const D3D_FEATURE_LEVEL *feature_levels, unsigned int level_count) ... > + D3D_FEATURE_LEVEL selected_feature_level = 0; ... > + return selected_feature_level; because this doesn't match the return type.

1 0

Re: [PATCH 1/5] wmasf: add stub dll
by Austin English March 9, 2016

March 9, 2016

On Wed, Mar 9, 2016 at 12:31 AM, Austin English <austinenglish(a)gmail.com> wrote: > This patch series is for https://bugs.winehq.org/show_bug.cgi?id=39797 > > The bug subject is wmasf, but the uploaded log shows that there are a > few more dlls requested (api-ms-wine-core-*), so I went ahead and > added stubs for those while I was at it. > > -- > -Austin Sorry for the noise, gitconfig wasn't set up on the machine the patches were generated on, I'll resend tomorrow. -- -Austin

1 0

Re: [PATCH] d3dx9: IsParameterUsed stub should return TRUE.
by Henri Verbeet March 8, 2016

March 8, 2016

On 7 March 2016 at 22:49, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > Yes, I guess returning TRUE is usually more likely to work. Of course Is that necessarily what you want though? It might be harder to debug something being slow because it's updating unused parameters than to debug something rendering incorrectly because it's not updating them. > a proper implementation would be even better (although it may be non > obvious to find out if a parameter is used, depending on what "used" > really means - it needs tests)... You always need tests, but a reasonable guess would be whether the parameter is referenced by the technique.

3 7

Metatrader 5 uses all CPU time
by Vyacheslav Napadovsky March 8, 2016

March 8, 2016

Hello. I'm trying to launch Metatrader 5 in ubuntu with winehq-devel=1.9.5~ubuntu14.04.1 When I log in to my demo account the wineserver and terminal.exe (Metetrader 5 itself) start consume all available CPU. And if I'm trying to "Show all symbols" in "Market overview" then Metatrader UI just hangs. Here's last 10000 lines of 1.9GB log I dumped with WINEDEBUG=fixme-all,warn+all,+relay wine terminal.exe > terminal.log 2>&1 http://sendfile.su/1211848 (can't post it with pastebin.com, because it's over 500kB). Note, I killed process at the end with `killall terminal.exe` Moreover, when terminal.exe is running (without showing all symbols), `vmstat 1` shows that user space / system space consumes 50 / 50 % of CPU. And one more notice, if I run terminal.exe in a Virtual Box and assign this VM only one CPU core, than terminal.exe works fine consuming about 7% cpu, but with 2 cores it consumes 50%/50% with wineserver. On native Windows OS terminal.exe consumes less than 4% CPU with showing all symbols (I have 4 CPU cores on my notebook). Any clues where to dig next? -- Vyacheslav Napadovsky

1 0

wine dll loader
by Vyacheslav Napadovsky March 8, 2016

March 8, 2016

Hello. I'm developing .dll plugin for thirdparty software. In Windows 8.0 all works fine (my plugin loads and unloads correctly), but in wine, I got DLL_PROCESS_ATTACH, then 7 DLL_THREAD_ATTACH at plugin loading stage and only 1 DLL_THREAD_DETACH at plugin unloading, i.e my plugin remains active (because no DLL_PROCESS_DETACH came in). Maybe that's because I spawn new thread (CreateThread) at DLL_PROCESS_ATTACH. Please, suggest ways to debug this issue. Regards, Vyacheslav Napadovsky

3 6

Re: [PATCH] opencl/tests: Add initial tests
by Henri Verbeet March 8, 2016

March 8, 2016

On 8 March 2016 at 13:14, Detlef Riekenberg <wine.dev(a)web.de> wrote: > + * Copyright 2013 Detlef Riekenberg Is the year correct? > +INT WINAPI clGetPlatformIDs(UINT, PVOID*, UINT*); That doesn't look right. I also don't think anything in this test is particularly Windows specific.

1 0

Re: [PATCH] opencl/tests: Add initial tests
by Marvin March 8, 2016

March 8, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21276 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0

Re: user32: Do not block sending/posting WM_NOTIFY messages.
by Alexandre Julliard March 7, 2016

March 7, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > @@ -11188,6 +11188,35 @@ static void test_quit_message(void) > ok_sequence(WmStopQuitSeq, "WmStopQuitSeq", FALSE); > } > > +static void test_notify_message(void) > +{ > + HWND hwnd; > + BOOL ret; > + > + hwnd = CreateWindowExA(0, "TestWindowClass", NULL, WS_OVERLAPPEDWINDOW, > + CW_USEDEFAULT, CW_USEDEFAULT, 300, 300, 0, NULL, NULL, 0); > + ok(hwnd != 0, "Failed to create window\n"); > + > + ret = SendNotifyMessageA(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "SendNotifyMessageA failed with error %u\n", GetLastError()); > + ret = SendNotifyMessageW(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "SendNotifyMessageW failed with error %u\n", GetLastError()); > + ret = SendMessageCallbackA(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef, NULL, 0); > + ok(ret == TRUE, "SendMessageCallbackA failed with error %u\n", GetLastError()); > + ret = SendMessageCallbackW(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef, NULL, 0); > + ok(ret == TRUE, "SendMessageCallbackW failed with error %u\n", GetLastError()); > + ret = PostMessageA(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "PostMessageA failed with error %u\n", GetLastError()); > + ret = PostMessageW(hwnd, WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "PostMessageW failed with error %u\n", GetLastError()); > + ret = PostThreadMessageA(GetCurrentThreadId(), WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "PostThreadMessageA failed with error %u\n", GetLastError()); > + ret = PostThreadMessageW(GetCurrentThreadId(), WM_NOTIFY, 0x1234, 0xdeadbeef); > + ok(ret == TRUE, "PostThreadMessageW failed with error %u\n", GetLastError()); It would be interesting to test the received message contents too, also for the case of valid data. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v3] d3dx9: support setting texture through SetValue in effect.
by Matteo Bruni March 7, 2016

March 7, 2016

2016-03-06 9:39 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -2389,6 +2389,43 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) > } > } > > +static void test_effect_setvalue_object(IDirect3DDevice9 *device) > +{ > + ID3DXEffect *effect; > + D3DXHANDLE parameter; > + IDirect3DTexture9 *texture; > + IDirect3DTexture9 *texture_set; > + HRESULT hr; > + ULONG count; > + > + hr = D3DXCreateEffect(device, test_effect_parameter_value_blob_object, > + sizeof(test_effect_parameter_value_blob_object), NULL, NULL, 0, NULL, &effect, NULL); > + ok(hr == D3D_OK, "Got result %#x, expected 0 (D3D_OK).\n", hr); > + > + parameter = effect->lpVtbl->GetParameterByName(effect, NULL, "tex"); > + ok(parameter != NULL, "GetParameterByName failed, got %p\n", parameter); > + > + texture = NULL; > + hr = D3DXCreateTexture(device, D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, 0, D3DPOOL_DEFAULT, &texture); > + ok(hr == D3D_OK, "Got result %#x, expected 0 (D3D_OK).\n", hr); > + hr = effect->lpVtbl->SetValue(effect, parameter, &texture, sizeof(IDirect3DTexture9 **)); That sizeof() happens to have the right value (because IDirect3DTexture9 * is also a pointer type) although it's technically incorrect. It's generally preferred to use the variable instead of the type in sizeof when possible (e.g. in this case sizeof(texture)), that would have avoided this mistake and it also helps in other cases. The other two calls to {GS}etValue below have the same issue.

1 0

[PATCH RFC] programs/winedevice.exe: allow group loading
by Aric Stewart March 7, 2016

March 7, 2016

Here is a patch Sebastian Lackner wanted to see. This is continued work to allow group loading and working off of moving to using IoCreateDriver and such in winedevice. Still using a mailslot which I know Sebastian does not like. But it works quite well. -aric --- programs/winedevice/device.c | 190 ++++++++++++++++++++++++++++++++++++++----- 1 file changed, 170 insertions(+), 20 deletions(-)

1 0

Re: [PATCH] webservices: Fixed memory leaks in one error condition (Coverity)
by Hans Leidekker March 7, 2016

March 7, 2016

Hi Marcus, > diff --git a/dlls/webservices/reader.c b/dlls/webservices/reader.c > index 72e75c3..688bc2b 100644 > --- a/dlls/webservices/reader.c > +++ b/dlls/webservices/reader.c > @@ -928,7 +928,7 @@ static HRESULT read_attribute( struct reader *reader, WS_XML_ATTRIBUTE **ret ) > WS_XML_UTF8_TEXT *text; > unsigned int len = 0, ch, skip, quote; > const unsigned char *start; > - WS_XML_STRING *prefix, *localname; > + WS_XML_STRING *prefix, *localname = NULL; > HRESULT hr = WS_E_INVALID_FORMAT; > > if (!(attr = heap_alloc_zero( sizeof(*attr) ))) return E_OUTOFMEMORY; > @@ -948,7 +948,11 @@ static HRESULT read_attribute( struct reader *reader, WS_XML_ATTRIBUTE **ret ) > if (WsXmlStringEquals( prefix, &xmlns, NULL ) == S_OK) > { > attr->isXmlNs = 1; > - if (!(attr->prefix = alloc_xml_string( localname->bytes, localname->length ))) goto error; > + heap_free (prefix); > + if (!(attr->prefix = alloc_xml_string( localname->bytes, localname->length ))) { > + heap_free (localname); > + goto error; > + } > attr->localName = localname; > } > else Please replace tabs with spaces and use the same formatting as surrounding code. Otherwise it looks good, thanks.

1 0

Re: ddraw/tests: Fix function name in multiple ok() messages. (resend)
by Marvin March 7, 2016

March 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21242 Your paranoid android. === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w864 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (64 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match

1 0

Re: user32: Do not block sending/posting WM_NOTIFY messages.
by Marvin March 7, 2016

March 7, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21241 Your paranoid android. === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

2 1

Re: make_xftmpl: Remove getopt prototype
by Alexandre Julliard March 7, 2016

March 7, 2016

André Hentschel <nerv(a)dawncrow.de> writes: > @@ -92,8 +92,6 @@ static const struct keyword reserved_words[] = { > {"WORD", TOKEN_WORD} > }; > > -extern int getopt(int argc, char *const *argv, const char *optstring); This was explicitly added for MSVC builds. -- Alexandre Julliard julliard(a)winehq.org

1 0

Problems about License Compatibility
by Jianqiu Zhang March 6, 2016

March 6, 2016

Hi, I am writing packet.dll which is a dependency of windows native wpcap.dll , Source can be get from winpcap.org , When I try to impelment it in wine, I found that I need to use the Packet32.h from packet.dll , Which has a different license than wine(LGPL), And I am not familar with solving license compability, Is there anyone that know how to solve this problem? Thanks in advance I Attach the License for Packet32.h below -- snip -- /* * Copyright (c) 1999 - 2005 NetGroup, Politecnico di Torino (Italy) * Copyright (c) 2005 - 2007 CACE Technologies, Davis (California) * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions * are met: * * 1. Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. * 3. Neither the name of the Politecnico di Torino, CACE Technologies * nor the names of its contributors may be used to endorse or promote * products derived from this software without specific prior written * permission. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * */

3 2

Re: ntdll: add stub for RtlAddAccessDeniedObjectAce and forward to AddAccessDeniedObjectAce in advapi32
by Alexandre Julliard March 6, 2016

March 6, 2016

Louis Lenders <xerox.xerox2000x(a)gmail.com> writes: > Signed-off-by: Louis Lenders <xerox.xerox2000x at gmail.com> I'll apply this one, but next time could you please put a valid email address here? Thanks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2] d3dx9: support setting texture through SetValue in effect.
by Paul Gofman March 6, 2016

March 6, 2016

I will add a fall through message, thanks for the notice On 03/06/2016 11:29 AM, Paul Gofman wrote: > Hi Alistair, no, there is actual copy of data below there which is > required for this case either. Thanks, Paul. > > On Sun, 6 Mar 2016 at 06:16, Alistair Leslie-Hughes > <leslie_alistair(a)hotmail.com <mailto:leslie_alistair(a)hotmail.com>> wrote: > > Hi Paul, > I think you have missed a break in the switch or a message to > state fall through. > > > Alistair >

1 0

re: [v2] d3dx9: support setting texture through SetValue in effect.
by Alistair Leslie-Hughes March 5, 2016

March 5, 2016

Hi Paul, I think you have missed a break in the switch or a message to state fall through. Alistair

1 0

wine 1.9.5 shared wow64 compile error
by Olivier F. R. Dierick March 5, 2016

March 5, 2016

Hello, I've updated my git tree with 1.9.5 and now I have this error while compiling 32bit Wine with the --with-wine64 option (in a shared wow64 setup): ---begin make output--- ... rm -f fonts && ln -s ../1.9.5_wow_64/fonts fonts rm: impossible de supprimer « fonts »: est un dossier make: *** [fonts] Erreur 1 ... ---end make output--- It says fonts is a directory and can't be removed. I do out-of-tree builds. The 32bit directory doesn't exists when I run configure. After running configure, the 32bit build tree is there and contains a fonts directory with a single Makefile in it. I had no such error with Wine 1.9.4 and I don't have it when compiling stand-alone 32bit Wine or the 64bit shared wow part. I did a regression test and found this commit to be the culprit: ---begin git bisect output--- dcc16c7cac1cbf93096b072fe2f7b32ad08d1fa5 is the first bad commit commit dcc16c7cac1cbf93096b072fe2f7b32ad08d1fa5 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Feb 29 15:06:42 2016 +0900 makefiles: Don't generate global rules in disabled directories. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> ... ---end git bisect output--- I look forward to hearing from you soon -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be

2 2

Wine-1.9.5 source code Cppcheck 1.69 scanning
by Игорь Чебаненко March 4, 2016

March 4, 2016

Source code scanned with Cppcheck 1.69. Yes,I know that in this scanning report I have messages called "noise messages",but I hope,that you will see real bugs,and will ingnore this type of messages.

1 0

Re: [PATCH 07/10] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1().
by Henri Verbeet March 4, 2016

March 4, 2016

On 4 March 2016 at 11:43, Józef Kucia <jkucia(a)codeweavers.com> wrote: > It doesn't seem to be easy to declare D3D10CreateDeviceAndSwapChain1() > without using cpp_quote() because D3D10_DRIVER_TYPE is unknown to idl > (it's declared in d3d10misc.h). My knowledge about idl is limited > so maybe someone knows better. The easiest thing to do would be to use "enum D3D10_DRIVER_TYPE" instead of "D3D10_DRIVER_TYPE". I wouldn't be opposed to just using idl for d3d10misc.h either though. > +cpp_quote("HRESULT WINAPI D3D10CreateDeviceAndSwapChain1(IDXGIAdapter *,") > +cpp_quote(" D3D10_DRIVER_TYPE, HMODULE, UINT, D3D10_FEATURE_LEVEL1,") > +cpp_quote(" UINT, DXGI_SWAP_CHAIN_DESC *, IDXGISwapChain **, ID3D10Device1 **);") I'd prefer this with parameter names either way.

1 0

Re: [PATCH 1/2] user32: Store pointer to timer callback in SetTimer function instead of treating it as window procedure
by Alexandre Julliard March 4, 2016

March 4, 2016

Piotr Caban <piotr(a)codeweavers.com> writes: > I decided to leave 16-bit version of SetTimer as is for now. I haven't > seen any application running out of window procedures in this > case. This patch will change behavior of following 16-bit application: > SetTimer(hWnd, TIMER_ID, 1, tfunc); > GetMessage32(&msg, 0, 0, 0, TRUE); //get's WM_TIMER message > DispatchMessage32(&msg, TRUE); > Now this code will no longer call tfunc callback. According to my test > new behavior is correct. The more likely case is a 16-bit app retrieving a 32-bit timer and calling it through DispatchMessage16. How is this going to work with your proposed changes? -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [PATCH 2/2 v2] d3drm: Implement AddDestroyCallback/DeleteDestroyCallback for a viewport
by Henri Verbeet March 3, 2016

March 3, 2016

On 3 March 2016 at 09:10, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > +HRESULT d3drm_object_delete_destroy_callback(struct d3drm_object *object, D3DRMOBJECTCALLBACK cb, void *ctx) > +{ > + struct destroy_callback *callback, *callback2; > + > + if (!cb) > + return D3DRMERR_BADVALUE; > + > + LIST_FOR_EACH_ENTRY_SAFE(callback, callback2, &object->destroy_callbacks, struct destroy_callback, entry) > + { > + if (callback->cb == cb && callback->ctx == ctx) > + { > + list_remove(&callback->entry); > + HeapFree(GetProcessHeap(), 0, callback); > + } > + } > + > + return D3DRM_OK; > +} I won't hold it against the patch (much), but is that correct? E.g. suppose you do something like the following: add cb1 add cb2 add cb3 add cb2 delete cb2 What would the sequence be that ends up getting called?

2 1

Re: [v3 6/7] d3dx9: implement state save and restore in effect.
by Matteo Bruni March 3, 2016

March 3, 2016

2016-03-03 13:22 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- For your next submissions, can you please write a short changelog of the differences with the previous version(s) of the same patch? Ideally that goes after the '---'. > @@ -3493,18 +3501,34 @@ static HRESULT WINAPI ID3DXEffectImpl_Begin(ID3DXEffect *iface, UINT *passes, DW > if (flags & ~(D3DXFX_DONOTSAVESTATE | D3DXFX_DONOTSAVESAMPLERSTATE | D3DXFX_DONOTSAVESHADERSTATE)) > WARN("Invalid flags (%#x) specified.\n", flags); > > - if (This->manager || flags & D3DXFX_DONOTSAVESTATE) > + if (effect->manager || flags & D3DXFX_DONOTSAVESTATE) > { > TRACE("State capturing disabled.\n"); > } > else > { > - FIXME("State capturing not supported, yet!\n"); > + HRESULT hr; > + unsigned int i; > + > + if (!technique->saved_state) > + { > + hr = IDirect3DDevice9_BeginStateBlock(effect->device); > + if (FAILED(hr)) > + ERR("BeginStateBlock failed, hr %#x.\n", hr); > + for (i = 0; i < technique->pass_count; i++) > + d3dx9_apply_pass_states(effect, &technique->passes[i]); This is likely correct but testing it with a technique with at least 2 passes would be nice.

1 0

Re: [v3 5/7] d3dx9: implement sampler and texture effect states application.
by Matteo Bruni March 3, 2016

March 3, 2016

2016-03-03 13:22 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/d3dx9_36/effect.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/d3dx9_36/tests/effect.c | 2 +- > 2 files changed, 40 insertions(+), 3 deletions(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index e1f01f2..6813c79 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -2681,7 +2681,8 @@ HRESULT d3dx_set_shader_const_state(IDirect3DDevice9 *device, enum SHADER_CONSTA > return D3D_OK; > } > > -static HRESULT d3dx9_apply_state(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, struct d3dx_state *state) > +static HRESULT d3dx9_apply_state(struct ID3DXEffectImpl *effect, struct d3dx_pass *pass, > + struct d3dx_state *state, int parent_index) I would have used an unsigned int here, flagging "none" with ~0u.

1 0

Re: [v3 4/7] d3dx9: implement shader constants effect states application.
by Matteo Bruni March 3, 2016

March 3, 2016

2016-03-03 13:22 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > + UINT nelem; "unsigned int element_count;" would be better.

1 0

Re: [v3 3/7] d3dx9: implement light and material effect states application.
by Matteo Bruni March 3, 2016

March 3, 2016

2016-03-03 13:22 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > + light_tbl[] = > + { > + {FIELD_OFFSET(D3DLIGHT9, Type), "LC_TYPE"}, > + {FIELD_OFFSET(D3DLIGHT9, Diffuse), "LT_DIFFUSE"}, > + {FIELD_OFFSET(D3DLIGHT9, Specular), "LT_SPECULAR"}, > + {FIELD_OFFSET(D3DLIGHT9, Ambient), "LT_AMBIENT"}, > + {FIELD_OFFSET(D3DLIGHT9, Position), "LT_POSITION"}, > + {FIELD_OFFSET(D3DLIGHT9, Direction), "LT_DIRECTION"}, > + {FIELD_OFFSET(D3DLIGHT9, Range), "LT_RANGE"}, > + {FIELD_OFFSET(D3DLIGHT9, Falloff), "LT_FALLOFF"}, > + {FIELD_OFFSET(D3DLIGHT9, Attenuation0), "LT_ATTENUATION0"}, > + {FIELD_OFFSET(D3DLIGHT9, Attenuation1), "LT_ATTENUATION1"}, > + {FIELD_OFFSET(D3DLIGHT9, Attenuation2), "LT_ATTENUATION2"}, > + {FIELD_OFFSET(D3DLIGHT9, Theta), "LT_THETA"}, > + {FIELD_OFFSET(D3DLIGHT9, Phi), "LT_PHI"} > + }; This is misindented. > + switch (op) > + { > + case LT_TYPE: > + TRACE("LT_TYPE %u.\n", *(D3DLIGHTTYPE *)value); > + light->Type = *(D3DLIGHTTYPE *)value; > + break; > + case LT_DIFFUSE: > + case LT_SPECULAR: > + case LT_AMBIENT: > + { > + D3DCOLORVALUE c = *(D3DCOLORVALUE *)value; > + > + TRACE("%s (%f %f %f %f).\n", light_tbl[op].name, c.r, c.g, c.b, c.a); > + *(D3DCOLORVALUE *)((char *)light + light_tbl[op].offset) = c; It's probably a bit nicer to cast to (BYTE *) instead of (char *). > diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c > index 81a7d12..3bcba72 100644 > --- a/dlls/d3dx9_36/tests/effect.c > +++ b/dlls/d3dx9_36/tests/effect.c > @@ -2910,11 +2910,11 @@ static void test_effect_states(IDirect3DDevice9 *device) > } > > hr = IDirect3DDevice9_GetLightEnable(device, 2, &bval); > - todo_wine ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > if (hr == D3D_OK) > ok(bval, "Got result %u, expected TRUE.\n", bval); > hr = IDirect3DDevice9_GetLight(device, 2, &light); > - todo_wine ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > if (hr == D3D_OK) > ok(light.Position.x == 4.0f && light.Position.y == 5.0f && light.Position.z == 6.0f, > "Got unexpected light position (%f, %f, %f).\n", light.Position.x, light.Position.y, light.Position.z); > @@ -2950,9 +2950,9 @@ static void test_effect_states(IDirect3DDevice9 *device) > todo_wine ok(!memcmp(mat.m, test_mat.m, sizeof(mat)), "World matrix not restored.\n"); > > hr = IDirect3DDevice9_GetLightEnable(device, 2, &bval); > - todo_wine ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > + ok(hr == D3D_OK, "Got result %x, expected 0 (D3D_OK).\n", hr); > if (hr == D3D_OK) > - ok(!bval, "Got result %u, expected 0.\n", bval); > + todo_wine ok(!bval, "Got result %u, expected 0.\n", bval); It would be nice if the test also checked the material.

1 0

Re: [v3 1/7] d3dx9: add test for basic effect state management.
by Matteo Bruni March 3, 2016

March 3, 2016

2016-03-03 13:22 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > + > + if (effect) > + effect->lpVtbl->Release(effect); > +} The if is unnecessary, the effect creation should never fail (and if it failed you would have already crashed long before that).

1 0