April 2016 - Wine-Devel - list.winehq.org

RFC: gdi32: add a [fonts] section to win.ini
by Austin English April 26, 2016

April 26, 2016

This patch is for https://bugs.winehq.org/show_bug.cgi?id=33492, already tested as working. I wanted to send for review first, as I'm not sure if this is the best approach or if someone has a better idea for how to handle it. Thanks, -- -Austin

2 2

Re: [PATCH] shell32: Add SHLimitInputEdit stub.
by Nikolay Sivov April 26, 2016

April 26, 2016

On 26.04.2016 6:13, Alex Henrie wrote: > Needed for Windows Movie Maker 2.6. > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/shell32/shell32.spec | 1 + > dlls/shell32/shlfolder.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec > index 93fd449..7ebd032 100644 > --- a/dlls/shell32/shell32.spec > +++ b/dlls/shell32/shell32.spec > @@ -264,6 +264,7 @@ > 727 stdcall SHGetImageList(long ptr ptr) > 730 stdcall -noname RestartDialogEx(long wstr long long) > 743 stdcall SHCreateFileExtractIconW(wstr long ptr ptr) > + 747 stdcall SHLimitInputEdit(ptr ptr) > Does it actually need explicit ordinal?

2 2

Re: [PATCH 3/5] qedit: Implement IAMTimelineObj_GetTimelineType and add tests.
by Nikolay Sivov April 26, 2016

April 26, 2016

On 26.04.2016 6:09, Alex Henrie wrote: > static HRESULT WINAPI TimelineObj_GetTimelineType(IAMTimelineObj *iface, TIMELINE_MAJOR_TYPE *type) > { > TimelineObjImpl *This = impl_from_IAMTimelineObj(iface); > - FIXME("(%p)->(%p): not implemented!\n", This, type); > - return E_NOTIMPL; > + TRACE("(%p)->(%p)\n", This, type); > + *type = This->timeline_type; > + return S_OK; > } Is it supposed to handle NULL input?

2 1

Re: [6/6] wininet: Handle INTERNET_INVALID_PORT_NUMBER in HttpOpenRequest.
by Marvin April 25, 2016

April 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22569 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [5/6] wininet/tests: Add more tests for INTERNET_INVALID_PORT_NUMBER.
by Marvin April 25, 2016

April 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22568 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [4/6] wininet/tests: Add tests for asynchronous InternetReadFile.
by Marvin April 25, 2016

April 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22567 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: [2/6] wininet/tests: Add tests for asynchronous InternetReadFileEx.
by Marvin April 25, 2016

April 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22566 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2406: Test failed: count was wrong http.c:2407: Test failed: http data wrong, got: Garbage: Header http.c:3070: Test failed: HttpAddRequestHeaders succeeded http.c:3071: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3076: Test failed: code = 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:3076: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

3 2

Re: [v2 PATCH 1/3] ucrtbase: Implement _initialize_onexit_table()
by Piotr Caban April 25, 2016

April 25, 2016

On 04/24/16 20:51, Nikolay Sivov wrote: > dlls/ucrtbase/tests/onexit.c | 114 +++++++++++++++++++++ Probably we don't need a separate file just for these tests. Could you please put them into a file with more generic name so it can be used for other tests in future. > + memset(&table, 0, sizeof(table)); > + ret = p_initialize_onexit_table(&table); > + ok(ret == 0, "got %d\n", ret); > + ok(table._first == table._last && table._first == table._end, "got first %p, last %p, end %p\n", > + table._first, table._last, table._end); > +todo_wine > + ok(table._first != NULL, "got %p\n", table._first); We probably don't need to be binary compatible but native uses following algorithm (x - random number, 32-bit version): void* encode_ptr(void *p) { DWORD r = (DWORD)p; r = _rotl(r, x); return r^x; } void* decode_ptr(void *p) { DWORD r = (DWORD)p; r = r^x; return _rotr(r, x); } In theory this test may fail if x happens to be 0. Thanks, Piotr

2 1

Re: msvcrt: The fpclass() constants are not defines.
by Piotr Caban April 25, 2016

April 25, 2016

Hi, I don't know how to review this patch. Alexandre, could you please take a look on it? For me the patch may go in and if it causes any problems configure check may be added. I guess we no longer care about the compiler it was added for. Thanks, Piotr

1 0

Re: shell32/tests: Tests for broken apps that check GetLastError() after SHFileOperation()
by Marvin April 25, 2016

April 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22483 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2455: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2464: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2468: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2471: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2477: Test failed: SHGetNewLinkInfoA failed, err=0 shlfileop.c:2481: Test failed: Y does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2484: Test failed: Y does not end with .lnk === wvistau64 (64 bit shlfileop) === shlfileop.c:297: Test failed: SHGetFileInfoA(test4.txt/) should return 1, got 0x0 shlfileop.c:2455: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2464: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2468: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2471: Test failed: does not end with .lnk shlfileop.c:83: Test failed: Failure to open file shlfileop.c:2477: Test failed: SHGetNewLinkInfoA failed, err=1008 shlfileop.c:2481: Test failed: does not start with C:\Users\Public\Documents\testdir2 shlfileop.c:2484: Test failed: does not end with .lnk shlfileop.c:2486: Test failed: and are the same

2 1