May 2016 - Wine-Devel - list.winehq.org

Wine Gecko 2.47-beta1
by Jacek Caban May 5, 2016

May 5, 2016

Hi all, I just uploaded a beta build of the next Gecko update. Wine patch is attached. All reviews and testing is appreciated. Thanks, Jacek

1 0

Re: [1/2] shlwapi/tests: Add wvnsprintfW comformance test
by Marvin May 5, 2016

May 5, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22849 Your paranoid android. === wxppro (32 bit string) === string: unhandled exception c0000005 at 77F6923B === w2003std (32 bit string) === string: unhandled exception c0000005 at 7D18A782

1 0

Re: [PATCH] winmm: Restrict some MCI actions to the creating thread
by Marvin May 4, 2016

May 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22848 Your paranoid android. === w864 (32 bit mci) === mci.c:1121: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) === w1064 (32 bit mci) === mci.c:1121: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) === w864 (64 bit mci) === mci.c:1121: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close) === w1064 (64 bit mci) === mci.c:1121: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

1 0

Re: [PATCH 11/11] msctf: Added ITfTransitoryExtensionSink tests.
by Marvin May 4, 2016

May 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22847 Your paranoid android. === wvistau64 (32 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === w2008s64 (32 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === w7u (32 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === w7pro64 (32 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === wvistau64 (64 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === w2008s64 (64 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie === w7pro64 (64 bit inputprocessor) === inputprocessor.c:1104: Test failed: Failed to get sink cookie

1 0

Re: msctf: Improved ITfKeystrokeMgr::TestKeyUp and TestKeyDown stubs.
by Aric Stewart May 4, 2016

May 4, 2016

Signed-off-by: Aric Stewart <aric(a)codeweavers.com>

1 0

Re: comdlg32: Use SetRect() instead of open coding it.
by Dmitry Timoshkov May 4, 2016

May 4, 2016

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote: > - cancel_rc.left = dialog_rc.right - cancel_width - hspacing; > - cancel_rc.top = dialog_rc.bottom - cancel_height - vspacing; > - cancel_rc.right = cancel_rc.left + cancel_width; > - cancel_rc.bottom = cancel_rc.top + cancel_height; > + SetRect(&cancel_rc, > + dialog_rc.right - cancel_width - hspacing, dialog_rc.bottom - cancel_height - vspacing, > + dialog_rc.right - hspacing , dialog_rc.bottom - vspacing); This is at least very strange and weird formatting of an API call. I don't see anything like that in the changed file. -- Dmitry.

3 5

Re: [PATCH 3/4] winemac.drv: Really fix our handling of DIBs on the clipboard.
by Ken Thomases May 4, 2016

May 4, 2016

Hi Chip, Thanks for working on this. I know you didn't originate this approach, but, as a general concern, is there really no better approach to converting DIBs than what we have with duplicated code for manually laying out the structure and copying data? I mean, that code has to go someplace, but shouldn't there be proper functions in GDI or something? Among other things, I worry that there might be subtle details that each duplicate gets slightly wrong or at least different from the others. For one thing, when converting from a DIBv5 to another format, you copy across the image data, but you drop the color profile. Shouldn't there be a color conversion to sRGB or whatever the default profile of a v3 DIB is? I know that most of Wine doesn't handle this stuff properly, anyway, but that's part of my point about doing these conversions in one place. When such support is added to that one place in the future, we'd want to automatically get the benefit of it here. Specific points about the code in-line below. In some cases, I may just be ignorant about the DIB format, so just let me know: On May 3, 2016, at 2:03 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > > +static HGLOBAL create_dib_from_dibv5(HGLOBAL src) … > + /* Calculate the size of the new packed DIB */ > + data_size = bv5->bV5SizeImage; MSDN says bV5SizeImage can be zero for BI_RGB DIBs. Is that only for zero-size DIBs or does it mean it's implicit in width, height, and bit count? > + packed_size = sizeof(BITMAPINFOHEADER) > + + ((bv5->bV5BitCount <= 8) ? (sizeof(RGBQUAD) * bv5->bV5ClrUsed) : 0) > + + ((bv5->bV5Compression == BI_BITFIELDS) ? (sizeof(DWORD) * 3) : 0) > + + data_size; MSDN says bV5BitCount can be 0 for BI_JPEG and BI_PNG. For that case, should a color table be included in the size? There's an existing function, bitmap_info_size(). Should that be extended for additional header types for its existing uses? Should it be used for these calculations in your new code? > +static HGLOBAL create_dibv5_from_dib(HGLOBAL src) … > + data_size = bmih->biSizeImage; > + packed_size = sizeof(BITMAPV5HEADER) > + + ((bmih->biBitCount <= 8) ? (sizeof(RGBQUAD) * bmih->biClrUsed) : 0) > + + data_size; > + offset_src = bmih->biSize > + + ((bmih->biBitCount <= 8) ? (sizeof(RGBQUAD) * bmih->biClrUsed) : 0); Shouldn't offset_src potentially include the color masks for biCompression == BI_BITFIELDS? > + if (bv5->bV5Compression == BI_BITFIELDS && bmih->biSize < sizeof(BITMAPV4HEADER)) > + { > + memcpy(&bv5->bV5RedMask, bmih+1, 3*sizeof(DWORD)); > + bv5->bV5AlphaMask = 0; > + } Is it OK to leave the masks uninitialized for other cases? > + hdc = GetDC(0); You never release this DC. > + if (GetLogColorSpaceW(GetColorSpace(hdc), &lcs, sizeof(lcs))) > + { > + if (bmih->biSize < sizeof(BITMAPV4HEADER)) > + { > + bv5->bV5CSType = lcs.lcsCSType; > + bv5->bV5Endpoints = lcs.lcsEndpoints; > + bv5->bV5GammaRed = lcs.lcsGammaRed; > + bv5->bV5GammaGreen = lcs.lcsGammaGreen; > + bv5->bV5GammaBlue = lcs.lcsGammaBlue; > + } > + bv5->bV5Intent = lcs.lcsIntent; > + } > + else > + { > + if (bmih->biSize < sizeof(BITMAPV4HEADER)) > + { > + bv5->bV5CSType = LCS_DEVICE_RGB; This type isn't listed as a valid value for bV5CSType in MSDN. > + memset(&bv5->bV5Endpoints, 0, sizeof(bv5->bV5Endpoints)); > + bv5->bV5Endpoints.ciexyzRed.ciexyzX = 0xffffffff; > + bv5->bV5Endpoints.ciexyzGreen.ciexyzY = 0xffffffff; > + bv5->bV5Endpoints.ciexyzBlue.ciexyzZ = 0xffffffff; > + bv5->bV5GammaRed = 0; > + bv5->bV5GammaGreen = 0; > + bv5->bV5GammaBlue = 0; Are gamma values of 0 right? I would expect the 16.16-fixed form of 2.2 or maybe 1.0. > @@ -724,6 +932,7 @@ static HANDLE import_bmp_to_dib(CFDataRef data) > } > > memcpy(p, bmi, len); > + Spurious whitespace change. > @@ -1254,8 +1552,35 @@ static CFDataRef export_bitmap_to_dib(HANDLE data) > dib = create_dib_from_bitmap(data); > if (dib) > { > - ret = export_clipboard_data(dib); > + HGLOBAL dib3 = create_dib_from_dibv5(dib); > + > + ret = export_clipboard_data(dib3); > + GlobalFree(dib); > + if (dib3 != dib) GlobalFree(dib3); > + } Is the above necessary? create_dib_from_bitmap() will only ever create v3 DIBs, right? It's specifically allocating and building a BITMAPINFOHEADER. -Ken

1 0

Re: [PATCH 3/3] wininet: Added IRD_NO_WAIT flag tests.
by Marvin May 4, 2016

May 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22837 Your paranoid android. === w1064 (32 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2413: Test failed: count was wrong http.c:2414: Test failed: http data wrong, got: Garbage: Header http.c:3077: Test failed: HttpAddRequestHeaders succeeded http.c:3078: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3083: Test failed: code = 200, expected 400 http.c:3083: Test failed: unexpected status code 200, expected 400 http.c:3083: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 === w1064 (64 bit http) === http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1 http.c:1762: Test failed: Expected 2, got 4 http.c:1763: Test failed: Expected CRLF, got ' http.c:2413: Test failed: count was wrong http.c:2414: Test failed: http data wrong, got: Garbage: Header http.c:3077: Test failed: HttpAddRequestHeaders succeeded http.c:3078: Test failed: Expected error ERROR_HTTP_HEADER_NOT_FOUND, got 0 http.c:3083: Test failed: code = 200, expected 400 http.c:3083: Test failed: unexpected status code 200, expected 400 http.c:3083: Test failed: unexpected status code 200, expected 400 http.c:523: Test failed: HTTP_QUERY_RAW_HEADERS: expected length 0, but got 1

1 0

Re: msctf: Improved ITfKeystrokeMgr::TestKeyUp and TestKeyDown stubs.
by Marvin May 4, 2016

May 4, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22836 Your paranoid android. === wvistau64 (32 bit inputprocessor) === inputprocessor.c:254: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:275: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:1241: Test failed: eaten = 1 === w2008s64 (32 bit inputprocessor) === inputprocessor.c:254: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:275: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:1241: Test failed: eaten = 1 === w864 (32 bit inputprocessor) === inputprocessor.c:793: Test failed: Deactivation came unexpectedly === wvistau64 (64 bit inputprocessor) === inputprocessor.c:254: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:275: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:1241: Test failed: eaten = 1 === w2008s64 (64 bit inputprocessor) === inputprocessor.c:254: Test failed: Unexpected TextStoreACP_RequestLock sink inputprocessor.c:275: Test failed: Unexpected TextStoreACP_GetSelection sink inputprocessor.c:1241: Test failed: eaten = 1

1 0

Re: winex11.drv: Use IsRectEmpty() instead of open coding it.
by Alexandre Julliard May 4, 2016

May 4, 2016

Michael Stefaniuc <mstefani(a)redhat.de> writes: > @@ -134,7 +134,7 @@ static inline void reset_bounds( RECT *bounds ) > > static inline void add_bounds_rect( RECT *bounds, const RECT *rect ) > { > - if (rect->left >= rect->right || rect->top >= rect->bottom) return; > + if (IsRectEmpty(rect)) return; I'm not sure it's an improvement to add a function call in such a simple inline function. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: [PATCH 2/4] winemac.drv: Move create_bitmap_from_dib() above the import/export functions.
by Ken Thomases May 4, 2016

May 4, 2016

Signed-off-by: Ken Thomases <ken(a)codeweavers.com>

1 0

Re: winemac.drv: Use IsRectEmpty() instead of open coding it.
by Ken Thomases May 4, 2016

May 4, 2016

On May 3, 2016, at 2:47 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > Not even compile tested. But as this is a purely generated patch there > was no opportunity for me to screw it up... In fact, it doesn't compile. :-/ You've added a call to IsRectEmpty() to macdrv.h, which doesn't #include winuser.h. That alone only causes an implicit declaration warning. However, clipboard.c includes winuser.h after macdrv.h, which causes an error about the conflict between the real and implicit declarations. You can move the include of winuser.h from all of the modules to macdrv.h, but make sure to #define OEMRESOURCE before it, as required by mouse.c. It also seems to need to come after the include of wingdi.h. -Ken > > > > dlls/winemac.drv/macdrv.h | 2 +- > dlls/winemac.drv/window.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winemac.drv/macdrv.h b/dlls/winemac.drv/macdrv.h > index f3b5e65..81b642c 100644 > --- a/dlls/winemac.drv/macdrv.h > +++ b/dlls/winemac.drv/macdrv.h > @@ -47,7 +47,7 @@ > > static inline CGRect cgrect_from_rect(RECT rect) > { > - if (rect.left >= rect.right || rect.top >= rect.bottom) > + if (IsRectEmpty(&rect)) > return CGRectMake(rect.left, rect.top, 0, 0); > return CGRectMake(rect.left, rect.top, rect.right - rect.left, rect.bottom - rect.top); > } > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index a48ac17..fbea49f 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -401,7 +401,7 @@ static void sync_window_region(struct macdrv_win_data *data, HRGN win_region) > */ > static inline void add_bounds_rect(RECT *bounds, const RECT *rect) > { > - if (rect->left >= rect->right || rect->top >= rect->bottom) return; > + if (IsRectEmpty(rect)) return; > bounds->left = min(bounds->left, rect->left); > bounds->top = min(bounds->top, rect->top); > bounds->right = max(bounds->right, rect->right); > -- > 2.4.11 > >

1 0

Re: ntdll: Fix buffer allocation check in get_dir_data_space.
by Alexandre Julliard May 4, 2016

May 4, 2016

Sebastian Lackner <sebastian(a)fds-team.de> writes: > BTW: I assume its intentional that you realloc only the first buffer to release > some space, right? In the worst case we are wasting up to about > PATH_MAX * sizeof(WCHAR) space in the other buffers. Yes, in the common case it will only waste a few bytes. It's only the last buffer that can have significant space left. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dbghelp: Fix a typo in comment
by Frédéric Delanoy May 4, 2016

May 4, 2016

Minor thing, but you wanna keep "*/" alignment consistent by adding a space. On Tue, May 3, 2016 at 4:01 PM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > @@ -58,7 +58,7 @@ > /* order from highest-order term to lowest-order term. UARTs transmit */ > /* characters in order from LSB to MSB. By storing the CRC this way, */ > /* we hand it to the UART in the order low-byte to high-byte; the UART */ > -/* sends each low-bit to hight-bit; and the result is transmission bit */ > +/* sends each low-bit to high-bit; and the result is transmission bit */ > /* by bit from highest- to lowest-order term without requiring any bit */ > /* shuffling on our part. Reception works similarly. */ -- Frédéric Delanoy

1 0

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin May 3, 2016

May 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22828 Your paranoid android. === wvistau64 (64 bit win) === win.c:8154: Test failed: transparent window didn't get WM_NCHITTEST message win.c:8155: Test failed: button under static window didn't get WM_LBUTTONUP

1 0

Re: [PATCH 3/4] d3drm: Implement IDirect3DRM*_CreateTexture. (v2)
by Aaryaman Vasishta May 3, 2016

May 3, 2016

Please take a look at v2 of this patch and v2 of patch 2/4. 1/4 and 4/4 are there as well but are way down the list so should I resend the whole patch set instead? Cheers Aaryaman On Sat, Apr 30, 2016 at 4:54 PM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- > dlls/d3drm/d3drm.c | 37 ++++++++++++++++++++--------- > dlls/d3drm/tests/d3drm.c | 61 > ++++++++++++++++++++++++++++++++++++++++++++---- > dlls/d3drm/texture.c | 2 +- > 3 files changed, 83 insertions(+), 17 deletions(-) > > diff --git a/dlls/d3drm/d3drm.c b/dlls/d3drm/d3drm.c > index 2b428ef..6c6007d 100644 > --- a/dlls/d3drm/d3drm.c > +++ b/dlls/d3drm/d3drm.c > @@ -195,17 +195,19 @@ static HRESULT WINAPI > d3drm1_CreateAnimationSet(IDirect3DRM *iface, IDirect3DRMA > static HRESULT WINAPI d3drm1_CreateTexture(IDirect3DRM *iface, > D3DRMIMAGE *image, IDirect3DRMTexture **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = > IDirect3DRM3_CreateTexture(&d3drm->IDirect3DRM3_iface, image, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, > &IID_IDirect3DRMTexture, (void **)texture); > + IDirect3DRMTexture3_Release(texture3); > > - return D3DRM_OK; > + return hr; > } > > static HRESULT WINAPI d3drm1_CreateLight(IDirect3DRM *iface, > @@ -661,17 +663,19 @@ static HRESULT WINAPI > d3drm2_CreateAnimationSet(IDirect3DRM2 *iface, IDirect3DRM > static HRESULT WINAPI d3drm2_CreateTexture(IDirect3DRM2 *iface, > D3DRMIMAGE *image, IDirect3DRMTexture2 **texture) > { > - struct d3drm_texture *object; > + struct d3drm *d3drm = impl_from_IDirect3DRM2(iface); > + IDirect3DRMTexture3 *texture3; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > > - if (FAILED(hr = d3drm_texture_create(&object))) > + if (FAILED(hr = > IDirect3DRM3_CreateTexture(&d3drm->IDirect3DRM3_iface, image, &texture3))) > return hr; > > - *texture = &object->IDirect3DRMTexture2_iface; > + hr = IDirect3DRMTexture3_QueryInterface(texture3, > &IID_IDirect3DRMTexture2, (void **)texture); > + IDirect3DRMTexture3_Release(texture3); > > - return D3DRM_OK; > + return hr; > } > > static HRESULT WINAPI d3drm2_CreateLight(IDirect3DRM2 *iface, > @@ -1152,13 +1156,24 @@ static HRESULT WINAPI > d3drm3_CreateAnimationSet(IDirect3DRM3 *iface, IDirect3DRM > static HRESULT WINAPI d3drm3_CreateTexture(IDirect3DRM3 *iface, > D3DRMIMAGE *image, IDirect3DRMTexture3 **texture) > { > + struct d3drm *d3drm = impl_from_IDirect3DRM3(iface); > struct d3drm_texture *object; > HRESULT hr; > > - FIXME("iface %p, image %p, texture %p partial stub.\n", iface, image, > texture); > + TRACE("iface %p, image %p, texture %p.\n", iface, image, texture); > + > + if (!d3drm_validate_image(image)) > + return D3DRMERR_BADVALUE; > > if (FAILED(hr = d3drm_texture_create(&object))) > return hr; > + object->d3drm = &d3drm->IDirect3DRM_iface; > + > + if (FAILED(hr = > IDirect3DRMTexture3_InitFromImage(&object->IDirect3DRMTexture3_iface, > image))) > + { > + d3drm_texture_destroy(object); > + return hr; > + } > > *texture = &object->IDirect3DRMTexture3_iface; > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 2a70ca4..3a32e6d 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1725,11 +1725,62 @@ static void test_Texture(void) > hr = IDirect3DRM_QueryInterface(d3drm1, &IID_IDirect3DRM3, (void > **)&d3drm3); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRM3 interface (hr = %x).\n", > hr); > > + /* Tests for validation of D3DRMIMAGE struct */ > + hr = IDirect3DRM_CreateTexture(d3drm1, &testimg, &texture1); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture interface (hr = > %x)\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &testimg, &texture2); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = > %x)\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &testimg, &texture3); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture3 interface (hr = > %x)\n", hr); > + IDirect3DRMTexture_Release(texture1); > + IDirect3DRMTexture2_Release(texture2); > + IDirect3DRMTexture3_Release(texture3); > + > + initimg.rgb = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.rgb = 1; > + initimg.red_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.red_mask = 0x000000ff; > + initimg.green_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.green_mask = 0x0000ff00; > + initimg.blue_mask = 0; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + initimg.blue_mask = 0x00ff0000; > + initimg.buffer1 = NULL; > + hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got > %x.\n", hr); > + > initimg.buffer1 = &pixel; > hr = IDirect3DRM_CreateTexture(d3drm1, &initimg, &texture1); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > + ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 = %u.\n", > ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1737,7 +1788,7 @@ static void test_Texture(void) > hr = IDirect3DRM2_CreateTexture(d3drm2, &initimg, &texture2); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1 + 1, "expected ref2 > ref1, got ref1 = %u , > ref2 = %u.\n", ref1, ref2); > + ok(ref2 > ref1 + 1, "expected ref2 > (ref1 + 1), got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1745,7 +1796,7 @@ static void test_Texture(void) > hr = IDirect3DRM3_CreateTexture(d3drm3, &initimg, &texture3); > ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture3 interface (hr = > %x)\n", hr); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 > ref1 + 2, "expected ref2 > ref1, got ref1 = %u , > ref2 = %u.\n", ref1, ref2); > + ok(ref2 > ref1 + 2, "expected ref2 > (ref1 + 2), got ref1 = %u , ref2 > = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1803,7 +1854,7 @@ static void test_Texture(void) > > IDirect3DRMTexture_Release(texture1); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 - 2 == ref1, "expected ref2 == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > + ok(ref2 - 2 == ref1, "expected (ref2 - 2) == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > @@ -1827,7 +1878,7 @@ static void test_Texture(void) > > IDirect3DRMTexture2_Release(texture2); > ref2 = get_refcount((IUnknown *)d3drm1); > - todo_wine ok(ref2 - 1 == ref1, "expected ref2 == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > + ok(ref2 - 1 == ref1, "expected (ref2 - 1) == ref1, got ref1 = %u, > ref2 = %u.\n", ref1, ref2); > ref3 = get_refcount((IUnknown *)d3drm2); > ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = > %u.\n", ref1, ref3); > ref4 = get_refcount((IUnknown *)d3drm3); > diff --git a/dlls/d3drm/texture.c b/dlls/d3drm/texture.c > index 7db3ecd..883be82 100644 > --- a/dlls/d3drm/texture.c > +++ b/dlls/d3drm/texture.c > @@ -46,7 +46,7 @@ static inline struct d3drm_texture > *impl_from_IDirect3DRMTexture3(IDirect3DRMTex > > void d3drm_texture_destroy(struct d3drm_texture *texture) > { > - if (texture->d3drm && texture->initialized) > + if (texture->initialized) > IDirect3DRM_Release(texture->d3drm); > HeapFree(GetProcessHeap(), 0, texture); > } > -- > 2.3.2 (Apple Git-55) > >

1 0

Re: mode: add stub exe
by Nikolay Sivov May 2, 2016

May 2, 2016

> +MODULE = mode.exe I don't know how important that is, but on Win7 it's called mode.com, just what bug title says. > @@ -3472,6 +3472,7 @@ WINE_CONFIG_PROGRAM(iexplore,,[install]) > WINE_CONFIG_PROGRAM(ipconfig,,[clean,install]) > WINE_CONFIG_PROGRAM(lodctr,,[install]) > WINE_CONFIG_PROGRAM(mofcomp,,[install]) > +WINE_CONFIG_PROGRAM(mode,,[install]) > WINE_CONFIG_PROGRAM(mshta,,[install]) > WINE_CONFIG_PROGRAM(msiexec,,[install,installbin,manpage]) > WINE_CONFIG_PROGRAM(net,,[clean,install]) This is not sorted.

2 1

Re: [1/2] kernel32/tests: Add more tests for GetConsoleFontInfo. (v4)
by Marvin May 2, 2016

May 2, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22804 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 1301662830 console.c:1445: Test failed: [15] Expected output count to be 0, got 1301662830 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1301662830 console.c:1689: Test failed: [13] Expected output count to be 0, got 1301662830 console.c:1689: Test failed: [15] Expected output count to be 0, got 1301662830 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1301662830 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 3495556664 console.c:1445: Test failed: [15] Expected output count to be 0, got 3495556664 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3495556664 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 3495556664 console.c:1689: Test failed: [15] Expected output count to be 0, got 3495556664 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3495556664 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 4206877851 console.c:1445: Test failed: [15] Expected output count to be 0, got 4206877851 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 4206877851 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 4206877851 console.c:1689: Test failed: [15] Expected output count to be 0, got 4206877851 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 4206877851 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [2/2] kernel32/tests: Add tests for SetConsoleFont. (resend)
by Marvin May 2, 2016

May 2, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22805 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 3667173890 console.c:1445: Test failed: [15] Expected output count to be 0, got 3667173890 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 3667173890 console.c:1689: Test failed: [13] Expected output count to be 0, got 3667173890 console.c:1689: Test failed: [15] Expected output count to be 0, got 3667173890 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 3667173890 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 125638792 console.c:1445: Test failed: [15] Expected output count to be 0, got 125638792 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 125638792 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 125638792 console.c:1689: Test failed: [15] Expected output count to be 0, got 125638792 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 125638792 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 62984337 console.c:1445: Test failed: [15] Expected output count to be 0, got 62984337 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 62984337 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 62984337 console.c:1689: Test failed: [15] Expected output count to be 0, got 62984337 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 62984337 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w864 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

ntdll: Store the directory identity and search mask in the directory cache
by Piotr Caban May 2, 2016

May 2, 2016

The patch breaks compilation on mac: directory.c:1973:42: error: expected identifier if (!has_wildcard( dir_data->->mask )) break; ^ directory.c:2164:34: error: use of undeclared identifier 'dir_data' const UNICODE_STRING *mask = dir_data->mask; ^ directory.c:2216:61: error: use of undeclared identifier 'dir_data' union file_directory_info *info = append_entry( dir_data, bu... Thanks, Piotr

1 1

Re: [PATCH] comctl32/tooltips: Cut tooltip text at first tab char unless TTS_NOPREFIX is used
by Dmitry Timoshkov May 2, 2016

May 2, 2016

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > @@ -316,49 +318,40 @@ static void test_gettext(void) > toolinfoA.lParam = 0xdeadbeef; > GetClientRect(hwnd, &toolinfoA.rect); > r = SendMessageA(hwnd, TTM_ADDTOOLA, 0, (LPARAM)&toolinfoA); > - if (r) > - { > - toolinfoA.hwnd = NULL; > - toolinfoA.uId = 0x1234ABCD; > - toolinfoA.lpszText = bufA; > - SendMessageA(hwnd, TTM_GETTEXTA, 0, (LPARAM)&toolinfoA); > - ok(strcmp(toolinfoA.lpszText, "") == 0, "lpszText should be an empty string\n"); > > - toolinfoA.lpszText = bufA; > - SendMessageA(hwnd, TTM_GETTOOLINFOA, 0, (LPARAM)&toolinfoA); > - ok(toolinfoA.lpszText == NULL, > - "expected NULL, got %p\n", toolinfoA.lpszText); 'r' is assigned but not used. Perhaps it would be a good idea to test return value of every SendMessage() call. -- Dmitry.

1 0

Re: dwmapi: Return S_OK in DwmSetWindowAttribute stub.
by Nikolay Sivov May 2, 2016

May 2, 2016

On 02.05.2016 16:06, Sebastian Lackner wrote: > From: Michael Müller <michael(a)fds-team.de> > > Signed-off-by: Michael Müller <michael(a)fds-team.de> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > dlls/dwmapi/dwmapi_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c > index 155d7d3..8c3472a 100644 > --- a/dlls/dwmapi/dwmapi_main.c > +++ b/dlls/dwmapi/dwmapi_main.c > @@ -126,7 +126,7 @@ HRESULT WINAPI DwmSetWindowAttribute(HWND hwnd, DWORD attributenum, LPCVOID attr > > if (!once++) FIXME("(%p, %x, %p, %x) stub\n", hwnd, attributenum, attribute, size); > > - return E_NOTIMPL; > + return S_OK; > } > > /********************************************************************** > What application is that for?

2 1

Re: [PATCH 2/2 v2] mshtml: Make it possible to clear timer and interval with any of clearTimeout and clearInterval functions
by Marvin May 2, 2016

May 2, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22785 Your paranoid android. === wxppro (32 bit events) === events.c:1388: timeout The test timed out === w2003std (32 bit events) === events.c:1388: timeout The test timed out === wvistau64 (32 bit events) === events.c:1388: timeout The test timed out === w2008s64 (32 bit events) === events.c:1388: timeout === w7u (32 bit events) === events.c:1388: timeout === w7pro64 (32 bit events) === events.c:1388: timeout === w8 (32 bit events) === events.c:1388: timeout === w864 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === wvistau64 (64 bit events) === events.c:1388: timeout === w2008s64 (64 bit events) === events.c:1388: timeout === w7pro64 (64 bit events) === events.c:1388: timeout === w864 (64 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (64 bit events) === events.c:1388: timeout events.c:1388: timeout

1 0

Re: [PATCH 1/2 v2] mshtml: Fix HTMLWindow3_setInterval behavior on 0 msec intervals
by Marvin May 2, 2016

May 2, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22784 Your paranoid android. === wxppro (32 bit events) === events.c:1388: timeout === w2003std (32 bit events) === events.c:1388: timeout === wvistau64 (32 bit events) === events.c:1388: timeout === w2008s64 (32 bit events) === events.c:1388: timeout === w7u (32 bit events) === events.c:1388: timeout === w7pro64 (32 bit events) === events.c:1388: timeout === w8 (32 bit events) === events.c:1388: timeout === w864 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (32 bit events) === events.c:1388: timeout events.c:1388: timeout === wvistau64 (64 bit events) === events.c:1388: timeout === w2008s64 (64 bit events) === events.c:1388: timeout === w7pro64 (64 bit events) === events.c:1388: timeout === w864 (64 bit events) === events.c:1388: timeout events.c:1388: timeout === w1064 (64 bit events) === events.c:1388: timeout events.c:1388: timeout

1 0

Re: [PATCH] po: update Norwegian translation
by Nikolay Sivov May 2, 2016

May 2, 2016

On 30.04.2016 17:18, Kim Malmo wrote: > I have added missing translations and fixed up the fuzzy ones. I've also > fixed some minor typos and spelling errors in the old translation. > > The undertaking that might stand out here however, is I've tried to make > it more consistent with itself, and more consistent with the original > english text. One thing I want to point out is the (former) usage of > « and » signs. First of all the are no longer present on Norwegian > keyboards, second and perhaps most importantly, they look hideous with > whatever is the default Wine font. For consistency what I've done is the > following: > > * For %1 (or similar) in the english text I have used %1 or '%1' depending > on context. In some cases it makes sense to wrap handles or operations > in Norwegian. > > * For '%1' (or similar) in the english text I have used '%1' > > * All cases of «%1» (or similar) has been changed to %1 or '%1' depending > on context. > > For parts of the translation I have tried to make the context and meaning > more clear. There are also quite a few changes to make it more conformant > with Microsoft's Norwegian Bokmål Style Guide. Hi, thank you for this major update. Regarding quotation marks, it's really up to target language to use one of several styles of quotation marks and quotation formatting. Original English text is only a reference, not something to follow. User guide you mentioned, mostly tells to omit quotation marks (p. 58), and use straight double quotes if they are necessary. The fact that '«' and '»' are missing from default keyboard layout is unfortunate but can't alone be a reason not to use them, if traditional typographical rules tell so. What about default Wine font problems with them? I see no such thing when testing in clean prefix, but it could certainly depend on dpi/font size (Wine's Tahoma is simplistic) and actual font you're using. > > Signed-off-by: Kim Malmo <berencamlost(a)msn.com>

3 3