June 2016 - Wine-Devel - list.winehq.org

Re: [v2 PATCH] d3dx9_36: Stop crash when displaying effect errors
by Matteo Bruni June 28, 2016

June 28, 2016

2016-06-22 13:10 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > if (temp_errors) > - TRACE("%s\n", (char *)ID3D10Blob_GetBufferPointer(temp_errors)); > + { > + const char *p = ID3D10Blob_GetBufferPointer(temp_errors); > + SIZE_T size = ID3D10Blob_GetBufferSize(temp_errors); > + const char *end = p + size; > + const char *line = p; > + > + while (p != end) > + { > + if (*p == '\n') > + { > + UINT len = p - line; > + if (len && *(p - 1) == '\r') --len; > + TRACE("%s\n", debugstr_an(line, len)); > + line = ++p; > + } > + else ++p; > + } > + if (line != p) > + TRACE("%s\n", debugstr_an(line, p - line)); > + } This only breaks at '\n', which might still be too much if the lines are particularly long. I also wrote a patch for this a few days ago. I'm going to send it to wine-patches in a bit, I'd appreciate if you can test if it works for you or point out any issue with it.

1 0

Re: include: Add missing interface declaration.
by Nikolay Sivov June 28, 2016

June 28, 2016

> interface IWbemContext; > interface IWbemServices; > +interface IWbemLocator; > interface IWbemStatusCodeText; > interface IWbemCallResult; > interface IWbemObjectSink; Why do you need this? IWbemLocator is fully defined later in this file.

1 0

Re: [PATCH 6/7] d3drm: Implement IDirect3DRMViewport*::Init.
by Stefan Dösinger June 27, 2016

June 27, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > + if (FAILED(hr = IDirect3DRMDevice_QueryInterface(device, &IID_IDirect3DRMDevice3, (void **)&device3))) > + return hr; > + > + if (FAILED(hr = IDirect3DRMFrame_QueryInterface(camera, &IID_IDirect3DRMFrame3, (void **)&camera3))) > + { > + IDirect3DRMDevice3_Release(device3); > + return hr; > + } > + IDirect3DRMDevice_Release(device); > + IDirect3DRMFrame_Release(camera); > + > + return d3drm_viewport2_Init(&viewport->IDirect3DRMViewport2_iface, device3, camera3, x, y, width, height); This has the same problem as the first version of your frame thunks: You get "device3", but then you release "device", to which you don't hold a reference. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcFfoAAoJEN0/YqbEcdMweH8P/RBg+lEvXxGES0C1Uo5aN6Ht E0TOftji/AaGrVcaoHLWMsl30/GUpmh+iRdM19ZHwL0vey3yKKdTmFlt4tMrG5aP LLHLlxRqcJt1h+MREvMYb7JJjCAMcR/2Bn63nxWZpZ+PncQo1H90ZsBHCrd4Y707 JukrA3QfPm9cyXiX/ER8cj7QgpnNsk5y8ZXgbdtDDGOzShf2OSoslU5ivQQsmZ4W 2fiJWOeWdpi3P9Fh6EUTDOwUf5Rnj7mBYb3KFASc9o0VZXHuI/f35LGG9AdNkSxs lf6RbPDcXxPQqUxlz0VnmS/31/oGb0pDczESx+alDU9n29tWPANY+yBGUmDStyJ0 /RHl2qpZJMs/lQpk9UQ/RpvuVdZfLVxgftqyZuoWT4EfW5iseOlCytmsJEG1AVpd BKAMFRbueGhPYfUcuLAH1GL4keRg7P3QUd36MlR0wWVdYGtMWrbQL+6SrHT6r75C QmXU9mTJMTleA/Yzskenm71Tz9/wbwavYjUMaEQp3+7OKrG0Zqnt4foh2GpNUT+6 M7jxfSSng4+irWvxf3ZKdpjfGNHRn1ZhRKrEpxKQptiGlFvYSMDy7tHtyybK2MbB h8CO19YAzcVjfFHj5sRSYtZIHdVm5aG5FJLfVm9UPBA7xT2l9b6EgqXEhLTVLYC6 /TSyEFgT5j+DkKf6DCm+ =0tcs -----END PGP SIGNATURE-----

2 3

OSSCOM 2016 Conference - Dec, 2016 (Call for Papers)
by 2nd International Conference on Open Source Software Computing June 27, 2016

June 27, 2016

OSSCOM 2016 Call for Proposals/ Papers OSSCOM 2016 The 2nd International Conference on Open Source Software Computing 1st - 3rd December 2016 Lebanese University, Beirut - Lebanon http://mailer.tagorg.com/lists/lt.php?id=bB0DBlQZUAJSTlQNAFIEAA Partially funded by EC - Tempus and technically sponsored by IEEE Objectives To promote opportunities for cooperation towards enabling OSS key technologies, building cross-cutting sciences, and driving disruptive innovations; to disseminate research on technology and applications of open source software computing; and to expand the framework of effective participation of universities in developing OSS industry through incubators and business accelerators. Structure - Keynotes - Panel and roundtable discussions - Presentation sessions - Industry and technology discussions - Consultation meetings, focus groups, and roundtables - Best practice showcases and practical demonstration - Workshops Submission Deadline 1st September, 2016 (Manuscripts) 1st October, 2016 (Proposals) Topics of Interest Track 1: Systems Software - Operating systems: Linux Kernel, Server and Desktop Linux: RedHat, Debian, Slackware, Caldera, SuSe, Fedora - Distributed Operating systems: Open source platforms and software for the cloud platform as a service (PaaS), software as a service (SaaS), and infrastructure as a service (IaaS). Open stack, Open-source software in scientific computing including clouds, grids and HPCs - Embedded and Realtime Operating systems - Ubiquitous mobile computing and technologies: middleware, operating system (e.g. Android), new I/O and user interfaces, mobile protocols Track 2: Applications and Services - Open-source software services and applications in energy, environment, education, health, climate, water, agriculture, biology, economy, medicine and other pressing global issues and problems - Open-source software for e-Services, including e-Government, e-Libraries, e-Learning and any e-* - Open-source software for Smart Education, Smart Cities, Smart Power Grids, Smart Transportation - Open Source applications for mobile and tablets Track 3: Networking and Security - Open source network simulation/emulations tools - Open source platforms for network security deployment, testing and verification - Network and security open source management software Track 4: Open Source Development and Support - Perspectives on open-source software development and services, including challenges, operation, sustainability, funding, governance, business models, and security - National, regional and international organizations and their role in funding and supporting open-source software applications in research and education - Collaborative projects and initiatives in research and education at national, regional and global levels - Research and education challenges and open access paradigm - Business models for open-source software development and services Track 5: Software Engineering This track will bring together researchers, students and industry experts from diverse areas associated with software engineering who are utilizing, developing or even improving open source software systems during their research and experiments. Software Engineering influences all aspects of computer science research and touches every software researchers and practitioners. There are diverse Free and open-source software that could be utilized in many fields under the umbrella of Software Engineering such as but not limited to: - Software Process Models - Software Process Improvement - Software Architecture - Component-Based Software Engineering - Software Verification and Validation - Model Checking - Software Impact Analysis - Design Patterns and Frameworks - Model Driven Architecture - Modeling with UML - Reusable Software and Metrics - Reverse Engineering, Re-engineering - Adaptive Software - Software Define Network - Data Mining and Machine Learning - Safety and Security in Critical Software Conference Venue Lebanese University, Beirut - Lebanon Submit a Participation <http://mailer.tagorg.com/lists/lt.php?id=bB0DB1EZUAJSTlQNAFIEAA> Language English Registration Fees OSSCOM members 50 Euro OSSCOM non-members 100 Euro Authors and Speakers 50 Euro Students Free All papers will be peer-reviewed and selected papers will be published in the conference proceedings and submitted to IEEE Explore. Partners and Organisers - Hochschule Bonn-Rhein-Sieg University of Applied Sciences, Germany - German Jordanian University, Jordan - Lebanese University, Lebanon - Brunel University, United Kingdom - Yarmouk University, Jordan - Notre Dame University, Lebanon - University of Castilla-La Mancha, Spain - Tarent AG, Germany - Talal Abu-Ghazaleh Information Technology International, Jordan - Information Management Ltd, Lebanon - Le Cnam Liban Important Dates 1st Sept, 2016 Manuscript Submission Deadline 1st Oct, 2016 Acceptance Notification 15th Nov 2016 Registration Deadline 1st – 3rd Dec 2016 OSSCOM 2016 Conference For more information and paper submission, please contact Paper Submission: - Please submit your manuscript or proposal at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBVQZUAJSTlQNAFIEAA Registration: - Please register for OSSCOM 2016 conference at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBlYZUAJSTlQNAFIEAA Publicity: - Dr. Yaser Jararweh, yijararweh(a)just.edu.jo <mailto:yijararweh(a)just.edu.jo> - Dr. Muhannad Quwaider, mqquwaider(a)just.edu.jo <mailto:mqquwaider(a)just.edu.jo> More Information: - Please contact us through our email: office(a)osscom.org <mailto:office(a)osscom.org> All information is available at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBlcZUAJSTlQNAFIEAA -- This message was sent to wine-devel(a)winehq.org by Office(a)osscom.org To forward this message, please do not use the forward button of your email application, because this message was made specifically for you only. Instead use the forward page <http://mailer.tagorg.com/lists/lt.php?id=bB0DBVcZUAJSTlQNAFIEAA> in our newsletter system. To change your details and to choose which lists to be subscribed to, visit your personal preferences page <http://mailer.tagorg.com/lists/lt.php?id=bB0DS1dUUE9WClYGBlc> Or you can opt-out completely <http://mailer.tagorg.com/lists/lt.php?id=bB0CS1dUUE9WClYGBlc> from all future mailings. -- powered by phpList, www.phplist.com --

1 0

Host_Quit implementation in wscript
by Thiago Barbato June 27, 2016

June 27, 2016

I tried running a .js with a WScript.Quit() call and noticed it isn't implemented yet in programs/wscript/host.c. Would a simple ExitProcess( ExitCode ) do the job or are there cases where this would be the wrong thing to do?

2 1

Re: [PATCH 4/4] rpcrt4: Added RpcServerRegisterAuthInfoW failure test.
by Marvin June 27, 2016

June 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23875 Your paranoid android. === w864 (32 bit rpc) === rpc.c:815: Test failed: GUID does not appear to contain a MAC address: {6eb1cf99-3c79-11e6-be78-e71666c2e04a} === w864 (64 bit rpc) === rpc.c:815: Test failed: GUID does not appear to contain a MAC address: {f4f8b15d-3c7a-11e6-be78-e71666c2e04a}

1 0

Re: wordpad: Avoid buffer overrun in registry_set_filelist.
by Huw Davies June 27, 2016

June 27, 2016

On Sun, Jun 26, 2016 at 11:42:31AM +0200, Thomas Faber wrote: > From e80a75cfe223a82eea4c55874975e54de4981282 Mon Sep 17 00:00:00 2001 > From: Thomas Faber <thomas.faber(a)reactos.org> > Date: Sun, 26 Jun 2016 10:59:08 +0200 > Subject: wordpad: Avoid buffer overrun in registry_set_filelist. > > Signed-off-by: Thomas Faber <thomas.faber(a)reactos.org> > --- > programs/wordpad/registry.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/programs/wordpad/registry.c b/programs/wordpad/registry.c > index bf2af5b..e047f37 100644 > --- a/programs/wordpad/registry.c > +++ b/programs/wordpad/registry.c > @@ -298,7 +298,7 @@ void registry_set_filelist(LPCWSTR newFile, HWND hMainWnd) > if(!lstrcmpiW(pFiles[i], newFile)) > { > int j; > - for(j = 0; pFiles[j] && j < i; j++) > + for(j = 0; j < i && pFiles[j]; j++) > { > pFiles[i-j] = pFiles[i-j-1]; > } This looks odd to me. I don't see how this could avoid an overflow; pFiles[i] is valid at this point and so pFiles[j] will be ok if j == i. More confusingly though, is why pFiles[j] is in the test at all. Huw.

2 1

Re: d3d9/tests: Use SetRect() instead of open coding it.
by Marvin June 27, 2016

June 27, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23872 Your paranoid android. === w1064 (64 bit device) === device.c:4348: Test failed: cw is 0xf60, expected 0x7f. device.c:4357: Test failed: Callback cw is 0xf60, expected 0x7f.

2 1

Re: [PATCH 7/7] d3drm: Implement IDirect3DRM*::CreateViewport.
by Stefan Dösinger June 27, 2016

June 27, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, rc.top, rc.right, rc.bottom + 1, &viewport2); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + if (FAILED(hr)) > + { > + hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, rc.top, rc.right, rc.bottom, NULL); > + ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got %#x.\n", hr); > + } Afaics the if (FAILED(hr)) isn't necessary here. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcFm2AAoJEN0/YqbEcdMwbewP/11c9oFcbQjek33cW30miUka fO/BIk3qk6xpsz/CMF/DRmwQvqPObSnG5zsAXn4j1hsJM2y3EBRjLeZx1/CqyR9s uQ9JyN85zB2rEDkSpLFNaOIW0hnX7bFFnOmZlIlZPYRH1cqQSJcg5gcAq8EnLeIl ioWW0qK3ZREeRDZXEe0YxuwGqWE+HouUNzS/En9OrlZ9b76zfuRcH2rrGSw+2BPo Az8PzllV8v3Df/HxqYyeG9JxgjWElk2aQGfHP5BPUE/JF5+Ky2xEb6RvHVGJQ64P G/HKJGlKZT/VgQGCbJx6s5bNazBiJSyD4a6dj5IbEbWmnySJIbwW2DNXrcxKT9MO oz0NNyjMQAVkJx45QVvtxm+5QsJIbO6V/38h+zsPW0F6dGrYoqBXXSFbsbp4ge2G S2EC+bJVHsUwc2en52BaqJCRDYLSgxNaD2kL8ovZjLYBVi3jlfTP/OcIXYjam2I7 67b8VEeV7xBILU2uvhFxwpwLIgtVJ1b2QUyH3TjrKfClGu5lbe/VbASsrDjBaJV1 ZZMqcmn1JU/P24wQVWb2gfqN12ktvhEnnYznwz8zw7OKdpOUoKlOXr/06tlrMmei YfuGMZmJyxMJQSsfIVtoFH1HmqlZuk5QUjnjyShYDDf4TlKWZAtn4o4JJbt4n1J0 bOobnKLPsEGKSNhoZbnm =xbZw -----END PGP SIGNATURE-----

2 1

Vacation
by Alexandre Julliard June 25, 2016

June 25, 2016

Folks, I'll be out on vacation next week, so there won't be any commits. Feel free to keep sending patches, I'll try to catch up when I get back, and make the next release on schedule two weeks from now. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] comdlg32: Optimize FILEDLG95_FILENAME_FillFromSelection.
by Henri Verbeet June 25, 2016

June 25, 2016

On 23 June 2016 at 13:29, Lauri Kenttä <lauri.kentta(a)gmail.com> wrote: > This trades some memory for speed, but since currently selecting > 1000 files takes over a minute but the required memory for those > 1000 filenames is only 262 kB (worst case), this seems a reasonable > trade-off. > That's probably fine, but is there any reason this can't use the standard approach of just doubling the buffer size when you run out of space? If this is performance critical code, the multiple copies of the string related to GetName() probably don't help either.

2 1

Re: [PATCH 7/9] d3d11: Implement ID3D11UnorderedAccessView interface.
by Henri Verbeet June 24, 2016

June 24, 2016

On 24 June 2016 at 11:46, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + switch (desc->ViewDimension) > + { > + case D3D11_UAV_DIMENSION_TEXTURE1DARRAY: > + if (desc->u.Texture1DArray.ArraySize == -1 && desc->u.Texture1DArray.FirstArraySlice < layer_count) I noticed too late for the other normalisation functions, but "ArraySize" is unsigned.

2 2

Re: [PATCH 3/9] d3d11: Implement d3d11_immediate_context_OMGetBlendState().
by Henri Verbeet June 24, 2016

June 24, 2016

On 24 June 2016 at 11:45, Józef Kucia <jkucia(a)codeweavers.com> wrote: > @@ -4044,16 +4053,17 @@ static void STDMETHODCALLTYPE d3d10_device_OMGetBlendState(ID3D10Device1 *iface, > ID3D10BlendState **blend_state, FLOAT blend_factor[4], UINT *sample_mask) > { > struct d3d_device *device = impl_from_ID3D10Device(iface); > + ID3D11BlendState *d3d11_blend_state; > + struct d3d_blend_state *object; > > TRACE("iface %p, blend_state %p, blend_factor %p, sample_mask %p.\n", > iface, blend_state, blend_factor, sample_mask); > > - if ((*blend_state = device->blend_state ? (ID3D10BlendState *)&device->blend_state->ID3D10BlendState1_iface : NULL)) > - ID3D10BlendState_AddRef(*blend_state); > - wined3d_mutex_lock(); > - memcpy(blend_factor, device->blend_factor, 4 * sizeof(*blend_factor)); > - *sample_mask = wined3d_device_get_render_state(device->wined3d_device, WINED3D_RS_MULTISAMPLEMASK); > - wined3d_mutex_unlock(); > + d3d11_immediate_context_OMGetBlendState(&device->immediate_context.ID3D11DeviceContext_iface, > + &d3d11_blend_state, blend_factor, sample_mask); > + > + object = unsafe_impl_from_ID3D11BlendState(d3d11_blend_state); Why not just impl_from_ID3D11BlendState() here?

2 4

Re: Andrey Gusev : msvcp120/tests: Fix a typo in ok() message.
by Ken Thomases June 23, 2016

June 23, 2016

On Jun 23, 2016, at 11:15 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > diff --git a/dlls/msvcp120/tests/msvcp120.c b/dlls/msvcp120/tests/msvcp120.c > index 7c94906..354b2d3 100644 > --- a/dlls/msvcp120/tests/msvcp120.c > +++ b/dlls/msvcp120/tests/msvcp120.c > @@ -592,7 +592,7 @@ static void test_xtime_get(void) > diff = p__Xtime_diff_to_millis2(&after, &before); > > ok(diff >= tests[i], > - "xtime_get() not functioning correctly, test: %d, expect: ge %d, got: %d\n", > + "xtime_get() not functioning correctly, test: %d, expect: %d, got: %d\n", > i, tests[i], diff); > } Too late on this one, but I think the "ge" was supposed to mean "greater than or equal to", given the actual test being performed. Probably best to replace it with ">=". -Ken

1 0

Re: kernel32/tests: Fix a typo in skip() message.
by Marvin June 23, 2016

June 23, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23833 Your paranoid android. === w1064 (32 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got ''

1 0

Re: mshtml/tests: Fix a typo in ok() message.
by Michael Stefaniuc June 23, 2016

June 23, 2016

On 06/23/2016 11:56 AM, Andrey Gusev wrote: > > mshtml-tests-Fix-a-typo-in-ok-message.txt > > > From d30dec56bc2f7f716ab786516ee6080c9cdea67f Mon Sep 17 00:00:00 2001 > Message-Id: <d30dec56bc2f7f716ab786516ee6080c9cdea67f.1466675739.git.andrey.goosev(a)gma…> > From: Andrey Gusev <andrey.goosev(a)gmail.com> > Date: Thu, 23 Jun 2016 12:55:21 +0300 > Subject: [PATCH] mshtml/tests: Fix a typo in ok() message. > > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/mshtml/tests/dom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index dce65d5..5c4261e 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -7497,7 +7497,7 @@ static void test_table_elem(IHTMLElement *elem) > VariantClear(&v); > hres = IHTMLTable_get_width(table, &v); > ok(hres == S_OK, "get_width = %08x\n", hres); > - ok(!strcmp_wa(V_BSTR(&v), "40.2%"), "Expected 40.2%%, got %s\n", wine_dbgstr_w(V_BSTR(&v))); > + ok(!strcmp_wa(V_BSTR(&v), "40.2%"), "Expected 40.2%, got %s\n", wine_dbgstr_w(V_BSTR(&v))); That is not a typo, one of this commands would have told you that: - man 3 printf - make bye michael

1 0

Re: mshtml/tests: Allow ParseUrl to clear buffer on Win10
by Marvin June 22, 2016

June 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android. === w1064 (32 bit protocol) === protocol.c:723: Test failed: buf changed === w1064 (64 bit protocol) === protocol.c:723: Test failed: buf changed

1 0

Re: [2/2] advapi32/tests: Allow Win8+ flags for Admins ACE
by Marvin June 22, 2016

June 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23817 Your paranoid android. === w1064 (32 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [1/2] advapi32/tests: Allow MACHINE\Software to be owned by local system
by Marvin June 22, 2016

June 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android. === w864 (32 bit security) === security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: kernel32/tests: Fix a typo
by Marvin June 22, 2016

June 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23815 Your paranoid android. === w1064 (32 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got ''

1 0

Re: apphelp: add SdbGetAppPatchDir stub (try 2)
by Sebastian Lackner June 22, 2016

June 22, 2016

On 22.06.2016 09:23, Austin English wrote: > Using WCHAR * > > Previous try dropped without comment. Fixes > https://bugs.winehq.org/show_bug.cgi?id=35892 > > -- -Austin GPG: 14FB D7EA A041 937B > > > 0001-apphelp-add-SdbGetAppPatchDir-stub.patch > > > From 12b43f471b437309d80bf8625cdc4d518a225c72 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 22 Jun 2016 02:17:19 -0500 > Subject: [PATCH] apphelp: add SdbGetAppPatchDir stub > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/apphelp/apphelp.c | 5 +++++ > dlls/apphelp/apphelp.spec | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/apphelp/apphelp.c b/dlls/apphelp/apphelp.c > index 64dcd87..122642c 100644 > --- a/dlls/apphelp/apphelp.c > +++ b/dlls/apphelp/apphelp.c > @@ -111,3 +111,8 @@ void WINAPI SdbCloseDatabase(PDB pdb) > { > FIXME("stub: %p\n", pdb); > } > + > +void WINAPI SdbGetAppPatchDir(HSDB hsdb, WCHAR *path, DWORD size) > +{ > + FIXME("stub: %p %s %d\n", hsdb, debugstr_w(path), size); Path is an output buffer, it does not make sense to use debugstr_w here. Also, MSDN says "If the function fails, this parameter is set to the empty string ("").". It would probably make sense to implement that, too. > +} > diff --git a/dlls/apphelp/apphelp.spec b/dlls/apphelp/apphelp.spec > index a658e5c..0119a48 100644 > --- a/dlls/apphelp/apphelp.spec > +++ b/dlls/apphelp/apphelp.spec > @@ -49,7 +49,7 @@ > @ stub SdbFreeFileInfo > @ stub SdbFreeFlagInfo > @ stub SdbGetAppCompatDataSize > -@ stub SdbGetAppPatchDir > +@ stdcall SdbGetAppPatchDir(ptr wstr long) HSDB is a handle, so "long" is more appropriate. > @ stub SdbGetBinaryTagData > @ stub SdbGetDatabaseID > @ stub SdbGetDatabaseInformation > -- 2.8.1 > > >

1 0

Re: [PATCH 1/2] include: add wmium.h (try 2) (resend)
by Sebastian Lackner June 22, 2016

June 22, 2016

On 22.06.2016 00:18, Austin English wrote: On the first sight, your patch still contains the same errors I pointed out in my earlier review: https://www.winehq.org/pipermail/wine-devel/2016-June/113414.html Is this really the latest version? Regards, Sebastian

1 0

Re: [v2 PATCH] inetcomm: Implement IMimeBody GetPropInfo
by Alexandre Julliard June 22, 2016

June 22, 2016

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + memset(&info, 0, sizeof(info)); > + hr = IMimeBody_GetPropInfo(body, "Subject", &info); > + ok(hr == S_OK, "ret %08x\n", hr); > + if(hr == S_OK) > + { > + ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags); > + ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags); > + ok(info.ietEncoding == 0, "Invalid encoding %d\n", info.ietEncoding); > + ok(info.dwPropId == 0, "Invalid propid %d\n", info.dwPropId); > + } > + > + memset(&info, 0, sizeof(info)); > + info.dwPropId = 1024; > + info.ietEncoding = 99; > + hr = IMimeBody_GetPropInfo(body, "Subject", &info); > + ok(hr == S_OK, "ret %08x\n", hr); > + if(hr == S_OK) > + { > + ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags); > + ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags); > + ok(info.ietEncoding == 99, "Invalid encoding %d\n", info.ietEncoding); > + ok(info.dwPropId == 1024, "Invalid propid %d\n", info.dwPropId); > + } I still think it would be better to memset with a non-zero value so you can reliably see what has been set. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 4/7] msvcirt: Implement ostream::operator<< for floats
by Piotr Caban June 22, 2016

June 22, 2016

On 06/22/16 11:53, Iván Matellanes wrote: > + str_length += _scprintf(sprintf_fmt, prec, d); /* number representation */ > + if (str_length > 24) { > + /* too long to output */ > + ostream_writepad(ostr, "", ""); Could you please add a test for it? Also a comment saying that this is expected behavior would be useful. > + float param_float[] = {1.0f, 0.0f, 4.25f, 3.999f, 12.0005f, 15.33582f, 15.0f, 15.22f, 21.123f, 0.1f, > + 13.14159f, 0.00013f, 0.000013f, 1.0f / 0.0f, -1.0f / 0.0f, 0.0f / 0.0f}; Please do something similar as in dlls/msvcrt/tests/misc.c to define INFINITY/NAN in tests. Thanks, Piotr

2 2

Re: user32/tests: Avoid using CopyRect().
by Marvin June 22, 2016

June 22, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === w864 (64 bit win) === win.c:8733: Test failed: msg.message = 320

2 1