June 2016 - Wine-Devel - list.winehq.org

Re: [v2 1/7] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban June 22, 2016

June 22, 2016

On 06/22/16 11:53, Iván Matellanes wrote: > + enum { CHAR } type; It's better to avoid using enum values identical as Windows types. It will make it impossible to use CHAR type. Thanks, Piotr

1 0

Re: [v2 3/7] msvcirt: Implement ostream::operator<< for integers
by Piotr Caban June 22, 2016

June 22, 2016

On 06/22/16 11:53, Iván Matellanes wrote: > int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; It causes compilation warning: ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; ^ ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 Thanks, Piotr

1 0

Re: [PATCH 5/5] wined3d: Send query destruction through the command stream.
by Henri Verbeet June 22, 2016

June 22, 2016

On 22 June 2016 at 10:39, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/wined3d/palette.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > The subject should of course read "wined3d: Send palette destruction through the command stream."

1 0

Re: include: Add an inline version of CopyRect() too.
by Alexandre Julliard June 21, 2016

June 21, 2016

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > Around 95 use cases. > No, I do *not* want to do change RECT struct assignments to CopyRect(). Good, but how about changing CopyRect to assignments? ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcrt: Implement _wperror (v2)
by Piotr Caban June 21, 2016

June 21, 2016

On 06/21/16 14:42, Hugh McMaster wrote: > + size = MSVCRT_wcstombs(NULL, str, 0) + 1; > + buffer = MSVCRT_malloc(size); > + if (!buffer) return; > + MSVCRT_wcstombs(buffer, str, size); Please handle MSVCRT_wcstombs failure. Thanks, Piotr

2 2

Re: [2/8] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban June 21, 2016

June 21, 2016

On 06/21/16 11:54, Iván Matellanes wrote: > @@ -2608,8 +2615,7 @@ ostream* __thiscall ostream_print_char(ostream *this, char c) > DEFINE_THISCALL_WRAPPER(ostream_print_unsigned_char, 8) > ostream* __thiscall ostream_print_unsigned_char(ostream *this, unsigned char c) > { > - FIXME("(%p %c) stub\n", this, c); > - return this; > + return ostream_print_char(this, (char) c); > } The cast here is not needed. > + pssb = (strstreambuf*) call_func1(p_strstreambuf_ctor, &ssb); > + ok(pssb == &ssb, "wrong return, expected %p got %p\n", &ssb, pssb); > + pos = (ostream*) call_func3(p_ostream_sb_ctor, &os, (streambuf*) &ssb, TRUE); As well as this ones. Such casts can potentially hide problems otherwise visible during 64-bit compilation. > + pos = (ostream*) call_func2(p_ostream_print_char, &os, (int) tests[i].param.c); break; The cast here is also not needed. Thanks, Piotr

1 0

Re: [7/8] msvcirt: Implement ostream::operator<< for streambuf
by Marvin June 21, 2016

June 21, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23764 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0

Re: [6/8] msvcirt: Implement ostream::operator<< for pointers
by Marvin June 21, 2016

June 21, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23763 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0

Re: [2/8] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban June 21, 2016

June 21, 2016

On 06/21/16 11:54, Iván Matellanes wrote: > + struct ostream_print_test { > + enum { CHAR } type; > + union { > + char c; > + } param; > + ios_io_state state; > + ios_flags flags; > + int precision; > + int fill; > + int width; > + const char *expected_text; > + ios_io_state expected_flags; > + } tests[] = { > + /* char */ > + {CHAR, {.c = 'a'}, IOSTATE_badbit, 0, 6, ' ', 0, "", IOSTATE_badbit|IOSTATE_failbit}, > + {CHAR, {.c = 'a'}, IOSTATE_eofbit, 0, 6, ' ', 0, "", IOSTATE_eofbit|IOSTATE_failbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, ' ', 0, "a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, 'x', 3, "xxa", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_left, 6, ' ', 4, "a ", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_left|FLAGS_internal, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_internal|FLAGS_hex|FLAGS_showbase, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = '9'}, IOSTATE_goodbit, FLAGS_oct|FLAGS_showbase|FLAGS_uppercase, 6, 'i', 2, "i9", IOSTATE_goodbit}, > + {CHAR, {.c = '9'}, IOSTATE_goodbit, FLAGS_showpos|FLAGS_scientific, 0, 'i', 2, "i9", IOSTATE_goodbit}, > + {CHAR, {.c = 'e'}, IOSTATE_goodbit, FLAGS_left|FLAGS_right|FLAGS_uppercase, 0, '*', 8, "e*******", IOSTATE_goodbit} > + }; This is not portable (the {.c = 'a'} part). Thanks, Piotr

1 0

Re: [5/8] msvcirt: Implement ostream::operator<< for floats
by Marvin June 21, 2016

June 21, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23762 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0

Re: msvcrt: Implement _wperror
by Piotr Caban June 21, 2016

June 21, 2016

On 06/21/16 10:09, Hugh McMaster wrote: > dlls/msvcrt/msvcrt.spec | 2 +- > 2 files changed, 36 insertions(+), 1 deletion(-) Please also update other msvc*/ucrtbase spec files as well. > /********************************************************************* > + * _wperror (MSVCRT.@) > + */ > +void CDECL MSVCRT__wperror(const MSVCRT_wchar_t* str) > +{ > + int err, size, len; > + static const WCHAR colon_spaceW[] = {':',' ',0}; > + static const WCHAR newlineW[] = {'\n',0}; > + MSVCRT_wchar_t *buffer = NULL; > + > + err = *MSVCRT__errno(); > + if (err < 0 || err > MSVCRT__sys_nerr) err = MSVCRT__sys_nerr; > + > + size = MultiByteToWideChar(CP_ACP, 0, MSVCRT__sys_errlist[err], -1, NULL, 0) + 1 /* add \n */; > + > + if (str && *str) > + size += lstrlenW(str) + 2; /* add str length, colon and space */ > + > + buffer = MSVCRT_malloc(size * sizeof(MSVCRT_wchar_t)); > + if (!buffer) return; > + > + if (str && *str) > + { > + lstrcpyW(buffer, str); > + lstrcatW(buffer, colon_spaceW); > + } > + else buffer[0] = 0; > + > + len = lstrlenW(buffer); > + MultiByteToWideChar(CP_ACP, 0, MSVCRT__sys_errlist[err], -1, buffer + len, size - len); > + lstrcatW(buffer, newlineW); > + MSVCRT__write(2, buffer, lstrlenW(buffer) * sizeof(MSVCRT_wchar_t)); > + MSVCRT_free(buffer); > +} This is not how the function works. It shouldn't print wchar_t string to stderr. Probably the simplest implementation is to convert input parameter and call _perror (CP_ACP is not the correct encoding, you can use MSVCRT_wcstombs). Thanks, Piotr

2 3

Re: Fix overflow when left-shifting
by Dmitry Timoshkov June 21, 2016

June 21, 2016

Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > Subject: [PATCH] widi: Fix overflow when left-shifting The tool name is 'widl'. -- Dmitry.

1 0

Re: [PATCH v2] jscript: Properly handle arguments in Object constructor.
by Marvin June 20, 2016

June 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23756 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: jscript: Properly handle arguments in Object constructor.
by Marvin June 20, 2016

June 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23747 Your paranoid android. === wxppro (32 bit) === Found no trace of the test summary line or of a crash === w2003std (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (32 bit) === Found no trace of the test summary line or of a crash === w2008s64 (32 bit) === Found no trace of the test summary line or of a crash === w7u (32 bit) === Found no trace of the test summary line or of a crash === w7pro64 (32 bit) === Found no trace of the test summary line or of a crash === w8 (32 bit) === Found no trace of the test summary line or of a crash === w864 (32 bit) === Found no trace of the test summary line or of a crash === w1064 (32 bit) === Found no trace of the test summary line or of a crash === wvistau64 (64 bit) === Found no trace of the test summary line or of a crash === w2008s64 (64 bit) === Found no trace of the test summary line or of a crash === w7pro64 (64 bit) === Found no trace of the test summary line or of a crash === w864 (64 bit) === Found no trace of the test summary line or of a crash === w1064 (64 bit) === Found no trace of the test summary line or of a crash

1 0

Re: [PATCH 1/2] winex11: fix gl drawable type
by Alexandre Julliard June 20, 2016

June 20, 2016

Miklós Máté <mtmkls(a)gmail.com> writes: > @@ -1344,7 +1344,7 @@ static BOOL create_gl_drawable( HWND hwnd, struct gl_drawable *gl ) > > if (data) > { > - gl->type = DC_GL_WINDOW; > + gl->type = DC_GL_CHILD_WIN; This can't possibly work, top-level windows and child windows have to be treated differently. -- Alexandre Julliard julliard(a)winehq.org

2 2

Images in MyHeritage Family Tree Builder
by Stephen Davies June 20, 2016

June 20, 2016

I am running WINE 1.9.11 (Staging) under Fedora 22. I have been running the MyHeritage Family Tree Builder V7 product on this box for several years without issue but recently (last month perhaps), FTB is no longer able to display JPEG photographs. The JPEG files exist in the relevant directory but they all display as blank images. FTB has not changed but there have been numerous updates to F22 and to WINE suggesting that this may be the cause. Can anybody throw any light on what may have happened? Cheers and thanks, Stephen

3 4

Re: comctl32/tests: Use EqualRect() instead of memcmp() to compare RECTs.
by Marvin June 20, 2016

June 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23734 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: d3d8/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin June 20, 2016

June 20, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23732 Your paranoid android. === w8 (32 bit device) === device.c:1372: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1417: Test failed: Reset failed, hr 0x88760868. device.c:1419: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1423: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1430: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1431: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1432: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1433: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1434: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1435: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1440: Test failed: Screen width is 640, expected 800. device.c:1441: Test failed: Screen height is 480, expected 600. device.c:1447: Test failed: Back buffer width is 640, expected 800. device.c:1449: Test failed: Back buffer height is 480, expected 600. device.c:1479: Test failed: Screen width is 640, expected 1024. device.c:1480: Test failed: Screen height is 480, expected 768. device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480. === w864 (32 bit device) === device.c:7573: Test failed: Got unexpected hr 0. device.c:7575: Test failed: Got unexpected hr 0. === w1064 (32 bit device) === device.c:2725: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2730: Test failed: The focus window is active. device.c:2738: Test failed: Got unexpected hr 0x88760869. device.c:2742: Test failed: Got unexpect screen size 800x600. device.c:2757: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2766: Test failed: Got unexpect screen size 800x600. device.c:2779: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2787: Test failed: Got unexpect width 640. device.c:2788: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 2/5] d3drm: Add stubs for IDirect3DRMFrame interface. (v5)
by Henri Verbeet June 20, 2016

June 20, 2016

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > +static HRESULT WINAPI d3drm_frame1_AddChild(IDirect3DRMFrame *iface, IDirect3DRMFrame *child) > +{ > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface); > + struct d3drm_frame *child_frame = unsafe_impl_from_IDirect3DRMFrame(child); > + > + TRACE("iface %p, child %p.\n", iface, child); > + > + if (!child_frame) > + return D3DRMERR_BADOBJECT; That's redundant, d3drm_frame3_AddChild() already takes care of that.

2 6

Re: [PATCH] msi: allocate correct buffer size (Coverity)
by Hans Leidekker June 20, 2016

June 20, 2016

On Sat, 2016-06-18 at 10:02 +0200, Marcus Meissner wrote: > 713180 Out-of-bounds access > 713179 Out-of-bounds access > > We pass in a size of 1 character more to MBtoWC than we allocated earlier. No, Coverity doesn't see that MsiEnumComponentsExW and MsiEnumProductsExW return size excluding the terminating null.

1 0

Re: ws2_32: Ensure default route IP addresses are returned first in gethostbyname
by Marvin June 19, 2016

June 19, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23725 Your paranoid android. === w7pro64 (64 bit sock) === sock.c:7738: Test failed: bytesReturned isn't supposed to be 1 sock.c:7784: Test failed: Waiting for timeout failed with 0 + errno 997

1 0

Re: [PATCH 5/5] d3drm/tests: Modify all QI tests to compare vtables. (resend)
by Henri Verbeet June 19, 2016

June 19, 2016

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > + { &IID_IUnknown, &IID_IUnknown, NULL, S_OK }, Is the NULL "vtable_iid" here intentional?

2 2

WineConf 2016
by Michael Stefaniuc June 19, 2016

June 19, 2016

Hello guys, it's that time of the year again where we start thinking about the next WineConf. Last year would already have been the turn for North America so the next WineConf will happen definitely there. Jeremy White / CodeWeavers, as always, was very generous and offered to host it in Minneapolis (or was it St. Paul? ;). But if you're in US / Canada and really hoped to host the next WineConf now is your time to speak up! The Twin Cities are beautiful at -30 C but we wouldn't mind seeing other places too. bye michael

4 4

Re: [PATCH 4/5] d3drm: Fix viewport object creation. (resend)
by Henri Verbeet June 19, 2016

June 19, 2016

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > @@ -861,10 +863,19 @@ static HRESULT WINAPI d3drm2_CreateShadow(IDirect3DRM2 *iface, IDirect3DRMVisual > FIXME("iface %p, device %p, camera %p, x %u, y %u, width %u, height %u, viewport %p partial stub!\n", > - iface, device, camera, x, y, width, height, viewport); > + iface, device, camera, x, y, width, height, viewport); I thought that was fine the way it was. > -HRESULT Direct3DRMViewport_create(REFIID riid, IUnknown **out) > +HRESULT d3drm_viewport_create(struct d3drm_viewport **viewport, IDirect3DRM *d3drm) > { > struct d3drm_viewport *object; > > - TRACE("riid %s, out %p.\n", debugstr_guid(riid), out); > + TRACE("out %p, d3drm %p.\n", viewport, d3drm); "viewport"

1 0

Re: [PATCH 3/5] d3drm: Fix frame object creation method. (v3 resend)
by Henri Verbeet June 19, 2016

June 19, 2016

On 19 June 2016 at 00:29, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote: > diff --git a/dlls/d3drm/d3drm_private.h b/dlls/d3drm/d3drm_private.h > index 817accf..1f4094b 100644 > --- a/dlls/d3drm/d3drm_private.h > +++ b/dlls/d3drm/d3drm_private.h > @@ -44,6 +44,27 @@ struct d3drm_texture > D3DRMIMAGE *image; > }; > > +struct d3drm_frame > +{ > + IDirect3DRMFrame IDirect3DRMFrame_iface; > + IDirect3DRMFrame2 IDirect3DRMFrame2_iface; > + IDirect3DRMFrame3 IDirect3DRMFrame3_iface; > + IDirect3DRM *d3drm; > + LONG ref; > + struct d3drm_frame *parent; > + ULONG nb_children; > + ULONG children_capacity; > + IDirect3DRMFrame3** children; > + ULONG nb_visuals; > + ULONG visuals_capacity; > + IDirect3DRMVisual** visuals; > + ULONG nb_lights; > + ULONG lights_capacity; > + IDirect3DRMLight** lights; > + D3DRMMATRIX4D transform; > + D3DCOLOR scenebackground; > +}; "IDirect3DRMFrame3 **children", "IDirect3DRMVisual **visuals" and "IDirect3DRMLight **lights". > @@ -51,11 +72,11 @@ void d3drm_object_cleanup(IDirect3DRMObject *iface, struct d3drm_object *object) > > HRESULT d3drm_device_create(struct d3drm_device **out) DECLSPEC_HIDDEN; > HRESULT d3drm_texture_create(struct d3drm_texture **texture, IDirect3DRM *d3drm) DECLSPEC_HIDDEN; > +HRESULT d3drm_frame_create(struct d3drm_frame **frame, IUnknown* parent_frame, IDirect3DRM *d3drm) DECLSPEC_HIDDEN; "IUnknown *parent_frame". > -HRESULT Direct3DRMFrame_create(REFIID riid, IUnknown *parent, IUnknown **out) > +HRESULT d3drm_frame_create(struct d3drm_frame **frame, IUnknown* parent_frame, IDirect3DRM *d3drm) Like above. > { > struct d3drm_frame *object; > - HRESULT hr; > + HRESULT hr = D3DRM_OK; > > - TRACE("riid %s, parent %p, out %p.\n", debugstr_guid(riid), parent, out); > + TRACE("out %p, parent_frame %p, d3drm %p.\n", frame, parent_frame, d3drm); "frame" instead of "out". > + if (parent_frame) > { > IDirect3DRMFrame3 *p; > > - hr = IDirect3DRMFrame_QueryInterface(parent, &IID_IDirect3DRMFrame3, (void**)&p); > + hr = IDirect3DRMFrame_QueryInterface(parent_frame, &IID_IDirect3DRMFrame3, (void**)&p); > if (hr != S_OK) "if (FAILED(hr = ...))" and "(void **)".

1 0