June 2016 - Wine-Devel - list.winehq.org

Re: [v3 1/4] winejoystick.drv/joystick_osx.c: fixes Ry/Rx -> U/V axes mapping
by Alex Henrie June 13, 2016

June 13, 2016

> Signed-off-by: David Lawrie david.dljunk(a)gmail.com This line is incorrectly formatted. Please use the format with angle brackets generated by `git commit -s`. See https://wiki.winehq.org/Submitting_Patches#The_commit_message for an example. -Alex

2 1

Re: [PATCH] comctl32: isolate condition to avoid compiler warnings.
by Nikolay Sivov June 13, 2016

June 13, 2016

On 13.06.2016 4:53, Hadrien Boizard wrote: > Hi Nikolay, > > I'm using gcc 6.1.1 and I'm getting "-Wmisleading-indentation" warnings. > > I didn't notice when I sent the patch but there's an indent that I > didn't mean to be there. > It's weird because on my file, it looks like that : >> if (len == -1) goto end; >> buf += len; size -= len; > > Perhaps this format would be more appropriate : >> if (len == -1) >> goto end; >> buf += len; size -= len; > > > Is there a problem with this version of gcc ? > Should I try resending the patch with either of these 2 solutions ? Personally I don't think code needs fixing just to silence this warning. But if we care, looks like it's enough to have everything after 'goto end;' on a separate line, indented with spaces. > > > > 2016-06-12 21:46 GMT+02:00 Nikolay Sivov <bunglehead(a)gmail.com > <mailto:bunglehead(a)gmail.com>>: > > Hi, Hadrien. > > What is the compiler you're testing with and what kind of warnings do > you see? Is it misleading indentation from gcc 6 by any chance? > > > - if (len == -1) goto end; buf += len; size -= len; > > + if (len == -1) goto end; > > + buf += len; size -= len; > > Reformatting it like that is even more misleading. > >

1 0

Re: [PATCH 1/3] d3drm: Add stubs for IDirect3DRMFrame interface. (v2)
by Stefan Dösinger June 12, 2016

June 12, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, On the big picture this code is a copypaste of the frame2 -> frame3 thunks. There's nothing wrong with that on its own, but unfortunately the frame2 -> frame3 thunks have a number of issues. In particular some thunks are not trivial, e.g. AddVisual, which accepts a IDirect3DRMVisual in one version and an IUnknown in another. Or GetChildren - which interface is added in to the Children array? I think we had that discussion with other interfaces in the past - implement thunks for everything or implement thunks for the implemented frame3 functions only and make the others return an error. Judging from the existing code we decided on the latter option for IDirect3DRM* . I would suggest to make all frame1 functions return E_NOTIMPL in the first patch (except IUnknown), then implement the thunks that have sufficient existing tests (adding tests for version 1 in the same patches) and then add the rest of the thunks as you implement the version 3 function. That way you won't be blocked by discussions about thunks that aren't relevant to you yet. Am 2016-06-09 um 23:18 schrieb Aaryaman Vasishta: > +static HRESULT WINAPI d3drm_frame1_AddChild(IDirect3DRMFrame *iface, IDirect3DRMFrame *child) > +{ > + struct d3drm_frame *frame = impl_from_IDirect3DRMFrame(iface); > + IDirect3DRMFrame3 *child3; > + HRESULT hr; > + > + TRACE("iface %p, child %p.\n", iface, child); > + > + if (!child) > + return D3DRMERR_BADOBJECT; > + hr = IDirect3DRMFrame_QueryInterface(child, &IID_IDirect3DRMFrame3, (void **)&child3); > + if (hr != S_OK) > + return D3DRMERR_BADOBJECT; > + IDirect3DRMFrame_Release(child); > + > + return IDirect3DRMFrame3_AddChild(&frame->IDirect3DRMFrame3_iface, child3); > +} This doesn't seem right. Right now you're releasing a reference you don't own (child's frame1) and leak one (child's frame3). Is there a reason why you're using QueryInterface instead of accessing child->IDirect3DRMFrame3_iface? If you stick to QI I think this should be more like this (error checking excluded): QI(child, IID_child3, &child3); hr = Frame3_AddChild(frame, child3); IDirect3DRMFrame3_Release(child3); d3drm_frame2_AddChild has the same problem, this is where your code seems to come from. > + hr = IDirect3DRM_CreateFrame(d3drm1, NULL, &frame1); > + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMFrame interface (hr = %#x).\n", hr); > + > + hr = IDirect3DRMFrame_QueryInterface(frame1, &IID_IDirect3DRMObject, (void **)&obj); > + ok(SUCCEEDED(hr), "Could not get IDirect3DRMObject interface (hr = %#x).\n", hr); > + ok(obj == (IDirect3DRMObject *)frame1, "got object pointer %p, expected %p", obj, frame1); > + IDirect3DRMObject_Release(obj); > + IDirect3DRMFrame_Release(frame1); What's missing here is a test that frame1 != frame2 != frame3 and frame1 == visual and frame1 == IUnknown (I guess that one will be false). You could also consider making this and patch use the same kind of table as e.g. the IDirect3DRM tests. That would keep the tests for various interfaces similar to each other. On the other hand because there's only one refcount (thanks to aggregation support) I am fine with a smaller test for refcounts. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXXXYCAAoJEN0/YqbEcdMwFdcP/3D9Ldet3j2QS14fCOjsuamK bVzdTzr+WuYZlYAp6MUyiZUFCSy+tb8f8C1LO6wuxmuaJmgNzFXB4j+s7fUzH/PQ bljIsEOc0aDYRDrMLekxa86MaK25xfHFOsj7ixM72NZsCaRVsUpq9y993LNVRAEN cUazAn3SQWSQVXD97mZa1/4MjGExfKR6Sw932f5WOeUGoZRSAFUxZ1hlOKS7HJbp qIweKka1D8lz+DgJGpsVkSJqDUw4+uHhKlBPPcu5RDjgzzTefuk3k53I4ntasrY6 611gv+xkmo32cfewPcte0b+ttA5MW/DXyTrXWAhffrZ+kFpB327HusbdD3Wa+O2S yOvbPBPTbWwTr1wGaIvD6QB2MSEsBQLLVnB73gMO8Ref0yY+Q4ujV/2IITyFjRzB lJz3821uSB+RFyfBKgS7KN81KBs35a7OsfQi7EwyuUQtwXY0NuEF/s48D7dHMJdO fLeRv928WqYY+hmXkj4gQZD8mmEzjEGyT1PqAum/EJcr9tOzEXWbhwlKrgL9f0k9 g/u2WQh+OtwvAcueIWZaRgxNZZjsi6xi15Dnjwi7OSW5s19PCg5/g1qgyCA4nVCb jb9AHJX6HxhnGGGej5NTUw+uCW83y3ons9DV2s9lRprIFt58v5mb1tELO7TBFAGa VqA7RDllo5Zh3jOnYKyB =ll6/ -----END PGP SIGNATURE-----

2 3

Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support
by Hugh McMaster June 12, 2016

June 12, 2016

On Friday, 10 June 2016 4:11 PM, David Lawrie wrote: > This patch fixes Slider and Ry/Rx axes mapping and adds support for > general multi-axis controllers (up to 6-axis controllers), steering > wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3), > rudder pedals, and throttles. > > Tested on OS X 10.10.5 > > Signed-off-by: David Lawrie david.dljunk(a)gmail.com > --- > dlls/winejoystick.drv/joystick_osx.c | 171 ++++++++++++++++++++++++----------- > 1 file changed, 119 insertions(+), 52 deletions(-) Hi David, Your patch contains a mixture of tab and space indentation. The tabs, in particular, make the lines long and difficult to read. Please resubmit your patch using four spaces for each level of indentation. -- Hugh McMaster

2 2

Re: [PATCH] comctl32: isolate condition to avoid compiler warnings.
by Nikolay Sivov June 12, 2016

June 12, 2016

Hi, Hadrien. What is the compiler you're testing with and what kind of warnings do you see? Is it misleading indentation from gcc 6 by any chance? > - if (len == -1) goto end; buf += len; size -= len; > + if (len == -1) goto end; > + buf += len; size -= len; Reformatting it like that is even more misleading.

1 0

Questions about Wine explorer.exe desktop work
by Joel Holdsworth June 12, 2016

June 12, 2016

Dear All, I've been watching AJ's work on improving wine when running in desktop mode with respect to the task bar and start menu. I was wondering what the motivation for this work was? but it's a cool feature whatever the reason. I'm also interested in the work the ReactOS guys have been doing on reactos and shell32. To my understanding, in the last couple of years, the reactos team have expended quite some effort to faithfully replicate the behavior of shell32+explorer as seen in XP and Server 2003. This diagram shows how all the undocumented shell32 COM objects fit together: https://www.reactos.org/node/780 I was interested to see if reactos explorer.exe could run in wine, and it fails because it doesn't have the undocumented shell32 StartMenu or TaskBar COM objects. Look at AJ's patches it looks like Wine's start menu and task bar are being done in an ad-hoc way in explorer.exe; not trying to replicate shell32 COM objects. According to this document: https://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?vie… , it seems that reactos forked shell32 in 2007. And from browsing the code, it seems a lot of it is now written in C++. It would be cool if the reactos could be moved off their fork back onto wine's version, but it seems like their shell32 might be ahead of wine's in some places. I wanted to ask suggest/ask if it would be a good idea to import or base-off-of the ROS shell32 code, convert it to C and use that for the new desktop code? It seems to me that the architecture would more closely match windows, so the ROS and Microsoft explorer.exe would then run on Wine. Also this would move us towards having the ROS and Wine explorer.exe and shell32 merged - and the ROS guys seem to care quite a lot about that stuff, so it would be good to unite the two project's efforts. Best Regards Joel Holdsworth

2 1

Re: [v2 0/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support
by Alexandre Julliard June 11, 2016

June 11, 2016

David Lawrie <david.dljunk(a)gmail.com> writes: > This patch fixes Slider and Ry/Rx axes mapping and adds support for > general multi-axis controllers (up to 6-axis controllers), steering > wheels w/ accelerators/brakes, multiple sliders/dials/wheels (up to 3), > rudder pedals, and throttles. > > Fixes: > 1) Slider now maps to Z, U, or V depending on availability > 2) Ry now maps to U > 3) Rx now maps to V > > Windows defines Winmm U as Dinput Ry and V as Dinput Rx. Original joystick_osx.c mapping was other way around. This is also a bug in the Linux Winmm joystick version (not fixed with this patch). Sliders are supposed to map to the Z-axis (or U/V axes if Z is taken). > > Adds: > > 1) Driver will find Multi-axis controller type in addition to gamepad and joystick > > 2a) In function collect_joystick_elements, under Generic Desktop page, patch adds support for multiple Sliders, Dials, and Wheels up to 3. First Slider/Dial/Wheel maps to Z, Second -> U, Third -> V. > > 2b) Patch also adds support for controller features defined by HID Simulation page: Rudder (Rz), Throttle (Z), Steering (X), Accelerator (Y), Brake (Rz). Looks good, but please send separate fixes as separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/1] winejoystick.drv/joystick_osx.c: fixed axes mapping, add feature support
by DavidL June 10, 2016

June 10, 2016

Hi, I recently submitted a patch which had at least one whitespace formatting issue. Looking over it, I found one on line 518, a bracket in the wrong place. Is there an easy way for me to check if there are more formatting issues before resubmitting? Or should I simply resubmit? Thanks! David On Fri, Jun 10, 2016 at 7:06 AM, Marvin <testbot(a)winehq.org> wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Formatting". > > This means that there are some formatting issues with your > patch. Either the author's full name, email address, or Signed-off-by > headers are missing, indentation is messed up (usually from editing > with a non-standard tab size), or there are gratuitous formatting > changes to the code. You need to resend a fixed patch. > > If you do not understand the reason for this status, disagree with our > assessment, or are simply not sure how to proceed next, please ask for > clarification by replying to this email. >

2 1

Re: ucrtbase: Add __fpe_flt_rounds implementation
by Marvin June 10, 2016

June 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23515 Your paranoid android. === wxppro (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w2003std (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === wvistau64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w2008s64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w7u (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w7pro64 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w8 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === w864 (32 bit misc) === misc: unhandled exception c0000005 at 00000000 === wvistau64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w2008s64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w7pro64 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w864 (64 bit misc) === misc: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit misc) === misc.c:233: Test failed: __fpe_flt_rounds returned 3 misc.c:237: Test failed: __fpe_flt_rounds returned 2

1 0

Re: [PATCH v2] secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin June 10, 2016

June 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23510 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:856: Test failed: Got unexpected status 0x80090308. schannel.c:864: Test failed: Got unexpected status 0x80090308.

1 0

Re: [PATCH 3/3] msscript: Implement Language() property
by Jacek Caban June 10, 2016

June 10, 2016

Hi Nikolay, On 06/09/2016 07:40 PM, Nikolay Sivov wrote: > static HRESULT WINAPI ScriptControl_put_Language(IScriptControl *iface, BSTR language) > { > ScriptControl *This = impl_from_IScriptControl(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_w(language)); > - return E_NOTIMPL; > + > + TRACE("(%p)->(%s)\n", This, debugstr_w(language)); > + > + if (!lstrcmpiW(language, vbscriptW)) > + This->language = LANGUAGE_VBSCRIPT; > + else if (!lstrcmpiW(language, jscriptW)) > + This->language = LANGUAGE_JSCRIPT; > + else if (!language) > + This->language = LANGUAGE_UNDEFINED; > + else > + return CTL_E_INVALIDPROPERTYVALUE; Are you sure it's limited to those two languages? It counters the point of active script technology. I don't see why it couldn't handle other registered languages. See register_script_engine from MSHTML script.c tests to see how additional languages may be added. Thanks, Jacek

1 0

Re: secur32/tests: Don't load advapi32.dll function dynamically.
by Marvin June 10, 2016

June 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23509 Your paranoid android. === w1064 (32 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308. === w1064 (64 bit schannel) === schannel.c:854: Test failed: Got unexpected status 0x80090308. schannel.c:862: Test failed: Got unexpected status 0x80090308.

1 0

Re: d3d9/tests: Use wine_dbgstr_rect() to print RECTs.
by Marvin June 10, 2016

June 10, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23495 Your paranoid android. === w864 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4351: Test failed: cw is 0xf60, expected 0x7f. device.c:4360: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (32 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1. === w1064 (64 bit d3d9ex) === d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=0. d3d9ex.c:2351: Test failed: Got unexpected hr 0, i=1. d3d9ex.c:2353: Test failed: Got unexpected hr 0, i=1.

2 1

Re: [PATCH 5/5] usp10: Replace zero-width glyphs with 0x20 when psa->fNoGlyphIndex is set in ScriptShapeOpenType().
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23487 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 4/5] usp10: Replace more control characters with blanks.
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23486 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 3/5] usp10: Don't replace control characters with blanks when psa->fNoGlyphIndex is set.
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23485 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 2/5] usp10: Don't modify psa->fNoGlyphIndex in ScriptShapeOpenType().
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23484 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: [PATCH 1/5] usp10: Set fZeroWidth when replacing control characters with blanks.
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23483 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1) === w1064 (64 bit usp10) === usp10.c:1467: Test failed: 0: uJustification incorrect (0) usp10.c:1467: Test failed: 1: uJustification incorrect (0) usp10.c:1467: Test failed: 2: uJustification incorrect (0) usp10.c:1467: Test failed: 3: uJustification incorrect (0) usp10.c:1467: Test failed: 4: uJustification incorrect (0) usp10.c:1467: Test failed: 5: uJustification incorrect (0) usp10.c:1467: Test failed: 6: uJustification incorrect (0) usp10.c:1467: Test failed: 7: uJustification incorrect (0) usp10.c:1467: Test failed: 8: uJustification incorrect (0) usp10.c:1467: Test failed: 9: uJustification incorrect (0) usp10.c:1483: Test failed: 3: uJustification incorrect (0) usp10.c:1483: Test failed: 5: fDiacritic incorrect (1) usp10.c:1483: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1483: Test failed: 15: fDiacritic incorrect (1) usp10.c:1483: Test failed: 15: fZeroWidth incorrect (1)

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.
by Marvin June 9, 2016

June 9, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23462 Your paranoid android. === w864 (32 bit ddraw7) === ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw7) === ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw7) === ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

3 3

Re: ddraw/tests: Finish the move to use wine_dbgstr_rect().
by Henri Verbeet June 9, 2016

June 9, 2016

On 8 June 2016 at 22:38, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > Though this is more likely one of those "to be fixed by moving to > ddraw[1247].c... I'm afraid so. > I did check and there are set_display_mode() tests in those files > already. They look different but parts seem to be the same. > So something for somebody that knows that code. > For what it's worth, note that setdisplaymode() is only called by testdisplaymodes(), which is guarded by "if (winetest_interactive)". Practically speaking, that means I've run that test twice in the past 10 years, one of which was today. It fails with "ddrawmodes.c:576: Test succeeded inside todo block: Fullscreen window has wrong size", so I doubt a lot of other people are running this regularly either.

1 0

Re: [PATCH 2/4] d3drm: Fix frame object creation method.
by André Hentschel June 9, 2016

June 9, 2016

Am 08.06.2016 um 23:49 schrieb Aaryaman Vasishta: > There is a warning generated while compiling this. It's because IDirect3DRMFrame stubs aren't in yet. I'll be adding them next patch. > > Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> > --- Hi Aaryaman, You should rather not send patches which generate Warnings at compile/link time...

3 3

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw4 tests.
by Marvin June 8, 2016

June 8, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23461 Your paranoid android. === w864 (32 bit ddraw4) === ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw4) === ddraw4.c:2540: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw4) === ddraw4.c:2540: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw4.c:7999: Test failed: Got unexpected P8 color key blit result.

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw2 tests.
by Marvin June 8, 2016

June 8, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23460 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw2) === ddraw2.c:2355: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw2) === ddraw2.c:2355: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw2.c:6472: Test failed: Got unexpected P8 color key blit result.

1 0

Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw1 tests.
by Marvin June 8, 2016

June 8, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23459 Your paranoid android. === w864 (32 bit ddraw1) === ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result. === w1064 (32 bit ddraw1) === ddraw1.c:2204: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result. === w1064 (64 bit ddraw1) === ddraw1.c:2204: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768). ddraw1.c:5415: Test failed: Got unexpected P8 color key blit result.

1 0

Re: [PATCH 2/2 v3] server: Generate mouse move message when window position is changed
by Marvin June 8, 2016

June 8, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23454 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6717: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6719: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:7065: Test failed: WmParentPaint: 2: the msg sequence is not complete: expected 0000 - actual 001a msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different

1 0