June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] shell32: fix out of memory errors and their underlying cause
by Nikolay Sivov June 4, 2016

June 4, 2016

Thanks. Could you please also fix buffer and 'assoc' leaks in the same patch?

1 0

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap
by Vincent Povirk June 4, 2016

June 4, 2016

We'll need it when we implement adjustable arrow caps. On Jun 3, 2016 8:34 PM, "Ken Thomases" <ken(a)codeweavers.com> wrote: On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

1 0

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap
by Ken Thomases June 4, 2016

June 4, 2016

On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

1 0

Re: mmdevapi/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23320 Your paranoid android. === w7u (32 bit capture) === capture.c:181: Test failed: Position 375 expected 0 capture.c:231: Test failed: Position 1719 expected 823 capture.c:263: Test failed: Position 1719 expected 823 capture.c:325: Test failed: Position 3063 gap 1792 capture.c:329: Test failed: GCP 11200 vs. BufferSize 21996 capture.c:349: Test failed: Position 4407 expected 3511 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5751 expected 3959 capture.c:375: Test failed: flags 1 === w8 (32 bit capture) === capture.c:325: Test failed: Position 3191 gap 1216 capture.c:349: Test failed: Position 4279 expected 3639 capture.c:374: Test failed: Position 5303 expected 4087 === w864 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:263: Test failed: Position 2167 expected 1527 capture.c:325: Test failed: Position 3127 gap 1152 capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:349: Test failed: Position 4215 expected 3575 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5303 expected 4023 capture.c:375: Test failed: flags 1 === w1064 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:263: Test failed: Position 2167 expected 1527 capture.c:325: Test failed: Position 4151 gap 2176 capture.c:329: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4599 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5687 expected 5047 === w864 (64 bit capture) === capture.c:181: Test failed: Position 119 expected 0 capture.c:231: Test failed: Position 2167 expected 567 capture.c:263: Test failed: Position 2167 expected 567 capture.c:325: Test failed: Position 3191 gap 2176 capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:349: Test failed: Position 4279 expected 3639 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 4727 expected 4087 === w1064 (64 bit capture) === capture.c:181: Test failed: Position 1143 expected 0 capture.c:231: Test failed: Position 2167 expected 1591 capture.c:263: Test failed: Position 2167 expected 1591 capture.c:325: Test failed: Position 4215 gap 2176 capture.c:329: Test failed: GCP 13440 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4663 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5687 expected 5111

1 0

Re: [PATCH 2/2] msvcr120/tests: Add critical section test.
by Piotr Caban June 3, 2016

June 3, 2016

Hi, something strange happened while sending this patch. It was sent by me. Sorry for that. Piotr On 06/03/16 14:36, YongHao Hu wrote: > From: YongHao Hu <christopherwuy(a)gmail.com> > > This patch supersedes 122410. > > Signed-off-by: YongHao Hu <christopherwuy(a)gmail.com> > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/msvcr120/tests/msvcr120.c | 251 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 251 insertions(+) > > > > >

1 0

Re: [PATCH] wined3d : Set texture target of WINED3DFMT_NULL to 0
by Henri Verbeet June 3, 2016

June 3, 2016

On 2 June 2016 at 07:39, Max Qian <public(a)maxqia.com> wrote: > This fixes https://bugs.winehq.org/show_bug.cgi?id=40624 > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > dlls/wined3d/context.c | 4 ++-- > dlls/wined3d/wined3d_private.h | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > The patch got wrapped, please use git send-email for submitting patches. Regardless, I don't think this is an improvement over Józef's patch. (Which I think would be fine for fixing the regression, even if we want to improve the way WINED3DFMT_NULL is handled in general.)

1 0

Re: user32/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23303 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:10057: Test failed: SendMessageTimeout succeeded msg.c:10058: Test failed: WmEmptySeq: 0: the msg sequence is not complete: expected 0000 - actual 0400 === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:7440: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a

1 0

Re: urlmon/tests: Fix a typo in ok() message
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23302 Your paranoid android. === w1064 (32 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon" === w1064 (64 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon"

1 0

Re: kernel32/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23301 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: hlink/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23300 Your paranoid android. === w1064 (32 bit hlink) === hlink.c:414: Test failed: url only: Saved data differs hlink.c:414: Test failed: url + friendly name: Saved data differs hlink.c:414: Test failed: url + friendly_name + location: Saved data differs hlink.c:414: Test failed: url + target frame name: Saved data differs === w1064 (64 bit hlink) === hlink.c:414: Test failed: url only: Saved data differs hlink.c:414: Test failed: url + friendly name: Saved data differs hlink.c:414: Test failed: url + friendly_name + location: Saved data differs hlink.c:414: Test failed: url + target frame name: Saved data differs

1 0

Re: [PATCH] Tell dosbox to read the current user's config
by Austin English June 3, 2016

June 3, 2016

On Wed, Jun 1, 2016 at 8:46 PM, shankao(a)gmail.com <shankao(a)gmail.com> wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=40380 Hi, Thanks for the patch, but please see https://wiki.winehq.org/Submitting_Patches for how to submit a patch (sorry for not linking originally). In particular, you need a real name on the patch and to add a sign-off. -- -Austin

4 8

Re: [PATCH 5/5] wined3d: User clip planes emulation for core profile contexts.
by Henri Verbeet June 2, 2016

June 2, 2016

On 1 June 2016 at 23:16, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + if (update_mask & WINED3D_SHADER_CONST_VS_CLIP_PLANES) > + { > + for (i = 0; i < gl_info->limits.clipplanes; ++i) > + shader_glsl_clip_plane_uniform(context, state, i, prog); > + } It's not wrong, but it seems somewhat arbitrary to use the legacy/fixed function clip plane limit.

2 1

Re: [PATCH] d3dx9_36: Stop crash when displaying effect errors
by Matteo Bruni June 2, 2016

June 2, 2016

2016-06-01 12:18 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/d3dx9_36/effect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c > index 7772406..a72aa3a 100644 > --- a/dlls/d3dx9_36/effect.c > +++ b/dlls/d3dx9_36/effect.c > @@ -5969,7 +5969,7 @@ static HRESULT d3dx9_base_effect_init(struct d3dx9_base_effect *base, > if (bytecode) > ID3D10Blob_Release(bytecode); > if (temp_errors) > - TRACE("%s\n", (char *)ID3D10Blob_GetBufferPointer(temp_errors)); > + TRACE("%s\n", debugstr_a((char *)ID3D10Blob_GetBufferPointer(temp_errors))); > if (errors) > *errors = temp_errors; > else if (temp_errors) > -- > 2.8.1 What effect / application is crashing because of this and what are the errors?

2 2

Re: [PATCH 1/5] wined3d: Fix FFP vertex shaders with ARB_explicit_attrib_location.
by Józef Kucia June 1, 2016

June 1, 2016

On Wed, Jun 1, 2016 at 11:16 PM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > dlls/wined3d/glsl_shader.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c > index e5a0e69..4e773b6 100644 > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > @@ -6363,10 +6363,15 @@ static GLuint shader_glsl_generate_ffp_vertex_shader(struct shader_glsl_priv *pr > > shader_addline(buffer, "%s\n", shader_glsl_get_version(gl_info, NULL)); > > + if (shader_glsl_use_explicit_attrib_location(gl_info)) > + shader_addline(buffer, "#extension GL_ARB_explicit_attrib_location : enable\n"); > + > for (i = 0; i < WINED3D_FFP_ATTRIBS_COUNT; ++i) > { > const char *type = i < ARRAY_SIZE(attrib_info) ? attrib_info[i].type : "vec4"; > > + if (shader_glsl_use_explicit_attrib_location(gl_info)) > + shader_addline(buffer, "layout(location = %u) ", i); > shader_addline(buffer, "%s %s vs_in%u;\n", get_attribute_keyword(gl_info), type, i); > } > shader_addline(buffer, "\n"); > -- > 2.7.3 > > > I am not sure how I missed this... Thanks!

2 1

Re: [v2] setupapi: Add stub for setupapi.dll.CM_Get_DevNode_Status
by André Hentschel June 1, 2016

June 1, 2016

Hi Bob, Am 01.06.2016 um 22:22 schrieb Bob Wya: > Hi André, > > I've resubmitted the patch as you suggested (v2). Sorry after re-submitting it I realised I should have cc'd you in. Hopefully I've read the MSDN docs right this time!! Prototype looks good now, thx! > Just taking some baby steps - to get my feet wet so to speak... I'm working on fixing up an existing / long-standing, "unglamorous" wine bug - that is taking some "real work" now. :-) That's great to hear! Just some remarks for v3 (which should then be good to go): Am 30.05.2016 um 11:40 schrieb Rob Walker: > +CONFIGRET WINAPI CM_Get_DevNode_Status(PULONG pulStatus, PULONG pulProblemNumber, DEVINST dnDevInst, > + ULONG ulFlags) > +{ > + FIXME("%p %p 0x%08x 0x%08x: stub\n", pulStatus, pulProblemNumber, dnDevInst, ulFlags); > + return CR_FAILURE; > +} > + > +/*********************************************************************** > + * CM_Get_DevNode_Status_Ex (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Get_DevNode_Status_Ex(PULONG pulStatus, PULONG pulProblemNumber, DEVINST dnDevInst, > + ULONG ulFlags, HMACHINE hMachine) > +{ > + FIXME("%p %p 0x%08x 0x%08x %p: stub\n", pulStatus, pulProblemNumber, dnDevInst, ulFlags, hMachine); > + return CR_FAILURE; > +} Please avoid "PULONG" style variables, instead use e.g. "ULONG *status" Further we normally don't copy the variable names, because they often are camelcase and/or hungarian notation, which we avoid both for new code. I'd suggest something like: status, number, dev, flags, machine

1 0

Regression in wined3d
by Fabian Maurer June 1, 2016

June 1, 2016

Hello, I found a regression in the implementation of wined3d that causes a lot of rendering artifacts in certain games, for example the NekoPara series on steam. I uploaded a sample screenshot: http://imgur.com/cIfQDft The offending commit is 1ddf2e47e252fd30976237bd190a98b310909301 wined3d: Use immutable storage for 2D textures. After reverting that commit and it's child (4f9642d0e90b941e0316137523dbf12588c4bccc), it displays fine again. Since I don't know too much about the 3d implementation, I'd be glad to have someone help me with that issue. Fabian

2 1

Re: Broken AppDB Test Results Pages
by Jimi Huotari June 1, 2016

June 1, 2016

On 01/06/16 14:47, Rosanne DiMesio wrote: > I deleted the reports that were breaking those pages. FYI, the way to > do that is to go to the page for one of the older test reports Ah, should have thought of that. Thanks. > https://bugs.winehq.org/show_bug.cgi?id=34647 Likewise, should have guessed this is a known bug already... Apologies for the ruckus. Thank you.

1 0

Broken AppDB Test Results Pages
by Jimi Huotari June 1, 2016

June 1, 2016

Greetings! I sent two mails about this to appdb(a)winehq.org the other day, but austin987 suggested I'll mail here (and Cc jnewman), too, since it has been a few days now. So I broke a couple of pages: //appdb.winehq.org/objectManager.php?sClass=version&iId=24670 //appdb.winehq.org/objectManager.php?sClass=version&iId=24695 Using QupZilla (QtWebEngine edition), the Xinha editor took its built-in ad-block rules, with some of the style code, and included them in the code for the page, which breaks most of it (none of the test results or notes/comments\bugs show up). Loading up the form at AppDB resulted into a count of HTML: 259501, and this number goes up by about the same amount every time the form is reloaded, and (probably) all of it will be included in the code. It would be great if someone with the power to do so could undo my edits to the two pages I mentioned, as I can't do anything about it myself. :] I already reported the issue upstream of QupZilla, and a fix was quickly put in place there, but the editor itself remains vulnerable (no idea how big of an annoyance /really/ exploiting it could become). Thank you, and apologies for the inconvenience!

2 1

Re: [PATCH 2/2] msi/tests: Add test for special InstallService-ErrorControl-flag
by Hans Leidekker June 1, 2016

June 1, 2016

On Tue, 2016-05-31 at 22:44 +0200, Andreas Maier wrote: > diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c > index 243e61b..3213737 100644 > --- a/dlls/msi/tests/action.c > +++ b/dlls/msi/tests/action.c > @@ -234,7 +234,7 @@ static const char service_install2_dat[] = > "LoadOrderGroup\tDependencies\tStartName\tPassword\tArguments\tComponent_\tDescription\n" > "s72\ts255\tL255\ti4\ti4\ti4\tS255\tS255\tS255\tS255\tS255\ts72\tL255\n" > "ServiceInstall\tServiceInstall\n" > - "TestService\tTestService\tTestService\t2\t3\t0\t\t\tTestService\t\t\tservice_comp\t\n" > + "TestService\tTestService\tTestService\t2\t3\t0x8000\t\t\tTestService\t\t\tservice_comp\t\n" > "TestService4\tTestService4\tTestService4\t2\t3\t0\t\t\tTestService4\t\t\tservice_comp3\t\n"; This test fails here on Windows. You should label the fix 1/2 to correctly express the dependency.

1 0