June 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] shell32: fix out of memory errors and their underlying cause
by Nikolay Sivov June 4, 2016

June 4, 2016

Thanks. Could you please also fix buffer and 'assoc' leaks in the same patch?

1 0

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap
by Vincent Povirk June 4, 2016

June 4, 2016

We'll need it when we implement adjustable arrow caps. On Jun 3, 2016 8:34 PM, "Ken Thomases" <ken(a)codeweavers.com> wrote: On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

1 0

Re: gdiplus: Fix a typo in struct GpAdjustableArrowCap
by Ken Thomases June 4, 2016

June 4, 2016

On Jun 3, 2016, at 10:12 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > > diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h > index 10092f1..9b29d88 100644 > --- a/dlls/gdiplus/gdiplus_private.h > +++ b/dlls/gdiplus/gdiplus_private.h > @@ -314,7 +314,7 @@ struct GpCustomLineCap{ > REAL scale; > }; > > -struct GpAdustableArrowCap{ > +struct GpAdjustableArrowCap{ > GpCustomLineCap cap; > }; > Nothing uses this struct, which is evident by the fact that there are no other changes necessary along with the above change. So, why is this here, at all? Shouldn't it just be removed? -Ken

1 0

Re: mmdevapi/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23320 Your paranoid android. === w7u (32 bit capture) === capture.c:181: Test failed: Position 375 expected 0 capture.c:231: Test failed: Position 1719 expected 823 capture.c:263: Test failed: Position 1719 expected 823 capture.c:325: Test failed: Position 3063 gap 1792 capture.c:329: Test failed: GCP 11200 vs. BufferSize 21996 capture.c:349: Test failed: Position 4407 expected 3511 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5751 expected 3959 capture.c:375: Test failed: flags 1 === w8 (32 bit capture) === capture.c:325: Test failed: Position 3191 gap 1216 capture.c:349: Test failed: Position 4279 expected 3639 capture.c:374: Test failed: Position 5303 expected 4087 === w864 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:263: Test failed: Position 2167 expected 1527 capture.c:325: Test failed: Position 3127 gap 1152 capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:349: Test failed: Position 4215 expected 3575 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5303 expected 4023 capture.c:375: Test failed: flags 1 === w1064 (32 bit capture) === capture.c:181: Test failed: Position 1079 expected 0 capture.c:231: Test failed: Position 2167 expected 1527 capture.c:263: Test failed: Position 2167 expected 1527 capture.c:325: Test failed: Position 4151 gap 2176 capture.c:329: Test failed: GCP 11648 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4599 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5687 expected 5047 === w864 (64 bit capture) === capture.c:181: Test failed: Position 119 expected 0 capture.c:231: Test failed: Position 2167 expected 567 capture.c:263: Test failed: Position 2167 expected 567 capture.c:325: Test failed: Position 3191 gap 2176 capture.c:329: Test failed: GCP 13888 vs. BufferSize 21996 capture.c:349: Test failed: Position 4279 expected 3639 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 4727 expected 4087 === w1064 (64 bit capture) === capture.c:181: Test failed: Position 1143 expected 0 capture.c:231: Test failed: Position 2167 expected 1591 capture.c:263: Test failed: Position 2167 expected 1591 capture.c:325: Test failed: Position 4215 gap 2176 capture.c:329: Test failed: GCP 13440 vs. BufferSize 21996 capture.c:349: Test failed: Position 5239 expected 4663 capture.c:350: Test failed: flags 1 capture.c:374: Test failed: Position 5687 expected 5111

1 0

Re: [PATCH 2/2] msvcr120/tests: Add critical section test.
by Piotr Caban June 3, 2016

June 3, 2016

Hi, something strange happened while sending this patch. It was sent by me. Sorry for that. Piotr On 06/03/16 14:36, YongHao Hu wrote: > From: YongHao Hu <christopherwuy(a)gmail.com> > > This patch supersedes 122410. > > Signed-off-by: YongHao Hu <christopherwuy(a)gmail.com> > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/msvcr120/tests/msvcr120.c | 251 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 251 insertions(+) > > > > >

1 0

Re: [PATCH] wined3d : Set texture target of WINED3DFMT_NULL to 0
by Henri Verbeet June 3, 2016

June 3, 2016

On 2 June 2016 at 07:39, Max Qian <public(a)maxqia.com> wrote: > This fixes https://bugs.winehq.org/show_bug.cgi?id=40624 > Signed-off-by: Max Qian <public(a)maxqia.com> > --- > dlls/wined3d/context.c | 4 ++-- > dlls/wined3d/wined3d_private.h | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > The patch got wrapped, please use git send-email for submitting patches. Regardless, I don't think this is an improvement over Józef's patch. (Which I think would be fine for fixing the regression, even if we want to improve the way WINED3DFMT_NULL is handled in general.)

1 0

Re: user32/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23303 Your paranoid android. === w864 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:10057: Test failed: SendMessageTimeout succeeded msg.c:10058: Test failed: WmEmptySeq: 0: the msg sequence is not complete: expected 0000 - actual 0400 === w1064 (64 bit msg) === msg.c:6484: Test failed: Update region shouldn't be empty msg.c:6718: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6720: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:6490: Test failed: Regions are different msg.c:7440: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 001a

1 0

Re: urlmon/tests: Fix a typo in ok() message
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23302 Your paranoid android. === w1064 (32 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon" === w1064 (64 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon"

1 0

Re: kernel32/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23301 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: hlink/tests: Fix a typo in ok() messages
by Marvin June 3, 2016

June 3, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23300 Your paranoid android. === w1064 (32 bit hlink) === hlink.c:414: Test failed: url only: Saved data differs hlink.c:414: Test failed: url + friendly name: Saved data differs hlink.c:414: Test failed: url + friendly_name + location: Saved data differs hlink.c:414: Test failed: url + target frame name: Saved data differs === w1064 (64 bit hlink) === hlink.c:414: Test failed: url only: Saved data differs hlink.c:414: Test failed: url + friendly name: Saved data differs hlink.c:414: Test failed: url + friendly_name + location: Saved data differs hlink.c:414: Test failed: url + target frame name: Saved data differs

1 0