June 2016 - Wine-Devel - list.winehq.org

Re: [v1 1/2] dinput/joystick_osx.c: debugstr_device prints location ID
by Ken Thomases June 29, 2016

June 29, 2016

On Jun 24, 2016, at 8:33 PM, David Lawrie <david.dljunk(a)gmail.com> wrote: > > +static Boolean IOHIDDevice_GetLongProperty(IOHIDDeviceRef inIOHIDDeviceRef, CFStringRef inKey, long * outValue) Don't name your functions as though they were Apple's. Apple "owns" the namespace of identifiers starting with "IOHIDDevice". In general, just use simple lowercase-and-underscores names unless there's a strong reason not to. Something like "get_device_property_long". Same goes for the parameters: "key" and "out_value" or the like. > +{ > + Boolean result = FALSE; > + CFTypeRef tCFTypeRef; Don't use this naming convention either (is that Hungarian notation?). Why is the type repeated in the variable name? What does the "t" prefix signify. Just call this "value" or something. > + > + if (inIOHIDDeviceRef) { > + assert(IOHIDDeviceGetTypeID() == CFGetTypeID(inIOHIDDeviceRef)); > + > + tCFTypeRef = IOHIDDeviceGetProperty(inIOHIDDeviceRef, inKey); > + > + if ( tCFTypeRef ) { > + /* if this is a number */ > + if (CFNumberGetTypeID() == CFGetTypeID(tCFTypeRef)) { > + /* get it's value */ What do these comments add? > + result = CFNumberGetValue((CFNumberRef)tCFTypeRef, kCFNumberSInt32Type, outValue); "long" and "SInt32" don't match reliably. Why not kCFNumberLongType? > +long IOHIDDevice_GetLocationID(IOHIDDeviceRef inIOHIDDeviceRef) Naming conventions here, too. > +{ > + long result = 0; > + (void)IOHIDDevice_GetLongProperty(inIOHIDDeviceRef, CFSTR(kIOHIDLocationIDKey), &result); I don't think we generally use the cast-to-void thing for unused return values in Wine. -Ken

1 0

Re: shell32/tests: Avoid casts from a COM object to an iface.
by Marvin June 29, 2016

June 29, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23879 Your paranoid android. === w1064 (32 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057 === w1064 (64 bit shlfolder) === shlfolder.c:1591: Test failed: IShellFolder_GetDisplayNameOf(NULL) failed! hr = 80070057

2 1

Re: [PATCH] winex11: fix destroying of top-level windows
by Alexandre Julliard June 28, 2016

June 28, 2016

Miklós Máté <mtmkls(a)gmail.com> writes: > Fixes https://bugs.winehq.org/show_bug.cgi?id=40767 > > Signed-off-by: Miklós Máté <mtmkls(a)gmail.com> > --- > dlls/winex11.drv/opengl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c > index d89a193..27ddd79 100644 > --- a/dlls/winex11.drv/opengl.c > +++ b/dlls/winex11.drv/opengl.c > @@ -1314,6 +1314,9 @@ static void free_gl_drawable( struct gl_drawable *gl ) > { > switch (gl->type) > { > + case DC_GL_WINDOW: > + pglXDestroyWindow( gdi_display, gl->drawable ); > + break; Actually this one has some issues too: ../../../tools/runtest -q -P wine -T ../../.. -M d3d9.dll -p d3d9_test.exe.so device && touch device.ok device.c:2250: Tests skipped: could not create device, IDirect3D9_CreateDevice returned 0x8876086c device.c:6312: Tests skipped: This GPU supports SM3, skipping unsupported shader test. device.c:6724: Tests skipped: D3DFMT_A32B32G32R32F supports filtering, skipping tests. device.c:7747: Tests skipped: Failed to create cube texture for format R8G8B8 (hr 0x8876086c), skipping tests. device.c:8450: Tests skipped: Dynamic D3DFMT_YUY2 textures not supported, skipping mipmap test. device.c:8450: Tests skipped: Dynamic D3DFMT_UYVY textures not supported, skipping mipmap test. X Error of failed request: GLXBadWindow Major opcode of failed request: 155 (GLX) Minor opcode of failed request: 32 (X_GLXDestroyWindow) Serial number of failed request: 8900 Current serial number in output stream: 8901 Makefile:208: recipe for target 'device.ok' failed -- Alexandre Julliard julliard(a)winehq.org

4 6

Re: d3dx10: Implement D3DX10CompileFromMemory.
by Matteo Bruni June 28, 2016

June 28, 2016

2016-06-27 21:49 GMT+02:00 Andrey Gusev <andrey.goosev(a)gmail.com>: > + TRACE("data %s, data_size %lu, filename %s, defines %p, include %p, entry_point %s, target %s, " > + "sflags %#x, eflage %#x, pump %p, shader %p, error_messages %p, hresult %p.\n", "eflage" typo. > diff --git a/dlls/d3dx10_43/d3dx10_43_main.c b/dlls/d3dx10_43/d3dx10_43_main.c > index 0c1ff80..fe56ee0 100644 > --- a/dlls/d3dx10_43/d3dx10_43_main.c > +++ b/dlls/d3dx10_43/d3dx10_43_main.c > @@ -37,6 +37,8 @@ > #include "d3dx10core.h" > #include "d3dx10tex.h" > > +#include "wine/debug.h" That is already included a few lines above. Looks good otherwise.

1 0

Re: [d3dcompiler] - add missing fields to d3dcompiler_shader_reflection
by Matteo Bruni June 28, 2016

June 28, 2016

2016-06-23 1:45 GMT+02:00 Vijay Kiran Kamuju <infyquest(a)gmail.com>: > [d3dcompiler] - add missing fields to d3dcompiler_shader_reflection > > This add missing fields to the d3dcompiler_shader_reflection based on > http://timjones.tw/blog/archive/2015/09/02/parsing-direct3d-shader-bytecode > https://msdn.microsoft.com/en-us/library/windows/desktop/ff476590(v=vs.85).… > https://msdn.microsoft.com/en-us/library/windows/desktop/bb694550(v=vs.85).… > https://msdn.microsoft.com/en-us/library/windows/desktop/bb172432(v=vs.85).… > https://msdn.microsoft.com/en-us/library/windows/desktop/ff476209(v=vs.85).… Thank you for the links, that saved me some time to have to look them up. > + UINT sample_frequency_shader; As far as I understand, that would be better served by a BOOL. > UINT dcl_count; > + UINT def_count; Nitpick but def_count is right before dcl_count in both D3D11_SHADER_DESC and in the shader bytecode, it would be nice to have the same order everywhere. We have tests for this in d3dcompiler_43/tests/reflection.c. Can you please add some tests for those new fields too? Notice that you don't necessarily need n separate new tests for each of the n new features. The patch subject should be something like "d3dcompiler: Add d3d11 fields to struct d3dcompiler_shader_reflection." i.e. no square brackets for the dll prefix and put a colon after it. Also, while not strictly required, it's encouraged to use git send-email, it will inline the patch without wrapping and generally take care of most of the formatting details, assuming git is configured correctly.

1 0

Re: [v2 PATCH] d3dx9_36: Stop crash when displaying effect errors
by Matteo Bruni June 28, 2016

June 28, 2016

2016-06-22 13:10 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > if (temp_errors) > - TRACE("%s\n", (char *)ID3D10Blob_GetBufferPointer(temp_errors)); > + { > + const char *p = ID3D10Blob_GetBufferPointer(temp_errors); > + SIZE_T size = ID3D10Blob_GetBufferSize(temp_errors); > + const char *end = p + size; > + const char *line = p; > + > + while (p != end) > + { > + if (*p == '\n') > + { > + UINT len = p - line; > + if (len && *(p - 1) == '\r') --len; > + TRACE("%s\n", debugstr_an(line, len)); > + line = ++p; > + } > + else ++p; > + } > + if (line != p) > + TRACE("%s\n", debugstr_an(line, p - line)); > + } This only breaks at '\n', which might still be too much if the lines are particularly long. I also wrote a patch for this a few days ago. I'm going to send it to wine-patches in a bit, I'd appreciate if you can test if it works for you or point out any issue with it.

1 0

Re: include: Add missing interface declaration.
by Nikolay Sivov June 28, 2016

June 28, 2016

> interface IWbemContext; > interface IWbemServices; > +interface IWbemLocator; > interface IWbemStatusCodeText; > interface IWbemCallResult; > interface IWbemObjectSink; Why do you need this? IWbemLocator is fully defined later in this file.

1 0

Re: [PATCH 6/7] d3drm: Implement IDirect3DRMViewport*::Init.
by Stefan Dösinger June 27, 2016

June 27, 2016

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta: > + if (FAILED(hr = IDirect3DRMDevice_QueryInterface(device, &IID_IDirect3DRMDevice3, (void **)&device3))) > + return hr; > + > + if (FAILED(hr = IDirect3DRMFrame_QueryInterface(camera, &IID_IDirect3DRMFrame3, (void **)&camera3))) > + { > + IDirect3DRMDevice3_Release(device3); > + return hr; > + } > + IDirect3DRMDevice_Release(device); > + IDirect3DRMFrame_Release(camera); > + > + return d3drm_viewport2_Init(&viewport->IDirect3DRMViewport2_iface, device3, camera3, x, y, width, height); This has the same problem as the first version of your frame thunks: You get "device3", but then you release "device", to which you don't hold a reference. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcFfoAAoJEN0/YqbEcdMweH8P/RBg+lEvXxGES0C1Uo5aN6Ht E0TOftji/AaGrVcaoHLWMsl30/GUpmh+iRdM19ZHwL0vey3yKKdTmFlt4tMrG5aP LLHLlxRqcJt1h+MREvMYb7JJjCAMcR/2Bn63nxWZpZ+PncQo1H90ZsBHCrd4Y707 JukrA3QfPm9cyXiX/ER8cj7QgpnNsk5y8ZXgbdtDDGOzShf2OSoslU5ivQQsmZ4W 2fiJWOeWdpi3P9Fh6EUTDOwUf5Rnj7mBYb3KFASc9o0VZXHuI/f35LGG9AdNkSxs lf6RbPDcXxPQqUxlz0VnmS/31/oGb0pDczESx+alDU9n29tWPANY+yBGUmDStyJ0 /RHl2qpZJMs/lQpk9UQ/RpvuVdZfLVxgftqyZuoWT4EfW5iseOlCytmsJEG1AVpd BKAMFRbueGhPYfUcuLAH1GL4keRg7P3QUd36MlR0wWVdYGtMWrbQL+6SrHT6r75C QmXU9mTJMTleA/Yzskenm71Tz9/wbwavYjUMaEQp3+7OKrG0Zqnt4foh2GpNUT+6 M7jxfSSng4+irWvxf3ZKdpjfGNHRn1ZhRKrEpxKQptiGlFvYSMDy7tHtyybK2MbB h8CO19YAzcVjfFHj5sRSYtZIHdVm5aG5FJLfVm9UPBA7xT2l9b6EgqXEhLTVLYC6 /TSyEFgT5j+DkKf6DCm+ =0tcs -----END PGP SIGNATURE-----

2 3

OSSCOM 2016 Conference - Dec, 2016 (Call for Papers)
by 2nd International Conference on Open Source Software Computing June 27, 2016

June 27, 2016

OSSCOM 2016 Call for Proposals/ Papers OSSCOM 2016 The 2nd International Conference on Open Source Software Computing 1st - 3rd December 2016 Lebanese University, Beirut - Lebanon http://mailer.tagorg.com/lists/lt.php?id=bB0DBlQZUAJSTlQNAFIEAA Partially funded by EC - Tempus and technically sponsored by IEEE Objectives To promote opportunities for cooperation towards enabling OSS key technologies, building cross-cutting sciences, and driving disruptive innovations; to disseminate research on technology and applications of open source software computing; and to expand the framework of effective participation of universities in developing OSS industry through incubators and business accelerators. Structure - Keynotes - Panel and roundtable discussions - Presentation sessions - Industry and technology discussions - Consultation meetings, focus groups, and roundtables - Best practice showcases and practical demonstration - Workshops Submission Deadline 1st September, 2016 (Manuscripts) 1st October, 2016 (Proposals) Topics of Interest Track 1: Systems Software - Operating systems: Linux Kernel, Server and Desktop Linux: RedHat, Debian, Slackware, Caldera, SuSe, Fedora - Distributed Operating systems: Open source platforms and software for the cloud platform as a service (PaaS), software as a service (SaaS), and infrastructure as a service (IaaS). Open stack, Open-source software in scientific computing including clouds, grids and HPCs - Embedded and Realtime Operating systems - Ubiquitous mobile computing and technologies: middleware, operating system (e.g. Android), new I/O and user interfaces, mobile protocols Track 2: Applications and Services - Open-source software services and applications in energy, environment, education, health, climate, water, agriculture, biology, economy, medicine and other pressing global issues and problems - Open-source software for e-Services, including e-Government, e-Libraries, e-Learning and any e-* - Open-source software for Smart Education, Smart Cities, Smart Power Grids, Smart Transportation - Open Source applications for mobile and tablets Track 3: Networking and Security - Open source network simulation/emulations tools - Open source platforms for network security deployment, testing and verification - Network and security open source management software Track 4: Open Source Development and Support - Perspectives on open-source software development and services, including challenges, operation, sustainability, funding, governance, business models, and security - National, regional and international organizations and their role in funding and supporting open-source software applications in research and education - Collaborative projects and initiatives in research and education at national, regional and global levels - Research and education challenges and open access paradigm - Business models for open-source software development and services Track 5: Software Engineering This track will bring together researchers, students and industry experts from diverse areas associated with software engineering who are utilizing, developing or even improving open source software systems during their research and experiments. Software Engineering influences all aspects of computer science research and touches every software researchers and practitioners. There are diverse Free and open-source software that could be utilized in many fields under the umbrella of Software Engineering such as but not limited to: - Software Process Models - Software Process Improvement - Software Architecture - Component-Based Software Engineering - Software Verification and Validation - Model Checking - Software Impact Analysis - Design Patterns and Frameworks - Model Driven Architecture - Modeling with UML - Reusable Software and Metrics - Reverse Engineering, Re-engineering - Adaptive Software - Software Define Network - Data Mining and Machine Learning - Safety and Security in Critical Software Conference Venue Lebanese University, Beirut - Lebanon Submit a Participation <http://mailer.tagorg.com/lists/lt.php?id=bB0DB1EZUAJSTlQNAFIEAA> Language English Registration Fees OSSCOM members 50 Euro OSSCOM non-members 100 Euro Authors and Speakers 50 Euro Students Free All papers will be peer-reviewed and selected papers will be published in the conference proceedings and submitted to IEEE Explore. Partners and Organisers - Hochschule Bonn-Rhein-Sieg University of Applied Sciences, Germany - German Jordanian University, Jordan - Lebanese University, Lebanon - Brunel University, United Kingdom - Yarmouk University, Jordan - Notre Dame University, Lebanon - University of Castilla-La Mancha, Spain - Tarent AG, Germany - Talal Abu-Ghazaleh Information Technology International, Jordan - Information Management Ltd, Lebanon - Le Cnam Liban Important Dates 1st Sept, 2016 Manuscript Submission Deadline 1st Oct, 2016 Acceptance Notification 15th Nov 2016 Registration Deadline 1st – 3rd Dec 2016 OSSCOM 2016 Conference For more information and paper submission, please contact Paper Submission: - Please submit your manuscript or proposal at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBVQZUAJSTlQNAFIEAA Registration: - Please register for OSSCOM 2016 conference at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBlYZUAJSTlQNAFIEAA Publicity: - Dr. Yaser Jararweh, yijararweh(a)just.edu.jo <mailto:yijararweh(a)just.edu.jo> - Dr. Muhannad Quwaider, mqquwaider(a)just.edu.jo <mailto:mqquwaider(a)just.edu.jo> More Information: - Please contact us through our email: office(a)osscom.org <mailto:office(a)osscom.org> All information is available at: http://mailer.tagorg.com/lists/lt.php?id=bB0DBlcZUAJSTlQNAFIEAA -- This message was sent to wine-devel(a)winehq.org by Office(a)osscom.org To forward this message, please do not use the forward button of your email application, because this message was made specifically for you only. Instead use the forward page <http://mailer.tagorg.com/lists/lt.php?id=bB0DBVcZUAJSTlQNAFIEAA> in our newsletter system. To change your details and to choose which lists to be subscribed to, visit your personal preferences page <http://mailer.tagorg.com/lists/lt.php?id=bB0DS1dUUE9WClYGBlc> Or you can opt-out completely <http://mailer.tagorg.com/lists/lt.php?id=bB0CS1dUUE9WClYGBlc> from all future mailings. -- powered by phpList, www.phplist.com --

1 0

Host_Quit implementation in wscript
by Thiago Barbato June 27, 2016

June 27, 2016

I tried running a .js with a WScript.Quit() call and noticed it isn't implemented yet in programs/wscript/host.c. Would a simple ExitProcess( ExitCode ) do the job or are there cases where this would be the wrong thing to do?

2 1